JasonLi-cn opened a new pull request, #11758:
URL: https://github.com/apache/datafusion/pull/11758
## Which issue does this PR close?
Closes https://github.com/apache/datafusion/issues/9562
## Rationale for this change
## What changes are included in this
waynexia opened a new pull request, #11759:
URL: https://github.com/apache/datafusion/pull/11759
## Which issue does this PR close?
Related to https://github.com/apache/datafusion/issues/11375
## Rationale for this change
Try to break large `lib.rs` into s
Dandandan opened a new pull request, #11760:
URL: https://github.com/apache/datafusion/pull/11760
## Which issue does this PR close?
This was failing in an earlier version we were using (39) but is fixed more
recently.
Adding test to make sure this doesn't break in the futu
jonahgao commented on code in PR #11729:
URL: https://github.com/apache/datafusion/pull/11729#discussion_r1699854883
##
datafusion/functions-aggregate/src/string_agg.rs:
##
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-//
lewiszlw commented on issue #11707:
URL: https://github.com/apache/datafusion/issues/11707#issuecomment-2262658651
How to handle aliased aggr expr? Keep an optional name param in
`create_aggregate_expr` or Change `aggr_expr` field of `AggregateExec` from
`Vec>` to `Vec<(Arc, String)>`?
--
alamb commented on code in PR #11627:
URL: https://github.com/apache/datafusion/pull/11627#discussion_r1699904215
##
datafusion/functions-aggregate/src/count.rs:
##
@@ -433,6 +433,49 @@ impl GroupsAccumulator for CountGroupsAccumulator {
Ok(vec![Arc::new(counts) as Arra
alamb commented on code in PR #11627:
URL: https://github.com/apache/datafusion/pull/11627#discussion_r1699904215
##
datafusion/functions-aggregate/src/count.rs:
##
@@ -433,6 +433,49 @@ impl GroupsAccumulator for CountGroupsAccumulator {
Ok(vec![Arc::new(counts) as Arra
xinlifoobar opened a new pull request, #11761:
URL: https://github.com/apache/datafusion/pull/11761
## Which issue does this PR close?
Part of #11725
## Rationale for this change
## What changes are included in this PR?
## Are these changes
xinlifoobar commented on code in PR #11761:
URL: https://github.com/apache/datafusion/pull/11761#discussion_r1699923583
##
datafusion/expr/src/function.rs:
##
@@ -54,9 +55,6 @@ pub struct AccumulatorArgs<'a> {
/// The return type of the aggregate function.
Review Comment:
alamb commented on PR #11678:
URL: https://github.com/apache/datafusion/pull/11678#issuecomment-2262710828
Thank you for the review @mustafasrepo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb merged PR #11678:
URL: https://github.com/apache/datafusion/pull/11678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11675: `pushdown_sorts` pushes a SortExec through a node in
violation of its stated input ordering requirements
URL: https://github.com/apache/datafusion/issues/11675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
alamb closed pull request #11493: Test + workaround for `SanityCheckPlan` error
URL: https://github.com/apache/datafusion/pull/11493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on PR #11708:
URL: https://github.com/apache/datafusion/pull/11708#issuecomment-2262720435
If it turns out that reusing hash values isn't a good idea, I think we could
close the ticket as "won't do"
Another thought, similarly to what @andygrove has been exploring in
h
alamb commented on issue #11680:
URL: https://github.com/apache/datafusion/issues/11680#issuecomment-2262722015
@Dandandan has a good point on
https://github.com/apache/datafusion/pull/11708#issuecomment-2262084412 that is
some cases (like a network shuffle) passing the hash values might b
alamb commented on PR #11708:
URL: https://github.com/apache/datafusion/pull/11708#issuecomment-2262723812
Another point is that generating the hash value is most expensive for string
columns -- so maybe we could only reuse hash values when there are string
columns as part of the groupby ex
alamb commented on code in PR #11479:
URL: https://github.com/apache/datafusion/pull/11479#discussion_r1699984627
##
datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs:
##
@@ -356,20 +356,24 @@ impl<'a> RowGroupPruningStatistics<'a> {
&'a self,
alamb commented on PR #11479:
URL: https://github.com/apache/datafusion/pull/11479#issuecomment-2262805898
Thank you for the reviews @Ted-Jiang and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
alamb merged PR #11479:
URL: https://github.com/apache/datafusion/pull/11479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11000: Reduce test duplication in tests for data page
stattistics
URL: https://github.com/apache/datafusion/issues/11000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
alamb merged PR #11703:
URL: https://github.com/apache/datafusion/pull/11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11702: Rename RepartitionExec metric `repart_time` to
`repartition_time`
URL: https://github.com/apache/datafusion/issues/11702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on PR #11703:
URL: https://github.com/apache/datafusion/pull/11703#issuecomment-2262808454
It seems people like this naming better, so I will merge it in. Thanks
everyone for your comments and review
--
This is an automated message from the Apache Git Service.
To respond t
alamb merged PR #11744:
URL: https://github.com/apache/datafusion/pull/11744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11743: `TableScan` plan without projection is not converted
correctly to a sql statement
URL: https://github.com/apache/datafusion/issues/11743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on PR #11744:
URL: https://github.com/apache/datafusion/pull/11744#issuecomment-2262813214
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
jayzhan211 commented on issue #11707:
URL: https://github.com/apache/datafusion/issues/11707#issuecomment-2262827066
It's not clear to me why do we need to handle aliased aggr expr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jayzhan211 commented on PR #11708:
URL: https://github.com/apache/datafusion/pull/11708#issuecomment-2262836799
Let's find out if combining group + repartition is reasonable, if yes,
whether to reuse hash should be trivial since we don't need to convert it to
record batch anymore
--
This
alamb commented on issue #11710:
URL: https://github.com/apache/datafusion/issues/11710#issuecomment-2262855223
REview Queue:
arrow-rs
- [ ] Take kernel speed in arrow-rs:
https://github.com/apache/arrow-rs/pull/6168
- [ ] bytestrema split: https://github.com/apache/arrow-rs/pu
alamb merged PR #11254:
URL: https://github.com/apache/datafusion/pull/11254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #11254:
URL: https://github.com/apache/datafusion/pull/11254#issuecomment-2262857165
> lgtm thanks @alamb awesome clean up. errors macros can be added later
I was messing around with the PR anyways so I made the changes to use error
macros.
Thanks again @c
alamb commented on PR #11729:
URL: https://github.com/apache/datafusion/pull/11729#issuecomment-2262857833
Thanks @jonahgao for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb merged PR #11729:
URL: https://github.com/apache/datafusion/pull/11729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #11728: doc warnings about private items
URL: https://github.com/apache/datafusion/issues/11728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
alamb merged PR #11760:
URL: https://github.com/apache/datafusion/pull/11760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #11759:
URL: https://github.com/apache/datafusion/pull/11759#discussion_r1700022065
##
datafusion/physical-plan/src/lib.rs:
##
@@ -14,46 +14,36 @@
// KIND, either express or implied. See the License for the
// specific language governing permissi
timsaucer commented on issue #781:
URL:
https://github.com/apache/datafusion-python/issues/781#issuecomment-2262912815
Just for my own education, what are the use cases for invoking
`.to_variant()`? I came across these when I was working on python wrapper
functions and I don't know how peo
jayzhan211 opened a new pull request, #11762:
URL: https://github.com/apache/datafusion/pull/11762
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
jayzhan211 commented on issue #11680:
URL: https://github.com/apache/datafusion/issues/11680#issuecomment-2262949557
I found I got performance boost for clickbench Q17 just by enforcing single
mode for group by, interesting
```rust
Comparing main and single-multi-groupby
---
edmondop commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1700094985
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -15,103 +15,165 @@
// specific language governing permissions and limitations
// under the License.
-/
jayzhan211 commented on code in PR #11761:
URL: https://github.com/apache/datafusion/pull/11761#discussion_r1700124481
##
datafusion/expr/src/function.rs:
##
@@ -54,9 +55,6 @@ pub struct AccumulatorArgs<'a> {
/// The return type of the aggregate function.
pub data_type
jayzhan211 commented on PR #11666:
URL: https://github.com/apache/datafusion/pull/11666#issuecomment-2263026860
> I think `schema` is what makes sense as `dfschema` is mostly a logical
thing in my mind (as it has a relation name).
@xinlifoobar I think it is not clear whether we should
alamb opened a new pull request, #11763:
URL: https://github.com/apache/datafusion/pull/11763
## Which issue does this PR close?
Related to https://github.com/apache/datafusion/pull/11723
## Rationale for this change
While working to enable `StringView` by default I h
jayzhan211 commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1700177718
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -15,103 +15,165 @@
// specific language governing permissions and limitations
// under the License.
andygrove merged PR #727:
URL: https://github.com/apache/datafusion-comet/pull/727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
viirya closed issue #749: Subquery execution under
CometTakeOrderedAndProjectExec fails
URL: https://github.com/apache/datafusion-comet/issues/749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
viirya merged PR #748:
URL: https://github.com/apache/datafusion-comet/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
viirya commented on PR #748:
URL: https://github.com/apache/datafusion-comet/pull/748#issuecomment-2263154158
Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
viirya merged PR #738:
URL: https://github.com/apache/datafusion-comet/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
viirya closed issue #737: [Doc] Update outdated
`spark.comet.columnar.shuffle.enabled` configuration doc
URL: https://github.com/apache/datafusion-comet/issues/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
viirya commented on PR #738:
URL: https://github.com/apache/datafusion-comet/pull/738#issuecomment-2263156002
Thanks @wForget @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
edmondop commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2263194246
@jayzhan211 fyi all the tests in scalar subquery failed with the stubs, I
restored import that used the real implementation
--
This is an automated message from the Apache Git Se
andygrove commented on issue #745:
URL:
https://github.com/apache/datafusion-comet/issues/745#issuecomment-2263196669
This paper may have useful information:
"Filter Representation in Vectorized Query Execution"
https://db.cs.cmu.edu/papers/2021/ngom-damon2021.pdf
--
This is an
jayzhan211 commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2263217466
> @jayzhan211 fyi all the tests in scalar subquery failed with the stubs, I
restored import that used the real implementation
wait, we should use stubs instead of the real f
andygrove commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1700316675
##
spark/src/main/scala/org/apache/spark/sql/comet/CometRowToColumnarExec.scala:
##
@@ -60,8 +62,17 @@ case class CometRowToColumnarExec(child: SparkPlan)
jayzhan211 commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2263247832
You use the name "min" in Max, and "max" in Min for stubs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
edmondop commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2263258794
> > @jayzhan211 fyi all the tests in scalar subquery failed with the stubs,
I restored import that used the real implementation
>
> wait, we should use stubs instead of the re
andygrove commented on PR #734:
URL: https://github.com/apache/datafusion-comet/pull/734#issuecomment-2263264565
Performance is ok, but not great.
```
OpenJDK 64-Bit Server VM 11.0.24+8-post-Ubuntu-1ubuntu322.04 on Linux
6.5.0-41-generic
AMD Ryzen 9 7950X3D 16-Core Processor
andygrove merged PR #770:
URL: https://github.com/apache/datafusion-python/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove merged PR #768:
URL: https://github.com/apache/datafusion-python/pull/768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove merged PR #782:
URL: https://github.com/apache/datafusion-python/pull/782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove commented on PR #734:
URL: https://github.com/apache/datafusion-comet/pull/734#issuecomment-2263287666
microbenchmark results:
```
OpenJDK 64-Bit Server VM 11.0.24+8-post-Ubuntu-1ubuntu322.04 on Linux
6.5.0-41-generic
AMD Ryzen 9 7950X3D 16-Core Processor
TPCDS Micr
andygrove merged PR #704:
URL: https://github.com/apache/datafusion-comet/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
andygrove closed issue #645: Re-implement support for count in window aggregate
URL: https://github.com/apache/datafusion-comet/issues/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove merged PR #736:
URL: https://github.com/apache/datafusion-comet/pull/736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
andygrove merged PR #723:
URL: https://github.com/apache/datafusion-comet/pull/723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
jayzhan211 commented on PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#issuecomment-2263310385
> > > @jayzhan211 fyi all the tests in scalar subquery failed with the
stubs, I restored import that used the real implementation
> >
> >
> > wait, we should use stubs i
alamb merged PR #11665:
URL: https://github.com/apache/datafusion/pull/11665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #11757:
URL: https://github.com/apache/datafusion/pull/11757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
b4l opened a new issue, #11764:
URL: https://github.com/apache/datafusion/issues/11764
### Describe the bug
When aggregating a `Float64` type column, an internal error occurs with the
message in the title.
### To Reproduce
```rust
df.aggregate(vec![], vec as item_detail
FROM item;
```
alamb opened a new issue, #11766:
URL: https://github.com/apache/datafusion/issues/11766
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
```shell
datafusion-cli
```
Then run
```sql
DataFusion CLI v40.0.0
andygrove opened a new issue, #751:
URL: https://github.com/apache/datafusion-comet/issues/751
### Describe the bug
I noticed this while running some benchmarks. I assume that this is a
side-effect of the changes in
https://github.com/apache/datafusion-comet/pull/723.
We may w
Kimahriman commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1700429573
##
native/spark-expr/src/structs.rs:
##
@@ -125,3 +125,103 @@ impl PartialEq for CreateNamedStruct {
.unwrap_or(false)
}
}
+
+#[derive(Debu
Kimahriman commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1700431011
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -59,12 +59,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde wit
comphead commented on code in PR #11763:
URL: https://github.com/apache/datafusion/pull/11763#discussion_r1700431300
##
datafusion/sqllogictest/test_files/clickbench.slt:
##
@@ -274,5 +274,23 @@ query PI
SELECT DATE_TRUNC('minute', to_timestamp_seconds("EventTime")) AS M, COUNT
Kimahriman commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1700431812
##
spark/src/main/scala/org/apache/spark/sql/comet/CometBatchScanExec.scala:
##
@@ -152,3 +153,17 @@ case class CometBatchScanExec(wrapped: BatchScanExec,
ru
Kimahriman commented on code in PR #731:
URL: https://github.com/apache/datafusion-comet/pull/731#discussion_r1700432052
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1756,4 +1756,21 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
notfilippo commented on issue #11513:
URL: https://github.com/apache/datafusion/issues/11513#issuecomment-2263436262
This past week I've started some work on transitioning Scalar Types to being
strictly logical. Most of the refactoring work is done and now I'm reworking
some of the casting
alamb opened a new issue, #11767:
URL: https://github.com/apache/datafusion/issues/11767
**Describe the bug**
I found one of the clickbench extended queries panics when using StringView
-- https://github.com/apache/datafusion/pull/11723
**To Reproduce**
```
> create table foo
alamb commented on code in PR #11763:
URL: https://github.com/apache/datafusion/pull/11763#discussion_r1700492887
##
datafusion/sqllogictest/test_files/clickbench.slt:
##
@@ -274,5 +274,23 @@ query PI
SELECT DATE_TRUNC('minute', to_timestamp_seconds("EventTime")) AS M, COUNT(*)
alamb merged PR #11763:
URL: https://github.com/apache/datafusion/pull/11763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #11763:
URL: https://github.com/apache/datafusion/pull/11763#issuecomment-2263493350
Thanks for the review @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
andygrove opened a new pull request, #752:
URL: https://github.com/apache/datafusion-comet/pull/752
## Which issue does this PR close?
N/A
## Rationale for this change
Many tests use the following pattern to cover testing with
dictionary-encoded data.
andygrove opened a new issue, #753:
URL: https://github.com/apache/datafusion-comet/issues/753
### Describe the bug
Many tests use the following pattern to cover testing with
dictionary-encoded data.
```scala
Seq("true", "false").foreach { dictionary =>
withPa
XiangpengHao commented on issue #11767:
URL: https://github.com/apache/datafusion/issues/11767#issuecomment-2263518796
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
XiangpengHao opened a new pull request, #11768:
URL: https://github.com/apache/datafusion/pull/11768
## Which issue does this PR close?
Closes #11767
## Rationale for this change
It is a typo
## What changes are included in this PR?
## Are th
parthchandra commented on issue #751:
URL:
https://github.com/apache/datafusion-comet/issues/751#issuecomment-2263569717
I don't think reverting this is needed.
This warning can be suppressed with the JVM option
[--add-opens](https://docs.oracle.com/en/java/javase/17/migrate/migrating-j
alamb commented on PR #11768:
URL: https://github.com/apache/datafusion/pull/11768#issuecomment-2263581921
Thank you @XiangpengHao -- I ahve some tests written for this that I will
push to this branch
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on code in PR #11768:
URL: https://github.com/apache/datafusion/pull/11768#discussion_r1700549078
##
datafusion/functions-aggregate/src/count.rs:
##
@@ -237,14 +237,17 @@ impl AggregateUDFImpl for Count {
Box::new(BytesDistinctCountAccumulator::
XiangpengHao commented on PR #11768:
URL: https://github.com/apache/datafusion/pull/11768#issuecomment-2263635809
Do you @alamb have any thoughts on why clickbench query 5 won't previously
panic?
```sql
SELECT COUNT(DISTINCT "SearchPhrase") FROM hits;
```
I find only whe
dharanad commented on issue #11766:
URL: https://github.com/apache/datafusion/issues/11766#issuecomment-2263646758
i'm really interested in working on this issue. Feeling little doubtful, but
let me try. I'm might seek some help, if not i will unassign myself .
--
This is an automated mes
Dandandan opened a new pull request, #11769:
URL: https://github.com/apache/datafusion/pull/11769
## Which issue does this PR close?
Some minor refactoring
* Change count to be of type `u64`
* Some small other misc type improvements
## Rationale for this change
kazuyukitanimura commented on PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741#issuecomment-2263656950
Thank you @andygrove merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kazuyukitanimura merged PR #741:
URL: https://github.com/apache/datafusion-comet/pull/741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
alamb commented on PR #11768:
URL: https://github.com/apache/datafusion/pull/11768#issuecomment-2263684224
> Do you @alamb have any thoughts on why clickbench query 5 won't previously
panic?
Yes, I think it is because
```
SELECT COUNT(DISTINCT "SearchPhrase") FROM hits;
```
XiangpengHao commented on PR #11768:
URL: https://github.com/apache/datafusion/pull/11768#issuecomment-2263689951
> Is rewritten to a group by without distinct here
I see, that makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 170 matches
Mail list logo
