andygrove opened a new issue, #753:
URL: https://github.com/apache/datafusion-comet/issues/753

   ### Describe the bug
   
   Many tests use the following pattern to cover testing with 
dictionary-encoded data.
   
   ```scala
       Seq("true", "false").foreach { dictionary =>
           withParquetTable(
             (-5 until 5).map(i => (i.toDouble + 0.3, i.toDouble + 0.8)),
             "tbl",
             withDictionary = dictionary.toBoolean) {
   ```
   
   However, in many cases, including this example, the data does not contain 
repeated values and therefore does not cause any dictionary-encoded arrays to 
be created. 
   
   PR https://github.com/apache/datafusion-comet/pull/752 adds an assertion to 
detect such cases and updates some tests to stop testing with `withDictionary = 
true`, linking to this issue for tracking.
   
   We can close this issue when these tests have been updated to actually test 
dictionary-encoded inputs.
   
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to