Re: [PATCH v3 0/8] sequencer: don't fork git commit

2017-11-18 Thread Phillip Wood
On 18/11/17 03:57, Junio C Hamano wrote: > Junio C Hamano writes: > >> Phillip Wood writes: >> >>> From: Phillip Wood >>> >>> I've updated these based on the feedback for v2. I've dropped the >>> patch that stopped print_commit_summary() from dying as I think it is >>> better to die than return

Re: [PATCH v3 0/8] sequencer: don't fork git commit

2017-11-18 Thread Phillip Wood
On 18/11/17 03:57, Junio C Hamano wrote: > Junio C Hamano writes: > >> Phillip Wood writes: >> >>> From: Phillip Wood >>> >>> I've updated these based on the feedback for v2. I've dropped the >>> patch that stopped print_commit_summary() from dying as I think it is >>> better to die than return

Re: [PATCH v3 0/8] sequencer: don't fork git commit

2017-11-17 Thread Junio C Hamano
Junio C Hamano writes: > Phillip Wood writes: > >> From: Phillip Wood >> >> I've updated these based on the feedback for v2. I've dropped the >> patch that stopped print_commit_summary() from dying as I think it is >> better to die than return an error (see the commit message of the >> patch th

Re: [PATCH v3 0/8] sequencer: don't fork git commit

2017-11-17 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > I've updated these based on the feedback for v2. I've dropped the > patch that stopped print_commit_summary() from dying as I think it is > better to die than return an error (see the commit message of the > patch that adds print_commit_summary() for

[PATCH v3 0/8] sequencer: don't fork git commit

2017-11-17 Thread Phillip Wood
From: Phillip Wood I've updated these based on the feedback for v2. I've dropped the patch that stopped print_commit_summary() from dying as I think it is better to die than return an error (see the commit message of the patch that adds print_commit_summary() for the reasoning). Apart from that t