Re: [PATCH v2 2/4] diff: convert flags to be stored in bitfields

Brandon Williams writes: > + if (flags) > + rev.diffopt.flags = diff_flags_or(&rev.diffopt.flags, flags); If we are avoiding from passing a struct (even if it is a small one) by value, then returning a struct as value defeats the point of the exercise, I would think. If that wil

[PATCH v2 2/4] diff: convert flags to be stored in bitfields

We cannot add many more flags to the diff machinery due to the limitations of the number of flags that can be stored in a single unsigned int. In order to allow for more flags to be added to the diff machinery in the future this patch converts the flags to be stored in bitfields in 'struct diff_fl