Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-26 Thread Johannes Schindelin
Hi Junio, On Wed, 25 Jan 2017, Junio C Hamano wrote: > Subject: [PATCH] connect: rename tortoiseplink and putty variables > > One of these two may have originally been named after "what exact > SSH implementation do we have" so that we can tweak the command line > options, but these days "putty=

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-26 Thread Johannes Schindelin
Hi Junio, On Wed, 25 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Now, with the patch in question (without the follow-up, which I would > > like to ask you to ignore, just like you did so far), Git would not > > figure out that your script calls PuTTY eventually. The work

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-25 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 25, 2017 at 02:35:36PM -0800, Junio C Hamano wrote: > >> -- >8 -- >> Subject: [PATCH] connect: core.sshvariant to correct misidentification > > I have been watching this discussion from the sidelines, and I agree > that this direction is a big improvement. > ... >

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 02:35:36PM -0800, Junio C Hamano wrote: > -- >8 -- > Subject: [PATCH] connect: core.sshvariant to correct misidentification I have been watching this discussion from the sidelines, and I agree that this direction is a big improvement. > +static void override_ssh_variant(i

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-25 Thread Junio C Hamano
Junio C Hamano writes: > Yes. Here is what comes on an obvious clean-up patch (which will be > sent as a follow-up to this message). ... and this is the "obvious clean-up patch" to apply directly on top of Segev's GIT_SSH_COMMAND support, which comes before the previous one. -- >8 -- Subject:

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-25 Thread Junio C Hamano
Johannes Schindelin writes: > Now, with the patch in question (without the follow-up, which I would like > to ask you to ignore, just like you did so far), Git would not figure out > that your script calls PuTTY eventually. The work-around? Easy: > > DUMMY=/plink.exe /path/to/junio-is-a-sup

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-25 Thread Johannes Schindelin
Hi Junio, On Mon, 9 Jan 2017, Junio C Hamano wrote: > IOW, "give an escape hatch to override auto-detected tortoiseplink and > plink variables" suggestion should be taken as an "in addition to" > suggestion (as opposed to an "instead of" suggestion). I was not clear > in my very first message, a

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-09 Thread Junio C Hamano
Johannes Schindelin writes: >> > But do we really need to do that? >> >> No. > > Exactly. > But since you seem to convinced that a future bug report like this may > happen (I am not, and it contradicts my conviction that one should cross a > bridge only when reaching it, but whatever), how abou

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-09 Thread Johannes Schindelin
Hi Junio, On Mon, 9 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > If you feel strongly about your contrived examples possibly being > > affected by this patch, we could easily make this conditional on > > > > 1) no '&&' or '||' being found on the command-line, and > > 2) a

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-09 Thread Junio C Hamano
Johannes Schindelin writes: > If you feel strongly about your contrived examples possibly being > affected by this patch, we could easily make this conditional on > > 1) no '&&' or '||' being found on the command-line, and > 2) argv[0] not containing an '=' > > Another approach would be to verify

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-08 Thread Johannes Schindelin
Hi Junio, On Sun, 8 Jan 2017, Junio C Hamano wrote: > Junio C Hamano writes: > > > I suspect that this will break when GIT_SSH_COMMAND, which is meant > > to be processed by the shell, hence the user can write anything, > > begins with a one-shot environment variable assignment, e.g. > > > >

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-08 Thread Junio C Hamano
Junio C Hamano writes: > I suspect that this will break when GIT_SSH_COMMAND, which is meant > to be processed by the shell, hence the user can write anything, > begins with a one-shot environment variable assignment, e.g. > > [core] sshcommand = VAR1=VAL1 VAR2=VAL2 //path/to/tortoiseplink

Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-07 Thread Junio C Hamano
Johannes Schindelin writes: > + if (ssh) { > + char *split_ssh = xstrdup(ssh); > + const char **ssh_argv; > + > + if (split_cmdline(split_ssh, &ssh_argv)) > +

[PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND

2017-01-02 Thread Johannes Schindelin
From: Segev Finer Git for Windows has special support for the popular SSH client PuTTY: when using PuTTY's non-interactive version ("plink.exe"), we use the -P option to specify the port rather than OpenSSH's -p option. TortoiseGit ships with its own, forked version of plink.exe, that adds suppor