On 18-08-2011 21:41:47 +0200, Michał Górny wrote:
> On Thu, 18 Aug 2011 20:43:59 +0200
> Fabian Groffen wrote:
>
> > On 18-08-2011 20:42:23 +0200, Michał Górny wrote:
> > > > elif [[ ${PN} != "leechcraft-core" ]]; then
> > > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
> > >
> > >
> On Thu, 18 Aug 2011, Michał Górny wrote:
> On Thu, 18 Aug 2011 20:43:59 +0200
> Fabian Groffen wrote:
>> > > elif [[ ${PN} != "leechcraft-core" ]]; then
>> > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
>> >
>> > Don't quote that. It looks bad that the left-side is unquoted and
>>
On Thu, 18 Aug 2011 20:43:59 +0200
Fabian Groffen wrote:
> On 18-08-2011 20:42:23 +0200, Michał Górny wrote:
> > > elif [[ ${PN} != "leechcraft-core" ]]; then
> > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
> >
> > Don't quote that. It looks bad that the left-side is unquoted and
> > r
On 18-08-2011 20:42:23 +0200, Michał Górny wrote:
> > elif [[ ${PN} != "leechcraft-core" ]]; then
> > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
>
> Don't quote that. It looks bad that the left-side is unquoted and right
> side is quoted.
it's a string, what's the problem?
--
Fabia
On Thu, 18 Aug 2011 22:33:15 +0400
Maxim Koltsov wrote:
> if [[ -z "${LEECHCRAFT_PACKAGE_CATEGORY}" ]]; then
>
> CMAKE_USE_DIR="${S}"/src/plugins/${LEECHCRAFT_PACKAGE_CATEGORY}/${PN#leechcraft-}
Dude, that's the opposite.
> elif [[ ${PN} != "leechcraft-core" ]]; then
> CAKE_USE_DIR
2011/8/18 Michał Górny :
> On Thu, 18 Aug 2011 19:30:29 +0400
> Maxim Koltsov wrote:
>
>> if [ "${LEECHCRAFT_PACKAGE_CATEGORY+x}" != "x" ]; then
>>
>> CMAKE_USE_DIR="${S}/src/plugins/${LEECHCRAFT_PACKAGE_CATEGORY}/${PN#leechcraft-}"
>> elif [ ${PN} != "leechcraft-core" ]; then
>>
On Thu, 18 Aug 2011 19:30:29 +0400
Maxim Koltsov wrote:
> if [ "${LEECHCRAFT_PACKAGE_CATEGORY+x}" != "x" ]; then
>
> CMAKE_USE_DIR="${S}/src/plugins/${LEECHCRAFT_PACKAGE_CATEGORY}/${PN#leechcraft-}"
> elif [ ${PN} != "leechcraft-core" ]; then
> CMAKE_USE_DIR="${S}/src/plugins
2011/8/18 Fabian Groffen :
>> > if [ "${LC_PCAT+x}" != "x" ]; then
>> > CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}"
>> > else
>> > if [[ ${PN} != "leechcraft-core" ]]; then
>> > CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}"
>> > else
>> > C
2011/8/18 Michał Górny :
> On Thu, 18 Aug 2011 14:38:01 +0400
> Maxim Koltsov wrote:
>
>
>> 0|1) die "EAPI not supported, bug ebuild mantainer" ;;
>> *) die "Unknown EAPI, Bug eclass maintainers." ;;
>
> I think I already mentioned that. Keep consistent case, and in this
> case lowerca
On Thu, Aug 18, 2011 at 8:27 AM, Fabian Groffen wrote:
> On 18-08-2011 16:57:59 +0200, Michał Górny wrote:
>> > # @ECLASS-VARIABLE: LC_PCAT
>> > # @DESCRIPTION:
>> > # Set this to the category of the plugin, if any.
>> > : ${LC_PCAT:=}
>>
>> Please use verbose variable names, and prefix them with
On 18-08-2011 16:57:59 +0200, Michał Górny wrote:
> > # @ECLASS-VARIABLE: LC_PCAT
> > # @DESCRIPTION:
> > # Set this to the category of the plugin, if any.
> > : ${LC_PCAT:=}
>
> Please use verbose variable names, and prefix them with eclass
> filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY.
Really? T
On Thu, 18 Aug 2011 14:38:01 +0400
Maxim Koltsov wrote:
> We've fixed all the problems with eclass. Please review it and give OK
> for commit, i plan to do it this night.
> 0|1) die "EAPI not supported, bug ebuild mantainer" ;;
> *) die "Unknown EAPI, Bug eclass maintainers." ;;
I t
On Fri, 22 Jul 2011 14:57:08 +0400
Maxim Koltsov wrote:
> Sorry, forgot the eclass. Attaching it here...
> P.S. Email of author: 0xd34df...@gmail.com
Then you should CC him (like I did now).
> # Original author: 0xd34df00d <0xd34df...@gmail.com> and
> #Andrian No
Sorry, forgot the eclass. Attaching it here...
P.S. Email of author: 0xd34df...@gmail.com
leechcraft.eclass
Description: Binary data
14 matches
Mail list logo
