On 18-08-2011 21:41:47 +0200, Michał Górny wrote:
> On Thu, 18 Aug 2011 20:43:59 +0200
> Fabian Groffen <grob...@gentoo.org> wrote:
>
> > On 18-08-2011 20:42:23 +0200, Michał Górny wrote:
> > > > elif [[ ${PN} != "leechcraft-core" ]]; then
> > > > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
> > >
> > > Don't quote that. It looks bad that the left-side is unquoted and
> > > right side is quoted.
> >
> > it's a string, what's the problem?
>
> It's just a matter of taste. I think it looks better if both sides are
> quoted, or neither is.
Right, it's a matter of taste, so the snippet is fine as-is.
Commenting on code is fine, Just don't present your taste as if it is
the only right thing to do.
--
Fabian Groffen
Gentoo on a different level
