Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

Thursday 22 Jul 2021 10:54:02, Patrice Clement wrote : > ... and replace it with a test against the REPLACING_VERSIONS variable. > > See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. > > This is an updated version of the same patch discussed previously on this ML. > > Suggested by Ar

Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

> On 22 Jul 2021, at 09:32, Patrice Clement wrote: > > Thursday 22 Jul 2021 04:44:39, Sam James wrote : >> >>> [snip] >> >> The patch itself seems fine, but I have some suggestions while we're >> working on the eclass: >> >> [snip] >> Let me know if you need any assistance, etc. >> >> than

[gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

... and replace it with a test against the REPLACING_VERSIONS variable. See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. This is an updated version of the same patch discussed previously on this ML. Suggested by Arfrever. --- eclass/vim-plugin.eclass | 12 ++-- 1 file chang

Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

Thursday 22 Jul 2021 04:44:39, Sam James wrote : > > > > On 21 Jul 2021, at 17:47, Patrice Clement wrote: > > > > ... and replace it with a test against the REPLACING_VERSIONS variable. > > > > See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. > > > > Patch courtesy of Arfrever. >

Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

Wednesday 21 Jul 2021 19:16:36, Ulrich Mueller wrote : > > On Wed, 21 Jul 2021, Patrice Clement wrote: > > > + if [[ -n "${VIM_PLUGIN_HELPFILES}" ]]; then > > Quotation marks are not necessary here (and three more times below, > in the elif lines). Thanks, this has been mended.

Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

> On 21 Jul 2021, at 17:47, Patrice Clement wrote: > > ... and replace it with a test against the REPLACING_VERSIONS variable. > > See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. > > Patch courtesy of Arfrever. > Ideally, we'd use Arfrever's sign off, but this is kind of a gre

Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

> On Wed, 21 Jul 2021, Patrice Clement wrote: > + if [[ -n "${VIM_PLUGIN_HELPFILES}" ]]; then Quotation marks are not necessary here (and three more times below, in the elif lines). signature.asc Description: PGP signature

[gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

... and replace it with a test against the REPLACING_VERSIONS variable. See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. Patch courtesy of Arfrever. Closes: https://github.com/gentoo/gentoo/pull/21733 Signed-off-by: Patrice Clement --- eclass/vim-plugin.eclass | 12 ++-- 1