> On 22 Jul 2021, at 09:32, Patrice Clement <monsie...@gentoo.org> wrote: > > Thursday 22 Jul 2021 04:44:39, Sam James wrote : >> >>> [snip] >> >> The patch itself seems fine, but I have some suggestions while we're >> working on the eclass: >> >> [snip]
>> Let me know if you need any assistance, etc. >> >> thanks, >> sam >> > Thanks for the suggestions. If you don't mind, I'd like to stick to the > original changes for now and address your suggestions later in a follow up > patch. It's preferred [0] where, if we know more changes are coming, to batch them up, unless this is really critical. This is because of needless cache regeneration. It's generally not a reason to block fixing something if no other issues exist, but it is a reason to stop and pause/reflect if there are any other low-hanging fruit we could fix while there. A lot of this is straightforward tidying. I don't mind if you're sure you will be able to return to it shortly, but then I figure, why not just do it now? [0] https://devmanual.gentoo.org/eclass-writing/index.html#adding-and-updating-eclasses (see the "Note") thanks, sam
signature.asc
Description: Message signed with OpenPGP
