Just letting everyone know that I created a PR at
https://github.com/apache/incubator-pekko-sbt-paradox/pull/72 that should
better clarify that the linked docs are just references for mroe
information and NOT that the code was copied/derived from the sample
documentation.
On Fri, Jul 14, 2023 at 1
The -1 is accepted and the vote is cancelled.
Other than the groups.js issue, we have already addressed all the
other issues in the git repo in preparation for an eventual RC2.
On Fri, 14 Jul 2023 at 09:31, Claude Warren wrote:
>
> Justin,
>
> I agree with 80% of your assessment and agree that
Justin,
I agree with 80% of your assessment and agree that a -1 is warranted. However,
[2] is clearly a copy of the original lightbend code [6] which is licensed
under Apache V2. Lightbend's LICENSE file shows no other attribution and the
URLs in the code appear to point to documentation abou
Hi,
> I just had an look at the entire git history of the file (see
> https://github.com/lightbend/paradox/commit/7f55c0c71bfbfc6a987c2693b19dcbb74c9dc9a3)
> and the original version
> of the code that was committed is pretty much the same as the latest
> version (see
> https://github.com/lightben
Hi,
> b) it uses the same formatting/style as the original example, which is
> different to the style of the rest of the code.
>
> The indentation/formatting/style of the code is entirely consistent
I'd suggest you look again; other code put chained functions on a single line
rather than multi
