Just letting everyone know that I created a PR at https://github.com/apache/incubator-pekko-sbt-paradox/pull/72 that should better clarify that the linked docs are just references for mroe information and NOT that the code was copied/derived from the sample documentation.
On Fri, Jul 14, 2023 at 10:30 AM Claude Warren <cla...@apache.org> wrote: > Justin, > > I agree with 80% of your assessment and agree that a -1 is warranted. > However, [2] is clearly a copy of the original lightbend code [6] which is > licensed under Apache V2. Lightbend's LICENSE file shows no other > attribution and the URLs in the code appear to point to documentation about > Cookies and how they function in general and how to access them via > javascript. I do not see the level of similarity between the example code > and the code in question to assume that it was copied. I do note that > there are only so many ways to set and get cookies and that most of the > code seems to fall under the generic cookie API. > > The Pekko code clearly has the Lightbend attribution and Apache License > 2.0 reference. > > For these reasons I think you should withdraw [2] from your list of issues. > > Claude > > [6] > https://github.com/lightbend/paradox/blob/8e30c341f1f8351a19b71599219d2f636ba68eb4/themes/generic/src/main/assets/js/groups.js > > > On 2023/07/12 00:14:45 Justin Mclean wrote: > > Hi, > > > > Sorry but it’s - 1 (binding from me). The source release seems to > contain code that is licensed under a Category B Mozilla license and > missing headers from files. > > > > I checked: > > - incubating in name > > - signatures and hashes are fine > > - DISCLAIMER exists > > - LICENSE is missing some 3rd party code [2] (Mozilla licensed) > > - This file is also under the MIT license [3] but not mentioned in > LICENSE > > - Files are missing ASF or other header [1][4][5] > > - No unexpected binary files > > - Can compile from source > > > > Kind Regards, > > Justin > > > > 1. ./plugin/src/main/scala/org/apache/pekko/PekkoParadoxPlugin.scala > > 2. ./theme/src/main/assets/assets/javascripts/groups.js > > 3. ./theme/src/main/assets/assets/javascripts/paradox-material-theme.js > > 4. ./theme/src/main/assets/assets/stylesheets/pekko-theme.css > > 5. ./theme/src/main/assets/partials/extra_nav_links.st > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
