Hi Mark,
Well done on the new patches they are currently being merged. I imagine the
typechecking could be a bit more complex since correct me if I am wrong but
I feel like this might end up affecting the whole PathInExpression
resolution which is fairly complicated. There is a nullptr bug there i
Hi Philip,
On Thu, Sep 02, 2021 at 02:23:33PM +0100, Philip Herron wrote:
> I've been reviewing your branch a bit and noticed this commit
> https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=enums&id=84d27b926e09ef44dd94be20c97d72bd4b865c40
> which I really like. I wasn't sure what was the b
Hi Mark,
I've been reviewing your branch a bit and noticed this commit
https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=enums&id=84d27b926e09ef44dd94be20c97d72bd4b865c40
which I really like. I wasn't sure what was the best way to interact with
the AST which contained unique_ptr's to things
Hi,
On Wed, Sep 01, 2021 at 11:11:46AM +0100, Philip Herron wrote:
> This is fantastic work Mar. This brings us closer to the AST structures of
> rustc and does simplify a lot of the analysis within the compiler.
> https://doc.rust-lang.org/nightly/reference/expressions/struct-expr.html
The refer
This is fantastic work Mar. This brings us closer to the AST structures of
rustc and does simplify a lot of the analysis within the compiler.
https://doc.rust-lang.org/nightly/reference/expressions/struct-expr.html
I agree the HIR cleanup will also help reduce a lot of duplication of code
and visi
Hi,
There are various Structure Expressions that don't actually "exist"
because they are syntactically equivalent to other constructs. So we
never really construct or use these classes. But they are still listed
in various visitors, which is somewhat confusing. Removing the AST and
HIR variants of
