Re: PING [PATCH] RX movsicc degrade fix

2018-02-07 Thread Nick Clifton
pproved - please apply. Cheers Nick

Re: PING [PATCH] -mjsr option bug fix

2018-02-07 Thread Nick Clifton
BOL_REF in call_internal and > + call_value_internal insns > + Approved - please apply. Note for the future - it is usually best to provide changelog entries as plain text, rather than a context diff, as they almost never apply cleanly... Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-07 Thread Nick Clifton
decided to leave it for now. Fixing them will require mucking about in the C preprocessor library, which I did not fancy doing at the moment. So, is this enhanced patch OK now ? Cheers Nick gcc/ChangeLog 2018-02-07 Nick Clifton PR 84195 * tree.c (warn_deprecated_use): Replace

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-08 Thread Nick Clifton
ro message length, multi-line messages are allowed. At least that was my understanding of the option. Thanks for the patch review. I will get onto fixing the points you raised today. Cheers Nick

RFA: Fix PR 68028: LTO error when compiling PowerPC binaries with single precision floating point

2018-02-08 Thread Nick Clifton
Nick gcc/ChangeLog 2018-02-08 Nick Clifton * config/rs6000/rs6000.c (rs6000_option_override_internal): In LTO mode prefer function attributes over command line -mcpu setting. Index: gcc/config/rs6000/rs6000.c

Re: RFA: Fix PR 68028: LTO error when compiling PowerPC binaries with single precision floating point

2018-02-09 Thread Nick Clifton
Hi Segher, > I thought you were going to do a patch like the following, to make the > e500 cores less special (they are not): Sorry - my bad. I defer to your patch then. Whatever it takes to get the BZ fixed and off the books... :-) Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-09 Thread Nick Clifton
oor C++ coding - it is not my strong point. I am an assembler level programmer at heart). Cheers Nick gcc/ChangeLog 2018-02-09 Nick Clifton PR 84195 * tree.c (escaped_string): New class. Converts an unescaped string into its escaped equivalent. (warn_deprecate

Re: [RX] Fix PR 83831 -- Unused bclr, bnot, bset insns

2018-02-13 Thread Nick Clifton
insn, correct maximum insn length. > > gcc/testsuite/ChangeLog: > > PR target/83831 > * gcc.target/rx/pr83831.c: New tests. Approved - please apply - and thanks very much for doing this! Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-16 Thread Nick Clifton
Hi David, Attached is a revised version of the patch which I hope addresses all of your (very helpful) comments on the v3 patch. OK to apply once the sources are back on stage 1 ? Cheers Nick gcc/ChangeLog 2018-02-09 Nick Clifton PR 84195 * tree.c (escaped_string

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-20 Thread Nick Clifton
str field has been set to the same string as A, because its m_owned field will be set to FALSE. Cheers Nick

Re: plugin-api.h patch to add a new interface for linker plugins

2018-02-22 Thread Nick Clifton
ck to GCC, unless someone there OKs it sooner. > > Nick, is that OK? Yes, that is fine with me. Cheers Nick

Re: [PATCH] RX TARGET_RTX_COSTS function

2018-02-22 Thread Nick Clifton
Hi Oleg, > Ping. Sorry - I am not very good at spotting RX bugs on the gcc-patches list. :-( >> gcc/ChangeLog: >> * config/rx/rx.c (rx_rtx_costs): New function. >> (TARGET_RTX_COSTS): Override to use rx_rtx_costs. Approved - please apply. Cheers Nick

Re: [PATCH] [configure] Added "nfp" to the build for binutils.

2018-05-01 Thread Nick Clifton
Hi Francois, > 2018-05-01 Francois H. Theron > > * configure.ac: Added "nfp" target. > * configure: Regenerate. I have applied this change patch to both the gcc and binutils mainline sources. Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-05-03 Thread Nick Clifton
ped_string::escape (const char * unescaped) > No need for the space between the * and unescaped. Et tu Jeff ? Then fall Nick. :-) [Fixed] > + case '\v': escaped[new_i++] = 'v'; break; > + default: escaped[new_i++] = '?'; break; &g

Commit: MSP430: Make -mmcu option define C preprocessor symbol and linker scripts

2013-11-06 Thread Nick Clifton
. Cheers Nick gcc/ChangeLog 2013-11-06 Nick Clifton * config/msp430/msp430.h (TARGET_CPU_CPP_BUILTINS): Define the name returned by msp430_mcu_name. (LIB_SPEC): If a -T option has not been specified then set a default, mcu-specific, linker script

Commit: RX: Correctly honour user specified alignment of jumps, loops and labels

2014-06-13 Thread Nick Clifton
Hi Guys, I am applying the patch below to fix a small problem with the RX port - it was using non-log based alignment values for jumps, loops and labels when user specified alignment was enabled. Cheers Nick gcc/ChangeLog 2014-06-13 Nick Clifton * config/rx/rx.h (JUMP_ALIGN

Commit: MSP430: Add NOP after DINT in hardware multiply patterns

2014-06-17 Thread Nick Clifton
it has to be a NOP. The change is going in to the mainline sources and the 4.9 branch. Cheers Nick gcc/ChangeLog 2014-06-17 Nick Clifton * config/msp430/msp430.md (mulhisi3): Add a NOP after the DINT. (umulhi3, mulsidi3, umulsidi3): Likewise. Index: gcc/config/msp430

Commit: RX: Fix typo in description of RX vector attribute

2014-06-26 Thread Nick Clifton
Hi Guys, I am checking in the patch below to fix a small typo in the description of the RX vector function attribute. Cheers Nick gcc/ChangeLog 2014-06-26 Nick Clifton * doc/extend.texi (Function Attributes): Fix typo in description of RX vector attribute. Index: doc

Commit: Testsuite: Fix typo in proc check_effective_target_trapping

2014-06-26 Thread Nick Clifton
Hi Guys, I am applying the patch below as an obvious fix for a typo in the check_effective_target_trapping proc in the testsuite's target-supports.exp file. Cheers Nick gcc/testsuite/ChangeLog 2014-06-26 Nick Clifton * lib/target-supports.exp (check_effective_target_tra

Commit: FRV: Remove redundant assert

2014-06-26 Thread Nick Clifton
Hi Guys, I am checking in the patch below to remove a redundant assert, now that DECL_SECTION_NAME returns a string rather than a tree. Cheers Nick gcc/ChangeLog 2014-06-26 Nick Clifton * config/frv/frv.c (frv_in_small_data_p): Remove redundant assert. Index: config/frv/frv.c

RFA: RL78: Place zero-initialised data into the .bss section

2015-05-13 Thread Nick Clifton
expected sections. Tested with no regressions on an rl8-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-05-13 Nick Clifton * config/rl78/rl78.c (rl78_select_section): Select the correct default section based upon the category of the decl. Index: gcc/config/rl78

Commit: MSP430: Enhance the zero_extendhisi2 pattern

2015-05-19 Thread Nick Clifton
in PR 66156. Cheers Nick gcc/ChangeLog 2015-05-19 Nick Clifton PR target/66156 * config/msp430/msp430.md (zero_extendhisi2): Add support for separate source and destination registers. Index: gcc/config/msp430/msp430.md

Commit: RX: Better use of PUSHM and POPM

2015-05-28 Thread Nick Clifton
Hi Guys, I am applying the patch below to enhance the RX backend so that it will push and pop multiple groups of registers using the PUSHM and POPM instructions, thus reducing code size and increasing performance. Cheers Nick gcc/ChangeLog 2015-05-28 Nick Clifton * config

Commit: MSP430: Add multilibs for different types of hardware multiply

2015-05-29 Thread Nick Clifton
Hi Guys, I am applying the patch below to the MSP430 backend to add new multilibs based upon the type of hardware multiply support used. Cheers Nick gcc/ChangeLog 2015-05-29 Nick Clifton * config/msp430/t-msp430 (MULTILIB_OPTIONS): Add multilibs for the different types

RFA: RL78:

2015-06-02 Thread Nick Clifton
interrupt handler if the handler never uses or corrupts the frame pointer. Tested with no regressions using an rx-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-06-02 Nick Clifton * config/rl78/rl78-real.md: Add peepholes to avoid a register copy when

RFA: RL78: With -mes0 put read only data in the .frodata section

2015-06-08 Thread Nick Clifton
to apply ? Cheers Nick gcc/ChangeLog 2015-06-08 Nick Clifton * config/rl78/rl78.c (rl78_select_section): With -mes0 put read only data into the .frodata section. Index: config/rl78/rl78.c === --- config/rl78/rl78

Commit: RX: Do not promote vector types

2015-06-08 Thread Nick Clifton
ernal compiler errors when the promoted type does not match the original vector type. Cheers Nick gcc/ChangeLog 2015-06-08 Nick Clifton * config/rx/rx.c (rx_function_value): Do not promote vector types. (rx_promote_function_mode): Likewise. * config/rx/rx.h (LIBCALL_

Commit: RL78: Fix compile time warnings

2015-04-23 Thread Nick Clifton
Hi Guys, I am applying the patch below as an obvious fix for come compile time warning messages building the rl78 toolchain. Cheers Nick gcc/ChangeLog 2015-04-23 Nick Clifton * config/rl78/rl78.c (rl78_preferred_reload_class): Add ATTRIBUTE_UNUSED to x parameter

RFA: RL78: Save the frame pointer if it is used.

2015-05-05 Thread Nick Clifton
. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-05-05 Nick Clifton * config/rl78/rl78.c (need_to_save): Save the frame pointer any time that it is used. Index: gcc/config/rl78/rl78.c

Commit: MSP430: Add -mcode-region= and -mdata-region= options

2015-05-05 Thread Nick Clifton
igh memory otherwise. Three new function and data attributes have also been added - lower, either and upper - which allow the programmer to explicitly state which memory region an object should use. Tested with no regressions and 77 less unexpected failures on an msp430-elf toolchain. Che

RFA: Doc update: Describe new MSP430 feature

2015-05-05 Thread Nick Clifton
OK to apply ? Cheers Nick Index: htdocs/gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.120 diff -u -3 -p -r1.120 changes.html --- htdocs/gcc-5/changes.html 1 May 2015 22:44:45

RL78: Add support for assembler G10 multiply/divide functions to libgcc

2014-11-13 Thread Nick Clifton
Hi Guys, I am applying the patch below to add support for G10 versions of the RL78 assembler multiply and divide functions to the libgcc library. Cheers Nick libgcc/ChangeLog 2014-11-13 Nick Clifton * config/rl78/divmodhi.S: Add support for the G10 architecture. Use

Commit: Rl78: Save ES register in interrupt handlers

2014-11-21 Thread Nick Clifton
Nick gcc/ChangeLog 2014-11-21 Nick Clifton * config/rl78/rl78-real.md (movqi_from_es): New pattern. * config/rl78/rl78.c (struct machine_function): Add uses_es field. (rl78_expand_prologue): Save the ES register in interrupt handlers that use it

Commit: V850: Pass -msoft-float/-mhard-float on to the assembler

2015-02-24 Thread Nick Clifton
Hi Guys, I am applying the patch below to update the V850 backend so that it will pass on the -msoft-float and -mhard-float options to the assembler. This matches up with a recent update to the assembler that accepts these options. Cheers Nick gcc/ChangeLog 2015-02-24 Nick Clifton

RFA: RL78: Fix register constraints in rl78-real.md

2015-03-03 Thread Nick Clifton
w use the "R" and "v" register constraints. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-03-03 Nick Clifton * config/rl78/rl78.h (enum reg_class): Remove real registers from General register class.

RFA: RL78: Add muladdhi3 pattern

2015-03-03 Thread Nick Clifton
operations. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-03-03 Nick Clifton * config/rl78/rl78.md (muladdhi4): New splitter. Index: gcc/config/rl78/rl78.md

RFA: Update gcc test 20101011-1.c with more targets that do not trap

2015-03-12 Thread Nick Clifton
Hi Guys, The patch below updates the 20101011-1.c test in the gcc testsuite to add a few more targets whose (simulated) runtime does not support trapping on division by zero. OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2015-03-12 Nick Clifton * gcc.c-torture/execute

RFC: Avoid calling convert_to_mode with invalid rtl.

2015-03-13 Thread Nick Clifton
does will still remain valid. What do people think ? Is this the right approach ? I have tested the patch with an rl78-elf toolchain as well as an x86_64-pc-linux-gnu toolchain and there were no regressions in the gcc testsuite for either of these targets. Cheers Nick Index: gcc/e

Commit: Avoid calling convert_to_mode with invalid rtl.

2015-04-14 Thread Nick Clifton
cannot be sure that the offset RTL is valid outside of an address context it needs to be forced into a register first. Tested with no regressions on an x86_64-pc-linux-gnu and a rl78-elf toolchain. Cheers Nick gcc/ChangeLog 2015-04-14 Nick Clifton * expr.c (expand_assignment

RFA: RL78:

2015-04-14 Thread Nick Clifton
fact it is only an input. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick 2015-04-14 Nick Clifton * config/rl78/rl78.c (rl78_expand_prologue): Mark large stack decrement instruction as being frame related. (rl78_print_operand_1

Commit: RX: Add option to disable string instructions.

2015-04-15 Thread Nick Clifton
Nick gcc/ChangeLog 2015-04-15 Nick Clifton * config/rx/rx.opt (mallow-string-insns): New option. * config/rx/rx.c (RX_BUILTIN_RMPA): Disable the use of this builtin if string instructions are denied. * config/rx/rx.h (TARGET_CPU_CPP_BUILTINS): Define

RFA: RL78: Add support for G13 and G14 multiply and divide

2015-04-15 Thread Nick Clifton
with those patterns. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-04-15 Nick Clifton * config/rl78/rl78-opts.h (enum rl78_mul_types): Add MUL_G14 and MUL_UNINIT. (enum rl78_cpu_type): New. * config/rl78

RFA: Fix isl-ast-gen-if-1.c test

2015-06-22 Thread Nick Clifton
ddress on the stack). The patch below fixes the problem, although it could also be solved by increasing the size of the a array when it is declared in main(). OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2015-06-22 Nick Clifton * gcc.dg/graphite/isl-ast-gen-if-1.

RFA: Add support for -fstack-usage to various ports

2015-06-23 Thread Nick Clifton
regressions on bfin-elf, ft32-elf, h8300-elf, iq2000-elf, m32c-elf, mn10300-elf and v850-elf toolchains. OK to apply ? Cheers Nick gcc/ChangeLog 2015-06-23 Nick Clifton * config/bfin/bfin.c (bfin_expand_prologue): Set current_function_static_stack_size if

Commit: MSP430: Fix zero-extending a 16-bit value to a 20-bit value, in memory

2015-07-01 Thread Nick Clifton
Hi Guys, I am applying the patch below to fix a problem with the MSP430's zero_extendhipsi2 pattern. When the destination is memory, four bytes must be written, even though only a 20-bit value is being stored, as otherwise the top nibble will be lost. Cheers Nick gcc/ChangeLog

RFA: RL78: Scan inside PARALLELs when looking for dead code

2015-01-20 Thread Nick Clifton
generated for the RL78 are the SImode shift patterns and these always consist of a SET as the first element and a CLOBBER as the second element. So I decided to keep things simple and create the patch below. OK to apply ? Cheers Nick 2015-01-20 Nick Clifton * config/rl78

RFA: RL78: Minor prologue and epilogue enhancements

2015-01-26 Thread Nick Clifton
? Cheers Nick 2015-01-26 Nick Clifton * config/rl78/rl78.c (rl78_expand_prologue): In G10 mode push the BC, DE and HL registers directly, not via AX. When decrementing the stack pointer by a large amount, transfer SP into AX and perform the subtraction there

RFA: RL78: Add assembler versions of some libgcc functions.

2015-01-26 Thread Nick Clifton
toolchain with no regressions. OK to apply ? Cheers Nick 2015-01-26 Nick Clifton * config/rl78/cmpsi2.S: Use function start and end macros. (__gcc_bcmp): New function. * config/rl78/lshrsi3.S: Use function start and end macros. * config/rl78/mulsi3.S: Add

RFA: RL78: Fix gcc testsuite failures

2015-02-04 Thread Nick Clifton
fixes using an rl78-elf toolchain. OK to apply ? Cheers Nick libgcc/ChangeLog 2015-02-04 Nick Clifton * config/rl78/fpmath-sf.S (__addsf3): Add code for the special case where rounding the fraction up results in an overflow into unused bits. gcc/ChangeLog 2015

Commit: MSP430: Extend msp430_use_f5_series_hwmult()

2015-02-04 Thread Nick Clifton
Hi Guys, I am applying the patch below to extend the MSP430 port of gcc's auto-recognition of F5 multiply hardware enabled MCUs. Cheers Nick gcc/ChangeLog 2015-02-04 Nick Clifton * config/msp430/msp430.c (msp430_use_f5_series_hwmult): Add more prefixes of kno

Commit: FR30: Fix di_operand and nonimmediate_di_operand predicates

2015-02-04 Thread Nick Clifton
Hi Guys, I am checking in the patch below to add SUBREG to the list of rtx codes accepted by the di_operand and nonimmediate_di_operand predicates in the FR30 backend. This should resolve PR 64408. Cheers Nick gcc/ChangeLog 2015-02-04 Nick Clifton PR target/64408

RFA: Synchronize top level files with binutils

2019-05-29 Thread Nick Clifton
Hi Guys, I would like to bring over a few additions that have recently been made to the binutils versions of the Makefile.def and configure.ac files. Any objections ? Note - I did run a toolchain bootstrap after applying this patch locally and that went OK... Cheers Nick

Re: RFA: Synchronize top level files with binutils

2019-06-07 Thread Nick Clifton
ill work on it over the weekend and try again on Monday. Cheers Nick

Re: RFA: Synchronize top level files with binutils

2019-06-10 Thread Nick Clifton
Hi Richard, OK, here is a resubmission of my patch with just the addition of the libctf patches this time. (Sorry about the previous bad patch). Tested with a bootstrap and a normal build. OK to apply ? Cheers Nick 2019-06-07 Nick Clifton Import these changes from the

Re: RFA: Synchronize top level files with binutils

2019-06-18 Thread Nick Clifton
h current binutils would be available? Do you have any particular branches in mind ? There do seem to be quite a lot of them... Cheers Nick

Re: RFA: Synchronize top level files with binutils

2019-06-20 Thread Nick Clifton
Hi Richard, Please may I apply this patch to the gcc-9, gcc-8 and gcc-7 branches ? I have tested it on all three branches and found no problems. Cheers Nick 2019-06-07 Nick Clifton Import these changes from the binutils/gdb repository: 2019-05-28 Nick Alcock

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v3]

2018-12-03 Thread Nick Clifton
this of course, but I would rather have Ian's blessing first. Cheers Nick

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-12-03 Thread Nick Clifton
I think that in real life no program is ever going to generate a mangled name that is sufficiently complex to trigger a seg-fault this way, so the only real purpose of the patch is to resolve these PRs and stop more from being filed. Cheers Nick

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v4]

2018-12-04 Thread Nick Clifton
the patch, although I had to make sure that the affected code could handle NULL pointers properly afterwards. OK to apply ? Cheers Nick include/ChangeLog 2018-11-29 Nick Clifton * demangle.h (DMGL_NO_RECURSE_LIMIT): Define. (DEMANGLE_RECURSION_LIMIT): Define li

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-04 Thread Nick Clifton
led, then this is the value used as > > Typo: "RECURE" Oops - thanks. OK, revised (v5) patch attached. Is this version acceptable to all ? Cheers Nick Index: include/demangle.h === --- include/demangle.h (revision 2

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v5]

2018-12-06 Thread Nick Clifton
Hi Ian, Is the patch OK with you ? Cheers Nick

Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes

2018-12-07 Thread Nick Clifton
e, what will happen ? Ie I guess I am asking if they will be given a hint that they need to use an older toolchain in order to demangle the names. Cheers Nick

Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes

2018-12-07 Thread Nick Clifton
ugh at all (e.g. x86-64, powerpc64le, aarch64, I believe not even > powerpc64-linux). Well that is good enough for me. :-) I do not have the power to approve the patch, but I would certainly be happy to see it go in. Cheers Nick

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

2018-12-10 Thread Nick Clifton
de just is really recursive... Cheers Nick

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

2018-12-10 Thread Nick Clifton
not sure if this could be triggered with the other limits in place, and I did not have a reproducer that touched it, so I left it alone. Cheers Nick

Re: [PATCH] Set DEMANGLE_RECURSION_LIMIT to 1536

2018-12-10 Thread Nick Clifton
pe is that we can choose a value that will allow any realistic mangled name to be decoded, but which will prevent these fuzzers from generating arbitrary length strings which exhaust the machines resources. Cheers Nick

RFA: libiberty: Add a limit on demangling qualifiers (PR 87241)

2018-12-12 Thread Nick Clifton
Nick libiberty/ChangeLog 2018-12-12 Nick Clifton * cplus-dem.c (demangle_qualified): Add an upper limit on the number of qualifiers supported, based upon the value of DEMANGLE_RECURSE_LIMIT. Index: libiberty/cplus-dem.c

RFA: libiberty: Add a limit on demangling qualifiers (PR 87241) (version 2)

2018-12-12 Thread Nick Clifton
Hi Ian, *sigh* 5 minutes after sending the patch for this PR, I realised that I had made a mistake. I should have conditionalized the limit on the number of supported qualifiers, so that the check is only made if we have resource limits enabled. Like this: Cheers Nick Index

Re: RFA: libiberty: Add a limit on demangling qualifiers (PR 87241) (version 2)

2018-12-13 Thread Nick Clifton
Hi Ian, > I thought we were removing the old demangling schemes? Doh! yes, I totally forgot. So I will withdraw this patch in favour of Jason's. Cheers Nick

Re: RFA: libiberty: Add a limit on demangling qualifiers (PR 87241)

2018-12-13 Thread Nick Clifton
Hi Jason, > This issue also will be resolved by disabling or removing the old > demangling code, which I haven't seen anyone argue against. Doh - of course. I withdraw my patch and I hope that yours will go in soon. Cheers Nick

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

2019-09-06 Thread Nick Desaulniers
detection instead. This simplifies use of this feature even between codebases supporting multiple versions of GCC. (Also, I'm guessing the cost of another preprocessor define is near zero compared to parsing comments for -Wimplicit-fallthrough) -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

2019-09-06 Thread Nick Desaulniers
On Fri, Sep 6, 2019 at 3:56 PM Segher Boessenkool wrote: > > On Fri, Sep 06, 2019 at 03:35:02PM -0700, Nick Desaulniers wrote: > > On Fri, Sep 6, 2019 at 3:03 PM Segher Boessenkool > > wrote: > > > And if instead you tested whether the actual feature you need works

Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition

2019-09-12 Thread Nick Desaulniers
On Sat, Sep 7, 2019 at 6:11 AM Segher Boessenkool wrote: > > On Fri, Sep 06, 2019 at 06:04:54PM -0700, Nick Desaulniers wrote: > > On Fri, Sep 6, 2019 at 5:14 PM Segher Boessenkool > > wrote: > > > On Fri, Sep 06, 2019 at 04:42:58PM -0700, Nick Desaulniers v

RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-11-29 Thread Nick Clifton
ty of different binutils builds and also bootstrapped an x86_64-pc-linux-gnu toolchain. No new failures were found. What do you think, is this approach reasonable ? Cheers Nick [*] Actually I also have a patch for the binutils to modify the addr2line, c++filt, nm and objdump programs to make u

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-11-30 Thread Nick Clifton
other static variables in libiberty that face the same issue ? Cheers Nick libiberty/ChangeLog 2018-11-29 Nick Clifton PR 87681 PR 87675 PR 87636 PR 87335 * cp-demangle.c (demangle_recursion_limit): New static variable

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-11-30 Thread Nick Clifton
Hi Scott, > Thank you for looking into this Nick. I've been staring at a few of these > CVEs off-and-on for a few days, and the following CVEs all look like > duplicates: > > CVE-2018-17985: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87335 > CVE-2018-18484: https

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-11-30 Thread Nick Clifton
mit is controlled by a separate feature of the proposed patch, ie the new DMGL_RECURSE_LIMIT flag in the options field of the cplus_demangleXXX() functions. But there is not enough room in the options field to also include a recursion limit value. Cheers Nick

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler [v3]

2018-11-30 Thread Nick Clifton
this version acceptable ? Cheers Nick libiberty/ChangeLog 2018-11-29 Nick Clifton PR 87681 PR 87675 PR 87636 PR 87335 * cp-demangle.h (struct d_info): Add recursion_limit field. * cp-demangle.c (d_function_type): If the recursion limit is

RFA: Patch to fix severe recursion in d_count_templates_scopes (PR 89394)

2019-03-21 Thread Nick Clifton
further investigation proved this guess to be wrong. I felt that leaving the check in however would still be a good idea. Tested with no regressions with an x86_64-linux-gnu toolchain, as well as against the testcase in PR 89394. OK to apply ? Cheers Nick libiberty/ChangeLog 2019-03

Commit: MSP430: Three small fixes

2016-05-25 Thread Nick Clifton
extract the low 16 bits of a 20 bit pointer. Adding a simple pattern to the machine description file fixes this. Cheers Nick gcc/ChangeLog 2016-05-25 Nick Clifton * config/msp430/msp430.c (msp430_attr): Produce an error if a static interrupt handler is detected

Re: RFA: Generate normal DWARF DW_LOC descriptors for non integer mode pointers

2016-05-26 Thread Nick Clifton
ad. I tried out the extended patch (attached) and it gave even better GDB results for the MSP430 and still no regressions (GCC or GDB) for MSP430 or x86_64. Is this enough justification ? Cheers Nick dwarf2out.c.patch.2 Description: Unix manual page

Re: [RX] Add support for atomic operations

2016-05-31 Thread Nick Clifton
Hi Oleg, > Sorry, but my original patch was buggy. There are two problems: Thanks for your diligence in checking the patch. > The attached patch fixes those issues. > OK for trunk? > > Cheers, > Oleg > > gcc/ChangeLog: > * config/rx/rx.md (FETCHOP_NO_MINUS): New code iterator. > (

Commit: MSP430: Rename entries in option enums

2016-06-16 Thread Nick Clifton
. Tested with no regressions on an msp430-elf toolchain. Cheers Nick gcc/ChangeLog 2016-06-16 Nick Clifton * config/msp430/msp430-opts.h (msp430_hwmult_types): Add MSP430_HWMULT_ prefix to enum values. (msp430_regions): Add MSP430_REGION_ prefix to enum values

Re: RFA: Generate normal DWARF DW_LOC descriptors for non integer mode pointers

2016-06-22 Thread Nick Clifton
Hi Jeff, > I can buy that ;-) OK with a suitable ChangeLog entry. Thanks! Checked in with this changelog entry. Cheers Nick gcc/ChangeLog 2016-06-22 Nick Clifton * dwarf2out.c (scompare_loc_descriptor): Use SCALAR_INT_MODE_P() in place of GET_MODE_CLASS() == MODE_

Re: [PATCH] [MSP430] [PR80993] Prevent lto removing interrupt handlers

2017-08-29 Thread Nick Clifton
, as I do not have write access. Approved and applied. Thanks for fixing this bug. Cheers Nick

Re: [PATCH] [MSP430] Read mcu data from file instead of hardcoded data

2017-08-29 Thread Nick Clifton
ered this (new) failure: cc1: error: -mlarge requires a 430X-compatible -mmcu= compiler exited with status 1 FAIL: gcc.target/msp430/no_devices_warn_msp430.c (test for excess errors) I think that you might need to extend the skip list in the test... Cheers Nick

Re: [PATCH] [MSP430] Pass -mcode/data-region to the linker and assembler

2017-08-30 Thread Nick Clifton
Hi Jozef, > The changes made in a series of binutils patches > (https://sourceware.org/ml/binutils/2017-08/msg00274.html) > to ld and gas require the -mcode/data-region options to be propagated > from gcc. > > The attached patch adds that functionality. Approved and applied. Cheers Nick

Re: PR translation/80280

2017-05-09 Thread Nick Clifton
at_std_version' to 'const char*' in initial Do you have time to fix this ? If not, please could you tell me which of the fields in the struct is new, and how it ought to be initialised. Cheers Nick

Re: PR translation/80280

2017-05-09 Thread Nick Clifton
extensions like > this. What a tangled mess. Oh go on - if it was easy you would be bored... > The fix should be trivial. My change added just a single member: > format_flag_spec::quoting. I can take care of it today, along > with bug 80673. Thanks very much! Cheers Nick

Re: [PATCH] [MSP430] PR78838: Do not add section name prefixes when section name is .lowtext

2017-05-30 Thread Nick Clifton
Hi Josef, Thanks for reporting this problem, and providing a patch to fix it. I have checked your patch in, along with one, very very minor change to the formatting of the comment in gen_prefix(). Cheers Nick

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-30 Thread Nick Clifton
0 0xd9ff22 msp430_data_attr gcc/current/gcc/config/msp430/msp430.c:1998 It seems that there is a problem with calling the DECL_SECTION_NAME macro on the line just before your new code. Are you able to reproduce this problem ? Cheers Nick

Re: [PATCH] Fix PR78189

2017-01-20 Thread Nick Clifton
xpected successes 21 < # of expected failures128 --- > # of expected passes 3037 > # of unexpected failures 127 > # of unexpected successes 24 > # of expected failures228 Which looks like a win to me. So - any objections to my applying this pa

RFA: Update XFAIL comments in

2017-01-20 Thread Nick Clifton
are not broken, it is just that, for these particular test cases, for these specific architectures (ARM, PPC), the unshrink- wrapped code is actually smaller than the shrink wrapped version. So - is it OK to apply the patch ? Cheers Nick gcc/testsuite/ChangeLog 2017-01-20 Nick Clifton

RFA: Patch for ARM PR77770

2017-01-25 Thread Nick Clifton
testsuite entry based upon the simplified test in the PR. So - OK to apply ? Cheers Nick Index: gcc/config/arm/thumb1.md === --- gcc/config/arm/thumb1.md(revision 244853) +++ gcc/config/arm/thumb1.md(working copy

Re: install.texi and arm

2017-03-13 Thread Nick Clifton
ubtargets include: >> Okay to yank this? > > Fine by me. Me too. > Nick, do you have any objections to this? None. Are you intending to replace the requirement with a more recent version of the binutils, or just remove the requirement entirely ? Cheers Nick

Re: RFA: PR 70044: Catch a second call to aarch64_override_options_after_change

2016-03-07 Thread Nick Clifton
d that made everything simple. So attached is a revised patch with the missing second hunk restored and a testcase added. (Which I have checked and confirmed that it does fail without the patch and it does pass with the patch applied). OK to apply ? Cheers Nick gcc/ChangeLog as before...

Re: RFA: PR 70044: Catch a second call to aarch64_override_options_after_change

2016-03-10 Thread Nick Clifton
#x27;s my bad and I'll propose a patch for it soon. > > I don't think I've seen this on list yet, it might be worth waiting until > Kyrill has put this patch up before you commit. I did this. Plus I checked to make sure that the patch still works and that the new test passes... Cheers Nick

Commit: ARM: Extend fix for PR 62254

2016-03-30 Thread Nick Clifton
Hi Guys, I am applying this patch as a further fix for PR 62254. In the long run we will hopefully be dropping support for ARM v3 (and earlier) so this is more in the nature of a plaster than a real fix. Cheers Nick gcc/ChangeLog 2016-03-30 Nick Clifton PR target/62254

Commit: MSP430: Update prototypes in libgcc

2016-04-25 Thread Nick Clifton
. Cheers Nick libgcc/ChangeLog 2016-04-25 Nick Clifton * config/msp430/cmpd.c (__mspabi_cmpf): Add prototype. (__mspabi_cmpd): Likewise. * config/msp430/floathidf.c (__floathidf): Likewise. * config/msp430/floathisf.c (__floathisf): Likewise * config/msp430

Commit: MSP430: Optimize 1 bit shifts

2016-04-25 Thread Nick Clifton
inline. Cheers Nick gcc/ChangeLog 2016-04-25 DJ Delorie * config/msp430/msp430.md (ashlhi3): Optimize one bit shifts. (ashrhi3): Likewise. (lshrhi3): Likewise. Index: gcc/config/msp430/msp430.md

<    1   2   3   4   5   6   >