Hi Guys,
I would like to close out PR 70681 by applying the patch below. It
updates the XFAIL comments in the two affected tests, explaining why
the check for shrink-wrapping will fail. There is nothing actually
wrong here. The shrink wrapping optimization is working and the
targets are not broken, it is just that, for these particular test
cases, for these specific architectures (ARM, PPC), the unshrink-
wrapped code is actually smaller than the shrink wrapped version.
So - is it OK to apply the patch ?
Cheers
Nick
gcc/testsuite/ChangeLog
2017-01-20 Nick Clifton <ni...@redhat.com>
* gcc.dg/pr10474.c: Update XFAIL comment to explain why the
check for shrink-wrapping can be expected to fail.
* gcc.dg/vect/vect-strided-a-u8-i2-gap.c: Likewise.
Index: gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c
===================================================================
--- gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c (revision 244691)
+++ gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c (working copy)
@@ -31,5 +31,7 @@
/* { dg-final { scan-rtl-dump "Will split live ranges of parameters" "ira" } } */
/* { dg-final { scan-rtl-dump "Split live-range of register" "ira" } } */
-/* XFAIL due to PR70681. */
+/* The XFAILs are because these targets produce better code without
+ shrinkwrapping, and hence the optimization is not triggered. See
+ PR70681 for more details. */
/* { dg-final { scan-rtl-dump "Performing shrink-wrapping" "pro_and_epilogue" { xfail arm*-*-* powerpc*-*-* } } } */
Index: gcc/testsuite/gcc.dg/pr10474.c
===================================================================
--- gcc/testsuite/gcc.dg/pr10474.c (revision 244691)
+++ gcc/testsuite/gcc.dg/pr10474.c (working copy)
@@ -12,5 +12,7 @@
}
}
-/* XFAIL due to PR70681. */
+/* The XFAILs are because these targets produce better code without
+ shrinkwrapping, and hence the optimization is not triggered. See
+ PR70681 for more details. */
/* { dg-final { scan-rtl-dump "Performing shrink-wrapping" "pro_and_epilogue" { xfail arm*-*-* powerpc*-*-* } } } */
