Re: [PATCH 4/5 ][P1] [PR tree-optimization/71437] Use a dominator order walk rather than random for VRP threading

2017-03-17 Thread Trevor Saunders
On Thu, Mar 16, 2017 at 01:17:13PM -0600, Jeff Law wrote: > +thread_outgoing_edges (basic_block bb, gcond *dummy_cond, > +class const_and_copies *const_and_copies, > +class avail_exprs_stack *avail_exprs_stack, nit picking, but what's the point in the class

Re: [RFA][PATCH][PR tree-optimization/64058] Improve and stabilize sorting of coalesce pairs

2016-03-14 Thread Trevor Saunders
On Mon, Mar 14, 2016 at 04:32:06PM -0600, Jeff Law wrote: > On 03/11/2016 03:02 AM, Richard Biener wrote: > > > > > >For the other part I noticed a few things > > 1) having a bitmap_count_ior_bits () would be an improvement > Yea, I almost built one. That's easy enough to add. > > > 2) you migh

Re: [PATCH 1/2] Fix new -Wparentheses warnings encountered during bootstrap

2016-03-31 Thread Trevor Saunders
On Thu, Mar 31, 2016 at 04:53:45PM -0400, Patrick Palka wrote: > This patch fixes the new -Wparentheses warnings (implemented by the > subsequent patch) that are encountered during bootstrap: > > /home/patrick/code/gcc/gcc/omp-low.c: In function ‘void > scan_sharing_clauses(tree, omp_context*, bo

Re: [PATCH] Fix PR c++/70452 (regression in C++ parsing performance)

2016-04-02 Thread Trevor Saunders
On Sat, Apr 02, 2016 at 05:18:31PM -0400, Patrick Palka wrote: > On Fri, 1 Apr 2016, Jason Merrill wrote: > > > I like this approach a lot. One thing, though: > > > > On 04/01/2016 03:13 PM, Patrick Palka wrote: > > > +struct GTY((chain_next ("%h.prev"))) bpr_entry > > > +{ > > > + tree body; >

Re: [PATCH 10/18] merge adjust_cost and adjust_cost_2 target hooks

2016-04-20 Thread Trevor Saunders
On Wed, Apr 20, 2016 at 07:17:03AM -0500, Segher Boessenkool wrote: > On Wed, Apr 20, 2016 at 02:22:14AM -0400, tbsaunde+...@tbsaunde.org wrote: > > * config/microblaze/microblaze.c (microblaze_adjust_cost): > > * Likewise. > > Stray * (here and elsewhere). > > > --- a/gcc/config/alpha/al

Re: [PATCH 00/18] towards removing rtx_insn_list and rtx_expr_list

2016-04-20 Thread Trevor Saunders
On Wed, Apr 20, 2016 at 06:03:01AM -0700, Andi Kleen wrote: > tbsaunde+...@tbsaunde.org writes: > > > I have some more patches that almost completely eliminate these, but I > > haven't > > tested the rest yet, and this is already a long series so it would be nice > > to > > get some of it out of

Re: [PATCH 11/18] add some utility methods to vec

2016-04-20 Thread Trevor Saunders
On Wed, Apr 20, 2016 at 11:13:42AM +0200, Richard Biener wrote: > On Wed, Apr 20, 2016 at 8:22 AM, wrote: > > From: Trevor Saunders > > > > Later patches use these functions, and I believe Mikhail has mentioned > > before > > he'd like to have begin / en

Re: [PATCH 08/18] make side_effects a vec

2016-04-22 Thread Trevor Saunders
On Thu, Apr 21, 2016 at 11:12:48PM -0600, Jeff Law wrote: > On 04/20/2016 12:22 AM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > > >gcc/ChangeLog: > > > >2016-04-19 Trevor Saunders > > > > * var-tracking.c (struct

Re: [PATCH 09/18] make pattern_regs a vec

2016-04-25 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 02:56:07PM +0200, Bernd Schmidt wrote: > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > > > >-static rtx_expr_list * > >+static vec > > extract_mentioned_regs (rtx x) > > { > >- rtx_expr_list *mentioned_regs = NULL; > >+ vec mentioned_regs = vNULL; > >sub

Re: [PATCH 01/18] stop using rtx_insn_list in reorg.c

2016-04-25 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 11:35:16AM +0200, Bernd Schmidt wrote: > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > >- rtx_insn_list *merged_insns = 0; > >+ auto_vec, 10> merged_insns; > > I see Jeff has already acked this, but some of the expressions here are > getting unwieldy. can we

Re: [PATCH 15/18] make nonlocal_goto_handler_labels a vec

2016-04-25 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 02:43:27PM +0200, Bernd Schmidt wrote: > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > >- remove_node_from_insn_list (insn, &nonlocal_goto_handler_labels); > >+ > >+ unsigned int len = vec_safe_length (nonlocal_goto_handler_labels); > >+ for (unsi

Re: [PATCH 07/18] loop-iv.c: make cond_list a vec

2016-04-25 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 02:28:51PM +0200, Bernd Schmidt wrote: > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > >+ unsigned int len = cond_list.length (); > >+ for (unsigned int i = len - 1; i < len; i--)

Re: [PATCH 12/18] haifa-sched.c: make insn_queue[] a vec

2016-04-25 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 03:55:15PM +0200, Bernd Schmidt wrote: > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > >-/* Remove INSN from queue. */ > >+/* Remove INSN at idx from queue. */ > >+static void > >+queue_remove (unsigned int q, unsigned int idx) > >+{ > >+ QUEUE_INDEX (insn_qu

Re: [PATCH] Fix a recent warning in reorg.c

2016-04-26 Thread Trevor Saunders
On Tue, Apr 26, 2016 at 09:03:03AM -0600, Jeff Law wrote: > On 04/26/2016 07:08 AM, Jakub Jelinek wrote: > >Hi! > > > >I've noticed a warning during bootstrap: > >../../gcc/reorg.c: In function ‘void try_merge_delay_insns(rtx_insn*, > >rtx_insn*)’: > >../../gcc/reorg.c:1431:12: warning: name looku

Re: [PATCH 07/18] loop-iv.c: make cond_list a vec

2016-04-26 Thread Trevor Saunders
On Mon, Apr 25, 2016 at 04:25:27PM +0200, Bernd Schmidt wrote: > On 04/25/2016 04:21 PM, Bernd Schmidt wrote: > >On 04/25/2016 03:30 PM, Trevor Saunders wrote: > >>On Mon, Apr 25, 2016 at 02:28:51PM +0200, Bernd Schmidt wrote: > >>>On 04/20/2016 08:22 AM, t

Re: [PATCH] fix-it hints for warn_uninit

2016-09-14 Thread Trevor Saunders
On Tue, Sep 13, 2016 at 08:45:25PM -0400, David Malcolm wrote: > We warn about uses of uninitialized variables from the middle end, via > warn_uninit. > > This patch adds the ability for such warnings to contain fix-it hints, > showing the user how to zero-initialize the relevant variables. > Natu

Re: [PATCH 3/9] selftest.h: add temp_override fixture

2016-09-14 Thread Trevor Saunders
On Thu, Sep 08, 2016 at 08:30:47PM -0400, David Malcolm wrote: > We have a lot of global state in our code. Ideally we'd reduce the > amount of such global state, but a prerequisite for sane refactoring > is having automated testing in place to ensure that the refactoring > doesn't break anything.

Re: [PATCH 1/8] change a few rtx_insn * to rtx_jump_insn *

2016-09-14 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 01:04:04PM +0900, Kaz Kojima wrote: > tbsaunde+...@tbsaunde.org wrote: > > @@ -2201,8 +2201,7 @@ fix_crossing_unconditional_branches (void) > > { > > if (!BARRIER_P (cur_insn)) > > BLOCK_FOR_INSN (cur_insn) = cur_bb; > > -

Re: [PATCH 1/8] change a few rtx_insn * to rtx_jump_insn *

2016-09-15 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 10:28:19AM +0200, Richard Biener wrote: > On Thu, Sep 15, 2016 at 6:31 AM, Trevor Saunders > wrote: > > On Thu, Sep 15, 2016 at 01:04:04PM +0900, Kaz Kojima wrote: > >> tbsaunde+...@tbsaunde.org wrote: > >> > @@ -2201,8 +2201,7 @@ fix_cros

Re: [PATCH 0/8] make next_*_insn take rtx_insn * arguments

2016-09-15 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 12:52:59PM +0200, Bernd Schmidt wrote: > On 09/14/2016 09:21 PM, tbsaunde+...@tbsaunde.org wrote: > > > Basically $subject. First change variable's type to rtx_insn * where > > possible. > > Then change the functions and fixup callers where it is still necessary to > > ca

Re: [PATCH 0/8] make next_*_insn take rtx_insn * arguments

2016-09-15 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 10:27:56AM -0600, Jeff Law wrote: > On 09/15/2016 10:10 AM, Trevor Saunders wrote: > > On Thu, Sep 15, 2016 at 12:52:59PM +0200, Bernd Schmidt wrote: > > > On 09/14/2016 09:21 PM, tbsaunde+...@tbsaunde.org wrote: > > > > > > > Basic

Re: [PATCH 0/8] make next_*_insn take rtx_insn * arguments

2016-09-16 Thread Trevor Saunders
On Thu, Sep 15, 2016 at 10:27:56AM -0600, Jeff Law wrote: > On 09/15/2016 10:10 AM, Trevor Saunders wrote: > > On Thu, Sep 15, 2016 at 12:52:59PM +0200, Bernd Schmidt wrote: > > > On 09/14/2016 09:21 PM, tbsaunde+...@tbsaunde.org wrote: > > > > > > > Basic

Re: [PATCH 0/8] make next_*_insn take rtx_insn * arguments

2016-09-16 Thread Trevor Saunders
On Fri, Sep 16, 2016 at 12:10:51PM +0200, Bernd Schmidt wrote: > On 09/16/2016 12:10 PM, Trevor Saunders wrote: > > ok, going through all the casts added here I see the following reasons > > for them. > > > > - in md files operands is a array of rtx, we should probably

Re: [PATCH 0/8] make next_*_insn take rtx_insn * arguments

2016-09-19 Thread Trevor Saunders
On Mon, Sep 19, 2016 at 02:49:49PM -0600, Jeff Law wrote: > On 09/16/2016 04:10 AM, Trevor Saunders wrote: > > On Thu, Sep 15, 2016 at 10:27:56AM -0600, Jeff Law wrote: > > > On 09/15/2016 10:10 AM, Trevor Saunders wrote: > > > > On Thu, Sep 15, 2016 at 12:52:5

Re: [PATCH 3/8] make next/prev _nonnote_insn take rtx_insn *

2016-09-19 Thread Trevor Saunders
On Mon, Sep 19, 2016 at 03:23:58PM -0600, Jeff Law wrote: > On 09/14/2016 01:21 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-09-13 Trevor Saunders > > > > * emit-rtl.c (next_nonnote_in

Re: [PATCH 7/8] make next/prev active_insn and active_insn_p take rtx_insn *

2016-09-19 Thread Trevor Saunders
On Mon, Sep 19, 2016 at 03:17:33PM -0600, Jeff Law wrote: > On 09/14/2016 01:21 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-09-14 Trevor Saunders > > > > * emit-rtl.c (next_active_in

Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context

2016-09-20 Thread Trevor Saunders
On Tue, Sep 20, 2016 at 05:30:36PM +0200, Bernd Schmidt wrote: > On 09/20/2016 05:18 PM, Jeff Law wrote: > > > I assume HARD_FRAME_POINTER_REGNUM is never zero. > > It could be zero. It's just a hard register number. No target has the > > property that its hard frame pointer register is 0 though

Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context

2016-09-20 Thread Trevor Saunders
On Wed, Sep 21, 2016 at 01:13:41AM +0200, Bernd Schmidt wrote: > On 09/21/2016 01:09 AM, Trevor Saunders wrote: > > > > I thought I remember discussing this macro with you, but see what was > > checked in I'll believe I'm thinking of something similar but different

Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context

2016-09-21 Thread Trevor Saunders
On Tue, Sep 20, 2016 at 11:48:04PM -0400, Eric Gallager wrote: > On 9/20/16, Trevor Saunders wrote: > > On Wed, Sep 21, 2016 at 01:13:41AM +0200, Bernd Schmidt wrote: > >> On 09/21/2016 01:09 AM, Trevor Saunders wrote: > >> > > >> > I thought I rememb

Re: [PATCH] Extend -Wint-in-bool-context to suspicious enum values (PR 77700)

2016-10-08 Thread Trevor Saunders
On Fri, Oct 07, 2016 at 03:18:07PM +, Bernd Edlinger wrote: > Hi! > > This extends -Wint-in-bool-context to uses of enum values in boolean > context, and fixes one place where accidentally an enum value was > passed to a bool parameter. > > I excluded enum values 0 and 1 because that is used

Re: [PATCH] Make EVRP propagate into PHIs and remove dead stmts

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 02:34:58PM +0200, Richard Biener wrote: > > The following patch makes EVRP remove stmts that will become dead > after propagation. For this to work we have to propagate into PHIs > (sth we missed as well). > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. >

Re: [PATCH 7/7] make targetm.gen_ccmp{first,next} take rtx_insn **

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 01:25:55PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-10-17 Trevor Saunders > > > > * ccmp.c (expand_cc

Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 01:18:42PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > { > > - rtx r0, r16, eqv, tga, tp, insn, dest, seq; > > + rtx r0, r16, eqv, tga, tp, dest, seq; > > + rtx_insn *insn; > > > >switch (tls_symboli

Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 03:54:43PM +0200, Bernd Schmidt wrote: > On 10/18/2016 03:54 PM, Trevor Saunders wrote: > > > > I do really prefer reading code where variables are declared at first > > use > > In general, so do I, but in this case it's one variable out

Re: [PATCH 7/7] make targetm.gen_ccmp{first,next} take rtx_insn **

2016-10-26 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 01:25:55PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-10-17 Trevor Saunders > > > > * ccmp.c (expand_cc

Re: [PATCH][GIMPLE FE] Split out parser into separate file

2016-10-26 Thread Trevor Saunders
On Tue, Oct 25, 2016 at 03:33:36PM +0200, Richard Biener wrote: > > Hi, > > so I did the massaging to split out the GIMPLE parsing routines out > to a separate file (quite tricky to get the gengtype issues correctly > so I thought to help out here and get things started). actually it looks like

Re: [PATCH][GIMPLE FE] Split out parser into separate file

2016-10-27 Thread Trevor Saunders
On Thu, Oct 27, 2016 at 09:28:31AM +0200, Richard Biener wrote: > On Thu, 27 Oct 2016, Trevor Saunders wrote: > > > On Tue, Oct 25, 2016 at 03:33:36PM +0200, Richard Biener wrote: > > > > > > Hi, > > > > > > so I did the massaging to split out the

Re: RFD: Buffer handling for ASM_GENERATE_INTERNAL_LABEL

2016-10-29 Thread Trevor Saunders
On Fri, Oct 28, 2016 at 09:42:10PM -0600, Jeff Law wrote: > > Consider this definition of ASM_GENERATE_INTERNAL_LABEL (from sp64-elf.h): > > #undef ASM_GENERATE_INTERNAL_LABEL > #define ASM_GENERATE_INTERNAL_LABEL(LABEL,PREFIX,NUM) \ > sprintf ((LABEL), "*.L%s%ld", (PREFIX), (long)(NUM)) >

Re: [PATCH 0/3] use rtx_insn * more

2016-11-01 Thread Trevor Saunders
On Mon, Oct 31, 2016 at 07:37:54AM -0600, Jeff Law wrote: > On 10/28/2016 01:13 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > HI, > > > > This series changes various variables type from rtx to rtx_insn * so that > > the > &

Re: [PATCH 0/3] use rtx_insn * more

2016-11-02 Thread Trevor Saunders
On Wed, Nov 02, 2016 at 05:35:40PM +0100, Bernd Schmidt wrote: > On 11/02/2016 03:55 PM, David Malcolm wrote: > > > Did you mean this patch: > > https://gcc.gnu.org/ml/gcc-patches/2016-10/msg01358.html > > That one is ok after the test, sorry for not being more clear. ah, no worries :) and sor

Re: [PATCH 0/6] remove some usage of rtx_{insn,expr}_list

2016-07-06 Thread Trevor Saunders
On Fri, Jul 01, 2016 at 03:34:51PM +0200, Bernd Schmidt wrote: > On 06/21/2016 04:47 PM, Trevor Saunders wrote: > > On Mon, Jun 20, 2016 at 06:52:35PM +0200, Bernd Schmidt wrote: > > > > So that's a second more in real time - was the machine very busy at the > >

Re: [PATCH 0/9] remove some manual memory management

2016-07-06 Thread Trevor Saunders
On Thu, Jun 30, 2016 at 12:33:24PM +0200, Bernd Schmidt wrote: > On 06/29/2016 02:26 PM, tbsaunde+...@tbsaunde.org wrote: > > patches individually bootstrapped and regtested on x86_64-linux-gnu, ok? > > I think these all look sensible. ChangeLogs ought to have slightly more > information than "Adj

Re: [Driver] Add support for -fuse-ld=lld

2016-07-06 Thread Trevor Saunders
On Mon, Jul 04, 2016 at 09:36:52PM +0200, Markus Trippelsdorf wrote: > On 2016.07.04 at 10:08 -0700, H.J. Lu wrote: > > On Sun, Jul 3, 2016 at 9:38 PM, Davide Italiano > > wrote: > > > On Thu, Jun 23, 2016 at 9:11 PM, Davide Italiano > > > wrote: > > >> + HJ who wrote the code for the option or

Re: [PATCH] Avoid invoking ranlib on libbackend.a

2016-07-17 Thread Trevor Saunders
On Sun, Jul 17, 2016 at 10:04:13PM -0400, Patrick Palka wrote: > On Sun, 17 Jul 2016, David Edelsohn wrote: > > > On Sun, Jul 17, 2016 at 10:43 AM, Patrick Palka > > wrote: > > > On Sun, Jul 17, 2016 at 9:15 AM, David Edelsohn wrote: > > >>> Patrick Palka writes: > > >> > > >>> Hmm, this is

Re: [PATCH 2/6] use auto_sbitmap in various places

2016-07-25 Thread Trevor Saunders
On Mon, Jul 25, 2016 at 11:18:07AM -0600, Jeff Law wrote: > On 07/24/2016 05:44 AM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-07-24 Trevor Saunders > > > > * bt-load.c (compute_out): U

Re: [PATCH 1/6] add auto_sbitmap class

2016-07-25 Thread Trevor Saunders
On Mon, Jul 25, 2016 at 09:30:07AM -0600, Jeff Law wrote: > On 07/24/2016 10:28 AM, Richard Biener wrote: > > On July 24, 2016 1:44:44 PM GMT+02:00, tbsaunde+...@tbsaunde.org wrote: > > > From: Trevor Saunders > > > > > > gcc/ChangeLog: >

Re: [PATCH 1/3] make pattern_regs a vec

2016-07-27 Thread Trevor Saunders
On Wed, Jul 27, 2016 at 04:15:02PM -0600, Jeff Law wrote: > On 07/24/2016 03:10 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-07-24 Trevor Saunders > > > > * store-motion.c

Re: [2/67] Make machine_mode a class

2016-12-15 Thread Trevor Saunders
On Fri, Dec 09, 2016 at 12:52:03PM +, Richard Sandiford wrote: > This patch renames enum machine_mode to enum machine_mode_enum > and adds a machine_mode wrapper class. > > The previous patch mechanically replaced mode names in case > statements; this one updates other places that should conti

Re: [RFA] [PR tree-optimization/33562] [PATCH 1/4] Byte tracking in DSE

2016-12-15 Thread Trevor Saunders
On Thu, Dec 15, 2016 at 06:54:43PM -0700, Jeff Law wrote: >unsigned cnt = 0; > + bitmap live_bytes = NULL; > + bitmap orig_live_bytes = NULL; > >*use_stmt = NULL; > > + /* REF is a memory write. Go ahead and get its base, size, extent > + information and encode the bytes written

Re: [PATCH 1/4] PR c++/62314: add fixit hint for missing "template <> " in explicit specialization

2016-04-28 Thread Trevor Saunders
On Thu, Apr 28, 2016 at 10:28:15AM -0400, David Malcolm wrote: > This is a resend of a patch kit I sent in stage 3; the original post > was here: > https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01933.html > > I've rebased the patches against yesterday's trunk and retested them. > > They add var

Re: [PATCH 12/18] haifa-sched.c: make insn_queue[] a vec

2016-05-03 Thread Trevor Saunders
On Tue, May 03, 2016 at 02:36:55PM +0200, Bernd Schmidt wrote: > On 04/25/2016 04:17 PM, Trevor Saunders wrote: > > On Mon, Apr 25, 2016 at 03:55:15PM +0200, Bernd Schmidt wrote: > > > On 04/20/2016 08:22 AM, tbsaunde+...@tbsaunde.org wrote: > > > &

Re: [PATCH 1/2] Add OVERRIDE and FINAL macros to coretypes.h

2016-05-06 Thread Trevor Saunders
On Fri, May 06, 2016 at 07:10:33PM +0100, Pedro Alves wrote: > On 05/06/2016 06:56 PM, Pedro Alves wrote: > > > If building gcc as a C++11 program is supported, then it > > won't be possible to use these names as symbols for > > anything else anyway? > > Just found out the above is not true. App

Re: [PATCH] [rtlfe] Barebones implementation of "__RTL"; next steps?

2016-05-10 Thread Trevor Saunders
On Tue, May 10, 2016 at 05:01:00PM -0400, David Malcolm wrote: > [CCing Prasad since this may be useful for his gimple FE work, by > replacing "rtl" with "gimple" in the patch] > > On Mon, 2016-05-09 at 11:44 +0200, Richard Biener wrote: > > On Wed, May 4, 2016 at 10:49 PM, David Malcolm > > wrot

Re: [PATCH 3/3] jit: implement gcc_jit_rvalue_set_bool_require_tail_call

2016-05-17 Thread Trevor Saunders
On Tue, May 17, 2016 at 06:01:32PM -0400, David Malcolm wrote: > This implements the libgccjit support for must-tail-call via > a new: > gcc_jit_rvalue_set_bool_require_tail_call > API entrypoint. It seems to me like that's not a great name, the rvalue and bool parts are just about the argument

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-07 Thread Trevor Saunders
On Fri, Aug 07, 2015 at 10:45:57AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Thu, Aug 06, 2015 at 08:36:36PM +0100, Richard Sandiford wrote: > >> An integrated assembler or tighter asm output would be nice, but when > >> I last checked LLVM was u

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-10 Thread Trevor Saunders
On Mon, Aug 10, 2015 at 03:56:02PM +0200, Markus Trippelsdorf wrote: > On 2015.08.10 at 08:05 -0400, tbsaunde+...@tbsaunde.org wrote: > > > > In many places gcc puts classes in the anon namespace so the compiler can > > tell > > they do not get inheritted from to enable better devirtualization.

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Trevor Saunders
On Wed, Aug 12, 2015 at 03:31:35PM -0400, David Edelsohn wrote: > This patch has caused a bootstrap failure on AIX. reverted, though my bet is this is some sort of generic devirt bug on aix. Trev > > - David

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-12 Thread Trevor Saunders
On Wed, Aug 12, 2015 at 01:03:36PM -0600, Jeff Law wrote: > On 08/12/2015 12:57 PM, Richard Sandiford wrote: > >Jeff Law writes: > >>On 08/10/2015 06:05 AM, tbsaunde+...@tbsaunde.org wrote: > >>>From: Trevor Saunders > >>> > >>>Hi, > >&

Re: [PATCH 2/2] replace several uses of the anon namespace with GCC_FINAL

2015-08-14 Thread Trevor Saunders
On Thu, Aug 13, 2015 at 07:56:47PM +0300, Mikhail Maltsev wrote: > On 08/12/2015 11:36 PM, Trevor Saunders wrote: > > In many places gcc puts classes in the anon namespace so the compiler can > > tell > > they do not get inheritted from to enable better devirtualization.

Re: [PATCH] remove more useless typedefs

2015-08-19 Thread Trevor Saunders
gnu, commited since preapproved > > by richi. > > [...] > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > > index db23a0f..32421c5 100644 > > --- a/gcc/ChangeLog > > +++ b/gcc/ChangeLog > > @@ -1,3 +1,15 @@ > > +2015-08-18 Trevor Saunders > >

Re: [PATCH 00/11] more rtx_insn * stuff

2016-11-14 Thread Trevor Saunders
On Mon, Nov 14, 2016 at 02:45:40PM +0100, Bernd Schmidt wrote: > On 11/14/2016 09:09 AM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > Hi, > > > > Basically $subject which gets rid of a few more casts over all. > > > > I ment

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > Markus Trippelsdorf writes: > > > >> Many developers are still using __attribute__((optimize())) in > >> production code, although it quite broken. > > > > Wo reads documentati

Re: [PATCH] doc: discourage use of __attribute__((optimize())) in production code

2015-12-14 Thread Trevor Saunders
On Mon, Dec 14, 2015 at 05:40:57PM +0100, Markus Trippelsdorf wrote: > On 2015.12.14 at 11:20 -0500, Trevor Saunders wrote: > > On Mon, Dec 14, 2015 at 10:01:27AM +0100, Richard Biener wrote: > > > On Sun, Dec 13, 2015 at 9:03 PM, Andi Kleen wrote: > > > &g

Re: RFA (hash-*): PATCH for c++/68309

2015-12-14 Thread Trevor Saunders
> > + hash_map (const hash_map &h, bool ggc = false, > + bool gather_mem_stats = true CXX_MEM_STAT_INFO) sorry about the late response, but wouldn't it be better to make this and the hash_table constructor explicit? Its probably less important than other constructors, but is there a re

Re: [PATCH 0/2] obsolete some old targets

2015-12-15 Thread Trevor Saunders
On Tue, Dec 15, 2015 at 02:32:47PM -0700, Jeff Law wrote: > On 12/14/2015 08:55 PM, tbsaunde+...@tbsaunde.org wrote: > >From: Trevor Saunders > > > >Hi, > > > >http://gcc.gnu.org/ml/gcc-patches/2015-12/msg00365.html reminded me I hadn't > >gotten

Re: [PATCH 0/2] obsolete some old targets

2015-12-17 Thread Trevor Saunders
t's what I thought from googling, so I'll just go ahead and commit these patches. Trev > > Thanks, > > > Sent: Thursday, December 17, 2015 at 3:24 PM > > From: "Trevor Saunders" > > To: "Kamil Rytarowski" > > Cc: tbsaunde+...@tbsaun

Re: [PATCH 0/2] obsolete some old targets

2015-12-17 Thread Trevor Saunders
On Tue, Dec 15, 2015 at 03:25:18PM -0700, Jeff Law wrote: > On 12/15/2015 03:02 PM, Trevor Saunders wrote: > >> > >>Can you mark interix as obsolete? It hasn't even built for a long time. > > > > Sure, I can do that if you want, I just wasn't sure befo

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Trevor Saunders
On Thu, Dec 17, 2015 at 12:53:20PM -0700, Jeff Law wrote: > On 12/17/2015 11:58 AM, Jan-Benedict Glaw wrote: > >On Thu, 2015-12-17 11:39:24 -0700, Jeff Law wrote: > >>On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > >>>On Thu, 2015-12-17 11:05:42 -0700, Jeff Law wrote: > On 12/16/2015 03:46

Re: [PATCH] C: fix reported range of invalid unary dereference.

2015-12-22 Thread Trevor Saunders
On Tue, Dec 22, 2015 at 12:26:29PM -0500, David Malcolm wrote: > Currently, trunk emits this for a bad unary * in C: > > bad-dereference.c:10:10: error: invalid type argument of unary ‘*’ (have > ‘int’) >return *some_f.x; > ^ > > The following patch fixes the reported location to h

Re: Optimise hash_table::empty

2016-01-15 Thread Trevor Saunders
On Fri, Jan 15, 2016 at 06:00:10PM +, Richard Sandiford wrote: > Calling redirect_edge_var_map_empty after each pass was slowing things > down because hash_table::empty () cleared all slots even if the hash > table was already empty. > > Tested on x86_64-linux-gnu, where it gives a 1% compile

Re: [C++] Add -fnull-this-pointer

2016-01-19 Thread Trevor Saunders
On Tue, Jan 19, 2016 at 01:11:44PM +0100, Jan Hubicka wrote: > Hi, > according to Trevor, the assumption about THIS pointer being non-NULL breaks That was Markus, not me. > several bigger C++ packages (definitly including Firefox, but I believe > kdevelop was mentioned, too). This patch makes th

Re: [PATCH 2/2] [C++] pr31397 - implement -Wsuggest-override

2014-12-18 Thread Trevor Saunders
On Wed, Dec 17, 2014 at 04:21:31PM -0500, Jason Merrill wrote: > On 11/27/2014 01:28 AM, tsaund...@mozilla.com wrote: > >+ if (warn_override && DECL_VIRTUAL_P (decl) && !DECL_OVERRIDE_P (decl) > > Why check DECL_VIRTUAL_P here? I think it was to avoid warning when decl is hiding a non virtua

Re: [PATCHv3][PING] New check and updates in check_GNU_style script

2015-01-07 Thread Trevor Saunders
On Wed, Jan 07, 2015 at 12:41:57PM +, Mantas Mikaitis wrote: > On 26/12/14 06:46, Yury Gribov wrote: > >On 12/19/2014 11:14 AM, Yury Gribov wrote: > >>Hi all, > >> > >>Attached patch adds new check (all blocks of 8 spaces are replaced with > >>tabs) to contrib/check_GNU_style.sh. It also change

Re: [PATCH] support ggc hash_map and hash_set

2014-09-09 Thread Trevor Saunders
/gcc.gnu.org/bugs.html> for instructions. > > FAIL: ./array-1.H -g (internal compiler error) > FAIL: ./array-1.H -g (test for excess errors) > Excess errors: > ./array-1.H:4:2: internal compiler error: in relocate_ptrs, at > ggc-common.c:435 > > --Alan > > t

Re: [PATCH 1/2] add staticly checked label_nuses accessors

2014-09-11 Thread Trevor Saunders
On Thu, Sep 11, 2014 at 02:55:43PM -0600, Jeff Law wrote: > On 09/05/14 16:38, Trevor Saunders wrote: > > > >So, in this case it seems to me you basically have two options > > > >A. change the macro to an inline function, and fix up all the callers to > >pass the r

Re: [PATCH 2/2] add static typed insn_deleted_p

2014-09-11 Thread Trevor Saunders
On Thu, Sep 11, 2014 at 08:06:02PM -0400, David Malcolm wrote: > On Thu, 2014-09-11 at 18:49 -0400, tsaund...@mozilla.com wrote: > > From: Trevor Saunders > > > > Hi, > > > > This changes all callers of INSN_DELETED_P to use one of insn->deleted

Re: [PATCHv3] Vimrc config with GNU formatting

2014-09-16 Thread Trevor Saunders
On Tue, Sep 16, 2014 at 08:38:58PM +0400, Yury Gribov wrote: > Hi all, > > This is the third version of the patch. A list of changes since last > version: > * move config to contrib so that it's _not_ enabled by default (current > score is 2/1 in favor of no Vim config by default) fwiw, I think e

Re: [PATCH, PR63229] fix assert in hash_table pch routines

2014-09-23 Thread Trevor Saunders
On Fri, Sep 19, 2014 at 11:23:11AM +0100, Richard Sandiford wrote: > tsaund...@mozilla.com writes: > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > > index c048672..5b27aa8 100644 > > --- a/gcc/ChangeLog > > +++ b/gcc/ChangeLog > > @@ -1,3 +1,8 @@

Re: [PATCH] Put all MAINTAINERS email addresses into <...>

2014-09-26 Thread Trevor Saunders
On Fri, Sep 26, 2014 at 03:14:16PM +0200, Steven Bosscher wrote: > On Fri, Sep 26, 2014 at 3:09 PM, Segher Boessenkool wrote: > > On Thu, Sep 25, 2014 at 11:10:00PM +0200, Jan-Benedict Glaw wrote: > >> Resending this email. Seems some spam filter ate it due to the many > >> email addresses... > > >

start cleaning up the pretty printers

2013-07-31 Thread Trevor Saunders
Hi! its my first time sending patches here so please be gentle :) I'm working on further patches to use c++ inheritance instead of macros here, but I figured I might as well send these out now. Trev

[PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it

2013-07-31 Thread Trevor Saunders
bootstrapped and same test results on x86_64-linux-gnu against r201084 gcc/cp/ * cxx-pretty-print.h (cxx_pretty_printer): inherit from c_pretty_printer instead of include it. * (cxx_pretty_print.c): adjust accordingly. --- gcc/cp/cxx-pretty-print.c | 40 ++

[PATCH 2/2] rm pp_c_base sub classes should just inherit from c_pretty_printer and things should just work

2013-07-31 Thread Trevor Saunders
bootstrapped and same test results on x86_64-linux-gnu against r201084 gcc/c-family/ * c-pretty-print.h (PP_C_BASE): remove macro. * c-pretty-print.c adjust accordingly. gcc/cp/ * cxx-pretty-print.c adjust accordingly. * cxx-pretty-print.h adjust accordingl

Re: [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it

2013-07-31 Thread Trevor Saunders
On Wed, Jul 31, 2013 at 10:02:29PM -0500, Gabriel Dos Reis wrote: > On Wed, Jul 31, 2013 at 8:14 PM, Trevor Saunders > wrote: > > bootstrapped and same test results on x86_64-linux-gnu against r201084 > > > > gcc/cp/ > > * cxx-pretty-print.h (cxx

Re: [PATCH 1/2] make the c++ pretty printer inherit from the C one instead of include it

2013-08-04 Thread Trevor Saunders
On Wed, Jul 31, 2013 at 10:02:29PM -0500, Gabriel Dos Reis wrote: > * declare the "pointer to function fields" as virtual functions -- > that is what I meant > with the (necessarily poor) emulation through the casts. I guess you'll work on this later in the patch series you're sending, but i

Re: [GSoC] use obstack in parse_c_expr

2014-04-25 Thread Trevor Saunders
On Fri, Apr 25, 2014 at 05:09:57PM +0530, Prathamesh Kulkarni wrote: > On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo wrote: > > Please remember to send patches to gcc-patches. > > > > I'm wondering if you couldn't just use std::string here. No need to change > > one complicated allocation scheme

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > Hi, > Shall it a good idea to add new warning -Wsizeof-array-argument that > warns when sizeof is applied on parameter declared as an array ? Seems reasonable enough. > Similar to clang's -Wsizeof-array-argument: > http://

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders > wrote: > > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > >> Hi, > >> Shall it a good idea to add new warnin

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 09:08:50AM +0400, Yury Gribov wrote: > Hi Trevor, > > I think this looks rather useful. sounds great! > > +if (-d .git) { > > What about moving default name/addr (with finger, etc.) to else branch? Well, consider the case git doesn't know, that said I could do if (-d .

Re: [PATCH 2/2] allow running mklog as a filter

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 09:18:39AM +0400, Yury Gribov wrote: > >+# XXX We should probably accept /dev/stdin or maybe magic autodetection of > >+# being supposed to get the patch from stdin. > >+# > > Can we just set $diff to '-' if @ARGV is empty? sgtm > >+# In any case if we got the diff on std

Re: [PATCH 5/6] add finalizers to ggc

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 02:58:11PM +0200, Richard Biener wrote: > On Tue, Apr 29, 2014 at 1:08 PM, wrote: > > From: Trevor Saunders > > > > Hi, > > > > This implements finalizers by keeping a list of registered finalizers > > and after every mark but befo

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-04-29 Thread Trevor Saunders
On Tue, Apr 29, 2014 at 10:39:00AM -0500, seg...@kernel.crashing.org wrote: > > +# if this is a git tree then take name and email from the git configuration > > +if (-d .git) { > > + $gitname = `git config user.name`; > > + chomp($gitname); > > + if ($gitname) { > > + $name = $gitname; > > +

Re: [PATCH 2/6] don't have gengtype autocreate allocation macros for variably sized types

2014-04-30 Thread Trevor Saunders
On Wed, Apr 30, 2014 at 11:18:18AM +0200, Richard Biener wrote: > On Wed, Apr 30, 2014 at 11:04 AM, Laurynas Biveinis > wrote: > >> ISTR we went to typed allocs as part of a transition which not > >> fully materialised? > > > > Yes. I had plans to replace the call-based GC marker routines with a >

Re: [PATCH 0/3] Compile-time gimple checking, without typedefs

2014-05-05 Thread Trevor Saunders
On Mon, May 05, 2014 at 01:44:06PM -0600, Jeff Law wrote: > On 05/05/14 11:37, Richard Biener wrote: > > > >Well, I hope that Andrew doesn't do without a namespace (and I still > >don't believe in what he tries to achieve without laying proper ground-work > >throughout the compiler). With a namesp

Re: [SH, committed] add missing function* argument in sh_optimize_sett_clrt::execute

2014-05-05 Thread Trevor Saunders
On Sat, May 03, 2014 at 10:24:31PM +0200, Oleg Endo wrote: > Hi, > > I've committed the attached patch as r210040, which reinstates the RTL > pass. > > Trevor, could you please double check that you haven't missed any other > cases in your pass refactoring patches? I have no clue how this happen

Re: RFC: Faster for_each_rtx-like iterators

2014-05-07 Thread Trevor Saunders
On Wed, May 07, 2014 at 09:52:49PM +0100, Richard Sandiford wrote: > I noticed for_each_rtx showing up in profiles and thought I'd have a go > at using worklist-based iterators instead. So far I have three: > > FOR_EACH_SUBRTX: iterates over const_rtx subrtxes of a const_rtx > FOR_EACH_SUBRTX

Re: RFC: Faster for_each_rtx-like iterators

2014-05-08 Thread Trevor Saunders
On Thu, May 08, 2014 at 07:25:50AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Wed, May 07, 2014 at 09:52:49PM +0100, Richard Sandiford wrote: > >> I noticed for_each_rtx showing up in profiles and thought I'd have a go > >> at using worklist-

Re: [PATCH 0/2] Make option-lookup macros explicit

2014-05-09 Thread Trevor Saunders
On Fri, May 09, 2014 at 05:14:45PM -0400, David Malcolm wrote: > GCC's code is full of references to options like: > > static bool > gate_vrp (void) > { > return flag_tree_vrp != 0; > } > > where "flag_tree_vrp" is actually an autogenerated macro to: > > global_options.x_flag_tree_

Re: [PATCH 4/5] add finalizers to ggc

2014-05-17 Thread Trevor Saunders
On Tue, May 13, 2014 at 11:41:46AM +0200, Richard Biener wrote: > On Tue, May 13, 2014 at 8:41 AM, wrote: > > From: Trevor Saunders > > > > This implements finalizers by keeping a list of registered finalizers > > and after every mark but before sweeping check to see

Re: RFA: speeding up dg-extract-results.sh

2014-05-24 Thread Trevor Saunders
On Sat, May 24, 2014 at 10:14:54AM -0700, Mike Stump wrote: > On May 24, 2014, at 4:17 AM, Bernd Schmidt wrote: > > On 02/13/2014 10:18 AM, Richard Sandiford wrote: > >> contrib/ > >>* dg-extract-results.py: New file. > >>* dg-extract-results.sh: Use it if the environment seems suitable. >

Re: [RFC] Add patch for debugging compiler ICEs

2014-05-27 Thread Trevor Saunders
On Mon, May 26, 2014 at 11:54:04AM +0400, Maxim Ostapenko wrote: > Hi, > > A years ago there was a discussion ( > https://gcc.gnu.org/ml/gcc-patches/2004-01/msg02437.html) about debugging > compiler ICEs that resulted in a patch from Jakub, which dumps useful > information into temporary file, but

<    1   2   3   4   5   >