[openacc] Make oacc_fn_attrib_level external

2018-12-19 Thread Tom de Vries
[ was: Fwd: [openacc, committed] Add oacc_get_default_dim ] On 19-12-18 16:27, Tom de Vries wrote: > [ Adding gcc-patches ] > > Forwarded Message > Subject: [openacc, committed] Add oacc_get_default_dim > Date: Wed, 19 Dec 2018 16:24:25 +0100 > From: Tom de V

[nvptx, committed] Add PTX_CTA_SIZE

2018-12-19 Thread Tom de Vries
[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0005-nvptx-update-openacc-dim-macros.patch Factored out this patch. Committed. Thanks, - Tom [nvptx] Add PTX_CTA_SIZE 2018-12-17 Tom de Vries * config/nvptx/nvptx.c (PTX_CTA_SIZE): Define. ---

Fwd: [RFC, openacc] Ensure oacc_replace_fn_attrib replaces

2018-12-20 Thread Tom de Vries
[ add gcc-patches ] Forwarded Message Subject: [RFC, openacc] Ensure oacc_replace_fn_attrib replaces Date: Thu, 20 Dec 2018 00:40:56 +0100 From: Tom de Vries To: Thomas Schwinge Hi, this looks like a good cleanup. WDYT? Thanks, - Tom [openacc] Ensure oacc_replace_fn_attrib

Re: [nvptx] vector length patch series

2018-12-21 Thread Tom de Vries
On 14-12-18 20:58, Tom de Vries wrote: > 0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch > 0017-nvptx-Enable-large-vectors.patch 1. If I void nvptx_adjust_parallelism like this: ... static unsigned nvptx_adjust_parallelism (unsigned inner_mask, unsigned outer_mask) {

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-29 Thread Tom de Vries
On 29-12-18 07:40, Gerald Pfeifer wrote: > On Fri, 23 Nov 2018, Tom de Vries wrote: >> When building libbacktrace, we typically use elf.c, and don't build >> pecoff.c, xcoff.c or unknown.c >> >> Add testcases that use unused format to ensure that we also buil

Re: [nvptx] vector length patch series -- openacc parts

2019-01-03 Thread Tom de Vries
On 18-12-18 00:52, Tom de Vries wrote: > On 14-12-18 20:58, Tom de Vries wrote: > >> 0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch > Hi Thomas, ping. OK for trunk? Thanks, - Tom

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-03 Thread Tom de Vries
On 02-01-19 14:20, Rainer Orth wrote: > Unfortunately, libbacktrace is one of those libraries that don't produce > Dejagnu-style .sum and .log files, so test failures are buried in the > make check output and very easily overlooked. FTR, I've filed PR88002 - "libbacktrace and libiberty tests don't

[committed][nvptx] Eliminate changed local var in nvptx_goacc_validate_dims

2019-01-03 Thread Tom de Vries
, - Tom [nvptx] Eliminate changed local var in nvptx_goacc_validate_dims 2019-01-03 Tom de Vries * config/nvptx/nvptx.c (nvptx_goacc_validate_dims_1): New function, factored out of ... (nvptx_goacc_validate_dims): ... here. --- gcc/config/nvptx/nvptx.c | 38

[committed][nvptx] Add early-out cases in nvptx_goacc_validate_dims

2019-01-03 Thread Tom de Vries
Hi, Add early-out cases for for oacc_min_dims_p and routine_p in nvptx_goacc_validate_dims, allowing simplification of the rest of the function. Committed to trunk. Thanks, - Tom [nvptx] Add early-out cases in nvptx_goacc_validate_dims 2019-01-03 Tom de Vries * config/nvptx

Re: [nvptx] vector length patch series

2019-01-03 Thread Tom de Vries
On 14-12-18 20:58, Tom de Vries wrote: > 0007-nvptx-consolidate-offloaded-function-attributes-into.patch > diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c > index a3169febbb4..dcfa57d10ca 100644 > --- a/gcc/config/nvptx/nvptx.c > +++ b/gcc/config/nvptx/nvptx

Re: [nvptx] vector length patch series

2019-01-03 Thread Tom de Vries
On 14-12-18 20:58, Tom de Vries wrote: > 0012-nvptx-Add-axis_dim.patch > diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c > index 74a0d4b04d9..02ecf12bd84 100644 > --- a/gcc/config/nvptx/nvptx.c > +++ b/gcc/config/nvptx/nvptx.c > @@ -2885,6 +2885,23 @@ st

Re: [nvptx] vector length patch series

2019-01-03 Thread Tom de Vries
On 14-12-18 20:58, Tom de Vries wrote: > 0016-nvptx-Add-vector_length-128-testcases.patch > * testsuite/libgomp.oacc-c-c++-common/vred2d-128.c: New test. > > * testsuite/libgomp.oacc-fortran/gemm.f

Re: [nvptx] vector length patch series

2019-01-05 Thread Tom de Vries
On 22-12-18 03:13, Tom de Vries wrote: > If you have a test-case where this is indeed failing without the > proposed hook implementation, then please try to remove the hardcoding > of vector_length > 32 from the test-source and instead set it using > -fopenacc-dim. AFAIU, the pro

[RFC] Add gcc_assert_implies

2019-01-06 Thread Tom de Vries
_if, gcc_if_assert or gcc_cond_assert. ] Also, using this kind of assert will make it easier to spot that: ... gcc_assert_implies (a, b); if (a) { ... } ... can be simplified into: ... if (a) { gcc_assert (b); ... } ... 2019-01-06 Tom de Vries * system.h (gcc

[openacc] Add oacc_get_min_dim

2019-01-07 Thread Tom de Vries
[ was: Re: Fwd: [openacc, committed] Add oacc_get_default_dim ] On 19-12-18 16:27, Tom de Vries wrote: > [ Adding gcc-patches ] > > Forwarded Message > Subject: [openacc, committed] Add oacc_get_default_dim > Date: Wed, 19 Dec 2018 16:24:25 +0100 > From:

[nvptx, committed] Fix libgomp.oacc-c-c++-common/vector-length-128-3.c

2019-01-07 Thread Tom de Vries
[was: Re: [nvptx] vector length patch series] On 03-01-19 17:29, Tom de Vries wrote: > +/* { dg-set-target-env-var "GOMP_OPENACC_DIM" "-:-:128" } */ Committed as obvious. Thanks, - Tom [nvptx] Fix libgomp.oacc-c-c++-common/vector-length-128-3.c The vector-length

[committed][nvptx] Eliminate PTX_VECTOR_LENGTH

2019-01-07 Thread Tom de Vries
Hi, this patch removes PTX_VECTOR_LENGTH and replaces uses of it with PTX_DEFAULT_VECTOR_LENGTH, PTX_MAX_VECTOR_LENGTH and PTX_WARP_SIZE. Committed to trunk. Thanks, - Tom [nvptx] Eliminate PTX_VECTOR_LENGTH 2019-01-07 Tom de Vries * config/nvptx/nvptx.c (PTX_VECTOR_LENGTH

[committed][nvptx] Add asserts in nvptx_goacc_validate_dims

2019-01-07 Thread Tom de Vries
Hi, this patch adds a few asserts to nvptx_goacc_validate_dims. Committed to trunk. Thanks, - Tom [nvptx] Add asserts in nvptx_goacc_validate_dims 2019-01-07 Tom de Vries * config/nvptx/nvptx.c (nvptx_goacc_validate_dims): Add asserts. --- gcc/config/nvptx/nvptx.c | 4 1

[committed][nvptx] Postpone warnings in nvptx_goacc_validate_dims_1

2019-01-07 Thread Tom de Vries
Hi, this patch moves warnings in nvptx_goacc_validate_dims_1 to as late as possible. This allows us more flexibility in setting the dimensions. Committed to trunk. Thanks, - Tom [nvptx] Postpone warnings in nvptx_goacc_validate_dims_1 2019-01-07 Tom de Vries * config/nvptx

[committed][nvptx] Allow larger PTX_MAX_VECTOR_LENGTH in nvptx_goacc_validate_dims_1

2019-01-07 Thread Tom de Vries
Hi, Allow PTX_MAX_VECTOR_LENGTH to be defined as larger than PTX_WARP_SIZE in nvptx_goacc_validate_dims_1. Committed to trunk. Thanks, - Tom [nvptx] Allow larger PTX_MAX_VECTOR_LENGTH in nvptx_goacc_validate_dims_1 2019-01-07 Tom de Vries * config/nvptx/nvptx.c

[nvptx, committed] Add support for a per-worker broadcast buffer and barrier

2019-01-07 Thread Tom de Vries
[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0015-nvptx-Generalize-state-propagation-and-synchronizati.patch Committed. Thanks, - Tom [nvptx] Add support for a per-worker broadcast buffer and barrier Add support for a per-worker broadcast buffer

[nvptx] Don't emit barriers for empty loops -- fix

2019-01-07 Thread Tom de Vries
[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0022-nvptx-openacc-Don-t-emit-barriers-for-empty-loops.patch Committed without test-case. Thanks, - Tom [nvptx] Don't emit barriers for empty loops -- fix When compiling an empty loop: ... long

[nvptx] Handle large vector reductions

2019-01-07 Thread Tom de Vries
[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0024-nvptx-Handle-large-vector-reductions.patch Committed. Thanks, - Tom [nvptx] Handle large vector reductions Add support for vector reductions with openacc vector_length larger than warp-size. 2018

Re: [committed][nvptx] Allow larger PTX_MAX_VECTOR_LENGTH in nvptx_goacc_validate_dims_1

2019-01-07 Thread Tom de Vries
On 07-01-19 09:56, Tom de Vries wrote: > + /* Check that the vector_length is not too large. */ > + if (dims[GOMP_DIM_VECTOR] > PTX_MAX_VECTOR_LENGTH) > +dims[GOMP_DIM_VECTOR] = PTX_MAX_VECTOR_LENGTH; And just to note this: I've chosen a different solution here than og8,

[nvptx, committed] Force vl32 if calling vector-partitionable routines

2019-01-07 Thread Tom de Vries
[ was: Re: [nvptx] vector length patch series ] On 14-12-18 20:58, Tom de Vries wrote: > 0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch > @@ -73,6 +73,7 @@ > #include "cfgloop.h" > #include "fold-const.h" > #include "intl.h" >

Re: [PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-10-23 Thread Tom de Vries
On 7/31/18 11:22 AM, Richard Biener wrote: > Otherwise OK for trunk and also for branches after a while. Jakub, I just backported this fix to gcc-8-branch and gcc-7-branch. I noticed that the gcc-6 branch is frozen, and changes require RM approval. Do you want this fix in gcc-6? Thanks, - Tom

[PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-13 Thread Tom de Vries
requires FORM_GNU_strp_alt. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Handle DW_FORM_GNU_strp_alt 2018-11-11 Tom de Vries * dwarf.c (struct dwarf_data): Add altlink field. (read_attribute): Add altlink parameter. Handle DW_FORM_GN

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-14 Thread Tom de Vries
On 13-11-18 14:42, Tom de Vries wrote: > diff --git a/libbacktrace/Makefile.am b/libbacktrace/Makefile.am > index 3c1bd49dd7b..2fec9bbb4b6 100644 > --- a/libbacktrace/Makefile.am > +++ b/libbacktrace/Makefile.am > @@ -96,6 +96,28 @@ btest_LDADD = libbacktrace.la > > ch

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-14 Thread Tom de Vries
On 14-11-18 14:25, Jakub Jelinek wrote: > On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: >>> +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 >> >> Hmm, I already discovered that specifying the -O0 doesn't work, since >> it's overridden b

[PATCH][libbacktrace] Factor out read_string

2018-11-15 Thread Tom de Vries
Hi, This patch factors out new function read_string in dwarf.c. Bootstrapped and reg-tested on x86_64. OK for trunk (or, for stage1)? Thanks, - Tom [libbacktrace] Factor out read_string 2018-11-15 Tom de Vries * dwarf.c (read_string): Factor out of ... (read_attribute

[PATCH][driver] Ensure --help=params lines end with period

2018-11-20 Thread Tom de Vries
Hi, this patch ensures that gcc --help=params lines end with a period by: - fixing the help message of param HOT_BB_COUNT_FRACTION, and - adding a test-case. Build and tested on x86_64. OK for trunk? Thanks, - Tom [driver] Ensure --help=params lines end with period 2018-11-20 Tom de Vries

[PATCH][libbacktrace] Factor out read_initial_length

2018-11-21 Thread Tom de Vries
Hi, this patch factors out new function read_initial_length in dwarf.c. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Factor out read_initial_length 2018-11-22 Tom de Vries * dwarf.c (read_initial_length): Factor out of

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-21 Thread Tom de Vries
On 21-11-18 02:03, Ian Lance Taylor wrote: > On Wed, Nov 14, 2018 at 6:45 AM, Tom de Vries wrote: >> On 14-11-18 14:25, Jakub Jelinek wrote: >>> On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: >>>>> +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 >>

[PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == 0

2018-11-22 Thread Tom de Vries
replaced by alloc.c to ensure that backtrace_vector_release in alloc.c is tested. OK for trunk if bootstrap and reg-test on x86_64 succeeds? Thanks, - Tom [libbacktrace] Handle realloc returning NULL if size == 0 2018-11-22 Tom de Vries * Makefile.am (check_PROGRAMS): Add unittest

[PATCH 2/2][libbacktrace] Don't point to released memory in backtrace_vector_release

2018-11-22 Thread Tom de Vries
nt to released memory. OK for trunk if bootstrap and reg-test on x86_64 succeeds? Thanks, - Tom [libbacktrace] Don't point to released memory in backtrace_vector_release 2018-11-22 Tom de Vries * alloc.c (backtrace_vector_release): Set base to NULL if size == 0.

[PATCH 1/4][libbacktrace] Test check_PROGRAMS without mmap

2018-11-23 Thread Tom de Vries
[ was: [PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == 0 ] On Thu, Nov 22, 2018 at 01:35:43PM +0100, Tom de Vries wrote: > Hi, > > Build and tested on x86_64, with mmap.c replaced by alloc.c to ensure that > backtrace_vector_release in alloc.c is tested. Hi, I ca

[PATCH 2/4][libbacktrace] Avoid realloc with size == 0 in backtrace_vector_release

2018-11-23 Thread Tom de Vries
[ was: Re: [PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == 0 ] On Thu, Nov 22, 2018 at 06:16:20PM +, Joseph Myers wrote: > On Thu, 22 Nov 2018, Tom de Vries wrote: > > > Hi, > > > > If realloc is called with size 0, realloc can return NULL. &

[PATCH 3/4][libbacktrace] Don't point to released memory in backtrace_vector_release

2018-11-23 Thread Tom de Vries
[ was: Re: [PATCH 2/2][libbacktrace] Don't point to released memory in backtrace_vector_release ] On Thu, Nov 22, 2018 at 01:36:49PM +0100, Tom de Vries wrote: > Hi, > > When backtrace_vector_release is called with vec.size == 0, it releases the > memory pointed at by vec.base

[PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-23 Thread Tom de Vries
- Tom [libbacktrace] Add tests for unused formats 2018-11-23 Tom de Vries * configure.ac (NOT_HAVE_FORMAT_ELF, NOT_HAVE_FORMAT_PECOFF) (NOT_HAVE_FORMAT_UNKNOWN, NOT_HAVE_FORMAT_XCOFF_32) (NOT_HAVE_FORMAT_XCOFF_64): New AM_CONDITIONAL. * configure: Regen

Re: [PATCH][driver] Ensure --help=params lines end with period

2018-11-26 Thread Tom de Vries
On 26-11-18 22:43, Mike Stump wrote: > On Nov 20, 2018, at 3:51 AM, Tom de Vries wrote: >> >> this patch ensures that gcc --help=params lines end with a period by: >> - fixing the help message of param HOT_BB_COUNT_FRACTION, and >> - adding a test-case. >> >&g

Re: [PATCH 1/4][libbacktrace] Test check_PROGRAMS without mmap

2018-11-28 Thread Tom de Vries
On 23-11-18 21:47, Tom de Vries wrote: > [ was: [PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == 0 ] > > On Thu, Nov 22, 2018 at 01:35:43PM +0100, Tom de Vries wrote: >> Hi, >> >> Build and tested on x86_64, with mmap.c replace

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-28 Thread Tom de Vries
On 23-11-18 21:56, Tom de Vries wrote: > Hi, > > When building libbacktrace, we typically use elf.c, and don't build pecoff.c, > xcoff.c or unknown.c > > Add testcases that use unused format to ensure that we also build and > test those on a typical development setup.

[PATCH][libbacktrace] Fix segfault upon allocation failure

2018-11-28 Thread Tom de Vries
. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Fix segfault upon allocation failure 2018-11-27 Tom de Vries * dwarf.c (read_abbrevs): Fix handling of abbrevs->abbrevs allocation failure. --- libbacktrace/dwarf.c | 2 +- 1 file changed,

[PATCH][libbacktrace] Add allocfail.sh test-case

2018-11-28 Thread Tom de Vries
est-case 2018-11-27 Tom de Vries * Makefile.am (TESTS): Add allocfail.sh. (check_PROGRAMS): Add allocfail. * Makefile.in: Regenerate. * instrumented_alloc.c: New file. Redefine malloc and realloc. Include alloc.c. * allocfail.c: New file.

[PATCH 2/5][libbacktrace] Fix memory leak in build_address_map

2018-11-28 Thread Tom de Vries
upon failure. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Fix memory leak in build_address_map 2018-11-28 Tom de Vries * dwarf.c (build_address_map): Free addrs vector upon failure. --- libbacktrace/dwarf.c | 5 + 1 file changed, 5

[PATCH 1/5][libbacktrace] Factor out backtrace_vector_free

2018-11-28 Thread Tom de Vries
Hi, this patch factors out new function backtrace_vector_free. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Factor out backtrace_vector_free 2018-11-28 Tom de Vries * Makefile.am (libbacktrace_la_SOURCES): Add backtrace-vector

[PATCH 3/5][libbacktrace] Fix memory leak in loop in build_address_map

2018-11-28 Thread Tom de Vries
18-11-28 Ian Lance Taylor Tom de Vries PR libbacktrace/88063 * dwarf.c (free_unit_addrs_vector): Remove. (build_address_map): Keep track of allocated units in vector. Free allocated units and corresponding abbrevs upon failure. Remov

[PATCH 4/5][libbacktrace] Simplify memory management in build_address_map

2018-11-28 Thread Tom de Vries
plify memory management in build_address_map 2018-11-28 Tom de Vries * dwarf.c (build_address_map): Simplify by removing local variable abbrevs. --- libbacktrace/dwarf.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/libbacktrace/dwar

[PATCH 5/5][libbacktrace] Reduce memory usage in build_address_map

2018-11-28 Thread Tom de Vries
been used, and reusing it otherwise. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktrace] Reduce memory usage in build_address_map 2018-11-28 Tom de Vries * dwarf.c (build_address_map): Reuse unused units. --- libbacktrace/dwarf.c | 13 + 1

Re: [PATCH 1/5][libbacktrace] Factor out backtrace_vector_free

2018-11-29 Thread Tom de Vries
On 29-11-18 00:26, Ian Lance Taylor wrote: > On Wed, Nov 28, 2018 at 3:15 PM, Tom de Vries wrote: >> >> this patch factors out new function backtrace_vector_free. >> >> Bootstrapped and reg-tested on x86_64. >> >> OK for trunk? > > We should only a

Re: [PATCH 1/5][libbacktrace] Factor out backtrace_vector_free

2018-11-30 Thread Tom de Vries
On 29-11-18 19:17, Ian Lance Taylor wrote: > On Thu, Nov 29, 2018 at 4:33 AM, Tom de Vries wrote: >> On 29-11-18 00:26, Ian Lance Taylor wrote: >>> On Wed, Nov 28, 2018 at 3:15 PM, Tom de Vries wrote: >>>> >>>> this patch factors out new function backtra

Re: [PATCH 1/4][libbacktrace] Test check_PROGRAMS without mmap

2018-11-30 Thread Tom de Vries
On 29-11-18 19:26, Ian Lance Taylor wrote: > On Fri, Nov 23, 2018 at 12:47 PM, Tom de Vries wrote: >> [ was: [PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == 0 ] >> >> On Thu, Nov 22, 2018 at 01:35:43PM +0100, Tom de Vries wrote: >>> Hi, >>&g

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-30 Thread Tom de Vries
On 29-11-18 19:28, Ian Lance Taylor wrote: > On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries wrote: >> >> When building libbacktrace, we typically use elf.c, and don't build pecoff.c, >> xcoff.c or unknown.c >> >> Add testcases that use unused format to ensur

Re: [PATCH] gdbhooks.py: dump-fn, dot-fn: cast ret values of fopen/fclose

2019-07-14 Thread Tom de Vries
On 09-07-19 16:10, Vladislav Ivanishin wrote: > Hi, > > Without the patch, I see these error messages with gdb 8.3: > > (gdb) Python Exception 'fclose@@GLIBC_2.2.5' has > unknown return type; cast the call to its declared return type: > (gdb) Error occurred in Python: 'fclose@@GLIBC_

Re: [committed][nvptx, libgomp] Move rtl-dump test-cases to libgomp

2019-02-22 Thread Tom de Vries
On 22-02-19 12:09, Thomas Schwinge wrote: > There is however still a problem here: if you have more than one offload > compiler configured, Ah, right, that's a configuration I'm not testing, evidently. > all of them will react to > '-foffload=-fdump-rtl-mach', and will overwrite their dump files

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-25 Thread Tom de Vries
On 25-02-19 11:48, Thomas Schwinge wrote: > Hi Tom! > > On Fri, 8 Feb 2019 10:42:24 +0100, Tom de Vries wrote: >> Add libbacktrace test-case using -flto. > > I'm seeing this one fail is some configurations, but only in the > 'build-gcc/libbacktrace/bte

Re: [backtrace] Avoid segfault

2019-02-25 Thread Tom de Vries
On 25-02-19 15:12, Gerald Pfeifer wrote: > Specifically I am now seeing > > gmake[4]: *** No rule to make target 'b3test_dwz_buildid', > needed by 'b3test_dwz_buildid.log'. > > in my build/test logs. (Note, this is GNU make 4.2.1, so might reproduce > on your SUSE systems as well?) Hi Ger

Re: [backtrace] Avoid segfault

2019-02-26 Thread Tom de Vries
On 25-02-19 21:03, Tom de Vries wrote: > On 25-02-19 15:12, Gerald Pfeifer wrote: >> Specifically I am now seeing >> >> gmake[4]: *** No rule to make target 'b3test_dwz_buildid', >> needed by 'b3test_dwz_buildid.log'. >> >> in m

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-26 Thread Tom de Vries
On 26-02-19 10:40, Thomas Schwinge wrote: > Hi Tom! > > On Mon, 25 Feb 2019 18:11:23 +0100, Tom de Vries wrote: >> On 25-02-19 11:48, Thomas Schwinge wrote: >>> On Fri, 8 Feb 2019 10:42:24 +0100, Tom de Vries wrote: >>>> Add libbacktrace test-case using -fl

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-26 Thread Tom de Vries
On 26-02-19 13:00, Thomas Schwinge wrote: > Hi Tom! > > On Tue, 26 Feb 2019 12:28:34 +0100, Tom de Vries wrote: >> On 26-02-19 10:40, Thomas Schwinge wrote: >>> On Mon, 25 Feb 2019 18:11:23 +0100, Tom de Vries wrote: >>>> On 25-02-19 11:48, Thomas Schwinge w

[RFC, doc] Note variable shadowing at max macro using statement expression

2019-04-08 Thread Tom de Vries
on the variable shadowing problem for: ... #define maxint3(a, b, c) \ ({int _a = (a), _b = (b), _c = (c); maxint (maxint (_a, _b), _c); }) ... Any comments? Thanks, - Tom [doc] Note variable shadowing at max macro using statement expression 2019-04-08 Tom de Vries * doc/extend.texi

[PATCH, doc] Note variable shadowing at max macro using statement expression

2019-04-11 Thread Tom de Vries
[ was: Re: [RFC, doc] Note variable shadowing at max macro using statement expression ] On 09-04-19 22:51, Sandra Loosemore wrote: > On 4/8/19 5:38 AM, Tom de Vries wrote: >> Hi, >> >> When suggesting to rewrite the unsafe (with respect to multiple >> evaluation of >

Re: [nvptx] vector length patch series

2019-01-08 Thread Tom de Vries
On 14-12-18 20:58, Tom de Vries wrote: > 0016-nvptx-Add-vector_length-128-testcases.patch > --- /dev/null > > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/

[committed][nvptx, libgomp] Don't launch with num_workers == 0

2019-01-08 Thread Tom de Vries
: ... cuOccupancyMaxPotentialBlockSize: grid = 10, block = 768 ... Fix this by ensuring that workers is at least one. Committed to trunk. Thanks, - Tom [nvptx, libgomp] Don't launch with num_workers == 0 2019-01-08 Tom de Vries * plugin/plugin-nvptx.c (nvptx_exec): Make sure to l

[committed][libgomp, testsuite, openacc] Don't use const int for dimensions

2019-01-08 Thread Tom de Vries
, testsuite, openacc] Don't use const int for dimensions 2019-01-08 Tom de Vries PR target/88756 * testsuite/libgomp.oacc-c-c++-common/reduction-1.c (ng, nw, vl): Use #define instead of "const int". * testsuite/libgomp.oacc-c-c++-common/reduction-

[RFC] Update Stage 4 description

2019-01-09 Thread Tom de Vries
[ To revisit https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00385.html ] The current formulation for the description of Stage 4 here ( https://gcc.gnu.org/develop.html ) is: ... During this period, the only (non-documentation) changes that may be made are changes that fix regressions. Other change

[wwwdocs, committed] Update Stage 4 description

2019-01-09 Thread Tom de Vries
[ was: Re: [RFC] Update Stage 4 description ] On 09-01-19 09:47, Richard Biener wrote: > On Wed, 9 Jan 2019, Tom de Vries wrote: > >> [ To revisit https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00385.html ] >> >> The current formulation for the description of Stage 4 here

[committed][nvptx, testsuite, openacc, libgomp] Add insufficient-resources.c

2019-01-11 Thread Tom de Vries
Hi, Add a test-case that tests the "insufficient resources" fatal in the nvptx libgomp plugin. Committed to trunk. Thanks, - Tom [nvptx, testsuite, openacc, libgomp] Add insufficient-resources.c 2019-01-11 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/insufficient-r

[committed][libgomp, testsuite, openacc] Remove -foffload=-w in reduction-[1-5].c

2019-01-11 Thread Tom de Vries
, remove the "-foffload=-w" setting. Committed to trunk. Thanks, - Tom [libgomp, testsuite, openacc] Remove -foffload=-w in reduction-[1-5].c 2019-01-11 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/reduction-1.c: Remove -foffload=-w. * testsuite/

[committed][nvptx] Move PTX_CTA_SIZE up

2019-01-11 Thread Tom de Vries
Hi, Move the defition of PTX_CTA_SIZE up in nvptx.c. Committed to trunk. Thanks, - Tom [nvptx] Move PTX_CTA_SIZE up 2019-01-11 Tom de Vries * config/nvptx/nvptx.c (PTX_CTA_SIZE): Move up. --- gcc/config/nvptx/nvptx.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions

[committed][nvptx] Don't allow vector_length 64 with num_workers 16

2019-01-11 Thread Tom de Vries
lem in both the compiler (handling "num_workers (16)") and in the libgomp nvptx plugin (with and without "GOMP_OPENACC_DIM=:16:"). Committed to trunk. Thanks, - Tom [nvptx] Don't allow vector_length 64 with num_workers 16 2019-01-10 Tom de Vries * conf

[committed][openacc] Add used parameter to TARGET_GOACC_VALIDATE_DIMS

2019-01-12 Thread Tom de Vries
Hi, Add a used parameter to TARGET_GOACC_VALIDATE_DIMS, allowing a target to make decisions in the hook implementation based on whether a dimension is used or not. Committed to trunk. Thanks, - Tom [openacc] Add used parameter to TARGET_GOACC_VALIDATE_DIMS 2019-01-11 Tom de Vries

[committed][nvptx] Verify dimension limits after applying defaults

2019-01-12 Thread Tom de Vries
date_dims_1, as oacc_validate_dims would do it, and then apply the dimensions limits. Committed to trunk. Thanks, - Tom [nvptx] Verify dimension limits after applying defaults 2019-01-11 Tom de Vries PR middle-end/88703 * config/nvptx/nvptx.c (nvptx_goacc_validate_dims_1):

[committed][nvptx] Allow default vl to be overridden in nvptx_goacc_validate_dims_1

2019-01-12 Thread Tom de Vries
2019-01-11 Tom de Vries * config/nvptx/nvptx.c (nvptx_goacc_validate_dims_1): Add an use new variable default_vector_length. --- gcc/config/nvptx/nvptx.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config

[committed][nvptx] Apply vector-partitionable routines workaround to default vl

2019-01-12 Thread Tom de Vries
Hi, Make "[nvptx] Force vl32 if calling vector-partitionable routines" work as well if vector length is set by modifying PTX_DEFAULT_VECTOR_LENGTH. Committed to trunk. Thanks, - Tom [nvptx] Apply vector-partitionable routines workaround to default vl 2019-01-11 To

[PATCH 3/9] [nvptx] Enable large vectors -- test-cases

2019-01-12 Thread Tom de Vries
Add various test-cases with vector length 128. 2018-12-17 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/vector-length-128-7.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-128-4.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-128

[PATCH 1/9] [nvptx] Enable large vectors

2019-01-12 Thread Tom de Vries
Allow vector_length clauses to accept values larger than warp size. Note that this does not enable setting vector_length to values larger than warp size using -fopenacc-dim. 2018-12-17 Tom de Vries * config/nvptx/nvptx.c (nvptx_goacc_validate_dims): Take larger vector lengths

[PATCH 2/9] [nvptx] Update insufficient launch message for variable vector_length

2019-01-12 Thread Tom de Vries
Update message in nvptx libgomp plugin about insufficient resources to launch kernel, to accommodate for the fact the vector_length can now be variable. 19-01-08 Tom de Vries * plugin/plugin-nvptx.c (nvptx_exec): Update insufficient hardware resources diagnostic. --- libgomp

[PATCH 0/9] [COVER-LETTER, nvptx] Add support for warp-multiple openacc vector length

2019-01-12 Thread Tom de Vries
riers for empty loops -- test-cases 6 [nvptx] Force vl32 if calling vector-partitionable routines -- test-cases 7 [nvptx] Add vector_length 64 test-cases 8 [nvptx] Enable setting vector length using -fopenacc-dim 9 [nvptx] Enable setting vector length using -fopenacc-di

[PATCH 8/9] [nvptx] Enable setting vector length using -fopenacc-dim

2019-01-12 Thread Tom de Vries
Enable setting vector length using -fopenacc-dim, f.i. -fopenacc-dim=::128. 2019-01-12 Tom de Vries * config/nvptx/nvptx.c (nvptx_goacc_validate_dims_1): Alow setting vector length using -fopenacc-dim. * plugin/plugin-nvptx.c (nvptx_exec): Update error message

[PATCH 7/9] [nvptx] Add vector_length 64 test-cases

2019-01-12 Thread Tom de Vries
Add some test-cases using vector_length 64. 2019-01-10 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/vector-length-64-1.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-64-2.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-64-3.c

[PATCH 5/9] [nvptx] Don't emit barriers for empty loops -- test-cases

2019-01-12 Thread Tom de Vries
Add test-cases for PR85381. 2018-12-17 Tom de Vries PR target/85381 * testsuite/libgomp.oacc-c-c++-common/pr85381-5.c: New test. * testsuite/libgomp.oacc-c-c++-common/pr85381.c: New test. --- .../libgomp.oacc-c-c++-common/pr85381-5.c | 24

[PATCH 6/9] [nvptx] Force vl32 if calling vector-partitionable routines -- test-cases

2019-01-12 Thread Tom de Vries
Add test-cases for "[nvptx] Force vl32 if calling vector-partitionable routines". 2018-12-17 Tom de Vries PR target/85486 * testsuite/libgomp.oacc-c-c++-common/pr85486-3.c: New test. * testsuite/libgomp.oacc-c-c++-common/pr85486.c: New test. --- .../libgom

[PATCH 4/9] [nvptx] Enable large vectors -- reduction testcases

2019-01-12 Thread Tom de Vries
Add various reduction test-cases with vector length 128. 2018-12-17 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/vred2d-128.c: New test. * testsuite/libgomp.oacc-fortran/gemm.f90: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-128-10.c: New test

[PATCH 9/9] [nvptx] Enable setting vector length using -fopenacc-dim -- testcases

2019-01-12 Thread Tom de Vries
Add some test-cases that set vector length using -fopenacc-dim. 2019-01-12 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/pr85486-2.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector-length-128-2.c: New test. * testsuite/libgomp.oacc-c-c++-common/vector

[committed][nvptx] Handle assignment to gang-level reduction variable

2019-01-15 Thread Tom de Vries
Hi, this fixes an ICE when handling an assignment to a gang-level reduction variable. Committed to trunk. Thanks, - Tom [nvptx] Handle assignment to gang-level reduction variable 2019-01-15 Tom de Vries PR target/80547 * config/nvptx/nvptx.c (nvptx_goacc_reduction_init

Re: [PATCH] Fix OpenACC shutdown and PTX image unloading (PR65904)

2019-01-15 Thread Tom de Vries
[ add gcc-patches@ ] On 15-01-19 11:38, Tom de Vries wrote: > Hi > > Copied from here ( > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00532.html ): >> This too. Retested for libgomp/NVPTX. >> >> OK for trunk now? >> > > The plugin-nvptx.c part looks o

x86_64 with nvptx accelerator libgomp test-report

2019-01-15 Thread Tom de Vries
Hi, FYI, I've build (various versions of current) trunk for x86_64 with nvptx accelerator and ran the libgomp testsuite on the following cards: - gt 710 (kepler) (using driver version 390.77) - quadro m1200 (maxwell) (using driver version 390.87) - gt 1030 (pascal) (using driver version 390.77).

Re: [PATCH 1/9] [libbacktrace] Read .gnu_debugaltlink

2019-01-16 Thread Tom de Vries
On 16-01-19 01:56, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >> >> Read the elf file pointed at by the .gnu_debugaltlink section, and verify >> that >> the build id matches. >> >> 2018-11-11 Tom de Vries >>

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 02:02, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >> >> Add an altlink field to struct dwarf_data, and initialize it with the pointer >> to the struct dwarf_data for the .gnu_debugaltlink. >> >> 2018-11-11 Tom d

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 17:33, Tom de Vries wrote: > On 16-01-19 02:02, Ian Lance Taylor wrote: >> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >>> >>> Add an altlink field to struct dwarf_data, and initialize it with the >>> pointer >>> to th

Re: [PATCH 3/9] [libbacktrace] Handle alt FORMS without .gnu_debugaltlink

2019-01-16 Thread Tom de Vries
On 16-01-19 02:06, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >> >> Handle DW_FORM_GNU_strp_alt and DW_FORM_GNU_ref_alt references robustly in >> presence of missing .gnu_debugaltlink file. >> >> 2018-11-11 Tom de Vrie

Re: [PATCH 6/9] [libbacktrace] Factor out read_referenced_name_1

2019-01-16 Thread Tom de Vries
On 16-01-19 02:15, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:15 AM Tom de Vries wrote: >> >> Factor out the common handling of DW_AT_abstract_origin and >> DW_AT_specification from read_function_entry and read_referenced_name. >> >> 2018-12-10 Tom d

Re: [PATCH 8/9] [libbacktrace] Add btest_dwz test-case

2019-01-16 Thread Tom de Vries
On 16-01-19 02:19, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:16 AM Tom de Vries wrote: >> >> 2018-11-11 Tom de Vries >> >> * configure.ac (DWZ): Set with AC_CHECK_PROG. >> (HAVE_DWZ): Set with AM_CONDITIONAL. &

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 18:17, Ian Lance Taylor wrote: > On Wed, Jan 16, 2019 at 8:33 AM Tom de Vries wrote: >> >>> Why is it void**? >> >> It's really struct dwarf_data *, but struct dwarf_data is a type >> declared in dwarf.c, so it's not known in other files

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 17:34, Tom de Vries wrote: > On 16-01-19 17:33, Tom de Vries wrote: >> On 16-01-19 02:02, Ian Lance Taylor wrote: >>> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >>>> >>>> Add an altlink field to struct dwarf_data, and initialize it

Re: [PATCH 1/9] [libbacktrace] Read .gnu_debugaltlink

2019-01-16 Thread Tom de Vries
On 16-01-19 18:14, Ian Lance Taylor wrote: > On Wed, Jan 16, 2019 at 8:26 AM Tom de Vries wrote: >> >> On 16-01-19 01:56, Ian Lance Taylor wrote: >>> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >>>> >>>> Read the elf file pointed at by the

Re: [PATCH 7/9] [libbacktrace] Handle DW_FORM_GNU_ref_alt

2019-01-16 Thread Tom de Vries
Hi, this handles DW_FORM_GNU_ref_alt which references the .debug_info section in the .gnu_debugaltlink file. OK for trunk? Thanks, - Tom On 11-12-18 11:14, Tom de Vries wrote: > 2018-12-10 Tom de Vries > > * dwarf.c (enum attr_val_encoding): Add ATTR_VAL_REF_ALT_INFO. >

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-17 Thread Tom de Vries
thout dwz compression. 2018-12-10 Tom de Vries * Makefile.am (TESTS): Add printdwarftest_dwz_cmp.sh. * Makefile.in: Regenerate. * printdwarftest.c: New file. * printdwarftest_dwz_cmp.sh: New file. --- libbacktrace/Makefile.am | 11 ++ libbacktrace/Makefile.in

Re: [PATCH 7/9] [libbacktrace] Handle DW_FORM_GNU_ref_alt

2019-01-17 Thread Tom de Vries
On 17-01-19 01:35, Ian Lance Taylor wrote: > On Wed, Jan 16, 2019 at 4:17 PM Tom de Vries wrote: >> >> this handles DW_FORM_GNU_ref_alt which references the .debug_info >> section in the .gnu_debugaltlink file. >> >> OK for trunk? >> >> Thanks, >>

<    10   11   12   13   14   15   16   17   18   19   >