Re: [PATCH] Detect loops in find_comparison_args

2012-07-26 Thread Sandra Loosemore
On 07/26/2012 01:28 AM, Paolo Bonzini wrote: > Il 26/07/2012 04:25, Sandra Loosemore ha scritto: >> On 07/25/2012 01:27 AM, Paolo Bonzini wrote: >>> >>> What I'm worried about is the extra cost of malloc-ing and free-ing >>> the pointer set. Perhaps

[patch, libiberty] avoid closing files twice on Windows when exec fails

2012-07-26 Thread Sandra Loosemore
well enough for us, as far as it goes, and is at least an incremental improvement in robustness. OK for mainline? -Sandra 2012-07-26 Kazu Hirata Sandra Loosemore libiberty/ * pex-win32.c (pex_win32_exec_child): Only close original file descriptors if

ping ancient MIPS: missed optimization patch

2012-07-27 Thread Sandra Loosemore
Richard, This ancient patch to tweak mips_legitimize_address http://gcc.gnu.org/ml/gcc/2008-11/msg00294.html seems to never have been applied. Do you have any idea whether this is still a useful change? The test case given in the first message in that thread no longer reproduces with a rece

[PATCH, MIPS] -mno-float odds and ends

2012-07-30 Thread Sandra Loosemore
hould override architecture defaults. This patch addresses both problems. OK to commit? -Sandra 2012-07-30 Sandra Loosemore Julian Brown gcc/ * doc/invoke.texi (MIPS Options): Document -mno-float. * config/mips/mips.h (MIPS_ARCH_FLOAT_SPEC): Make it

Re: [PATCH, MIPS] -mno-float odds and ends

2012-07-30 Thread Sandra Loosemore
ked in the attached version of the patch. Thanks for the speedy review! :-) -Sandra 2012-07-30 Sandra Loosemore Julian Brown gcc/ * doc/invoke.texi (MIPS Options): Document -mno-float. * config/mips/mips.h (MIPS_ARCH_FLOAT_SPEC): M

Re: [PATCH, MIPS] -mno-float odds and ends

2012-07-30 Thread Sandra Loosemore
ked in the attached version of the patch. Thanks for the speedy review! :-) -Sandra 2012-07-30 Sandra Loosemore Julian Brown gcc/ * doc/invoke.texi (MIPS Options): Document -mno-float. * config/mips/mips.h (MIPS_ARCH_FLOAT_SPEC): M

[PATCH, MIPS] Add 34Kn cpu

2012-07-31 Thread Sandra Loosemore
utils/2012-08/msg8.html -Sandra 2012-08-01 Catherine Moore Sandra Loosemore gcc/ * config/mips/mips-cpus.def (34kn): New. * config/mips/mips.h (MIPS_ARCH_FLOAT_SPEC): Add 34kn. (BASE_DRIVER_SELF_SPECS): Do not imply -mdsp for the 34kn. Index: c

[PATCH, MIPS] 74k madd scheduler tweaks

2012-08-01 Thread Sandra Loosemore
ed to contribute this to the FSF; ok for mainline? -Sandra 2012-08-01 Sandra Loosemore Maxim Kuvyrkov Julian Brown MIPS Technologies, Inc. * config/mips/74k.md (r74k_int_mult, r74k_int_madd): Don't use mips_linked_madd_p fo

[PATCH, MIPS] clean up 24k/74k store bypasses

2012-08-02 Thread Sandra Loosemore
This patch changes the 24k/74k scheduling descriptions to use the existing mips_store_data_bypass_p predicate instead of treating cprestore as a special case. OK for mainline? -Sandra 2012-08-02 Sandra Loosemore Maxim Kuvyrkov Julian Brown gcc

[PATCH, MIPS] DSP ALU scheduling

2012-08-02 Thread Sandra Loosemore
s" patch I posted the other day: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00062.html Assuming that one gets approved, is this patch OK for mainline? -Sandra 2012-08-02 Sandra Loosemore Maxim Kuvyrkov Julian Brown MIPS Technologies, In

[PATCH, MIPS] diagnose -fpic/-fpie incompatibility with -mno-abicalls

2012-08-03 Thread Sandra Loosemore
a couple test cases that triggered the new error. OK for mainline? -Sandra 2012-08-03 Sandra Loosemore gcc/ * config/mips/mips.c (mips_option_override): Check -fpic/-fpie and -mabicalls options for compatibility with ABI. gcc/testsuite/ * g++.dg/opt/e

[PATCH, MIPS] fix clear cache test cases

2012-08-03 Thread Sandra Loosemore
Some MIPS configurations #define CACHE_FLUSH_FUNC to something other than "_flush_cache", This fixes the two test cases that currently have that name wired in to know about the netbsd and sdemtk names too. OK for mainline? -Sandra 2012-08-03 Sandra Loosemore Cathe

[PATCH, MIPS] Netlogic XLR tuning tweaks

2012-08-03 Thread Sandra Loosemore
e had in our local source base for some time. OK for mainline? -Sandra 2012-08-03 Catherine Moore Sandra Loosemore gcc/ * config/mips/xlr.md (ir_xlr_alu_clz): New insn_reservation. (ir_xlr_alu): Remove clz. * config/mips/mips-cpus.def (xlr)

Re: [PATCH, MIPS] 74k madd scheduler tweaks

2012-08-04 Thread Sandra Loosemore
On 08/04/2012 07:48 AM, Richard Sandiford wrote: Sandra Loosemore writes: The existing scheduler bypass information for madd on the 74k uses some bits copied from the 24k, and is not quite correct. This patch is based on one originally sent to us by MIPS and has been present in our local

Re: [PATCH, MIPS] Add 34Kn cpu

2012-08-04 Thread Sandra Loosemore
On 08/04/2012 03:01 PM, Gerald Pfeifer wrote: On Wed, 1 Aug 2012, Richard Sandiford wrote: 2012-08-01 Catherine Moore Sandra Loosemore gcc/ * config/mips/mips-cpus.def (34kn): New. * config/mips/mips.h (MIPS_ARCH_FLOAT_SPEC): Add 34kn

Re: [PATCH, MIPS] diagnose -fpic/-fpie incompatibility with -mno-abicalls

2012-08-04 Thread Sandra Loosemore
On 08/04/2012 08:09 AM, Richard Sandiford wrote: Sandra Loosemore writes: For all supported MIPS ABIs other than EABI, compiling with -fpic/-fPIC/-fpie/-fPIE implicitly requires abicalls support. On Linux targets, -mabicalls is the default, but bare-metal targets like mips-sde-elf default to

[PATCH] put exception tables for comdat functions in comdat, too

2012-08-05 Thread Sandra Loosemore
This patch has also been present in our local source base for a while so it's been well-tested in that context. OK for mainline? -Sandra 2012-08-04 Paul Brook Sandra Loosemore gcc/ * except.c (switch_to_exception_section): Place tables for DEC

Re: [PATCH] put exception tables for comdat functions in comdat, too

2012-08-06 Thread Sandra Loosemore
On 08/06/2012 11:45 AM, Richard Henderson wrote: On 08/05/2012 08:40 PM, Sandra Loosemore wrote: 2012-08-04 Paul Brook Sandra Loosemore gcc/ * except.c (switch_to_exception_section): Place tables for DECL_ONE_ONLY functions in comdat groups. Mostly ok

Re: [patch, committed] invoke.texi: clean up texinfo markup

2012-05-02 Thread Sandra Loosemore
On 05/02/2012 12:41 AM, Gerald Pfeifer wrote: Hi Sandra, On Fri, 6 Apr 2012, Sandra Loosemore wrote: > This is another installment in my series of cleanups to invoke.texi. > In this patch I have taken a break from nit-picking grammar and have > nit-picked some Texinfo markup issue

[RFC, ivopts] fix bugs in ivopts address cost computation

2012-06-05 Thread Sandra Loosemore
My colleagues and I have been working on the GCC port for the Qualcomm Hexagon. Along the way I noticed that we were getting poor results from the ivopts pass no matter how we adjusted the target-specific RTX costs. In many cases ivopts was coming up with candidate use costs that seemed completel

[patch, committed] invoke.texi: DWARF, stabs, and ELF

2012-03-09 Thread Sandra Loosemore
to invoke.texi makes usages reflect the official names. Similarly, I've fixed up a couple instances of incorrect usage of "stabs" (official name seems to be all lowercase, like that) and "ELF". Checked in to trunk as obvious. -Sandra 2012-03-09 Sandra Loosem

[patch, committed] invoke.texi: use correct name/markup for "GCC" and other program names

2012-03-09 Thread Sandra Loosemore
"GCC@." rather than just "GCC." While I was at it, I checked references to "GDB" and "ld". For the latter, the GNU ld manual seems to prefer @command markup in all contexts, so that's what I did here. Checked in to trunk as obvious. -Sandra 2012-03-

[patch, RFA] delete obsolete -madjust-unroll option for SH

2012-03-09 Thread Sandra Loosemore
not delete this entirely, per the attached patch? I haven't built/tested this (except for the manual) but can do that if the patch isn't sufficiently obvious. -Sandra 2012-03-09 Sandra Loosemore gcc/ * config/sh/sh.opt (madjust-unroll): Delete. * conf

[patch, RFA] -no-integrated-cpp documentation

2012-03-11 Thread Sandra Loosemore
ther useless options too, and it's probably more trouble to remove than it's worth Anyway, I'd appreciate another pair of eyes looking at this, and suggestions on what better to do here if this rewrite isn't adequate. -Sandra 2012-03-11 Sandra Loosemore g

Re: [patch, committed] invoke.texi: DWARF, stabs, and ELF

2012-03-18 Thread Sandra Loosemore
On 03/18/2012 03:00 PM, Gerald Pfeifer wrote: On Fri, 9 Mar 2012, Sandra Loosemore wrote: Per the DWARF web site http://dwarfstd.org/Download.php the correct names of the various versions of the DWARF standard appear to be either "DWARF Version N" or "DWARF N", rath

[patch, committed] invoke.texi: clean up texinfo markup

2012-04-06 Thread Sandra Loosemore
generated PDF manual. -Sandra 2012-04-06 Sandra Loosemore gcc/ * doc/invoke.texi: Clean up Texinfo markup throughout the file. Use @option markup on command-line options. Use @samp markup on literal keywords to options. Use @code markup on code fragments

PATCH: fix infinite loop in CSE

2011-12-12 Thread Sandra Loosemore
limit on the number of iterations to be sure the outer loop always terminates. I regression-tested this in a GCC 4.5-based build for mips-linux-gnu and also did a full bootstrap and regression test for i686-pc-linux-gnu on mainline head. OK to check in on mainline? -Sandra 2011-12-12 Sandra Loos

Re: PATCH: fix infinite loop in CSE

2011-12-12 Thread Sandra Loosemore
On 12/12/2011 08:00 PM, Andrew Pinski wrote: On Mon, Dec 12, 2011 at 6:53 PM, Sandra Loosemore wrote: The test case in the attached patch gets stuck in an infinite loop in find_comparison_args in CSE when compiled for MIPS at -O2. This bug has been present at least as far back as GCC 4.5 and

Re: PATCH: fix infinite loop in CSE

2011-12-19 Thread Sandra Loosemore
On 12/18/2011 05:21 AM, Eric Botcazou wrote: OK everywhere without the cap and with the same test on ARG2: If a testcase doesn't need fancy options, it must go in gcc.c-torture/compile. OK. I've checked in this version, which addresses both those issues. -Sandra 2011-12-

[committed] copy-edit -flto documentation

2012-01-02 Thread Sandra Loosemore
don't affect content, I've checked in this patch as "obvious". -Sandra 2012-01-02 Sandra Loosemore gcc/ * doc/invoke.texi (-flto and related options): Copy-edit. Index: gcc/doc/invoke.texi ===

Re: [committed] copy-edit -flto documentation

2012-01-03 Thread Sandra Loosemore
On 01/03/2012 01:18 AM, Eric Botcazou wrote: When I was looking at some LTO-related test failures last week (see mail on gcc@), I found that the many punctuation and grammatical errors in the -flto documentation made this section of the GCC manual hard to read. I made a pass over it to clean up

[committed] invoke.texi: move -Wcoverage-mismatch blurb

2012-01-26 Thread Sandra Loosemore
I noticed that the documentation for -Wcoverage-mismatch was placed in the wrong section in invoke.texi. Fixed thusly. -Sandra 2012-01-27 Sandra Loosemore gcc/ * doc/invoke.texi (Language Independent Options): Move -Wcoverage-mismatch blurb from here

[committed] invoke.texi: fix "command line" vs "command-line" usage

2012-01-26 Thread Sandra Loosemore
cribe them correctly. ;-) I've checked in this patch as obvious. I have close to 500KB of similar kinds of content-free copy-editing patches to invoke.texi in my queue; does anyone really want to review them, or object to me just continuing to check them in piecewise like this? -Sandra 201

[committed] invoke.texi: fix hyphenation of "floating point" and related terms

2012-01-27 Thread Sandra Loosemore
showed up in many of the same sentences/paragraphs. I've checked in this patch as obvious. (Again, if anyone thinks these kinds of edits are not obvious, let me know, and I'll start posting them for review first instead.) -Sandra 2012-01-28 Sandra Loosemore

Re: [committed] invoke.texi: fix hyphenation of "floating point" and related terms

2012-01-28 Thread Sandra Loosemore
On 01/28/2012 08:44 AM, Robert Dewar wrote: On 1/27/2012 10:57 PM, Sandra Loosemore wrote: I've checked in this patch as obvious. (Again, if anyone thinks these kinds of edits are not obvious, let me know, and I'll start posting them for review first instead.) Following the

[PATCH] invoke.texi: "compile time", "run time" cleanup

2012-01-28 Thread Sandra Loosemore
e (and Wikipedia, in particular, is quite confused on this topic), but to me it seems silly to make the adjective form of "runtime" hyphenated when it's already a single word as a noun. So, I decided to go consistently with "runtime support", "runtime library",

[PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-29 Thread Sandra Loosemore
es it adds no overhead. Bootstrapped and regression-tested on i636 linux. OK to check in? -Sandra 2012-01-29 Sandra Loosemore Jason Merrill Jakub Jelinek PR c++/51910 gcc/ * tlink.c (do_tlink): Explicitly pass --no-demangle to linker

[PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-29 Thread Sandra Loosemore
solve undefined symbols from the repository. In other cases it adds no overhead. Bootstrapped and regression-tested on i636 linux. OK to check in? -Sandra 2012-01-29 Sandra Loosemore Jason Merrill Jakub Jelinek PR c++/51910 gcc/ * tl

[wwwdocs] Re: [PATCH] invoke.texi: "compile time", "run time" cleanup

2012-01-29 Thread Sandra Loosemore
On 01/29/2012 07:31 AM, Joseph S. Myers wrote: On Sat, 28 Jan 2012, Sandra Loosemore wrote: 2012-01-28 Sandra Loosemore gcc/ * doc/invoke.texi: Make usage of "compile time" and "run time"/"runtime" consistent throughout the file.

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-01-30 Thread Sandra Loosemore
On 01/30/2012 07:23 AM, Jakub Jelinek wrote: On Sun, Jan 29, 2012 at 05:08:10PM -0700, Sandra Loosemore wrote: Bootstrapped and regression-tested on i636 linux. OK to check in? I think that is terribly expensive fix, for larger projects a single ld invocation can take several minutes. What

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 06:56 AM, Jakub Jelinek wrote: Do users really want to demangle linker maps? I would never want that, e.g. because it is ambiguous and less compact. IMHO the best is just to back out the changes that introduced this regression. I don't think this is even really a regression. I

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 12:31 PM, Jason Merrill wrote: Why do you want the link map to be demangled? It seems more reliable to deal with mangled symbols; there's always c++filt if you want to check what the symbols demangle to. It's certainly more reliable for automated tools to deal with mangled symbo

[PATCH] fix PR51910, take 2

2012-02-02 Thread Sandra Loosemore
hen you request demangled output :-P Anyway, thoughts on this patch? It bootstrapped and regression tested OK on i686-linux, and I hand-tested it on every permutation of mangling/repository/map options I could think of. -Sandra 2012-02-02 Sandra Loosemore Jason Merrill

[patch, committed] invoke.texi: clean up n-bit/byte/word modifiers

2012-02-15 Thread Sandra Loosemore
noun phrase, it's properly "32 bits". Likewise similar issues with n-byte or n-word modifiers. I've checked this in as obvious. -Sandra 2012-02-15 Sandra Loosemore gcc/ * doc/invoke.texi: Clean up &quo

[patch, committed] invoke.texi: "big-endian", "little-endian"

2012-02-17 Thread Sandra Loosemore
either term as a noun in invoke.texi, so thankfully I did not have to deal with that case. ;-) -Sandra 2012-02-17 Sandra Loosemore gcc/ * doc/invoke.texi: Consistently hyphenate "big-endian"/"little-endian"

[patch, committed] invoke.texi: GCC coding conventions issues

2012-02-17 Thread Sandra Loosemore
ot;enumerated type" * "epilogue/prologue" * "lowercase"/"uppercase" -Sandra 2012-02-17 Sandra Loosemore gcc/ * doc/invoke.texi: Minor copy-edits to bring into conformance with GCC coding conventions. Index: gcc/doc/invoke.texi

[patch, committed] invoke.texi: copy-edit docs for IRA options and parameters

2012-02-18 Thread Sandra Loosemore
maybe it's not strictly "obvious", but it's intended to be a content-free change in terms of meaning, and it's at least an incremental improvement in readability compared to what's there now. -Sandra 2012-02-18 Sandra Loosemore gcc/ * doc/invok

[patch, committed] invoke.texi: copy-edit x86 sections

2012-03-04 Thread Sandra Loosemore
time and some of it may be bit-rotten in other ways. -Sandra 2012-03-04 Sandra Loosemore gcc/ * doc/invoke.texi (C++ Dialect Options): Minor copy-edits to x86-specific text. (Debugging Options): Likewise. (Optimize Options): Likewise. (i386 an

PATCH: fix collect2 handling of --demangle and --no-demangle

2011-06-17 Thread Sandra Loosemore
d the COLLECT_NO_DEMANGLE environment variable setting recipe. (3) I simplified the argument processing for --demangle and --no-demangle to pass them straight through to the linker when HAVE_LD_DEMANGLE is defined. OK to commit? -Sandra 2011-06-17 Sandra Loosemore gc

PING Re: PATCH: fix collect2 handling of --demangle and --no-demangle

2011-06-27 Thread Sandra Loosemore
wards compatibility, here (2) I fixed the COLLECT_NO_DEMANGLE environment variable setting recipe. (3) I simplified the argument processing for --demangle and --no-demangle to pass them straight through to the linker when HAVE_LD_DEMANGLE is defined. OK to commit? -Sandra 2011-06-17 Sa

PING^2 Re: PATCH: fix collect2 handling of --demangle and --no-demangle

2011-07-11 Thread Sandra Loosemore
wards compatibility, here (2) I fixed the COLLECT_NO_DEMANGLE environment variable setting recipe. (3) I simplified the argument processing for --demangle and --no-demangle to pass them straight through to the linker when HAVE_LD_DEMANGLE is defined. OK to commit? -Sandra 2011-06-17 Sa

PATCH: fix think-o in genrecog.c

2011-07-18 Thread Sandra Loosemore
n? I tested it by diffing the generated insn-recog.c for a mips-sde-elf build against one I got using a pre-r174305 genrecog.c. -Sandra 2011-07-18 Sandra Loosemore gcc/ * genrecog.c (make_insn_sequence): Correct position numbering when filtering out match

Re: PING^2 Re: PATCH: fix collect2 handling of --demangle and --no-demangle

2011-07-24 Thread Sandra Loosemore
On 07/24/2011 08:09 PM, H.J. Lu wrote: On Sun, Jul 24, 2011 at 7:03 PM, H.J. Lu wrote: On Mon, Jul 11, 2011 at 10:45 AM, Sandra Loosemore wrote: 2011-06-17 Sandra Loosemore gcc/ * configure.ac (demangler_in_ld): Default to yes. * configure: Regenerated. * collect2.c

Re: Ping: [PATCH] gcc/doc: adjust __builtin_choose_expr() description

2024-10-08 Thread Sandra Loosemore
On 10/8/24 09:35, Jan Beulich wrote: On 08.10.2024 17:30, Sandra Loosemore wrote: [snip] Hmmm, looking at the complete documentation for this built-in, and the code, I think I'd go a little farther with fixing up the docs. Since requiring the first operand to be a constant is also diff

Re: Ping: [PATCH] gcc/doc: adjust __builtin_choose_expr() description

2024-10-08 Thread Sandra Loosemore
On 10/8/24 08:12, Jan Beulich wrote: On 19.06.2024 16:01, Jan Beulich wrote: Present wording has misled people to believe the ?: operator would be evaluating all three of the involved expressions. gcc/ * doc/extend.texi: Clarify __builtin_choose_expr() similarity to the ?: oper

Re: [PATCH v3 03/12] libgomp: runtime support for target_device selector

2024-09-21 Thread Sandra Loosemore
On 9/9/24 04:46, Tobias Burnus wrote: I wonder whether we should do something like the following. [The following is a mix between compile code and generated code, for illustrative purpose.] Inside the compiler do: #ifndef ACCEL_COMPILER intr = 0; if (targetm.omp.device_kind_arch_isa != NULL

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-21 Thread Sandra Loosemore
On 9/20/24 01:41, Jakub Jelinek wrote: + + /* Check for unknown properties. */ if (omp_ts_map[ts_code].valid_properties == NULL) continue; - Why? Why what? I made this change because when I added another check in this loop I was temporarily confused about the

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-22 Thread Sandra Loosemore
On 9/21/24 22:52, Jakub Jelinek wrote: On Sat, Sep 21, 2024 at 08:08:29PM -0600, Sandra Loosemore wrote: On 9/20/24 01:41, Jakub Jelinek wrote: + + /* Check for unknown properties. */ if (omp_ts_map[ts_code].valid_properties == NULL) continue; - Why? Why what

Re: [r15-3834 Regression] FAIL: c-c++-common/gomp/declare-variant-duplicates.c (test for excess errors) on Linux/x86_64

2024-09-24 Thread Sandra Loosemore
On 9/24/24 14:08, haochen.jiang wrote: On Linux/x86_64, 96246bff0bcd9e5cdec9e6cf811ee3db4997f6d4 is the first bad commit commit 96246bff0bcd9e5cdec9e6cf811ee3db4997f6d4 Author: Sandra Loosemore Date: Fri Sep 6 20:58:13 2024 + OpenMP: Check additional restrictions on context

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-18 Thread Sandra Loosemore
On 9/9/24 14:55, Sandra Loosemore wrote: On 9/9/24 05:01, Jakub Jelinek wrote: I think also testing the device={kind(any,any)} and device={kind("any",any)} and device={kind(any,"any"))} would be useful. Hmmm, it looks like GCC does not presently check for the rest

[COMMITTED, wwwdocs] gcc-15: Document removal of Nios II back end

2024-11-25 Thread Sandra Loosemore
--- htdocs/gcc-15/changes.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-15/changes.html b/htdocs/gcc-15/changes.html index 80604ab8..6c9ebaac 100644 --- a/htdocs/gcc-15/changes.html +++ b/htdocs/gcc-15/changes.html @@ -29,7 +29,9 @@ a work-in-progress. C

[PATCH v4 08/10] OpenMP: Fortran support for metadirectives and dynamic selectors

2024-11-15 Thread Sandra Loosemore
: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Tobias Burnus Co-Authored-By: Paul-Antoine Arras --- gcc/fortran/decl.cc | 29 + gcc/fortran/dump-parse-tree.cc| 20 + gcc/fortran/gfortran.h

[PATCH v4 07/10] OpenMP: Shared metadirective/dynamic selector tests for C and C++

2024-11-15 Thread Sandra Loosemore
-late-2.c: New. * testsuite/libgomp.c-c++-common/metadirective-target-device.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- .../c-c++-common/gomp/attrs-metadirective-1.c | 47 + .../c-c++-common/gomp/attrs-metadirective-2.c | 76 .../c-c

[PATCH v4 02/10] OpenMP: Re-work and extend context selector resolution

2024-11-15 Thread Sandra Loosemore
r PR114596. * gfortran/gomp/declare-variant-13.f90: Tweak testcase to ensure that -O causes dead code to be optimized away. * gfortran/gomp/declare-variant-14.f90: Likewise. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Marcel Vollweiler ---

[PATCH v4 10/10] OpenMP: Update documentation of metadirective implementation status.

2024-11-15 Thread Sandra Loosemore
libgomp/ChangeLog * libgomp.texi (OpenMP 5.0): Mark metadirective and declare variant as implemented. (OpenMP 5.1): Mark target_device as supported. Add changed interaction between declare target and OpenMP context and dynamic selector support. (OpenM

[PATCH v4 03/10] OpenMP: Remove dead code from declare variant reimplementation

2024-11-15 Thread Sandra Loosemore
After reimplementing late resolution of "declare variant", the declare_variant_alt and calls_declare_variant_alt flags on struct cgraph_node are no longer used by anything. For the purposes of marking functions that need late resolution, the has_omp_variant_constructs flag has replaced calls_decla

[PATCH v4 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2024-11-15 Thread Sandra Loosemore
properties. (analyze_metadirective_body): New. (c_parser_omp_metadirective): New. gcc/testsuite/ PR middle-end/112779 * c-c++-common/gomp/declare-variant-2.c: Adjust expected output for C. * gcc.dg/gomp/metadirective-1.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore

[PATCH v4 01/10] OpenMP: New tree nodes for metadirective and dynamic selector support.

2024-11-15 Thread Sandra Loosemore
ew. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/doc/generic.texi | 63 +++ gcc/fold-const.cc| 2 + gcc/gimple-expr.cc | 5 +++ gcc/gimple.cc| 4 +- gcc/tree-cfg.cc | 1 + gcc/tree-inline.cc |

[PATCH v4 00/10] OpenMP: Implement metadirective and dynamic selectors

2024-11-15 Thread Sandra Loosemore
iant" that I have not yet submitted because I've been blocked on getting these infrastructure changes in first. -Sandra Sandra Loosemore (10): OpenMP: New tree nodes for metadirective and dynamic selector support. OpenMP: Re-work and extend context selector resolution OpenMP: Remove

[PATCH v4 04/10] OpenMP: Robustify C front end handling of attribute-syntax pragmas

2024-11-15 Thread Sandra Loosemore
Presently, the code to handle OpenMP attribute-syntax pragmas in the C front end assumes nothing else is messing with redirecting parser->tokens, and makes no provision for restoring it from anything other than parser->tokens_buf when the buffer allocated for the pragma is exhausted. Adding suppor

[PATCH v4 09/10] OpenMP: Update "declare target"/OpenMP context interaction

2024-11-15 Thread Sandra Loosemore
The code and test case previously implemented the OpenMP 5.0 spec, which said in section 2.3.1: "For functions within a declare target block, the target trait is added to the beginning of the set..." In OpenMP 5.1, this was changed to "For device routines, the target trait is added to the beginni

[PATCH v4 06/10] OpenMP: C++ support for metadirectives and dynamic selectors.

2024-11-15 Thread Sandra Loosemore
* testsuite/libgomp.c++/metadirective-template-2.C: New. * testsuite/libgomp.c++/metadirective-template-3.C: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/cp/cp-tree.h | 2 + gcc/cp/parser.cc

Re: [PATCH 09/11] doc: Mention floating point atomic fetch_add etc in docs

2024-11-14 Thread Sandra Loosemore
On 11/14/24 07:51, Gerald Pfeifer wrote: On Thu, 14 Nov 2024, mmalcom...@nvidia.com wrote: gcc/ChangeLog: * doc/extend.texi: Document ability to use floating point atomic fetch_add/fetch_sub/add_fetch/sub_fetch builtins. +Moreover, the @samp{__atomic_fetch_add}, @samp{__atomi

Re: [Patch] [gcn] install.texi: Update for new ISA targets and their requirements

2025-02-10 Thread Sandra Loosemore
On 2/10/25 08:50, Tobias Burnus wrote: Update the GCN install documentation for added ISAs, especially as no longer all supported ISA are enabled by default.  And for the (ROCm wise: upcoming) generic support. OK for mainline? I have no comments on the technical content, but @@ -3991,14

[PATCH 0/7] [stage1 + og14] OpenMP: Implement "begin declare variant"

2025-02-10 Thread Sandra Loosemore
(e.g. PR118530 and PR118791) causing some bogus errors that are xfailed in the corresponding test cases. -Sandra Sandra Loosemore (7): OpenMP: Bug fixes for comparing context selectors OpenMP: Pass a 3-way flag to omp_check_context_selector instead of a bool. OpenMP: Support functions for neste

[PATCH 4/7] OpenMP: Add flag for code elision to omp_context_selector_matches.

2025-02-10 Thread Sandra Loosemore
The "begin declare variant" has different rules for determining whether a context selector cannot match for purposes of code elision than we normally use; it excludes the case of a constant false "condition" selector for the "user" set. gcc/ChangeLog * omp-general.cc (omp_context_selector_

[PATCH 2/7] OpenMP: Pass a 3-way flag to omp_check_context_selector instead of a bool.

2025-02-10 Thread Sandra Loosemore
The OpenMP "begin declare variant" directive has slightly different requirements for context selectors than regular "declare variant", so something more than a bool is required to tell the error-checking routine what to check. gcc/ChangeLog * omp-general.cc (omp_check_context_selector): Ch

[PATCH 3/7] OpenMP: Support functions for nested "begin declare variant"

2025-02-10 Thread Sandra Loosemore
This patch adds functions for variant name mangling and context selector merging that are shared by the C and C++ front ends. The OpenMP specification says that name mangling is supposed to encode the context selector for the variant, but also provides for no way to reference these functions direc

[PATCH 7/7] OpenMP: C/C++ common testcases for "omp begin declare variant"

2025-02-10 Thread Sandra Loosemore
gcc/testsuite/ChangeLog * c-c++-common/gomp/delim-declare-variant-1.c: New. * c-c++-common/gomp/delim-declare-variant-2.c: New. * c-c++-common/gomp/delim-declare-variant-3.c: New. * c-c++-common/gomp/delim-declare-variant-4.c: New. * c-c++-common/gomp/delim-d

[PATCH 6/7] OpenMP: C front end support for "begin declare variant"

2025-02-10 Thread Sandra Loosemore
gcc/c/ChangeLog * c-decl.cc (current_omp_declare_variant_attribute): Define. * c-lang.h (struct c_omp_declare_variant_attr): Declare. (current_omp_declare_variant_attribute): Declare. * c-parser.cc (c_parser_skip_to_pragma_omp_end_declare_variant): New. (c_pa

[PATCH 1/7] OpenMP: Bug fixes for comparing context selectors

2025-02-10 Thread Sandra Loosemore
gcc/ChangeLog * omp-general.cc (omp_context_selector_props_compare): Handle arbitrary expressions in the "user" and "device_num" selectors. (omp_context_selector_set_compare): Detect mismatch when one selector specifies a score and the other doesn't. --- gcc/omp-gen

[PATCH 5/7] OpenMP: C++ front end support for "begin declare variant"

2025-02-10 Thread Sandra Loosemore
This patch implements C++ support for the "begin declare variant" construct. The OpenMP specification is hazy on interaction of this feature with C++ language features. Variant functions in classes are supported but must be defined as members in the class definition, using an unqualified name for

[PATCH] OpenMP: Improve Fortran metadirective diagnostics [PR107067]

2025-01-31 Thread Sandra Loosemore
The Fortran front end was giving an ICE instead of a user-friendly diagnostic when variants of a metadirective variant had different statement associations. The particular test case reported in the issue also involved invalid placement of the "omp end metadirective" which was not being diagnosed e

[PATCH v5 01/10] OpenMP: New tree nodes for metadirective and dynamic selector support.

2024-12-09 Thread Sandra Loosemore
ew. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/doc/generic.texi | 63 +++ gcc/fold-const.cc| 2 + gcc/gimple-expr.cc | 5 +++ gcc/gimple.cc| 4 +- gcc/tree-cfg.cc | 1 + gcc/tree-inline.cc |

[PATCH v5 00/10] OpenMP: Implement metadirective and dynamic selectors

2024-12-09 Thread Sandra Loosemore
construct. I still hope this functionality can make it into GCC 15. -Sandra Sandra Loosemore (10): OpenMP: New tree nodes for metadirective and dynamic selector support. OpenMP: Re-work and extend context selector resolution OpenMP: Remove dead code from declare variant reimplementation

[PATCH v5 04/10] OpenMP: Robustify C front end handling of attribute-syntax pragmas

2024-12-09 Thread Sandra Loosemore
Presently, the code to handle OpenMP attribute-syntax pragmas in the C front end assumes nothing else is messing with redirecting parser->tokens, and makes no provision for restoring it from anything other than parser->tokens_buf when the buffer allocated for the pragma is exhausted. Adding suppor

[PATCH v5 02/10] OpenMP: Re-work and extend context selector resolution

2024-12-09 Thread Sandra Loosemore
f90: Likewise. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Marcel Vollweiler --- gcc/Makefile.in |2 +- gcc/c/c-parser.cc |4 +- gcc/cgraph.h |3 + gcc/c

[PATCH v5 03/10] OpenMP: Remove dead code from declare variant reimplementation

2024-12-09 Thread Sandra Loosemore
After reimplementing late resolution of "declare variant", the declare_variant_alt and calls_declare_variant_alt flags on struct cgraph_node are no longer used by anything. For the purposes of marking functions that need late resolution, the has_omp_variant_constructs flag has replaced calls_decla

[PATCH v5 07/10] OpenMP: Shared metadirective/dynamic selector tests for C and C++

2024-12-09 Thread Sandra Loosemore
: New. * testsuite/libgomp.c-c++-common/metadirective-late-2.c: New. * testsuite/libgomp.c-c++-common/metadirective-target-device.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- .../c-c++-common/gomp/attrs-metadirective-1.c | 47 + .../c-c

[PATCH v5 05/10] OpenMP: Add C support for metadirectives and dynamic selectors.

2024-12-09 Thread Sandra Loosemore
properties. (analyze_metadirective_body): New. (c_parser_omp_metadirective): New. gcc/testsuite/ PR middle-end/112779 * c-c++-common/gomp/declare-variant-2.c: Adjust expected output for C. * gcc.dg/gomp/metadirective-1.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore

[PATCH v5 10/10] OpenMP: Update documentation of metadirective implementation status.

2024-12-09 Thread Sandra Loosemore
libgomp/ChangeLog * libgomp.texi (OpenMP 5.0): Mark metadirective and declare variant as implemented. (OpenMP 5.1): Mark target_device as supported. Add changed interaction between declare target and OpenMP context and dynamic selector support. (OpenM

[PATCH v5 08/10] OpenMP: Fortran support for metadirectives and dynamic selectors

2024-12-09 Thread Sandra Loosemore
: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Tobias Burnus Co-Authored-By: Paul-Antoine Arras --- gcc/fortran/decl.cc | 29 + gcc/fortran/dump-parse-tree.cc| 20 + gcc/fortran/gfortran.h

[PATCH v5 06/10] OpenMP: C++ support for metadirectives and dynamic selectors.

2024-12-09 Thread Sandra Loosemore
* testsuite/libgomp.c++/metadirective-template-2.C: New. * testsuite/libgomp.c++/metadirective-template-3.C: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/cp/cp-tree.h | 2 + gcc/cp/parser.cc

[PATCH v5 09/10] OpenMP: Update "declare target"/OpenMP context interaction

2024-12-09 Thread Sandra Loosemore
The code and test case previously implemented the OpenMP 5.0 spec, which said in section 2.3.1: "For functions within a declare target block, the target trait is added to the beginning of the set..." In OpenMP 5.1, this was changed to "For device routines, the target trait is added to the beginni

[COMMITTED] Fix misplaced x86 -mstack-protector-guard-symbol documentation [PR117150]

2024-12-11 Thread Sandra Loosemore
Commit e1769bdd4cef522ada32aec863feba41116b183a accidentally inserted the documentation for the x86 -mstack-protector-guard-symbol option in the wrong place. Fixed thusly. gcc/ChangeLog PR target/117150 * doc/invoke.texi (RS/6000 and PowerPC Options): Move description of -

Re: [COMMITTED] i386: regenerate i386.opt.urls

2024-12-12 Thread Sandra Loosemore
On 12/12/24 03:53, Sam James wrote: r15-6128-gfa878dc8c45fa3 missed the regeneration of the URL doc map, so regenerate it here to make the buildbots happy. I apologize for this breakage. :-( Can someone explain how I can detect this problem *before* submitting patches, and how to fix it, so

Re: [COMMITTED] Documentation: Make OpenMP/OpenACC docs easier to find [PR26154]

2024-12-17 Thread Sandra Loosemore
On 12/17/24 14:21, Tobias Burnus wrote: Hi Sandra, thanks for the patch! One minor nit: Sandra Loosemore wrote: +To enable the processing of OpenACC directives @samp{#pragma omp} #pragma acc – not #pragma omp. Sigh, I need to get new glasses! Fixed with the attached patch. -SandraFrom

[COMMITTED] Documentation: Make OpenMP/OpenACC docs easier to find [PR26154]

2024-12-17 Thread Sandra Loosemore
PR c/26154 is one of our oldest documentation issues. The only discussion of OpenMP support in the GCC manual is buried in the "C Dialect Options" section, with nothing at all under "Extensions". The Fortran manual does have separate sections for OpenMP and OpenACC extensions so I have copy-edite

[COMMITTED] Clean up documentation of -Wsuggest-attribute= [PR115532]

2024-12-12 Thread Sandra Loosemore
The list of -Wsuggest-attribute= variants was out of date in the option summary (and getting too long to fit on one line), and an index entry was missing for -Wsuggest-attribute=returns_nonnull. gcc/c-family/ChangeLog PR c/115532 * c.opt.urls: Regenerated. gcc/ChangeLog PR

[COMMITTED] Regenerate attr-urls.def.

2024-12-12 Thread Sandra Loosemore
I noticed there is this new generated file that needs to be updated by "make regenerate-attr-urls" similarly to "make regenerate-opt-urls", but nobody had done that recently as the buildbot does not nag about it yet. gcc/ChangeLog * attr-urls.def: Regenerate. --- gcc/attr-urls.def | 9 ++

<    7   8   9   10   11   12   13   14   >