Re: The COBOL front end, in 8 notes

2024-12-14 Thread Sam James
"James K. Lowden" writes: > The following 8 patches constitute the 80 files needed to build and > document the COBOL front end. They assume that following exist: > > gcc/cobol/ChangeLog > libgcobol/ChangeLog > > The messages are grouped by files in a more or less logical order, > but gro

Re: The COBOL front end, in 8 notes

2024-12-14 Thread Sam James
David Malcolm writes: > On Thu, 2024-12-12 at 12:56 -0500, James K. Lowden wrote: >> The following 8 patches constitute the 80 files needed to build and >> document the COBOL front end.  They assume that following exist: >> >>     gcc/cobol/ChangeLog >>     libgcobol/ChangeLog >> >> The message

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-13 Thread Sam James
Sam James writes: > David Malcolm writes: > >> This patch attempts to provide better error messages for >> code compiled with C23 that hasn't been updated for >> "bool", "true", and "false" becoming keywords (based on >>

Re: The COBOL front end, in 8 notes

2024-12-19 Thread Sam James
"James K. Lowden" writes: > On Thu, 12 Dec 2024 12:56:36 -0500 > "James K. Lowden" wrote: > >> The following 8 patches constitute the 80 files needed to build and >> document the COBOL front end. > [...] > * does not build on Darwin/macOS [Iain] > [...] > - 32-bit architectures are not a consid

Re: [PING] [contrib] validate_failures.py: fix python 3.12 escape sequence warnings

2024-11-22 Thread Sam James
Jeff Law writes: > On 6/9/24 5:45 AM, Gabi Falk wrote: >> Hi, >> On Sat, Jun 08, 2024 at 03:34:02PM -0600, Jeff Law wrote: >>> On 5/14/24 8:12 AM, Gabi Falk wrote: Hi, This one still needs review: https://inbox.sourceware.org/gcc-patches/20240415233833.104460-1-gabif...@g

[PATCH] Sync top-level configure with binutils

2024-11-22 Thread Sam James
This syncs us with binutils/gdb's toplevel configure as of 987db70acefd0b223a8df2240d4e5ca544cc0a91. There's not much notable here, just gprofng (which is in binutils) being disabled for musl and a new target which got added on that side too. The only part which may look interesting is the basear

Re: [PATCH] wwwdocs: Align the DCO text for the GNU Toolchain to match community usage.

2024-11-22 Thread Sam James
Jason Merrill writes: > On 11/21/24 6:04 PM, Carlos O'Donell wrote: >> Adjust the DCO text to match the broader community usage including >> the Linux kernel use around "real names." >> These changes clarify what was meant by "real name" and that it is >> not required to be a "legal name" or any

Re: [PATCH] wwwdocs: Align the DCO text for the GNU Toolchain to match community usage.

2024-11-21 Thread Sam James
Mark Wielaard writes: > Hi Carlos, > > On Thu, 2024-11-21 at 12:04 -0500, Carlos O'Donell wrote: >> Adjust the DCO text to match the broader community usage including >> the Linux kernel use around "real names." > > We made a similar change to switch from "real names" to "known > identifies" for

Re: [PATCH v1] autoupdate: replace obsolete macros in libiberty

2024-11-22 Thread Sam James
Matthieu Longo writes: > Autoreconf-2.72 warns about obsolete macros. This patch aims at removing > the noise from a future upgrade to autoreconf-2.72 or later. This is in > no a way a complete patch allowing the upgrade to autoreconf-2.72. > > - AC_GNU_SOURCE by AC_USE_SYSTEM_EXTENSIONS > http

Re: 3rd Ping: [Middle-end][PATCH v4 0/3][RFC]Provide more contexts for -Warray-bounds and -Wstringop-* warning messages

2024-12-06 Thread Sam James
Qing Zhao writes: > This is the 3rd ping of the Middle-end review for this patch. > Jeff, would you be able to take a look? (In part because I know you've had a lot of comments and feedback on the middle-end warnings before). The diagnostics bits are OK'd already. I've been running this on dist

Re: [PATCH] c: special-case some "bool" errors with C23 [PR117629]

2024-12-06 Thread Sam James
David Malcolm writes: > This patch attempts to provide better error messages for > code compiled with C23 that hasn't been updated for > "bool", "true", and "false" becoming keywords (based on > a brief review of the Gentoo bug tracker links given at > https://gcc.gnu.org/pipermail/gcc/2024-Novem

Re: [RFC/RFA] [PR tree-optimization/92539] Improve code and avoid Warray-bounds false positive

2025-01-09 Thread Sam James
Richard Biener writes: > On Wed, Jan 8, 2025 at 5:34 PM Qing Zhao wrote: >> >> >> >> > On Jan 7, 2025, at 07:29, Richard Biener >> > wrote: >> > >> > On Mon, Jan 6, 2025 at 5:40 PM Qing Zhao wrote: >> >> >> >> >> >> >> >>> On Jan 6, 2025, at 11:01, Richard Biener >> >>> wrote: >> >>> >> >>>

Re: [committed] testsuite: Require int32plus for test case pr117546.c

2025-01-21 Thread Sam James
Dimitar Dimitrov writes: > Test case is valid even if size of int is more than 32 bits. > > Pushed to trunk as obvious. > > gcc/testsuite/ChangeLog: > > * gcc.dg/torture/pr117546.c: Require effective target int32plus. > > Cc: Georg-Johann Lay > Cc: Sam J

Re: [PATCH v1] RISC-V: Make FRM as global register [PR118103] [PR118646]

2025-01-25 Thread Sam James
pan2...@intel.com writes: > From: Pan Li > > After we enabled the labe-combine pass after the mode-switching pass, it > will try to combine below insn patterns into op. Aka: > > (insn 40 5 41 2 (set (reg:SI 11 a1 [151]) > (reg:SI 69 frm)) "pr118103-simple.c":67:15 2712 {frrmsi} > (nil)) > (i

Re: [PATCH] testsuite: Fixes for test case pr117546.c

2025-01-18 Thread Sam James
.c: Require effective target int32. > (main): Add return statement. > > Ok for trunk? > > Cc: Sam James > Signed-off-by: Dimitar Dimitrov > --- I think it can go in as obvious. Thanks for the fixup. > gcc/testsuite/gcc.dg/torture/pr117546.c | 4 +++- > 1 file changed

Re: [PATCH v1] RISC-V: Make FRM as global register [PR118103] [PR118646]

2025-01-25 Thread Sam James
"Li, Pan2" writes: > Thanks Jeff and Sam, updated v2 for -fno-strict-aliasing. Thanks! The test looks good now. > > Pan > > -Original Message- > From: Jeff Law > Sent: Sunday, January 26, 2025 1:06 AM > To: Li, Pan2 ; gcc-patches@gcc.gnu.org > Cc: juzhe.zh...@rivai.ai; kito.ch...@gmai

[PATCH] testsuite: torture: add LLVM testcase for DSE vs. -ftrivial-auto-var-init=

2025-01-02 Thread Sam James
This testcase came up in a recent LLVM bug report [0] for DSE vs -ftrivial-auto-var-init=. Add it to our testsuite given that area could do with better coverage. [0] https://github.com/llvm/llvm-project/issues/119646 gcc/testsuite/ChangeLog: * gcc.dg/torture/dse-trivial-auto-var-init.c:

Re: [patch, Fortran, doc] Mention generating C prototypes from Fortran

2025-01-03 Thread Sam James
Thomas Koenig writes: > Hello world, > > I noticed that there is no mention of automatically generating > C prototypes and declarations in the relevant section of > the docs, "Interoperability with C". This patch remedies that. > > OK for trunk? > > Best regards > > Thomas > > gcc/fortran/C

Re: [PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-03 Thread Sam James
Sam James writes: > PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but > the testcase here is sufficiently different to be worth including > in torture/. > > gcc/testsuite/ChangeLog: > PR ipa/117546 > * gcc.dg/torture/pr117546.c: New test. &

[PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-03 Thread Sam James
PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but the testcase here is sufficiently different to be worth including in torture/. gcc/testsuite/ChangeLog: PR ipa/117546 * gcc.dg/torture/pr117546.c: New test. --- gcc/testsuite/gcc.dg/torture/pr117546.c | 84

[PATCH 2/2] testsuite: add testcase for fixed PR98000

2025-01-03 Thread Sam James
gcc/testsuite/ChangeLog: PR ipa/98000 * g++.dg/ipa/pr98000.C: New test. --- gcc/testsuite/g++.dg/ipa/pr98000.C | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ipa/pr98000.C diff --git a/gcc/testsuite/g++.dg/ipa/pr98000

Re: [PATCH v11] ada: fix timeval timespec on 32 bits archs with 64 bits time_t [PR114065]

2025-01-03 Thread Sam James
Marc Poulhiès writes: > Hello Nicolas, > >>> At first view, it seems possible and desirable to merge _posix and >>> _rtems, but working on this right now would be counter-productive. >>> >>> I suggest to apply patches 1-2 and fix PR114065 first. >>> >>> Then the cosmetic changes in patches 3-6 (a

Re: [PATCH v11] ada: fix timeval timespec on 32 bits archs with 64 bits time_t [PR114065]

2025-01-03 Thread Sam James
Marc Poulhiès writes: >>> Would it make sense to drop the "Glibc" here? Having "Glibc" means that >>> we end up with glibc specifics in files that are not glibc specific (e.g. >>> a-exetim__posix.adb or s-osinte__linux.ads). Are these particular macros >>> glibc specific? We need these to build w

Re: [PATCH] Annotate dbg_line_numbers table

2025-01-15 Thread Sam James
Richard Biener writes: > [...]. It also cuts the lines down to 10 entries. (This version doesn't ;)) > > static int dbg_line_numbers[1267] = { > /* 0 */ 161, 164, 173, 175, 178, 181, 183, 189, 197, 195, > /* 10 */ 199, 201, 205, 923, 921, 2060, 2071, 2052, 2058, 2063, > ... >

[COMMITTED 2/2] doc: cleanup trailing whitespace

2025-01-15 Thread Sam James
gcc/ChangeLog: * doc/extend.texi: Cleanup trailing whitespace. --- Committed as obvious. gcc/doc/extend.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 84894efc2ea4..52ba78b80361 100644 --- a/gcc/doc/extend.te

[COMMITTED 1/2] doc: trivial grammar fix

2025-01-15 Thread Sam James
We say 'a constant .. expression' elsewhere. Fix the grammar. gcc/ChangeLog: * doc/extend.texi: Add 'a' for grammar fix. --- Committed as obvious. gcc/doc/extend.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 1e1b

Re: [PATCH] MAINTAINERS: Add myself to write after approval

2025-01-17 Thread Sam James
See https://gcc.gnu.org/gitwrite.html#authenticated.

Re: [RFC] PR81358: Enable automatic linking of libatomic

2025-01-17 Thread Sam James
Prathamesh Kulkarni writes: >> -Original Message- >> From: Prathamesh Kulkarni >> Sent: 10 January 2025 09:48 >> To: Thomas Schwinge >> Cc: Tobias Burnus ; Joseph Myers >> ; Xi Ruoyao ; Matthew >> Malcomson ; gcc-patches@gcc.gnu.org; Tom de >> Vries >> Subject: RE: [RFC] PR81358: Enabl

Re: [PATCH htdocs] bugs: mention ASAN too

2025-02-13 Thread Sam James
Gerald Pfeifer writes: > On Mon, 11 Nov 2024, Sam James wrote: >> Request that reporters try `-fsanitize=address,undefined` rather than >> just `-fsanitize=undefined` when reporting bugs. We get invalid bug >> reports which ASAN would've caught sometimes, even if it&

Re: [PATCH v4] [ifcombine] avoid creating out-of-bounds BIT_FIELD_REFs [PR118514]

2025-02-13 Thread Sam James
Alexandre Oliva writes: > On Feb 6, 2025, Sam James wrote: > >> Richard Biener writes: >>> On Thu, Feb 6, 2025 at 2:41 PM Alexandre Oliva wrote: >>>> >>>> On Jan 27, 2025, Richard Biener wrote: >>>> > (I see the assert is no lon

Re: [PATCH] COBOL 6/15 156K lex: lexer

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:52 PM EST > Subject: [PATCH] 3 new 'cobol' FE files > > gcc/cobol/ChangeLog > * cdf-copy.cc: New file. > * lexio.cc: New file. >

Re: [PATCH] COBOL 3/15 92K bld: config and build machinery

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:52 PM EST > Subject: [PATCH] Add 'cobol' to 17 files The commit message summary (first line) should say something like the email title, so

Re: [PATCH] COBOL 12/15 24K pos: Posix adapter framework

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:54 PM EST > Subject: [PATCH] 12 new 'cobol' FE files Please make sure the commit summaries reflect the contents. > > gcc/cobol/ChangeLog >

Re: [PATCH] x86: Properly find the maximum stack slot alignment

2025-02-12 Thread Sam James
"H.J. Lu" writes: > Don't assume that stack slots can only be accessed by stack or frame > registers. We first find all registers defined by stack or frame > registers. Then check memory accesses by such registers, including > stack and frame registers. > > gcc/ > > PR target/109780 > PR target

Re: [PATCH] COBOL 10/15 252K gen: GENERIC interface support

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:53 PM EST > Subject: [PATCH] 3 new 'cobol' FE files > > gcc/cobol/ChangeLog > * gengen.cc: New file. > * genmath.cc: New file. >

[PATCH] testsuite: add testcase for recent alias fix

2025-03-25 Thread Sam James
r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs but there wasn't a testcase available at the time. Now there is. Thanks to Andrew for the testcase. gcc/testsuite/ChangeLog: PR testsuite/119382 * gcc.dg/ipa/ipa-icf-40.c: New test. Co-authored-by: Andrew Pinsk

Re: [PATCH v2] reassoc: Optimize CMP/XOR expressions [PR116860]

2025-03-16 Thread Sam James
Hans-Peter Nilsson writes: > On Thu, 13 Mar 2025, Konstantinos Eleftheriou wrote: >> Testcases for match.pd patterns >> `((a ^ b) & c) cmp d | a != b -> (0 cmp d | a != b)` and >> `(a ^ b) cmp c | a != b -> (0 cmp c | a != b)` were failing on some targets, >> like PowerPC. >> >> This patch adds

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-17 Thread Sam James
Andreas Schwab writes: > On Mär 13 2025, James K. Lowden wrote: > >> On Tue, 11 Mar 2025 11:18:22 +0100 >> Andreas Schwab wrote: >> >>> libgcobol/configure.tgt says it's supported on powerpc64le. >> >> Our intention, tell me if you disagree, is that cobol is enabled if >> >> 1. --enable-languag

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread Sam James
NightStrike writes: > How is an online only name different from an anonymous pseudonym? It doesn’t > seem to me that your changes actually > clarify anything. To me, they make it more ambiguous. The idea is to not have something throwaway (please also don't toppost).

Re: combine: Re-enable 2->2 combinations, with limits [PR116398]

2025-04-05 Thread Sam James
Richard Sandiford writes: > This series is an update of: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-April/679924.html > > As discussed in that thread, the changes since last time are to make > distribute_links start from the last use, where easy, and to avoid > an unnecessary insn walk

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-04-05 Thread Sam James
Jakub Jelinek writes: > Hi! > > r15-8956 changed in the test: > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > which made it even worse than before, when the directive has > been silently ignored because it didn't match the regex

[PATCH] aarch64: change another CRC test

2025-04-05 Thread Sam James
Fixed the iteration number in crc-crc32-data16.c test from 8 to 16 to match the test name, just like in r15-9038-gdf55a933cfc675. gcc/testsuite/ChangeLog: * gcc.target/aarch64/crc-crc32-data16.c: Fix iteration count to match testname. --- Do we need this as well? Untested so far.

Re: [PATCH] testsuite: Fix up strub-internal-pr112938.C test for C++2{0,3,6}

2025-04-05 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 27, 2025 at 12:05:21AM +0000, Sam James wrote: >> The test was being ignored because dg.exp looks for .C in g++.dg/. >> >> gcc/testsuite/ChangeLog: >> PR middle-end/112938 >> >> * g++.dg/strub-internal-pr11293

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
ghtened out, everything is working without > the flag_strict_aliasing modification. > > Thanks for asking, and thanks for listening. > >> -Original Message- >> From: Robert Dubner >> Sent: Friday, April 4, 2025 16:02 >> To: Sam James >> Cc: GCC Patches &g

[PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-26 Thread Sam James
A handful of cosmetic ones in here but most meant the directive wasn't doing anything. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/udlit-namespace-ambiguous.C: Fix whitespace. * g++.dg/cpp2a/constexpr-init21.C: Ditto. * g++.dg/diagnostic/wrong-tag-1.C: Ditto. * g++.dg/

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Sam James writes: > David Malcolm writes: > >> This patch adds a new dg-lint subdirectory below contrib, containing >> a "dg-lint" script for detecting common mistakes made in our DejaGnu >> tests. >> I should say: I don't think any of my comm

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 09:32:30PM +0000, Sam James wrote: >> Right, we can extend it for 'dg-do known-actions' as well. > > I think that shouldn't be necessary. > > gcc-dg-test-1 should already complain about unexpected actions. Ah, you're right. Thanks.

[PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-03-26 Thread Sam James
Include the term used in the standard to ease further research for users. gcc/ChangeLog: * doc/invoke.texi: Use "compatible types" term. --- gcc/doc/invoke.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index b3f

[PATCH 1/6] testsuite: fortran: fix dg syntax errors

2025-03-26 Thread Sam James
No change in test results. The changes other than the first are arguably not errors, but still clearly wrong and mistakes. gcc/testsuite/ChangeLog: * gfortran.dg/associate_70.f90: Replace ')' with '}'. * gfortran.dg/bessel_3.f90: Drop extraneous ')'. * gfortran.dg/c_funloc

[PATCH 3/6] testsuite: more (mostly cosmetic) dg- whitespace fixes

2025-03-26 Thread Sam James
Some of these are harmless but still inconsistent (and asking for trouble given it may give people the wrong idea about similar "style"). gcc/testsuite/ChangeLog: * g++.dg/cpp0x/gen-attrs-6.C: Surround 'target' by whitespace. * gcc.target/aarch64/atomic-inst-ldlogic.c: Fix 'dg-fin

[PATCH 6/6] testsuite: assorted targets: add missing braces to dg-* directives

2025-03-26 Thread Sam James
These get ignored otherwise. gcc/testsuite/ChangeLog: * gcc.target/arc/taux-1.c: Add missing brace. * gcc.target/arc/taux-2.c: Ditto. * gcc.target/i386/addr-space-1.c: Ditto. * gcc.target/ia64/mfused-madd-vect.c: Ditto. * gcc.target/ia64/mfused-madd.c: Ditt

[PATCH 0/6] testsuite: more misc. syntax fixes

2025-03-26 Thread Sam James
Pushed as obvious. Sam James (6): testsuite: fortran: fix dg syntax errors testsuite: fix dg-bogus typo testsuite: more (mostly cosmetic) dg- whitespace fixes testsuite: fix dg-message typos testsuite: fix more dg-* whitespace issues testsuite: assorted targets: add missing braces to

[PATCH 2/4] testsuite: tree-ssa: fix PR98265 filename

2025-03-26 Thread Sam James
.C is for C++ testcases and gcc.dg's dg.exp ignores .c. The test was not being run. gcc/testsuite/ChangeLog: PR ipa/98265 * gcc.dg/tree-ssa/pr98265.C: Move to... * g++.dg/tree-ssa/pr98265.C: ...here. --- gcc/testsuite/{gcc.dg => g++.dg}/tree-ssa/pr98265.C | 0 1 file chan

[PATCH 0/4] testsuite: filename/location fixes

2025-03-26 Thread Sam James
These weren't being run before because of the wrong filename or location. Pushed the lot as obvious. Sam James (4): testsuite: g++.dg: fix PR112938 filename testsuite: tree-ssa: fix PR98265 filename testsuite: g++.dg: vect: fix PR37143 filename testsuite: tree-ssa: fix PR98265 te

[PATCH 4/4] testsuite: tree-ssa: fix PR98265 test to use C++14

2025-03-26 Thread Sam James
This test was previously not being run at all so this wasn't noticed until my fix just now. The test needs C++14 and it also should use scan-tree-dump, not scan-tree-dump-times, as it wasn't passing a count parameter. gcc/testsuite/ChangeLog: PR ipa/98265 * g++.dg/tree-ssa/pr9826

[PATCH 1/4] testsuite: g++.dg: fix PR112938 filename

2025-03-26 Thread Sam James
The test was being ignored because dg.exp looks for .C in g++.dg/. gcc/testsuite/ChangeLog: PR middle-end/112938 * g++.dg/strub-internal-pr112938.cc: Move to... * g++.dg/strub-internal-pr112938.C: ...here. --- .../{strub-internal-pr112938.cc => strub-internal-pr112938.C}

[PATCH] testsuite: fixup tree scan syntax for strub-internal-pr112938.C

2025-03-26 Thread Sam James
This wasn't being run before my r15-8949-g6b21f7969241cf so went unnoticed. Match [0-9+] instead of [0-9][0-9] and escape the parentheses around 'D'. gcc/testsuite/ChangeLog: PR testsuite/119489 * g++.dg/strub-internal-pr112938.C: Adjust pattern. --- Pushed as obvious. gcc/test

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > On Wed, 2025-03-26 at 19:59 +0100, Jakub Jelinek wrote: >> On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote: >> >> Thanks for working on this. >> My python is very limited, so just adding some comments rather >> than doing patch review. >> >> > +COMMON_MISSP

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > This patch adds a new dg-lint subdirectory below contrib, containing > a "dg-lint" script for detecting common mistakes made in our DejaGnu > tests. > > Specifically, DejaGnu's dg.exp's dg-get-options has a regexp for > detecting dg- directives > https://git.savannah.gnu

[PATCH 3/4] testsuite: g++.dg: vect: fix PR37143 filename

2025-03-26 Thread Sam James
The test was being ignored because vect.exp looks for .cc in g++.dg/vect/. gcc/testsuite/ChangeLog: PR tree-optimization/37143 * g++.dg/vect/pr37143.C: Move to... * g++.dg/vect/pr37143.cc: ...here. --- gcc/testsuite/g++.dg/vect/{pr37143.C => pr37143.cc} | 0 1 file change

Re: [PATCH] testsuite: add testcase for recent alias fix

2025-03-26 Thread Sam James
Martin Jambor writes: > Hi, > > On Tue, Mar 25 2025, Sam James wrote: >> r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs >> but there wasn't a testcase available at the time. Now there is. >> >> Thanks to Andrew for the testcase. >

[PATCH 4/6] testsuite: fix dg-message typos

2025-03-26 Thread Sam James
gcc/testsuite/ChangeLog: * g++.dg/diagnostic/unclosed-extern-c.C: Fix 'dg-message' typo. * g++.dg/warn/Wno-attributes-1.C: Ditto. --- gcc/testsuite/g++.dg/diagnostic/unclosed-extern-c.C | 2 +- gcc/testsuite/g++.dg/warn/Wno-attributes-1.C| 6 +++--- 2 files changed, 4 inse

Re: [PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-27 Thread Sam James
Marek Polacek writes: > On Thu, Mar 27, 2025 at 12:38:55AM +0000, Sam James wrote: >> A handful of cosmetic ones in here but most meant the directive wasn't >> doing anything. > > This patch breaks g++.dg/template/explicit-args6.C for me. See PR119490. I can XFAIL i

Re: [PATCH 1/3] testsuite: harmless dg-* whitespace fixes

2025-03-27 Thread Sam James
Harald Anlauf writes: > Sam, > > who approved the fortran testsuite changes? We've been doing them as obvious by consensus since last year. I'm sorry for the error. > > Am 27.03.25 um 14:28 schrieb Sam James: >> These just fix inconsistent/unusual style to avoid

[PATCH] testsuite: aarch64: fix another unbalanced }

2025-03-27 Thread Sam James
In r15-8956-ge90d6c2639c392, I missed one, so while it did fix a problem, it also exposed another because the braces were now unbalanced. There's IMO more to do here with ideally whitespace before the } when using scan-assembler-times but let's do that later. gcc/testsuite/ChangeLog: * g

[PATCH] testsuite: revert Fortran change

2025-03-27 Thread Sam James
Revert part of my change from r15-8973-g1307de1b4e7d5e; as Harald points out, the comment explains why this is there. It's a hack but it needs to stay for now. (I did have this marked as a TODO in my branch and didn't leave a proper note as to why, so it's my fault.) gcc/testsuite/ChangeLog:

Re: [PATCH 12/12] testsuite, s390: fix broken dg directives

2025-03-28 Thread Sam James
David Malcolm writes: > Found by dg-lint. > > gcc/testsuite/ChangeLog: > * gcc.target/s390/target-attribute/tattr-1.c: Fix missing trailing > close brace on dg-do directive. > * gcc.target/s390/target-attribute/tattr-2.c: Likewise. I've cherry-picked the remaining ones and reso

Re: [PATCH] doc: document incremental LTO flags

2025-03-27 Thread Sam James
Michal Jires writes: > This adds missing documentation for LTO flags. > > Ok? > > gcc/ChangeLog: > > * doc/invoke.texi: (Optimize Options): > Add incremental LTO flags. > --- > gcc/doc/invoke.texi | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > >

Re: [PATCH] Makefile.tpl: Implement per-stage GDCFLAGS [PR116975]

2025-04-10 Thread Sam James
Iain Buclaw writes: > Hi, > > This patch implements STAGE1_GDCFLAGS and others to the configure > machinery, allowing the GDCFLAGS for each bootstrap stage of building > gdc to be overriden, as is the case with CXXFLAGS for other front-ends. > > This is limited to just the generation of recipes f

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Sam James
Christophe Lyon writes: > Le dim. 30 mars 2025, 22:10, Sam James a écrit : > > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-

Re: [PATCH] contrib: Wrap git repo access in gcc-changelog.

2025-03-15 Thread Sam James
"Robin Dapp" writes: > Hi, > > since updating to Fedora 41 I have been seeing ignored python exceptions > like the following when using 'git gcc-verify' = > contrib/gcc_changelog/git_check_commit.py. > > Checking 90fcc1f4f1a5537e8d30628895a07cbb2e7e16ff: OK > Exception ignored in: > Traceback (

Re: [PATCH] c++: Fix various Wnarrowing minor issues

2025-04-11 Thread Sam James
Vishnu Mohandas writes: > Hello, > This is a possible fix for Wnarrowing warning issues. > Bootstrapped on x86_64 Linux. Please see my remarks at https://inbox.sourceware.org/gcc-patches/87iknbzfw4@gentoo.org/.

Re: [PATCH] Add COBOL information to gcc.gnu.org index.html

2025-04-17 Thread Sam James
Robert Dubner writes: > Okay for htdocs/master? > > From d412e45d5afeecded3c8cf1b6b2865e088a480cc Mon Sep 17 00:00:00 2001 > From: Robert Dubner > Date: Thu, 17 Apr 2025 15:12:26 -0400 > Subject: [PATCH] Add COBOL information to gcc.gnu.org index.html > > * htdocs/index.html: Add COBOL inf

Re: [r15-9427 Regression] FAIL: gcc.dg/ipa/pr119530.c execution test on Linux/x86_64

2025-04-14 Thread Sam James
"haochen.jiang" writes: > On Linux/x86_64, > > de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 is the first bad commit > commit de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 > Author: Martin Jambor > Date: Mon Apr 14 14:21:15 2025 +0200 > > ipa-cp: Make propagation of bits in IPA-CP aware of type conv

Re: [PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 10:41:52AM +0000, Sam James wrote: >> Include the term used in the standard to ease further research for users. >> >> gcc/ChangeLog: >> >> * doc/invoke.texi: Use "compatible types" term. >> --

[PATCH v2] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Include the term used in the standard to ease further research for users, and while at it, rephrase the description of the rule entirely using Alexander Monakov's suggestion: it was previously wrong (and imprecise) as "the same address" may well be re-used later on, and the issue is the access via

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-22 Thread Sam James
Jakub Jelinek writes: > On Mon, Apr 21, 2025 at 10:52:22AM +0200, Richard Biener wrote: >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> > >> > On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >> > > That's one option, but maybe it's better the other way round: instead of >

Re: [PATCH] sanitizer: Store no_sanitize attribute value in uint32 instead of unsigned

2025-04-22 Thread Sam James
Kees Cook writes: > On Thu, Apr 10, 2025 at 05:17:51PM -0700, Keith Packard wrote: >> A target using 16-bit ints won't have enough bits to hold the whole >> flag_sanitize set. Be explicit about using uint32 for the attribute data. >> >> Signed-off-by: Keith Packard >> --- >> gcc/c-family/c-att

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-22 Thread Sam James
Jakub Jelinek writes: > On Mon, Apr 21, 2025 at 10:16:39AM +0100, Sam James wrote: >> Sam James writes: >> >> > Richard Biener writes: >> > >> >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> >>> >> >>> O

Re: [PATCH 1/2] DSE: Support triming of some more memset [PR87901]

2025-04-17 Thread Sam James
Andrew Pinski writes: > DSE has support for trimming memset (and memset like) statements. > In this case we have `MEM [(char * {ref-all})&z] = {};` in > the IR and when we go to trim it, we call build_fold_addr_expr which leaves > around This looks cut off?

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Sam James
Philipp Tomsich writes: > Applied to trunk (16.0.0), thank you! > Should this be backported to the GCC-15 release branch as well? BTW, what's the plan for enabling this on trunk now by default? (I don't recall if some other issues were left.)

[PATCH] libphobos: enable for sparc64-unknown-linux-gnu

2025-04-19 Thread Sam James
This bootstraps with some test failures but works well enough to build 11..15. libphobos/ChangeLog: * configure.tgt: Add sparc64-unknown-linux-gnu as a supported target. --- As discussed on IRC. OK? I'd like to backport it to branches in due course once they're all open and some time on t

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-19 Thread Sam James
Robert Dubner writes: >> -Original Message- >> From: Jakub Jelinek >> Sent: Friday, April 18, 2025 14:10 >> To: Rainer Orth >> Cc: Richard Biener ; Andreas Schwab >> ; gcc-patches@gcc.gnu.org; Robert Dubner >> ; James K. Lowden >> Subject: Re: [PATCH] cobol: Allow for undefined NAME_MA

Re: [PATCH v2] gcc: do not apply store motion on loop with no exits.

2025-04-27 Thread Sam James
ywgrit writes: > I encountered one problem with loop-im pass. > I compiled the program dhry2reg which belongs to > unixbench(https://github.com/kdlucas/byte-unixbench). > > The gcc used > gcc (GCC) 12.3.0 > > The commands executed as following > make > ./Run -c -i 1 dhry2reg > > The results are

Re: [PATCH 30/61] MSA: Make MSA and microMIPS R5 unsupported

2025-04-27 Thread Sam James
Xi Ruoyao writes: > On Wed, 2025-04-23 at 12:43 +, Aleksandar Rakic wrote: >> From 16b3207aed5e4846fde4f3ffa1253c65ef6ba056 Mon Sep 17 00:00:00 2001 >> From: Aleksandar Rakic >> Date: Wed, 23 Apr 2025 14:14:17 +0200 >> Subject: [PATCH] Make MSA and microMIPS R5 unsupported >> >> There are n

[COMMITTED htdocs] gcc-3.2/changes: fix 'several' typo

2025-04-10 Thread Sam James
--- Pushed. htdocs/gcc-3.2/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-3.2/changes.html b/htdocs/gcc-3.2/changes.html index 7b9ea63f..4ab9fdce 100644 --- a/htdocs/gcc-3.2/changes.html +++ b/htdocs/gcc-3.2/changes.html @@ -59,7 +59,7 @@ C++ -

Re: [PATCH] Improve [-W..] display for -Wformat

2025-04-10 Thread Sam James
Vishnu Mohandas writes: > Hello, Hi, > The patch below proposes a possible improvement for the issue mentioned in > bug 65445. Although I'm not certain that it > address all the concerns, it does seem to make it better.> Unfortunately, I see a few issues here. There needs to be a ChangeLog en

[PATCH] ltmain.in: don't suppress output for PIC compilations

2025-04-14 Thread Sam James
When working on xz, I set `-Werror=suggest-attribute=returns_nonnull`, and the build failed (as I expected it to), but with no visible error from the compiler. There's a mysterious '>/dev/null 2>&1' on the second line where liblzma_la-common.o is built without PIC. With -fPIC, IPA doesn't end up d

Re: [PATCH] PR tree-optimization/119712 - Always reflect lower bits from mask in subranges.

2025-04-16 Thread Sam James
Andrew MacLeod writes: > This was a fun one!   An actual bug, and it took a while to sort out.  > After chasing down some red herrings, this turns out to be an issue of > interaction between the range and value masks and intervening > calculations. (Just want to say thanks for the detailed commi

Re: [PATCH] i386: Implement Thread Local Storage on Windows

2025-05-06 Thread Sam James
Julian Waters writes: > gcc bootstrap works on my end pretty well, but you know what they say, > no one likes an "It works on my device" developer :) The reason he asked is https://gcc.gnu.org/contribute.html#patches (it's convention to state how you tested it & on what platforms) and whether th

Re: [PATCH v4] libstdc++: Implement C++26 features (P2546R5)

2025-05-05 Thread Sam James
Jonathan Wakely writes: > [...] > +void > +std::breakpoint() noexcept > +{ > + PROBE(std::breakpoint); > + > + if (__gnu_cxx::debugger_signal_for_breakpoint > 0) > +std::raise(__gnu_cxx::debugger_signal_for_breakpoint); > + glib's https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gbackt

[committed htdocs v2] bugs: improve "ABI changes" subsection

2025-05-01 Thread Sam James
C++ ABI for C++ standards with full support by GCC (rather than those marked as experimental per https://gcc.gnu.org/projects/cxx-status.html) should be stable. It's certainly not the case in 2025 that one needs a full world rebuild for C++ libraries using e.g. the default standard or any other sup

Re: [PATCH] libphobos: enable for sparc64-unknown-linux-gnu

2025-05-05 Thread Sam James
Iain Buclaw writes: > Excerpts from Sam James's message of April 20, 2025 2:46 am: >> This bootstraps with some test failures but works well enough to build >> 11..15. >> >> libphobos/ChangeLog: >> >> * configure.tgt: Add sparc64-unknown-linux-gnu as a supported target. >> --- >> As discus

Re: [PATCH] debug/78685 - reword -Og documentation

2025-04-28 Thread Sam James
Richard Biener writes: > On Mon, 28 Apr 2025, Alexander Monakov wrote: > >> >> On Mon, 28 Apr 2025, Richard Biener wrote: >> >> > The following rewords the documentation for -Og which over-promises >> > the ability to debug the generated code. While -Og enables >> > var-tracking and thus impro

Re: [PATCH 2/3] Flip default to LRA for targets with -mlra

2025-05-02 Thread Sam James
Richard Biener writes: > This flips the default to LRA for targets with an -mlra option not > using Mask(..). Please tag PR113934 for avr, PR113939 for m68k, PR113933 for pa, and PR55212 for sh.

Re: [PATCH 1/3] Force targets to use LRA which opted out via hook_bool_void_false

2025-05-02 Thread Sam James
Richard Biener writes: > * config/alpha/alpha.cc (TARGET_LRA_P): Remove define. > * config/bfin/bfin.cc (TARGET_LRA_P): Likewise. > * config/c6x/c6x.cc (TARGET_LRA_P): Likewise. > * config/fr30/fr30.cc (TARGET_LRA_P): Likewise. > * config/frv/frv.cc (TARGET_LRA_P): L

Re: [PATCH 0/3][RFC] Remove TARGET_LRA_P hook

2025-05-03 Thread Sam James
John Paul Adrian Glaubitz writes: > Hello, > > > > >> This mini-series removes the TARGET_LRA_P hook, forcing all targets >> to use LRA. I have not touched the targets that define -mlra >> in terms of a 'Target Mask(XXX)' since IIRC there's no way to >> "default" that. I'd expect those to wrong

Re: Update GCC16 to use libffi 3.4.8

2025-05-03 Thread Sam James
Simon Sobisch writes: > As GCC15 is now strict on dynamic function as > int *func() > to mean exactly zero arguments via its default -std=gnu23, I'm looking > into a dynamic option that would work for C23 and recognized libffi > being built as part of GCC and being part of its source tree, wh

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-21 Thread Sam James
Richard Biener writes: > On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> >> On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >> > That's one option, but maybe it's better the other way round: instead of >> > excluding known-bad targets, restrict cobol to known-good ones >> >

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-21 Thread Sam James
Sam James writes: > Richard Biener writes: > >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >>> >>> On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >>> > That's one option, but maybe it's better the other way round: in

<    1   2   3   4   5   >