Jakub Jelinek <ja...@redhat.com> writes: > On Mon, Apr 21, 2025 at 10:52:22AM +0200, Richard Biener wrote: >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek <ja...@redhat.com> wrote: >> > >> > On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >> > > That's one option, but maybe it's better the other way round: instead of >> > > excluding known-bad targets, restrict cobol to known-good ones >> > > (i.e. x86_64-*-linux* and aarch64-*-linux*) instead. >> > > >> > > I've been using the following for this (should be retested for safety). >> > >> > I admit I don't really know what works and what doesn't out of the box now, >> > but your patch looks reasonable to me for 15 branch. >> > >> > Richard, Robert and/or James, do you agree? >> >> I agree to restrict =all to enable cobol only for known-good platform >> triples. >> But IIRC that's what libgcobol configure.tgt does - IIRC intent was to allow > > But libgcobol configure.tgt does it only for the target case. > Much more important right now is the host whitelist case. > The code in the FE is still not sufficiently portable and so even > i686-solaris -> x86_64-linux --enable-languages=all cross just won't build out > of the box (and even if it would, it wouldn't work properly). > Or x86_64-freebsd -> x86_64-linux might not either. > > So, I think we want Rainer's patch here. >
I thought about it further after discussion on IRC and I agree. Rainer's looks good. >> a cobol build with explicit 'cobol' included even when configure.tgt claims >> unsupported? So why's *-*solaris now included in =all? >> >> I'm a bit confused, I thought we had =all restricted already. > >> > > 2025-03-17 Rainer Orth <r...@cebitec.uni-bielefeld.de> >> > > >> > > PR cobol/119217 >> > > * configure.ac: Restrict cobol to aarch64-*-linux*, >> > > x86_64-*-linux*. >> > > * configure: Regenerate. > > Jakub