Re: [match-and-simplify] reject expanding operator-list to implicit 'for'

2015-05-20 Thread Prathamesh Kulkarni
On 20 May 2015 at 18:18, Richard Biener wrote: > On Wed, 20 May 2015, Prathamesh Kulkarni wrote: > >> On 20 May 2015 at 17:01, Richard Biener wrote: >> > On Wed, 20 May 2015, Prathamesh Kulkarni wrote: >> > >> >> On 20 May 2015 at 16:17, Prathamesh Kulka

Re: [match-and-simplify] reject expanding operator-list to implicit 'for'

2015-05-23 Thread Prathamesh Kulkarni
On 20 May 2015 at 17:39, Prathamesh Kulkarni wrote: > On 20 May 2015 at 17:01, Richard Biener wrote: >> On Wed, 20 May 2015, Prathamesh Kulkarni wrote: >> >>> On 20 May 2015 at 16:17, Prathamesh Kulkarni >>> wrote: >>> > Hi, >>> > Th

[C patch] PR49551

2015-05-31 Thread Prathamesh Kulkarni
e/gcc.dg/pr49551.c new file mode 100644 index 000..204f06d --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr49551.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-options "-O -fdata-sections" } */ + +int x = 1; +int x; + +/* { dg-final { scan-assembler-not {comm[\t ]+x} } } */ 2015-05-3

Re: [C PATCH] warn for empty struct -Wc++-compat

2015-06-02 Thread Prathamesh Kulkarni
On Sat, Nov 15, 2014 at 3:56 AM, Prathamesh Kulkarni wrote: > On Sat, Nov 15, 2014 at 3:06 AM, Joseph Myers wrote: >> On Wed, 12 Nov 2014, Prathamesh Kulkarni wrote: >> >>> Is this version okay ? >>> [gcc/c] >>> * c-decl.c (warn_cxx_compat_finish_str

[C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
Since cxx_dialect is not cxx98 and ok is false, it returns false. The attached patch fixes the ICE, by setting "ok = true" if warn_narrowing is enabled thereby returning "true" to convert_like_real(). Booststrapped and tested on x86_64-unknown-linux-gnu with no regressions. OK

Re: [C++ patch] PR 65858

2015-04-30 Thread Prathamesh Kulkarni
On 1 May 2015 at 01:12, Paolo Carlini wrote: > Hi again, > > On 04/30/2015 08:45 PM, Paolo Carlini wrote: >> >> .. also, your patch doesn't seem to fix the case of -w instead of That could be fixed as follows: if (!warn_narrowing || inhibit_warnings) ok = true; else // pedwarn >> -Wno-narrowin

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-14 Thread Prathamesh Kulkarni
On Sat, Nov 15, 2014 at 3:06 AM, Joseph Myers wrote: > On Wed, 12 Nov 2014, Prathamesh Kulkarni wrote: > >> Is this version okay ? >> [gcc/c] >> * c-decl.c (warn_cxx_compat_finish_struct): New parameters code, >> record_loc. >> Warn for empty

[C PATCH] Fix PR44257

2015-06-19 Thread Prathamesh Kulkarni
for trunk if testing passes ? Thank you, Prathamesh 2015-06-19 Prathamesh Kulkarni PR c/44257 * c-typeck.c (build_indirect_ref): Add check !in_typeof before reporting incomplete type error. * gcc.dg/pr44257: New test-case. diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c

fix segfault in verify_flow_info() with -dx option

2015-07-05 Thread Prathamesh Kulkarni
not trip on that. */ if ((cfun->curr_properties & PROP_cfg) - && !from_ipa_pass) + && !from_ipa_pass + && cfun->cfg) verify_flow_info (); if (current_loops && loops_state_sati

flatten cfgloop.h

2015-07-05 Thread Prathamesh Kulkarni
using config-list.mk. I left includes in cfgloop.h commented with #if 0 ... #endif. OK for trunk ? Thank you, Prathamesh 2015-07-05 Prathamesh Kulkarni * loop-invariant.h: New header file. * loop-init.h: Likewise. * loop-doloop.h: Likewise. * cfgloopanal.h

move a * (1 << b) -> a << b pattern from fold-const.c to match.pd

2015-07-06 Thread Prathamesh Kulkarni
Hi, The attached patch moves pattern a * (1 << b) -> a << b. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. OK for trunk if testing passes ? Thank you, Prathamesh 2015-07-06 Prathamesh Kulkarni * fold-const.c (fold_binary_loc): Remove pattern a * 1

Re: fix segfault in verify_flow_info() with -dx option

2015-07-06 Thread Prathamesh Kulkarni
On 6 July 2015 at 12:00, Richard Biener wrote: > On Sun, Jul 5, 2015 at 2:07 PM, Prathamesh Kulkarni > wrote: >> Hi, >> Passing -dx causes segmentation fault: >> Test case: void f(void) {} >> >> ./test.c: In function 'f': >> ../tes

Re: flatten expr.h (version 2)

2015-01-15 Thread Prathamesh Kulkarni
On 14 January 2015 at 12:14, Richard Biener wrote: > On Wed, 14 Jan 2015, Prathamesh Kulkarni wrote: > >> On 14 January 2015 at 17:31, Richard Biener wrote: >> > On Wed, 14 Jan 2015, Prathamesh Kulkarni wrote: >> > >> >> On 14 January 2015 at 11:16, Pr

Re: [Patch] Missing plugin header files

2015-01-15 Thread Prathamesh Kulkarni
On 15 January 2015 at 14:14, Richard Biener wrote: > On Wed, Jan 14, 2015 at 10:43 PM, Steve Ellcey wrote: >> I tried compiling an empty plugin that just included gcc-plugin.h and >> plugin-version.h and found that these header files were included from >> gcc-plugin.h but not in the list of heade

Re: [Patch] Missing plugin header files

2015-01-15 Thread Prathamesh Kulkarni
On 16 January 2015 at 00:00, Steve Ellcey wrote: > >> >> >> >> 2015-01-14 Steve Ellcey >> >> >> >> * Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h, >> >> cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def, >> >> chkp-builtins.def, and pass-instance

[PATCH, committed] remove duplicate contents explow.h, dojump.h

2015-01-15 Thread Prathamesh Kulkarni
r219655 added two files explow.h, dojump.h with duplicated contents, silly mistake from my side. The attached patch removes duplicate contents. Committed (r219680) as obvious. Thanks, Prathamesh 2015-01-15 Prathamesh Kulkarni * explow.h: Remove duplicate contents. * dojump.h

Re: [match-and-simplify] Remove printing "for expression"

2015-01-16 Thread Prathamesh Kulkarni
On 12 January 2015 at 08:46, Richard Biener wrote: > On Sat, 10 Jan 2015, Prathamesh Kulkarni wrote: > >> On 8 January 2015 at 17:52, Richard Biener wrote: >> > On Sun, 21 Dec 2014, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> I removed

[PATCH] add includes in config/tilepro/mul-tables.c and config/tilegx/mul-tables.c

2015-01-19 Thread Prathamesh Kulkarni
ed similar to a doc-fix ? OK to commit ? Thanks, Prathamesh 2015-01-20 Prathamesh Kulkarni * config/tilegx/mul-tables.c: Move symtab.h include after coretypes.h include. * config/tilepro/mul-tables.c: Add includes hashtab.h, hash-set.h, vec.h, machmode.h, tm.h, hard

Re: flatten expr.h (version 2)

2015-01-22 Thread Prathamesh Kulkarni
ess. Assuming it goes fine, OK to commit ? Thanks, Prathamesh > > -- > Eric Botcazou 2015-01-22 Prathamesh Kulkarni * emit-rtl.h (store_bit_field): Move prototype to expmed.h. (extract_bit_field): Likewise. (extract_low_bits): Likewise. (expand_mult): Like

Re: [PATCH v2] libgcc: Use braces instead of macro's empty body to avoid xgcc warnings.

2015-01-31 Thread Prathamesh Kulkarni
On 31 January 2015 at 15:30, Chen Gang S wrote: > On 1/31/15 16:53, Andreas Schwab wrote: >> Chen Gang S writes: >> >>> * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Use braces >>> instead of macro's empty body to avoid xgcc warnings. The ChangeLog entry should be fixed to reflect it

Re: [match-and-simplify] error checking on user defined oper in for

2014-10-28 Thread Prathamesh Kulkarni
On Tue, Oct 28, 2014 at 3:45 PM, Richard Biener wrote: > On Sat, Oct 25, 2014 at 8:16 PM, Prathamesh Kulkarni > wrote: >> Currently this is accepted: >> (for plus (mult div) >> ...) >> which is incorrect. This patch puts more error-checks on the user-defi

Re: [match-and-simplify] reject conditional convert and commutative ops in result operand

2014-10-28 Thread Prathamesh Kulkarni
On Tue, Oct 28, 2014 at 3:50 PM, Richard Biener wrote: > On Mon, Oct 27, 2014 at 3:32 PM, Prathamesh Kulkarni > wrote: >> I suppose we should reject conditional convert and commutative ops in >> result operand ? since it would create 1-n mapping from match -> >> resu

[match-and-simplify] fix segfault in parser::parse_for

2014-10-29 Thread Prathamesh Kulkarni
genmatch segfaults if user-defined operator is not specified. eg: (for (oper1 oper2...) pattern) * genmatch.c (parser::parse_for): Call peek instead of peek_ident. Thanks, Prathamesh Index: genmatch.c === --- genmatch.c (revisio

[match-and-simplify] support operator list

2014-11-03 Thread Prathamesh Kulkarni
(had sent it earlier by private mail). The attached patch supports operator-list and it's use in for. For now, operator-list is rejected in expression. This patch also allows user-defined operator to be used as operator-list (user-defined ops are really temporary or "scoped" operator-lists). (for

[match-and-simplify] operator-lists in expression

2014-11-10 Thread Prathamesh Kulkarni
Hi, This patch adds support for operator-lists to be used in expression. I reuse operator-list as the iterator. This is not really valid since user-defined operator-lists cannot be iterator in 'for', but it was convenient to reuse operator-list as a 'for' iterator and lower_for doesn't care abou

[C PATCH] warn for empty struct -Wc++-compat

2014-11-10 Thread Prathamesh Kulkarni
Hi, For the following test-case: struct A {}; clang -fsyntax-only -Wc++-compat gives following warning and gcc does not: empty-struct.c:1:1: warning: empty struct has size 0 in C, size 1 in C++ [-Wc++-compat] struct F {}; This patch adds the above warning to the C FE. Bootstrapped on x86_64-unkn

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-10 Thread Prathamesh Kulkarni
On Tue, Nov 11, 2014 at 3:35 AM, Marek Polacek wrote: > On Tue, Nov 11, 2014 at 03:24:48AM +0530, Prathamesh Kulkarni wrote: >> * gcc/c/c-decl.c >> (warn_cxx_compat_finish_struct): Add new parameter of type location_t. >> Warn for empty struct. >> (

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-11 Thread Prathamesh Kulkarni
On Tue, Nov 11, 2014 at 4:30 PM, Marek Polacek wrote: > On Tue, Nov 11, 2014 at 04:45:46AM +0530, Prathamesh Kulkarni wrote: >> Index: gcc/c/c-decl.c >> === >> --- gcc/c/c-decl.c(revision 217287) >> +++

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-11 Thread Prathamesh Kulkarni
On Wed, Nov 12, 2014 at 1:28 AM, Marek Polacek wrote: > On Tue, Nov 11, 2014 at 11:27:21PM +0530, Prathamesh Kulkarni wrote: >> I tried the following: >> struct A { struct B {}; int x; } /* { dg-warning "empty struct has >> size 0 in C" } */ >>

cse.c typo fix

2019-05-22 Thread Prathamesh Kulkarni
Hi, The attached patch fixes a typo in cse_dump_path, which I came across while debugging another issue. OK to commit ? Thanks, Prathamesh 2019-05-22 Prathamesh Kulkarni * cse.c (cse_dump_path): s/dump_file/f. diff --git a/gcc/cse.c b/gcc/cse.c index 6c9cda16a98..35840a6d5ca 100644

[AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-27 Thread Prathamesh Kulkarni
+test on patch in qemu. Does the patch look OK ? Thanks, Prathamesh 2019-05-27 Prathamesh Kulkarni Richard Sandiford * vector-builder.h (vector_builder::count_dups): New method. * config/aarch64/aarch64-protos.h (aarch64_expand_sve_vector_init): De

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Wed, 29 May 2019 at 18:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to improve initialization for fixed-length > > SVE vector and it's algorithm is described in comments for > > aarch64_sve_expand_vector_

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Thu, 30 May 2019 at 15:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > new file mode 100644 > > index 000..cbfeff4a59c &

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Thu, 30 May 2019 at 21:19, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 30 May 2019 at 15:10, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > diff --git a/gcc/testsuite/gcc.target/aarch64

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Mon, 3 Jun 2019 at 14:53, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 30 May 2019 at 21:19, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Thu, 30 May 2019 at 15:10, Richard Sandiford &g

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Mon, 3 Jun 2019 at 16:25, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > >> > diff --git a/gcc/testsuite/lib/target-supports.exp > >> > b/gcc/testsuite/lib/target-supports.exp > >> > index 3bd6e815715..0ff0d8fb757 100644 > >

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-07 Thread Prathamesh Kulkarni
On Thu, 6 Jun 2019 at 16:54, Richard Sandiford wrote: > > Szabolcs Nagy writes: > > On 03/06/2019 08:26, Prathamesh Kulkarni wrote: > >> +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_8.c > >> @@ -0,0 +1,32 @@ > >> +/* { dg-do assemble { target aarch64_

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-07 Thread Prathamesh Kulkarni
On Fri, 7 Jun 2019 at 18:26, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 6 Jun 2019 at 16:54, Richard Sandiford > > wrote: > >> > >> Szabolcs Nagy writes: > >> > On 03/06/2019 08:26, Prathamesh Kulkarni wrote: > >&g

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-08 Thread Prathamesh Kulkarni
On Fri, 7 Jun 2019 at 22:47, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > 2019-06-07 Prathamesh Kulkarni > > > > * gcc.target/aarch64/sve/init_1.c: Remove options > > -O2 -fno-schedule-insns and instead pass -O. > &g

[SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-21 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR88833. For the following test-case: subroutine foo(x) real :: x(100) x = x + 10 end subroutine foo Assembly with -O3 -march=armv8.2-a+sve: foo_: .LFB0: .cfi_startproc mov w2, 100 mov w3, w2 mov x1, 0 wh

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-24 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 14:59, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/fwprop.c b/gcc/fwprop.c > > index 45703fe5f01..93a1a10c9a6 100644 > > --- a/gcc/fwprop.c > > +++ b/gcc/fwprop.c > > @@ -547,6 +547,54 @@ propagate_rtx_

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-01 Thread Prathamesh Kulkarni
On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni wrote: > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni > wrote: > > > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov > > wrote: > > > > > > Hi Prathamesh > > > > > > On 7/10/

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-07 Thread Prathamesh Kulkarni
On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni wrote: > > On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni > wrote: > > > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkacho

[SVE] PR86753

2019-08-14 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR86753. For following test: void f1 (int *restrict x, int *restrict y, int *restrict z) { for (int i = 0; i < 100; ++i) x[i] = y[i] ? z[i] : 10; } vect dump shows: vect_cst__42 = { 0, ... }; vect_cst__48 = { 0, ... }; vect__4.7_41 = .MASK_LOAD (ve

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-15 Thread Prathamesh Kulkarni
On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni wrote: > > On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni > wrote: > > > > On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni

[SVE] PR88839

2019-08-20 Thread Prathamesh Kulkarni
Hi, The attached patch is a fix for PR88839 ported from sve-acle-branch. OK to commit to trunk ? Thanks, Prathamesh 2019-08-21 Prathamesh Kulkarni Richard Sandiford PR target/88839 * config/aarch64/aarch64.c (aarch64_evpc_sel): New function

Re: [SVE] PR88839

2019-08-21 Thread Prathamesh Kulkarni
On Wed, 21 Aug 2019 at 15:18, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch is a fix for PR88839 ported from sve-acle-branch. > > OK to commit to trunk ? > > > > Thanks, > > Prathamesh > > > > 2

Re: [SVE] PR86753

2019-08-21 Thread Prathamesh Kulkarni
On Thu, 15 Aug 2019 at 01:50, Richard Sandiford wrote: > > Richard Biener writes: > > On Wed, Aug 14, 2019 at 6:49 PM Richard Biener > > wrote: > >> > >> On Wed, Aug 14, 2019 at 5:06 PM Prathamesh Kulkarni > >> wrote: > >> >

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-21 Thread Prathamesh Kulkarni
On Mon, 19 Aug 2019 at 22:14, James Greenhalgh wrote: > > On Thu, Aug 15, 2019 at 02:11:25PM +0100, Prathamesh Kulkarni wrote: > > On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni > >

[SVE] [aarch64] Add "@" in vcond_mask pattern

2019-08-21 Thread Prathamesh Kulkarni
ailure. OK to commit ? Thanks, Prathamesh 2019-08-22 Prathamesh Kulkarni * aarch64-sve.md (vcond_mask): Add "@". diff --git a/gcc/config/aarch64/aarch64-sve.md b/gcc/config/aarch64/aarch64-sve.md index ac65e691d73..f58353e9c6d 100644 --- a/gcc/config/aarch64/aarch64-sve.md +++ b/gcc

Re: [SVE] PR86753

2019-08-23 Thread Prathamesh Kulkarni
On Thu, 22 Aug 2019 at 16:44, Richard Biener wrote: > > On Wed, Aug 21, 2019 at 8:24 PM Prathamesh Kulkarni > wrote: > > > > On Thu, 15 Aug 2019 at 01:50, Richard Sandiford > > wrote: > > > > > > Richard Biener writes: > > > > On W

Re: [SVE] PR86753

2019-08-23 Thread Prathamesh Kulkarni
On Fri, 23 Aug 2019 at 18:15, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 22 Aug 2019 at 16:44, Richard Biener > > wrote: > >> > >> On Wed, Aug 21, 2019 at 8:24 PM Prathamesh Kulkarni > >> wrote: > >> &g

Re: [SVE] PR86753

2019-08-25 Thread Prathamesh Kulkarni
On Fri, 23 Aug 2019 at 19:43, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Fri, 23 Aug 2019 at 18:15, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Thu, 22 Aug 2019 at 16:44, Richard Biener >

Re: [SVE] PR86753

2019-08-26 Thread Prathamesh Kulkarni
On Mon, 26 Aug 2019 at 14:48, Richard Biener wrote: > > On Sun, Aug 25, 2019 at 11:13 PM Prathamesh Kulkarni > wrote: > > > > On Fri, 23 Aug 2019 at 19:43, Richard Sandiford > > wrote: > > > > > > Prathamesh Kulkarni writes: > >

Re: [SVE] PR86753

2019-08-27 Thread Prathamesh Kulkarni
On Tue, 27 Aug 2019 at 17:29, Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Aug 27, 2019 at 11:58 AM Richard Sandiford > > wrote: > >> ifcvt produces: > >> > >>[local count: 1063004407]: > >> # i_34 = PHI > >> # ivtmp_5 = PHI > >> _1 = (long unsigned int) i_34; > >>

Re: [SVE] PR86753

2019-08-27 Thread Prathamesh Kulkarni
On Tue, 27 Aug 2019 at 21:14, Richard Sandiford wrote: > > Richard should have the final say, but some comments... > > Prathamesh Kulkarni writes: > > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c > > index 1e2dfe5d22d..862206b3256 100644 > > --- a/g

PR78736

2019-08-28 Thread Prathamesh Kulkarni
+test on x86_64-unknown-linux-gnu. (Also IIRC, Wall triggered several instances of the warning with allmodconfig kernel build last time). Is the patch OK to commit ? Thanks, Prathamesh 2019-08-29 Prathamesh Kulkarni * doc/invoke.texi: Document -Wenum-conversion. * c-family/c.opt

Re: [SVE] PR86753

2019-08-31 Thread Prathamesh Kulkarni
On Fri, 30 Aug 2019 at 16:15, Richard Biener wrote: > > On Wed, Aug 28, 2019 at 11:02 AM Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > On Tue, 27 Aug 2019 at 21:14, Richard Sandiford > > > wrote: > > >> > >

Re: [2/2] PR 78736: libgomp fallout

2019-09-04 Thread Prathamesh Kulkarni
On Tue, 9 May 2017 at 18:59, Jakub Jelinek wrote: > > On Tue, May 09, 2017 at 06:55:12PM +0530, Prathamesh Kulkarni wrote: > > ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00135.html > > The libgomp patch is ok provided the warning is added. > Though, should it be in -

Re: PR78736

2019-09-04 Thread Prathamesh Kulkarni
On Wed, 4 Sep 2019 at 01:22, Jeff Law wrote: > > On 8/28/19 8:55 PM, Prathamesh Kulkarni wrote: > > Hi, > > This is a rebased patch on trunk for PR78736. The last time, it got > > stuck, because of warning issues with libgfortran, for which I filed > > PR91593. The

Re: [SVE] PR86753

2019-09-05 Thread Prathamesh Kulkarni
On Thu, 5 Sep 2019 at 14:29, Richard Sandiford wrote: > > Sorry for the slow reply. > > Prathamesh Kulkarni writes: > > On Fri, 30 Aug 2019 at 16:15, Richard Biener > > wrote: > >> > >> On Wed, Aug 28, 2019 at 11:02 AM Richard Sandiford > >>

Re: [SVE] PR86753

2019-09-09 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 16:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > With patch, the only following FAIL remains for aarch64-sve.exp: > > FAIL: gcc.target/aarch64/sve/cond_unary_2.c -march=armv8.2-a+sve > > scan-assembler-times \\tmovprfx\\t 6 &

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-09-09 Thread Prathamesh Kulkarni
On Thu, 22 Aug 2019 at 00:05, Prathamesh Kulkarni wrote: > > On Mon, 19 Aug 2019 at 22:14, James Greenhalgh > wrote: > > > > On Thu, Aug 15, 2019 at 02:11:25PM +0100, Prathamesh Kulkarni wrote: > > > On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni > > >

Re: [SVE] PR86753

2019-09-09 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 22:06, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 16:45, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > With patch, the only following FAIL remains for aarch64-sve.exp: > > > FAIL: gcc.target/aarch64/

Re: [SVE] PR86753

2019-09-10 Thread Prathamesh Kulkarni
On Tue, 10 Sep 2019 at 19:05, Matthew Malcomson wrote: > > Resending because I forgot to avoid the disclaimer and hence my email > didn't go to the gcc-patches list. > > > > On 09/09/19 21:55, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 22:06, Prathamesh K

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-14 Thread Prathamesh Kulkarni
On Wed, 11 Sep 2019 at 11:50, Wilco Dijkstra wrote: > > While code hoisting generally improves codesize, it can affect performance > negatively. Benchmarking shows it doesn't help SPEC and negatively affects > embedded benchmarks, so only enable code hoisting with -Os on Arm. > > Bootstrap OK, OK

Re: [SVE] PR86753

2019-09-16 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 09:36, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 16:45, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > With patch, the only following FAIL remains for aarch64-sve.exp: > > > FAIL: gcc.target/aarch64/

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-18 Thread Prathamesh Kulkarni
On Wed, 18 Sep 2019 at 01:46, Richard Biener wrote: > > On Tue, Sep 17, 2019 at 7:18 PM Wilco Dijkstra wrote: > > > > Hi Richard, > > > > > The issue with the bugzilla is that it lacked appropriate testcase(s) and > > > thus > > > it is now a mess. There are clear testcases (maybe not in the be

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-18 Thread Prathamesh Kulkarni
On Wed, 18 Sep 2019 at 22:17, Prathamesh Kulkarni wrote: > > On Wed, 18 Sep 2019 at 01:46, Richard Biener > wrote: > > > > On Tue, Sep 17, 2019 at 7:18 PM Wilco Dijkstra > > wrote: > > > > > > Hi Richard, > > > > > > > Th

[SVE] PR91532

2019-09-19 Thread Prathamesh Kulkarni
Hi, For PR91532, the dead store is trivially deleted if we place dse pass between ifcvt and vect. Would it be OK to add another instance of dse there ? Or should we add an ad-hoc "basic-block dse" sub-pass to ifcvt that will clean up the dead store ? Thanks, Prathamesh

[ARM] Implement division using vrecpe, vrecps

2018-10-25 Thread Prathamesh Kulkarni
which stalled the patch). Bootstrap+tested on arm-linux-gnueabihf. Cross-tested on arm*-*-* variants. OK for trunk ? Thanks, Prathamesh 2018-10-26 Prathamesh Kulkarni * config/arm/neon.md (div3): New pattern. testsuite/ * gcc.target/arm/neon-vect-div-1.c: New

PR83750: CSE erf/erfc pair

2018-11-02 Thread Prathamesh Kulkarni
> 0 which resolves the regression. Bootstrapped+tested on x86_64-unknown-linux-gnu. Cross-testing on arm and aarch64 variants in progress. OK for trunk if passes ? Thanks, Prathamesh 2018-11-02 Prathamesh Kulkarni * match.pd (erfc(x) -> 1 - erf(x)): New pattern. (1 - e

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-02 Thread Prathamesh Kulkarni
On Fri, 26 Oct 2018 at 10:34, Prathamesh Kulkarni wrote: > > Hi, > This is a rebased version of patch that adds a pattern to neon.md for > implementing division with multiplication by reciprocal using > vrecpe/vrecps with -funsafe-math-optimizations excluding -Os. > The newly ad

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-04 Thread Prathamesh Kulkarni
On Fri, 2 Nov 2018 at 19:08, Wilco Dijkstra wrote: > > Prathamesh Kulkarni wrote: > > > This is a rebased version of patch that adds a pattern to neon.md for > > implementing division with multiplication by reciprocal using > > vrecpe/vrecps with -funsafe-math-optimizat

Re: PR83750: CSE erf/erfc pair

2018-11-05 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 15:10, Richard Biener wrote: > > On Fri, Nov 2, 2018 at 10:37 AM Prathamesh Kulkarni > wrote: > > > > Hi, > > This patch adds two transforms to match.pd to CSE erf/erfc pair. > > erfc(x) is canonicalized to 1 - erf(x) and is the

Re: PR83750: CSE erf/erfc pair

2018-11-05 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 18:14, Richard Biener wrote: > > On Mon, Nov 5, 2018 at 1:11 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 5 Nov 2018 at 15:10, Richard Biener > > wrote: > > > > > > On Fri, Nov 2, 2018 at 10:37 AM Prathamesh Kulkarni > &g

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-08 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 19:22, Ramana Radhakrishnan wrote: > > On 26/10/2018 06:04, Prathamesh Kulkarni wrote: > > Hi, > > This is a rebased version of patch that adds a pattern to neon.md for > > implementing division with multiplication by reciprocal using > > vr

Re: PR83750: CSE erf/erfc pair

2018-11-08 Thread Prathamesh Kulkarni
On Tue, 6 Nov 2018 at 16:04, Richard Biener wrote: > > On Mon, Nov 5, 2018 at 3:11 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 5 Nov 2018 at 18:14, Richard Biener > > wrote: > > > > > > On Mon, Nov 5, 2018 at 1:11 PM Prathamesh Kulkarni > &

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-24 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 19:51, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -1415,6 +1460,19 @@ forward_propagate_into (df_ref use) > >if (!def_set) > > return false; > > > > + if (reg_prop_only > > + && !REG_P

Re: [PR 90939] Remove outdated assert in ipcp_bits_lattice::meet_with

2019-06-25 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 22:02, Martin Jambor wrote: > > Hi, > > in August 2016 Prathamesh implemented inter-procedural propagation of > known non-zero bits on integers. In August that same year he then also > added the ability to track it for pointer, replacing separate alignment > tracking. > > H

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-25 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkarni wrote: > > On Mon, 24 Jun 2019 at 19:51, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > @@ -1415,6 +1460,19 @@ forward_propagate_into (df_ref use) > > >if (!def_set) >

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-26 Thread Prathamesh Kulkarni
On Tue, 25 Jun 2019 at 20:05, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkarni > > wrote: > >> > >> On Mon, 24 Jun 2019 at 19:51, Richard Sandiford > >> wrote: > >> > > &g

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-26 Thread Prathamesh Kulkarni
On Wed, 26 Jun 2019 at 16:05, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 25 Jun 2019 at 20:05, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkar

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-02 Thread Prathamesh Kulkarni
On Wed, 26 Jun 2019 at 23:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Wed, 26 Jun 2019 at 16:05, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 25 Jun 2019 at 20:05, Richard Sandiford &g

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-02 Thread Prathamesh Kulkarni
On Tue, 2 Jul 2019 at 16:59, Richard Sandiford wrote: > > Thanks for fixing this. > > Prathamesh Kulkarni writes: > > diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c > > index 89a46a933fa..79bd0cfbd28 100644 > > --- a/gcc/simplify-rtx.c > > +++ b/gcc/si

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-03 Thread Prathamesh Kulkarni
On Tue, 2 Jul 2019 at 18:22, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford > > wrote: > >> > >> Thanks for fixing this. > >> > >> Prathamesh Kulkarni writes: > >> >

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-03 Thread Prathamesh Kulkarni
On Wed, 3 Jul 2019 at 17:06, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 Jul 2019 at 18:22, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford >

PR90723

2019-07-08 Thread Prathamesh Kulkarni
OK to commit ? Thanks, Prathamesh 2019-07-09 Prathamesh Kulkarni PR target/90723 * recog.h (volatile_ok_temp): New class. * config/aarch64/aarch64.c (aarch64_emit_sve_pred_move): Set volatile_ok temporarily to true using volatile_ok_temp. *

PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-10 Thread Prathamesh Kulkarni
dval) satisfies aarch64_plus_operand predicate and if not, forces it to be in register, which resolves ICE. Does it look OK ? Bootstrap+testing in progress on aarch64-linux-gnu. PS: The issue has nothing to do with SVE, which I incorrectly mentioned in bug report. Thanks, Prathamesh 2019-07-10 Prat

Re: PR90723

2019-07-11 Thread Prathamesh Kulkarni
On Thu, 11 Jul 2019 at 01:48, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > For following test-case: > > > > typedef double v4df __attribute__ ((vector_size (32))); > > void foo(v4df); > > > > int > > main () > &

Re: PR90723

2019-07-13 Thread Prathamesh Kulkarni
On Thu, 11 Jul 2019 at 13:39, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -186,6 +186,23 @@ skip_alternative (const char *p) > > /* Nonzero means volatile operands are recognized. */ > > extern int volatile_ok; > > > > +/* RAII class

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-17 Thread Prathamesh Kulkarni
On Wed, 10 Jul 2019 at 16:54, Prathamesh Kulkarni wrote: > > Hi, > For following test-case, > static long long AL[24]; > > int > check_ok (void) > { > return (__sync_bool_compare_and_swap (AL+1, 0x20003ll, 0x1234567890ll)); > } > > Compiling with -O2 -mar

PR91166 - Unfolded ZIPs of constants

2019-07-17 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR91166. Does it look OK ? Bootstrap+test in progress on aarch64-linux-gnu and x86_64-unknown-linux-gnu. Thanks, Prathamesh 2019-07-17 Prathamesh Kulkarni PR middle-end/91166 * match.pd (vec_perm_expr(v, v, mask) -> v): New patt

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-17 Thread Prathamesh Kulkarni
On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov wrote: > > Hi Prathamesh > > On 7/10/19 12:24 PM, Prathamesh Kulkarni wrote: > > Hi, > > For following test-case, > > static long long AL[24]; > > > > int > > check_ok (void) > > { > >

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Fri, 19 Jul 2019 at 18:12, Richard Sandiford wrote: > > Not really my area, but FWIW... > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to fix PR91166. > > Does it look OK ? > > Bootstrap+test in progress on aarch64-linux-g

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Tue, 23 Jul 2019 at 16:36, Richard Biener wrote: > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > On Fri, 19 Jul 2019 at 18:12, Richard Sandiford > > wrote: > > > > > > Not really my area, but FWIW... > > > > > > Prathamesh

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Tue, 23 Jul 2019 at 17:48, Richard Biener wrote: > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > On Tue, 23 Jul 2019 at 16:36, Richard Biener wrote: > > > > > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > > > >

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-24 Thread Prathamesh Kulkarni
On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni wrote: > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov > wrote: > > > > Hi Prathamesh > > > > On 7/10/19 12:24 PM, Prathamesh Kulkarni wrote: > > > Hi, > > > For following test-case, > >

[SVE ACLE] Fix for PR88839

2019-04-06 Thread Prathamesh Kulkarni
Hi, I committed attached patch, which fixes PR88839 to sve-acle-branch after approval from Richard Sandiford offline. Thanks, Prathamesh diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index ec60e972f5f..f8d5270b982 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/confi

Re: [PATCH] Add simplification rule tanh (x) * cosh (x) -> sinh (x)

2019-04-29 Thread Prathamesh Kulkarni
On Tue, 30 Apr 2019 at 02:56, Jeff Law wrote: > > On 1/30/19 7:10 AM, Bárbara de Castro Fernandes wrote: > > This patch simplifies the function tanh (x) * cosh (x) -> sinh (x). > > This rule is derived from the relationship between hyperbolic > > functions. > > > > I ran the tests and gfortran.dg/

<    1   2   3   4   5   6   7   8   9   10   >