Re: Recent Go patch broke Alpha bootstrap

2013-11-07 Thread Ian Lance Taylor
On Thu, Nov 7, 2013 at 2:25 PM, Uros Bizjak wrote: > > Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: > > --cut here-- > Index: runtime/proc.c > === > --- runtime/proc.c (revision 204522) > +++ runtime/pr

Go patch committed: Correct types in type conversion

2013-11-07 Thread Ian Lance Taylor
This patch to the Go frontend fixes the type returned when a type conversion has to make a function call. I have a test case that I will commit to the master testsuite after the Go 1.2 release (the test case is simply "return []byte(s)[0]"). Bootstrapped and ran Go testsuite on x86_64-unknown-lin

Merge from mainline to gccgo branch

2013-11-07 Thread Ian Lance Taylor
I've merged GCC mainline revision 204559 to the gccgo branch. Ian

Go patch committed: Avoid bogus init loop error

2013-11-08 Thread Ian Lance Taylor
Code like this type S struct { F int } var V = S{F: 1} var F = V.F could trigger an incorrect "variable initializer refers to itself" error because the Go frontend would confuse itself into thinking that the "F" in the composite literal was the same as the global variable "F", rather th

Merge from GCC mainline to gccgo branch

2013-11-08 Thread Ian Lance Taylor
I merged GCC mainline revision 204583 to the gcgo branch. Ian

libgo patch committed: Correct flag

2013-11-09 Thread Ian Lance Taylor
In the recent libgo update I used the wrong flag value: FlagNoGC where I should have used FlagNoInvokeGC. This patch fixes the bug. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d956ad070046 libgo/runtime/malloc.goc --- a/libgo/runtime/malloc.g

Merge from mainline to gccgo branch

2013-11-09 Thread Ian Lance Taylor
I've merge GCC mainline revision 204617 to the gccgo branch. Ian

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 8:27 AM, Jakub Jelinek wrote: > On Mon, Nov 11, 2013 at 09:24:27AM -0700, Jeff Law wrote: >> On 11/11/13 02:33, Eric Botcazou wrote: >> >>However, that brings up an couple interesting questions. >> >> >> >>Let's say we find a NULL pointer which reaches a return statement in

Go patch committed: Check for nil pointers when taking address

2013-11-11 Thread Ian Lance Taylor
In Go 1.2 the language was changed slightly to prohibit taking the address of a field in a struct given a nil pointer to the struct (http://golang.org/s/go12nil). This patch by Chris Manghane implements that check in gccgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 9:41 AM, Eric Botcazou wrote: >> But throw what? It is up to the runtimes of -fnon-call-exceptions languages >> to decide if they actually want to throw or do something else in the signal >> handlers, and what exactly to throw. > > Throw nothing per se, __builtin_throw wou

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 10:55 AM, Eric Botcazou wrote: >> Simply trapping doesn't tell you anything about caused the trap. >> There are at least two distinct possibilities: NULL pointer >> dereference and integer division by zero. There should be some way to >> distinguish those two cases. It's

Re: Recent Go patch broke Alpha bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak wrote: > On Fri, Nov 8, 2013 at 12:39 AM, Ian Lance Taylor wrote: > >>> Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: >>> >> Thanks for the patch and report. This patch should fix them. >&g

Re: Recent Go patch broke Alpha bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak wrote: > > panic: runtime error: invalid memory address or nil pointer dereference > [signal 0xb code=0x1 addr=0x1c] > > goroutine 5 [running]: > syscall.Exitsyscall > ../../../gcc-svn/trunk/libgo/runtime/proc.c:1986 > pprof.profileWriter >

Re: Recent Go patch broke Solaris bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 4:01 AM, Rainer Orth wrote: > The recent Go patch (couldn't find the submission on gcc-patches) broke > Solaris bootstrap: on Solaris 10/x86 I get > > /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_unix.go:414:72: error: reference > to undefined identifier 'syscall.F_DUPFD_CL

Re: Recent Go patch broke CentOS 5.10 bootstrap

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 7:08 AM, Uros Bizjak wrote: > > Building latest gcc+go on CentOS 5.10 breaks with following build failure: > > ../../../gcc-svn/trunk/libgo/go/net/fd_unix.go:414:72: error: > reference to undefined identifier ‘syscall.F_DUPFD_CLOEXEC’ >r0, _, e1 := syscall.Syscall(sysca

Re: Recent Go patch broke Solaris bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 4:01 AM, Rainer Orth wrote: > The recent Go patch (couldn't find the submission on gcc-patches) broke > Solaris bootstrap: on Solaris 10/x86 I get > > /vol/gcc/src/hg/trunk/local/libgo/go/net/tcpsockopt_unix.go:26:103: error: > reference to undefined identifier 'syscall.TC

Re: Recent Go patch broke Solaris bootstrap

2013-11-12 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 6:43 AM, Rainer Orth wrote: > > works on Solaris 11, but not on Solaris 9 and 10 which lack > TCP_KEEPALIVE_THRESHOLD. Do they have any facility for changing the keepalive timers? Ian

Re: [PATCH, libiberty]: Add a couple of missing casts

2013-11-12 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 11:24 AM, Uros Bizjak wrote: > > This was uncovered by x86 lto-profiledbootstrap. The patch allows > lto-profiledbootstrap to proceed further. > > 2013-11-12 Uros Bizjak > > * cp-demangle.c (d_copy_templates): Cast result of malloc > to (struct d_print_template *

Re: [gofrontend-dev] Re: libgo patch committed: Implement reflect.MakeFunc for amd64

2013-11-12 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 1:40 PM, H.J. Lu wrote: > > TestMakeFunc failed on x32: > > FAIL: TestMakeFunc (0.00 seconds) > all_test.go:1457: Call returned 10, 20, 30, [40 0], 60, 70, 80; want 10, > 20, 30, [40, 50], 60, 70, 80 > > The difference in x32 is x32 puts 2 pointers (32-bit) in one 64-g

Re: [patch] go front end changes to fix compilation break

2013-11-12 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 12:30 PM, Andrew MacLeod wrote: > > My latest set of changes (which I just checked in as revision204717) to > restructuring the gimple include files breaks go. It requires a minor > change to the go front end in order for it to compile... > > patch attached: Thanks. C

Re: [PATCH, libiberty]: Add a couple of missing casts

2013-11-13 Thread Ian Lance Taylor
On Wed, Nov 13, 2013 at 7:30 AM, Gary Benson wrote: > Richard Biener wrote: >> On Tue, Nov 12, 2013 at 8:55 PM, Ian Lance Taylor wrote: >> > On Tue, Nov 12, 2013 at 11:24 AM, Uros Bizjak wrote: >> > > >> > > This was uncovered by x86 lto-prof

Re: [PATCH][1-3] New configure option to enable Position independent executable as default.

2013-11-13 Thread Ian Lance Taylor
On Wed, Nov 13, 2013 at 3:23 PM, Mike Stump wrote: > On Nov 13, 2013, at 2:28 PM, Magnus Granberg wrote: >> This patchset will add a new configure options --enable-default-pie. > > Ick. Would be nice to figure out on what systems one can do this and just do > it without the configure option. I

Re: [PATCH][1-3] New configure option to enable Position independent executable as default.

2013-11-13 Thread Ian Lance Taylor
On Wed, Nov 13, 2013 at 8:07 PM, Mike Stump wrote: > On Nov 13, 2013, at 5:14 PM, Ian Lance Taylor wrote: >> On Wed, Nov 13, 2013 at 3:23 PM, Mike Stump wrote: >>> On Nov 13, 2013, at 2:28 PM, Magnus Granberg wrote: >>>> This patchset will add a new configur

libgo patch committed: Fix list of supported os's and arch's

2013-11-14 Thread Ian Lance Taylor
This patch from Dave Cheney fixes the list of supported operating systems and architectures in libgo. syslist.go used to be a generated file in the master Go library, but it was changed a while back to a fixed list. This patch makes the same change to libgo. Bootstrapped and ran Go testsuite on

libgo patch committed: Fill in list of gccgo architectures

2013-11-14 Thread Ian Lance Taylor
This patch expands the recent one from Dave Cheney to add all the known gccgo architectures. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 5d4a0b7216b6 libgo/go/go/build/syslist.go --- a/libgo/go/go/build/syslist.go Thu Nov 14 10:07:00 2013 -0

libgo patch committed: Fix flag when allocating cgo memory

2013-11-14 Thread Ian Lance Taylor
This patch to libgo fixes a flag when allocating memory from cgo. I misunderstood the meanings of the flags. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 2544e5a0261f libgo/runtime/malloc.goc --- a/libgo/runtime/malloc.goc Thu Nov 14 10:14:4

Re: Recent Go patch broke Solaris bootstrap

2013-11-14 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 4:01 AM, Rainer Orth wrote: > The recent Go patch (couldn't find the submission on gcc-patches) broke > Solaris bootstrap: on Solaris 10/x86 I get > > /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_select.go:90:30: error: use of > undefined type 'pollServer' > func (p *polls

Re: Recent Go patch broke Solaris bootstrap

2013-11-14 Thread Ian Lance Taylor
On Tue, Nov 12, 2013 at 7:16 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Tue, Nov 12, 2013 at 6:43 AM, Rainer Orth >> wrote: >>> >>> works on Solaris 11, but not on Solaris 9 and 10 which lack >>> TCP_KEEPALIVE_THRESHOLD. >> >

Go patch committed: Use backend interface for comparisons

2013-11-14 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use the backend interface for comparisons. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 8a3737dd11fd go/expressions.cc --- a/go/expressions.cc Thu Nov 14 12:18:10 2013 -0800 +++ b/go/e

libgo patch committed: Don't use filename without '/' for backtrace

2013-11-14 Thread Ian Lance Taylor
This patch changes libgo so that if the executable filename does not have a '/', it does not use that name for the backtrace library. This is the case when an executable is found on PATH. In that case, there is no particular reason to believe that a file with that name in the current directory is

Re: Recent Go patch broke Alpha bootstrap

2013-11-14 Thread Ian Lance Taylor
On Wed, Nov 13, 2013 at 7:25 AM, Uros Bizjak wrote: > On Tue, Nov 12, 2013 at 8:52 AM, Uros Bizjak wrote: > panic: runtime error: invalid memory address or nil pointer dereference [signal 0xb code=0x1 addr=0x1c] >> FAIL: runtime/pprof gmake[2]: *** [runtime/pprof/check] Error

Re: Recent Go patch fails several tests on 32bit CentOS 5.10

2013-11-15 Thread Ian Lance Taylor
On Fri, Nov 15, 2013 at 4:56 AM, Uros Bizjak wrote: >> >> I still see panic in runtime (trace below), segfault in sync, >> database/sql, net/http and abort in sync/atomic on 32bit CentOS 5.10 >> library. The problems on 32-bit are a recently introduced middle-end bug: http://gcc.gnu.org/PR59099 .

Re: Recent Go patch broke Alpha bootstrap

2013-11-15 Thread Ian Lance Taylor
On Fri, Nov 15, 2013 at 4:34 AM, Uros Bizjak wrote: > On Fri, Nov 15, 2013 at 12:35 PM, Uros Bizjak wrote: > >>> panic: runtime error: invalid memory address or nil pointer dereference >>> [signal 0xb code=0x1 addr=0x1c] > >>> FAIL: runtime/pprof >>> gmake[2]: *** [runtime/ppr

Re: [PATCH] Support -fsanitize=leak

2013-11-15 Thread Ian Lance Taylor
On Fri, Nov 15, 2013 at 11:41 AM, Jakub Jelinek wrote: > > This patch adds support for -fsanitize=leak and -static-liblsan options. > If combined with -fsanitize=address, it does nothing, otherwise it links > in liblsan, a new shared+static library (on x86_64-linux only so far, > the code isn't 32

libbacktrace patch RFC: Look up variables in backtrace_syminfo

2013-11-15 Thread Ian Lance Taylor
Ian 2013-11-15 Ian Lance Taylor * backtrace.h (backtrace_syminfo): Update comment and parameter name to take any address, not just a PC value. * elf.c (STT_OBJECT): Define. (elf_nosyms): Rename parameter pc to addr. (elf_symbol_search): Rename local var

Re: libbacktrace patch RFC: Look up variables in backtrace_syminfo

2013-11-16 Thread Ian Lance Taylor
On Fri, Nov 15, 2013 at 1:34 PM, Jakub Jelinek wrote: > On Fri, Nov 15, 2013 at 01:26:54PM -0800, Ian Lance Taylor wrote: >> Jakub asked whether it would be possible to extend backtrace_syminfo to >> work for variables as well as functions. It's a straightforward >>

Re: [PATCH] Fix libbacktrace on prelinked shared libraries

2013-11-18 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 5:11 AM, Jakub Jelinek wrote: > > info->dlpi_addr == 0 is true for executables (but those have also > info->dlpi_name set to ""), but not just for those, it is true also > for successfully prelinked shared libraries or any other libraries that > have been linked at non-zero

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-18 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 5:39 AM, Jakub Jelinek wrote: > > I've kept the possibility to override the symbolizer by magic symbols > (InternalSymbolizer), and as I have no idea how the llvm buildsystem etc. > works and what is the possibility there to add libbacktrace, this just > requires users to c

Re: [PATCH] Fix libbacktrace on prelinked shared libraries

2013-11-18 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 8:46 AM, Jakub Jelinek wrote: > > 2013-11-18 Jakub Jelinek > > * elf.c (SHN_UNDEF): Define. > (elf_initialize_syminfo): Add base_address argument. Ignore symbols > with st_shndx == SHN_UNDEF. Add base_address to address fields. > (elf_ad

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-18 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 9:09 AM, Ian Lance Taylor wrote: > On Mon, Nov 18, 2013 at 5:39 AM, Jakub Jelinek wrote: > >> 3) I wonder if libbacktrace couldn't be updated to use __atomic_* builtins, >>then it could avoid the ugliness to emulate atomic loads and stores. &g

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-18 Thread Ian Lance Taylor
n most targets) faster to use > __atomic_load/__atomic_store, plus you could make it explicit what > is an acquire, what is release semantics, what needs sequentially consistent > atomic etc. And it would be more readable. OK, fair enough. I committed this patch to use the atomic in

libgo patch committed: Fix typo in configure.ac

2013-11-18 Thread Ian Lance Taylor
This patch to libgo/configure.ac fixes a typo. Thanks to Roland McGrath for pointing it out. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 9b8deb2de52b libgo/configure.ac --- a/libgo/configure.ac Fri Nov 15 09:20:05 2013 -0800 +++ b/libgo/con

libgo patch committed: Handle PPC ELF v2 in libgo test script

2013-11-18 Thread Ian Lance Taylor
Ulrich Weigand pointed out that the new PPC ELF v2 ABI does not use function descriptors. The libgo testsuite script had special code to recognize function descriptors in the data section for PPC. This patch lets it also recognize functions in the text section. Bootstrapped and ran Go testsuite

libgo patch committed: Fix handling of FFI with empty struct

2013-11-18 Thread Ian Lance Taylor
This patch from Michael Hudson-Doyle fixes libgo to correctly handle reflect.Call when passing or returning a struct with no fields. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 76b3c32eef84 libgo/go/reflect/all_test.go --- a/libgo/go/reflect/a

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-19 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 11:44 PM, Jakub Jelinek wrote: > On Tue, Nov 19, 2013 at 05:32:12PM +1030, Alan Modra wrote: >> On Tue, Nov 19, 2013 at 06:17:41AM +0100, Hans-Peter Nilsson wrote: >> > In file included from /tmp/x/gcc/libbacktrace/atomic.c:37: >> > /tmp/x/gcc/libbacktrace/internal.h:182: e

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-19 Thread Ian Lance Taylor
On Tue, Nov 19, 2013 at 12:04 AM, Jakub Jelinek wrote: > On Mon, Nov 18, 2013 at 09:09:03AM -0800, Ian Lance Taylor wrote: >> > 2) for tsan querying of data symbols, apparently the classes want to see >> >not just the symbol name and start value, but also size. libback

Please don't commit changes to gcc/go/gofrontend

2013-11-19 Thread Ian Lance Taylor
Hi, as noted in gcc/go/README.gcc, the files in gcc/go/gofrontend are actually mirrored from a different repository. Please do not directly commit changes to those files. Instead, send the changes to me. I will commit them upstream. Thanks. Ian

Go patch committed: Update for mainline changes

2013-11-19 Thread Ian Lance Taylor
This patch to the Go frontend incorporates patches by Richard S and Diego for changes to the middle-end. These patches were already committed to the GCC repository. This change commits them to the master Go repository. Ian diff -r 75537ee240ab go/expressions.cc --- a/go/expressions.cc Mon Nov 1

libgo patch committed: Update for libbacktrace change

2013-11-19 Thread Ian Lance Taylor
This patch to libgo updates the use of the libbacktrace library for the recent addition of a size argument to the syminfo callback. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 923fd178d72b libgo/runtime/go-caller.c --- a/libgo/runtime/go-calle

Re: Please don't commit changes to gcc/go/gofrontend

2013-11-19 Thread Ian Lance Taylor
On Tue, Nov 19, 2013 at 7:08 AM, Diego Novillo wrote: > On Tue, Nov 19, 2013 at 9:48 AM, Ian Lance Taylor wrote: >> Hi, as noted in gcc/go/README.gcc, the files in gcc/go/gofrontend are >> actually mirrored from a different repository. Please do not directly >> commit c

Re: [PATCH, collect2] AIX depth-first shared object initializers

2013-11-20 Thread Ian Lance Taylor
On Wed, Nov 20, 2013 at 4:14 PM, David Edelsohn wrote: > Andrew Dixie and I have been building and using GCC with this feature > for over six months. Are the collect2 changes okay? > > Thanks, David > > > 2013-11-20 David Edelsohn > Andrew Dixie > > libgcc: > > * con

Re: [patch] PR 59195: C++ demangler handles conversion operator incorrectly

2013-11-22 Thread Ian Lance Taylor
On Thu, Nov 21, 2013 at 1:22 PM, Cary Coutant wrote: > I've made a small revision to this patch to handle recursive > invocations of d_expression and d_operator_name, restoring the > previous values of is_expression and is_conversion instead of just > setting them to 0 upon return. I've also added

Re: [patch 1/3] Flatten gimple.h - go front end changes

2013-11-22 Thread Ian Lance Taylor
On Fri, Nov 22, 2013 at 8:02 AM, Andrew MacLeod wrote: > On 11/21/2013 02:31 PM, Jeff Law wrote: >> >> On 11/21/13 11:15, Andrew MacLeod wrote: >>> >>> >>> >>> This bootstraps on x86_64-unknown-linux-gnu, and regressions are >>> currently running. Assuming it passes fine, OK? >> >> patch#1 in the

Re: [PATCH] Use libbacktrace as libsanitizer's symbolizer

2013-11-22 Thread Ian Lance Taylor
On Fri, Nov 22, 2013 at 10:19 AM, Alexey Samsonov wrote: > On Tue, Nov 19, 2013 at 8:42 PM, Jakub Jelinek wrote: >> >> On Tue, Nov 19, 2013 at 04:33:50PM +0100, Jakub Jelinek wrote: >> > I will try. >> >> Ok, here it is (untested though, because libsanitizer in gcc is older and I >> don't have sp

Re: Problems with Go on powerpc64le-linux

2013-11-22 Thread Ian Lance Taylor
On Mon, Nov 18, 2013 at 9:57 AM, Ulrich Weigand wrote: > Ian Lance Taylor wrote on 18.11.2013 18:32:08: >> On Sun, Nov 17, 2013 at 2:00 PM, Ulrich Weigand > wrote: >> > >> > - It seems you've already updated libgo's libtool.m4 to support > powerpc

Re: [RFC][LIBGCC][1 of 2] 64 bit divide implementation for processor without hw divide instruction

2013-11-23 Thread Ian Lance Taylor
Kugan writes: > This RFC patch series implements a simple align divisor shift dividend > method. > > Regression tested on arm-none-linux-gnueabi with no issues. > > OK? > > Thanks, > Kugan > > +2013-11-22 Kugan Vivekanandarajah > + > + * libgcc/libgcc2.c (__udivmoddi4): Define new implemen

Re: [PATCH] pointer to integer conversion.

2013-11-23 Thread Ian Lance Taylor
On Sat, Nov 23, 2013 at 4:38 AM, Iain Buclaw wrote: > > OK, I've checked that document, and there's also a comment with it. > Apparently someone spotted this before. > > @c ??? We've always claimed that pointers were unsigned entities. > @c Shouldn't we therefore be doing zero-extension? If so, t

Go patch committed: Fix representation of calls to interface methods

2013-11-23 Thread Ian Lance Taylor
tical one. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2013-11-23 Ian Lance Taylor * go-gcc.cc (Gcc_backend::function_type): Add result_struct parameter. Index: gcc/go/gofrontend/expressio

libgo patch committed: Only call varargs from C

2013-11-23 Thread Ian Lance Taylor
Reportedly in the new PPC ELF v2 ABI calls to varargs functions act differently from calls to normal functions. The Go compiler can call C functions directly using //extern comments, but it can't represent a C varargs function. Rather than extend the compiler, this patch changes the library so th

Re: wide-int, go

2013-11-23 Thread Ian Lance Taylor
On Sat, Nov 23, 2013 at 11:21 AM, Mike Stump wrote: > Richi has asked the we break the wide-int patch so that the individual port > and front end maintainers can review their parts without have to go through > the entire patch.This patch covers the go front end. This is fine. Go ahead and

Re: [RFC][LIBGCC][1 of 2] 64 bit divide implementation for processor without hw divide instruction

2013-11-26 Thread Ian Lance Taylor
On Mon, Nov 25, 2013 at 4:29 PM, Kugan wrote: > > +2013-11-26 Kugan Vivekanandarajah > + > + * libgcc/libgcc2.c (__udivmoddi4): Define new implementation when > + TARGET_HAS_NO_HW_DIVIDE is defined, for processors without any divide > + instructions. > + > > > +2013-11-26 Kug

libgo patch committed: Fix SizeofSockaddrAny

2013-11-26 Thread Ian Lance Taylor
This patch from Michael Hudson-Doyle fixes the value of SizeofSockaddrAny in the syscall package. I'm not sure where the incorrect value came from. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian diff -r 8f2a489c6452 -r bcd0cf1ac784 libg

Go patch committed: Forward hash/equal to for type defined as type

2013-11-26 Thread Ian Lance Taylor
This patch changes the Go frontend so that if a type is defined in terms of another named type, the hash and equality functions are simply forwarded to that other type. Without this, programs could fail to link if the other named type is defined in some other package and uses unexported types defi

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-06 Thread Ian Lance Taylor
On Mon, Oct 6, 2014 at 12:42 AM, Dominik Vogt wrote: > > On s390[x] the symbol value of a section symbol is definitely not > zero. Is true even in an object file? I agree that in an executable a section symbol will have a non-zero value, but that case doesn't arise since an executable won't have

libgo patch committed: Fix recover.go test for large args, FFI

2014-10-08 Thread Ian Lance Taylor
This patch to libgo fixes PR 60406, in which a problem arises when passing a large argument to a deferred function. The current code generates a thunk that looks like this: if (__go_set_defer_retaddr (&&L)) goto L; deferred_function(args); L: Then the deferred_function calls

Re: [gofrontend-dev] [PATCH 2/9] Gccgo port to s390[x] -- part I

2014-10-09 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:49 AM, Dominik Vogt wrote: > A test case added to golang for the previous patch. > > gcc/testsuite/ChangeLog > 2014-09-05 Dominik Vogt > > * go.test/test/recover.go (test1): Test recover() from deferred > recursive function. Proposed for master testsuit

Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I

2014-10-09 Thread Ian Lance Taylor
On Tue, Oct 7, 2014 at 3:45 AM, Dominik Vogt wrote: > > The only points in that patch are that on one hand - as far as I > know - the Abi does not guarantee that section symbols are either > zero or not relocated, even if that may be the case in reality. > And on the other hand, if that code is ev

Merge from trunk to gccgo branch

2014-10-09 Thread Ian Lance Taylor
I merged trunk revision 216040 to the gccgo branch. Ian

Go patch committed: Accept "for range v"

2014-10-09 Thread Ian Lance Taylor
The Go language was tweaked slightly to permit the variable to be omitted in a range clause, so that one can write "for range v" instead of having to write "for _ = range v". This patch from Chris Manghane implements this in gccgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. C

Re: libffi patch RFA: Pass -Qunused-arguments for asm files

2014-10-10 Thread Ian Lance Taylor
Ping. Adding Paolo as a build machinery maintainer. Thanks. Ian On Mon, Sep 29, 2014 at 5:12 PM, Ian Lance Taylor wrote: > Similar to a recent patch to libgo, this patch to the libffi configure > script checks whether the compiler support -Qunused-arguments. If it > does, it passes

Re: [PATCH 00/13] Go closures, libffi, and the static chain

2014-10-10 Thread Ian Lance Taylor
On Fri, Oct 10, 2014 at 1:42 PM, Richard Henderson wrote: > > So instead I thought about how I'd add some support for Go directly > into libffi. After all, we've got some custom code in libffi for > Java, why couldn't Go have the same treatment? > > The stickler, as far as I could see, is __go_se

Re: [PATCH 03/13] HACK! Allow the static chain to be set from C

2014-10-10 Thread Ian Lance Taylor
On Fri, Oct 10, 2014 at 1:42 PM, Richard Henderson wrote: > > This is awful syntax, and therefore contains no documentation. > But we'll need to be able to set the static chain on a few calls > within the Go runtime, so we need to expose this by some means. > > It currently looks like > >

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker wrote: > >> libiberty/ChangeLog >> 2014-08-05 Iain Buclaw >> >> * Makefile.in (CFILES): Add d-demangle.c. >> (REQUIRED_OFILES): Add d-demangle.o. >> * cplus-dem.c (libiberty_demanglers): Add dlang_demangling case. >> (cplus_demangl

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 10:07 AM, Joel Brobecker wrote: > > libiberty/ChangeLog: > > * d-demangle.c: Replace strtold with strtod in global comment. > (strtold): Remove declaration. > (strtod): New declaration. > (dlang_parse_real): Declare value as double instead of

Re: gccgo testcase: binary testdata for libgo/go/debug/elf/file_test.go

2014-10-15 Thread Ian Lance Taylor
On Wed, Oct 15, 2014 at 1:41 PM, Lynn A. Boger wrote: > > I'm working on a patch submission for gccgo to add the R_PPC64 relocation > definitions to libgo/go/debug/elf/elf.go. Along with this submission I was > going to update the testcase file_test.go from the same directory so it > would test t

Go patch committed: Accept trailing comma after receiver

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to treat a function's receiver as any other parameter list, except that it must contain exactly one parameter. The only effect of this is that a receiver may have a trailing comma after it, as in "func (r,) M()" and also that it may have extra unnecessary parenthe

Go patch committed: Functions that call defer_retaddr not inlinable

2014-10-16 Thread Ian Lance Taylor
It does not work to split functions that call __go_set_defer_retaddr, because those functions are designed to work as a single unit. They always look like this: if (__go_set_defer_retaddr (&&L)) goto L; real_function (real_args); L: The function __go_set_defer_retaddr always return

Go patch committed: Report init cycles in method values

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend to correctly report initialization cycles involving method values. He added a test case for this in the master gc testsuite, which will be copied into the gccgo testsuite in due course. This is http://golang.org/issue/7961 . Bootstrapped and ra

Go patch committed: Don't crash on blank interface

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes a compiler crash when using a blank interface type. This is http://golang.org/issue/8079 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r f0e1f402d71c go/parse.cc --- a/go/parse.cc Thu Oct 16 11:56:29 2014

Go testsuite patch committed: fix test

2014-10-16 Thread Ian Lance Taylor
I forgot to commit this testsuite patch that corresponds to the recent patch for receiver parameters (https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01591.html). Now committed to mainline. Ian Index: test/fixedbugs/bug299.go === ---

Go patch committed: method names must be non-blank

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to say that method names must be non-blank. This patch by Chris Manghane implements this restriction in the Go frontend. This requires a couple of testsuite changes, already in the master testsuite and included in this patch. This fixes http://golang.org/issue/

Re: [gofrontend-dev] [PATCH 6/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:58 AM, Dominik Vogt wrote: > Eases the rediculously tight minimum stack size for goprocesses on > 64 bit systems. > > ChangeLog > 2014-09-05 Dominik Vogt > > * libgo/runtime/proc.c (runtime_newosproc): Set the thread stack size > explicitly only on 32 bi

Re: [gofrontend-dev] [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:02 AM, Dominik Vogt wrote: > This patch extends the -fdump-go-spec option to handle bitfields > and unions and fixes handlinx of zero length arrays. All of this > is necessary for s390[x] since the system headers use these > features. Please check the commit comment for

Re: [gofrontend-dev] [PATCH 8/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:04 AM, Dominik Vogt wrote: > This is an optional extension of the -fgo-dump-spec option to > handle copmplex data types. It is not necessary for s390[x] but > was easy to write on top of the previous patch. > > gcc/ChangeLog > 2014-09-05 Dominik Vogt > > * godu

Re: [gofrontend-dev] [PATCH 9/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:06 AM, Dominik Vogt wrote: > > Quote shell variables that may contain whitespace in the configure > file. I cannot remember exactly whether I actually ran into a > problem, but the patch won't hurt anyway. > > ChangeLog > 2014-09-05 Dominik Vogt > > * libgo/con

Re: [gofrontend-dev] [PATCH 0/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:44 AM, Dominik Vogt wrote: > > The following series' of patches introduce s390[x] support for > Gccgo. For practical reasons they will be submitted in separate > parts. This is the first part of the submissions with > architecture independent bug fixes and enhancements t

Re: [PATCHv4][Kasan] Allow to override Asan shadow offset from command line

2014-10-17 Thread Ian Lance Taylor
Jakub Jelinek writes: > Not sure if there aren't extra steps to make strtoull prototype available > in system.h, libiberty.h etc. for systems that don't have strtoull in their > headers. See the #if defined(HAVE_DECL_XXX) && !HAVE_DECL_XXX lines in include/libiberty.h. Although strtol is miss

Go patch committed: Don't allow dup names in a tuple assignment

2014-10-17 Thread Ian Lance Taylor
The Go frontend was incorrectly accepting duplicate variable names in a tuple assignment, as in "a, a := 0, 0". This is http://golang.org/issue/8436. This patch from Chris Manghane corrects this error. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian d

Re: [PATCHv5][Kasan] Allow to override Asan shadow offset from command line

2014-10-27 Thread Ian Lance Taylor
Yury Gribov writes: > --- a/include/libiberty.h > +++ b/include/libiberty.h > @@ -655,6 +655,33 @@ extern size_t strnlen (const char *, size_t); > extern int strverscmp (const char *, const char *); > #endif > > +#if defined(HAVE_DECL_STRTOL) && !HAVE_DECL_STRTOL > +extern long int strtol (co

Re: Patch for builtins.h restructuring [2/2]

2014-06-02 Thread Ian Lance Taylor
On Mon, Jun 2, 2014 at 8:26 AM, Andrew MacLeod wrote: > > GO changes can now be directly checked in, is that right Ian? To be pedantically clear, it's always been OK to directly in changes to the files in gcc/go, but not to the files in gcc/go/gofrontend. That is still true. What has changed rec

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Ian Lance Taylor
On Thu, Jun 5, 2014 at 3:24 AM, Matthias Klose wrote: > Am 05.06.2014 03:28, schrieb Ian Lance Taylor: >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revisio

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Ian Lance Taylor
On Thu, Jun 5, 2014 at 9:38 AM, Uros Bizjak wrote: > >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revision to merge to because the next revision >> deleted a file that is explicitl

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-06 Thread Ian Lance Taylor
On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revision to merge to b

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: > On 06/04/14 18:28:17, Ian Lance Taylor wrote: >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. > > Based on trunk rev. 211365, we're seeing this warning: >

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
Forgot to CC gofrontend-dev. On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: > On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: >> On 06/04/14 18:28:17, Ian Lance Taylor wrote: >>> I have committed a patch to libgo to merge from revision >>> 18783:00cce3a

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
And I also forgot to attach the patch. Sorry about this. On Mon, Jun 9, 2014 at 5:37 PM, Ian Lance Taylor wrote: > Forgot to CC gofrontend-dev. > > On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: >> On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: >>> On 06/0

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Ian Lance Taylor
On Wed, Jun 11, 2014 at 5:01 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth >> wrote: >>> Ian Lance Taylor writes: >>> >>>> I have committed a patch to libgo to merge from revision >

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Ian Lance Taylor
On Wed, Jun 11, 2014 at 6:57 AM, Rainer Orth wrote: > > Ok, I'll have a look unless some other solution can be found. There are other, less efficient, ways that this could be compiled, but a common symbol seems like the right solution. Basically, every type descriptor now points to a zero value

libgo patch committed: Align stack bottom pointer for GC

2014-06-13 Thread Ian Lance Taylor
This patch to libgo: always sets gcnext_sp to a pointer-aligned address. The gcnext_sp field is only used on systems that do not use split stacks. It marks the bottom of the stack for the garbage collector. This change makes sure that the stack bottom is always aligned to a pointer value. Previo

libgo patch committed: Stop backtrace at recognized functions

2014-06-13 Thread Ian Lance Taylor
This patch to libgo stop a backtrace at a few recognized functions. On x86_64 Solaris the makecontext function does not properly indicate that it is at the top of the stack. Attempting to unwind the stack past a call to makecontext tends to crash. This patch changes libgo to look for certain fun

<    5   6   7   8   9   10   11   12   13   14   >