And I also forgot to attach the patch. Sorry about this.
On Mon, Jun 9, 2014 at 5:37 PM, Ian Lance Taylor <[email protected]> wrote:
> Forgot to CC gofrontend-dev.
>
> On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor <[email protected]> wrote:
>> On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck <[email protected]> wrote:
>>> On 06/04/14 18:28:17, Ian Lance Taylor wrote:
>>>> I have committed a patch to libgo to merge from revision
>>>> 18783:00cce3a34d7e of the master library.
>>>
>>> Based on trunk rev. 211365, we're seeing this warning:
>>>
>>> libgo/runtime/chan.c:484:7: error: ‘received’ may be used uninitialized
>>> in this function [-Werror=maybe-uninitialized]
>>> bool received;
>>> ^
>>
>> Thanks for the report. There is no bug here, the control flow is just
>> too complicated for the compiler to sort out. I don't know why I'm
>> not seeing the warning, but in any case the fix is simple. This patch
>> bootstrapped and tested on x86_64-unknown-linux-gnu. Committed to
>> mainline.
>>
>> Ian
diff -r e632610ff06a libgo/runtime/chan.c
--- a/libgo/runtime/chan.c Fri Jun 06 14:52:01 2014 -0700
+++ b/libgo/runtime/chan.c Mon Jun 09 17:34:47 2014 -0700
@@ -481,7 +481,7 @@
_Bool
runtime_chanrecv2(ChanType *t, Hchan* c, byte* v)
{
- bool received;
+ bool received = false;
chanrecv(t, c, v, true, &received);
return received;
