bootstrap failure for cygwin, mingw targets due recent changes to hash_table

Hi Trevor, your recent commits have broken bootstrap for cygwin/mingw i386 targets with: ../../gcc/gcc/config/i386/winnt.c: In Funktion »unsigned int i386_pe_section_type_flags(tree, const char*, int)«: ../../gcc/gcc/config/i386/winnt.c:503:61: Fehler: keine passende Funktion für Aufruf von »hash

[patch passes.def]: Fix regression on ARM PR/61608

Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz PR rtl-optimization/61608 * passes.def (peephole2): Readd peephole2 pass before if-after-reload pass. Tested for arm*-none

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 16:04 GMT+02:00 Jeff Law : > So why is the peephole not working in its current location? > > Jeff Hi Jeff, that is what I read out of dumps: If peephole2 is executed early we see following pattern transformation: (insn 12 11 13 2 (set (reg:CC_NOOV 100 cc) (compare:CC_NOOV (ze

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 17:50 GMT+02:00 Richard Henderson : > On 06/25/2014 08:28 AM, Jeff Law wrote: >> Ask an ARM maintainer if the new code is actually better than the old code. > > It isn't. > >> It appears that with the peep2 pass moved that we actually if-convert the >> fall-thru path of the conditional a

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 19:15 GMT+02:00 Jeff Law : > On 06/25/14 10:02, Kai Tietz wrote: >> >> 2014-06-25 17:50 GMT+02:00 Richard Henderson : >>> >>> On 06/25/2014 08:28 AM, Jeff Law wrote: >>>> >>>> Ask an ARM maintainer if the new code is act

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 20:12 GMT+02:00 Richard Henderson : > On 06/25/2014 06:35 AM, Kai Tietz wrote: >> Hello, >> >> so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. >> So we need indeed 2 peephole2 passes. > > We don't need a second peepho

Re: [PATCH] remove broken and redundant diagnostic in i386_pe_section_type_flags

Hi Trev, 2014-06-27 1:55 GMT+02:00 : > From: Trevor Saunders > > Hi, > > While fixing up the hash_table patch's bustedness here I noticed the code > doesn't make any sense. What it inserts into the hash table will never match > what we try and look up in it. If you want to use hash_table or ht

[patch c++]: Fix PR 59759

ChangeLog 2015-05-26 Kai Tietz PR c++/59759 * pt.c (unify): Don't ICE on VAR_DECL. Regression tested on x86_64-w64-mingw32. Ok for apply? Regards, Kai Index: pt.c === --- pt.c(Revision 219014) +++ pt.c(Arbeits

Re: C++ delayed folding branch review

2015-04-24 6:22 GMT+02:00 Jason Merrill : >> + expr = fold (expr); >>/* This may happen, because for LHS op= RHS we preevaluate >> RHS and create C_MAYBE_CONST_EXPR >, which >> means we could no longer see the code of the EXPR. */ >>if (TREE_CODE (expr) == C_MAYBE_CONST_EXPR)

Re: C++ delayed folding branch review

2015-04-24 20:25 GMT+02:00 Jason Merrill : > On 04/24/2015 09:46 AM, Kai Tietz wrote: >> >> Sure, we can use here instead *_fully_fold, but for what costs? In >> general we need to deal here a simple one-level fold for simplifying >> constant-values, and/or removi

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 17:10 GMT+01:00 Jason Merrill : > On 11/13/2014 05:47 AM, Paolo Carlini wrote: >> >> shall we do something like the below? > > > Something similar, yes. Though it would also be nice to avoid the redundant > checking in the two functions: we only want to do constexpr folding if we > did

Patch: Some potential warnings for C++ bootstrap

Hello, this patch fixes some potential warnings for C++ bootstrap. I noticed them while working on the delayed folding for C++-FE on boostrap. ChangeLog 2014-11-14 Kai Tietz * dwarf2out.c(output_loc_operands): Make sure that comparison is done on same sign. * varasm.c

Re: Patch: Some potential warnings for C++ bootstrap

2014-11-14 21:45 GMT+01:00 Jason Merrill : > On 11/14/2014 03:41 PM, Kai Tietz wrote: >> >> - gcc_assert (val1->v.val_unsigned == DWARF2_ADDR_SIZE); >> + gcc_assert (val1->v.val_unsigned >> + == (unsigned HOST_WIDE_INT) DWARF2_ADDR_SIZE);

[patch c++]: Fix PR/53904

Hello, this issue fixes a type-overflow issue caused by trying to cast a UHWI via tree_to_shwi. As soon as value gets larger then SHWI_MAX, we get an error for it. So we need to cast it via tree_to_uhwi, and then casting it to the signed variant. ChangeLog 2014-11-20 Kai Tietz PR c

Re: [patch c++]: Fix PR/53904

Ok. Adjusted patch attached. Nevertheless we should use here unsigned HWI instead of possible truncation to signed int. I admit that it is unlikely to have more then 2^31 elements, but well Ok for apply with adjusted ChangeLog? Regards, Kai Index: constexpr.c

Re: [patch c++]: Fix PR/53904

Sorry, missed to add needed hunk to disable pedantic warnings for this testcase. Committed it as obvious fix at rev 218130. Kai

[patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

Hi, this patch turns off ms-extensions for mingw-targets to match diagnostics checked in testcases. Ok for apply? Kai ChangeLog 2014-11-28 Kai Tietz * gcc.dg/anon-struct-1.c: * gcc.dg/anon-struct-11.c: * gcc.dg/anon-struct-2.c: * gcc.dg/c11-anon-struct-2.c: * gcc.dg

[patch testsuite g++]: Fixes for mingw-targets

Hi, this patch fixes for mingw-targets some LP assumptions, adjusts for some testcases that ms-extensions is turned off for diagnostics, and turns on pedantic for some testcase to match expected diagnostics. Ok for apply? Kai ChangeLog 2014-11-28 Kai Tietz * g++.dg/abi/mangle13.C

[patch g++.dg]: Disable some weak-tests for mingw-targets

Hi, this patch skips some test, which are trying to test non-existing weak-variant for mingw-targets. ChangeLog 2014-11-28 Kai Tietz * g++.dg/abi/anon2.C: Skip for mingw targets. * g++.dg/abi/anon3.C: Likewise. * g++.dg/abi/thunk5.C: Likewise. * g++.dg/abi/rtti1.C: Likewise

Re: [patch g++.dg]: Disable some weak-tests for mingw-targets

2014-11-28 12:21 GMT+01:00 Rainer Orth : > Hi Kai, > >> this patch skips some test, which are trying to test non-existing >> weak-variant for mingw-targets. > > why is this necessary when most (all?) of those tests already have > dg-require-weak? If there's some property of weak variables that > P

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 12:14 GMT+01:00 Rainer Orth : > Hi Kai, > >> 2014-11-28 Kai Tietz >> >> * gcc.dg/anon-struct-1.c: >> * gcc.dg/anon-struct-11.c: >> * gcc.dg/anon-struct-2.c: >> * gcc.dg/c11-anon-struct-2.c: >> * gcc.dg/c11-a

Re: [patch testsuite g++]: Fixes for mingw-targets

2014-11-28 12:17 GMT+01:00 Rainer Orth : > Hi Kai, > >> 2014-11-28 Kai Tietz >> >> * g++.dg/abi/mangle13.C: Disable >> ms-extensions for mingw-targets. > > just a nit: why break this line way before 72/80 charackters? Several > more of those us

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 18:53 GMT+01:00 Joseph Myers : > On Fri, 28 Nov 2014, Kai Tietz wrote: > >> Hi, >> >> this patch turns off ms-extensions for mingw-targets to match >> diagnostics checked in testcases. >> >> Ok for apply? > > For the tests using -std= -

Re: [patch testsuite gcc.dg]: Turn of ms-extensions for mingw target

2014-11-28 19:10 GMT+01:00 Joseph Myers : > On Fri, 28 Nov 2014, Kai Tietz wrote: > >> Some diagnostics are different and some constructs getting allowed >> with enabled ms-extensions flag. Additionally is the pedantic-flag >> not automatically set for *-*-mingw* targets.

[patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

Hello, ChangeLog 2015-02-25 Kai Tietz PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow vect_internal_def without reduction to exit graceful. ChagneLog testsuite/ 2015-02-25 Kai Tietz PR tree-optimization/61917 * gcc.dg/vect/vect-pr61917

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-25 11:57 GMT+01:00 Richard Biener : > On Wed, Feb 25, 2015 at 11:06 AM, Kai Tietz wrote: >> Hello, >> >> ChangeLog >> >> 2015-02-25 Kai Tietz >> >> PR tree-optimization/61917 >> * tree-vect-loop.c (vectorizable_reduction):

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-25 12:35 GMT+01:00 Richard Biener : > On Wed, Feb 25, 2015 at 12:05 PM, Kai Tietz wrote: >> 2015-02-25 11:57 GMT+01:00 Richard Biener : >>> On Wed, Feb 25, 2015 at 11:06 AM, Kai Tietz wrote: >>>> Hello, >>>> >>>> ChangeLog &

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

Hello, So, I did full regression-test for following patch: ChangeLog 2015-02-25 Richard Biener Kai Tietz PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow vect_internal_def without reduction to exit graceful. ChagneLog testsuite/ 2015-02-25

[patch]: Fix PR target/64212

clones we want that they getting interposable. Therefore - as suggested by Honza - we need to make explicit sure that we set DECL_DLLIMPORT_P() explicit to 0 in symtab. ChangeLog 2015-02-25 Kai Tietz PR target/64212 * symtab.c (symtab::make_decl_local): Set DECL_IMPORT_P explicit to 0

Re: [patch]: Fix PR target/64212

Applied at revision 22098 to trunk. Jan approved patch on IRC. Regards, Kai

[patch]: Fix regression caused by fix for 61917

Hi, The patch didn't handled the case for dt being vect_constant_def, where of course the reduc_def_stmt is NULL. By checking for NULL before testing for PHI, we now fallback for such cases to old behavior and return in the next if-statment. 2015-02-25 Richard Biener Kai Tietz

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

Hi Marek, I have similiar change on the c++-delayed-fold branch. 2015-02-26 13:22 GMT+01:00 Marek Polacek : > We ICE on this invalid testcase in C++14 because in C++14 a function returning > void is a valid constexpr function, so adl_swap is registered as one, while in > C++11 it is not registere

[patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

Hi, This is the remaining fix for re-enabling native boostrap for Windows-variant of gcc without disabling -Werror for libgcc. ChangeLog 2015-02-26 Kai Tietz PR target/65038 * config.in: Regenerated. * configure: Likewise. * configure.ac (AC_HEADER_STDC): Add explicit

[patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

Hi, This patch addresses the reported ICE about #pragma weak used on declarations not var or function. ChangeLog 2015-02-26 Kai Tietz * c-pragma.c (handle_pragma_weak): Do not try to creat weak/alias of declarations not being function, or variable declarations. Bootstrapped

Re: [patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 19:53 GMT+01:00 Marek Polacek : > On Thu, Feb 26, 2015 at 07:28:02PM +0100, Kai Tietz wrote: >> Hi, >> >> This patch addresses the reported ICE about #pragma weak used on >> declarations not var or function. >> >> ChangeLog >> >>

Re: [patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

Applied at rev.revision 221055. -- Kai

Re: [patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

2015-02-27 14:48 GMT+01:00 H.J. Lu : > On Thu, Feb 26, 2015 at 6:49 AM, Kai Tietz wrote: >> Hi, >> >> This is the remaining fix for re-enabling native boostrap for >> Windows-variant of gcc without disabling -Werror for libgcc. >> >> ChangeLog >> &

[patch c++]: Fix for PR/65390

Hi, this patch avoids the attempt to create user-aligned-type for variants original and main-variants type-alignment differ and original type isn't user-aligned. Not sure if this is the preferred variant, we could create for such cases an aligned-type without setting user-align. But as this should

Re: [patch c++]: Fix for PR/65390

2015-03-16 19:07 GMT+01:00 Jason Merrill : > If there is an alignment mismatch without user intervention, there is a > problem, we can't just ignore it. > > Where we run into trouble is with array types where the version built > earlier has not been laid out yet but the new one has been. I've been

Re: [patch c++]: Fix for PR/65390

2015-03-16 20:22 GMT+01:00 Kai Tietz : > 2015-03-16 19:07 GMT+01:00 Jason Merrill : >> If there is an alignment mismatch without user intervention, there is a >> problem, we can't just ignore it. >> >> Where we run into trouble is with array types where the versi

Re: [patch c++]: Fix for PR/65390

2015-03-17 13:36 GMT+01:00 Jason Merrill : > On 03/16/2015 03:22 PM, Kai Tietz wrote: >> >> 2015-03-16 19:07 GMT+01:00 Jason Merrill : >>> >>> If there is an alignment mismatch without user intervention, there is a >>> problem, we can't just ignor

Re: [patch c++]: Fix for PR/65390

Hello, the problem here is that for cases of vla-array-types, the types don't get finally layouted in build_cplus_array_type. So the type-alignment isn't set in such cases for the resulting type. ChangeLog 2015-03-20 Kai Tietz PR c++/65390 * tree.c (strip_typedef

[patch libgomp]: Fix PR 64972

Hi, ChangeLog 2015-03-25 Kai Tietz PR libgomp/64972 * oacc-parallel.c (GOACC_parallel): Use PRIu64 if available. (GOACC_data_start): Likewise. * target.c (gomp_map_vars): Likewise. Tested for i686-w64-mingw32. Fix got preapproved by Jakub, so I will commit this soon, if

[patch emutls]:Fix PR 65566

Hi, This patch avoids that we try to operate on function-decl's cfun equal to NULL within lower_emutls_function_body. ChangeLog 2015-03-31 Kai Tietz PR target/65566 * tree-emutls.c (lower_emutls_function_body): Don't try to operate on node's decl function is NULL

Re: [patch emutls]:Fix PR 65566

2015-03-31 13:42 GMT+02:00 Jakub Jelinek : > On Tue, Mar 31, 2015 at 01:35:56PM +0200, Kai Tietz wrote: >> Hi, >> >> This patch avoids that we try to operate on function-decl's cfun equal >> to NULL within lower_emutls_function_body. > > If DECL_STRUCT_FUNC

Re: [patch c++]: Fix for PR/65390

Hi, I had tried same approach as Marek. For me it solved the PR, but caused other regressions on boostrap. So I dropped the way via dependent_type_p. Well, this bootstrap-issue might be caused by some local changes I had forgot to remove, but I doubt it. Marek, have you tried to do a boostrap w

Re: [patch c++]: Fix for PR/65390

2015-03-31 14:34 GMT+02:00 Marek Polacek : > On Tue, Mar 31, 2015 at 02:32:32PM +0200, Marek Polacek wrote: >> On Tue, Mar 31, 2015 at 02:25:14PM +0200, Kai Tietz wrote: >> > Hi, >> > >> > I had tried same approach as Marek. For me it solved the PR, but >&

Re: C++ delayed folding branch review

Hello Jason, Thanks for the review. I addressed a lot of your comments directly on svn-branch. See revision r224439. - Ursprüngliche Mail - > Generally, it seems like most of my comments from April haven't been > addressed yet. Yes, most of them. > > @@ -3023,13 +3023,14 @@ conversi

Re: Fix a MinGW warning in libiberty/strerror.c

Hi Eli, patch is reasonable and ok for me. Thanks Kai 2015-01-16 12:18 GMT+01:00 Eli Zaretskii : > Ping! > >> Date: Fri, 02 Jan 2015 12:54:47 +0200 >> From: Eli Zaretskii >> >> When compiling GDB 7.8.1, I get this warning in libiberty: >> >> gcc -c -DHAVE_CONFIG_H -O0 -g3 -D__USE_MINGW_ACC

Re: Fix a MinGW warning in libiberty/strerror.c

2015-01-16 12:50 GMT+01:00 Eli Zaretskii : >> Date: Fri, 16 Jan 2015 12:34:25 +0100 >> From: Kai Tietz >> Cc: GCC Patches , >> "gdb-patc...@sourceware.org" >> >> Hi Eli, >> >> patch is reasonable and ok for me. > > Thanks. D

[patch sdbout]: Fix ICE on -debug testsuite test const2.C for coff

Hi, This fixes recent fallout of debug-tests on Windows target for sdbout (coff) caused by an ICE. ChangeLog 2014-11-06 Kai Tietz * sdbout.c (sdbout_symbol): Eliminate register only if decl isn't a global variable. Tested for i686-w64-mingw32, and x86_64-w64-mingw32. Ok for

Re: [patch sdbout]: Fix ICE on -debug testsuite test const2.C for coff

Hi Jeff, 2014-11-07 21:03 GMT+01:00 Jeff Law : > On 11/06/14 12:37, Kai Tietz wrote: >> >> Hi, >> >> This fixes recent fallout of debug-tests on Windows target for sdbout >> (coff) caused by an ICE. >> >> ChangeLog >> >> 2014-11-06 Kai

Re: [patch sdbout]: Fix ICE on -debug testsuite test const2.C for coff

Ping

[patch c++]: Cleanup locally only/unused functions in typeck.c

Hello, I noticed that in typeck.c's API some functions are used just locally, and one has no users at all. So this patch cleans that up. ChangeLog 2014-11-12 Kai Tietz * cp-tree.h (cp_build_function_call): Remove prototype. (cp_build_addr_expr_strict): Lik

Re: [Ping] Port of VTV for Cygwin and MinGW

014-11-12 17:22 GMT+01:00 Patrick Wollgast : > Ping for the question below. > > On 30.10.2014 15:29, Patrick Wollgast wrote: >> Since I haven't heard back for quite a while, I wanted to ask what the >> current stat of the patch is. >> >> Is the patch from the last mail approved ( >> https://gcc.gnu

Re: [Ping] Port of VTV for Cygwin and MinGW

2014-11-12 18:45 GMT+01:00 Patrick Wollgast : >> >> I don't think you have addressed all of the comments I made in the >> comment, do you? >> >> Regards, >> Kai >> > > I added the three checks, if TARGET_PECOFF is defined, and fixed the > whitespace issues. > > For the questions regarding C-runtime

Re: [aarch64}: added variable issue rate feature for falkor

ilson Kai Tietz * config/aarch64/aarch64.c (aarch64_sched_reorder): Implement TARGET_SCHED_REORDER hook. (aarch64_variable_issue): Implement TARGET_SCHED_VARIABLE_ISSUE hook. (qdf24xx_): Add AARCH64_EXTRA_TUNE_SCHED_MICRO_OPS tune flag. (TARGET_SCHED_RE

Re: fix crash on 64-bit mingw-w64 hosted compiler using more than 4 gb of ram

Hello Stanislaw. patch is ok. Nevertheless there is a ChangeLog entry missing for it. It is mandatory to be provided for submissions to gcc. Thanks, Kai 2016-08-11 11:31 GMT+02:00 Stanislaw Halik : > The host configuration across platforms wrongly assumes that > sizeof(long) == sizeof(intptr_t)

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 12:21 GMT+02:00 JonY <10wa...@gmail.com>: > On 05/01/2017 11:31 AM, Uros Bizjak wrote: >> On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos >> wrote: >>> All of patches are concerned with 64-bit Microsoft ABI functions that call >>> System V ABI function which clobbers RSI, RDI and XMM6-

Re: [patch] Allow configuration with --disable-sjlj-exceptions on biarch x86 Windows targets

Hi, hopefully this time gmail uses mail-encoding elmz ask for ... Sorry to object here. I would like to point out that defaulting to dw2 on 32-bit if SEH is used for 64-bit is nothing good in general. This is reasoned by the problems existing in dw2 in combination with other compiler-generated

Re: [patch] Allow configuration with --disable-sjlj-exceptions on biarch x86 Windows targets

Ok. I just looked into patch. Sorry for the delay. As it is still possible to build old behavior, the patch is ok for me. Thanks, Kai 2016-05-19 20:55 GMT+02:00 Sandra Loosemore : > On 05/19/2016 12:40 PM, Kai Tietz wrote: >> >> Hi, >> >> hopefully this time gma

Re: C++ delayed folding branch review

Hello Jason, after a longer delay the answer to your question. 2015-08-03 17:39 GMT+02:00 Jason Merrill : > On 08/03/2015 05:42 AM, Kai Tietz wrote: >> >> 2015-08-03 5:49 GMT+02:00 Jason Merrill : >>> >>> On 07/31/2015 05:54 PM, Kai Tietz wrote: >>>

Re: [c++-delayed-folding] fold_simple

2015-08-27 4:57 GMT+02:00 Jason Merrill : > Why does fold_simple fold so many patterns? I thought we wanted something > that would just fold conversions and negations of constant values. Yes, initial variant was handling much less patterns. But actually we need for functions (eg. like build_vec_

Re: C++ delayed folding branch review

2015-08-27 4:56 GMT+02:00 Jason Merrill : > On 08/24/2015 03:15 AM, Kai Tietz wrote: >> >> 2015-08-03 17:39 GMT+02:00 Jason Merrill : >>> >>> On 08/03/2015 05:42 AM, Kai Tietz wrote: >>>> >>>> 2015-08-03 5:49 GMT+02:00 Jason Merr

Re: C++ delayed folding branch review

2015-08-27 15:27 GMT+02:00 Jason Merrill : > On 08/27/2015 06:39 AM, Kai Tietz wrote: >> >> 2015-08-27 4:56 GMT+02:00 Jason Merrill : >>> >>> On 08/24/2015 03:15 AM, Kai Tietz wrote: >>>> >>>> 2015-08-03 17:39 GMT+02:00 Jason Merr

Re: [c++-delayed-folding] fold_simple

2015-08-27 12:34 GMT+02:00 Richard Biener : > On Thu, Aug 27, 2015 at 11:21 AM, Kai Tietz wrote: >> 2015-08-27 4:57 GMT+02:00 Jason Merrill : >>> Why does fold_simple fold so many patterns? I thought we wanted something >>> that would just fold conversions and n

Re: C++ delayed folding branch review

With following patch testcase passes: Index: fold-const.c === --- fold-const.c(Revision 227111) +++ fold-const.c(Arbeitskopie) @@ -2110,6 +2110,17 @@ fold_convert_const (enum tree_code code, tree type else if (T

Re: C++ delayed folding branch review

2015-08-28 4:11 GMT+02:00 Jason Merrill : > On 08/27/2015 02:12 PM, Kai Tietz wrote: >> >> + else if (TREE_CODE (type) == VECTOR_TYPE) >> +{ >> + if (TREE_CODE (arg1) == VECTOR_CST >> + && code == NOP_EXPR >> + &&

Re: C++ delayed folding branch review

2015-08-28 9:19 GMT+02:00 Kai Tietz : > 2015-08-28 4:11 GMT+02:00 Jason Merrill : >> On 08/27/2015 02:12 PM, Kai Tietz wrote: >>> >>> + else if (TREE_CODE (type) == VECTOR_TYPE) >>> +{ >>> + if (TREE_CODE (arg1) ==

Re: [PATCH] clone_function_name_1: Retain any stdcall suffix

2015-08-18 22:23 GMT+02:00 Ray Donnelly : > I'm not familiar with setting up GCC testcases yet so I expect to have > to do that at least. To aid discussion, the commit message contains a > testcase. No problem. Patch looks fine to me. Thanks, Kai > -- > Best regards, > > Ray.

Re: [c++-delayed-folding] fold_simple

2015-08-29 6:45 GMT+02:00 Jason Merrill : > On 08/27/2015 05:21 AM, Kai Tietz wrote: >> >> 2015-08-27 4:57 GMT+02:00 Jason Merrill : >>> >>> Why does fold_simple fold so many patterns? I thought we wanted >>> something >>> that would jus

Re: [PATCH] Remove pointless -fPIC warning on Windows platforms

Hi Pedro, 2015-08-15 0:24 GMT+02:00 Paolo Bonzini : > There are plenty of targets that do not require -fPIC because they always > generate position independent code, but none of them feels the need to > complain with the user about an unnecessary but perfectly valid option, > on each and every .c-

Re: [c++-delayed-folding] fold_simple

2015-08-31 19:52 GMT+02:00 Jason Merrill : > On 08/29/2015 10:10 AM, Kai Tietz wrote: >> >> Hmm, I don't think we want to call maybe_constant_value in functions >> like cp_build_binary_op. We are interested in overflow only on >> constant-values anyway, I don

Re: [c++-delayed-folding] fold_simple

2015-08-31 21:29 GMT+02:00 Jason Merrill : > On 08/31/2015 03:08 PM, Kai Tietz wrote: >> >> I will need to verify that this patch doesn't introduce regressions. >> The wacky thing here is the encapsulation of overflowed-arguments in >> maybe_constant_value function

Re: [c++-delayed-folding] fold_simple

2015-08-31 21:43 GMT+02:00 Kai Tietz : > 2015-08-31 21:29 GMT+02:00 Jason Merrill : >> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>> >>> I will need to verify that this patch doesn't introduce regressions. >>> The wacky thing here is the

Re: [c++-delayed-folding] fold_simple

2015-08-31 22:19 GMT+02:00 Kai Tietz : > 2015-08-31 21:43 GMT+02:00 Kai Tietz : >> 2015-08-31 21:29 GMT+02:00 Jason Merrill : >>> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>>> >>>> I will need to verify that this patch doesn't introduce regressions.

Re: [c++-delayed-folding] fold_simple

2015-09-01 10:15 GMT+02:00 Kai Tietz : > 2015-08-31 22:19 GMT+02:00 Kai Tietz : >> 2015-08-31 21:43 GMT+02:00 Kai Tietz : >>> 2015-08-31 21:29 GMT+02:00 Jason Merrill : >>>> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>>>> >>>>> I will

Re: [c++-delayed-folding] fold_simple

2015-09-01 10:43 GMT+02:00 Kai Tietz : > 2015-09-01 10:15 GMT+02:00 Kai Tietz : >> 2015-08-31 22:19 GMT+02:00 Kai Tietz : >>> 2015-08-31 21:43 GMT+02:00 Kai Tietz : >>>> 2015-08-31 21:29 GMT+02:00 Jason Merrill : >>>>> On 08/31/2015 03:08 PM, Kai Tie

Re: [c++-delayed-folding] fold_simple

2015-09-01 13:17 GMT+02:00 Kai Tietz : > 2015-09-01 10:43 GMT+02:00 Kai Tietz : >> 2015-09-01 10:15 GMT+02:00 Kai Tietz : >>> 2015-08-31 22:19 GMT+02:00 Kai Tietz : >>>> 2015-08-31 21:43 GMT+02:00 Kai Tietz : >>>>> 2015-08-31 21:29 GMT+02:00 Jason Merri

Re: [c++-delayed-folding] fold_simple

2015-09-01 16:47 GMT+02:00 Jason Merrill : > On 08/31/2015 03:43 PM, Kai Tietz wrote: >> >> 2015-08-31 21:29 GMT+02:00 Jason Merrill : >>> >>> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>>> >>>> >>>> I will need to verify that t

Re: [c++-delayed-folding] fold_simple

2015-09-01 17:31 GMT+02:00 Jason Merrill : > On 09/01/2015 11:27 AM, Kai Tietz wrote: >> >> I rewrote binary/unary overflow-check logic so, that we avoid double >> checking-s. I think this address things as you intend, beside the >> checking for constant value. We wo

[patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

ymore within that function. Bootstrap just show 2 regressions within gcc.dg testsuite due patterns matched are folded more early by forward-propagation. I adjusted them, and added them to patch, too. I did regression-testing for x86_64-unknown-linux-gnu. ChangeLog 2015-09-08 Kai

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

Ping. 2015-09-08 13:17 GMT+02:00 Kai Tietz : > Hi, > > This patch is the first part of obsoleting 'shorten_compare' function > for folding. > It adjusts the uses of 'shorten_compare' to ignore folding returned by > it, and adds > missing pattterns t

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

2015-09-15 0:45 GMT+02:00 Jeff Law : > On 09/08/2015 05:17 AM, Kai Tietz wrote: >> >> Hi, >> >> This patch is the first part of obsoleting 'shorten_compare' function >> for folding. >> It adjusts the uses of 'shorten_compare' to ignore

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

Hi Richi, thanks for the review. 2015-09-15 12:06 GMT+02:00 Richard Biener : > On Tue, Sep 8, 2015 at 1:17 PM, Kai Tietz wrote: >> Hi, >> >> This patch is the first part of obsoleting 'shorten_compare' function >> for folding. >> It adjusts the

[patch c++]: Fix PR/64100 'A static assert using the the current class in a noexcept test leads to a segfault'

Hi, The issue is that lookup_destructor calls adjust_result_of_qualified_name_lookup with an NULL_TREE decl (returned by lookup_member). So error-message is missing. As already discussed in bug-tracker: ChangeLog 2014-12-04 Kai Tietz PR c++/64100 * typeck.c (lookup_destructor

[patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

Hi, this patch fixes an ICE happening on invalid code for < c++11. It is reasoned by accessing blindly identifier without checking that it is a declaration. ChangeLog 2014-12-04 Kai Tietz PR c++/64127 * parser.c (cp_parser_diagnose_invalid_type_name): Check id for bein

[patch c++]: Fix PR c++/64106 ICE on valid code

Hi, this patch adds INDIRECT_REF support to cxx_eval_store_expression handling. There is a different variant suggested by Marek, which adds additional operand-0 to ref, which looks to me wrong. ChangeLog gcc/cp 2014-12-04 Kai Tietz PR c++/64106 * constexpr.c

Re: [patch c++]: Fix PR/64100 'A static assert using the the current class in a noexcept test leads to a segfault'

2014-12-04 16:46 GMT+01:00 Marek Polacek : > On Thu, Dec 04, 2014 at 04:00:34PM +0100, Kai Tietz wrote: >> Hi, >> >> The issue is that lookup_destructor calls >> adjust_result_of_qualified_name_lookup >> with an NULL_TREE decl (returned by lookup_member). So erro

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

2014-12-04 16:47 GMT+01:00 Marek Polacek : > On Thu, Dec 04, 2014 at 04:12:02PM +0100, Kai Tietz wrote: >> Hi, >> >> this patch fixes an ICE happening on invalid code for < c++11. It is >> reasoned by >> accessing blindly identifier without checking that

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

So added testcase for this pr (its c++98 only) So: ChangeLog testsuite 2014-12-04 Kai Tietz PR c++/64127 * g++.dg/cpp/pr64127.C: New file. Tested on x86_64-unknown-linux-gnu. Ok to apply prior posted patch plus this new testcase? Regards, Kai Index: gcc/gcc/testsuite/g++.dg

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

2014-12-04 20:35 GMT+01:00 Jason Merrill : > On 12/04/2014 10:12 AM, Kai Tietz wrote: >> >> else if (cxx_dialect < cxx11 >> + && DECL_P (id) >> && !strcmp (IDENTIFIER_POINTER (id), "thread_local")) >

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

Updated version checking the right thing ... ChangeLog gcc/cp 2014-12-04 Kai Tietz PR c++/64127 * parser.c (cp_parser_diagnose_invalid_type_name): Check id for being an identifier before accessing it. Tested on x86_64-unknown-linux-gnu. Ok for apply together with testcase

Re: [patch c++]: Fix PR/64100 'A static assert using the the current class in a noexcept test leads to a segfault'

Ok, Additional change for testcase mentioned in PR. ChangeLog 2014-12-04 Kai Tietz PR c++/641000 * g++.dg/template/pr64100.C: New file. Ok for apply? Regards, Kai Index: gcc/gcc/testsuite/g++.dg/template/pr64100.C

[patch c++]: Fix PR/63996

Hi, The loop-expression loops endless in c++14's case for cases the statement-list isn't constant. Bug 63996 - Infinite loop in invalid C++14 constexpr fn ChangeLog 2014-12-12 Kai Tietz PR c++/63996 * constexpr.c (cxx_eval_loop_expr): Don't loop endless o

[patch c++]: Fix 61228 - noexcept(expression) causes internal compiler error

Hi, following patch fixes reported issue. Tested for x86_64-w64-mingw32. Ok for apply? Regards, Kai ChangeLog 2014-12-12 Kai Tietz PR c++/61228 * call.c (set_flags_from_callee): Assume no throw by deferred noexcept. 2014-12-12 Kai Tietz PR c++/61228 * g++.dg/cpp0x

Re: [patch c++]: Fix 61228 - noexcept(expression) causes internal compiler error

2014-12-12 21:15 GMT+01:00 Jason Merrill : > I think it would be better to call maybe_instantiate_noexcept so that we can > have a definite answer. > > Jason Hmm, for case that decl != NULL_TREE, this is ok. But what if decl is NULL_TREE? Kai

Re: [patch c++]: Fix PR/63996

2014-12-15 11:48 GMT+01:00 Paolo Carlini : > ... committed as obvious the below. > > Paolo. > > / Thanks Kai

[patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

Hi, this patch adds handling of aliases within templates and tries to resolve specialization for them. ChangeLog 2014-12-18 Kai Tietz PR c++/61198 * pt.c (retrieve_specialization): Handle using. Tested on x86_64-w64-mingw32. Ok for apply? Regards, Kai ChangeLog testsuite 2014

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-18 18:26 GMT+01:00 Jason Merrill : > On 12/18/2014 10:10 AM, Kai Tietz wrote: >> >> + if (TMPL_ARGS_DEPTH (args) > TMPL_PARMS_DEPTH (tmpl_parms)) >> +args = get_innermost_template_args >> +(args, TMPL_PARMS_DEPTH (tmpl_parms)); > >

<    1   2   3   4   5   6   7   8   9   >