stddef.h: Add C2x unreachable macro

2022-09-08 Thread Joseph Myers
C2x adds a macro unreachable to stddef.h, with the same semantics as __builtin_unreachable. Define this macro accordingly. Bootstrapped with no regressions for x86_64-pc-linux-gnu. OK to commit? gcc/ * ginclude/stddef.h [__STDC_VERSION__ > 201710L] (unreachable): New macro. gcc

Re: [PATCH] amdgcn: Add support for additional natively supported floating-point operations

2022-09-09 Thread Joseph Myers
On Thu, 8 Sep 2022, Kwok Cheung Yeung wrote: > The sin and cos instructions for some reason are scaled by 2*PI radians (i.e. > 1.0 == 2*PI radians/360 degrees), so their inputs need to be scaled by > 1/(2*PI) first. I've implemented this as an expander to two instructions - one C2x has sinpi and

stdatomic.h: Do not define ATOMIC_VAR_INIT for C2x

2022-09-09 Thread Joseph Myers
The macro ATOMIC_VAR_INIT, previously declared obsolete, is removed completely in C2x; disable it for C2x in GCC's implementation. (Although ATOMIC_* are reserved names for this header, disabling the macro for C2x still seems appropriate.) Bootstrapped with no regressions for x86_64-pc-linux-gnu

Re: [PATCH] c++: Implement P1467R9 - Extended floating-point types and standard names compiler part except for bfloat16 [PR106652]

2022-09-12 Thread Joseph Myers
On Mon, 12 Sep 2022, Jakub Jelinek via Gcc-patches wrote: > Now, I guess for the fixincludes it could also use > # if !__GNUC_PREREQ (7, 0) || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) > where earlier GCC 13 snapshots would not be doing the fixincludes, > but the question is what to use for

Re: [PATCH] middle-end/105376 - invalid REAL_CST for DFP constant

2022-04-27 Thread Joseph Myers
On Wed, 27 Apr 2022, Richard Biener via Gcc-patches wrote: > Is this the correct strathegy to deal with this problem? Would > it be valid to just set ->is_decimal in build_real based on Just setting ->decimal isn't correct; that signifies that ->sig stores the number in decimal128 format (host-

Re: [PATCH RFA] c-family: attribute ((aligned, mode)) [PR100545]

2022-04-27 Thread Joseph Myers
On Wed, 27 Apr 2022, Jason Merrill via Gcc-patches wrote: > + if (typedef_variant_p (type)) > + { > + /* Set up the typedef all over again. */ This seems wrong when the typedef is just being used in another declaration with the mode attribute, as opposed to being defined using th

Re: [PATCH] middle-end/105376 - invalid REAL_CST for DFP constant

2022-04-28 Thread Joseph Myers
On Thu, 28 Apr 2022, Richard Biener via Gcc-patches wrote: > We are eventually ICEing in decimal_to_decnumber on non-decimal > REAL_VALUE_TYPE that creep in from uses of build_real (..., dconst*) > for DFP types. The following extends the decimal_to_decnumber > special-casing of dconst* to build_

Re: [PATCH] Disable tests that require fesetround() on platforms without it

2022-04-28 Thread Joseph Myers
On Thu, 28 Apr 2022, Palmer Dabbelt wrote: > +proc check_effective_target_fenv_setround {} { > + return [check_runtime fenv_setround { > +#include > +#include > +int > +main (void) > +{ > + if (fesetround (1) == 0) There is no reason to expect that 1 is a valid argumen

Re: [PATCH] Disable tests that require fesetround() on platforms without it

2022-04-28 Thread Joseph Myers
On Thu, 28 Apr 2022, Palmer Dabbelt wrote: > On Thu, 28 Apr 2022 15:12:39 PDT (-0700), jos...@codesourcery.com wrote: > > On Thu, 28 Apr 2022, Palmer Dabbelt wrote: > > > > > +proc check_effective_target_fenv_setround {} { > > > + return [check_runtime fenv_setround { > > > +#include > > >

Re: [PATCH RFA] c-family: attribute ((aligned, mode)) [PR100545]

2022-04-29 Thread Joseph Myers
On Fri, 29 Apr 2022, Jason Merrill via Gcc-patches wrote: > Marek pointed out elsewhere that the first testcase should have > > // { dg-additional-options -g } > > OK for 13 with that change? OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [ping2][PATCH 0/8][RFC] Support BTF decl_tag and type_tag annotations

2022-05-03 Thread Joseph Myers
On Mon, 2 May 2022, David Faust via Gcc-patches wrote: > Consider the following example: > >#define __typetag1 __attribute__((btf_type_tag("tag1"))) >#define __typetag2 __attribute__((btf_type_tag("tag2"))) >#define __typetag3 __attribute__((btf_type_tag("tag3"))) > >int __typeta

Re: [PATCH] Skip constant folding for fmin/max when either argument is sNaN [PR105414]

2022-05-05 Thread Joseph Myers
On Thu, 5 May 2022, Richard Biener via Gcc-patches wrote: > MIN/MAX_EXPR shouldn't even appear with -fsignalling-nans for this > reason, at least that's what I thought. But yes, you might have a point > here (but maybe it's also not strictly enough specified). One option would > be to do (minmax

Re: [PATCH] configure: add --disable-fix-includes

2022-05-09 Thread Joseph Myers
If you add a new configure option, it should be documented in install.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 09/10] libgcc: Add support for HF mode (aka __fp16) in libbid

2022-05-09 Thread Joseph Myers
On Mon, 9 May 2022, Christophe Lyon via Gcc-patches wrote: > This patch adds support for trunc and extend operations between HF > mode (__fp16) and Decimal Floating Point formats (_Decimal32, > _Decimal64 and _Decimal128). > > For simplicity we rely on the implicit conversions inserted by the > c

Re: [PATCH 09/10] libgcc: Add support for HF mode (aka __fp16) in libbid

2022-05-10 Thread Joseph Myers
On Tue, 10 May 2022, Christophe Lyon via Gcc-patches wrote: > > Note that for conversion from DFP to HFmode, double rounding (going via > > SFmode) probably produces incorrectly rounded results in some cases > > (though we already have such incorrect results in the other direction for > > DPD; see

Re: [PATCH] [12/11/10] Fix invalid format warnings on Windows

2022-05-11 Thread Joseph Myers
On Wed, 11 May 2022, Martin Liška wrote: > May I please ping review for this? There are various coding style issues in the patch; at least missing space before '(' and '&&' at end of line (should be at start of line). It will also need to be updated for .c files having been renamed to .cc in t

Re: [PATCH v2 09/10] libgcc: Add support for HF mode (aka __fp16) in libbid

2022-05-13 Thread Joseph Myers
On Fri, 13 May 2022, Christophe Lyon via Gcc-patches wrote: > diff --git a/gcc/testsuite/gcc.target/aarch64/convert-dfp-2.c > b/gcc/testsuite/gcc.target/aarch64/convert-dfp-2.c I still think the tests should run for x86 as well - that is, for any target supporting both DFP and _Float16 (with ap

Re: PING#2 Re: [PATCH RFA] attribs: fix typedefs in generic code [PR105492]

2022-05-16 Thread Joseph Myers
On Mon, 16 May 2022, Jason Merrill via Gcc-patches wrote: > Ping. OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] c: use CONST_DECL for enumerators in TYPE_VALUES

2022-05-17 Thread Joseph Myers
On Tue, 17 May 2022, Marek Polacek via Gcc-patches wrote: > The C and C++ FEs differ in TYPE_VALUES for an enum type: an entry in > the list in the C++ FE has a CONST_DECL in the TREE_VALUE, but the C FE > has only the numerical value of the CONST_DECL there. This has caused > me some trouble in

Re: [PATCH v2] c: Implement new -Wenum-int-mismatch warning [PR105131]

2022-05-18 Thread Joseph Myers
On Wed, 18 May 2022, Marek Polacek via Gcc-patches wrote: > diff --git a/gcc/testsuite/gcc.dg/Wenum-int-mismatch-1.c > b/gcc/testsuite/gcc.dg/Wenum-int-mismatch-1.c > new file mode 100644 > index 000..f71a308bc19 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/Wenum-int-mismatch-1.c > @@ -0,

Re: [PATCH] Modula-2: merge proposal/review: 7/9 07.patch-set-05

2022-05-18 Thread Joseph Myers
On Wed, 18 May 2022, Gaius Mulley via Gcc-patches wrote: > /* This is the contribution to the `documented_lang_options' array in >toplev.c for gm2. */ I'm not sure what this is (an unused file?), but documented_lang_options was removed in 2003. And in general, comments referring to .c file

Re: [PATCH v3] c: Implement new -Wenum-int-mismatch warning [PR105131]

2022-05-18 Thread Joseph Myers
On Wed, 18 May 2022, Marek Polacek via Gcc-patches wrote: > I've extended the tests to use an enum with __attribute__ ((__packed__)) to > test the case when the underlying type is (un)signed char. But it seems like > we can't have underlying types wider than int. I've also included two tests > w

Re: [PATCH v3 09/10] libgcc: Add support for HF mode (aka _Float16) in libbid

2022-05-19 Thread Joseph Myers
On Thu, 19 May 2022, Christophe Lyon via Gcc-patches wrote: > Hi Joseph, > > May I ping you on this version? (I've moved the tests to gcc.dg/torture/ and > checked they work on aarch64 and x86_64. This version is OK, given a bug report filed in Bugzilla for the double-rounding issues with conve

Re: [wwwdocs] Add C status page

2022-05-24 Thread Joseph Myers
On Tue, 24 May 2022, Marek Polacek via Gcc-patches wrote: > I thought it'd be nice to have a table that documents our C support > status, like we have https://gcc.gnu.org/projects/cxx-status.html for C++. > We have https://gcc.gnu.org/c99status.html, but that's C99 only. > > So here's a patch to

Re: [wwwdocs] Add C status page

2022-05-24 Thread Joseph Myers
On Tue, 24 May 2022, Marek Polacek via Gcc-patches wrote: > + This actually looks like a mix of papers approved at the Oct 2020 meeting and those approved at the Nov/Dec 2020 meeting, though I haven't checked the lists in detail against those the minutes show as being approved as-is or wit

Re: [build] Properly track GCC language configure fragments

2019-10-25 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: introduce -fcallgraph-info option

2019-10-28 Thread Joseph Myers
On Sat, 26 Oct 2019, Alexandre Oliva wrote: > Regstrapped on x86_64-linux-gnu. Ok to install? I have only a peripheral comment: > diff --git a/gcc/common.opt b/gcc/common.opt > index cc279f411d796..63d646fba2b42 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -1091,6 +1091,14 @@ fbtr-

Re: introduce -fcallgraph-info option

2019-10-30 Thread Joseph Myers
On Wed, 30 Oct 2019, Alexandre Oliva wrote: > On Oct 28, 2019, Joseph Myers wrote: > > > We have a test in the testsuite that all option help text consistently > > ends with '.' (see gcc.misc-tests/help.exp). I'd have expected these > > options, lacki

Re: [PATCH 2/2] Remove cgraph_local_info structure.

2019-10-30 Thread Joseph Myers
This appears to have broken the build for Arm. /scratch/jmyers/glibc-bot/src/gcc/gcc/config/arm/arm.c: In function 'arm_pcs arm_get_pcs_model(const_tree, const_tree)': /scratch/jmyers/glibc-bot/src/gcc/gcc/config/arm/arm.c:5959:4: error: 'cgraph_local_info' was not declared in this scope cgr

Re: [PATCH 2/2] Remove cgraph_local_info structure.

2019-10-30 Thread Joseph Myers
On Wed, 30 Oct 2019, Joseph Myers wrote: > This appears to have broken the build for Arm. And probably bfin and c6x as well, based on grep, but my bot only covers glibc targets so doesn't test those. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Fix libcpp #pragma {push,pop}_macro handling of builtin macros (PR preprocessor/92296)

2019-10-31 Thread Joseph Myers
On Thu, 31 Oct 2019, Jakub Jelinek wrote: > Hi! > > Seems libcpp has been ICEing on push_macro of a builtin macro since 2010, In fact, we have both bug 69665 and bug 87181 for that. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Add explicit description for -finline

2019-11-01 Thread Joseph Myers
On Thu, 31 Oct 2019, Xiong Hu Luo wrote: > +@code{-finline} enables inlining of function declared \"inline\". > +@code{-finline} is enabled at levels -O1, -O2, -O3 and -Os, but not -Og. Use @option{} to mark up option names (both -finline and all the -O options in this paragraph). Use @code{} t

Re: [PATCH v2] PR92090: Fix testcase failures by r276469

2019-11-04 Thread Joseph Myers
On Mon, 4 Nov 2019, luoxhu wrote: > -finline-functions is enabled by default for O2 since r276469, update the > test cases with -fno-inline-functions. > > v2: disable inlining for the failed cases. Add two more failed cases > not listed in BZ. Tested on P8LE, P8BE and P9LE. If inlining (or oth

Re: [PATCH v2] PR92090: Fix testcase failures by r276469

2019-11-05 Thread Joseph Myers
On Tue, 5 Nov 2019, Kewen.Lin wrote: > Very good point! Since gcc doesn't pursue 100% testsuite pass rate, I noticed > there are a few failures exposed/caused by some PRs all the time. Could we > just leave the test case there without any pre workaround till the PR get > fixed? Yes, leaving th

Re: [PATCH 0/X] Introduce HWASAN sanitizer to GCC

2019-11-05 Thread Joseph Myers
On Tue, 5 Nov 2019, Matthew Malcomson wrote: > Hello, > > This patch series adds the LLVM hardware address sanitizer (HWASAN) to > GCC. The document describing HWASAN can be found here > http://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html. General observations on the patch se

Re: [PATCH 13/X] [libsanitizer][options] Add hwasan flags and argument parsing

2019-11-05 Thread Joseph Myers
On Tue, 5 Nov 2019, Matthew Malcomson wrote: > +DEFHOOK > +(can_tag_addresses, > + "True if backend architecture naturally supports ignoring the top byte of\ > + pointers. This feature means that -fsanitize=hwaddress can work.", > + bool, (), default_memtag_can_tag_addresses) @option{-fsanitize=

Re: [RFC PATCH] Extend the simd function attribute

2019-11-05 Thread Joseph Myers
On Tue, 5 Nov 2019, Szabolcs Nagy wrote: > GCC currently supports two ways to declare the availability of vector > variants of a scalar function: > > #pragma omp declare simd > void f (void); > > and > > __attribute__ ((simd)) > void f (void); > > However neither can declare unambiguou

Move string concatenation for C into the parser

2019-11-06 Thread Joseph Myers
nd C++ (some other messages in those tests already had differences between C and C++). Bootstrapped with no regressions on x86_64-pc-linux-gnu. Applied to mainline. gcc/c: 2019-11-07 Joseph Myers * c-parser.c (c_parser): Remove lex_untranslated_string. Add lex_joined_string

Re: [C] Opt out of GNU vector extensions for built-in SVE types

2019-11-07 Thread Joseph Myers
On Thu, 7 Nov 2019, Richard Sandiford wrote: > Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? OK. -- Joseph S. Myers jos...@codesourcery.com

Expand C2x attribute parsing support and factor out from TM attributes

2019-11-07 Thread Joseph Myers
alent to the "gnu" namespace inside [[]]. Bootstrapped with no regressions on x86_64-pc-linux-gnu. Applied to mainline. gcc/c: 2019-11-07 Joseph Myers * c-parser.c (c_parser_attribute_arguments): New function. Factored out of c_parser_gnu_attribute. (c_parser_gnu

Handle removal of old-style function definitions in C2x

2019-11-07 Thread Joseph Myers
11-08 Joseph Myers * doc/invoke.texi (-Wold-style-definition): Document () not being considered an old-style definition for C2x. gcc/c: 2019-11-08 Joseph Myers * c-decl.c (grokparms): Convert () in a function definition to (void) fo

Add C2x *_NORM_MAX constants to

2019-11-08 Thread Joseph Myers
otstrapped with no regressions on x86_64-pc-linux-gnu. Also tested compilation of the new test for powerpc-linux-gnu to confirm the check of LDBL_NORM_MAX in the IBM long double case does get properly optimized out. OK to commit? gcc: 2019-11-09 Joseph Myers * ginclude/float.c [__STDC

Re: [PATCH] Bump minimum MPFR version to 3.1.0

2019-11-11 Thread Joseph Myers
On Sat, 9 Nov 2019, Janne Blomqvist wrote: > Bump the minimum MPFR version to 3.1.0, released 2011-10-03. With this > requirement one can still build GCC with the operating system provided > MPFR on old but still supported operating systems like SLES 12 (MPFR > 3.1.2) or RHEL/CentOS 7.x (MPFR 3.1.

Ping Re: Add C2x *_NORM_MAX constants to

2019-11-13 Thread Joseph Myers
Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Switch gcc ftp URL's to http

2019-11-13 Thread Joseph Myers
On Wed, 13 Nov 2019, Janne Blomqvist wrote: > For me, when I use my normal web browser (firefox), it does redirect > to https. But I'm using the "HTTPS everywhere" extension, so I'm not > sure if it's the extension that does it, or if the server redirects > me, or if it's some other web-security-t

Re: [PATCH] Add `--with-install-sysroot=' configuration option

2019-11-13 Thread Joseph Myers
On Thu, 14 Nov 2019, Maciej W. Rozycki wrote: > Questions, comments, OK to apply? 1. This needs documentation in install.texi. 2. A common macro in config/ would be better than duplicating code in each configure.ac file. 3. To confirm (this should be made clear in the documentation), this is

Support C2x [[]] attributes for C

2019-11-13 Thread Joseph Myers
e removed, but failing that it should be restricted to structure and union types (and such a change would be a bug-fix). That would then allow various cases of [[]] attributes on types to work properly. Bootstrapped with no regressions on x86_64-pc-linux-gnu. Applied to mainline. g

Ping Re: float.h: C2x NaN and Inf macros

2020-11-02 Thread Joseph Myers
Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] mixing of labels and code in C2X

2020-11-02 Thread Joseph Myers
On Sun, 1 Nov 2020, Uecker, Martin wrote: > @@ -5693,27 +5692,54 @@ c_parser_compound_statement_nostart (c_parser *parser) >     last_label = true; >     last_stmt = false; >     mark_valid_location_for_stdc_pragma (false); > -   c_parser_label (parser); > +   c_parser_label (p

Re: PowerPC: Add __float128 conversions to/from Decimal

2020-11-02 Thread Joseph Myers
On Mon, 2 Nov 2020, Segher Boessenkool wrote: > > Also note that if you want to use printf as opposed to strfromf128 for > > IEEE binary128 you'll need to use __printfieee128 (the version that > > expects long double to be IEEE binary128) which was introduced in glibc > > 2.32, so that doesn't

Re: [04/32] cpp lexer

2020-11-03 Thread Joseph Myers
On Tue, 3 Nov 2020, Nathan Sidwell wrote: > @@ -888,9 +915,9 @@ struct GTY(()) cpp_hashnode { >unsigned int directive_index : 7; /* If is_directive, > then index into directive table. > Otherwise, a NODE_OPERATO

c: Implement C2x nodiscard attribute

2020-11-03 Thread Joseph Myers
C2x adds the nodiscard standard attribute, with an optional string argument, as in C++; implement it for C. Bootstrapped with no regressions for x86_64-pc-linux-gnu. Applied to mainline. gcc/c/ 2020-11-04 Joseph Myers * c-decl.c (handle_nodiscard_attribute): New

Re: [PATCH v5] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-11-04 Thread Joseph Myers
On Wed, 4 Nov 2020, Raoni Fassina Firmino via Gcc-patches wrote: > IMHO, It seems like it is not necessary if there not a libc that have > different values for the FE_* macros. I didn't check other archs, but if > is the case for some other arch I think it could be changed if and when > some other

Re: [PATCH v5] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-11-04 Thread Joseph Myers
On Wed, 4 Nov 2020, Richard Biener wrote: > AFAICS you do nothing to marshall with the actually used libc > implementation which AFAIU can choose arbitrary values for > the FE_* macros. I'm not sure we require the compiler to be > configured for one specific C library and for example require > ma

builtins: Add DFP signaling NaN built-in functions

2020-11-04 Thread Joseph Myers
onfirm they do work in the case (hardware DFP) where floating-point exceptions are supported for DFP. OK to commit? gcc/ 2020-11-05 Joseph Myers * builtins.def (BUILT_IN_NANSD32, BUILT_IN_NANSD64) (BUILT_IN_NANSD128): New built-in functions. * fold-const-

float.h: C2x decimal signaling NaN macros

2020-11-05 Thread Joseph Myers
136.html> and <https://gcc.gnu.org/pipermail/gcc-patches/2020-November/558126.html> (both pending review) applied. Bootstrapped with no regressions for x86_64-pc-linux-gnu. OK to commit? gcc/ 2020-11-05 Joseph Myers * ginclude/float.h (DEC32_SNAN, DEC64_SNAN, DEC128_SNAN): New C

Re: [PATCH] Objective-C : Implement NSObject attribute.

2020-11-06 Thread Joseph Myers
On Fri, 6 Nov 2020, Iain Sandoe wrote: > Hi > > Originally, I had this as a Darwin-only patch, however GNUStep > also makes use of NSObject and similar constructs, so this really > needs to be available to linux-gnu as well. > > tested across several Darwin versions and on x86_64-linux-gnu. > >

Re: [PATCH] Objective-C/C++ (C-family) : Add missing 'atomic' property attribute.

2020-11-06 Thread Joseph Myers
On Fri, 6 Nov 2020, Iain Sandoe wrote: > Hi > > Arguably, this is actually a bug fix since the ‘atomic’ attribute is > paired with the ‘nonatomic’ one. However it is the default and was > omitted when the @property implementation was added. > > ‘atomic’ in Objective-C terms is not specified in

Re: [PATCH] mixing of labels and code in C2X

2020-11-06 Thread Joseph Myers
On Fri, 6 Nov 2020, Uecker, Martin wrote: > Hi Joseph, > > here is the revised patch. I remove the 'fallthrough' > code as suggested, so everything becomes even simpler. > Some tests had to be changed then, but it seems Ok to > me. This patch is missing the new tests. > + * gcc.dg/c11-label

Re: [PATCH] mixing of labels and code in C2X

2020-11-06 Thread Joseph Myers
On Fri, 6 Nov 2020, Uecker, Martin wrote: > Am Freitag, den 06.11.2020, 22:07 + schrieb Joseph Myers: > > On Fri, 6 Nov 2020, Uecker, Martin wrote: > > > > > Hi Joseph, > > > > > > here is the revised patch. I remove the 'fallthrough'

Ping^2 Re: float.h: C2x NaN and Inf macros

2020-11-09 Thread Joseph Myers
Ping^2. This patch is still pending review (the DFP sNaN followup has been approved). -- Joseph S. Myers jos...@codesourcery.com

Re: [C PATCH RFC] Drop qualifiers during lvalue conversion

2020-11-09 Thread Joseph Myers
On Sat, 7 Nov 2020, Uecker, Martin wrote: > In 'gcc.dg/cond-constqual-1.c' we test for the opposite > behavior for conditional operators. I do not know why. > We could just invert the test. That's probably a relic of the old idea that rvalues might actually have qualified type in some cases; it

Re: [PATCH] C-family : Add attribute 'unavailable'.

2020-11-10 Thread Joseph Myers
This patch seems to be missing documentation for the new attribute in extend.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Better __ashlDI3, __ashrDI3 and __lshrDI3 functions, plus fixed __bswapsi2 function

2020-11-11 Thread Joseph Myers
On Wed, 11 Nov 2020, Jakub Jelinek via Gcc-patches wrote: > So indeed, 0x80 << 24 is UB in C99/C11 and C++98, unclear in C89 and > well defined in C++11 and later. I don't know if C2X is considering > mandating two's complement and making it well defined like C++20 did. C2x requires two's comple

Re: [PATCH][RFC] Make mingw-w64 printf/scanf attribute alias to ms_printf/ms_scanf only for C89

2020-11-12 Thread Joseph Myers
I'd expect these patches to include updates to the gcc.dg/format/ms_*.c tests to reflect the changed semantics (or new tests there if some of the changes don't result in any failures in the existing tests). -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 1/3] C-family, Objective-C [1/3] : Implement Wobjc-root-class [PR77404].

2020-11-12 Thread Joseph Myers
On Thu, 12 Nov 2020, Iain Sandoe wrote: > OK for the c-family parts? OK. -- Joseph S. Myers jos...@codesourcery.com

c: C2x __has_c_attribute

2020-11-12 Thread Joseph Myers
on of those macros, only to use the resulting pp-number in a #if expression, where long and int have the same set of values. Bootstrapped with no regressions for x86_64-pc-linux-gnu. Applied to mainline. gcc/ 2020-11-12 Joseph Myers * doc/cpp.texi (__has_attribute): Document wh

Re: [PATCH] C-Family, Objective-C : Implement Objective-C nullability Part 1 [PR90707].

2020-11-12 Thread Joseph Myers
On Thu, 12 Nov 2020, Iain Sandoe wrote: > OK for the C-family changes? OK. > +When @var{nullability kind} is @var{"unspecified"} or @var{0}, nothing is I think you mean @code or @samp for the second and third @var on this line, they look like literal code not metasyntactic variables. Likewise

float.h: C2x *_IS_IEC_60559 macros

2020-11-13 Thread Joseph Myers
lt;https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557136.html> (pending review), there are no actual dependencies between the patches; new tests are named to avoid conflicts with the tests added in that patch. gcc/c-family/ 2020-11-13 Joseph Myers * c-c

c: C2x binary constants

2020-11-13 Thread Joseph Myers
. Bootstrapped with no regressions for x86_64-pc-linux-gnu. Applied to mainline. gcc/testsuite/ 2020-11-13 Joseph Myers * gcc.dg/binary-constants-2.c, gcc.dg/binary-constants-3.c, gcc.dg/system-binary-constants-1.c: Update expected diagnostics. * gcc.dg/c11-binary

float.h: Handle C2x __STDC_WANT_IEC_60559_EXT__

2020-11-13 Thread Joseph Myers
not controlled by a feature test macro at all. Thus, add a check of __STDC_WANT_IEC_60559_EXT__ for CR_DECIMAL_DIG in float.h, the only case of this change relevant to GCC. Bootstrapped with no regressions for x86_64-pc-linux-gnu. OK to commit? gcc/ 2020-11-14 Joseph Myers * ginclude

Re: [PATCH][RFC] Make mingw-w64 printf/scanf attribute alias to ms_printf/ms_scanf only for C89

2020-11-13 Thread Joseph Myers
On Fri, 13 Nov 2020, Liu Hao via Gcc-patches wrote: > 在 2020/11/13 2:46, Joseph Myers 写道: > > I'd expect these patches to include updates to the gcc.dg/format/ms_*.c > > tests to reflect the changed semantics (or new tests there if some of the > > changes don'

Ping^3 Re: float.h: C2x NaN and Inf macros

2020-11-16 Thread Joseph Myers
Ping^3. This patch is still pending review (the DFP sNaN followup has been approved). (The independent C2x patches and

Re: [C PATCH RFC] Drop qualifiers during lvalue conversion

2020-11-16 Thread Joseph Myers
On Sun, 15 Nov 2020, Uecker, Martin wrote: > > I think it might be safest to avoid doing any conversion in the case where  > > the value is still of array type at this point (C90 non-lvalue arrays). > > I added a test for arrays, but I am not sure what effect it has. > What would be C90 non-lvalu

Re: [PATCH][driver] Don't add suffix for non-files

2020-11-16 Thread Joseph Myers
On Tue, 27 Oct 2020, Tamar Christina via Gcc-patches wrote: > Hi All, > > This patch fixes an issue where on systems that are > HAVE_TARGET_EXECUTABLE_SUFFIX the driver calls convert_filename in order to > add the suffix to the filename. However while it excludes `-` it doesn't > exclude the nul

Re: [PATCH] Practical Improvement to libgcc Complex Divide

2020-11-16 Thread Joseph Myers
On Tue, 8 Sep 2020, Patrick McGehearty via Gcc-patches wrote: > This project started with an investigation related to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59714. Study of Beebe[1] > provided an overview of past and recent practice for computing complex > divide. The current glibc implem

Add rough documentation of using git with GCC

2020-01-10 Thread Joseph Myers
I've applied this patch to add very preliminary documentation based on the corresponding SVN documentation. It is deliberately not linked to from anywhere, and does not yet include the list of branches from svn.html (which is very out of date regarding what branches are actually active). I adv

Re: Add rough documentation of using git with GCC

2020-01-10 Thread Joseph Myers
On Fri, 10 Jan 2020, Joseph Myers wrote: > In gitwrite.html: the various custom setup of checkouts for which scripts > have been posted, including usage of branches not fetched by default; an > actual example commit session should be included like the one in > svnwrite.html; m

Re: Add rough documentation of using git with GCC

2020-01-12 Thread Joseph Myers
On Fri, 10 Jan 2020, Joseph Myers wrote: > And we should also mention configuring your email address for git, if you > haven't used git on that system before or the default address you've > configured for git isn't the one you want for GCC commits. I've now applie

Replace update_version_svn with update_version_git

2020-01-13 Thread Joseph Myers
(since unlike in SVN, any commit to a branch conflicts with pushing a DATESTAMP update on that branch, whereas in SVN only a commit to the same file would conflict). The script does repeat the pull immediately before updating DATESTAMP on each branch to reduce that window. 202

Update gcc_release for move to git

2020-01-13 Thread Joseph Myers
eases are first built from git. Committed. 2020-01-13 Joseph Myers * gcc_release: Use git instead of SVN. * crontab: Update gcc_release calls. diff --git a/maintainer-scripts/crontab b/maintainer-scripts/crontab index f064d6fb45e..0cf342fdf3a 100644 --- a/maintainer-scripts/cr

Re: Update gcc_release for move to git

2020-01-13 Thread Joseph Myers
I've now also copied the latest gcc_release version to GCC 9 and 8 branches, since the git support will be needed there for future releases from those branches. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Clean up references to Subversion in documentation sources.

2020-01-13 Thread Joseph Myers
On Mon, 13 Jan 2020, Sandra Loosemore wrote: > On 1/13/20 7:02 AM, Eric S. Raymond wrote: > > Clean up references to SVN in in the GCC docs, redirecting to Git > > documentation as appropriate. > > This is OK, although the set of changes for the libstdc++ manual like this > gave me pause: I thin

Fix handling of overflow in C casts in integer constant expressions (PR c/93241)

2020-01-13 Thread Joseph Myers
e and call note_integer_operands as needed. Bootstrapped with no regressions for x86_64-pc-linux-gnu. Applied to mainline. Will backport to GCC 9 and 8 branches. gcc/c: 2020-01-13 Joseph Myers PR c/93241 * c-typeck.c (build_c_cast): Check for expressions with in

Replace update_web_docs_svn with update_web_docs_git

2020-01-13 Thread Joseph Myers
This patch replaces the update_web_docs_svn script, that updates online documentation from its sources in the GCC repository, run once a day from cron, with update_web_docs_git. Applied to mainline. 2020-01-13 Joseph Myers * update_web_docs_git: New file

Re: Replace update_web_docs_svn with update_web_docs_git

2020-01-13 Thread Joseph Myers
I've also applied this corresponding web page update. diff --git a/htdocs/releasing.html b/htdocs/releasing.html index 5d08550c..48853f9c 100644 --- a/htdocs/releasing.html +++ b/htdocs/releasing.html @@ -89,9 +89,9 @@ the main web page, and add a proper news item there as well. and add a link f

Re: Replace update_web_docs_svn with update_web_docs_git

2020-01-13 Thread Joseph Myers
On Mon, 13 Jan 2020, Jonathan Wakely wrote: > On 13/01/20 17:46 +0000, Joseph Myers wrote: > > This patch replaces the update_web_docs_svn script, that updates > > online documentation from its sources in the GCC repository, run once > > a day from cron, with update_web_docs_

Re: [PATCH] contrib: git descr/undescr aliases

2020-01-14 Thread Joseph Myers
On Tue, 14 Jan 2020, Roman Zhuykov wrote: > PS. We at ISPRAS see that for ~28 hours (11 Jan 2020, 18:00 UTC - 12 Jan 2020, > 22:00 UTC) our servers haven't received any gcc mailing list letters, but they > are available at https://gcc.gnu.org/ml/ archives (totally 6 mails on gcc@ and > 16 on gcc-p

Re: Fix for LTO compromised autoconf test in libiberty

2020-01-14 Thread Joseph Myers
My preference is still what I said in : either eliminate C alloca from libiberty, or don't build it with any compiler defining __GNUC__. I'd be surprised if there are host compilers that build libiberty, have the relevant optimizations

Correct git config command syntax

2020-01-14 Thread Joseph Myers
There is no --set option, git config sets variables without such an option. Committed. diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index 85a0da2d..f420fe22 100644 --- a/htdocs/gitwrite.html +++ b/htdocs/gitwrite.html @@ -78,7 +78,7 @@ git clone git+ssh://username@gcc.gnu.org/git/gcc.

Give example of error message when pushing to a branch with other changes

2020-01-14 Thread Joseph Myers
Giving explicit example of git messages seems helpful for novice users to understand when they are in a particular situation for which instructions are given. Committed. diff --git a/htdocs/gitwrite.html b/htdocs/gitwrite.html index f420fe22..e55cfa92 100644 --- a/htdocs/gitwrite.html +++ b/htdoc

Remove warning at top of git web pages

2020-01-14 Thread Joseph Myers
Although the documentation is still a work in progress, with various forms of git usage (e.g. contrib/gcc-git-customization.sh) not yet documented and development branches not yet listed on git.html as they are on svn.html, the warning about the conversion still being in progress is no longer accur

Say more about conflict messages on git pull

2020-01-14 Thread Joseph Myers
Give an example of the message you get for such a conflict, and discuss options for keeping local changes when pulling. Committed. diff --git a/htdocs/git.html b/htdocs/git.html index 70cc7b73..725bd81c 100644 --- a/htdocs/git.html +++ b/htdocs/git.html @@ -95,13 +95,30 @@ is: Autoconf, Bison, Xg

Fix setting of DECL_CONTEXT in pushdecl (PR c/93072)

2020-01-14 Thread Joseph Myers
, the two are equivalent.) Bootstrapped with no regressions for x86_64-pc-linux-gnu. Applied to mainline. Will backport to GCC 9 and 8 branches. gcc/c: 2020-01-15 Joseph Myers PR c/93072 * c-decl.c (pushdecl): Use TREE_PUBLIC, not DECL_EXTERNAL, to determine whether to

Re: [patch] contrib: Don't add push rules for personal and vendor spaces.

2020-01-15 Thread Joseph Myers
A reasonable replacement for those push rules might be command aliases (e.g. "git upush " to push the user branch ). -- Joseph S. Myers jos...@codesourcery.com

Copy list of development branches from svn.html into git.html

2020-01-16 Thread Joseph Myers
This patch makes a start on making the branch information from svn.html available in git.html. The list is copied, some notes added on devel/, refs/dead/heads/ and refs/vendors/ naming, and inactive branches from the general section (ones not present in refs/heads/devel/, automatically moved to re

Re: [PATCH] Fix ICE caused by swallowing a token in c_parser_consume_token

2020-01-16 Thread Joseph Myers
Thanks, patch committed. -- Joseph S. Myers jos...@codesourcery.com

Re: Copy list of development branches from svn.html into git.html

2020-01-16 Thread Joseph Myers
On Fri, 17 Jan 2020, Jakub Jelinek wrote: > On Thu, Jan 16, 2020 at 11:22:15PM +0000, Joseph Myers wrote: > > Committed. I think the main remaining things that need work in our git > > documentation on the website are: > > Shouldn't we move some of the branches

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-01-16 Thread Joseph Myers
On Thu, 16 Jan 2020, Alexandre Oliva wrote: > And here's a followup that fixes a limitation (bug?) in libiberty that > was hit when I attempted a last-minute simplification in lto-wrapper. > > Regstrapped separately on x86_64-linux-gnu. Ok to install? > > > [libiberty] output empty args as a p

Re: limit on emails for merge commits.

2020-01-16 Thread Joseph Myers
On Fri, 17 Jan 2020, Iain Sandoe wrote: > So I know that the policy is under review (and agree, from my PoV, that > something that represents these in a similar way to the SVN single mail > containing all the changes is probably optimum). > > However, right now I’m stuck - and really want to get

<    1   2   3   4   5   6   7   8   9   10   >