On Thu, 14 Nov 2019, Maciej W. Rozycki wrote:

>  Questions, comments, OK to apply?

1. This needs documentation in install.texi.

2. A common macro in config/ would be better than duplicating code in each 
configure.ac file.

3. To confirm (this should be made clear in the documentation), this is 
nonsensical given --enable-version-specific-runtime-libs?  If so, maybe 
the configure macro should give an error for the combination if possible.

4. How does this interact with sysroot suffixes (again, this should be 
made clear in the documentation)?

5. With this option, does the multilib OS directory (e.g. "../lib64") get 
used for anything at all outside the sysroot?  If not, is it valid with 
this option to have the same value of that directory for more than one 
multilib (that use different sysroot suffixes)?

(The basic complication in configurations with multiple sysroots is that 
the multilib OS directory currently gets used outside the sysroot, so 
needs to be unique.  But you also want a version that's only unique inside 
the sysroot - if you have sysroots for different CPU variants, each should 
have libraries in e.g. lib64 inside that sysroot.  At present, in such 
cases, you need to set STARTFILE_PREFIX_SPEC for the libraries to be found 
at link time inside the sysroot; see 
<https://gcc.gnu.org/ml/gcc/2016-12/msg00013.html> for some commentary on 
that.)

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to