Re: [PATCH] c-c++-common/Wrestrict.c: fix some typos and enable for LLP64

2024-03-02 Thread Jonathan Yong
On 2/15/24 14:08, Jonathan Yong wrote: Attached patch OK? Copy/pasted for review convenience. Ping.

Re: [PATCH] c-c++-common/Wrestrict.c: fix some typos and enable for LLP64

2024-03-18 Thread Jonathan Yong
On 3/17/24 17:38, Mike Stump wrote: On Feb 15, 2024, at 6:08 AM, Jonathan Yong wrote: Attached patch OK? Ok. Copy/pasted for review convenience. diff --git a/gcc/testsuite/c-c++-common/Wrestrict.c b/gcc/testsuite/c-c++-common/Wrestrict.c index 4d005a618b3..57a3f67e21e 100644 --- a/gcc

[PATCH] Simplify \r handling

2024-03-30 Thread Jonathan Yong
Simplify \r checking with regex globs. Signed-off-by: Jonathan Yong <10wa...@gmail.com> gcc/testsuite * g++.dg/contracts/contracts14.C: simplify \r regex. * g++.dg/contracts/contracts15.C: ditto * g++.dg/contracts/contracts16.C: ditto * g++.dg/coro

[PATCH] Change gcc/ira-conflicts.cc build_conflict_bit_table to use size_t/%zu

2024-02-01 Thread Jonathan Yong
0; i < ira_max_point; i++)From 48861b8578526ac199b123ff71af8f9778c396c3 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Thu, 1 Feb 2024 12:35:52 + Subject: [PATCH] PR target/43613: use %zu for build_conflict_bit_table LLP64 platforms like uses 32bit for long

Re: [PATCH] Change gcc/ira-conflicts.cc build_conflict_bit_table to use size_t/%zu

2024-02-01 Thread Jonathan Yong
On 2/1/24 13:06, Xi Ruoyao wrote: On Thu, 2024-02-01 at 14:01 +0100, Jakub Jelinek wrote: On Thu, Feb 01, 2024 at 12:45:31PM +, Jonathan Yong wrote: Attached patch OK? Copied inline for review convenience. No, I think e.g. AIX doesn't support the z modifier. I don't see %zd o

Re: [PATCH] Change gcc/ira-conflicts.cc build_conflict_bit_table to use size_t/%zu

2024-02-01 Thread Jonathan Yong
set_words * ira_objects_num * sizeof (IRA_INT_TYPE))); objects_live = sparseset_alloc (ira_objects_num); for (i = 0; i < ira_max_point; i++)From ab44628feca0b200aaaa2d3344af1a96cb1437c0 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Thu, 1 F

Re: [PATCH] Change gcc/ira-conflicts.cc build_conflict_bit_table to use size_t/%zu

2024-02-01 Thread Jonathan Yong
On 2/1/24 15:25, Jakub Jelinek wrote: On Thu, Feb 01, 2024 at 03:55:51PM +0100, Jakub Jelinek wrote: No, besides the formatting being incorrect both in ChangeLog and in the patch, this pessimizes ILP32 hosts unnecessarily. So like this instead? 2024-02-01 Jakub Jelinek * hwint.h (

Re: [PATCH] Change gcc/ira-conflicts.cc build_conflict_bit_table to use size_t/%zu

2024-02-02 Thread Jonathan Yong
On 2/1/24 15:33, Jonathan Yong wrote: On 2/1/24 15:25, Jakub Jelinek wrote: On Thu, Feb 01, 2024 at 03:55:51PM +0100, Jakub Jelinek wrote: No, besides the formatting being incorrect both in ChangeLog and in the patch, this pessimizes ILP32 hosts unnecessarily. So like this instead? 2024-02

[PATCH] coreutils-sum-pr108666.c: fix spurious LLP64 warnings

2024-02-02 Thread Jonathan Yong
;From 54731e86e4bdce03ef4a722860ea8cee931ec127 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Fri, 2 Feb 2024 23:47:47 + Subject: [PATCH] coreutils-sum-pr108666.c: fix spurious LLP64 warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

Re: [PATCH] libstdc++: /dev/null is not accessible on Windows

2024-02-06 Thread Jonathan Yong
On 2/5/24 19:38, Jonathan Wakely wrote: On Mon, 5 Feb 2024, 19:07 Torbjörn SVENSSON, wrote: Ok for trunk and releases/gcc-13? OK, thanks Done, pushed to master and releases/gcc-13.

Re: Ping: Re: [PATCH] libgcc: fix SEH C++ rethrow semantics [PR113337]

2024-02-06 Thread Jonathan Yong
On 2/6/24 05:31, NightStrike wrote: On Mon, Feb 5, 2024, 06:53 Matteo Italia wrote: Il 31/01/24 04:24, LIU Hao ha scritto: 在 2024-01-31 08:08, Jonathan Yong 写道: On 1/24/24 15:17, Matteo Italia wrote: Ping! That's a one-line fix, and you can find all the details in the bugzilla entry.

Re: [PATCH] coreutils-sum-pr108666.c: fix spurious LLP64 warnings

2024-02-10 Thread Jonathan Yong
On 2/2/24 23:55, Jonathan Yong wrote: Attached patch OK? Fixes the following warnings: coreutils-sum-pr108666.c:17:1: warning: conflicting types for built-in function ‘memcpy’; expected ‘void *(void *, const void *, long long unsigned int)’ [-Wbuiltin-declaration-mismatch]    17 | memcpy(void

Re: [PATCH] coreutils-sum-pr108666.c: fix spurious LLP64 warnings

2024-02-14 Thread Jonathan Yong
On 2/14/24 13:55, David Malcolm wrote: On Fri, 2024-02-02 at 23:55 +, Jonathan Yong wrote: Attached patch OK? Fixes the following warnings: Thanks; looks good to me. Dave Thanks, pushed to master branch.

[PATCH] c-c++-common/Wrestrict.c: fix some typos and enable for LLP64

2024-02-15 Thread Jonathan Yong
d + i, 5); /* { dg-warning "accessing 5 bytes at offsets 0 and \\\[2147483645, 2147483647] overlaps 3 bytes at offset 2147483642" "ILP32" { target ilp32 } } */ T (d + i, d, 5); /* { dg-warning "accessing 5 bytes at offsets \\\[2147483645, 2147483647] and 0 overlaps 3 b

Re: [PATCH] libgcc: fix Win32 CV abnormal spurious wakeups in timed wait [PR113850]

2024-02-16 Thread Jonathan Yong
On 2/10/24 10:10, Matteo Italia wrote: Il 09/02/24 15:18, Matteo Italia ha scritto: The Win32 threading model uses __gthr_win32_abs_to_rel_time to convert the timespec used in gthreads to specify the absolute time for end of the condition variables timed wait to a milliseconds value relative to

Re: [PATCH] libgcc: fix Win32 CV abnormal spurious wakeups in timed wait [PR113850]

2024-02-19 Thread Jonathan Yong
On 2/19/24 13:48, Matteo Italia wrote: Il 17/02/24 01:24, Jonathan Yong ha scritto: On 2/10/24 10:10, Matteo Italia wrote: Il 09/02/24 15:18, Matteo Italia ha scritto: The Win32 threading model uses __gthr_win32_abs_to_rel_time to convert the timespec used in gthreads to specify the absolute

Re: [RFC] Either fix or disable SME feature for `aarch64-w64-mingw32` target?

2024-01-10 Thread Jonathan Yong
On 1/9/24 19:37, Radek Barton wrote: Hello. I forgot to add the target maintainers to the CC. My apologies for that. Furthermore, I am adding also relevant changes in `libgcc/config/aarch64/lse.S` file to the patch. Originally we wanted to submit those changes separately but after the feedbac

Re: Ping: Re: [PATCH] libgcc: fix SEH C++ rethrow semantics [PR113337]

2024-01-30 Thread Jonathan Yong
On 1/24/24 15:17, Matteo Italia wrote: Ping! That's a one-line fix, and you can find all the details in the bugzilla entry. Also, I can provide executables built with the affected toolchains, demonstrating the problem and the fix. Thanks, Matteo I was away last week. LH, care to comment? Ch

[PATCH] uninit-pr108968-register.c: use __UINTPTR_TYPE__ for LLP64

2024-01-31 Thread Jonathan Yong
Ensure sp variable is long enough by using __UINTPTR_TYPE__ for rsp. Attached patch okay? Changes unsigned long to __UINTPTR_TYPE__.From 8b5e79e1345d99ec6d3595013a20a9c672edb403 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 31 Jan 2024 13:31:30 + Subject:

Re: [PATCH] uninit-pr108968-register.c: use __UINTPTR_TYPE__ for LLP64

2024-01-31 Thread Jonathan Yong
On 1/31/24 13:52, Richard Biener wrote: On Wed, Jan 31, 2024 at 2:39 PM Jonathan Yong <10wa...@gmail.com> wrote: Ensure sp variable is long enough by using __UINTPTR_TYPE__ for rsp. Attached patch okay? Changes unsigned long to __UINTPTR_TYPE__. OK. Thanks, pushed to master branch.

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-21 Thread Jonathan Yong
On 11/21/23 18:07, Costas Argyris wrote: This patch makes the inclusion of the utf8 manifest on the mingw hosts optional by introducing the configure option --disable-win32-utf8-manifest (has no effect on non-mingw hosts). Bootstrapped OK on i686-w64-mingw32 and x86_64-w64-mingw32 with and witho

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-22 Thread Jonathan Yong
On 11/22/23 12:34, Costas Argyris wrote: Attached a new patch. A couple things to note: 1) I changed your host_extra_objs=utf8-mingw32.o to host_extra_objs_mingw=utf8-mingw32.o to match the other two, since I believe that's what you meant. 2) This approach has the complication that the var

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-29 Thread Jonathan Yong
On 11/29/23 09:36, Costas Argyris wrote: Thanks. Eric, who originally reported the issue with the Ada compiler dropping a feature due to the utf8 manifest, is asking for this to be backported onto the 13 branch here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70#c13 If you agree with thi

Re: [PATCH] Fix MinGW option -mcrtdll=

2024-07-07 Thread Jonathan Yong
On 7/5/24 09:53, Pali Rohár wrote: On Monday 24 June 2024 10:03:26 Jonathan Yong wrote: On 6/23/24 16:40, Pali Rohár wrote: Add missing msvcr40* and msvcrtd* cases to CPP_SPEC and document missing _UCRT macro and msvcr71* case. Fixes commit 453cb585f0f8673a5d69d1b420ffd4b3f53aca00. Thanks

Re: [PATCH] Do not use caller-saved registers for COMDAT functions

2024-07-15 Thread Jonathan Yong
On 7/15/24 09:04, LIU Hao wrote: diff --git a/gcc/varasm.cc b/gcc/varasm.cc index 747f74ba1c0..b67a0b524db 100644 --- a/gcc/varasm.cc +++ b/gcc/varasm.cc @@ -7805,6 +7805,8 @@ decl_binds_to_current_def_p (const_tree decl) for all other declaration types. */ if (DECL_WEAK (decl)) r

Re: [PATCH] Do not use caller-saved registers for COMDAT functions

2024-07-18 Thread Jonathan Yong
On 7/15/24 12:45, Jonathan Yong wrote: On 7/15/24 09:04, LIU Hao wrote: diff --git a/gcc/varasm.cc b/gcc/varasm.cc index 747f74ba1c0..b67a0b524db 100644 --- a/gcc/varasm.cc +++ b/gcc/varasm.cc @@ -7805,6 +7805,8 @@ decl_binds_to_current_def_p (const_tree decl)   for all other declaration

Re: [PATCH v2] Define which threading model is in use on Windows

2024-05-27 Thread Jonathan Yong
On 5/27/24 05:16, Julian Waters wrote: Hi all, Please review a trivial change that defines which threading model is used on Windows, so applications can check it. This is also useful for system headers, since some headers should be switched off if pthread is the threading model (Currently they a

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-05 Thread Jonathan Yong
On 6/5/24 06:01, Uros Bizjak wrote: On Tue, Jun 4, 2024 at 10:10 PM Evgeny Karpov wrote: Richard and Uros, could you please review the changes for v2? LGTM for the generic x86 part, OS-specific part (cygming) should also be reviewed by OS port maintainer (CC'd). Thanks, Uros. Where is HA

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-07 Thread Jonathan Yong
On 6/6/24 09:23, Evgeny Karpov wrote: Thursday, June 6, 2024 1:42 AM Jonathan Yong <10wa...@gmail.com> wrote: Where is HAVE_64BIT_POINTERS used? Sorry, it was missed in the posted changes for review. Regards, Evgeny diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/min

Re: [PATCH v3 1/3] diagnostics: Enable escape sequence processing on windows consoles

2024-06-15 Thread Jonathan Yong
On 6/3/24 17:07, Peter Damianov wrote: Since windows 10 release v1511, the windows console has had support for VT100 escape sequences. We should try to enable this, and utilize it where possible. Thank you. Patches look good to me, pushed to master branch.

Re: [PATCH] Fix MinGW option -mcrtdll=

2024-06-24 Thread Jonathan Yong
On 6/23/24 16:40, Pali Rohár wrote: Add missing msvcr40* and msvcrtd* cases to CPP_SPEC and document missing _UCRT macro and msvcr71* case. Fixes commit 453cb585f0f8673a5d69d1b420ffd4b3f53aca00. Thanks, pushed to master branch.

Re: [PATCH v2] diagnostics: Fix compile error for MinGW <7.0

2024-10-07 Thread Jonathan Yong
On 9/28/24 12:49, Torbjörn SVENSSON wrote: Ok for trunk? Changes since v1: - Updated the commit message to mention the actual build error. - Switch to checking the required define rather than the version number of MinGW. Patch looks OK to me. Thanks for the reminder.

Re: [PATCH] i386: Implement Thread Local Storage on Windows

2025-02-19 Thread Jonathan Yong
On 2/20/25 7:16 AM, Julian Waters wrote: Patch with the amendments to the commit message as requested. best regards, Julian From e8e742b1f809af2c1a9697c31335e184738b258a Mon Sep 17 00:00:00 2001 From: Julian Waters Date: Tue, 15 Oct 2024 20:56:22 +0800 Subject: [PATCH] Implement Windows TLS M

[PATCH] deref-before-check-pr113253.c: Fix bogus warnings on lp32

2025-04-07 Thread Jonathan Yong
Attached patch OK for master branch? Will push soon if there are no objections. From 66c30c0db9560af4f61ebda0742d0eb7da45f474 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Mon, 7 Apr 2025 15:40:05 + Subject: [PATCH] deref-before-check-pr113253.c: Fix bogus warni

[PATCH] bf-ms-attrib.c: Fix expected struct size

2025-04-09 Thread Jonathan Yong
Attached patch OK for master branch? Gcc produced struct sizes match those of MSVC when __ms_struct__ is used, both producing a layout size of 12. Will push soon if there are no objections. From 522b0aa6473e109becc45e57255f14e23fc6a404 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <1

Re: [PATCH] deref-before-check-pr113253.c: Fix bogus warnings on lp32

2025-04-09 Thread Jonathan Yong
On 4/7/25 3:48 PM, Jonathan Yong wrote: Attached patch OK for master branch? Will push soon if there are no objections. Pushed to master branch.

[PATCH] realloc-1.c: accept long long in warning for llp64

2025-04-10 Thread Jonathan Yong
Attached patch OK for master branch? Will push soon if there are no objections. From 075f2ab502ca7291887c1fa75b5351fb0cbad013 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 9 Apr 2025 14:21:22 + Subject: [PATCH] realloc-1.c: accept long long in warning for

[PATCH] gcc.dg/analyzer/torture/switch-3.c: fix llp64 warnings

2025-03-29 Thread Jonathan Yong
Patch OK for master branch? gcc/testsuite/ChangeLog: * gcc.dg/analyzer/torture/switch-3.c: fix llp64 warnings diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/switch-3.c b/gcc/testsuite/gcc.dg/analyzer/torture/switch-3.c index 57b8acdb292..b40be664d38 100644 --- a/gcc/testsuite/gcc.dg/analy

Re: [PATCH] gcc/mingw: Align `.refptr.` to 8-byte boundaries for 64-bit targets

2025-03-29 Thread Jonathan Yong
On 3/29/25 5:56 PM, LIU Hao wrote: This is a minor change, bootstrapped on x86_64-w64-mingw32. Thanks, applied to master branch as obvious/trivial.

Re: [PATCH] gcc.dg/analyzer/torture/switch-3.c: fix llp64 warnings

2025-04-02 Thread Jonathan Yong
On 3/30/25 2:52 AM, Jonathan Yong wrote: Patch OK for master branch? gcc/testsuite/ChangeLog:   * gcc.dg/analyzer/torture/switch-3.c: fix llp64 warnings diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/switch-3.c b/gcc/ testsuite/gcc.dg/analyzer/torture/switch-3.c index 57b8acdb292

Re: [PATCH] realloc-1.c: accept long long in warning for llp64

2025-04-10 Thread Jonathan Yong
On 4/9/25 2:27 PM, Jonathan Yong wrote: Attached patch OK for master branch? Will push soon if there are no objections. Pushed to master branch.

Re: [PATCH] bf-ms-attrib.c: Fix expected struct size

2025-04-10 Thread Jonathan Yong
On 4/9/25 2:35 PM, Jonathan Yong wrote: Attached patch OK for master branch? Gcc produced struct sizes match those of MSVC when __ms_struct__ is used, both producing a layout size of 12. Will push soon if there are no objections. Pushed to master branch.

[PATCH] Wbuiltin-declaration-mismatch-4.c: accept long long in warning for llp64

2025-04-12 Thread Jonathan Yong
Attached patch OK for master branch? Will push soon if there are no objections. From a74ce95293fc310557047fa5da6fb9d55e760f61 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Sun, 13 Apr 2025 02:41:36 + Subject: [PATCH] Wbuiltin-declaration-mismatch-4.c: accept lon

Re: [PATCH] Wbuiltin-declaration-mismatch-4.c: accept long long in warning for llp64

2025-04-15 Thread Jonathan Yong
On 4/13/25 2:46 AM, Jonathan Yong wrote: Attached patch OK for master branch? Will push soon if there are no objections. Pushed to master branch.

[PATCH] ref-temp1.C: Enable some tests for PE targets

2025-04-15 Thread Jonathan Yong
Attached patch OK for master branch? Will push soon if there are no objections. From b329d899d07cda78bc44d88f81bdf10d5e2db302 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Tue, 15 Apr 2025 11:41:36 + Subject: [PATCH] ref-temp1.C: Enable some tests for PE targets

Re: [PATCH] ref-temp1.C: Enable some tests for PE targets

2025-04-18 Thread Jonathan Yong
On 4/15/25 11:46 AM, Jonathan Yong wrote: Attached patch OK for master branch? Will push soon if there are no objections. Pushed to master branch.

[PATCH] Fix size_t in id-15.c and infoleak-net-ethtool-ioctl.c for llp64

2025-04-24 Thread Jonathan Yong
7b1176589124eb25bf23ec0c05faa947aaabfdbf Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Thu, 24 Apr 2025 07:42:17 + Subject: [PATCH] Fix size_t in id-15.c and infoleak-net-ethtool-ioctl.c for llp64 Use __SIZE_TYPE__ for size_t types so that it works for llp64. Signed-off-by: Jonathan Yong

Re: [PATCH] libiberty: On Windows pass a >32k cmdline through a response file.

2023-06-05 Thread Jonathan Yong via Gcc-patches
On 5/23/23 08:21, Jonathan Yong wrote: On 5/22/23 13:25, Costas Argyris wrote: Currently on Windows, when CreateProcess is called with a command-line that exceeds the 32k Windows limit, we get a very bad error: "CreateProcess: No such file or directory" This patch detects the case

Re: [PATCH] libiberty: On Windows pass a >32k cmdline through a response file.

2023-06-05 Thread Jonathan Yong via Gcc-patches
On 6/5/23 09:22, Costas Argyris wrote: Thanks, here is the follow up patch for a couple typos in the same file. Thanks, pushed as obvious.

Re: [PATCH] Add MinGW option -mcrtdll= for choosing C RunTime DLL library

2023-06-11 Thread Jonathan Yong via Gcc-patches
On 5/27/23 10:14, Pali Rohár wrote: It adjust preprocess, compile and link flags, which allows to change default -lmsvcrt library by another provided by MinGW runtime. gcc/ * config/i386/mingw-w64.h (CPP_SPEC): Adjust for -mcrtdll=. (REAL_LIBGCC_SPEC): New define. * config/i386

Re: [PATCH] Add MinGW option -mcrtdll= for choosing C RunTime DLL library

2023-06-12 Thread Jonathan Yong via Gcc-patches
On 6/12/23 01:26, LIU Hao wrote: 在 2023/6/12 07:08, Jonathan Yong 写道: +preprocessor is done. MinGW import library @code{msvcrt} is just a +symlink (or file copy) to the other MinGW CRT import library I suggest a change to this line:    symlink to (or a copy of) another MinGW CRT import

Re: [PATCH v2] Add MinGW option -mcrtdll= for choosing C RunTime DLL library

2023-06-16 Thread Jonathan Yong via Gcc-patches
On 6/14/23 16:09, Pali Rohár wrote: It adjust preprocess, compile and link flags, which allows to change default -lmsvcrt library by another provided by MinGW runtime. gcc/ * config/i386/mingw-w64.h (CPP_SPEC): Adjust for -mcrtdll=. (REAL_LIBGCC_SPEC): New define. * config/i386

Re: [Patch] builtin-declaration-mismatch-7: fix LLP64 targets

2023-02-13 Thread Jonathan Yong via Gcc-patches
On 2/13/23 06:28, Jeff Law wrote: On 2/11/23 01:33, Jonathan Yong via Gcc-patches wrote: Attached patch OK? 0001-builtin-declaration-mismatch-7-fix-LLP64-targets.patch  From 3ba6812366e837a87c15360e83d1f72ffdd29684 Mon Sep 17 00:00:00 2001 From: Jonathan Yong<10wa...@gmail.com> Dat

Re: [Patch] pr65658.c: fix excess warnings on LLP64 targets

2023-02-13 Thread Jonathan Yong via Gcc-patches
On 2/13/23 07:04, Jeff Law wrote: On 1/28/23 11:16, Jonathan Yong via Gcc-patches wrote: Patch OK? gcc/testsuite/ChangeLog:  * gcc.dg/pr65658.c: fix LLP64 test. 0001-pr65658.c-fix-excess-warnings-on-LLP64-targets.patch  From bd2634e2795723f290dcf4bbb06e70fb6ca6af51 Mon Sep 17 00:00:00

[Patch] More LLP64 fixes and __PIC__ values fixes for PE targets

2023-02-14 Thread Jonathan Yong via Gcc-patches
Attached patches OK?From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Tue, 14 Feb 2023 10:37:03 + Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE targets gcc/testsuite/ChangeLog: * pic-2.c: fix ex

[Patch] harden-sls-6.c: fix warning on LLP64

2023-02-15 Thread Jonathan Yong via Gcc-patches
gcc/testsuite/ChangeLog: * gcc.target/i386/harden-sls-6.c: fix warning on LLP64 targets. Attached patch OK?From c0572a1e95c6f569980d6b7454c8dc293f07389e Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 15 Feb 2023 13:42:12 + Subject: [PATCH]

Re: [PATCH] cygwin: Don't try to support multilibs [PR107998]

2023-02-22 Thread Jonathan Yong via Gcc-patches
On 2/22/23 09:25, Jakub Jelinek wrote: Hi! As discussed in the PR, t-cygwin-w64 file has been introduced in 2013 and has one important problem, two different multilib options -m64 and -m32, but MULTILIB_DIRNAMES with just one word in it. Before the genmultilib sanity checking was added, my under

Re: [PATCH] cygwin: Don't try to support multilibs [PR107998]

2023-02-22 Thread Jonathan Yong via Gcc-patches
On 2/22/23 09:25, Jakub Jelinek wrote: Hi! As discussed in the PR, t-cygwin-w64 file has been introduced in 2013 and has one important problem, two different multilib options -m64 and -m32, but MULTILIB_DIRNAMES with just one word in it. Before the genmultilib sanity checking was added, my under

[Patch] gcc.c-torture/compile/103818.c: enable for llp64 too

2023-02-25 Thread Jonathan Yong via Gcc-patches
Patch OK for master branch? I did not see any obvious issues to exclude LLP64 specifically.From 9c770936c4c6ffb59d15e5c1ce331494ba102250 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Sun, 26 Feb 2023 06:34:04 + Subject: [PATCH] gcc.c-torture/compile/103818.c:

[Patch] gcc.dg/overflow-warn-9.c: exclude from LLP64

2023-02-27 Thread Jonathan Yong via Gcc-patches
This test is for LP64 only, exclude LLP64 too. Patch OK?From fbc83ae10df1a0e10c302fb0fee13092eb65818e Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Mon, 27 Feb 2023 09:49:31 + Subject: [PATCH] gcc.dg/overflow-warn-9.c: exclude from LLP64 gcc/testsuite/Cha

[Patch] gcc.dg/memchr-3.c: fix for LLP64

2023-02-27 Thread Jonathan Yong via Gcc-patches
: Jonathan Yong <10wa...@gmail.com> Date: Mon, 27 Feb 2023 10:02:32 + Subject: [PATCH] gcc.dg/memchr-3.c: fix for LLP64 gcc/testsuite/ChangeLog: PR middle-end/97956 * gcc.dg/memchr-3.c (memchr): fix long to size_t in prototype. Signed-off-by: Jonathan Yong <10wa...@gmail.com> --- g

[Patch] c-c++-common/Warray-bounds.c: fix excess warnings on LLP64

2023-02-27 Thread Jonathan Yong via Gcc-patches
ay bounds of 'struct S16[][7]' [-Warray-bounds=] gcc/testsuite/ChangeLog: * c-c++-common/Warray-bounds.c: Fix excess warnings on LLP64.From 559c2ee7cf208227e8d6c4cf7106815e45b10590 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com

Re: [Patch] gcc.c-torture/compile/103818.c: enable for llp64 too

2023-02-27 Thread Jonathan Yong via Gcc-patches
On 2/28/23 02:10, Hans-Peter Nilsson wrote: On Sun, 26 Feb 2023, Jonathan Yong via Gcc-patches wrote: Patch OK for master branch? I did not see any obvious issues to exclude LLP64 specifically. I see "lp64 || lp64" in that patch (which should preferably have been sent inline, as i

Re: [Patch] gcc.dg/overflow-warn-9.c: exclude from LLP64

2023-02-28 Thread Jonathan Yong via Gcc-patches
On 2/28/23 03:06, Hans-Peter Nilsson wrote: On Mon, 27 Feb 2023, Jonathan Yong via Gcc-patches wrote: This test is for LP64 only, exclude LLP64 too. Patch OK? I may be confused, but you're not making use of the "llp64" effective target, there instead excluding/including lp64

Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64

2023-03-01 Thread Jonathan Yong via Gcc-patches
On 2/27/23 16:55, Richard Sandiford wrote: Jonathan Yong via Gcc-patches writes: Attached patch OK? gcc.dg/memchr-3.c: fix for LLP64 gcc/testsuite/ChangeLog: PR middle-end/97956 * gcc.dg/memchr-3.c (memchr): fix long to size_t in

Re: [Patch] harden-sls-6.c: fix warning on LLP64

2023-03-01 Thread Jonathan Yong via Gcc-patches
On 2/28/23 18:15, Jakub Jelinek wrote: On Wed, Feb 15, 2023 at 01:44:08PM +, Jonathan Yong via Gcc-patches wrote: gcc/testsuite/ChangeLog: * gcc.target/i386/harden-sls-6.c: fix warning on LLP64 targets. Attached patch OK? From c0572a1e95c6f569980d6b7454c8dc293f07389e

Re: [PATCH] gcc: Remove size limit of PCH for *-*-mingw32 hosts

2023-03-01 Thread Jonathan Yong via Gcc-patches
On 3/1/23 09:21, Richard Biener wrote: On Wed, Mar 1, 2023 at 9:52 AM NightStrike via Gcc-patches wrote: On Thu, Feb 16, 2023, 11:10 LIU Hao via Gcc-patches wrote: -- Best regards, LIU Hao Ping OK. Done, pushed to master branch.

Re: [Patch] gcc.dg/overflow-warn-9.c: exclude from LLP64

2023-03-02 Thread Jonathan Yong via Gcc-patches
On 3/2/23 10:44, Richard Sandiford wrote: diff --git a/gcc/testsuite/gcc.dg/overflow-warn-9.c b/gcc/testsuite/gcc.dg/overflow-warn-9.c index 57c0f17bc91..ae588bd8491 100644 --- a/gcc/testsuite/gcc.dg/overflow-warn-9.c +++ b/gcc/testsuite/gcc.dg/overflow-warn-9.c @@ -59,7 +59,8 @@ const struct Ty

Re: [Patch] gcc.dg/memchr-3.c: fix for LLP64

2023-03-02 Thread Jonathan Yong via Gcc-patches
On 3/2/23 10:46, Richard Sandiford wrote: diff --git a/gcc/testsuite/gcc.dg/memchr-3.c b/gcc/testsuite/gcc.dg/memchr-3.c index c38d9cf3349..af1b26ef3ae 100644 --- a/gcc/testsuite/gcc.dg/memchr-3.c +++ b/gcc/testsuite/gcc.dg/memchr-3.c @@ -6,7 +6,7 @@ typedef __INT8_TYPE__ int8_t; typedef __I

Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865]

2023-03-09 Thread Jonathan Yong via Gcc-patches
On 3/9/23 13:33, Costas Argyris wrote: Pinging the list and mingw maintainer. Analysis and pre-approval here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 Thanks, pushed to master branch.

Re: Patch ping: [PATCH] cygwin: Don't try to support multilibs [PR107998]

2023-03-10 Thread Jonathan Yong via Gcc-patches
On 3/10/23 09:37, Jakub Jelinek wrote: Hi! I'd like to ping this patch (as I wrote a week ago, NightStrike has tested it): Thanks, pushed to master branch.

Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets

2023-03-11 Thread Jonathan Yong via Gcc-patches
On 3/11/23 17:29, Jeff Law wrote: On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote: Attached patches OK? 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch  From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001 From: Jonathan Yong<10wa...@gmail.com>

Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets

2023-03-14 Thread Jonathan Yong via Gcc-patches
On 3/12/23 16:54, Jeff Law wrote: Windows code is effectively always PIC, since the PE loader can relocate it anywhere if the preferred address is already occupied. Patch still OK? Yes, still OK.  Just make the trivial ChangeLog adjustments. Done, pushed to master branch, thanks.

Re: [PATCH] libiberty: On Windows pass a >32k cmdline through a response file.

2023-05-23 Thread Jonathan Yong via Gcc-patches
On 5/22/23 13:25, Costas Argyris wrote: Currently on Windows, when CreateProcess is called with a command-line that exceeds the 32k Windows limit, we get a very bad error: "CreateProcess: No such file or directory" This patch detects the case where this would happen and writes the long command-

Re: [patch] Make -no-pie option work for native Windows

2021-08-11 Thread Jonathan Yong via Gcc-patches
On 8/11/21 2:21 PM, Eric Botcazou wrote: Hi, as already mentioned on the list, binutils 2.36 generates PIE executables by default on native Windows (because --dynamicbase is the default) so it makes sense to have a simple way to counter that and -no-pie seems appropriate, all the more so that it

[Patch] gcc.c-torture/execute: Fix tmpnam issue on Windows

2021-08-21 Thread Jonathan Yong via Gcc-patches
Attached patch OK? 2021-08-22 Jonathan Yong <10wa...@gmail.com> gcc/testsuite/ChangLog: * gcc.c-torture/execute/gcc_tmpnam.h: Fix tmpnam case on Windows where it can return a filename with "\" to indicate current directory. * gcc.c-torture/exe

Re: [Patch] gcc.c-torture/execute: Fix tmpnam issue on Windows

2021-08-22 Thread Jonathan Yong via Gcc-patches
On 8/23/21 1:07 AM, Jeff Law wrote: On 8/21/2021 9:10 PM, Jonathan Yong via Gcc-patches wrote: Attached patch OK? 2021-08-22  Jonathan Yong  <10wa...@gmail.com> gcc/testsuite/ChangLog: * gcc.c-torture/execute/gcc_tmpnam.h: Fix tmpnam case on Windows where it can return a fi

[Patch] Fix cygming-crtend.c build warning due to -Wprio-ctor-dtor

2021-08-25 Thread Jonathan Yong via Gcc-patches
: * doc/extend.texi: Add note about reserved priorities to the constructor attribute. From e9758ef8c03e617eafe13ca6512fd7cd0256abc7 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Wed, 25 Aug 2021 16:33:36 + Subject: [PATCH 1/2] cygming-crtend.c: fix

Re: [Patch] Fix cygming-crtend.c build warning due to -Wprio-ctor-dtor

2021-08-25 Thread Jonathan Yong via Gcc-patches
On 8/25/21 11:06 PM, Jeff Law wrote: On 8/25/2021 10:46 AM, Jonathan Yong via Gcc-patches wrote: Attached patches OK?     cygming-crtend.c: fix build warnings     libgcc/Changelog:     * config/i386/cygming-crtend.c: Fix register_frame_ctor     and register_frame_dtor

Re: [PATCH] testsuite: /dev/null is not accessible on Windows

2022-10-05 Thread Jonathan Yong via Gcc-patches
On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote: When running the DejaGNU testsuite on a toolchain built for native Windows, the path /dev/null can't be used to open a stream to void. On native Windows, the resource is instead named "nul". The error would look like this: c:/arm-11.3.re

Re: [PATCH] testsuite: /dev/null is not accessible on Windows

2022-10-05 Thread Jonathan Yong via Gcc-patches
On 10/5/22 09:34, Jonathan Yong wrote: On 9/29/22 17:38, Torbjörn SVENSSON via Gcc-patches wrote: When running the DejaGNU testsuite on a toolchain built for native Windows, the path /dev/null can't be used to open a stream to void. On native Windows, the resource is instead named "

Re: PING^1 [PATCH] testsuite: Windows reports errors with CreateProcess

2022-10-05 Thread Jonathan Yong via Gcc-patches
On 10/5/22 09:15, Torbjorn SVENSSON via Gcc-patches wrote: Hi, Ping, https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602541.html Kind regards, Torbjörn Looks good to me, pushed to master branch as fa8e3a055a082e38aeab2561a5016b01ebfd6ebd.

Re: Adding a new thread model to GCC

2022-10-14 Thread Jonathan Yong via Gcc-patches
On 10/11/22 13:22, LIU Hao wrote: 在 2022-10-10 23:56, LIU Hao 写道: 在 2022-10-04 20:44, LIU Hao 写道: Attached are revised patches. These are exported from trunk. Revised further. The patch for libgfortran has been committed to trunk today, so I include only the other two.    * In the second

Re: Adding a new thread model to GCC

2022-10-19 Thread Jonathan Yong via Gcc-patches
On 10/14/22 09:39, Jonathan Yong wrote: On 10/11/22 13:22, LIU Hao wrote: 在 2022-10-10 23:56, LIU Hao 写道: 在 2022-10-04 20:44, LIU Hao 写道: Attached are revised patches. These are exported from trunk. Revised further. The patch for libgfortran has been committed to trunk today, so I include

Re: [PATCH] libgcc: Update 'gthr-mcf.h' to include a dedicated header for libobjc

2022-10-22 Thread Jonathan Yong via Gcc-patches
On 10/22/22 11:54, LIU Hao wrote: This allows building libobjc and enabling Objective-C. Tested against GCC 12 branch on i686-w64-mingw32. Done, pushed to master branch.

Re: [PATCH] mingw32: Fix warning, update documentation

2022-09-08 Thread Jonathan Yong via Gcc-patches
On 9/8/22 11:02, Jan-Benedict Glaw wrote: Hi! The mingw32 port is the only port to have TARGET_OVERRIDES_FORMAT_ATTRIBUTES defined. When this macro is defined, it will never evaluate to NULL, so this check just leads to a warning: /usr/lib/gcc-snapshot/bin/g++ -fcf-protection -fno-PIE -c -DIN

Re: [PATCH] Remove size limit of PCH

2022-05-11 Thread Jonathan Yong via Gcc-patches
On 5/10/22 13:30, LIU Hao wrote: 在 2022-05-10 20:00, Xi Ruoyao 写道: On Tue, 2022-05-10 at 19:35 +0800, LIU Hao via Gcc-patches wrote: Subject: [PATCH] Remove size limit of PCH Make it "Remove size limit of PCH [PR14940]", so once it's committed a message will show up in bugzilla. Here is t

Re: [PATCH v2] libgcc: Expose the instruction pointer and stack pointer in SEH _Unwind_Backtrace

2020-11-02 Thread Jonathan Yong via Gcc-patches
On 9/8/20 12:21 PM, Martin Storsjö wrote: Previously, the SEH version of _Unwind_Backtrace did unwind the stack and call the provided callback function as intended, but there was little the caller could do within the callback to actually get any info about that particular level in the unwind. Se

Re: [PATCH] libstdc++: use lt_host_flags for libstdc++.la

2020-11-02 Thread Jonathan Yong via Gcc-patches
On 10/20/20 2:03 AM, Jonathan Yong wrote: On 9/16/20 1:16 PM, JonY wrote: For platforms like Mingw and Cygwin, cygwin refuses to generate the shared library without using -no-undefined. Attached patch makes sure the right flags are used, since libtool is already used to link libstdc++. Patch

Re: [PATCH v2] libgcc: Expose the instruction pointer and stack pointer in SEH _Unwind_Backtrace

2020-11-05 Thread Jonathan Yong via Gcc-patches
On 11/6/20 3:27 AM, Jeff Law wrote: On 11/2/20 5:05 AM, Kai Tietz via Gcc-patches wrote: Hello, as noone seems to be able to review this patch, I will do so, even if this is no longer a task of mine. The patch itself is reasonable and seems to fix a pending issue we have on CFA support. I had

Re: Fwd: libstdc++: Attempt to resolve PR83562

2020-11-06 Thread Jonathan Yong via Gcc-patches
On 11/6/20 8:34 AM, Martin Storsjö wrote: On Fri, 6 Nov 2020, Liu Hao via Gcc-patches wrote: 在 2020/10/29 下午3:56, Liu Hao 写道: I forward it here for comments. Basing on the behavior of both GCC and Clang, `__cxa_thread_atexit` is used to register the destructor of thread_local objects directl

[PATCH] libstdc++: exclude cygwin/mingw from relro linker test

2020-11-11 Thread Jonathan Yong via Gcc-patches
cygwin/mingw hosted linker may support multiple targets with ELF relro support. This breaks configure testing. Attached patch excludes cygwin/mingw PE format from relro linker flag. Patch OK? From a72f02aec065c312528e41e4243c702d7371b5ce Mon Sep 17 00:00:00 2001 From: Jonathan Yong <1

[PATCH][RFC] Make mingw-w64 printf/scanf attribute alias to ms_printf/ms_scanf only for C89

2020-11-12 Thread Jonathan Yong via Gcc-patches
is a solution to satisfy everyone, but at least this allows C99/C++11 compliant code to build again with -Werror. Comments? From 397097aba5a098f18da92704e9ca7560adb4f29c Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Thu, 12 Nov 2020 06:45:00 + Subject: [PATCH

Re: [PATCH][RFC] Make mingw-w64 printf/scanf attribute alias to ms_printf/ms_scanf only for C89

2020-11-15 Thread Jonathan Yong via Gcc-patches
On 11/14/20 12:29 PM, Liu Hao via Gcc-patches wrote: This is the third revision of my patch: 1. Two typos in the commit message have been fixed. 2. Support for `%a` and `%A` has been added. Documentation can be found on the same page in the commit message. 3. GCC will no longer warn about 'I

Re: [PATCH] libstdc++-v3: Check for TLS support on mingw

2021-08-31 Thread Jonathan Yong via Gcc-patches
On 8/31/21 9:02 AM, Jonathan Wakely wrote: It looks like my questions about this patch never got an answer, and it never got applied. Could somebody say whether TLS is enabled for native *-*-mingw* builds? If it is, then we definitely need to add GCC_CHECK_TLS to the cross-compiler config too.

Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h

2021-09-09 Thread Jonathan Yong via Gcc-patches
On 9/9/21 1:19 PM, Richard Biener wrote: The following removes the unused config/dbx.h file and removes the setting of PREFERRED_DEBUGGING_TYPE from dbxcoff.h which is overridden by all users (djgpp/mingw/cygwin) via either including config/i386/djgpp.h or config/i386/cygming.h There are still c

Re: Adding a new thread model to GCC

2022-12-18 Thread Jonathan Yong via Gcc-patches
On 10/31/22 15:22, i.nixman--- via Gcc-patches wrote: On 2022-10-31 09:18, Eric Botcazou wrote: Hi Eric! thank you very much for the job! I will try to build our (MinGW-Builds project) builds using this patch and will report back. @Jonathan what the next steps to be taken to accept this pat

testsuite: Fix pr55569.c excess errors

2022-12-20 Thread Jonathan Yong via Gcc-patches
te/gcc.c-torture/compile/pr55569.c:13:34: warning: iteration 2147483647 invokes undefined behavior [-Waggressive-loop-optimizations] Patch OK?From 11cc6c38c4b44849110240da3ed553fcc3b35d05 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Tue, 20 Dec 2022 09:16:16 + Su

Re: testsuite: Fix pr55569.c excess errors

2022-12-20 Thread Jonathan Yong via Gcc-patches
On 12/20/22 16:55, Andrew Pinski wrote: On Tue, Dec 20, 2022 at 1:22 AM Jonathan Yong via Gcc-patches wrote: This fixes the following: It is not obvious from the email, why this patch is needed but I figured it was due to LLP64 targets or some other targets where long is not the same size

Re: Adding a new thread model to GCC

2022-12-22 Thread Jonathan Yong via Gcc-patches
On 12/16/22 19:20, Eric Botcazou wrote: The libgcc parts look reasonable to me, but I can't approve them. Maybe Jonathan Yong can approve those parts as mingw-w64 target maintainer, or maybe a libgcc approver can do so. OK. The libstdc++ parts are OK for trunk. IIUC they could

  1   2   >