On 3/2/23 10:44, Richard Sandiford wrote:
diff --git a/gcc/testsuite/gcc.dg/overflow-warn-9.c 
b/gcc/testsuite/gcc.dg/overflow-warn-9.c
index 57c0f17bc91..ae588bd8491 100644
--- a/gcc/testsuite/gcc.dg/overflow-warn-9.c
+++ b/gcc/testsuite/gcc.dg/overflow-warn-9.c
@@ -59,7 +59,8 @@ const struct Types t1 = {
    .ui = UINT_MAX + 1L,      /* { dg-warning "signed conversion from .long int. to .unsigned 
int. changes value from .4294967296. to .0." "lp64" { target lp64 } } */
    .ui = UINT_MAX + 1LU,     /* { dg-warning "conversion from .long unsigned int. to 
.unsigned int. changes value from .4294967296. to .0." "lp64" { target lp64 } } */
- .sl = LONG_MAX + 1LU, /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value from .9223372036854775808. to .-9223372036854775808." "not-ilp32" { target { ! ilp32 } } } */
+  .sl = LONG_MAX + 1LU,     /* { dg-warning "signed conversion from .long unsigned int. to 
.long int. changes value from .9223372036854775808. to .-9223372036854775808." 
"lp64" { target lp64 } } */
    /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value 
from .2147483648. to .-2147483648." "ilp32" { target ilp32 } .-1 } */
+  /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value 
from .2147483648. to .-2147483648." "llp64" { target llp64 } .-2 } */
    .ul = ULONG_MAX + 1LU     /* there should be some warning here */
  };

OK, although in general I think would be good to use
{ target { ilp32 || llp64 } } for this kind of thing.

No need to change this patch though, just saying for the future.


Thanks for reviewing, how does the "ilp32" or "llp64" before the curly target brackets work?

Pushed existing patch to master branch.

Reply via email to