Re: [PATCH] libstdc++: use a link test to test for -Wl,-z,relro

2020-09-13 Thread JonY via Gcc-patches
On 9/10/20 2:23 PM, JonY wrote: > Do a link test instead of just a grep. The linker can > support multiple targets, but not all targets can use it. > > Cygwin/MinGW ld can support ELF but the PE format for Windows itself > does not support such a feature. Attached patch OK? > > I'm not confident

Re: [PATCH] libstdc++: use a link test to test for -Wl,-z,relro

2020-09-16 Thread JonY via Gcc-patches
On 9/13/20 3:37 PM, JonY wrote: > On 9/10/20 2:23 PM, JonY wrote: >> Do a link test instead of just a grep. The linker can >> support multiple targets, but not all targets can use it. >> >> Cygwin/MinGW ld can support ELF but the PE format for Windows itself >> does not support such a feature. Atta

[PATCH] libstdc++: use lt_host_flags for libstdc++.la

2020-09-16 Thread JonY via Gcc-patches
For platforms like Mingw and Cygwin, cygwin refuses to generate the shared library without using -no-undefined. Attached patch makes sure the right flags are used, since libtool is already used to link libstdc++. Patch OK? From 4ba039687182fccd67e1170f89e259e1c4a58eeb Mon Sep 17 00:00:00 2001 Fro

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-16 Thread JonY via Gcc-patches
On 9/17/20 3:56 AM, Jeff Law wrote: > > If it's been ack'd by a maintainer, yes.  Jakub definitely qualifies as > a maintainer, so feel free to push it on Martin's behalf. > > > jeff Sure, it has been pushed, thanks all. signature.asc Description: OpenPGP digital signature

Re: [PATCH] Cygwin/MinGW: Do not version lto plugins

2020-09-21 Thread JonY via Gcc-patches
On 9/21/20 11:38 AM, Martin Liška wrote: > Sorry, it's not caused by your patch. It's our SUSE-specific package setup. > How does liblto_plugin.so.0.0.0 get loaded? I find only mentions of liblto_plugin.so. Is Suse GCC patched to use the versioned library? signature.asc Description: OpenPGP d

Re: [PATCH] libstdc++: use a link test to test for -Wl,-z,relro

2020-09-22 Thread JonY via Gcc-patches
On 9/22/20 8:50 AM, Jonathan Wakely wrote: > > I don't see a patch, or any previous email to the libstdc++ list. > > Please resend with the patch, CCing libstdc++@ > > Thanks. > > > Resent for the record. I've been told it might not be appropriate because some targets cannot link yet and the

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-04 Thread JonY via Gcc-patches
On 9/1/20 1:01 PM, Martin Storsjö wrote: > This fixes compilation of codepaths for dos-like filesystems > with Clang. When built with clang, it treats C input files as C++ > when the compiler driver is invoked in C++ mode, triggering errors > when the return value of strchr() on a pointer to const

Re: [PATCH] gcc: Make strchr return value pointers const

2020-09-07 Thread JonY via Gcc-patches
On 9/4/20 12:47 PM, Martin Storsjö wrote: > Hi, > > On Fri, 4 Sep 2020, Jakub Jelinek wrote: > >> On Tue, Sep 01, 2020 at 04:01:42PM +0300, Martin Storsjö wrote: >>> This fixes compilation of codepaths for dos-like filesystems >>> with Clang. When built with clang, it treats C input files as C++

[PATCH] Cygwin/MinGW: Do not version lto plugins

2020-09-08 Thread JonY via Gcc-patches
Hello, The lto plugis are tied to the built GCC anyway, so there isn't much point to versioning them. * gcc/config.host: Remove version string * lto-plugin/Makefile.am: Use libtool -avoid-version * lto-plugin/Makefile.in: Regenerate This patch has been in use with Cygwin gcc for a long time and

Re: [PATCH] Cygwin/MinGW: Do not version lto plugins

2020-09-09 Thread JonY via Gcc-patches
On 9/9/20 7:21 AM, Richard Biener wrote: > On Wed, Sep 9, 2020 at 2:28 AM JonY via Gcc-patches > wrote: >> >> Hello, >> >> The lto plugis are tied to the built GCC anyway, so there isn't much >> point to versioning them. > > In fact the lto p

Re: [PATCH] Cygwin/MinGW: Do not version lto plugins

2020-09-09 Thread JonY via Gcc-patches
On 9/9/20 7:32 AM, JonY wrote: > On 9/9/20 7:21 AM, Richard Biener wrote: >> On Wed, Sep 9, 2020 at 2:28 AM JonY via Gcc-patches >> wrote: >>> >>> Hello, >>> >>> The lto plugis are tied to the built GCC anyway, so there isn't much >>

Re: [PATCH] Cygwin/MinGW: Do not version lto plugins

2020-09-10 Thread JonY via Gcc-patches
On 9/10/20 9:44 AM, Richard Biener wrote: >> >> I can confirm liblto is still loaded correctly from the logs, likewise >> renaming it away will cause an error. >> >> Seems to be fine on Linux. > > OK then. > > Thanks, > Richard. > Thanks for reviewing, pushed to master branch ae6cf62861b5e9acb5

[PATCH] libstdc++: use a link test to test for -Wl,-z,relro

2020-09-10 Thread JonY via Gcc-patches
Do a link test instead of just a grep. The linker can support multiple targets, but not all targets can use it. Cygwin/MinGW ld can support ELF but the PE format for Windows itself does not support such a feature. Attached patch OK? I'm not confident with regenerating configure due to some unrela

Re: [PATCH] Port libgccjit to Windows.

2020-05-29 Thread JonY via Gcc-patches
On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote: >>> I was able to successfully bootstrap and regression test with >>> your patch on x86_64-pc-linux-gnu. I also verified that the >>> result of >> "make >>> install" was not affected for my configuration. >> >> Great. >> >>> I've pushed yo

Re: [PATCH] Ensure `-lmsvcrt` precede `-lkernel32`

2020-05-29 Thread JonY via Gcc-patches
On 5/29/20 2:04 PM, Liu Hao via Gcc-patches wrote: > 在 2020/5/29 22:01, Liu Hao 写道: >> This is necessary as libmsvcrt.a is not a pure import library, but >> also contains some functions that invoke others in KERNEL32.DLL. >> >> * config/i386/mingw32.h: Insert -lkernel32 after -lmsvcrt >> --- >

Re: [PATCH] Port libgccjit to Windows.

2020-06-02 Thread JonY via Gcc-patches
On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote: > On Thu, 2020-05-28 at 16:51 -0300, Nicolas Bértolo wrote: >>> I'm going to have to trust your Windows expertise here; the tempdir >>> code looks convoluted to me, but perhaps that's the only way to do >> it. >>> (Microsoft's docs for "SECUR

Re: [PATCH] Port libgccjit to Windows.

2020-06-07 Thread JonY via Gcc-patches
On 6/7/20 4:03 PM, Nicolas Bértolo wrote: > Hi, > > Sorry for the super late reply. > >> 1. Using .so on Windows for DLLs is fine. > > I know, but using the standard suffix for the platform seems better, IMHO. > It doesn't prevent applications from actually loading it. >> 2. The DLL name on W

Re: [PATCH] Port libgccjit to Windows.

2020-06-11 Thread JonY via Gcc-patches
On 6/11/20 10:02 PM, Nicolas Bértolo wrote: > Hi, > > On 6/7/20 11:12 PM, JonY wrote: >> Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is >> not. So the only way to ABI version the dll would be to use Unix style >> soname to mark when an ABI has changed. > > I tried generat

Re: [PATCH] Port libgccjit to Windows.

2020-06-15 Thread JonY via Gcc-patches
On 6/12/20 12:19 AM, JonY wrote: > On 6/11/20 10:02 PM, Nicolas Bértolo wrote: >> Hi, >> >> On 6/7/20 11:12 PM, JonY wrote: >>> Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is >>> not. So the only way to ABI version the dll would be to use Unix style >>> soname to mark when