On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote: >>> I was able to successfully bootstrap and regression test with >>> your patch on x86_64-pc-linux-gnu. I also verified that the >>> result of >> "make >>> install" was not affected for my configuration. >> >> Great. >> >>> I've pushed your patch to master as >>> c83027f32d9cca84959c7d6a1e519a0129731501. >>> >>> Thanks again for the patch Dave >> >> Thanks to you for all the good feedback. >> >> Nico. >
Hello, A bit of a late review, some minor points: 1. Using .so on Windows for DLLs is fine. 2. The DLL name on Windows should use LIBGCCJIT_SONAME rather than LIBGCCJIT_LINKER_NAME, so applications would load libgccjit.so.0 instead of libgccjit.so directly. The linker command output needs to be LIBGCCJIT_SONAME. 3. Ideally I would prefer to .cc too, though I see other C++ files also written as .c.
signature.asc
Description: OpenPGP digital signature
