Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

Hi! Generally, we need to consider the aim to test things sufficiently vs. the already way too long test time of libgomp.fortran testsuite which is not parallelized itself and often takes the longest time in the testsuite. The primary reason to do any option cycling in libgomp.fortran are tests i

Re: [C++ PATCH] Fix up decl_in_std_namespace_p handling of --enable-symvers=gnu-versioned-namespace

ht: 2019-10-30 Jakub Jelinek * typeck.c (decl_in_std_namespace_p): Return true also for decls in inline namespaces inside of std namespace. * g++.dg/cpp0x/Wpessimizing-move6.C: New test. --- gcc/cp/typeck.c.jj 2019-10-23 20:38:00.022871653 +0200 +++ gcc/cp/typeck.c

Re: [Patch][Fortran/OpenMP] Don't create "alloc:" for 'target exit data'

On Fri, Oct 18, 2019 at 11:27:39AM +0200, Tobias Burnus wrote: > Currently, one has for >   !$omp target exit data map(delete:x) > in the original dump: >   #pragma omp target exit data map(delete:*x) map(alloc:x [pointer assign, > bias: 0]) > > The "alloc:" not only does not make sense but also g

Re: [Patch][OpenMP] use_device_addr/use_device_ptr with Fortran allocatable/pointer arrays (= array descriptor)

On Mon, Oct 14, 2019 at 03:11:43PM +0200, Tobias Burnus wrote: > gcc/fortran/ > * f95-lang.c (LANG_HOOKS_OMP_ARRAY_DATA): Set to gfc_omp_array_data. > * trans-array.c Description of what has been changed and how is missing. > --- a/gcc/langhooks.h > +++ b/gcc/langhooks.h > @@ -2

Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

On Wed, Oct 30, 2019 at 11:45:11AM +0100, Tobias Burnus wrote: > On 10/30/19 10:31 AM, Jakub Jelinek wrote: > > > +++ b/libgomp/testsuite/libgomp.fortran/omp_orphan.f > > > +++ b/libgomp/testsuite/libgomp.fortran/omp_reduction.f > > > +++ b/libgomp/testsuite/li

Re: [PATCH] Fix PR90316

On Wed, Oct 30, 2019 at 11:57:12AM +0100, Thomas Schwinge wrote: > ..., and when building gcc-9-branch with > '--enable-checking=yes,extra,rtl' (apparently I'm the only one doing > that, huh?), runs into the following (at least I suppose that's what's I'm testing release branches with ../configure

[committed] Add testcase for C++ score parsing

adds a testcase for that, tested on x86_64-linux, committed to trunk. 2019-10-30 Jakub Jelinek * g++.dg/gomp/declare-variant-6.C: New test. --- gcc/testsuite/g++.dg/gomp/declare-variant-6.C.jj2019-10-30 13:11:36.534957481 +0100 +++ gcc/testsuite/g++.dg/gomp/declare-varian

Re: [RFC PATCH] targetm.omp.device_kind_arch_isa and OpenMP declare variant kind/arch/isa handling

On Wed, Oct 30, 2019 at 02:12:30PM +, Szabolcs Nagy wrote: > On 29/10/2019 17:15, Jakub Jelinek wrote: > > +void f03 (void); > > +#pragma omp declare variant (f03) match > > (device={kind(any),arch(x86_64),isa(avx512f,avx512bw)}) > > +void f04 (void); > > 1)

Re: [Patch][Fortran/OpenMP] Don't create "alloc:" for 'target exit data'

On Wed, Oct 30, 2019 at 04:48:43PM +0100, Tobias Burnus wrote: > On 10/30/19 11:12 AM, Jakub Jelinek wrote: > > I believe it is easier to handle it at the same spot as we do it e.g. > > for C/C++ pointer attachments (where we create the same clauses > > regardless of the exa

Re: [C++ PATCH] Feature macros are long

On Wed, Oct 30, 2019 at 12:33:00PM -0400, Nathan Sidwell wrote: > As discussed on IRC, this adds an L suffix to C++ feature macros, as > specified by the std. I'd forgotten that in preprocessor-land, expressions > are evaluated as longs anyway, but the user might be trying to printf these > consta

Re: [C++ PATCH] P0784R7 constexpr new fixes (PR c++/91369)

On Wed, Oct 30, 2019 at 04:26:17PM -0400, Jason Merrill wrote: > OK. > Thanks, committed. > > Now, for the accepts invalid issues. > > From what I unde

[C++ PATCH] Fix a recent regression (PR c++/90947)

27;t break anything else in the testsuite. I've actually used TYPE_NON_AGGREGATE_CLASS because a RECORD_TYPE might not be always a CLASS_TYPE_P. Here is what I've bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-10-30 Jakub Jelinek

[PATCH] Fix fallout from the fndecl_built_in_p patch (PR middle-end/92231)

m surprised it isn't e.g. a VAR_DECL in the free_lang_data case or lto case. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-10-31 Jakub Jelinek PR middle-end/92231 * tree.h (fndecl_built_in_p): Use fndecl_built_in_p instead of DECL_BUI

Re: [RFC PATCH] targetm.omp.device_kind_arch_isa and OpenMP declare variant kind/arch/isa handling

On Thu, Oct 31, 2019 at 09:16:00AM +, Richard Sandiford wrote: > > Yes, it is indeed not clear, subject to ongoing discussions. > > My reading of the spec was that all the *-name-list are comma > > separated lists of identifiers, some others in the committee > > want now (yesterday's discussion

Re: [PATCH][testuite] Fix pr80481.C after epilogue vectorization

On Thu, Oct 31, 2019 at 01:55:26PM +, Andre Vieira (lists) wrote: > I used to have this testcase in my patch when testing but forgot to include > it in the patch I sent upstream. This testcase checks that a vmovaps isn't > generated when vectorizing the loop. When I turn epilogue vectorizatio

Re: [Patch,Fortran] PR92284 – gfc_desc_to_cfi_desc fixes

fixes the issue: 2019-10-31 Jakub Jelinek PR fortran/92284 * gfortran.dg/bind_c_array_params_3_aux.c: Include ../../../libgfortran/ISO_Fortran_binding.h rather than ISO_Fortran_binding.h. --- gcc/testsuite/gfortran.dg/bind_c_array_params_3_aux.c.jj2019-10-

Re: [Patch,committed] Ensure that gfortran.dg/achar_2.f90 can fail

On Thu, Oct 31, 2019 at 09:42:07AM -0700, Steve Kargl wrote: > On Thu, Oct 31, 2019 at 05:12:39PM +0100, Tobias Burnus wrote: > > At some point, 'call abort()' was changed to 'stop'; this works fine as > > long as exit status is != 0. At least on my Linux system, this works > > until 255. (Which

Re: [PATCH 2/2][vect]Make vect-epilogues-nomask=1 default

On Wed, Oct 30, 2019 at 06:16:43PM +, Andre Vieira (lists) wrote: > 2019-10-30 Andre Vieira > > * params.def (PARAM_VECT_EPILOGUES_NOMASK): Enable by default. This broke quite a few tests in libgomp, and as they are execution failures, just trying to work around it in the test is n

[C++ PATCH] P0784R7 constexpr new further fix (PR c++/91369)

On Wed, Oct 30, 2019 at 11:05:29PM +0100, Jakub Jelinek wrote: > > Looks like there used to be a TREE_CALLS_NEW flag in TREE_LANG_FLAG_1, but > > that flag is now free for CALL_EXPR. > > I'll try a CALL_EXPR flag first. TREE_LANG_FLAG_1 is also STMT_IS_FULL_EXPR_P, and whi

[PATCH] Fix libcpp #pragma {push,pop}_macro handling of builtin macros (PR preprocessor/92296)

ding to the builtin_array. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-10-31 Jakub Jelinek PR preprocessor/92296 * internal.h (struct def_pragma_macro): Add is_builtin bitfield. (_cpp_restore_special_builtin): Declare. * init.c (_cp

[C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335, take 3)

hat case. Bootstrapped/regtested on x86_64-linux and i686-linux, all tests pass now, ok for trunk? 2019-10-31 Jakub Jelinek PR c++/88335 - Implement P1073R3: Immediate functions c-family/ * c-common.h (enum rid): Add RID_CONSTEVAL. * c-common.c (c_common_res

Re: [Patch][OpenMP] use_device_addr/use_device_ptr with Fortran allocatable/pointer arrays (= array descriptor)

On Thu, Oct 31, 2019 at 06:09:28PM +0100, Tobias Burnus wrote: > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -71,6 +71,33 @@ gfc_omp_is_optional_argument (const_tree decl) > && GFC_DECL_OPTIONAL_ARGUMENT (decl)); > } > > + > +/* Returns tree with NULL if it i

Re: [PATCH][testuite] Fix pr80481.C after epilogue vectorization

On Thu, Oct 31, 2019 at 06:02:02PM +, Andre Vieira (lists) wrote: > When I debug the vect_analyze_loop calls loop->simdlen is 0 everywhere, with > or without epilogue vectorization turned on. However, I also noticed that > excluding -fopenmp and -fopenmp-simd will yield the generation of vmova

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335, take 3)

On Fri, Nov 01, 2019 at 03:42:58PM -0400, Jason Merrill wrote: > > + for (size_t n = cp_parser_skip_balanced_tokens (parser, 1); ; n++) > > + { > > + size_t after = cp_parser_skip_attributes_opt (parser, n); > > + if (after > n) > > + { > > + n = afte

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335, take 3)

On Fri, Nov 01, 2019 at 04:42:45PM -0400, Jason Merrill wrote: > It isn't accepted for me: > > wa3.C: In function 'void foo()': > wa3.C:4:29: warning: attribute ignored [-Wattributes] > 4 | auto a = [] () [[noreturn]] constexpr {}; > | ^ > wa3.C:4:29: note:

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335, take 3)

On Fri, Nov 01, 2019 at 09:56:44PM +0100, Jakub Jelinek wrote: > Ah, used 8.x to test it. There have been r265787 and r269775 changes in > between. > Though > auto d = [] () mutable __attribute__((noreturn)) constexpr {}; > auto e = [] () mutable [[noreturn]] constexpr {}; >

Re: [PATCH] bring -Warray-bounds closer to -Wstringop-overflow (PR91647, 91463, 91679)

rn to; This FAILs: +ERROR: gcc.dg/pr36902.c: missing " for " dg-warning 47 "\\[-Warray-bounds " +ERROR: gcc.dg/pr36902.c: missing " for " dg-warning 47 "\\[-Warray-bounds " Fixed thusly, regtested on x86_64-linux and i686-linux, committed to trunk

[committed] OpenMP declare variant context strict subset testing

. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-11-02 Jakub Jelinek * omp-general.h (omp_context_selector_set_compare): Declare. * omp-general.c (omp_construct_simd_compare, omp_context_selector_props_compare, omp_context_selec

[committed] Simplify omp-device-properties.h creation (PR bootstrap/92314)

-11-02 Jakub Jelinek PR bootstrap/92314 * configure.ac: Don't look for omp-device-properties files from installed offloading compilers. Instead add tmake_file snippets for configured offloading targets and use files they generate. * Makefile.in (in

[committed] declare variant scoring

t overflow into further bits and simply represent the number as widest_int + up to 8 2^X numbers represented by those Xs, and then just write a comparison function for that. Regtested on x86_64-linux and i686-linux, committed to trunk. 2019-11-02 Jakub Jelinek * gimplify.h (omp_construct_s

Re: [patch] testsuite/libgomp.fortran/pr66199-2.f90 – remove dg-options

On Mon, Nov 04, 2019 at 01:18:58PM +0100, Tobias Burnus wrote: > This test case had from the beginning both > ! { dg-do run } > ! { dg-options "-O2" } > > However, 'dg-do run' implies torture, i.e. multiple optimization options, > while 'dg-options "-O2"' implies -O2, only. > > This means that

Re: [patch] testsuite/libgomp.fortran/pr66199-2.f90 – remove dg-options

On Mon, Nov 04, 2019 at 02:02:38PM +0100, Tobias Burnus wrote: > On 11/4/19 1:29 PM, Jakub Jelinek wrote: > > Note, pr66199-1.f90 has the same issue. And I'd probably go for the > > removal of dg-do run instead. > > Well, there are even more (ignoring those which have -s

Re: [PATCH] Add if-chain to switch conversion pass.

On Mon, Nov 04, 2019 at 03:23:20PM +0100, Martin Liška wrote: > The patch adds a new pass that identifies a series of if-elseif > statements and transform then into a GIMPLE switch (if possible). > The pass runs right after tree-ssa pass and I decided to implement > matching of various forms that a

Re: [Patch][AMD GCN][OpenMP] Add gcc/config/gcn/t-omp-device for OpenMP declare variant kind/arch/isa

On Mon, Nov 04, 2019 at 04:31:10PM +0100, Tobias Burnus wrote: > This adds gcc/config/gcn/t-omp-device to augment the nvptx, hsa and x86 host > implementation. > > This compiler has -march= carrizo/fiji/gfx900/gfx906 (for Corrizo, Fiji and > Vega GPUs; arch names aligned with LLVM and passed on to

Re: [Patch][AMD GCN][OpenMP] Add gcc/config/gcn/t-omp-device for OpenMP declare variant kind/arch/isa

On Mon, Nov 04, 2019 at 04:33:27PM +, Andrew Stubbs wrote: > On 04/11/2019 15:37, Jakub Jelinek wrote: > > My preference would be that arch on amdgcn is something like amdgcn or gcn. > > I hope the general distinction between arch and isa will be something that > > w

Re: [PATCH][vect] Disable vectorization of epilogues for loops with SIMDUID set

On Tue, Nov 05, 2019 at 08:07:53AM +0100, Richard Biener wrote: > > I was using loop->simdlen to detect whether it was a SIMD loop and I don't > > believe that was correct, as can be witnessed by the mass failures in > > libgomp. > > My apologies for not running this, didn't think of it! > > > >

[C++ PATCH] Allow [[likely]] and [[unlikely]] in constexpr functions (PR c++/92343)

86_64-linux and i686-linux, ok for trunk? 2019-11-05 Jakub Jelinek PR c++/92343 * constexpr.c (potential_constant_expression_1): Return true rather than false for PREDICT_EXPR. * g++.dg/cpp2a/attr-likely6.C: New test. --- gcc/cp/constexpr.c.jj 2019-11-02

[PATCH] Fix compute_objsize ICE on VLA ARRAY_REF (PR tree-optimization/91945)

Hi! As the testcase shows, ARRAY_REF on an array with variable length element doesn't have INTEGER_CST TYPE_SIZE_UNIT which the code was assuming. The following patch punts in that case. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-11-05 Jakub Jelinek

[PATCH] Reject VLAs in inline asm operands that require registers (PR inline-asm/92352)

-linux, ok for trunk? 2019-11-05 Jakub Jelinek PR inline-asm/92352 * gimplify.c (gimplify_asm_expr): Reject VLA in output or input operands with non-memory constraints. * c-c++-common/pr92352.c: New test. --- gcc/gimplify.c.jj 2019-11-02 10:00:59.595253274

[committed] OpenMP declare variant template handling

Hi! The following patch handles declare variant in templates, including instantiating the "omp declare variant base" attribute value. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-11-05 Jakub Jelinek * decl.c (omp_declare_variant_finalize_

Re: [PATCH] Reject VLAs in inline asm operands that require registers (PR inline-asm/92352)

gt;= 0 sizes are specific to Ada and I have no idea what is and isn't valid there, for C/C++ it should always return -1. > Otherwise looks reasonable to me. So, is the following ok if it passes bootstrap/regtest, or shall I just go for || !tree_fits_poly_uint64_p (TYPE_SIZE_UNIT (outtype

Re: [C++ PATCH] Allow [[likely]] and [[unlikely]] in constexpr functions (PR c++/92343)

On Tue, Nov 05, 2019 at 08:19:17AM +, Jason Merrill wrote: > OK. Thanks, committed. > I wonder why we're returning false for EMPTY_CLASS_EXPR? No idea. Seems it has been added in http://gcc.gnu.org/r227296 on c++-delayed-folding branch by Kai, but there was no testsuite coverage nor I can

Re: [PATCH 1/5] Libsanitizer: merge from trunk with merge.sh.

On Mon, Nov 04, 2019 at 04:10:27PM +0100, Martin Liska wrote: > > libsanitizer/ChangeLog: > > 2019-11-05 Martin Liska > > * all source files: Merge from upstream r375507. > --- > libsanitizer/BlocksRuntime/Block.h| 59 + > libsanitizer/BlocksRuntime/Block_private.h|

Re: [PATCH][committed] Warn about inconsistent OpenACC nested reduction clauses

On Wed, Nov 06, 2019 at 01:41:47PM +0100, frede...@codesourcery.com wrote: > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -128,6 +128,12 @@ struct omp_context > corresponding tracking loop iteration variables. */ >hash_map *lastprivate_conditional_map; > > + /* A tree_list of the re

[PATCH] Ensure x86_64 TYPE_EMPTY_P args have distinct addresses (PR c++/92384)

tually copy anything, as the TYPE_EMPTY_P types contain solely padding and so it is ok if they are just allocated on the stack, but are not copied. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-11-07 Jakub Jelinek PR c++/92384 *

Re: [PATCH][vect] Disable vectorization of epilogues for loops with SIMDUID set

On Thu, Nov 07, 2019 at 02:26:29PM +, Andre Vieira (lists) wrote: > 2019-11-07 Andre Vieira > > * tree-vect-loop.c (vect_analyze_loop): Disable epilogue > vectorization for loops with SIMDUID set. Enable epilogue > vectorization for loops with SIMDLEN set after find

Re: [committed] Remove gimple_call_types_likely_match_p (PR 70929)

On Thu, Nov 07, 2019 at 12:00:32PM +0100, Martin Jambor wrote: > 2019-11-07 Martin Jambor > > PR lto/70929 > * cif-code.def (MISMATCHED_ARGUMENTS): Removed. > * cgraph.h (gimple_check_call_matching_types): Remove > * cgraph.c (gimple_check_call_args): Likewise. > (

[PATCH] Handle gimple_clobber_p stmts in store-merging (PR target/92038)

on x86_64-linux and i686-linux, ok for trunk? 2019-11-07 Jakub Jelinek PR target/92038 * gimple-ssa-store-merging.c (find_constituent_stores): For return value only, return non-NULL if there is a single non-clobber constituent store even if there are constitue

[C++ PATCH] PR c++/91370 - Implement P1041R4 and P1139R2 - Stronger Unicode reqs

nted in r276167. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? I believe we can now claim to have both P1041R4 and P1139R2 implemented. 2019-11-07 Jakub Jelinek PR c++/91370 - Implement P1041R4 and P1139R2 - Stronger Unicode reqs * charset.c (narro

[committed] Fix some typos

Hi! I've noticed a comment typo in build_vec_delete_1 and when grepping around if the same typo isn't elsewhere, I found a different typo elsewhere. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2019-11-08 Jakub Jelinek

Re: [C++ PATCH] Implement D1959R0, remove weak_equality and strong_equality.

ng compilation). Fixed thusly, tested on x86_64-linux, committed to trunk as obvious: 2019-11-08 Jakub Jelinek * g++.dg/cpp2a/spaceship-scalar1-neg.C: Change dg-do from run to compile. --- gcc/testsuite/g++.dg/cpp2a/spaceship-scalar1-neg.C (revision 277932) +++ gcc/testsuite/

[C++ PATCH] Fix error-recovery with constexpr dtor (PR c++/92414)

there is no need to try to evaluate constexpr dtor on it. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-11-08 Jakub Jelinek PR c++/92414 * constexpr.c (cxx_constant_dtor): Don't call cxx_eval_outermost_constant_expr if DECL_INITIAL is erro

Re: [Patch][OpenMP][Fortran] Support absent optional args with use_device_{ptr,addr} (+ OpenACC's use_device clause)

On Thu, Nov 07, 2019 at 11:42:22AM +0100, Tobias Burnus wrote: > + /* For VALUE, the scalar variable is passed as is but a hidden argument > + denotes the value. Cf. trans-expr.c. */ > + if (TREE_CODE (TREE_TYPE (decl)) != POINTER_TYPE) > +{ > + char name[GFC_MAX_SYMBOL_LEN + 2]; >

Re: [Patch][OpenMP][Fortran] Support absent optional args with use_device_{ptr,addr} (+ OpenACC's use_device clause)

On Fri, Nov 08, 2019 at 04:41:23PM +0100, Tobias Burnus wrote: > With DECL_ARTIFICIAL added and also_value replaced: > Build on x86-64-gnu-linux. OK once regtested? Almost. > - gimplify_assign (x, var, &ilist); > + if (do_optional_check && omp_check_optional_argument (ovar, true))

Re: [PATCH, Fortran] Allow CHARACTER literals in assignments and DATA statements

On Fri, Nov 08, 2019 at 11:17:21AM +0100, Tobias Burnus wrote: > >     Jim MacArthur  > >     Mark Eggleston  > > > >     * arith.c (hollerith2representation): Use OPT_Wcharacter_truncation > > in > >     call to gfc_warning.  Add character2representation, > > gfc_character2int, > >     gfc_char

Backports to gcc-9-branch

Hi! I've backorted following 10 patches from trunk to 9 branch, bootstrapped/regtested them on x86_64-linux and i686-linux and committed. Jakub 2019-11-08 Jakub Jelinek Backported from mainline 2019-10-21 Jakub Jelinek PR c++/92015 * conste

Re: [PATCH, Fortran] Allow CHARACTER literals in assignments and DATA statements

_char_conversion_in_data_3.f90 -Os compilation failed to produce executable Tests with dg-error are expected to fail compilation, so won't produce executable and thus can't be run. Fixed thusly, tested on x86_64-linux, committed to trunk as obvious. 2019-11-09 Ja

[committed] Fix various spelling errors in cgraph, tree-ssa-strlen and ipa-sra

fixes spelling errors, e.g. the very first hunk contains some weird unless at the end of the sentence, which I haven't changed. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2019-11-09 Jakub Jelinek * symtab.c: Fix com

[PATCH] Fix ICE during gimple resimplification (PR tree-optimization/92401)

? 2019-11-09 Jakub Jelinek PR tree-optimization/92401 * gimple-match-head.c (gimple_resimplify1): Call const_unop only if res_op->code is an expression with code length 1. * gimple-match-head.c (gimple_resimplify2): Call const_binop only if res_op-&g

[C++ PATCH] Implement P1946R0 - Allow defaulting comparisons by value

egtest? 2019-11-11 Jakub Jelinek Implement P1946R0 - Allow defaulting comparisons by value * method.c (early_check_defaulted_comparison): Remove unused variable i. For non-static data members always require argument type to be const C &, for friends allow e

Re: [C++ PATCH] Implement P1946R0 - Allow defaulting comparisons by value

On Mon, Nov 11, 2019 at 09:07:08AM +0100, Jakub Jelinek wrote: > From > https://www.reddit.com/r/cpp/comments/dtuov8/201911_belfast_iso_c_committee_trip_report/ > I understood P1946R0 made it into C++20, so here is my attempt at > implementing it, you had most of it implemented an

[committed] Diagnose #pragma omp declare target without corresponding #pragma omp end declare target

Hi! I found a bug in OpenMP 5.0 examples that GCC didn't flag as an error. The following patch implements the missing diagnostics. Bootstrapped/regtested on powerpc64le-linux, committed to trunk. 2019-11-11 Jakub Jelinek * c-parser.c (c_parser_translation_unit): Diagnose de

[committed] Unbreak powerpc* bootstrap (PR bootstrap/92433)

maybe-uninitialized warning. Fixed thusly, additionally simplified the code/made it more readable with std::swap. Bootstrapped/regtested on powerpc64le-linux, preapproved by Segher on IRC, committed to trunk. 2019-11-11 Jakub Jelinek PR bootstrap/92433 * config/rs6000/rs600

[C++ PATCH] Fix deleted fn handling (PR c++/92447)

something else, pop_nested_class isn't called anymore and callers get upset they are in current_binding_level of sk_class instead of what they expected. Fixed thusly, bootstrapped/regtested on powerpc64le-linux, ok for trunk? 2019-11-11 Jakub Jelinek PR c++/92447 * d

[PATCH] Fix ICE in vrp on aarch64 (PR tree-optimization/92452)

using cross to aarch64-linux, bootstrapped/regtested on powerpc64le-linux, ok for trunk? 2019-11-11 Jakub Jelinek PR tree-optimization/92452 * tree-vrp.c (vrp_prop::check_array_ref): If TRUNC_DIV_EXPR folds into NULL_TREE, set up_bound to NULL_TREE instead of comp

[C++ PATCH] Fix concepts vs. PCH (PR c++/92458)

cross PCH save/restore. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2019-11-11 Jakub Jelinek PR c++/92458 * constraint.cc: Include tree-hash-traits.h. (decl_tree_cache_traits): New type. (decl_tree_cache_map): New ty

[PATCH] Avoid *ORDERED_EXPRs in the IL if !HONOR_NANS (PR target/92449)

emit it even in that case. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? I'll defer the addition of the testcase and rs6000 changes to Segher. 2019-11-11 Jakub Jelinek PR target/92449 * tree-complex.c (expand_complex_multiplication): If !

Re: [C++ PATCH] Sorry about <=> on VECTOR_TYPE.

On Tue, Nov 12, 2019 at 09:10:58AM +0100, Richard Biener wrote: > On Tue, Nov 12, 2019 at 5:54 AM Jason Merrill wrote: > > > > I'm not sure what semantics we might eventually want for vector <=>, but > > let's > > give a sorry for now. > > Given our vector extension does elementwise comparisons

Re: [C++ PATCH] Sorry about <=> on VECTOR_TYPE.

On Tue, Nov 12, 2019 at 10:19:49AM +0100, Richard Biener wrote: > On Tue, Nov 12, 2019 at 10:02 AM Jakub Jelinek wrote: > > > > On Tue, Nov 12, 2019 at 09:10:58AM +0100, Richard Biener wrote: > > > On Tue, Nov 12, 2019 at 5:54 AM Jason Merrill wrote: > > > >

Re: [PATCH] Enable libsanitizer build on riscv64

On Tue, Nov 12, 2019 at 10:56:21AM +0100, Andreas Schwab wrote: > On Nov 11 2019, Jim Wilson wrote: > > > ../../../../gcc-git/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:1136:1: > > note: in expansion of macro ‘CHECK_SIZE_AND_OFFSET’ > > 1136 | CHECK_SIZE_AND_OFFSET(ipc_perm

Re: [PATCH] Enable libsanitizer build on riscv64

On Tue, Nov 12, 2019 at 11:32:56AM +0100, Jakub Jelinek wrote: > On Tue, Nov 12, 2019 at 10:56:21AM +0100, Andreas Schwab wrote: > > On Nov 11 2019, Jim Wilson wrote: > > > > > ../../../../gcc-git/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:1136:1:

Re: [PATCH 1/7 libgomp,nvptx] Move generic libgomp files from nvptx to accel

On Tue, Nov 12, 2019 at 01:29:10PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > libgomp/ > * configure.tgt (nvptx*-*-*): Add "accel" directory. > * config/nvptx/libgomp-plugin.c: Move ... > * config/accel/libgomp-plugin.c: ... to here. > * config/nvpt

Re: [PATCH 3/7 libgomp,nvptx] Add device number to GOMP_OFFLOAD_openacc_async_construct

On Tue, Nov 12, 2019 at 01:29:12PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > libgomp/ > * libgomp-plugin.h (GOMP_OFFLOAD_openacc_async_construct): Add int > parameter. > * oacc-async.c (lookup_goacc_asyncqueue): Pass device number to the > queue co

Re: [PATCH 4/7 libgomp,amdgcn] GCN libgomp port

On Tue, Nov 12, 2019 at 01:29:13PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > include/ > * gomp-constants.h (GOMP_DEVICE_GCN): Define. > (GOMP_VERSION_GCN): Define. Perhaps this could be 0, but not a big deal. > libgomp/ > * Makefile.am (libgomp_l

Re: [PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

On Tue, Nov 12, 2019 at 01:29:14PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > libgomp/ > * config/gcn/team.c (gomp_gcn_enter_kernel): Set up the team arena > and use team_malloc variants. > (gomp_gcn_exit_kernel): Use team_free. > * libgomp.h (TEAM_

Re: [PATCH 7/7 libgomp,amdgcn] GCN Libgomp Plugin

On Tue, Nov 12, 2019 at 01:29:16PM +, Andrew Stubbs wrote: > 2019-11-12 Andrew Stubbs > > libgomp/ > * plugin/Makefrag.am: Add amdgcn plugin support. > * plugin/configfrag.ac: Likewise. > * plugin/plugin-gcn.c: New file. > * configure: Regenerate. I'm a little

Re: [PATCH 5/7 libgomp,amdgcn] Optimize GCN OpenMP malloc performance

On Tue, Nov 12, 2019 at 05:47:11PM +, Andrew Stubbs wrote: > > Not really sure if it is a good idea to print anything, at least not when > > in some debugging mode. I mean, it is fairly easy to write code that will > > trigger this. And, what is the reason why you can't free the > > gomp_mall

Re: Ping Re: Add C2x *_NORM_MAX constants to

On Wed, Nov 13, 2019 at 02:10:34PM +, Joseph Myers wrote: > Ping. This patch > is pending > review. Ok. Jakub

Re: [Patch] PR fortran/92470 Fixes for CFI_address

GCC 8 and earlier). Fixed thusly, tested on x86_64-linux, committed to trunk as obvious. 2019-11-14 Jakub Jelinek * gfortran.dg/ISO_Fortran_binding_17.c: Include ../../../libgfortran/ISO_Fortran_binding.h rather than ISO_Fortran_binding.h. --- gcc/testsuite/gfortran.dg

Re: [C++] Fix interaction between aka changes and DR1558 (PR92206)

h -std=c++11: /usr/src/gcc/gcc/testsuite/g++.dg/cpp0x/alias-decl-pr92206-3.C:8:37: error: variable templates only available with '-std=c++14' or '-std=gnu++14' Fixed thusly, committed as obvious: 2019-11-14 Jakub Jelinek * g++.dg/cpp0x/alias-decl-pr92206-3.C

Re: Fix ICE when inlining into function containing polymorphic call

f(long int)' used but never defined I've fixed all the -Wwrite-strings warnings, all but one -Wreturn-type warnings (the one spot left made the ICE go away with unfixed g++ at -O3), the undefined bf ctor warning, tested on x86_64-linux, verified unfixed g++ still ICEs, committed to trunk a

Re: [PATCH PR92926]Fix wrong code caused by ctor node translation unit wide sharing

On Thu, Jan 09, 2020 at 04:27:09PM -0500, Jason Merrill wrote: > > Isn't the right spot to fix this somewhere in cp_gimplify_expr? > > I mean, the way gimplification works, we unshare_body first and then > > gimplify, which is destructive for the GENERIC it is gimplifying. The > > reason why this

Re: [PATCH] Fix quadraticness in EH sink_clobbers, PR93199

On Fri, Jan 10, 2020 at 10:47:32AM +0100, Richard Biener wrote: > > The following patch addresses the quadraticness when sinking > clobbers across a long chain of "empty" EH landing pads one > pad at a time, walking the chain of clobbers that becomes longer > and longer repeatedly. The idea is si

Re: [PATCH] Fix PR93199, quadraticness in cleanup_all_empty_eh

On Fri, Jan 10, 2020 at 11:23:34AM +0100, Richard Biener wrote: > > The following manages to avoid high EH indegree of landing pads > during the sequence of cleaning up empty EH with a chain of those. > By walking the landing pads in reverse order we mimic walking of > the EH tree depth-first (whi

[PATCH] Optimize reads from multiple elts in fold_ctor_reference (PR tree-optimization/93210)

ply exponential compile time behavior. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-01-10 Jakub Jelinek PR tree-optimization/93210 * fold-const.h (native_encode_initializer, can_native_interpret_type_p): Declare. * fold-const.c (nativ

[C++ PATCH] Fix deprecated attribute handling on templates (PR c++/93228)

apped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-01-10 Jakub Jelinek PR c++/93228 * parser.c (cp_parser_template_name): Look up deprecated attribute in DECL_TEMPLATE_RESULT or its type's attributes. * g++.dg/cpp1y/attr-deprecated-3.C: New test.

[committed] Fix libgomp build with -D_FORTIFY_SOURCE on older glibcs (PR libgomp/93219)

. 2020-01-10 Jakub Jelinek PR libgomp/93219 * libgomp.h (gomp_print_string): Change return type from void to int. * affinity-fmt.c (gomp_print_string): Likewise. Return true if not all characters have been written. --- libgomp/libgomp.h.jj2020-01-01 12:22

[committed] Unbreak bootstrap on most targets (was Re: [PATCH] PR90838: Support ctz idioms)

and verifying the testcase on aarch64-linux (and seeing it is not recognized on x86_64-linux; wonder if we couldn't handle CTZ_DEFINED_VALUE_AT_ZERO == 1 too by emitting a conditional in gimple or something similar and waiting for RTL opts to fix it up, but guess it can be handled incremental

Re: [PATCH] PR90838: Support ctz idioms

On Thu, Jan 09, 2020 at 02:26:10PM +0100, Richard Biener wrote: > > >> + tree lhs = gimple_assign_lhs (stmt); > > >> + bool zero_ok = CTZ_DEFINED_VALUE_AT_ZERO (TYPE_MODE (type), val); > > > > > > since we're using the optab entry shouldn't you check for == 2 here? > > > > Yes, that looks

Re: [committed] Unbreak bootstrap on most targets (was Re: [PATCH] PR90838: Support ctz idioms)

[-Werror=unused-but-set-variable] > 1925 | scalar_int_mode mode = SCALAR_INT_TYPE_MODE (type); > | ^~~~ Oops, then I think we need following, but can't commit it until Monday. 2020-01-11 Jakub Jelinek PR tree-optimization/90838 * tree-ssa

[PATCH] Further bootstrap unbreak (was Re: [PATCH] PR90838: Support ctz idioms)

On Sat, Jan 11, 2020 at 05:30:52PM +0100, Jakub Jelinek wrote: > On Sat, Jan 11, 2020 at 05:24:19PM +0100, Andreas Schwab wrote: > > ../../gcc/tree-ssa-forwprop.c: In function 'bool > > simplify_count_trailing_zeroes(gimple_stmt_iterator*)': > > ../../gcc/tre

[PATCH] contrib: git descr/undescr aliases

are pushed into the upstream repository)? 2020-01-13 Jakub Jelinek * contrib/gcc-git-customization: Add git descr and undescr aliases. --- contrib/gcc-git-customization.jj2020-01-12 00:25:19.697684793 +0100 +++ contrib/gcc-git-customization 2020-01-13 12:27:33.154283245 +0

Re: [PATCH] Fix ctz issues (PR93231)

On Mon, Jan 13, 2020 at 05:30:23PM +, Wilco Dijkstra wrote: > Further improve the ctz recognition: Avoid ICEing on negative shift > counts or multiply constants. Check the type is 8 bits for the string > constant case to avoid accidentally matching a wide STRING_CST. > Add a tree_expr_nonzero_

Re: [C++ PATCH RFC] PR c++/80265 - constexpr __builtin_mem*.

On Mon, Jan 13, 2020 at 06:38:23PM +, Jonathan Wakely wrote: > > > On 11/01/20 00:03 -0500, Jason Merrill wrote: > > > >The library has already worked around this issue, but I was curious about > > > >why it wasn't working. The answer: because we were passing &var to fold, > > > >which doesn't

Re: Analyzer status

On Mon, Jan 13, 2020 at 05:10:24PM -0500, David Malcolm wrote: > Unfortunately, I didn't resolve the hash_table/hash_map issue > referred to here: > https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00734.html > where r279139 on 2019-12-09 introduced the assumption that empty > hash_table entries and

Re: Analyzer status

On Mon, Jan 13, 2020 at 11:56:14PM +0100, Jakub Jelinek wrote: > > Some options: > > (a) the patch to fix hash_table::empty, and the analyzer kit > > (b) the analyzer kit with the following kludge > > (c) someone with better C++-fu than me figure out a way to get the >

Re: Analyzer status

On Mon, Jan 13, 2020 at 06:42:06PM -0500, David Malcolm wrote: > Thanks. Does it have warnings, though? > > My attempt was similar, but ran into warnings from -Wclass-memaccess in > four places, like this: > > ../../src/gcc/hash-map-traits.h:102:12: warning: ‘void* memset(void*, > int, size_t)’

Re: [PATCH] contrib: git descr/undescr aliases

On Tue, Jan 14, 2020 at 12:04:04PM +0300, Roman Zhuykov wrote: > It was a bit confusing to see "git descr" here in posted patch and "git > gcc-descr" actually committed. That was an IRC request from Richard Earnshaw. > Moreover "git gcc-descr" doesn't work for me with old git: > > ~$ git --versi

Re: [PATCH 1/2] hash-table.h: support non-zero empty values in empty_slow (v2)

how it can work at all. > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu (in > conjuction with the analyzer patch kit, which it fixes) > > OK for master? Yes to both patches, thanks. > gcc/cp/ChangeLog: Jakub Jelinek > * cp-gimplify.c (source_location

Re: Fix for LTO compromised autoconf test in libiberty

On Tue, Jan 14, 2020 at 03:02:01PM -0700, Jeff Law wrote: > Bootstrapped and regression tested on x86_64. Verified STACK_DIRECTION > is correct via hand inspection. > > OK for the trunk? Wouldn't that fail due to warnings if compiled e.g. by gcc that doesn't support noclone attribute? Can't we e

<    1   2   3   4   5   6   7   8   9   10   >