Re: [PATCH] Accept ISL 0.12

2013-09-03 Thread Jack Howarth
On Tue, Sep 03, 2013 at 12:04:51PM +0200, Richard Biener wrote: > > The following patch makes us accept ISL 0.12. > > Bootstrapped and tested on x86_64-unknown-linux-gnu (with using ISL 0.12), > applied as obvious. Richard, Does this also accept isl 0.12.1 as that is the current bug fix relea

Re: [i386, AVX-512F, pr58269] Partial fix for PR58269: properly initialize last EXT REX SSE register.

2013-09-10 Thread Jack Howarth
On Fri, Sep 06, 2013 at 11:04:45AM +0100, Iain Sandoe wrote: > Hi Kirill, > > Thanks for Ilya's input on the PR thread. > > We've done some testing/checking across the Darwin versions last night and > I've bootstrapped all langs including Ada, and tested the patch below > (together with the fra

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jack Howarth
On Wed, Oct 03, 2012 at 03:26:14PM -0700, Mike Stump wrote: > On Oct 3, 2012, at 12:04 PM, Jason Merrill wrote: > > This patch fixes a couple of Darwin issues I noticed with a cross-compiler: > > > > 1) Adds a couple of consts to avoid const-correctness errors. > > 2) Treats visibility "internal"

[PATCH] fix nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-07 Thread Jack Howarth
as well as gcc-4_7-branch/gcc-4_6-branch/gcc-4_5-branch? Jack libstdc++-v3/ 2012-10-07 Jack Howarth PR libstdc++/54847 * acinclude.m4 (GLIBCXX_ENABLE_LIBSTDCXX_TIME): Declare tp as struct for non-POSIX timers. * configure: Regenerated. Index: acinclude

[PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-08 Thread Jack Howarth
? Jack libstdc++-v3/ 2012-10-08 Jack Howarth PR libstdc++/54847 * config/os/bsd/darwin/os_defines.h (_GLIBCXX_USE_NANOSLEEP): Define. (_GLIBCXX_USE_SCHED_YIELD): Likewise. Index: libstdc++-v3/config/os/bsd/darwin/os_defines.h

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-09 Thread Jack Howarth
On Tue, Oct 09, 2012 at 09:21:25AM +0100, Jonathan Wakely wrote: > On 9 October 2012 01:39, Jack Howarth wrote: > >The --enable-libstdcxx-time=yes configure option fails to validate the > > presence of a usable nanosleep() call on darwin due to its use of pre-2008 > >

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-09 Thread Jack Howarth
On Tue, Oct 09, 2012 at 04:07:51PM +0200, Dominique Dhumieres wrote: > On x86_64-apple-darwin10 The following tests: > > g++.dg/gomp/tls-5.C > g++.dg/tls/thread_local-cse.C > g++.dg/tls/thread_local-order*.C > g++.dg/tls/thread_local*g.C > > fail with > > sorry, unimplemented: dynamic initializa

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-09 Thread Jack Howarth
On Tue, Oct 09, 2012 at 10:49:28AM -0700, Benjamin De Kosnik wrote: > > > I don't like the sched_yield macro being set there because it's > > detected correctly by configure anyway, but I'm not going to labour > > that point any more. > > Indeed. Then somebody will waste hours in the future wonde

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-10 Thread Jack Howarth
On Tue, Oct 09, 2012 at 09:13:06PM -0400, Jason Merrill wrote: > On 10/09/2012 04:36 PM, Dominique Dhumieres wrote: >> ==36994== Address 0x1003cd2e0 is 16 bytes inside a block of size 536 free'd >> ==36994==at 0x10001252D: free (vg_replace_malloc.c:430) >> ==36994==by 0x1003B5CB2: emutls_d

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-10 Thread Jack Howarth
On Wed, Oct 10, 2012 at 04:50:22PM +0200, Rainer Orth wrote: > Jack Howarth writes: > > >Have you tried a gcc trunk build on linux configured to use emutls > > instead > > of tls to confirm that this issue is really darwin-specific? These failures > > migh

Re: RFC: C++ PATCH to support dynamic initialization and destruction of C++11 and OpenMP TLS variables

2012-10-10 Thread Jack Howarth
On Wed, Oct 10, 2012 at 04:16:03PM -0400, Jack Howarth wrote: > On Wed, Oct 10, 2012 at 04:50:22PM +0200, Rainer Orth wrote: > > Jack Howarth writes: > > > > >Have you tried a gcc trunk build on linux configured to use emutls > > > instead > > > o

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 12:18:59AM +0100, Jonathan Wakely wrote: > On 11 October 2012 00:09, Jonathan Wakely wrote: > > On 9 October 2012 18:49, Benjamin De Kosnik wrote: > >> > >>> I don't like the sched_yield macro being set there because it's > >>> detected correctly by configure anyway, but I'm

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 06:46:47PM +0100, Jonathan Wakely wrote: > On 11 October 2012 17:05, Jack Howarth wrote: > > > > Jonathan, > > The committed patch results in the expected this_thread::yield() and > > this_thread::sleep_for() > > support. I did run

Re: [PATCH] revised fix for nanosleep check in GLIBCXX_ENABLE_LIBSTDCXX_TIME for darwin

2012-10-11 Thread Jack Howarth
On Thu, Oct 11, 2012 at 08:11:48PM +0200, Dominique Dhumieres wrote: > Jack, > > > > That's PR 54407, so not a regression. > > > > ... The pthreads support is definitely improved in darwin11 and later. > > Do you confirm that 30_threads/condition_variable/54185.cc is passing on > darwin11 and 12

[PATCH] partial fix for PR target/54404

2012-10-17 Thread Jack Howarth
-darwin10 and powerpc-apple-darwin9. Okay for gcc trunk? Jack gcc/testsuite/ 2012-10-17 Dominique Dhumieres Jack Howarth PR target/54404 * g++.dg/other/darwin-cfstring1.C: Add -ftrack-macro-expansion=0 to dg-options. * obj-c++.dg/strings/const-cfstring

[PATCH] Fix target/PR55061

2012-10-25 Thread Jack Howarth
libbacktrace/ 2012-10-25 Jack Howarth target/PR55061 * configure.ac: Check for _Unwind_GetIPInfo function declaration. * configure: Regenerate. Index: libbacktrace/configure.ac === --- libbacktrace/configure.ac

[PATCH][Revised] Fix target/PR55061

2012-10-26 Thread Jack Howarth
, AC_LANG_PROGRAM and AC_MSG_RESULT instead of AC_TRY_COMPILE(). Okay for gcc trunk? Jack libbacktrace/ 2012-10-26 Jack Howarth target/PR55061 * configure.ac: Check for _Unwind_GetIPInfo function declaration. * configure: Regenerate. Index

[PATCH] add check_effective_target_masm_intel

2012-10-26 Thread Jack Howarth
on x86_64-apple-darwin12. Okay for gcc trunk? Jack gcc/testsuite/ 2012-10-26 Jack Howarth PR target/54255 * lib/target-supports.exp (check_effective_target_masm_intel): New proc. * gcc.target/i386/asm-dialect-1.c: Use dg-require-effective-target masm_intel

Re: [PATCH] Fix pr571518.c test case.

2013-10-15 Thread Jack Howarth
On Fri, Jul 05, 2013 at 09:25:52AM -0700, Mike Stump wrote: > On Jul 4, 2013, at 9:17 AM, Marcus Shawcroft wrote: > >* gcc.dg/pr57518.c: Adjust scan-rtl-dump-not pattern. > > [ If you want a review or need an approval, be sure to ask Ok? Just in case > you forgot... ] Ok. > > Thanks.

Re: libsanitizer merge from upstream r191666

2013-11-02 Thread Jack Howarth
On Fri, Nov 01, 2013 at 04:13:05PM -0700, Konstantin Serebryany wrote: > Jukub, > > This works! > New patch attached. Konstantin, This patch, when applied on top of r204305, bootstraps fine on x86_64-apple-darwin12 but produces a lot of regressions with... make -k check RUNTESTFLAGS="asan.ex

Re: libsanitizer merge from upstream r191666

2013-11-04 Thread Jack Howarth
ith-system-zlib --enable-checking=yes --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib --program-suffix=-fsf-4.9 Thread model: posix gcc version 4.9.0 20131101 (experimental) (GCC) > > --kcc > > On Sat, Nov 2, 2013 at 10:25 AM, Jack Howarth > wrote: > >

Backport of r244010 to gcc-6-branch

2017-06-19 Thread Jack Howarth
The following change from gcc-7-branch and trunk needs to be backported to gcc-6-branch to allow the Xcode 9 clang compiler to bootstrap it. Tested on 10.12 with Xcode 9 beta. Okay for gcc-6-branch? Jack r244010-gcc_6_branch-backport.patch Description: Binary data

[PATCH] fix PR sanitizer/58994 on darwin via correct linkage

2013-11-13 Thread Jack Howarth
m munging the the flags. libsanitizer/ 2013-11-13 Jack Howarth PR sanitizer/58994 * asan/Makefile.am (libasan_la_LDFLAGS): Link to Foundation framework on darwin. * asan/Makefile.in: Regenerate. Index: libsanitizer/asan/M

[PATCH]: backport fix for PR sanitizer/58994

2013-11-14 Thread Jack Howarth
ps Kostya, can you handled the commit? Thanks in advance. 2013-11-14 Kostya Serebryany Jack Howarth libsanitizer/ PR sanitizer/58994 Backport from upstream revision 194573 * asan/asan_interceptors.cc (COMMON_INTERCEPTOR_ENTER): Fall back to the

[PATCH] Support -rdynamic on darwin12 and later

2015-04-28 Thread Jack Howarth
The attached patch adds support for the -rdynamic compiler flag on darwin12 and later. The darwin linker, starting with Xcode 5 on darwin12, added support for the associated new -export_dynamic linker flag. -export_dynamic Preserves all global symbols in main executables

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Jack Howarth
The new patch bootstraps fine on x86_64-apple-darwin14. On Wed, Apr 29, 2015 at 5:22 PM, Caroline Tice wrote: > Here is a new patch to update the cold name partition so that it will > only be treated like a function name and be given a size on the > architectures that specifically define macros f

Re: libsanitizer merge from upstream r221802

2014-11-13 Thread Jack Howarth
Konstantin, Applying the libsanitizer-221802.patch merge to r217456 with the proposed patch at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63534#c50, produces the following new regressions on x86_64-apple-darwin14 for asan.exp at -m32/-m64... FAIL: c-c++-common/asan/global-overflow-1.c -

Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-27 Thread Jack Howarth
es it for conditional compilation. > > The graphite*c patch is based on the one of Jack Howarth, > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00906.html - without checking > whether the ISL replacements make sense. > > With the patch, I have successfully bootstrapped GCC with ISL 0.12.2

[PATCH] fix PR testsuite/64145

2014-12-02 Thread Jack Howarth
The attached patch fixes the regression in the gcc/testsuite/gcc.dg/graphite/isl-codegen-loop-dumping.c testcase caused by the accidental removal of -fgraphite-identity from dg-options at r217315. Okay for gcc trunk? Jack 2014-12-01 Jack Howarth PR

[PATCH]: Remove unnecessary usage of -DCLOOG_INT_GMP on islinc

2014-12-03 Thread Jack Howarth
The attached patch completes the removal of the cloog support in gcc trunk by removing the use of -DCLOOG_INT_GMP on islinc in config/isl.m4 and the top-level configure. Bootstrap tested against isl 0.14 on x86_64-apple-darwin14. Okay for gcc trunk? Jack 2014-12-03 Jack

Re: ipa-icf::merge TLC

2015-02-26 Thread Jack Howarth
On Wed, Feb 25, 2015 at 3:38 AM, Jan Hubicka wrote: > > I plan to commit after some further testing tomorrow and having chance > Martin to look across the changes and discuss 5). > > Honza > Is this still going in today or is there a newer patch to test? Jack

Re: Fix line-maps wrt LTO

2015-03-26 Thread Jack Howarth
Jan, It appears that https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61250 is due to a problem in linemap_macro_map_lookup. It is hard to debug as the pch test harness doesn't produce a simple logged compile failure to re-execute but I can look at it from a core file in gdb. Unfortunately your pr

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-30 Thread Jack Howarth
HJ, This patch breaks the bootstrap on targets like darwin which don't build libgcc_nonshared.a... if test -z "$objects"; then \ echo 'int __libgcc_eh_dummy;' > eh_dummy.c; \ /sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/./gcc/xgcc -B/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/./gcc/ -B

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-30 Thread Jack Howarth
target 'bootstrap' failed make: *** [bootstrap] Error 2 Jack On Mon, Mar 30, 2015 at 10:08 PM, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 5:53 PM, Jack Howarth > wrote: >> HJ, >> This patch breaks the bootstrap on targets like darwin which >> don't

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-30 Thread Jack Howarth
On Mon, Mar 30, 2015 at 10:42 PM, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 7:08 PM, H.J. Lu wrote: >> On Mon, Mar 30, 2015 at 5:53 PM, Jack Howarth >> wrote: >>> HJ, >>> This patch breaks the bootstrap on targets like darwin which >>> don't

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-31 Thread Jack Howarth
H.J., While the latest patch fails to bootstrap on x86_64-apple-darwin14... make[2]: Entering directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/x86_64-apple-darwin14.3.0/libcilkrts' /bin/sh ./libtool --tag=CXX --mode=link /sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/./gcc/xg++ -B/sw

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-31 Thread Jack Howarth
H.J., Did you attach the correct version of the patch? I don't see anything conditional on linux. Jack On Tue, Mar 31, 2015 at 11:58 AM, H.J. Lu wrote: > On Tue, Mar 31, 2015 at 7:25 AM, Jack Howarth > wrote: >> H.J., >> While the latest patch fails

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-31 Thread Jack Howarth
On Tue, Mar 31, 2015 at 12:14 PM, H.J. Lu wrote: > On Tue, Mar 31, 2015 at 9:09 AM, Jack Howarth > wrote: >> H.J., >> Did you attach the correct version of the patch? I don't see >> anything conditional on linux. >> Jack > > My patch will

Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

2015-03-31 Thread Jack Howarth
On Tue, Mar 31, 2015 at 1:00 PM, H.J. Lu wrote: > On Tue, Mar 31, 2015 at 9:39 AM, Jack Howarth > wrote: >> On Tue, Mar 31, 2015 at 12:14 PM, H.J. Lu wrote: >>> On Tue, Mar 31, 2015 at 9:09 AM, Jack Howarth >>> wrote: >>>> H.J., >>>>

[PATCH] PR debug/61352 back port from mainline

2015-04-12 Thread Jack Howarth
The attached patch is a back port of the change from https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=211067 for gcc-4_9-branch. Bootstrap and regression tested on x86_64-apple-darwin14 with Xcode 6.3. Okay for gcc-4_9-branch? Jack 2015-04-12 Jack Howarth Back

[PATCH] Fix PR66509

2015-06-12 Thread Jack Howarth
The attached patch revises the tests for the filds and fists mnemonics to use the assembly... filds mem(%rip); fists mem(%rip) and the test for the fildq and fistq mnemonics to use the assembly... fildq mem(%rip); fistpq mem(%rip) which will assemble for both 64-bit and 32-bit mode. This is

Re: [PATCH] Fix PR66509

2015-06-13 Thread Jack Howarth
On Sat, Jun 13, 2015 at 12:04 AM, Mike Stump wrote: > On Jun 12, 2015, at 8:25 PM, Jack Howarth wrote: >> The attached patch revises the tests for the filds and fists >> mnemonics to use the assembly... >> >> filds mem(%rip); fists mem(%rip) > >> Okay f

[PATCH][Revised] Fix PR66509

2015-06-26 Thread Jack Howarth
The attached revised patch adjusts the tests for the filds and fists mnemonics to use the assembly... filds (%ebp); fists (%ebp) and the test for the fildq and fistq mnemonics to use the assembly... fildq (%ebp); fistpq (%ebp) which will assemble for both 64-bit and 32-bit mode. This is requi

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
On 86_64 Fedora 15, current gcc trunk only produces… nm libgcc_s.so.1 | grep OFF 00215478 d _GLOBAL_OFFSET_TABLE_ and not __OFFLOAD_TABLE__, The libgcc_s.so.1 built on x86_64-apple-darwin14 doesn't even contain the _GLOBAL_OFFSET_TABLE_ symbol. On Fri, Jan 16, 2015 at 5:40 PM, Ilya Ver

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
___OFFLOAD_TABLE__... # nm e.50.1.o | grep OFF U ___OFFLOAD_TABLE__ rather than $ nm e.50.1.o | grep OFF w __OFFLOAD_TABLE__ for all of the test cases. On Fri, Jan 16, 2015 at 6:30 PM, Ilya Verbin wrote: > On 16 Jan 18:22, Jack Howarth wrote: >> On 86_64 Fedora 15, cu

Re: [PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter (was: Merge current set of OpenACC changes from gomp-4_0-branch)

2015-01-16 Thread Jack Howarth
Confirmed that this patch eliminates [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin and thus exposes [Bug libgomp/64635] New: darwin produces libgomp-plugin-host_nonshm.1.dylib but tries to load libgomp-plugin-host_nonshm.so.1 The additional hack (which should be fi

Re: Merge current set of OpenACC changes from gomp-4_0-branch

2015-01-27 Thread Jack Howarth
Thomas, Any plans to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64635 soon? On x86_64 darwin, the OpenACC merge resulted a huge number of failures in the libgomp test suite… === libgomp Summary === # of expected passes 10628 # of unexpected failures 724 # of unsupported tests 562 whic

[PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Jack Howarth
The attached patch solves PR64635 for those targets which produce a libgomp-plugin-host_nonshm shared library with a suffix other than ".so.1". A set of target specific plugin-suffix.h headers are installed in libgomp/config/aix, libgomp/config/darwin and libgomp/config/hpux as well as a generic

Re: [PATCH] PR64635 - load libgomp-plugin-host_nonshm shared library with correct suffix

2015-01-28 Thread Jack Howarth
Mike, Thanks for the commit. There is one other issue that I have been pondering about filing a PR. In fink and MacPorts, FSF gcc is built and packaged using either... --prefix=/sw/lib/gcc5.0 or --libdir=/opt/local/lib/gcc5 such that the libraries for each gcc release are buried. While th

[PATCH] Fix PR64855

2015-01-29 Thread Jack Howarth
The attached patch fixes PR64855 by not setting targetabis on darwin in testsuite/lib/libffi.exp as suggested by Iain Sandoe. Confirmed on x86_64-apple-darwin14 to eliminate the libffi regressions at -m32/-m64. Okay for gcc trunk? Jack 2015-01-29 Jack Howarth PR libffi

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-06 Thread Jack Howarth
H.J., On x86_64-apple-darwin14, your patch applied to r220481 results in... FAIL: gcc.dg/visibility-22.c (test for excess errors) FAIL: gcc.dg/visibility-23.c scan-hidden private_extern[ \t_]*_?foo with... Executing on host: /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc -B/sw/sr

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-06 Thread Jack Howarth
015 at 4:41 PM, H.J. Lu wrote: > On Fri, Feb 6, 2015 at 1:31 PM, Jack Howarth wrote: >> H.J., >> On x86_64-apple-darwin14, your patch applied to r220481 results in... >> >> FAIL: gcc.dg/visibility-22.c (test for excess errors) >> FAIL: gcc.dg/visibility-23.c scan-

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-06 Thread Jack Howarth
likely caused by different translation units being compiled with different visibility settings. Can this change wait until stage1? Jack On Fri, Feb 6, 2015 at 4:41 PM, H.J. Lu wrote: > On Fri, Feb 6, 2015 at 1:31 PM, Jack Howarth wrote: >> H.J., >> On x86_64-apple

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-06 Thread Jack Howarth
H.J., Where is this new patch? Jack On Fri, Feb 6, 2015 at 8:55 PM, H.J. Lu wrote: > On Fri, Feb 6, 2015 at 5:51 PM, Jack Howarth wrote: >> H.J., >> This patch also seems to be causing a huge number of regressions >> in the g++ test suite due to linka

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-07 Thread Jack Howarth
id foo () __attribute__((weak,visibility("hidden"))); int If you don't define a dg-options line first, the dg-additional-options lines have no effect. Jack On Fri, Feb 6, 2015 at 8:55 PM, H.J. Lu wrote: > On Fri, Feb 6, 2015 at 5:51 PM, Jack Howarth wrote: &

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-07 Thread Jack Howarth
On Sat, Feb 7, 2015 at 7:27 AM, H.J. Lu wrote: > On Sat, Feb 07, 2015 at 03:28:38AM -0500, Jack Howarth wrote: >> H.J., >> The new patch bootstraps okay on x86_64-apple-darwin14 but I > > Does it cause any regressions on x86_64-apple-darwin14? > >> discovered that

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-07 Thread Jack Howarth
.constructor .destructor .align 1 .subsections_via_symbols On Sat, Feb 7, 2015 at 10:11 AM, Jack Howarth wrote: > H.J,, > Unfortunately, the answer is yes. This patch still introduces > regressions in the g++ test suite.l These are all some form of... &g

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-07 Thread Jack Howarth
10:11:01AM -0500, Jack Howarth wrote: >> H.J,, >> Unfortunately, the answer is yes. This patch still introduces >> regressions in the g++ test suite.l These are all some form of... >> > > It looks like Darwin depends on the old behavior of > default_bin

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-08 Thread Jack Howarth
015 at 07:56:06AM -0800, H.J. Lu wrote: >> On Sat, Feb 07, 2015 at 10:11:01AM -0500, Jack Howarth wrote: >> > H.J,, >> > Unfortunately, the answer is yes. This patch still introduces >> > regressions in the g++ test suite.l These are all some form of... >&g

Re: Fix PR 63566 part 3

2015-02-09 Thread Jack Howarth
Jan, This patch caused Bug 64982 - [5 Regression] Many g++ failures on x86_64-apple-darwin14 with -m32. Jack On Sun, Feb 8, 2015 at 3:20 PM, Jan Hubicka wrote: > Hi, > this patch makes i386.c ready for presence of aliases of local functions, but > also fixes a wrong code i

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-09 Thread Jack Howarth
This appears to be the first instance where 'target' and 'nonpic' have been used in a dg-warning. On Mon, Feb 9, 2015 at 2:40 PM, Dominique d'Humières wrote: > >> Le 9 févr. 2015 à 20:01, Dominique d'Humières a écrit : >> >> >>> Le 9 févr. 2015 à 19:10, Tom de Vries a écrit : >>> >>> On 09-02-1

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-09 Thread Jack Howarth
_, if that fails in dg-warning, wouldn't it 'appear' functional on nonpic targets, no? On Mon, Feb 9, 2015 at 3:51 PM, Jack Howarth wrote: > This appears to be the first instance where 'target' and 'nonpic' have > been used in a dg-warning. > > On Mon, Feb

Re: [PATCH] Fix PR64764 && Fix scan-tree-dump for scop-19.c

2015-02-10 Thread Jack Howarth
Tom, At -m32 on x86_64-apple-darwin14, the failing test case executes... % /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc -B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/ /sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20150209/gcc/testsuite/gcc.dg/uninit-19.c -fno-diagnostics

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-10 Thread Jack Howarth
es as... [PATCH][Revised] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking to make sure it gets the visibility for a review. On Mon, Feb 9, 2015 at 12:25 PM, Mike Stump wrote: > On Feb 8, 2015, at 10:24 AM, Jack Howarth wrote: >> This last

Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking

2015-02-11 Thread Jack Howarth
Richard, Your proposed patch fails to bootstrap here on x86_64-apple-darwin14 against the system clang compilers... g++ -c -g -DIN_GCC-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-format-attribute -Wove

Re: [PATCH] PR rtl-optimization/32219: optimizer causees wrong code in pic/hidden/weak symbol checking

2015-02-12 Thread Jack Howarth
H.J., Oddly I saw no regressions in the g++ test suite at -m32/-m64 on x86_64-apple-darwin14. Jack On Thu, Feb 12, 2015 at 1:16 PM, H.J. Lu wrote: > On Wed, Feb 11, 2015 at 10:22 PM, Richard Henderson wrote: >> On 02/10/2015 01:19 PM, Richard Henderson wrote: >>> As an existing iss

Re: [PATCH] PR rtl-optimization/32219: optimizer causees wrong code in pic/hidden/weak symbol checking

2015-02-12 Thread Jack Howarth
On Thu, Feb 12, 2015 at 2:18 PM, H.J. Lu wrote: > On Thu, Feb 12, 2015 at 11:16 AM, Jack Howarth > wrote: >> H.J., >>Oddly I saw no regressions in the g++ test suite at -m32/-m64 on >> x86_64-apple-darwin14. >>Jack > > They have >

Re: [patch, testsuite] Fix ubsan for testing when libstdc++ isn't installed

2015-02-13 Thread Jack Howarth
Mike and FX, Shouldn't we also apply... Author: fxcoudert Date: Mon Dec 22 21:57:45 2014 New Revision: 219035 URL: https://gcc.gnu.org/viewcvs?rev=219035&root=gcc&view=rev Log: * lib/ubsan-dg.exp: Add library path for libstdc++. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/test

Re: [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements

2015-02-13 Thread Jack Howarth
This also breaks the bootstrap on x86_64-apple-darwin14 due to a similar stage 2/3 comparison failure. On Fri, Feb 13, 2015 at 6:01 PM, H.J. Lu wrote: > On Fri, Feb 13, 2015 at 1:11 PM, Jeff Law wrote: >> This time with the right patch file. >> >> commit 48087ce0b383457b5919cbcc2ce1a5e1aaa264c3

Re: [patch] Fix invalid attributes in libstdc++

2015-02-16 Thread Jack Howarth
On Tue, Feb 3, 2015 at 5:37 AM, Iain Sandoe wrote: > Hi Jonathan, > > On 1 Feb 2015, at 15:10, Jonathan Wakely wrote: > >> On 01/02/15 15:08 +, Jonathan Wakely wrote: >>> I failed to CC gcc-patches on this patch ... >>> >>> On 29/01/15 13:02 +, Jonathan Wakely wrote: Jakub pointed out

Re: [PATCH] libgcc: Don't use "unused" in gthr-single.h

2015-02-22 Thread Jack Howarth
This change has already been proposed as part of a more extensive fix in https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00775.html. On Sun, Feb 22, 2015 at 9:28 PM, Segher Boessenkool wrote: > Header files shouldn't use identifiers in the application namespace. > gth-single.h does however; this ma

[PATCH] fix PR63699

2014-11-06 Thread Jack Howarth
The attached patch eliminates the compilation error... error: use of undeclared identifier 'do_not_use_toupper_with_safe_ctype' on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0 compiler. Okay for gcc trunk? Jack PR63699.patch Description: Binary data

[PATCH\ Fix PR63750

2014-11-06 Thread Jack Howarth
The attached patch eliminates the compilation error... error: use of undeclared identifier 'do_not_use_toupper_with_safe_ctype' on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0 compiler. Okay for gcc trunk? Jack PR63750.patch Description: Binary data

[PATCH][Revised] Fix PR63750

2014-11-06 Thread Jack Howarth
The revised attached patch, which corrects the placement of the include for below that of config.h, eliminates the compilation error... error: use of undeclared identifier 'do_not_use_toupper_with_safe_ctype' on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0 compiler. Okay

[PATCH][Revisedx2] Fix PR63750

2014-11-07 Thread Jack Howarth
The attached revised patch eliminates the compilation error... error: use of undeclared identifier 'do_not_use_toupper_with_safe_ctype' on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0 compiler by moving the include for earlier. Okay for gcc trunk?

[PATCH]Revised] fix PR63699

2014-11-07 Thread Jack Howarth
The attached patch eliminates the compilation error... error: use of undeclared identifier 'do_not_use_toupper_with_safe_ctype' on x86_64-apple-darwin14 when bootstrapping using the Clang 6.0 compiler by moving the include of earlier. Okay for gcc trunk?

Re: [PATCH] Don't bootstrap libcc1

2014-11-08 Thread Jack Howarth
Dominique, I thought from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63773#c1 that you were having clean bootstraps on darwin. I have tested x86_64-apple-darwin11/12/13/14 without issues in the creation of libcc1.0 % otool -L libcc1.0.so libcc1.0.so: /sw/lib/gcc5.0/lib/libstdc++.6.dylib (c

Re: [PATCH] Don't bootstrap libcc1

2014-11-08 Thread Jack Howarth
Iain, Any idea why this isn't failing universally? On all of the machines tested here with 'make bootstrap', the linkage of libcc1.so finds the necessary libstdc++ from the set of flags... -L/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/src -L/sw/src

Re: [PATCH] Don't bootstrap libcc1

2014-11-08 Thread Jack Howarth
Dominique, That is curious. I wouldn't have thought that the compiler selection would have had such a radical effect on the linkage flags emitted for the build directories. Jack On Sat, Nov 8, 2014 at 4:59 PM, Dominique d'Humières wrote: > >> Le 8 nov.

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-09 Thread Jack Howarth
ation of function template specialization 'wi::umax, std::__1::pair >' requested here result = wi::umax (pop0, pop1); ^ /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2600:1: note: cand

Re: patch to fix PR63620

2014-11-09 Thread Jack Howarth
I don't see any regressions in the libjava test suite on x86_64-apple-darwin14 at r217265 for -m32/-m64 regression testing but I also have... https://gcc.gnu.org/bugzilla/attachment.cgi?id=33843 from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63622#c3 to prevent alias creation on targets that d

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Jack Howarth
Also confirmed that FX's proposed string.diff patch solves both PR63699 and PR63750 on x86_64-apple-darwin13 against Xcode 6.1. On Mon, Nov 10, 2014 at 9:58 AM, FX wrote: >> My knowledge of C++ is limited, but I think this additional patch to >> wide-int.h is the proper fix to the issue reported

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Jack Howarth
Is the current isl 0.12.2 in infrastructure entirely sufficient to replace cloog-isl. or should the ABI compatibility changes be made to graphite to allow gcc 5.0 to be transitioned to the isl 0.14 release? Especially if any graphite changes might be made before the gcc 5.0 release that could

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Jack Howarth
lto,objc,obj-c++,java --with-gmp=/sw --with-libiconv-prefix=/sw --with-isl=/sw --without-cloog --with-mpc=/sw --with-system-zlib --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib --program-suffix=-fsf-5.0 On Mon, Nov 10, 2014 at 2:27 PM, Jack Howarth wrote: > Is the current

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
FX, It looks like you missed patching a few configure files... libjava/classpath/configure libjava/configure are definitely needed while libgo/configure zlib/configure should be added for completeness. Jack On Tue, Nov 11, 2014 at 4:15 AM, FX wrote: >> Your patch con

Re: Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
On Tue, Nov 11, 2014 at 9:45 AM, FX wrote: >>It looks like you missed patching a few configure files... >> >> libjava/classpath/configure >> libjava/configure > > Aren’t those under external control? i.e. maintained out of GCC tree? However these are maintained, the libjava configure files st

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-11 Thread Jack Howarth
sl were supposed to have improved performance that potentially would result in changes in such tree-dumps. On Mon, Nov 10, 2014 at 8:40 PM, Jack Howarth wrote: > On x86_64-apple-darwin14, the attached patch allows gcc trunk to > build against isl 0.14. I assume if we want to retain

Re: [patch, v2] Fix libtool.m4 for Darwin >= 10.10

2014-11-11 Thread Jack Howarth
Mike, The only problem with this fix for the broken libtool.m4 is that it will require constant tending as other patches regenerate these various configure files. For example, https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00379.html which was just committed would have removed the proposed change h

Re: [PATCH 0/2] backport c++ header fixes to gcc-5-branch

2017-08-25 Thread Jack Howarth
Szabolcs, Can you help get these back ports into gcc-5-branch? https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00478.html https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00477.html Thanks in advance. Jack On Mon, Aug 7, 2017 at 1:12 AM, Ryan Mounce wrote: > Fixes https://gcc.gnu.org/b

Re: GCC 5.5 Status Report (2017-09-16)

2017-09-16 Thread Jack Howarth
On Sat, Sep 16, 2017 at 3:03 PM, Jakub Jelinek wrote: > Status > == > > The GCC 5 branch is still open for regression and documentation fixes > but it's about time to close the branch with a last release from it. > Thus at the end of the next week I plan to do a RC for GCC 5.5 following > with

Re: [PATCH 1/2] (header usage fix) remove unused system header includes

2017-09-18 Thread Jack Howarth
Pinging for the final gcc 5.5 release. On Mon, Aug 7, 2017 at 1:12 AM, Ryan Mounce wrote: > 2017-08-05 Ryan Mounce > > cherry picked from trunk r235361 > 2016-04-22 Szabolcs Nagy > > * auto-profile.c: Remove include. > * diagnostic.c: Remove include. >

Re: [PATCH 2/2] (header usage fix) include c++ headers in system.h

2017-09-18 Thread Jack Howarth
Pinging for the final gcc 5.5 release. On Mon, Aug 7, 2017 at 1:12 AM, Ryan Mounce wrote: > 2017-08-05 Ryan Mounce > > cherry picked from trunk r235362 > 2016-04-22 Szabolcs Nagy > > * system.h (list, map, set, vector): Include conditionally. > * auto-profile

Re: [PATCH 0/2] backport c++ header fixes to gcc-5-branch

2017-09-18 Thread Jack Howarth
Pinging for the final gcc 5.5 release. On Mon, Aug 7, 2017 at 1:12 AM, Ryan Mounce wrote: > Fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81037 > > Bootstrap now succeeds using Xcode 9 toolchain. > > Tested on macOS 10.13 beta, however same issue reported on macOS 10.12 > with Xcode 9. > > R

Re: [PATCH 0/2] backport c++ header fixes to gcc-5-branch

2017-09-19 Thread Jack Howarth
://gcc.gnu.org/bugzilla/show_bug.cgi?id=81037#c12 wasn't that an approval from Richard Biener for applying the backport way back on 9/14? Jack > > On Sep 18, 2017, at 10:31 AM, Jack Howarth wrote: >> >> Pinging for the final gcc 5.5 release. >> >> O

Re: [PATCH, libgfortran] PR 67585 Handle EINTR

2016-10-07 Thread Jack Howarth
On Fri, Oct 7, 2016 at 12:09 PM, Janne Blomqvist wrote: > On Fri, Oct 7, 2016 at 5:50 PM, Fritz Reese wrote: >> On Fri, Oct 7, 2016 at 8:59 AM, Janne Blomqvist >> wrote: >>> On Fri, Oct 7, 2016 at 2:41 PM, FX wrote: > Many POSIX systems have the bad habit of not restarting interrupted >

[PATCH] Fix PR driver/78206 by silently ignoring EPERM as well as ENOENT

2016-11-06 Thread Jack Howarth
denied permissions as well as non-existent dirs from the stat (cur->name, &st) call in remove_dup() of gcc/incpath.c. Okay for gcc trunk and backports to gcc-5-branch and gcc-6-branch? Jack Howarth PR78206.patch Description: Binary data

Re: [PATCH] Fix PR driver/78206 by silently ignoring EPERM as well as ENOENT

2016-11-06 Thread Jack Howarth
On Sun, Nov 6, 2016 at 8:36 AM, Jack Howarth wrote: > The use of an Apple sandbox with denied file access permissions into > /usr/local > exposed that cc1 fails on errors of... > > cc1: error: /usr/local/include: Operation not permitted > > The commonly suggested solution

Re: [PATCH] Fix PR driver/78206 by silently ignoring EPERM as well as ENOENT

2016-11-06 Thread Jack Howarth
On Sun, Nov 6, 2016 at 9:45 AM, Iain Sandoe wrote: > >> On 6 Nov 2016, at 06:04, Jack Howarth wrote: >> >> On Sun, Nov 6, 2016 at 8:36 AM, Jack Howarth >> wrote: >>> The use of an Apple sandbox with denied file access permissions into >>> /usr/

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-07 Thread Jack Howarth
Iain, It certainly looks like you dropped a file here. The proposed ChangeLog shows... * config.in: Likewise. but the previously proposed hunk from... diff --git a/gcc/config.in b/gcc/config.in index a736de3..a7ff3ee 100644 --- a/gcc/config.in +++ b/gcc/config.in @@ -1934,6 +1934,18 @@ #en

Fwd: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-13 Thread Jack Howarth
-- Forwarded message -- From: Jack Howarth Date: Sun, Nov 13, 2016 at 1:19 PM Subject: Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267) To: Rainer Orth Cc: GCC Patches , Bruce Korb On Sun, Nov 13, 2016 at 5:53 AM, Rainer Orth wrote: > > Hi Jack, &g

  1   2   3   4   >