Re: [C++ coroutines 6/6] Testsuite.

2019-11-20 Thread Iain Sandoe
Hello JunMa, JunMa wrote: > 在 2019/11/17 下午6:28, Iain Sandoe 写道: > I find that the patches donot support 'for co_await'. And it is > quiet simple to implement range based 'for co_await' based on your > patches, since it's just need few more works on range

Re: Support C2x [[]] attributes for C

2019-11-21 Thread Iain Sandoe
Joseph Myers wrote: On Mon, 18 Nov 2019, Joseph Myers wrote: On Sat, 16 Nov 2019, Iain Sandoe wrote: Joseph Myers wrote: This patch adds support for the C2x [[]] attribute syntax to the C front end. gcc.dg/gnu2x-attrs-1.c: New tests. This test fails on targets without symbol alias

[Darwin, testsuite, committed] Update tests for common section use.

2019-11-21 Thread Iain Sandoe
: 2019-11-21 Iain Sandoe * gcc.dg/darwin-comm.c: Add -fcommon to compile flags. * gcc.dg/darwin-sections.c: Likewise. diff --git a/gcc/testsuite/gcc.dg/darwin-comm.c b/gcc/testsuite/gcc.dg/darwin-comm.c index a743fc6..ac892b0 100644 --- a/gcc/testsuite/gcc.dg/darwin-comm.c +++ b

[Darwin, X86, testsuite] Update tests for common section use.

2019-11-22 Thread Iain Sandoe
is to use '-mdynamic-no-pic' in the m32 case which makes the output similar to the ElF platform default. tested on x86_64-dawin16, x86_64-linux-gnu applied to mainline thanks Iain gcc/testsuite/ChangeLog: 2019-11-22 Iain Sandoe * gcc.target/i386/pr27971.c: Use mdynamic-no-p

Re: [Patch, build] Unbreak objc build

2019-11-26 Thread Iain Sandoe
Hi Rainer Orth wrote: When I tried to bootstrap with --enable-languages=default, which includes objc, it failed to build libobj. care to describe exactly how the build fails? PS: Assuming the build was indeed broken for everyone since 2 years, maybe one should remove 'objc' from the 'defau

Re: [PATCH] Trivial patch to allow bootstrap on MacOS

2019-11-28 Thread Iain Sandoe
Hello Rainer, thanks for the patch, but I think it’s only a work-around to part of the problem and there are alternate strategies for the “usual case” on MacOS/Darwin. Keller, Rainer wrote: the following is required to allow bootstrap in libcc1 during stage3 on MacOS Catalina (10.15). l

Re: [PATCH] Trivial patch to allow bootstrap on MacOS

2019-11-28 Thread Iain Sandoe
Hello again Rainer, Iain Sandoe wrote: GMP however is installed elsewhere (by Homebrew, MacPorts etc), so ignore any -nostdinc it also works to symlink the sources for gmp, mpfr, mpc (and isl, if you use it) into the source tree - those then get boostrapped along with the compiler and

[Darwin, X86, testsuite, committed] Update tests for common section use.

2019-11-28 Thread Iain Sandoe
The switch to default of no-common means that we no longer indirect the accesses to 'xxx' in this test. Adjust the scan- assembler tests to reflect this. tested on x86_64-darwin16, x86_64-linux-gnu applied to mainline, thanks Iain gcc/testsuite/ChangeLog: 2019-11-28 I

Re: [PATCH] coroutines: Fix promotion of class members in co_await statements [PR99576]

2022-11-28 Thread Iain Sandoe
Hi Adrian, Again thanks for working on this and getting it into a suitable state for posting. It’s a good idea to CC relevant maintainer(s) on patches [see MAINTAINERS] and I’d welcome cc on any coroutines ones (it’s easy to miss a patch otherwise). > On 28 Nov 2022, at 11:55, Adrian Perl via G

Re: [PATCH] coroutines: Fix promotion of class members in co_await statements [PR99576]

2022-11-30 Thread Iain Sandoe
Hi Adrian, > On 28 Nov 2022, at 20:44, Iain Sandoe wrote: >> Bootstrapping and running the testsuite on x86_64 was successfull. No >> regression occured. > > This looks resonable to me, as said in the PR. I’d like to test a little > wider with some larger > codeba

Re: [PATCH] testsuite, X86, Darwin: Fix bf16 ABI tests for Mach-O/macOS ABI.

2022-12-04 Thread Iain Sandoe
> On 4 Dec 2022, at 20:20, Uros Bizjak via Gcc-patches > wrote: > > On Sun, Dec 4, 2022 at 12:51 PM Iain Sandoe wrote: >> >> This is almost a completely Darwin-local patch, but there is one (repeated) >> place where a general change is needed - which is in m

Re: [PATCH] testsuite, X86, Darwin: Fix bf16 ABI tests for Mach-O/macOS ABI.

2022-12-05 Thread Iain Sandoe
Hi Uros, > On 5 Dec 2022, at 10:37, Uros Bizjak via Gcc-patches > wrote: > > On Sun, Dec 4, 2022 at 9:30 PM Iain Sandoe wrote: >> >> gcc/testsuite/ChangeLog: >> >>* gcc.target/x86_64/abi/bf16/args.h: Make xmm_regs, x87_regs extern. >>

Re: [PATCH] testsuite, X86, Darwin: Fix bf16 ABI tests for Mach-O/macOS ABI.

2022-12-05 Thread Iain Sandoe
Hi Uros, > On 5 Dec 2022, at 21:07, Uros Bizjak via Gcc-patches > wrote: > > On Mon, Dec 5, 2022 at 3:54 PM Iain Sandoe wrote: >> >> Hi Uros, >> >>> On 5 Dec 2022, at 10:37, Uros Bizjak via Gcc-patches >>> wrote: >>&g

Re: [PATCH v2 1/2] Allow subtarget customization of CC1_SPEC

2022-12-07 Thread Iain Sandoe
Hi > On 7 Dec 2022, at 07:54, Sebastian Huber > wrote: > > > > On 07.12.22 08:10, Thomas Schwinge wrote: >> Hi! >> On 2022-12-07T07:04:10+0100, Sebastian Huber >> wrote: >>> On 06.12.22 22:06, Thomas Schwinge wrote: >>> I suppose I just fail to see some detail here, but: >>> On 2022-1

Re: [PATCH] coroutines, c++: Find lambda-ness from the ramp function [PR 96517].

2021-12-17 Thread Iain Sandoe
Hi Jason, > On 5 Nov 2021, at 21:53, Jason Merrill wrote: > > On 11/5/21 17:16, Iain Sandoe wrote: >> Hi Jason, >>> On 5 Nov 2021, at 20:50, Jason Merrill via Gcc-patches >>> wrote: >>> >>> On 11/5/21 12:01, Iain Sandoe wrote: >>>

Re: [patch] Future-proof and homogenise handling of darwin versions

2021-12-17 Thread Iain Sandoe
Hi FX, thanks for the patch > On 17 Dec 2021, at 22:23, FX wrote: > > The current GCC branch will become 12.1.0, which will be the stable version > of GCC when the next macOS version is released. There are some places in GCC > that don’t handle darwin22 as a version, so we need to future-proo

Re: [PATCH] Testsuite: mark two tests that require alias

2021-12-19 Thread Iain Sandoe
Hi FX > On 19 Dec 2021, at 11:26, FX wrote: > Not sure who can review/approve this patch. These two tests have been failing > on darwin, apparently since they were introduced earlier this year. Mark them > with dg-require-alias. > > Tested on aarch64-apple-darwin21. > OK to commit? I think s

Re: [PATCH] objc: Fix handling of break stmt inside of switch inside of ObjC foreach [PR103639]

2021-12-31 Thread Iain Sandoe
> > PR objc/103639 > * c-typeck.c (c_finish_bc_stmt): For break inside of switch inside of > ObjC foreach, emit normal BREAK_STMT rather than goto to label. > > 2021-12-30 Iain Sandoe > > PR objc/103639 > * objc.dg/pr103639.m: New test.

Re: [PATCH] Fixincludes: handle __FLT_EVAL_METHOD__ == 16 on darwin

2022-01-01 Thread Iain Sandoe
Hi FX > On 1 Jan 2022, at 11:30, FX via Gcc-patches wrote: > > The darwin system headers error out on __FLT_EVAL_METHOD__ == 16, which > occurs when the compiler is called with -mavx512fp16 on i386. Allow this > value to proceed past the check (nothing else depends on it in the > system headers)

Re: [PATCH RFC] c++: co_await and move-only type [PR105406]

2023-03-16 Thread Iain Sandoe
Hi Jason > On 16 Mar 2023, at 03:01, Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. As with the array issue, I know you have WIP to > deal with larger issues, but this seems like a reasonable local fix. Does it > make sense to you? Yes, thanks for fixing it, I believe it will still be

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-26 Thread Iain Sandoe
Hi Richard, (I’m away from my usual infrastructure, so responses could be slow and testing things could take a while). > On 27 Mar 2023, at 12:10, Richard Biener wrote: > > On Sun, Mar 26, 2023 at 6:55 PM Iain Sandoe via Gcc-patches > wrote: >> >> Tested on x86_64-da

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard > On 27 Mar 2023, at 12:48, Richard Biener wrote: > > On Mon, Mar 27, 2023 at 8:58 AM Iain Sandoe wrote: >> >> Hi Richard, >> (I’m away from my usual infrastructure, so responses could be slow and >> testing things >> could take a while). &g

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-27 Thread Iain Sandoe
Hi Richard, > On 28 Mar 2023, at 11:58, Richard Biener wrote: > > On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: >> >> Hi Richard >> >>> On 27 Mar 2023, at 12:48, Richard Biener wrote: >>> >>> On Mon, Mar 27, 2023 at 8:58 AM Iai

Re: [PATCH] c++, coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-28 Thread Iain Sandoe
Hi Richard > On 28 Mar 2023, at 12:27, Iain Sandoe wrote: >> On 28 Mar 2023, at 11:58, Richard Biener wrote: >> >> On Mon, Mar 27, 2023 at 9:32 AM Iain Sandoe wrote: >>> >>>> On 27 Mar 2023, at 12:48, Richard Biener >>>> wrote: >>

Re: [PATCH] c++,coroutines: Stabilize names of promoted slot vars [PR101118].

2023-03-30 Thread Iain Sandoe
Hi Jason, > On 30 Mar 2023, at 00:53, Jason Merrill wrote: > > On 3/26/23 12:54, Iain Sandoe wrote: >> Tested on x86_64-darwin21, x86-64-linux-gnu >> +/* This is used to make a stable, but unique-per-function, sequence number >> for >> + each TARGET_EXPR s

Re: [Patch][GCC] Document and fix -r (partial linking)

2018-08-03 Thread Iain Sandoe
Hi Allan, > On 3 Aug 2018, at 12:56, Allan Sandfeld Jensen wrote: > > On Mittwoch, 1. August 2018 18:32:30 CEST Joseph Myers wrote: >> On Wed, 1 Aug 2018, Allan Sandfeld Jensen wrote: >>> gcc/ > > 2018-07-29 Allan Sandfeld Jensen > > gcc/doc > >* invoke.texi: Document -r > > gcc/ >

[PATCH, Darwin] Remove unnecessary target hook.

2018-08-13 Thread Iain Sandoe
Hi For Darwin when we switch between text sections a linker-visible symbol is required to preserve the linker’s “atom model”. Some time ago we implemented TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS to provide this. A suitable symbol is now emitted directly from final.c so the target hook versi

[PATCH] Fix PR19315.

2018-08-14 Thread Iain Sandoe
as extern. Two tests in the test-suite needed change, neither of which appears to be intentionally testing this "extension". The amended graphite test generates identical code. Bootstrapped on x86_64-linux-gnu (all langs), x86_64-apple-darwin. OK for trunk? iain 2018-08-14 Iain Sand

[PATCH] Fix P81033 for FDEs in partitioned code.

2018-08-14 Thread Iain Sandoe
i686 linux and on a number of Darwin platforms (from i686-darwin9 to x86_64-darwin17). OK for trunk? open branches? (although it's a regression on 8, it’s a latent wrong-code on all branches) thanks Iain 2018-08-14 Iain Sandoe gcc: PR target/81033 * d

[PATCH, Darwin, Obvious] Fix PR81685, by adding DWARF 5 section names.

2018-08-14 Thread Iain Sandoe
Hi I plan to apply this as obvious unless there are any comments in the next day or so. The ICE is caused by missing mach-o section names for the ones introduced for DWARF5. Where possible (i.e. they are currently defined), I’ve synced the Darwin names with the ones emitted by clang. thanks

[PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
Hi, The fails on Darwin are because the section naming convention is different. The patch adds Darwin-specific section attributes and a corresponding target-specific scan-assembler clause. OK for trunk? affected branches (7, 8)? thanks Iain 2018-08-15 Iain Sandoe gcc/testsuite

[PATCH, testsuite] Stringify __USER_LABEL_PREFIX__ for pr81923.c

2018-08-15 Thread Iain Sandoe
Hi, This test has always failed on Darwin (and presumably the other targets with user __USER_LABEL_PREFIX__ != “” ) since it needs to be stringified. OK for trunk? affected branches? thanks Iain 2018-08-15 Iain Sandoe gcc/testsuite: * gcc.dg/asan/pr81923.c: Stringify

[PATCH,testsuite, Darwin] Skip tests with pthread_barrier.

2018-08-15 Thread Iain Sandoe
Hi, Darwin is stated to be SUSv6 compliant and, at that revision, pthread_barrier is optional. It is not implemented on any version at least up to Darwin18. This skips the tests currently attempted which use pthread_barrier. OK for trunk? thanks Iain gcc/testsuite/ * c-c++-common/asan

Stack alignment on Darwin (PR78444)

2018-08-15 Thread Iain Sandoe
Hi HJ, I am trying to track down a misalignment of the stack on Darwin (pr78444). In r163971 you applied this: --- gcc/config/i386/darwin.h(revision 163970) +++ gcc/config/i386/darwin.h(revision 163971) @@ -79,7 +79,9 @@ Failure to ensure this will lead to a crash in the system libra

[PATCH, testsuite] Fix gcc.dg/memcmp-1.c for targets using __USER_LABEL_PREFIX__

2018-08-15 Thread Iain Sandoe
Hi, The test fails on Darwin (and presumably on other _U_L_P_ targets) because the asm-specified symbol isn’t found at link time. OK for trunk? thanks Iain gcc/testsuite: * gcc.dg/memcmp-1.c (lib_memcmp): Apply __USER_LABEL_PREFIX__. (lib_strncmp): Likewise. diff --git a/gcc/

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
> On 15 Aug 2018, at 19:39, Mike Stump wrote: > > On Aug 15, 2018, at 6:20 AM, Iain Sandoe wrote: >> >> The fails on Darwin are because the section naming convention is different. >> >> The patch adds Darwin-specific section attributes and a corresponding

[PATCH, Darwin] Move fixed _Unwind_find_Enclosing_func to a crt.

2018-08-15 Thread Iain Sandoe
is no need to treat Darwin12+ differently in this and that allows us to simplify the header there. OK for trunk? Iain 2018-08-15 Iain Sandoe gcc/ * config/darwin10.h (LINK_GCC_C_SEQUENCE_SPEC): Adjust to use the Darwin10-specific unwinder-shim. * config/darwin12.h

Re: [PATCH, testsuite] Fix PR78544 for Darwin.

2018-08-15 Thread Iain Sandoe
> On 15 Aug 2018, at 20:07, Joseph Myers wrote: > > On Wed, 15 Aug 2018, Iain Sandoe wrote: > >> One of my Grand Ideas (i.e. things that might never happen because of >> time) would be to split out the Well Known Sections used by GCC into >> file/files with .d

[PATCH, Darwin, drivers] Split DWARF is not supported on Darwin.

2018-08-16 Thread Iain Sandoe
The Darwin toolchains have a separate debug linker (dsymutil) so that the link-time penalty for debug data is not usually seen. At present, it's not clear how we would support split DWARF on Darwin (or if it would bring any additional benefit over dsymutil). This patch produces diagnostic outpu

[PATCH, testsuite] Make pr80263 work for Darwin by suppressing pubnames/types.

2018-08-16 Thread Iain Sandoe
Darwin emits pubnames/types by default which masks the intended check. OK for trunk? Iain gcc/testsuite * gcc.dg/debug/dwarf2/pr80263.c: Suppress pubtypes output for Darwin. --- gcc/testsuite/gcc.dg/debug/dwarf2/pr80263.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/te

[PATCH, X86] Test for MACH-O before HAVE_AS_GOTOFF_IN_DATA

2018-08-18 Thread Iain Sandoe
Hi, If we use an assembler which supports HAVE_AS_GOTOFF_IN_DATA, (e.g. a modern GAS) on Darwin, we produce wrong code because the gotoff-in-data test is conducted before the mach-o case. This should be a no-op on non-Darwin targets, since the Darwin test is guarded on #ifdef TARGET_MACHO. Boots

[PATCH, driver specs] Put -flto-partition= on the collect2 c/l

2018-08-18 Thread Iain Sandoe
Hi While working on the Darwin LTO issues I noticed that collect2 looks for "-flto-partition=none” in its command line option, but it doesn’t get passed. So - is the attached patch the right idea, or should collect2 be looking in the COLLECT_GCC_OPTIONS as the lto-wrapper does? (or maybe it s

[PATCH, Darwin] Do not run dsymutil automatically, when -save-temps is on the command line.

2018-08-18 Thread Iain Sandoe
Hi Folks, The point of running dsymutil automatically from collect2 is that it (collect2, lto-wrapper, etc) might be generating or using compiler temporary files that will be deleted at the end of the link process. dsymutil requires that it can see the objects actually used in the link since it a

[PATCH, LTO wrappers] If we're not building a plugin don't try to invoke it.

2018-08-18 Thread Iain Sandoe
Hi, The LTO wrappers are built and installed whether a plug-in is built or not. If one then tries to do --version or --help on those tools, it fails because the plugin is missing. A simple solution is not to try and invoke --plugin when we’re not building it. OK for trunk? Iain gcc/

r 262451

2018-08-20 Thread Iain Sandoe
I am seeing excess changes when running configure, is it possible the regenerated files were missed from this rev? https://gcc.gnu.org/ml/gcc-cvs/2018-07/msg00172.html thanks Iain

Re: r 262451

2018-08-20 Thread Iain Sandoe
> On 20 Aug 2018, at 15:55, Alexander Monakov wrote: > On Mon, 20 Aug 2018, Iain Sandoe wrote: > >> I am seeing excess changes when running I meant regenerating .. not running.. >> configure, is it possible the regenerated files were missed from this rev? >> &g

Re: [PATCH] Fix P81033 for FDEs in partitioned code.

2018-08-21 Thread Iain Sandoe
> On 20 Aug 2018, at 08:27, Richard Biener wrote: > > On Tue, Aug 14, 2018 at 10:18 PM Mike Stump wrote: >> >> On Aug 14, 2018, at 4:20 AM, Iain Sandoe wrote: >>> When function sub-sections are enabled, Darwin’s assembler needs the FDE >>> local

[PATCH, testsuite] Stringify __USER_LABEL_PREFIX__ in pr85248.

2018-08-21 Thread Iain Sandoe
another missing stringify for _U_L_P_ OK? thanks Iain gcc/testsuite * gcc.dg/lto/pr85248_0.c (test_alias): Stringify __USER_LABEL_PREFIX__. (test_noreturn): Likewise. --- gcc/testsuite/gcc.dg/lto/pr85248_0.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PATCH, Darwin] Update LTO specs to match gcc/gcc.c

2018-08-22 Thread Iain Sandoe
Hi, I committed the following as obvious. thanks Iain 2018-08-22 Iain Sandoe gcc/ * config/darwin.h (LINK_COMMAND_SPEC_A): Sync LTO options with the sequence used in gcc/gcc.c. Index: gcc/config/darwin.h

Re: [PATCH, driver specs][1] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> While working on the Darwin LTO issues I noticed that collect2 looks for >> "-flto-partition=none” in its command line option, but it doesn’t get passed. &

Re: [PATCH, driver specs][2] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> >> I plan on making Darwin default to fno-lto for link unless there’s an >> “flto*” on the link line, since otherwise there’s a process launch for every

Re: [PATCH, driver specs][3] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> >> Hi >> >> While working on the Darwin LTO issues I noticed that collect2 looks for >> "-flto-partition=none” in its command line optio

Allow target to emit LTO early debug to a separate LTO file.

2018-08-22 Thread Iain Sandoe
Hi Tom, Richi, This is something I was experimenting with to try and solve platform problems with early debug. Not a “finished patch” (I’ve removed the Darwin back-end parts) but would like your comments on the central idea. This is to switch to the alternate LTO file (this process already exi

Re: [Patch][GCC] Document and fix -r (partial linking)

2018-08-23 Thread Iain Sandoe
> On 20 Aug 2018, at 23:38, Joseph Myers wrote: > > On Fri, 3 Aug 2018, Allan Sandfeld Jensen wrote: > >>> I think you're changing the wrong place for this. If you want -r to be >>> usable with GCC without using -nostdlib (which is an interesting >>> question), you actually need to change LIN

Re: Allow target to emit LTO early debug to a separate LTO file.

2018-08-23 Thread Iain Sandoe
> On 23 Aug 2018, at 12:37, Richard Biener wrote: > > On Thu, Aug 23, 2018 at 1:19 PM Tom de Vries wrote: >> >> On 08/22/2018 10:09 PM, Iain Sandoe wrote: >>> Hi Tom, Richi, >>> >>> This is something I was experimenting with to try a

[PATCH,Darwin, config] Fix PR70694; don't force visibility on inlines for Darwin > 8

2018-08-24 Thread Iain Sandoe
At some point, with the toolchain components available to Darwin8, it was preferable to force everything generated by headers to be hidden. However, the work-around wasn’t limited and it has caused Darwin x86/x86_64 to have a blanket application of "-fvisibility-inlines-hidden” ever since. Since,

[PATCH, Darwin] Minor code clean-up, NFC, committed.

2018-08-25 Thread Iain Sandoe
Hi I committed the following patch which cleans up fallout from an ancient merge of the machopic stuff. No functional change intended. 2018-08-25 Iain Sandoe gcc/ * config/darwin.c (machopic_legitimize_pic_address): Clean up extraneous parentheses, dead code section and

[PATCH, testsuite] Don't assume that HOSTCXX can respond to TEST_ALWAYS_FLAGS.

2018-08-29 Thread Iain Sandoe
Hi, I have noticed, for some configuration cases, that the ms-sysv tests fail with “can’t build generator”. The setting of HOSTCXX in gcc/testsuite/gcc/site.exp is dependent on the top level configuration; for example, configuring with —target,host,build = x86_64-linux-gnu or CXX=/usr/bin/g++

[PATCH, Darwin, config] Arrange for configure to detect "otool".

2018-08-30 Thread Iain Sandoe
Currently, we fail to detect some Darwin assembler capabilities because the configure tests rely on a BINUTILS objdump, which isn’t generally available on Darwin. Darwin uses a tool called "otool" to provide information about objects, and we should be able to extend or adapt config tests to use th

Re: [PATCH] Maybe fix PR87134

2018-09-06 Thread Iain Sandoe
> On 6 Sep 2018, at 17:24, Gerald Pfeifer wrote: > > On Wed, 5 Sep 2018, Richard Biener wrote: >> So I'm testing the following then, leaving the placement new untouched >> (no init is fine) and then assign from vNULL. >> >> 2018-09-05 Richard Biener >> >> PR bootstrap/87134 >> *

Re: [PATCH] Maybe fix PR87134

2018-09-17 Thread Iain Sandoe
Hi Rainer, > On 6 Sep 2018, at 21:21, Rainer Orth wrote: > >> I can confirm the same, repeatable, fail on i686-darwin10 (and it >> reproduces with -save-temps) >> (and the vNULL change does not fix it there either) - don’t have access to >> the machine now until >> later in the month tho. > >

Re: [PATCH] Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-11-08 Thread Iain Sandoe
hi Balaji, On 8 Nov 2013, at 10:01, Mike Stump wrote: > On Nov 8, 2013, at 4:09 AM, Bernhard Reutner-Fischer > wrote: >> On 6 November 2013 08:04, Jakub Jelinek wrote: >>> On Wed, Nov 06, 2013 at 02:24:01AM +, Iyer, Balaji V wrote: Fixed patch is attached. The responses to your que

Re: [patch] Add -static-libquadmath option

2014-10-09 Thread Iain Sandoe
Hi FX, On 9 Oct 2014, at 11:39, FX wrote: > Version 2 of the patch, now handling the darwin case (thanks Iain) and > expressely noting in the documentation the implications on redistribution > (thanks Joseph). > Bootstrapped and regtested on x86_64-apple-darwin14. > > OK to commit? > > I need

Re: Another AIX Bootstrap failure

2014-06-24 Thread Iain Sandoe
Hi Honza, On 23 Jun 2014, at 18:36, Jan Hubicka wrote: >> The tests gcc.dg/globalalias-2.c and gcc.dg/localalias-2.c fail on darwin >> with >> >> /opt/gcc/work/gcc/testsuite/gcc.dg/globalalias-2.c:20:2: warning: alias >> definitions not supported in Mach-O; ignored >> >> I think they should b

Re: [patch i386]: Expand sibling-tail-calls via accumulator register

2014-07-06 Thread Iain Sandoe
Hello Kai, On 28 May 2014, at 09:43, Kai Tietz wrote: > Index: gcc/config/i386/i386.c > === > --- gcc/config/i386/i386.c(revision 210985) > +++ gcc/config/i386/i386.c(working copy) > @@ -38893,7 +38893,16 @@ x86_output_mi_thu

Re: [patch] fix _OBJC_Module defined but not used warning

2015-06-08 Thread Iain Sandoe
Hi Aldy, On 7 Jun 2015, at 12:37, Aldy Hernandez wrote: > On 06/07/2015 06:19 AM, Andreas Schwab wrote: >> Another fallout: >> >> FAIL: obj-c++.dg/try-catch-5.mm -fgnu-runtime (test for excess errors) >> Excess errors: >> : warning: '_OBJC_Module' defined but not used [-Wunused-variable] > > ch

Re: [PATCH, i386, Darwin RFT]: Remove reload_in_progress checks

2015-04-20 Thread Iain Sandoe
On 20 Apr 2015, at 10:47, Dominique d'Humières wrote: > After having fixed the typo, regtesting went without regression. I have done a bootstrap on i686-darwin10 with the amended patch - slow machine, so testing still in progress (but looks OK so far), NOTE: that there some references to reloa

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-13 Thread Iain Sandoe
Hello Richard, Joseph, Thanks for your reviews, On 13 Nov 2014, at 07:40, Richard Henderson wrote: > On 11/12/2014 10:18 PM, Iain Sandoe wrote: > >> # ifndef USE_ATOMIC >> #define USE_ATOMIC 1 >> # endif > > Why would USE_ATOMIC be defined previously?

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Iain Sandoe
Hello Richard, On 14 Nov 2014, at 08:01, Richard Henderson wrote: > On 11/13/2014 09:34 PM, Iain Sandoe wrote: >>> Um, surely not LOCK_SIZE, but CACHELINE_SIZE. It's the granularity of the >>> target region that's at issue, not the size of the lock itself. &g

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-14 Thread Iain Sandoe
On 14 Nov 2014, at 08:25, Richard Henderson wrote: > On 11/14/2014 09:12 AM, Iain Sandoe wrote: >> my locks are only 4 bytes [whereas they are >> rounded-up-to-n-cachlines(sizeof(pthreads mutext)) for the posix >> implementation]. >> The items that they are lockin

Re: [patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-24 Thread Iain Sandoe
On 24 Nov 2014, at 17:02, FX wrote: > Bootstrap is currently broken on ppc-darwin due to PR63703 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63703). > This is also broken on 4.9, and actually made it into the 4.9.2 release. > > This patch fixes it, restores bootstrap (well, it gets cc1 to b

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2015-03-08 Thread Iain Sandoe
+Ian + ping On 11 Feb 2015, at 14:37, Iain Sandoe wrote: > Hi Jeff, > > On 9 Feb 2015, at 14:47, Jeff Law wrote: > >> On 02/01/15 09:42, Iain Sandoe wrote: >>> >>> This is a GCC5 bootstrap regression on 32bit Darwin hosts ( I can raise a >>> PR

Re: [PATCH] pr 63354 - gcc -pg -mprofile-kernel creates unused stack frames on leaf functions on ppc64le

2015-03-21 Thread Iain Sandoe
Hi Martin, I've applied your latest patch to top of trunk and looked at the code gen on powerpc-darwin9 (and a cross from x86-64-darwin12 => powerpc64-linux-gnu). On 15 Mar 2015, at 23:39, Martin Sebor wrote: > On 03/14/2015 08:34 AM, Segher Boessenkool wrote: >> On Fri, Mar 13, 2015 at 03:54:5

Re: [Patch, Fortran] Extend (lib)coarray API/ABI documentation

2015-03-21 Thread Iain Sandoe
Dear Tobias, On 21 Mar 2015, at 14:28, H.J. Lu wrote: > On Sat, Mar 21, 2015 at 6:19 AM, Dominique Dhumieres > wrote: a couple of minor nits that Dominique and I spotted while discussing this : > -@item @emph{NOTE} A simple implementation could be a simple @code{__asm__ maybe "A simple im

Re: [PATCH] pr 63354 - gcc -pg -mprofile-kernel creates unused stack frames on leaf functions on ppc64le

2015-03-24 Thread Iain Sandoe
Hi Martin, On 24 Mar 2015, at 02:50, Martin Sebor wrote: > On 03/21/2015 01:48 PM, Iain Sandoe wrote: >>>>> 2015-03-13 Anton Blanchard >>>>> >>>>> PR target/63354 >>>>> * gcc/

[PATCH, Ada] Fix powerpc-darwin bootstrap with gcc-trunk.

2015-03-29 Thread Iain Sandoe
Hi Arnaud, Currently Ada bootstrap is broken for bootstrap compiler == gcc-trunk, and platform == powerpc-darwin9 (although it is possible to bootstrap with gcc-4.9). The reason is that generations of sinfo.h appears now to _require_ support for atomics (I assume that's intended). In fact, w.r

Re: [PATCH, Ada] Fix powerpc-darwin bootstrap with gcc-trunk.

2015-03-29 Thread Iain Sandoe
Hi Arnaud, On 29 Mar 2015, at 19:43, Arnaud Charlet wrote: >> Currently Ada bootstrap is broken for bootstrap compiler == gcc-trunk, and >> platform == powerpc-darwin9 (although it is possible to bootstrap with >> gcc-4.9). >> >> The reason is that generations of sinfo.h appears now to _require_

Re: [PATCH, Ada] Fix powerpc-darwin bootstrap with gcc-trunk.

2015-03-29 Thread Iain Sandoe
On 29 Mar 2015, at 20:01, Arnaud Charlet wrote: >> (cd ada/bldtools/sinfo; gnatmake -q xsinfo ; ./xsinfo sinfo.h ) >> raised PROGRAM_ERROR : s-atocou.adb:57 explicit raise >> >> Looking at this code, it indicates that it is a dummy implementation for >> platforms without an atomic increment supp

[PATCH] Revised fix for PR65351

2015-04-09 Thread Iain Sandoe
, built with GCC, it is known to be supported and can be added unconditionally. When generating the PICFLAG, -mno-dynamic-no-pic is added only when -mdynamic-no-pic is present in CFLAGS. OK for trunk? Iain 2015-04-09 Jakub Jelinek Iain Sandoe PR target/65351 config

[PATCH] fix final piece of PR66448 (Bootstrap fail on Darwin, after 224161).

2015-06-12 Thread Iain Sandoe
Hi, Since debug is not initialised at the time built-ins are initialised, whilst the latter may make forward declarations, those should not be considered for early debug, bootstrapped / tested on x86_64-darwin12 and x86_64-linux-gnu. OK? Iain gcc: PR bootstrap/66448 * passes.c

[PATCH g++ driver] Push -static-libstdc++ back onto the command line to allow spec substitutions to use it.

2015-06-18 Thread Iain Sandoe
Hi, This came up in a User question last night and reminded me that I had a patch for it in my Q. Usually g++ driver support for -static-libstdc++ is provided by "-Bstatic -lstdc++ -Bdynamic" and is currently disabled for targets without that linker support. However, actually, there is

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-20 Thread Iain Sandoe
On 14 Jan 2015, at 09:03, Tristan Gingold wrote: > >> On 09 Jan 2015, at 00:42, Iain Sandoe wrote: >> >> >> On 8 Jan 2015, at 13:52, Tristan Gingold wrote: >> >>> >>>> On 08 Jan 2015, at 13:49, Iain Sandoe wrote: >>>> &

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349).

2015-01-20 Thread Iain Sandoe
On 20 Jan 2015, at 10:53, Arnaud Charlet wrote: >> Any news on when this might hit trunk? >> - it is a bootstrap issue (although on older targets). > > Right, and you have local patches/a work around. > > I have been on paternity leave, so with no time to sync our changes (and > with other prio

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2015-01-26 Thread Iain Sandoe
On 26 Jan 2015, at 14:13, Rainer Orth wrote: > FX writes: > >>> The default BOOT_CFLAGS are: -O2 -g -mdynamic-no-pic >>> the libiberty pic build appends: -fno-common (and not even -fPIC) [NB >>> -fPIC _won't_ override -mdynamic-no-pic, so that's not a simple way out] >>> This means that the PIC

Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Iain Sandoe
On 28 Jan 2015, at 18:16, Richard Henderson wrote: > On 01/28/2015 10:10 AM, Dominique d'Humières wrote: >>> I can't think of any reason they shouldn't work. Were they not running >>> before, >>> or did something else change? >> >> AFAIU the commit, the tests were not run on x86_64-*-*, so the

Re: [COMMITTED] Merge libffi with upstream

2015-01-29 Thread Iain Sandoe
On 29 Jan 2015, at 16:22, Richard Henderson wrote: >> >> Well, somewhat confusingly "x86/darwin_c.c" is shared between darwin and the >> various Windows 32 bit implementations. > > It's not shared with anything. It's a copy of the old x86/ffi.c > prior to the merge from upstream. yeah, I get

Re: [Ada] Fix bootstrapping on darwin9/10 (PR ada/64349)

2015-01-30 Thread Iain Sandoe
Hi Tristan, On 30 Jan 2015, at 15:13, Arnaud Charlet wrote: > Avoid possible warning on darwin during compiler build. it's not "just a warning" it's a documented incorrect usage which causes a link error (and thus bootstrap fail) on systems that are not using the catch-all "-Wl, -undefined, dy

Re: [libstdc++ testsuite] all_attributes.cc failures

2015-01-31 Thread Iain Sandoe
On 31 Jan 2015, at 15:38, David Edelsohn wrote: > > The new testcases are producing new failures on AIX > > /nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc:29:16: > error: expected ')' before numeric constant > /nasfarm/edelsohn/src/src/libstdc++-v3/te

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2015-02-01 Thread Iain Sandoe
This is a GCC5 bootstrap regression on 32bit Darwin hosts ( I can raise a PR if that is considered necessary). In fact it is not libcc1, but libiberty that is the cause - On 26 Jan 2015, at 14:13, Rainer Orth wrote: > FX writes: > >>> The default BOOT_CFLAGS are: -O2 -g -mdynamic-no-pic >>>

Re: [patch] Fix invalid attributes in libstdc++

2015-02-03 Thread Iain Sandoe
Hi Jonathan, On 1 Feb 2015, at 15:10, Jonathan Wakely wrote: > On 01/02/15 15:08 +, Jonathan Wakely wrote: >> I failed to CC gcc-patches on this patch ... >> >> On 29/01/15 13:02 +, Jonathan Wakely wrote: >>> Jakub pointed out that we have some attributes that don't use the >>> reserved

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2015-02-11 Thread Iain Sandoe
Hi Jeff, On 9 Feb 2015, at 14:47, Jeff Law wrote: > On 02/01/15 09:42, Iain Sandoe wrote: >> >> This is a GCC5 bootstrap regression on 32bit Darwin hosts ( I can raise a PR >> if that is considered necessary). > Has this been addressed or is it still pending? I bel

Re: [PATCH 1/n] OpenMP 4.0 offloading infrastructure

2015-02-21 Thread Iain Sandoe
Hi Thomas, On 20 Feb 2015, at 19:46, Thomas Schwinge wrote: > On Fri, 20 Feb 2015 11:35:18 -0800, Mike Stump wrote: >> On Feb 20, 2015, at 6:36 AM, Ilya Verbin wrote: >>> I assumed that nobody would build an offloading compiler with >>> --enable-languages >>> other than c,c++,fortran[,lto]. >>

Re: [PATCH] Fix ICF sem_function::merge (PR target/63892)

2015-02-21 Thread Iain Sandoe
Hi Jakub, Martin, On 20 Feb 2015, at 16:42, Jeff Law wrote: > On 02/20/15 07:48, Jakub Jelinek wrote: >> Hi! >> >> As written in the PR, the sibcall-3.c testcase fails on Darwin, because >> !sem_item::target_supports_symbol_aliases_p () and we don't really try >> redirect_callers, even when that

Re: [PARCH 1/2, x86, PR63534] Fix darwin bootstrap

2014-11-08 Thread Iain Sandoe
Hi Jeff, On 7 Nov 2014, at 20:28, Jeff Law wrote: > On 11/06/14 06:01, Evgeny Stupachenko wrote: >> Now I see that equiv reload could be special for PIC register. Let's >> apply more conservative patch. >> >> Darwin bootstrap passed with the patch applied on r216304 (along with >> already commit

Re: [PATCH] Don't bootstrap libcc1

2014-11-08 Thread Iain Sandoe
On 8 Nov 2014, at 15:41, Jakub Jelinek wrote: > On Sat, Nov 08, 2014 at 04:31:28PM +0100, Dominique d'Humières wrote: >> I am still unable to bootstrap darwin14 without revision r216964 reverted. >> Executing the simplified command >> >> /opt/gcc/build_w/gcc/xg++ -B/opt/gcc/build_w/gcc/ >> -L/

Re: [PATCH] Don't bootstrap libcc1

2014-11-09 Thread Iain Sandoe
Jack, Dominique, I think we have two issues here - let's make sure we don't derail dealing with the first one. On 8 Nov 2014, at 22:08, Jack Howarth wrote: >That is curious. I wouldn't have thought that the compiler > selection would have had such a radical effect on the linkage flags > emi

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-09 Thread Iain Sandoe
Hi Jack, comments below apply also to the patch for PR63699 On 7 Nov 2014, at 17:13, Jack Howarth wrote: > The attached revised patch eliminates the compilation error... > > error: use of undeclared > identifier 'do_not_use_toupper_with_safe_ctype' > > on x86_64-apple-darwin14 when boots

Re: [PATCH, C++, SD-6] Add __cpp_aggregate_nsdmi macro now that we nave them.

2014-11-12 Thread Iain Sandoe
Hi Ed, On 2 Nov 2014, at 01:48, Ed Smith-Rowland wrote: > > please take a look at PR63834, as https://gcc.gnu.org/ml/gcc-cvs/2014-11/msg00307.html breaks bootstrap on x86064-darwin12, the reproducer also segvs on x86-64-linux. (It looks like the commit was related to this series of patches)

[PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-12 Thread Iain Sandoe
eeling be about back-porting? Iain libatomic: * config/darwin/host-config.h New. * config/darwin/lock.c New. * configure.tgt (DEFAULT_X86_CPU): New, (target): New entry for darwin. From fdbf91b9fb20992231a370f0e5cd803085b4f69e Mon Sep 17 00:00:00 2001 From: Iain Sandoe Da

[PATCH, Darwin, testsuite] Fix PR 63891.

2019-05-21 Thread Iain Sandoe
This is a testcase failing because one part of the codegen is (correctly) generating the scan-asm-not signature. Fixed by altering the build options. tested on x86_64-darwin16, applied to mainline, Iain gcc/testsuite/ 2019-05-21 Iain Sandoe PR target/63891 * gcc.dg/darwin

<    5   6   7   8   9   10   11   12   13   14   >