Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055)

2011-07-12 Thread Gabriel Charette
needed... Any idea why lto doesn't call lto_output_chain, but simply lto_output_tree to output the chains for struct/union? Gab On Tue, Jul 12, 2011 at 12:21 PM, Diego Novillo wrote: > On Fri, Jul 8, 2011 at 21:20, Gabriel Charette wrote: > >> 2011-07-08  Gabriel Charet

Re: [pph] Fix 3 asm differences (issue4695048)

2011-07-12 Thread Gabriel Charette
On Tue, Jul 12, 2011 at 3:25 PM, Diego Novillo wrote: > On 11-07-12 16:34 , Gabriel Charette wrote: > >> We probably want pph_register_decl_in_symtab to be inline as it does >> so little now. > > It doesn't really matter all that much.  Given that it's a st

Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055)

2011-07-12 Thread Gabriel Charette
On Tue, Jul 12, 2011 at 3:32 PM, Diego Novillo wrote: > On 11-07-12 16:43 , Gabriel Charette wrote: > >> Even if this doesn't break tests anymore, we probably still want this, >> no point adding stuff to the pph image that is not needed... > > Actually, the reverse i

Re: [pph] Add symbol table - Fix remaining asm differences (issue4732043)

2011-07-15 Thread Gabriel Charette
Nice solution :)! A few things inline below: > +  /* Read and process the symbol table.  */ > +  pph_in_symtab (stream); >  } > Why read the symbol table last? I would expect that we would read this first, before reading the bindings, then we don't need to change the actual pph_in_* functions to

[pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

2011-07-15 Thread Gabriel Charette
adiff variable) Gab 2011-07-15 Gabriel Charette * g++.dg/pph/c1builtin-integral.cc: Add expected diff checksum. * g++.dg/pph/c1eabi1.cc: Add expected diff checksum. * g++.dg/pph/p4eabi1.cc: Add expected diff checksum. * lib/dg-pph.exp (dg-pph-pos): Expect checks

[pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

2011-07-15 Thread Gabriel Charette
Reviewed in person by Lawrence. Shortened XFAIL message from previous patch. Also, quick side note, in the first description of this patch I said I used "exec grep", I meant "exec diff". Gab 2011-07-15 Gabriel Charette * g++.dg/pph/c1builtin-integral.cc: Add ex

Re: [pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

2011-07-18 Thread Gabriel Charette
On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab wrote: > > gch...@google.com (Gabriel Charette) writes: > > > +         set expectedSum [exec tr -d \} << [exec cut -f 4 -d\  << > > $xdiff_entry]] $xdiffentry is set to something like {{pph asm diff 123456}}

[pph] Output checksum for new unexpected diff (issue4768041)

2011-07-18 Thread Gabriel Charette
e TCL functions as suggested by Andreas Schwab in issue 4744043 (which was already commited then). 2011-07-18 Gabriel Charette * lib/dg-pph.exp (dg-pph-pos): Output actualSum on unexpected diff. Use native TCL functions instead of exec calls to tr and cut. diff --git a/gcc/test

Re: [pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

2011-07-18 Thread Gabriel Charette
On Mon, Jul 18, 2011 at 3:05 PM, Andreas Schwab wrote: > Gabriel Charette writes: > >> On Sat, Jul 16, 2011 at 12:59 AM, Andreas Schwab >> wrote: >>> >>> gch...@google.com (Gabriel Charette) writes: >>> >>> > +  

[pph] Fix c1builtin-integral (issue4761045)

2011-07-18 Thread Gabriel Charette
The issue was that we were compiling the pph with some flags and weren't doing so in the rest of the compilation (pph and non-pph), resulting in different outputs. The fact that pph would let this happen is potentially a problem and I opened a separate thread "Flags and pph..." to discuss this.

[pph] Add filter to prevent streaming out builtin identifiers (issue4802047)

2011-07-20 Thread Gabriel Charette
strap build and pph regression testing. diff --git a/libcpp/ChangeLog.pph b/libcpp/ChangeLog.pph index de21994..c0ef9f6 100644 --- a/libcpp/ChangeLog.pph +++ b/libcpp/ChangeLog.pph @@ -1,3 +1,7 @@ +2011-07-20 Gabriel Charette + + * symtab.c (cpp_lt_capture): Filter out builtin identi

[pph] Add filter to prevent streaming out builtin identifiers (issue4802047)

2011-07-20 Thread Gabriel Charette
Changed to use new cpp_is_builtin inline function. Gab diff --git a/libcpp/ChangeLog.pph b/libcpp/ChangeLog.pph index de21994..36369a5 100644 --- a/libcpp/ChangeLog.pph +++ b/libcpp/ChangeLog.pph @@ -1,3 +1,9 @@ +2011-07-20 Gabriel Charette + + * include/cpplib.h (cpp_is_builtin): New

[pph] Ignore line number in diff checksum (issue4800046)

2011-07-22 Thread Gabriel Charette
n a previous checkin. Tested with pph regression testing. Gab diff --git a/gcc/testsuite/ChangeLog.pph b/gcc/testsuite/ChangeLog.pph index 7ffeaf2..c90ab86 100644 --- a/gcc/testsuite/ChangeLog.pph +++ b/gcc/testsuite/ChangeLog.pph @@ -1,3 +1,10 @@ +2011-07-22 Gabriel Charette + + * g++.dg/pp

Re: [pph] Save pending and specialized templates (issue4814054)

2011-07-26 Thread Gabriel Charette
See comments inline. > + > +/* PPH write/read */ > + > + > +/* Emit a tinst_level list TINST to STREAM.  */ > + > +static void > +pph_out_tinst_level (pph_stream *stream, struct tinst_level *tinst) > +{ > +  int count; > +  struct tinst_level *cur; > + > +  /* Count the number of items.  */ > +  f

Remove unused line_maps field last_listed (issue4810058)

2011-07-28 Thread Gabriel Charette
The last_listed field in struct line_maps was never used, removed it. Gab 2011-07-28 Gabriel Charette * libcpp/include/line-map.h (struct line_maps): Remove unused field last_listed. diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h index 3234423..f1d5bee

Re: [pph] Free buffers used during tree encoding/decoding

2011-07-29 Thread Gabriel Charette
I just stashed all my changes and pulled in the latest svn HEAD this morning to check if I was seeing these failures: Repository Root: svn+ssh://gcc.gnu.org/svn/gcc Repository UUID: 138bc75d-0d04-0410-961f-82ee72b054a4 Revision: 176906 Node Kind: directory Schedule: normal Last Changed Author: cro

Remove line 0 hack in cp/decl.c (issue4835047)

2011-08-01 Thread Gabriel Charette
ven in his 2005 commit has been removed on 2009-10-08 by m...@suse.de according to ChangeLog-2009. This patch removes this hack which appears to be no longer necessary. Tested with a full bootstrap build and regression testing on x64. Gabriel 2011-08-01 Gabriel Charette

<    1   2