On Tue, Jul 12, 2011 at 3:32 PM, Diego Novillo <dnovi...@google.com> wrote: > On 11-07-12 16:43 , Gabriel Charette wrote: > >> Even if this doesn't break tests anymore, we probably still want this, >> no point adding stuff to the pph image that is not needed... > > Actually, the reverse is true. We want to write out the IL exactly as the > original parser emitted it. There are things we decide not to write because > they are better re-generated when the pph image is being read (e.g., > function numbers, DECL_RTL), but >
Well so lto_input_chain, called from pph_in_chain for every single chain, already reconstructs the DECL_CHAIN on input (DECL_CHAIN is actually set to NULL before streaming it out each element in the chain anyways). The only case where that wasn't true was when we output structs (and unions I think: we need to add a test for unions), because structs don't seem to use output chain (I don't have the code in front of me, but I know they would only output the tree (i.e. the tree was, in that case, responsible for streaming its DECL_CHAIN)). I'm surprised it no longer breaks... I'll have a look when I come back on Friday if it's still a debated issue then. Gab
