Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-04-16 Thread Chung-Lin Tang
On 2016/3/29 09:35 PM, Martin Jambor wrote: > Hi, > > On Sun, Mar 27, 2016 at 06:26:29PM +0800, Chung-Lin Tang wrote: >> On 2016/3/25 上午 02:40, Martin Jambor wrote: >>> On the whole, I am fine with the patch but there are two issues: >>> >>> First, and

Re: [PATCH 1/4, libgomp] Resolve deadlock on plugin exit

2016-04-16 Thread Chung-Lin Tang
Ping. On 2016/3/21 06:21 PM, Chung-Lin Tang wrote: > Hi, this is the set of patches from > https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01411.html > revised again, this time also with audits for the HSA plugin. > > The changes are pretty minor, mainly that the unload_image hook

Re: [PATCH, libgomp] Fix deadlock in acc_set_device_type

2016-04-16 Thread Chung-Lin Tang
Ping. On 2016/3/28 05:45 PM, Chung-Lin Tang wrote: > Hi Jakub, there's a path for deadlock on acc_device_lock when going > through the acc_set_device_type() OpenACC library function. > Basically, the gomp_init_targets_once() function should not be > called with that held. The att

Re: [PATCH, libgomp] Rewire OpenACC async

2016-04-16 Thread Chung-Lin Tang
Ping. On 2016/4/8 07:02 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: >> I've updated this patch for trunk (as attached), and re-tested without >> regressions. This patch is still a fix for >> libgomp.oacc-c-c++-common/asyncwa

Re: [PATCH, libgomp] Fix deadlock in acc_set_device_type (ping x2)

2016-04-19 Thread Chung-Lin Tang
Ping x2. Hi Jakub, This patch is fairly straightforward, and solves a easily encountered deadlock. Please approve for trunk and gcc-6-branch. Thanks, Chung-Lin On 2016/4/16 03:39 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/3/28 05:45 PM, Chung-Lin Tang wrote: >> Hi Jakub, the

Re: [patch, libgomp, OpenACC] Additional enter/exit data map handling

2016-09-08 Thread Chung-Lin Tang
On 2016/9/6 8:11 PM, Thomas Schwinge wrote: > Hi! > > On Mon, 29 Aug 2016 15:46:47 +0800, Chung-Lin Tang > wrote: >> this patch is a port of some changes from gomp-4_0-branch, >> including adding additional map type handling in OpenACC enter/exit data >> di

Re: [patch] Fix PR fortran/72743

2016-09-09 Thread Chung-Lin Tang
On 2016/9/1 03:13 PM, Richard Biener wrote: > On Wed, 31 Aug 2016, Chung-Lin Tang wrote: > >> Hi Richard, Martin, >> this issue is actually sort of like PR 70856, basically the same ICE >> after IPA-ICF, due to DECL_PT_UIDs not consistent after reaching for the

Re: [patch, libgomp, OpenACC] Additional enter/exit data map handling

2016-09-18 Thread Chung-Lin Tang
Ping. On 2016/9/6 7:45 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/8/29 03:46 PM, Chung-Lin Tang wrote: >> Hi Jakub, >> this patch is a port of some changes from gomp-4_0-branch, >> including adding additional map type handling in OpenACC enter/exit data >>

[PATCH, OpenACC, Fortran] Fix PR77371, ICE on allocatable

2016-10-02 Thread Chung-Lin Tang
Hi Jakub, This patch fixes the two ICEs listed on PR77371. One is due to the Fortran omp_privatize_by_reference hook returning true for types like 'character(kind=1)[1:XX] *', causing them to be processed by the path intended for C++ reference types. The other one is simply not setting 'remove = t

Re: [patch, libgomp, OpenACC] Additional enter/exit data map handling

2016-11-03 Thread Chung-Lin Tang
Ping this patch again. On 2016/9/21 12:43 AM, Cesar Philippidis wrote: >> +/* Returns the number of mappings associated with the pointer or pset. PSET >> > + have three mappings, whereas pointer have two. */ >> > + >> > static int >> > -find_pset (int pos, size_t mapnum, unsigned short *kinds

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x3)

2016-07-13 Thread Chung-Lin Tang
Ping x3 On 06/21/2016 02:18 PM, Chung-Lin Tang wrote: Ping x2 On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: Ping. On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: Hi, this patch resolves an ICE for Fortran when using the

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)

2016-07-21 Thread Chung-Lin Tang
Ping x4 On 2016/7/13 7:52 PM, Chung-Lin Tang wrote: > Ping x3 > > On 06/21/2016 02:18 PM, Chung-Lin Tang wrote: >> Ping x2 >> >> On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: >>> Ping. >>> >>> On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-07-29 Thread Chung-Lin Tang
On 2016/7/21 07:13 PM, Jakub Jelinek wrote: > Better put every && on a separate line if the whole if (...) doesn't fit > on a single line. > >> > +&& !n->sym->attr.cray_pointer >> > +&& !n->sym->attr.cray_pointee) > This is too ugly. I'd instead move the if

Re: [Patch 2/5] OpenACC tile clause support, omp-low parts

2016-11-29 Thread Chung-Lin Tang
Adjusted and re-tested using the way you advised, attached updated patch. Thanks, Chung-Lin On 2016/11/18 7:15 PM, Jakub Jelinek wrote: > Hi! > > On Thu, Nov 17, 2016 at 05:31:40PM +0800, Chung-Lin Tang wrote: >> +#ifndef ACCEL_COMPILER >> + span = integer_one_node; >&g

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-29 Thread Chung-Lin Tang
On 2016/11/18 7:23 PM, Jakub Jelinek wrote: > On Thu, Nov 17, 2016 at 05:34:34PM +0800, Chung-Lin Tang wrote: >> Updated C/C++ front-end patches, adjusted as reviewed. > > Jason is right, finish_omp_clauses will verify the tile operands > when !processing_template_decl are

Re: [patch, libgomp, OpenACC] Additional enter/exit data map handling

2016-12-06 Thread Chung-Lin Tang
Ping. On 2016/11/3 10:22 PM, Chung-Lin Tang wrote: > > Ping this patch again. > > On 2016/9/21 12:43 AM, Cesar Philippidis wrote: >>> +/* Returns the number of mappings associated with the pointer or pset. PSET >>>> + have three mappings, whereas pointer have

Re: [Patch 4/5] OpenACC tile clause support, Fortran front-end parts

2016-12-14 Thread Chung-Lin Tang
On 2016/11/30 10:47 AM, Cesar Philippidis wrote: > On 11/18/2016 03:24 AM, Jakub Jelinek wrote: >> On Sat, Nov 12, 2016 at 08:51:00AM -0800, Cesar Philippidis wrote: >>> On 11/11/2016 02:34 AM, Jakub Jelinek wrote: >>>> On Thu, Nov 10, 2016 at 06:46:46PM +0800, Chu

[PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-09 Thread Chung-Lin Tang
ins a little bit of adjustments in fortran/openmp.c:resolve_omp_clauses(), and some testcase adjustments. This has been tested without regressions for Fortran. Is this okay for trunk? Thanks, Chung-Lin 2015-05-09 Chung-Lin Tang gcc/ * fortran/openmp.c (resolve_omp_cl

Re: [PATCH, libgomp] Rewire OpenACC async (Ping x3)

2016-05-10 Thread Chung-Lin Tang
Ping x3 On 2016/4/16 3:40 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/4/8 07:02 PM, Chung-Lin Tang wrote: >> Ping. >> >> On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: >>> I've updated this patch for trunk (as attached), and re-tested without >&

Re: [PATCH, libgomp] Fix deadlock in acc_set_device_type (ping x3)

2016-05-10 Thread Chung-Lin Tang
Ping x3 On 2016/4/19 10:30 PM, Chung-Lin Tang wrote: > Ping x2. > > Hi Jakub, > This patch is fairly straightforward, and solves a easily encountered > deadlock. Please approve for trunk and gcc-6-branch. > > Thanks, > Chung-Lin > > On 2016/4/16 03:39 PM,

Re: [PATCH 1/4, libgomp] Resolve deadlock on plugin exit (Ping x2)

2016-05-10 Thread Chung-Lin Tang
Ping x2 On 2016/4/16 3:39 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/3/21 06:21 PM, Chung-Lin Tang wrote: >> Hi, this is the set of patches from >> https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01411.html >> revised again, this time also with audits for the HSA pl

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-17 Thread Chung-Lin Tang
On 2016/5/12 6:56 PM, Jakub Jelinek wrote: > On Thu, May 12, 2016 at 12:47:18PM +0200, Thomas Schwinge wrote: >> Hi! >> >> On Thu, 12 May 2016 12:02:58 +0200, Jakub Jelinek wrote: >>> ABI incompatible change for the plugin >>> interface (affecting OpenACC capable plugins only), I think you just sh

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-18 Thread Chung-Lin Tang
On 2016/5/17 5:00 PM, Jakub Jelinek wrote: > On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote: >> I assume that bumping GOMP_VERSION in include/gomp-constants.h would be >> enough? > > I think so. > > Jakub > How is this patch? I have added

Re: [nios2, committed] fix bad assertion

2016-05-21 Thread Chung-Lin Tang
On 2015/6/30 1:01 AM, Sandra Loosemore wrote: > When I was preparing to regression-test something else in a nios2-linux-gnu > build, I discovered it was ICE'ing while building > shared libraries with -fpic (glibc, libgomp). I tracked this down to having > started with r224048, but on further inv

[PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-08-27 Thread Chung-Lin Tang
e without regressions for both accel targets, is this okay for trunk? Thanks, Chung-Lin 2015-08-27 Chung-Lin Tang * oacc-host.c (host_init_device): Change return type to bool. (host_fini_device): Likewise. (host_dev2host): Likewise. (host_host2dev): Likewise.

[PATCH 2/3, libgomp] nvptx plugin parts

2015-08-27 Thread Chung-Lin Tang
These are the nvptx plugin specific parts. Chung-Lin * plugin/plugin-nvptx.c (CUDA_CALL_ERET): New convenience macro. (CUDA_CALL): Likewise. (CUDA_CALL_ASSERT): Likewise. (map_init): Change return type to bool, use CUDA_CALL* macros. (map_fini): Likewise.

[PATCH 3/3, libgomp] intelmic specific parts

2015-08-27 Thread Chung-Lin Tang
These are the intelmic plugin specific parts (actually beneath liboffloadmic instead of libgomp). The changes are basically to expose the return value of offload() back to libgomp. I only checked parts of the plugin, it appears that there may still be code in the liboffloadmic runtime that can cal

[PATCH] Propagate -fdiagnostics-* options in lto-wrapper

2015-09-06 Thread Chung-Lin Tang
per. I've tested this patch without regressions, is this okay for trunk? Thanks, Chung-Lin 2015-09-06 Chung-Lin Tang * lto-wrapper.c (merge_and_complain): Add OPT_fdiagnostics_show_caret, OPT_fdiagnostics_show_option, OPT_fdiagnostics_show_location_, and OPT_

Re: [gomp4] force global locks for nvptx targets

2015-09-09 Thread Chung-Lin Tang
ks in worker reductions. We're still investigating that > issue, but for the time being, global locks appear to work albeit with a > lock contention penalty. > > I've applied this patch to gomp-4_0-branch. > > Cesar > Fixed typo, committed as obvious. Chung-Lin 201

Re: [PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-09-09 Thread Chung-Lin Tang
Ping. On 2015/8/27 09:44 PM, Chung-Lin Tang wrote: > We've discovered that, for several of the libgomp plugin interface routines, > if the target specific routine calls exit() (usually upon a fatal condition), > deadlock ensues. We found this using nvptx, but it's possible on

[patch 0/5] OpenACC tile clause support

2016-11-10 Thread Chung-Lin Tang
Hi Jakub, this patch set is a port of the OpenACC tile clause functionality from the gomp4 branch. The tile clause allows the programmer to specify the tiling of an OpenACC loop nest. These patches were mostly implemented by Nathan, with the Fortran front-end bits by Cesar. I'm just upstreaming th

[Patch 1/5] OpenACC tile clause support, OMP_CLAUSE_TILE adjustments

2016-11-10 Thread Chung-Lin Tang
This patch contains a few supporting changes that adjusts how OMP_CLAUSE_TILE is handled. This is in support of the more elaborate omp-low.c changes in another patch. Thanks, Chung-Lin 2016-XX-XX Nathan Sidwell * tree.h (OMP_CLAUSE_TILE_ITERVAR, OMP_CLAUSE_TILE_COUNT): New. *

[Patch 2/5] OpenACC tile clause support, omp-low parts

2016-11-10 Thread Chung-Lin Tang
This part is the bulk of the patch set. It consists of the definition of the GOACC_TILE internal fn, the lowering/expanding of this in omp-low, as well as loop auto-partitioning adjustments that help improve generated code. This patch corresponds to the gomp4 committed patches: https://gcc.gnu.org

[Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-10 Thread Chung-Lin Tang
These are the patches for the C/C++ front-ends, along with the testsuite patches. Thanks, Chung-Lin 2016-XX-XX Nathan Sidwell c/ * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. (c_parser_oacc_clause_tile): Disallow collapse. Fix parsing and semantic

[Patch 5/5] OpenACC tile clause support, libgomp testsuite patches

2016-11-10 Thread Chung-Lin Tang
Some additional tests and adjustments to existing ones were made. 2016-XX-XX Nathan Sidwell Chung-Lin Tang libgomp/ * testsuite/libgomp.oacc-c-c++-common/tile-1.c: New. * testsuite/libgomp.oacc-c-c++-common/loop-auto-1.c: Adjust and add additional

[Patch 4/5] OpenACC tile clause support, Fortran front-end parts

2016-11-10 Thread Chung-Lin Tang
The Fortran front-end patches. These were originally written by Cesar. Thanks, Chung-Lin 2016-XX-XX Cesar Philippidis fortran/ * openmp.c (resolve_oacc_positive_int_expr): Promote the warning to an error. (resolve_oacc_loop_blocks): Use integer zero to represen

Re: [PATCH] OpenACC routines -- c++ front end

2016-11-11 Thread Chung-Lin Tang
On 2016/11/12 07:43 AM, Cesar Philippidis wrote: > Like it's c FE counterpart, this contains the following changes: > > * Updates c_parser_oacc_shape_clause to accept a location_t >argument in order to make the diagnostics more precise. > > * Adds support for the bind and nohost clauses. >

[patch, nios2] Fix PR78357, adjust sync builtin initialization

2016-11-16 Thread Chung-Lin Tang
This patch adjusts the initialization of __sync built-in functions: instead of conditionalizing on TARGET_LINUX_ABI, directly place the target-hook #define in config/nios2/linux.h. This appears to be in line with other similar ports, e.g. m68k. Sebastian, this should solve your issue of not wanti

Re: [Patch 1/5] OpenACC tile clause support, OMP_CLAUSE_TILE adjustments

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 5:38 PM, Jakub Jelinek wrote: > Hi! > > On Thu, Nov 10, 2016 at 06:44:52PM +0800, Chung-Lin Tang wrote: > > Above this it is fine. > >> @@ -9388,10 +9373,23 @@ gimplify_omp_for (tree *expr_p, gimple_seq *pre_p) >>

Re: [Patch 2/5] OpenACC tile clause support, omp-low parts

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 6:00 PM, Jakub Jelinek wrote: > On Thu, Nov 10, 2016 at 06:45:10PM +0800, Chung-Lin Tang wrote: >> 2016-XX-XX Nathan Sidwell >> >> * internal-fn.def (GOACC_DIM_POS): Comment may be overly >> conservative. >> (GOACC_TILE)

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Chung-Lin Tang
On 2016/11/11 6:30 PM, Jakub Jelinek wrote: > On Thu, Nov 10, 2016 at 06:46:16PM +0800, Chung-Lin Tang wrote: >> 2016-XX-XX Nathan Sidwell >> >> c/ >> * c-parser.c (c_parser_omp_clause_collapse): Disallow tile. >> (c_parser_oacc_cla

Re: [patch, nios2] Fix PR78357, adjust sync builtin initialization

2016-11-24 Thread Chung-Lin Tang
On 2016/11/24 6:28 AM, Jeff Law wrote: > On 11/16/2016 02:53 AM, Chung-Lin Tang wrote: >> This patch adjusts the initialization of __sync built-in functions: >> instead of conditionalizing on TARGET_LINUX_ABI, directly place the >> target-hook #define in config/nios2/linux.h

[PATCH 2/3, libgomp] Resolve libgomp plugin deadlock on exit, nvptx parts

2015-12-14 Thread Chung-Lin Tang
These are the nvptx parts. Thanks, Chung-Lin * plugin/plugin-nvptx.c (CUDA_CALL_ERET): New convenience macro. (CUDA_CALL): Likewise. (CUDA_CALL_ASSERT): Likewise. (map_init): Change return type to bool, use CUDA_CALL* macros. (map_fini): Likewise. (

[PATCH 3/3, libgomp] Resolve libgomp plugin deadlock on exit, intelmic parts

2015-12-14 Thread Chung-Lin Tang
Hi Ilya, thanks for the prior review (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01893.html), This version is mostly a like the prior one, with some minor code updates. Thanks, Chung-Lin 2015-12-14 Chung-Lin Tang * plugin/libgomp-plugin-intelmic.cpp (offload): Change return type

[PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2015-12-14 Thread Chung-Lin Tang
patch is the changes for the machine independent libgomp proper. The entire patch set was tested without regressions. Is this okay for trunk? Thanks, Chung-Lin 2015-12-14 Chung-Lin Tang * target.c (gomp_device_copy): New function. (gomp_copy_host2dev): Likewise

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-22 Thread Chung-Lin Tang
Ping. On 2015/11/24 6:27 PM, Chung-Lin Tang wrote: > Hi, this patch reworks some of the way that asynchronous copyouts are > implemented for OpenACC in libgomp. > > Before this patch, we had a somewhat confusing way of implementing this > by having two refcounts for each mappin

[PATCH] OpenACC use_device clause ICE fix

2016-01-05 Thread Chung-Lin Tang
Hi, we've been encountering an ICE for OpenACC host_data sections, which has a use_device() clause similar to OpenMP use_device_ptr. The ICE happens in make_decl_rtl() for scan-created variables, which IIUC, should not be entered at all for automatic variables. I believe the problem is, unlike ot

Re: [PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2016-01-05 Thread Chung-Lin Tang
Patch has been updated to accommodate the gomp_fini_device() removal changes. And ping. On 2015/12/14 11:47 PM, Chung-Lin Tang wrote: > [sorry, forgot to C gcc-patches in last send] > > Hi Jakub, > these patches are a revision of > https://gcc.gnu.org/ml/gcc-patches/2015-0

Re: [PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2016-01-18 Thread Chung-Lin Tang
Ping x 2. On 2016/1/5 11:22 PM, Chung-Lin Tang wrote: > Patch has been updated to accommodate the gomp_fini_device() removal changes. > And ping. > > On 2015/12/14 11:47 PM, Chung-Lin Tang wrote: >> [sorry, forgot to C gcc-patches in last send] >> >> Hi Jakub, >

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-18 Thread Chung-Lin Tang
Ping. On 2016/1/5 10:15 PM, Chung-Lin Tang wrote: > Hi, > we've been encountering an ICE for OpenACC host_data sections, which > has a use_device() clause similar to OpenMP use_device_ptr. > > The ICE happens in make_decl_rtl() for scan-created variables, which IIUC, > s

Re: section anchors and weak hidden symbols

2013-05-08 Thread Chung-Lin Tang
On 2013/5/9 04:11 AM, Bernhard Reutner-Fischer wrote: > On 8 May 2013 15:11:18 Jan Hubicka wrote: >> > 2013-05-08 Nathan Sidwell >> > gcc/ >> > * varasm.c (default_use_anchors_for_symbol_p): Reject WEAK. >> > gcc/testsuite/ >> > * gcc.dg/visibility-21.c: New. >> > Index: gcc/var

[PATCH] PR32219, weak hidden reference segfault

2013-05-09 Thread Chung-Lin Tang
ression from the PR32219 discussion, that the solution should be to make all weak-hidden-undefined symbols as potentially non-local. However, I don't think that is needed, no? As long as the linker added zero value is in the same module, weak hidden semantics should remain just the same

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-13 Thread Chung-Lin Tang
On 13/5/13 11:15 AM, Kugan wrote: > Hi, > > Ping this patch by Chung-Lin. > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html > > This patch allows lr registers to be used in leaf functions for ARM. > > There were some concerns about performance regression in thumb2 mode for > CoreMark. Ho

Re: [PATCH 2/5] Altera Nios II: libgcc

2013-05-14 Thread Chung-Lin Tang
On 13/4/26 4:00 AM, Joseph S. Myers wrote: > On Thu, 18 Apr 2013, Chung-Lin Tang wrote: > >> +nios2-*-linux*) >> +tmake_file="$tmake_file nios2/t-nios2 nios2/t-linux t-libgcc-pic >> t-slibgcc-libgcc" >> +extra_parts="$extra_parts crti.o

Re: [PATCH 0/5] Submission of Altera Nios II port

2013-05-14 Thread Chung-Lin Tang
On 2013/4/26 04:35 AM, Joseph S. Myers wrote: > I should ask the following general standard new-port questions: > > * Does the port build cleanly when configured with --enable-werror-always > and built using a native compiler from current GCC trunk - for both 32-bit > host, and 64-bit host? It

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Chung-Lin Tang
On 13/5/10 6:37 PM, Richard Sandiford wrote: > Chung-Lin Tang writes: >> +case UNSPEC: >> + /* Reach for a contained symbol. */ >> + return nonzero_address_p (XVECEXP (x, 0, 0)); > > I don't think this is safe. UNSPECs really are unspecified :-), &

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-15 Thread Chung-Lin Tang
On 13/5/15 9:43 PM, Kugan wrote: > On 14/05/13 19:18, Ramana Radhakrishnan wrote: >> On 05/13/13 04:15, Kugan wrote: >>> Hi, >>> >>> Ping this patch by Chung-Lin. >>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html >>> >>> This patch allows lr registers to be used in leaf functions for ARM.

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-31 Thread Chung-Lin Tang
On 13/5/15 8:12 PM, Richard Sandiford wrote: > Chung-Lin Tang writes: >> On 13/5/10 6:37 PM, Richard Sandiford wrote: >>> Chung-Lin Tang writes: >>>> +case UNSPEC: >>>> + /* Reach for a contained symbol. */ >>>> + return nonzer

[PING] Re: [PATCH 0/5] Submission of Altera Nios II port

2013-06-05 Thread Chung-Lin Tang
Pinging the nios2 port. On 13/5/15 1:04 AM, Chung-Lin Tang wrote: > On 2013/4/26 04:35 AM, Joseph S. Myers wrote: >> I should ask the following general standard new-port questions: >> >> * Does the port build cleanly when configured with --enable-werror-always >&g

Re: [ping**2] Nios II port

2013-06-18 Thread Chung-Lin Tang
On 13/6/18 上午3:05, Sandra Loosemore wrote: > Ping? I think these are the most recent versions of the unreviewed > patches in the series: > > http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00287.html > http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00760.html > http://gcc.gnu.org/ml/gcc-patches/2013-0

Re: [PATCH] PR32219, weak hidden reference segfault [PING]

2013-06-20 Thread Chung-Lin Tang
Ping again? On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: > ping, CCing middle-end maintainers for review. > > On 31 May 2013 10:13, Chung-Lin Tang wrote: >> On 13/5/15 8:12 PM, Richard Sandiford wrote: >>> Chung-Lin Tang writes: >>>> On 13/5

[PING^3] Nios II port

2013-06-24 Thread Chung-Lin Tang
Ping x 3. On 13/6/18 下午4:38, Chung-Lin Tang wrote: > On 13/6/18 上午3:05, Sandra Loosemore wrote: >> > Ping? I think these are the most recent versions of the unreviewed >> > patches in the series: >> > >> > http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00

[PATCH][2/3] Re-submission of Altera Nios II port, testsuite parts

2013-07-14 Thread Chung-Lin Tang
These are nios2 patches for the gcc testsuite. Some new testcases were added since the last posting. Chung-Lin 2013-07-14 Sandra Loosemore Chung-Lin Tang Based on patches from Altera Corporation * gcc.dg/stack-usage-1.c (SIZE): Define case for __nios2__

[PATCH][3/3] Re-submission of Altera Nios II port, libgcc parts

2013-07-14 Thread Chung-Lin Tang
nios2 libgcc parts. Since the original post, the only main change has been the fdpbit vs soft-fp issue raised by Joseph, which has been resolved. Other parts are mostly the same. Thanks, Chung-Lin 2013-07-14 Sandra Loosemore Chung-Lin Tang Based on patches from

[PATCH] Hexadecimal numbers in option arguments

2013-07-14 Thread Chung-Lin Tang
use IXDIGIT to check the argument string first, as you suggested in the last submission. Is this okay for trunk? Thanks, Chung-Lin 2013-07-14 Chung-Lin Tang * opts-common.c (integral_argument): Add support for hexadecimal command option integer arguments. Update comments. Index

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-07-14 Thread Chung-Lin Tang
Ping. On 2013/6/20 03:01 PM, Chung-Lin Tang wrote: > Ping again? > > On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: >> ping, CCing middle-end maintainers for review. >> >> On 31 May 2013 10:13, Chung-Lin Tang wrote: >>> On 13/5/15 8:12 PM, Richard

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-01 Thread Chung-Lin Tang
On 13/8/1 5:16 PM, Bernhard Reutner-Fischer wrote: > On 14 July 2013 19:43, Diego Novillo wrote: >> On Sun, Jul 14, 2013 at 2:08 AM, Chung-Lin Tang >> wrote: >>> Ping. >> >> Could you please repost the patch with its description? This thread >> is su

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-04 Thread Chung-Lin Tang
into trunk (patch attached again for convenience). Thanks, Chung-Lin 2013-08-04 Chung-Lin Tang PR target/32219 * rtlanal.c (nonzero_address_p): Robustify checking by look recursively into PIC c

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 10:06 PM, Mike Stump wrote: > On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: >> On 13/7/15 1:43 AM, Diego Novillo wrote: >>> Could you please repost the patch with its description? This thread >>> is sufficiently old and noisy that I'm not even sure

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 下午10:24, Mike Stump wrote: > On Aug 5, 2013, at 7:15 AM, Chung-Lin Tang wrote: >> On 13/8/5 10:06 PM, Mike Stump wrote: >>> On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang wrote: >>>> On 13/7/15 1:43 AM, Diego Novillo wrote: >>>>> Could you

[PATCH 0/5] Submission of Altera Nios II port

2013-04-18 Thread Chung-Lin Tang
Hi, Mentor Graphics is submitting on behalf of Altera, a GCC port for the Nios II architecture. Attached are the series of patches, including a few small additions to machine-independent parts. We are proposing Sandra Loosemoore and myself (Chung-Lin Tang), both of Mentor Graphics, as port

[PATCH 2/5] Altera Nios II: libgcc

2013-04-18 Thread Chung-Lin Tang
These are patches for libgcc. 2013-04-18 Sandra Loosemore Chung-Lin Tang Based on patches from Altera Corporation * config.host (nios2-*-*,nios2-*-linux*): Add nios2 host cases. * config/nios2/lib2-nios2.h: New file. * config/nios2/lib2-divmod

[PATCH 3/5] Altera Nios II: testsuite patches

2013-04-18 Thread Chung-Lin Tang
Testsuite changes, including gcc.target tests, plus some selected filtering of some other tests. 2013-04-18 Sandra Loosemore Chung-Lin Tang Based on patches from Altera Corporation * gcc.dg/stack-usage-1.c (SIZE): Define case for __nios2__. * gcc.dg

[PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-18 Thread Chung-Lin Tang
This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT host dependency in dwarf generation. Nios II does not have need_64bit_hwint switched on during configuring, and ran into GDB test FAILs originating from this problem. 2013-04-18 Julian Brown * dwarf2out.c (gen_enum

[PATCH 5/5] Altera Nios II: hexadecimal numbers in options

2013-04-18 Thread Chung-Lin Tang
the code on the command line, we are proposing the attached patch to allow, for example '-mcustom-fadds=255' to be written as '-mcustom-fadds=0xff' 2013-04-18 Chung-Lin Tang * opts-common.c (integral_argument): Add support for hexadecimal command option integ

Re: [PATCH 3/5] Altera Nios II: testsuite patches

2013-04-18 Thread Chung-Lin Tang
On 2013/4/18 09:49 PM, Chung-Lin Tang wrote: > Testsuite changes, including gcc.target tests, plus some selected > filtering of some other tests. > > 2013-04-18 Sandra Loosemore > Chung-Lin Tang > Based on patches from Altera Corporation Mis

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Chung-Lin Tang
On 2013/4/19 12:56 AM, Cary Coutant wrote: > On Thu, Apr 18, 2013 at 6:49 AM, Chung-Lin Tang > wrote: >> This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT >> host dependency in dwarf generation. Nios II does not have >> need_64bit_hwint switched on

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-23 Thread Chung-Lin Tang
On 2013/4/23 01:35 AM, Cary Coutant wrote: >> A : host_integerp (value, TYPE_UNSIGNED (TREE_TYPE (value))) >> B : host_integerp (value, 0) >> >> AB AB AB AB >> type_size,hwi | 00 01 10 11 >> --+--- >> 32,32

Re: Reload codegen improvement

2014-01-23 Thread Chung-Lin Tang
On 14/1/8 12:22 AM, Bernd Schmidt wrote: > This fixes a problem identified by Chung-Lin. Once reload is done, all > equivalencing insns for pseudos that didn't get a hard reg but could be > eliminated using their REG_EQUIV are deleted. However, we still can > produce reloads and reload insns for th

[PATCH, nios2, committed] PR59784, fextsd asm output fix

2014-01-29 Thread Chung-Lin Tang
Hi Savin, I've committed your patch for PR59784; the fix seems small enough to accept directly. Thanks a lot for catching this. Thanks, Chung-Lin 2014-01-30 Savin Zlobec PR target/59784 * config/nios2/nios2.c (nios2_fpu_insn_asm): Fix asm output of SFmode to DFmode ca

[PATCH, nios2] Large -fPIC support

2014-02-20 Thread Chung-Lin Tang
This patch adds large GOT support for the Nios II backend. Tested by running glibc tests with -fPIC forced on. A few smaller libgcc fixes are also included as well. Patch committed. Chung-Lin 2014-02-20 Chung-Lin Tang Sandra Loosemore gcc/ * config/nios2/nios2

Re: [PATCH/middle-end 2/6] __builtin_thread_pointer and AARCH64 ILP32

2014-02-24 Thread Chung-Lin Tang
ster tpidr_el0 is 64-bit wide regardless of >> ILP32 or not, but in the abstracted view of AArch64 ILP32 world, the thread >> pointer shall be a 32-bit pointer; the OS should have taken care of the >> hardware register tpidr_el0 by having its higher 32 bits cleared. I think >> e

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-17 Thread Chung-Lin Tang
On 2014/7/18 上午 05:19, Joel Sherrill wrote: > Unless someone objects, I am going to commit this to the > 4.9 branch and head. > > --joel Sorry about the delay, I'll review it today. Thanks, Chung-Lin > On 7/7/2014 1:42 AM, Sebastian Huber wrote: >> Ping. >> >> On 2014-06-26 13:43, Sebastian Hub

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-17 Thread Chung-Lin Tang
For the default multilib settings, it looks like you just intended to use -mcustom-fpu-cfg=60-2. I suggest you modify t-rtems to do that instead of enumerating the individual FPU insn options. Other than that, the patch looks okay. Chung-Lin On 2014/6/26 07:43 PM, Sebastian Huber wrote: > diff -

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-18 Thread Chung-Lin Tang
On 14/7/18 2:30 PM, Chung-Lin Tang wrote: > For the default multilib settings, it looks like you just intended to > use -mcustom-fpu-cfg=60-2. I suggest you modify t-rtems to do that > instead of enumerating the individual FPU insn options. > > Other than that, the patch looks o

Re: [PATCH] gcc/config/nios2/nios2.c: Let custom_builtin_name[*] always be zero terminated string

2014-07-25 Thread Chung-Lin Tang
On 14/7/26 11:28 AM, Chen Gang wrote: > The related strncpy() for custom_builtin_name[*] may set 5 none-zero > characters, which may cause custom_builtin_name[*] is none-zero > terminated. > > So add additional '\0' byte for custom_builtin_name[*]. Where did you see this? Supposedly the snprintf

Re: [PATCH] gcc/config/nios2/nios2.c: Let custom_builtin_name[*] always be zero terminated string

2014-07-26 Thread Chung-Lin Tang
On 2014/7/26 03:33 PM, Chen Gang wrote: > On 07/26/2014 02:32 PM, Chung-Lin Tang wrote: >> On 14/7/26 11:28 AM, Chen Gang wrote: >>> The related strncpy() for custom_builtin_name[*] may set 5 none-zero >>> characters, which may cause custom_builtin_name[*] is none-zero

[PATCH, nios2] Fix frame pointer calculation

2014-03-11 Thread Chung-Lin Tang
, plus nios2 GDB's prologue analyzer is capable of determining where FP is stored. Still this needs to fixed to be conformant to the ABI. Tested (both the compiler and gdb) and applied to trunk. Chung-Lin 2014-03-11 Chung-Lin Tang * config/nios2/nios2.c (machine_function)

[PATCH, nios2] Misc. fixes

2014-04-01 Thread Chung-Lin Tang
UNSPECs warning when building with -g. (5) Adjust the nios2-linux LINK_SPEC to define the dynamic linker name to /lib/ld-linux-nios2.so.1, which is the current upstreamed arrangement. Chung-Lin 2014-04-01 Chung-Lin Tang * config/nios2/nios2.md (unspec): Remove UNSPEC_TLS, UNSPEC_TLS_LDM

Re: resent2 [PATCH] Fix ICE in redirect_jump, at jump.c:1497 PR50496

2011-10-24 Thread Chung-Lin Tang
On 2011/10/18 04:03 PM, Eric Botcazou wrote: >> thread_prologue_and_epilogue_insns should detect all cases where a >> return insn can be created. So any CFG cleanup that runs before it does >> not need this functionality. > > So we're left with CFG cleanups that run after it and could forward edge

[PATCH] PR49720, infinite recursion in RTX simplification

2011-10-26 Thread Chung-Lin Tang
ptimization, so the patch here just tries to plug the recursion hole for the exact condition. Bootstrapped and tested on i686 and x86_64 without regressions. Is this okay for trunk? Thanks, Chung-Lin 2011-10-27 Chung-Lin Tang PR rtl-optimization/49720 * sim

Re: resent2 [PATCH] Fix ICE in redirect_jump, at jump.c:1497 PR50496

2011-10-31 Thread Chung-Lin Tang
On 2011/10/25 02:04 AM, Bernd Schmidt wrote: > On 10/24/11 20:02, Chung-Lin Tang wrote: >> On 2011/10/18 04:03 PM, Eric Botcazou wrote: >>>> thread_prologue_and_epilogue_insns should detect all cases where a >>>> return insn can be created. So any CFG cleanup that

Re: [PATCH] fix wrong-code bug for -fstrict-volatile-bitfields

2012-08-23 Thread Chung-Lin Tang
On 2012/8/23 05:08, Richard Guenther wrote: >> First of all the warning should be probably issued from stor-layout.c >> itself - see >> other cases where we warn about packed structs. Yes, that means you'll >> get the warning even when there is no access but you'll only get it a >> single time. >>

Re: [PATCH 1/6] Thread pointer built-in functions, core parts

2012-08-28 Thread Chung-Lin Tang
On 12/7/12 2:52 PM, Chung-Lin Tang wrote: > Core parts adding the new hooks. BUILT_IN_THREAD_POINTER and > BUILT_IN_SET_THREAD_POINTER are different hooks, as some targets only > implement one of them (thread pointer read). Following Richard H.'s advice, I have revised the patch to

Re: [PATCH 2/6] Thread pointer built-in functions, alpha

2012-08-28 Thread Chung-Lin Tang
On 12/7/12 2:52 PM, Chung-Lin Tang wrote: > Alpha parts. Note that now the machine-independent > __builtin_thread_pointer() is now marked as const/readonly, slightly > different from the original alpha backend code. Alpha patch updated to use MD pattern. * config/alpha

Re: [PATCH 3/6] Thread pointer built-in functions, arm

2012-08-28 Thread Chung-Lin Tang
On 12/7/12 5:47 PM, Ramana Radhakrishnan wrote: > On 12 July 2012 07:52, Chung-Lin Tang wrote: >> ARM parts, no further notes. >> > > ARM parts are ok, modulo approval for generic parts and no > regressions with testing on arm-linux-gnueabi. ARM parts updated to use MD

Re: [PATCH 4/6] Thread pointer built-in functions, s390

2012-08-28 Thread Chung-Lin Tang
On 12/7/18 8:05 PM, Andreas Krebbel wrote: > On 07/12/2012 08:52 AM, Chung-Lin Tang wrote: >> * config/s390/s390.c (s390_builtin,code_for_builtin_64, >> code_for_builtin_31,s390_init_builtins,s390_expand_builtin): >> Remove. >> (s390_ex

Re: [PATCH 5/6] Thread pointer built-in functions, xtensa

2012-08-28 Thread Chung-Lin Tang
On 12/7/12 下午2:52, Chung-Lin Tang wrote: > xtensa parts. No other notes. > > Thanks, > Chung-Lin > > * config/xtensa/xtensa.c > (xtensa_expand_builtin_thread_pointer): Add hook function for > TARGET_EXPAN

Re: [PATCH 6/6] Thread pointer built-in functions, mips

2012-08-28 Thread Chung-Lin Tang
On 12/7/12 2:53 PM, Chung-Lin Tang wrote: > Finally, what I personally need, the MIPS parts. > > Thanks, > Chung-Lin > > * config/mips/mips.c (mips_get_tp): Add 'target' parameter for > generating to specific reg. > (mips_legiti

Re: [PATCH] MIPS16 TLS support for GCC

2012-08-29 Thread Chung-Lin Tang
On 2012/7/6 02:23 PM, Richard Sandiford wrote: > Richard Sandiford writes: >>> (3) Also related to libraries, I edited CRT_CALL_STATIC_FUNCTION to emit >>> a 32-bit code sequence under both MIPS/MIPS16 mode (under O32). >>> >>> As you can see in the original Feb. patch, I had changes to emit a >>>

<    1   2   3   4   5   6   >