On 2016/5/17 5:00 PM, Jakub Jelinek wrote:
> On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote:
>> I assume that bumping GOMP_VERSION in include/gomp-constants.h would be
>> enough?
>
> I think so.
>
> Jakub
>
How is this patch? I have added a comment to remind to adjust the version number
when plugin interface changes are made.
And, if this approach to solve the plugin interface problem is okay, can I
regard the
device lock deadlock patches and async patch approved for trunk?
Thanks,
Chung-Lin
include/
* gomp-constants.h (GOMP_VERSION): Increment to 1, add comment describe
the
need for increment this macro whenever the plugin interface is modified.
Index: gomp-constants.h
===================================================================
--- gomp-constants.h (revision 236363)
+++ gomp-constants.h (working copy)
@@ -196,8 +196,10 @@ enum gomp_map_kind
/* Internal to libgomp. */
#define GOMP_TARGET_FLAG_UPDATE (1U << 31)
-/* Versions of libgomp and device-specific plugins. */
-#define GOMP_VERSION 0
+/* Versions of libgomp and device-specific plugins. GOMP_VERSION
+ should be incremented whenever an ABI-incompatible change is introduced
+ to the plugin interface defined in libgomp/libgomp.h. */
+#define GOMP_VERSION 1
#define GOMP_VERSION_NVIDIA_PTX 1
#define GOMP_VERSION_INTEL_MIC 0
#define GOMP_VERSION_HSA 0
