Re: [patch] adjust default nvptx launch geometry for OpenACC offloaded regions

On 06/29/2018 10:12 AM, Cesar Philippidis wrote: > Ping. While porting the vector length patches to trunk, I realized that I mistakenly removed support for the environment variable GOMP_OPENACC_DIM in this patch (thanks for adding those test case Tom!). I'll post an updated version of th

Re: [PATCH,PTX] Add support for CUDA 9

On 12/27/2017 01:16 AM, Tom de Vries wrote: > On 12/21/2017 06:19 PM, Cesar Philippidis wrote: >> My test results are somewhat inconsistent. On MG's build servers, there >> are no regressions in CUDA 8. > > Ack. > >> On my laptop, there are fewer regressions

[PATCH,NVPTX] Fix PR83920

In PR83920, I encountered a nvptx bug where live predicate variables were clobbered before their value was broadcasted. Apparently, there were problems in certain version of the CUDA driver where the JIT would generate wrong code for shfl broadcasts. The attached patch teaches nvptx_single not to a

Re: [PATCH,PTX] Add support for CUDA 9

On 12/19/2017 04:39 PM, Tom de Vries wrote: > On 12/20/2017 12:25 AM, Cesar Philippidis wrote: >> og7-ptx-cuda9.diff >> >> >> 2017-12-19  Cesar Philippidis  >> >> gcc/ >> * config/nvptx/nvptx.c (output_init_frag): Don't use generic addres

[og7] backport fix for PR83920

I've backported the patch Tom committed to trunk to fix PR83920 to openacc-gcc-7-branch in revision d0a1e0fa43ca4004fde33707cb6a93c01cb11507. No changes were required for og7. The original email can be found here . Cesar

[og7,nvptx] Backport CUDA 9 support from trunk.

into trunk. This patch keeps both trunk and og7 consistent. Cesar [nvptx] Backport CUDA 9 support from trunk. 2018-01-19 Cesar Philippidis Backport from mainline: 2018-01-19 Cesar Philippidis PR target/83790 gcc/ * config/nvptx/nvptx.c (output_init_frag): diff --git a/gcc/config/nvpt

[og7] Build libffi during bootstrap.

al variables at runtime. Cesar Build libffi during bootstrap. 2018-01-25 Cesar Philippidis * Makefile.def: Bootstrap module libffi. Add libffi dependency to all-target-libgomp. * Makefile.in: Regenerate. * configure.ac: Add libffi to bootstrap_target_libs when libgomp is bootstrapped. * config

[og7] Privatize independent OpenACC reductions

committee argue that the reduction variable in inner-reduction.c should be firstprivate, not copy. Cesar Privatize independent OpenACC reductions. 2018-01-26 Cesar Philippidis gcc/ * gimplify.c (oacc_privatize_reduction): New function. (omp_add_variable): Use it to determine if a reduction va

[og7] Enable firstprivate OpenACC reductions

nside gimplify.c:omp_add_variable. I know that it's been a while since you last worked on this. Let me know if you have any state on that code, otherwise I'll handle the cleanup. Cesar Enable firstprivate OpenACC reductions 2018-01-31 Cesar Philippidis gcc/ * gimplify.c (omp_add_variable): Allow certain Op

[og7] Properly handle alloca'd arrays in OpenACC data mappings

this problem would have been detected sooner. I'm considering moving the PTX .param pass later, possible during oaccdevlow. But that will have to wait for some other time. I've applied this patch to openacc-gcc-7-branch. Cesar Properly handle alloca'd OpenACC data mappings 2018-01-3

[og7] vector_length extension part 1: generalize function and variable names

it will be used in other places, including nvptx_validate_dims and the nvptx reduction handling code. This patch has been committed to openacc-gcc-7-branch. Cesar 2018-03-01 Cesar Philippidis gcc/ * config/nvptx/nvptx.c (PTX_VECTOR_LENGTH, PTX_WORKER_LENGTH, PTX_DEFAULT_RUNTIME_DIM): Move

[og7] vector_length extension part 2: Generalize state propagation and synchronization

oversial. I'll commit this patch to openacc-gcc-7-branch once the other patches are ready. There will be three more patches in this series. Cesar 2018-03-02 Cesar Philippidis gcc/ * config/nvptx/nvptx.c (oacc_bcast_partition): Declare. (nvptx_init_axis_predicate): Initi

[og7] vector_length extension part 3: reductions

finalizer will be slow. However, that's a project for another day. I'll commit this patch to openacc-gcc-7-branch after Tom reviews the new nvptx_red_partition insn. Cesar 2018-03-02 Cesar Philippidis gcc/ * config/nvptx/nvptx-protos.h (nvptx_output_red_partition): Decl

[og7] vector_length extension part 4: target hooks and automatic parallelism

code. Overall, the changes in this patch are mild. I'll apply it to openacc-gcc-7-branch after Tom approves the reduction patch. Cesar 2018-03-02 Cesar Philippidis gcc/ * config/nvptx/nvptx.c (NVPTX_GOACC_VL_WARP): Define. (nvptx_goacc_needs_vl_warp): New function. (nvptx_goac

[og7] vector_length extension part 5: libgomp and tests

c-7-branch once the reduction changes have been approved. Cesar 2018-03-02 Cesar Philippidis libgomp/ * plugin/plugin-nvptx.c (nvptx_exec): Adjust calculations of workers and vectors. * testsuite/libgomp.oacc-c-c++-common/vred2d-128.c: New test. * testsuite/libgomp.oacc-fortran/gemm.f90: Ne

[og7] Update nvptx_fork/join barrier placement

vptx_cta_sync. Cesar 2018-03-08 Cesar Philippidis gcc/ * config/nvptx/nvptx.c (nvptx_single): Adjust placement of nvptx_fork and nvptx_join nutering labels. (nvptx_process_pars): Place the CTA barrier at the beginning of the join block. diff --git a/gcc/config/nvptx/nvptx.c b/gcc/

Re: [og7] vector_length extension part 1: generalize function and variable names

On 03/09/2018 07:29 AM, Thomas Schwinge wrote: > On Thu, 1 Mar 2018 13:17:01 -0800, Cesar Philippidis > wrote: >> To reduce the size of the final patch, >> I've separated all of the misc. function and variable renaming into this >> patch. > > Yes, please

Re: [og7] Update nvptx_fork/join barrier placement

On 03/09/2018 08:21 AM, Tom de Vries wrote: > On 03/09/2018 12:31 AM, Cesar Philippidis wrote: >> Nvidia Volta GPUs now support warp-level synchronization. > > Well, let's try to make that statement a bit more precise. > > All Nvidia architectures have supported synch

[og7] Backport PR74048 and PR81352 nvptx fixes

cts unused parallelism (in this case, num_workers was being set but there was no worker partitioned loop). That problem went away with an extra dg-warning line. Cesar 2018-03-12 Cesar Philippidis Backport from trunk: 2018-01-25 Tom de Vries PR target/84028 gcc/ * config/nvptx/nvptx.c (nv

Re: [og7] Update nvptx_fork/join barrier placement

On 03/19/2018 07:04 AM, Tom de Vries wrote: > On 03/09/2018 05:55 PM, Cesar Philippidis wrote: >> On 03/09/2018 08:21 AM, Tom de Vries wrote: >>> On 03/09/2018 12:31 AM, Cesar Philippidis wrote: >>>> Nvidia Volta GPUs now support warp-level synchronization. >&g

Re: [og7] Update nvptx_fork/join barrier placement

On 03/19/2018 10:02 AM, Tom de Vries wrote: > On 03/19/2018 03:55 PM, Cesar Philippidis wrote: >>> Note that this changes ordering of the vector-neutering jump and >>> worker-neutering jump at the end. In principle, this should not be >>> harmful, but it viol

[og7] backport fix for PR84952

to nvptx_cta_sync so that function can be used for both large vector_lengths along with workers. Other than that, I didn't have to make any changes to his patch. Cesar 2018-03-20 Cesar Philippidis gcc/ * config/nvptx/nvptx.c (nvptx_single): Revert changes from 7445a4d40. Backport fro

Re: [og7] vector_length extension part 4: target hooks and automatic parallelism

On 03/21/2018 08:49 AM, Tom de Vries wrote: > On 03/02/2018 08:18 PM, Cesar Philippidis wrote: > >> og7-vl-part4-hooks.diff > >> diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c >> index 5642941c6a3..507c8671704 100644 >> --- a/gcc/config/nvptx/

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/21/2018 10:10 AM, Tom de Vries wrote: > On 03/02/2018 05:55 PM, Cesar Philippidis wrote: >> In addition, nvptx_cta_sync and the corresponding nvptx_barsync insn, >> have been extended to take a barrier ID and a thread count. The idea >> here is to assign one barrier fo

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/22/2018 06:43 AM, Tom de Vries wrote: > On 03/22/2018 04:59 AM, Cesar Philippidis wrote: >> On 03/21/2018 10:10 AM, Tom de Vries wrote: >>> Changing the code generation scheme for workers is fine, but obviously >>> that should be a minimal, separate patch

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/22/2018 07:23 AM, Tom de Vries wrote: > On 03/02/2018 05:55 PM, Cesar Philippidis wrote: > >> (nvptx_declare_function_name): Emit a .maxntid directive hint and >> call nvptx_init_oacc_workers. > >> + >> +  /* Emit a .maxntid hint to help the PTX JIT

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/22/2018 07:44 AM, Tom de Vries wrote: > On 03/02/2018 05:55 PM, Cesar Philippidis wrote: >> The attached patch generalizes the worker state propagation and >> synchronization code to handle large vectors. When the vector_length is >> larger than a CUDA warp, the nvptx B

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

arguments for maxntid. Cesar >From 11035dc92884146dc4d974156adcb260568db785 Mon Sep 17 00:00:00 2001 From: Cesar Philippidis Date: Thu, 22 Mar 2018 08:05:53 -0700 Subject: [PATCH] emit .maxntid hint --- gcc/config/nvptx/nvptx.c | 19 +++ gcc/config/nvptx/nvptx.h | 2 ++

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/22/2018 10:39 AM, Tom de Vries wrote: > On 03/02/2018 05:55 PM, Cesar Philippidis wrote: >> +  rtx red_partition; /* Similar to bcast_partition, except for vector >> +    reductions.  */ > > Shouldn't this be in "[og7] vector_length extension part 3: r

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/22/2018 10:51 AM, Tom de Vries wrote: > On 03/22/2018 06:24 PM, Cesar Philippidis wrote: >> On 03/22/2018 09:18 AM, Tom de Vries wrote: >> >>> That's obviously not good enough. >>> >>> When I compile this test-case: >>> ... >>

Re: [og7] vector_length extension part 4: target hooks and automatic parallelism

On 03/26/2018 07:14 AM, Tom de Vries wrote: > On 03/02/2018 08:18 PM, Cesar Philippidis wrote: >> diff --git a/gcc/omp-offload.c b/gcc/omp-offload.c >> index ba3f4317f4e..f15ce6b8f8d 100644 >> --- a/gcc/omp-offload.c >> +++ b/gcc/omp-offload.c >> @@ -626,7 +626,8

[PATCH,nvptx] Fix PR85056

this patch OK for trunk if the results come back clean? Thanks, Cesar 2018-03-26 Cesar Philippidis gcc/ PR target/85056 * config/nvptx/nvptx.c (nvptx_assemble_decl_begin): Add '[]' to extern array declarations. gcc/testsuite/ * testsuite/gcc.target/nvptx/pr85056.c: New test.

Re: [PATCH,nvptx] Fix PR85056

On 03/27/2018 01:17 AM, Tom de Vries wrote: > On 03/26/2018 11:57 PM, Cesar Philippidis wrote: >> As noted in PR85056, the nvptx BE isn't declaring external arrays using >> PTX array notation. Specifically, it's emitting code that's missing the >> empty angle b

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

On 03/30/2018 07:45 AM, Tom de Vries wrote: > On 03/30/2018 03:07 AM, Tom de Vries wrote: >> On 03/02/2018 05:55 PM, Cesar Philippidis wrote: >>> As a follow up patch will show, the nvptx BE falls back to using >>> vector_length = 32 when a vector loop is nested in

[PATCH] Handle empty infinite loops in OpenACC for PR84955

18-04-06 Cesar Philippidis PR middle-end/84955 gcc/ * cfgloop.c (flow_loops_find): Add assert. * omp-expand.c (expand_oacc_for): Add dummy false branch for tiled basic blocks without omp continue statements. * tree-cfg.c (execute_fixup_cfg): Handle calls to internal functi

[og7] Enable worker partitioning with warp-sized vector_length

. Consequently, not all of the CUDA threads were being utilized when vector_length = 32 (which is the default case). I've committed this patch to openacc-gcc-7-branch which allows warp-sized vectors to nest inside worker-partitioned loops. Cesar 2018-04-10 Cesar Philippidis gcc/ * config/

Re: [PATCH] Handle empty infinite loops in OpenACC for PR84955

On 04/09/2018 04:31 AM, Richard Biener wrote: > On Fri, 6 Apr 2018, Jakub Jelinek wrote: > >> On Fri, Apr 06, 2018 at 06:48:52AM -0700, Cesar Philippidis wrote: >>> 2018-04-06 Cesar Philippidis >>> >>> PR middle-end/84955 >>> >>>

Re: [PATCH] Handle empty infinite loops in OpenACC for PR84955

On 04/12/2018 11:27 AM, H.J. Lu wrote: > On Wed, Apr 11, 2018 at 12:30 PM, Cesar Philippidis > wrote: >> On 04/09/2018 04:31 AM, Richard Biener wrote: >>> On Fri, 6 Apr 2018, Jakub Jelinek wrote: >>> >>>> On Fri, Apr 06, 2018 at 06:48:52AM -0700, Cesar

[openacc] Teach gfortran to lower OpenACC routine dims

At present, gfortran does not encode the gang, worker or vector parallelism clauses when it creates acc routines dim attribute for subroutines and functions. While support for acc routine is lacking in other areas in gfortran (including modules), this patch is important because it encodes the paral

[patch][OpenACC] Add target hook TARGET_GOACC_ADJUST_PARALLELISM

At present, GCC fixes the vector length on all targets. However, that is an artificial restriction. This patch introduces a new TARGET_GOACC_ADJUST_PARALLELISM hook that enables the runtime to correct the default number of acc workers and vectors. Extra care need to be done to ensure that large vec

[OpenACC] Enable firstprivate OpenACC reductions

for (...) { #pragma acc loop reduction(+:s2) Here s2 will be transferred into the accelerator as firstprivate instead of copy. Is this OK for trunk? I regtested and bootstrapped for x86_64 with nvptx offloading. Cesar [OpenACC] Enable firstprivate OpenACC reductions 2018-XX-YY Cesar

Re: [patch,nvptx] Basic -misa support for nvptx

On 09/05/2018 07:30 AM, Tom de Vries wrote: > On 09/05/2018 12:19 AM, Cesar Philippidis wrote: >> On 09/02/2018 07:57 AM, Cesar Philippidis wrote: >>> On 09/01/2018 12:04 PM, Tom de Vries wrote: >>>> On 08/31/2018 04:14 PM, Cesar Philippidis wrote: >&g

Re: [PATCH, OpenACC 2.5, libgomp] Add *_async versions of runtime library API functions

On 09/10/2018 08:04 AM, Chung-Lin Tang wrote: > GOACC_2.0 { > Index: libgomp/oacc-mem.c > === > --- libgomp/oacc-mem.c(revision 264192) > +++ libgomp/oacc-mem.c(working copy) > @@ -153,8 +153,9 @@ acc_free (void *d) >

Re: [PATCH, OpenACC] C++ reference mapping (PR middle-end/86336)

are mapped like this (from the omplower dump): >> >> map(force_present:*x [len: 4]) map(firstprivate ref:x [pointer assign, bias: >> 0]) >> >> Tested with offloading to NVPTX and bootstrapped. OK for trunk? >> >> Thanks, >> >> Julian

[patch,nvptx] Add atomic_fetch* support for SImode arguments.

named atomic-fetch-2.c incorrectly; there should be an underscore between atomic and fetch. This patch also fixes that. I tested this patch using both a standalone nvptx compiler and x86_64 Linux with nvptx offloading. Cesar [nvptx] Add atomic_fetch* support for SImode arguments. 2018-09-17

Re: [PATCH,nvptx] Remove use of CUDA unified memory in libgomp

On 08/01/2018 04:12 AM, Tom de Vries wrote: > On 07/31/2018 05:27 PM, Cesar Philippidis wrote: >>/* Copy the (device) pointers to arguments to the device (dp and hp might >> in >> fact have the same value on a unified-memory system). */ > > This comment

[nvptx] vector length patch series

Hi Tom, Here is a link to our nvptx vector length patches on github: https://github.com/cesarjp/gcc/tree/trunk-og8-vl-private Specifically, the code lives in the trunk-og8-vl-private branch. There are a couple of outstanding dependency patches: * Teach gfortran to lower OpenACC routine dims

Re: [openacc] Teach gfortran to lower OpenACC routine dims

On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: > On Wed, 5 Sep 2018 12:52:03 -0700 > Cesar Philippidis wrote: > >> At present, gfortran does not encode the gang, worker or vector >> parallelism clauses when it creates acc routines dim attribute for >> subro

[patch,openacc] Better distinguish OpenACC and OpenMP sections in libgomp.texi

unk? I verified that libgomp.pdf looks ok. Thanks, Cesar [OpenACC] Update _OPENACC value and documentation for OpenACC 2.5 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/c-family/ * c-cppbuiltin.c (c_cpp_builtins): Update "_OPENACC" to "201510". gcc/fortran/ * cpp.c

[patch,opencc] Don't mark OpenACC auto loops as independent inside acc parallel regions

directives https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01552.html Is this OK for trunk? I bootstrapped and regtested on x86_64 Linux with nvptx offloading. Thanks, Cesar [OpenACC] Don't mark OpenACC auto loops as independent inside acc parallel regions 2018-XX-YY Cesar Philippidis gc

[patch,openacc] Fix acc_shutdown issue

strapped and regtested it for x86_64 Linux with nvptx offloading and I didn't encounter any regressions. Thanks, Cesar [OpenACC] Fix acc_shutdown issue 2018-XX-YY James Norris Cesar Philippidis libgomp/ * oacc-init.c (acc_shutdown_1): Replace use of gomp_free_memmap with go

[patch,openacc] Fix infinite recursion in OMP clause pretty-printing, default label

patch shouldn't be necessary because all of the clauses are fully implemented now, but it may prevent similar bugs from occuring in the future at least during development. 2018-XX-YY Tom de Vries Cesar Philippidis gcc/ * tree-pretty-print.c (dump_omp_clause): Fix infinite re

[patch,openacc] Generate sequential loop for OpenACC loop directive inside kernels

hanks, Cesar [OpenACC] Generate sequential loop for OpenACC loop directive inside kernels 2018-XX-YY Chung-Lin Tang Cesar Philippidis gcc/ * omp-expand.c (struct omp_region): Add inside_kernels_p field. (expand_omp_for_generic): Adjust to generate a 'sequential' loop when

[patch,openacc] handle missing OMP_LIST_ clauses in fortran's parse tree debugger

ted it for x86_64 Linux with nvptx offloading. Thanks, Cesar [OpenACC] handle missing OMP_LIST_ clauses in fortran's parse tree debugger 2018-XX-YY Cesar Philippidis gcc/fortran/ * dump-parse-tree.c (show_omp_clauses): Add missing omp list_types and reorder the switch cases to ma

[patch,openacc] Fix hang when running oacc exec with CUDA 9.0 nvprof

this for x86_64 Linux with nvptx offloading. Thanks, Cesar [OpenACC] Fix hang when running oacc exec with CUDA 9.0 nvprof 2018-XX-YY Tom de Vries Cesar Philippidis libgomp/ * oacc-init.c (acc_init_state_lock, acc_init_state, acc_init_thread): New variable. (acc_init_1): Set ac

[patch,openacc] Fix PR71959: lto dump of callee counts

x27;ll add some support for member data OpenACC 2.6, but some of the OpenACC C++ semantics are still unclear. Is this OK for trunk? I bootstrapped and regtested it for x86_64 Linux with nvptx offloading. Thanks, Cesar [PR71959] lto dump of callee counts 2018-XX-YY Nathan Sidwell Cesar P

[patch,openacc] Propagate independent clause for OpenACC kernels pass

t introduce any regressions. We do have a couple of other standalone kernels patches in og8, but those depend on other patches. Thanks, Cesar [OpenACC] Propagate independent clause for OpenACC kernels pass 2018-XX-YY Chung-Lin Tang Cesar Philippidis gcc/ * cfgloop.h (struct loop): Add 'boo

[patch,openacc] Set safelen to INT_MAX for oacc independent pragma

pragma 2018-XX-YY Tom de Vries Cesar Philippidis gcc/ * omp-expand.c (expand_omp_for): Set loop->safelen to INT_MAX if marked_independent. (cherry picked from gomp-4_0-branch r226079) --- gcc/omp-expand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/omp-expand.c b/gcc/omp

[patch,openacc] Update _OPENACC value and documentation for OpenACC 2.5

nvptx offloading. Thanks, Cesar [OpenACC] Update _OPENACC value and documentation for OpenACC 2.5 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/c-family/ * c-cppbuiltin.c (c_cpp_builtins): Update "_OPENACC" to "201510". gcc/fortran/ * cpp.c (cpp_define_builtins): Upd

Re: [patch,openacc] handle missing OMP_LIST_ clauses in fortran's parse tree debugger

On 09/20/2018 11:22 AM, Paul Richard Thomas wrote: > Hi Cesar, > > It looks OK to me. > > Thanks for the patch. > > Paul Thanks! Committed in r264446. Cesar > On 20 September 2018 at 18:21, Cesar Philippidis > wrote: >> This patch updates Fortran's pa

Re: [patch,openacc] Generate sequential loop for OpenACC loop directive inside kernels

On 09/20/2018 10:14 AM, Cesar Philippidis wrote: > As Chung-Lin noted here > <https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01079.html>: > > This patch adjusts omp-low.c:expand_omp_for_generic() to expand to a > "sequential" loop form (without the OM

Re: [openacc] Teach gfortran to lower OpenACC routine dims

On 09/20/2018 09:10 AM, Bernhard Reutner-Fischer wrote: > On Thu, 20 Sep 2018 07:41:08 -0700 > Cesar Philippidis wrote: > >> On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: >>> On Wed, 5 Sep 2018 12:52:03 -0700 >>> Cesar Philippidis wrote: > >>

[patch,openacc] update fortran nested parallelism error messages

nvptx offloading. Cesar [OpenACC] update fortran nested parallelism error messages 2018-09-24 Bernhard Reuther-Fischer Cesar Philippidis gcc/fortran/ * openmp.c (resolve_oacc_loop_blocks): gcc/testsuite/ * gfortran.dg/goacc/nested-parallelism.f90: New test. --- gcc/fortran/ope

Re: [PATCH][OpenACC] Update deviceptr handling during gimplification

On 09/25/2018 05:55 PM, Julian Brown wrote: > On Tue, 7 Aug 2018 15:09:38 -0700 > Cesar Philippidis wrote: > >> I had previously posted this patch as part of a monster deviceptr >> patch here >> <https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01911.html>. Thi

[patch,openacc] C, C++ OpenACC wait diagnostic change

x offloading. Thanks, Cesar [OpenACC] C, C++ OpenACC wait diagnostic change 2018-XX-YY James Norris Cesar Philippidis gcc/c/ * c-parser.c (c_parser_oacc_wait_list): Change error message. gcc/cp/ * parser.c (cp_parser_oacc_wait_list): Change error message. gcc/testsuite/

[patch,openacc] use existing local variable in cp_parser_oacc_enter_exit_data

] Use existing local variable in cp_parser_oacc_enter_exit_data 2018-XX-YY James Norris Cesar Philippidis gcc/cp/ * parser.c (cp_parser_oacc_enter_exit_data): Use existing local variable. (cherry picked from gomp-4_0-branch r223007) --- diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c

[patch,openacc] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

hat do you want to do with this patch Thomas? I bootstrapped and regtested it for x86_64 Linux with nvptx offloading. Cesar [OpenACC] Don't gimplify in ssa mode if seen_error in oacc_xform_loop 2018-XX-YY Tom de Vries Cesar Philippidis gcc/ PR tree-optimization/68977 * omp-offloa

[patch] nvptx libgcc atomic routines

2018-XX-YY Cesar Philippidis libgcc/ * config/nvptx/atomic.c: New file. * config/nvptx/t-nvptx (LIB2ADD): Include it. (cherry picked from gomp-4_0-branch r223177) --- libgcc/config/nvptx/atomic.c | 279 +++ libgcc/config/nvptx/t-nvptx | 3 +- 2 files ch

[patch,openacc] Use correct location information for OpenACC shape and simple, clauses in C/C++

it for x86_64 Linux with nvptx offloading. Cesar [OpenACC] Use correct location information for OpenACC shape and simple clauses in C/C++ 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/c/ * c-parser.c (c_parser_oacc_shape_clause) (c_parser_oacc_simple_clause): Add loc formal param

[patch,wip] warn on noncontiguous pointers

s pointer from non-contiguous target" error 2018-XX-YY Cesar Philippidis gcc/fortran/ * expr.c (gfc_check_pointer_assign): Demote "Assignment to contiguous pointer from non-contiguous target" to a warning. --- diff --git a/gcc/fortran/expr.c b/gcc/fortran/expr.c index 3315bb84

Re: [patch,wip] warn on noncontiguous pointers

On 09/26/2018 01:49 PM, Thomas Koenig wrote: > Hi Cesar, > >> As of GCC 8, gfortran now errors when a pointer with a contiguous >> attribute is set to point to a target without a contiguous attribute. I >> think this is overly strict, and should probably be demoted to a >> pedantic warning as I've

Re: [patch,openacc] C, C++ OpenACC wait diagnostic change

On 09/26/2018 12:50 PM, Joseph Myers wrote: > On Wed, 26 Sep 2018, Cesar Philippidis wrote: > >> Attached is an old patch which updated the C and C++ FEs to use %<)%> >> for the right ')' symbol. It's mostly a cosmetic change. All of the >> change

[patch,openacc] Use oacc_verify_routine_clauses for C/C++

OK for trunk? I bootstrapped and regression tested it for x86_64 Linux with nvptx offloading. This is only touches the OpenACC code path. Cesar [OpenACC] Use oacc_verify_routine_clauses for C/C++ 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/ * omp-general.c (oacc_build_routine_dims): M

[patch,openacc] Add support for OpenACC routine nohost clause

r trunk? I bootstrapped and regtested it for x86_64 Linux with nvptx offloading. Thanks Cesar [OpenACC] Add support for OpenACC routine nohost clause (was OpenACC bind, nohost changes) 2018-XX-YY Thomas Schwinge Cesar Philippidis gcc/ * tree-core.h (omp_clause_code): Add OMP_CLA

[patch,openacc] Repeated use of the OpenACC routine directive

ch too large. Is this patch OK for trunk? I bootstrapped and regtested it for x86_64 Linux with nvptx offloading. This patch is also self-contained to the OpenACC code path. Thanks, Cesar [OpenACC] Repeated use of the OpenACC routine directive 2018-XX-YY Thomas Schwinge Cesar Philippidis

[patch,openacc] Check clauses with intrinsic function specified in !$ACC ROUTINE ( NAME )

with intrinsic function specified in !$ACC ROUTINE ( NAME ) 2018-XX-YY Cesar Philippidis gcc/fortran/ * openmp.c (gfc_match_oacc_routine): Check clauses of intrinsic functions. gcc/testsuite/ * gfortran.dg/goacc/fixed-1.f: Update test. * gfortran.dg/goacc/pr72741-2.f: New test. * gfortr

[patch,openacc] Check for sufficient parallelism when calling acc routines in Fortran

rtran 2018-XX-YY Cesar Philippidis gcc/fortran/ * gfortran.h (gfc_resolve_oacc_routine_call): Declare. (gfc_resolve_oacc_routines): Declare. * openmp.c (gfc_match_oacc_routine): Make error reporting more precise. Defer rejection of non-function and subroutine symbols

[patch,openacc] Add warning for unused acc routine parallelism

or on implicitly private induction variables in gfortran) 2018-XX-YY Cesar Philippidis gcc/ * omp-general.c (oacc_verify_routine_clauses): New warning. gcc/testsuite/ * c-c++-common/goacc-gomp/nesting-fail-1.c: Update test. * c-c++-common/goacc/Wparentheses-1.c: Likewise. * c-c++-common/

[OpenACC] initial manual deep copy in c

is all an early work in progress. I'm still experimenting with some other functionality. If you checkout that branch, beware it may be rebased. Cesar [OpenACC] Initial Manual Deep Copy 2018-10-02 Cesar Philippidis gcc/c/ * c-typeck.c (handle_omp_array_sections_1): Enable structs

[PATCH] Update nvptx newlib installation requirements

Thanks, Cesar [nvptx] Update newlib dependency. 2018-04-23 Cesar Philippidis gcc/ * doc/install.texi: Update newlib dependency for nvptx. diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 64ad2445a33..121a821857f 100644 --- a/gcc/doc/install.texi +++ b/gcc/doc/install.texi @@ -4

Re: [PATCH] Update nvptx newlib installation requirements

On 04/24/2018 12:10 AM, Richard Biener wrote: > That's great news! Note that we usually keep copies of build dependences at > ftp://gcc.gnu.org/pub/gcc/infrastructure/ and there's currently no nvptx > newlib > variant there. Maybe you can prepare a tarball that's ready to plug into gcc > source

[PATCH] cleanup libgomp's coalesce chunk data structures

er by introducing a new gomp_coalesce_chunk structure with explicit start and end members. Beyond that, there's no functional changes to this patch. Is it OK for trunk? I tested it against x86_64-linux with nvptx acceleration. Thanks, Cesar 2018-05-02 Cesar Philippidis libgomp/ * target

[og7] Update deviceptr handling in Fortran

ls on at least one legacy driver. Cesar 2018-05-07 Cesar Philippidis gcc/fortran/ * trans-openmp.c (gfc_omp_finish_clause): Don't create pointer data mappings for deviceptr clauses. (gfc_trans_omp_clauses_1): Likewise. gcc/ * gimplify.c (enum gimplify_omp_var_data): Add GOVD_DEVICETP

[og7] Backport libgomp gomp_copy_host2dev coalesce optimization from trunk

This patch backports Jakub's gomp_copy_host2dev optimization from <https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01800.html>. There were a couple of changes required due to the new async infrastructure in og7. I've applied this patch to og7. Cesar 2018-05-07 Thomas Schw

Re: [og7] Update deviceptr handling in Fortran

c-c++-common/goacc/deviceptr-4.c -std=c++98 (test for excess > errors) I forgot to update the expected data mapping in devicetpr-4.c. Now, instead of implicitly adding a 'copy' clause for know deviceptr variables, the gimplifier will assign a force_deviceptr clause. I've ap

Fix PR85782: C++ ICE with continue statements inside acc loops

cause cp_genericize_r uses if statements to check for statement types instead of a huge switch statement. Cesar 2018-05-15 Cesar Philippidis PR c++/85782 gcc/cp/ * cp-gimplify.c (cp_genericize_r): Call genericize_omp_for_stmt for OACC_LOOPs. gcc/testsuite/ * c-c++-common/goacc/pr85782.c

Re: Fix PR85782: C++ ICE with continue statements inside acc loops

Ping. For reference, I've attached the patch for gcc7. Cesar On 05/15/2018 07:11 AM, Cesar Philippidis wrote: > This patch resolves the issue in PR85782, which involves a C++ ICE > caused by OpenACC loops which contain continue statements. The problem > is that genericize_continu

[patch,gomp4] make fortran loop variables implicitly private in openacc

also appear inside a reduction clause. I've also included a fix for this in this patch. Is this OK for gomp-4_0-branch? Thanks, Cesar 2014-08-11 Cesar Philippidis gcc/fortran/ * openmp.c (oacc_compatible_clauses): New function. (resolve_omp_clauses): Use it. (oacc_current_ctx): Move it

Re: [patch,gomp4] make fortran loop variables implicitly private in openacc

On 08/11/2014 04:55 PM, Cesar Philippidis wrote: > According to section 2.6.1 in the openacc spec, fortran loop variables > should be implicitly private like in openmp. This patch does just so. > Also, while working on this patch, I noticed that I made the check for > variables

Re: [patch,gomp4] make fortran loop variables implicitly private in openacc

On 08/13/2014 01:41 PM, Tobias Burnus wrote: > Cesar Philippidis wrote: >> According to section 2.6.1 in the openacc spec, fortran loop variables >> should be implicitly private like in openmp. This patch does just so. > > Makes sense. Looking at the patch, I wonder w

[PATCH] Add check for aarch64 in vect_cmdline_needed

ized 0 loops" 1 Apparently the intent of these particular tests is to ensure that those loops do not get vectorized when the target does not support SIMD. Is this OK for trunk? If so, please commit it since I do not have a SVN account. Thanks, Cesar 2013-11-05 Cesar Philippidis

Re: [PATCH] Add check for aarch64 in vect_cmdline_needed

On 11/6/13, 5:06 PM, Joseph S. Myers wrote: > You should be testing aarch64*-*-* so as to match aarch64_be targets. Thank you for catching that. Please commit this new patch if is OK. I don't have SVN access. Thanks, Cesar 2013-11-06 Cesar Philippidis gcc/testsuite/

[PATCH] aarch64 gcc.c-torture/execute/20101011-1.c failures

This patch addresses the failures caused by the gcc.c-torture/execute/20101011-1.c test on aarch64. The reason why this test fails is because aarch64 does not trap on integer division by zero. Is this OK for trunk? If so, please commit it because I do not have an svn account. Thanks, Cesar

Re: [PATCH] aarch64 gcc.c-torture/execute/20101011-1.c failures

On 11/18/13, 10:01 AM, Andrew Pinski wrote: > On Mon, Nov 18, 2013 at 9:58 AM, Cesar Philippidis > wrote: >> This patch addresses the failures caused by the >> gcc.c-torture/execute/20101011-1.c test on aarch64. The reason why this >> test fails is because aarch64

Re: [PATCH] aarch64 gcc.c-torture/execute/20101011-1.c failures

On 11/19/13, 1:37 AM, Marcus Shawcroft wrote: > On 18 November 2013 18:02, Cesar Philippidis wrote: > >>>> gcc.c-torture/execute/20101011-1.c test on aarch64. The reason why this >>>> test fails is because aarch64 does not trap on integer division by zero. >>

PING: [PATCH] libstdc++ testsuite cxxflags

This patch needs a review. Thanks, Cesar

Re: [PATCH] libstdc++ testsuite cxxflags

On 11/20/13, 1:46 PM, Jonathan Wakely wrote: > On 20 November 2013 21:44, Jonathan Wakely wrote: >> On 29 October 2013 15:37, Cesar Philippidis wrote: >>> This patch addresses two issues with the libstdc++ testsuite: >>> >>> * duplicate "-g -O2"

Re: [PATCH] libstdc++ testsuite cxxflags

On 11/21/13, 5:42 AM, Jonathan Wakely wrote: > On 20 November 2013 23:57, Cesar Philippidis wrote: >> On 11/20/13, 1:46 PM, Jonathan Wakely wrote: >>> On 20 November 2013 21:44, Jonathan Wakely wrote: >>>> On 29 October 2013 15:37, Cesar Philippidis wrote: >>

Re: [gomp4] OpenACC wait directive

ction after whole > program. > So, since you are resolving wait-list during match, you don't cover this > case. But async clause works fine. I moved that check back into resolve_omp_clauses. So it functions now. > By the way, the same difference between wait and async presents in C

Re: [gomp4] reduction bug fix

On 10/08/2014 02:38 AM, Thomas Schwinge wrote: > On Fri, 3 Oct 2014 09:22:52 -0700, Cesar Philippidis > wrote: >> There is a reduction bug [...] > > Thanks for looking into this! > >> This is a problem because initialize_reduction_data originally expected &

<    1   2   3   4   5   6   7   >