On 03/26/2018 07:14 AM, Tom de Vries wrote:
> On 03/02/2018 08:18 PM, Cesar Philippidis wrote:
>> diff --git a/gcc/omp-offload.c b/gcc/omp-offload.c
>> index ba3f4317f4e..f15ce6b8f8d 100644
>> --- a/gcc/omp-offload.c
>> +++ b/gcc/omp-offload.c
>> @@ -626,7 +626,8 @@ oacc_parse_default_dims (const char *dims)
>> function. */
>> static void
>> -oacc_validate_dims (tree fn, tree attrs, int *dims, int level,
>> unsigned used)
>> +oacc_validate_dims (tree fn, tree attrs, int *dims, int level,
>> unsigned used,
>> + int * ARG_UNUSED (default_dims))
>> {
>> tree purpose[GOMP_DIM_MAX];
>> unsigned ix;
>
>> @@ -1604,7 +1616,8 @@ execute_oacc_device_lower ()
>> }
>> int dims[GOMP_DIM_MAX];
>> - oacc_validate_dims (current_function_decl, attrs, dims, fn_level,
>> used_mask);
>> + oacc_validate_dims (current_function_decl, attrs, dims, fn_level,
>> used_mask,
>> + NULL);
>> if (dump_file)
>> {
>
> What's the purpose of this unused parameter default_dims, that only ever
> gets to be NULL?
That's stale and can be removed. In an earlier, and more complicated,
version of the patch I was still trying to get large vector lengths to
work with multiple workers.
I'll remove it from my patch.
Thanks,
Cesar
