[PATCH, fortran, v4] Use Levenshtein spelling suggestions in Fortran FE

2016-06-18 Thread Bernhard Reutner-Fischer
Rewrite C++ autovec in plain C. Factor out levenshtein distance handling into a commonly used gfc_closest_fuzzy_match(). gcc/fortran/ChangeLog 2015-12-27 Bernhard Reutner-Fischer * gfortran.h (gfc_lookup_function_fuzzy): New declaration. (gfc_closest_fuzzy_match): New de

Re: [PATCH] Commentary typo fix for gfc_typenode_for_spec()

2016-06-18 Thread Bernhard Reutner-Fischer
On Tue, Dec 01, 2015 at 08:00:15AM -0800, Steve Kargl wrote: > On Tue, Dec 01, 2015 at 01:55:00PM +0100, Bernhard Reutner-Fischer wrote: > > Regstrapped without regressions, ok for trunk stage3 now / next stage1? > > > > gcc/fortran/ChangeLog > > > > 201

Re: [PATCH] Use gfc_add_*_component defines where appropriate

2016-06-19 Thread Bernhard Reutner-Fischer
On Sun, Jun 19, 2016 at 11:18:08AM +0200, Paul Richard Thomas wrote: > Hi Bernhard, > > Thanks for doing some of this tidying up. The patch is OK to commit on > both trunk and 6-branch. It might be worth going back to 5-branch as > well, if you feel up to it. Applied to trunk as r237580 so far.

[PATCH] update-copyright.py: Retain file mode

2016-06-21 Thread Bernhard Reutner-Fischer
Hi! Ok for trunk? thanks, contrib/ChangeLog 2016-06-21 Bernhard Reutner-Fischer * update-copyright.py (Copyright.process_file): Retain original file mode. --- contrib/update-copyright.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/update-copyright.py b

Re: [RFC: Patch 1/6 v2] New target hook: max_noce_ifcvt_seq_cost

2016-06-21 Thread Bernhard Reutner-Fischer
On June 21, 2016 5:50:26 PM GMT+02:00, James Greenhalgh wrote: > >On Fri, Jun 03, 2016 at 12:39:42PM +0200, Richard Biener wrote: >> On Thu, Jun 2, 2016 at 6:53 PM, James Greenhalgh >> wrote: >> > >> > Hi, >> > >> > This patch introduces a new target hook, to be used like >BRANCH_COST but >> > w

Re: [PATCH 1/3] Add gcc-auto-profile script

2016-06-22 Thread Bernhard Reutner-Fischer
On June 22, 2016 2:37:04 PM GMT+02:00, Andi Kleen wrote: >From: Andi Kleen > >Using autofdo is currently something difficult. It requires using the >model specific branches taken event, which differs on different CPUs. >The example shown in the manual requires a special patched version of >perf t

Re: [PATCH, fortran, v4] Use Levenshtein spelling suggestions in Fortran FE

2017-10-19 Thread Bernhard Reutner-Fischer
[forgot to CC gcc-patches] On Sat, Jun 18, 2016 at 09:58:47PM +0200, Bernhard Reutner-Fischer wrote: > Hi, > > Ok for trunk? This was ACKed about a year ago by Janne and Jerry and since there were no objections in the meantime i've installed this first step towards prov

Re: [PATCH] Derive interface buffers from max name length

2017-10-19 Thread Bernhard Reutner-Fischer
On Sat, Jun 18, 2016 at 09:46:17PM +0200, Bernhard Reutner-Fischer wrote: > On December 3, 2015 10:46:09 AM GMT+01:00, Janne Blomqvist > wrote: > >On Tue, Dec 1, 2015 at 6:51 PM, Bernhard Reutner-Fischer > > wrote: > >> On 1 December 2015 at 15:52, Janne Blomqvist >

Re: [PATCH] Derive interface buffers from max name length

2017-10-20 Thread Bernhard Reutner-Fischer
On 19 October 2017 10:03:06 CEST, Bernhard Reutner-Fischer wrote: >On Sat, Jun 18, 2016 at 09:46:17PM +0200, Bernhard Reutner-Fischer >wrote: >> On December 3, 2015 10:46:09 AM GMT+01:00, Janne Blomqvist > wrote: >> >On Tue, Dec 1, 2015 at 6:51 PM, Bernhard Reutner-Fische

Re: [Patch] Edit contrib/ files to download gfortran prerequisites

2017-10-21 Thread Bernhard Reutner-Fischer
On 21 October 2017 at 02:26, Damian Rouson wrote: > > Hi Richard, > > Attached is a revised patch that makes the downloading of Fortran > prerequisites optional via a new --no-fortran flag that can be passed to > contrib/download_prerequisites as requested in your reply below. > > As Jerry menti

[PATCH, FORTRAN, committed] typo in error message in gfc_match_type_is

2017-10-25 Thread Bernhard Reutner-Fischer
cc/fortran/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2017-10-25 Bernhard Reutner-Fischer + + * match.c (gfc_match_type_is): Fix typo in error message. + 2017-10-21 Paul Thomas PR fortran/82586

Re: [patch, fortran] Index interchange for FORALL and DO CONCURRENT

2017-10-31 Thread Bernhard Reutner-Fischer
On Tue, Oct 31, 2017 at 02:24:39PM +0100, Thomas Koenig wrote: > Hello world, > > here is a version of the patch for index interchange for FORALL > and DO CONCURRENT that I would like to commit. > > It introduces a new option for selecting (or deselecting) > the option, -ffrontend-loop-interchang

Re: [patch, fortran] Index interchange for FORALL and DO CONCURRENT

2017-10-31 Thread Bernhard Reutner-Fischer
On Tue, Oct 31, 2017 at 09:30:27PM +0100, Thomas Koenig wrote: > > Or maybe emit diagnostics into the frontend optimize dump file and scan > > that? > > If we could check the Fortran tree dumps with dejagnu, that would be > doable. Unfortunately, we don't have that in place. Well that should be

Re: [patch, fortran] Index interchange for FORALL and DO CONCURRENT

2017-10-31 Thread Bernhard Reutner-Fischer
On Tue, Oct 31, 2017 at 09:50:37PM +0100, Bernhard Reutner-Fischer wrote: > On Tue, Oct 31, 2017 at 09:30:27PM +0100, Thomas Koenig wrote: > > > > Or maybe emit diagnostics into the frontend optimize dump file and scan > > > that? > > > > If we could check

Re: [patch, Fortran] PR 55806 - Inefficient ANY with array constructors

2017-11-02 Thread Bernhard Reutner-Fischer
On Mon, Jan 14, 2013 at 10:51:25PM +0100, Thomas Koenig wrote: > Am 14.01.2013 14:29, schrieb Mikael Morin: > > Le 13/01/2013 23:14, Thomas Koenig a écrit : > > > > OK for trunk? > > > > > OK with the changes suggested above. Thanks. > > Committed as rev. 195179 with your changes. s/intrnisics/

Re: Avoid global optimize flag checks in LTO

2017-07-07 Thread Bernhard Reutner-Fischer
On 7 July 2017 15:31:55 CEST, Jan Hubicka wrote: >Hi, >this patch fixes some places where we check global optimize flag rather >than >doing it per-function. This makes optimization attribute work closer to >what one gets when passing the same flag at command line. >This requires to run IPA passes

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-28 Thread Bernhard Reutner-Fischer
On 27 July 2017 10:43:09 CEST, Richard Biener wrote: >On Thu, Jul 27, 2017 at 10:30 AM, wrote: >> From: Trevor Saunders >> >> The preC++ way of passing information about the call site of a >function was to >> use a macro that passed __file__, __LINE__, and __FUNCTION__ to a >function with >> t

Re: Handle data dependence relations with different bases

2017-05-05 Thread Bernhard Reutner-Fischer
On 4 May 2017 14:12:04 CEST, Richard Biener wrote: >nonoverlapping_component_refs_of_decl_p >should simply skip ARRAY_REFs - but I also see there: > >/* ??? We cannot simply use the type of operand #0 of the refs here > as the Fortran compiler smuggles type punning into COMPONENT_REFs >

Re: [C++ PATCH] add_method, clone_function_decl

2017-05-11 Thread Bernhard Reutner-Fischer
On 10 May 2017 at 15:15, Nathan Sidwell wrote: > Another cleanup from modules. Changed the final parms to bool from tree and > int respectively. In the former case we were only using its non-nullness. Maybe sed -i -e s/CLASTYPE_METHOD_VEC/CLASSTYPE_METHOD_VEC/ gcc/cp/class.c while at it thanks

Re: [C++ PATCH] fix timer thinko

2017-05-11 Thread Bernhard Reutner-Fischer
On 11 May 2017 at 16:52, Nathan Sidwell wrote: > Bernhard's pestering finally got through. There was an early out that > failed to stop the timer. > > fixed by rearranging the code. :) thanks. LGTM but i cannot approve it.

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-11 Thread Bernhard Reutner-Fischer
On 11 May 2017 15:10:36 CEST, Nathan Sidwell wrote: >On 05/11/2017 08:28 AM, Rainer Orth wrote: > >> On the gcc-7 branch, the dump file (from -fdump-class-hierarchy) was >> called covariant7.C.002t.class, now it's covariant7.C.002l.class. >But >> gcc/testsuite/lib/scantree.exp (scan-tree-dump) ex

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-11 Thread Bernhard Reutner-Fischer
On 12 May 2017 00:57:58 CEST, Rainer Orth wrote: >Bernhard Reutner-Fischer writes: > >> On 11 May 2017 15:10:36 CEST, Nathan Sidwell wrote: >>>On 05/11/2017 08:28 AM, Rainer Orth wrote: >>> >>>> On the gcc-7 branch, the dump file (from -fdump-clas

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-11 Thread Bernhard Reutner-Fischer
On 12 May 2017 02:29:58 CEST, Nathan Sidwell wrote: >On 05/11/2017 06:52 PM, Bernhard Reutner-Fischer wrote: >> On 11 May 2017 15:10:36 CEST, Nathan Sidwell wrote: > >> Anyway, please also adjust the dump cleanup to handle class or I can >take care of it sometimes later. &

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-13 Thread Bernhard Reutner-Fischer
On 12 May 2017 01:10:19 CEST, Bernhard Reutner-Fischer wrote: >On 12 May 2017 00:57:58 CEST, Rainer Orth >wrote: >>Bernhard Reutner-Fischer writes: >> >>> On 11 May 2017 15:10:36 CEST, Nathan Sidwell wrote: >>>>On 05/11/2017 08:28 AM, Rainer Orth wro

Re: dejagnu version update?

2017-05-13 Thread Bernhard Reutner-Fischer
On Tue, Sep 15, 2015 at 10:50:12PM +0200, Bernhard Reutner-Fischer wrote: > On September 15, 2015 10:05:27 PM GMT+02:00, Jeff Law wrote: > >On 09/15/2015 01:21 PM, David Malcolm wrote: > >> On Tue, 2015-09-15 at 10:39 -0700, Mike Stump wrote: > >>> On Sep 14, 201

Re: dejagnu version update?

2017-05-16 Thread Bernhard Reutner-Fischer
On 16 May 2017 11:54:18 CEST, Jonathan Wakely wrote: >On 13 May 2017 at 11:38, Jakub Jelinek wrote: >> On Sat, May 13, 2017 at 12:24:12PM +0200, Bernhard Reutner-Fischer >wrote: >>> I guess neither redhat >>> (https://access.redhat.com/downloads/content/dejagnu/ red

Re: dejagnu version update?

2017-05-16 Thread Bernhard Reutner-Fischer
On 16 May 2017 at 14:16, Jonathan Wakely wrote: > On 16 May 2017 at 13:13, Bernhard Reutner-Fischer wrote: >> 1.5.0 wouldn't buy us anything as the "libdirs" handling is only in 1.5.2 >> and later. > > Ah I missed that in the earlier discussion. > >

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-30 Thread Bernhard Reutner-Fischer
On 29 May 2017 17:49:30 CEST, Nicolas Koenig wrote: >Hello Dominique, > >mea culpa, their was a bit confusion with the file being open in emacs >and vi at the same time. Attached is the new patch with the #define >removed. +static int +simplify_io_impl_do (gfc_code **code, int *walk_subtrees, +

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-05-31 Thread Bernhard Reutner-Fischer
On 31 May 2017 at 21:03, Nicolas Koenig wrote: > Hello Dominique, > > attached is the next try, this time without stupidities (I hope). Both test > cases you posted don't ICE anymore. > > Ok for trunk? Please check contrib/check_GNU_style.sh /tmp/p8.diff and let me point you to contrib/vimrc Fur

Re: [PATCH v2] Implement no_sanitize function attribute

2017-06-01 Thread Bernhard Reutner-Fischer
On 31 May 2017 14:25:09 CEST, "Martin Liška" wrote: >I've got written that on my TODO list. Will work on that some time in >the stage1. BTW.. May I ask you to put it below https://gcc.gnu.org/PR65534 (the tailcall resp. IPA-ICF thing :-) Many TIA and cheers,

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

2017-06-03 Thread Bernhard Reutner-Fischer
On Sat, Jun 03, 2017 at 09:25:31AM -0700, Jerry DeLisle wrote: > On 06/03/2017 06:48 AM, Nicolas Koenig wrote: > > Hello everyone, > > > > here is a version of the patch that includes a workaround for PR 80960. I > > have > > also included a separate test case for the failure that Dominique detec

Re: Reorgnanization of profile count maintenance code, part 1

2017-06-03 Thread Bernhard Reutner-Fischer
On Thu, Jun 01, 2017 at 01:35:56PM +0200, Jan Hubicka wrote: Just some very minor nits. > Index: final.c > === > --- final.c (revision 248684) > +++ final.c (working copy) > @@ -1951,9 +1951,11 @@ dump_basic_block_info (FILE *fil

Re: [PATCH] handle bzero/bcopy in DSE and aliasing (PR 80933, 80934)

2017-06-04 Thread Bernhard Reutner-Fischer
On 2 June 2017 13:12:41 CEST, Richard Biener wrote: >Note I'd be _much_ more sympathetic to simply canonicalizing all of >bzero and bcopy >to memset / memmove and be done with all the above complexity. Indeed and even more so since SUSv3 marked it LEGACY and both were removed in SUSv4. thanks,

Re: [PATCH 4/6] RISC-V Port: libsanitizer

2017-01-13 Thread Bernhard Reutner-Fischer
On 12 January 2017 03:30:36 CET, Palmer Dabbelt wrote: >--- a/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc >+++ b/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc >@@ -64,7 +64,7 @@ namespace __sanitizer { > >#if !defined(__powerpc64__) && !defined(__x86_64__)

Re: [PATCH] ARM: Introduce ARM_DEFAULT_SHORT_ENUMS

2017-04-04 Thread Bernhard Reutner-Fischer
On 3 April 2017 13:32:30 CEST, Sebastian Huber wrote: >Allow targets to define the default for the short enums option. Does this work nowadays? About 10 years ago I did this for some arm and had to force TREE_CODE at al to 16 bit manually, IIRC. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3420

Re: [PATCH v2,rs6000] PR80108: Fix ICE with cross compiler

2017-04-07 Thread Bernhard Reutner-Fischer
On 7 April 2017 21:54:24 CEST, Segher Boessenkool wrote: >Hi Kelvin, > >Sorry this has fallen by the wayside. I did mark it "to do", and then >promptly buried it. Whoops. > >On Thu, Apr 06, 2017 at 08:36:00AM -0600, Kelvin Nilsen wrote: > >> +dg-test $gfortran_test_path/[lindex $args 1] ""

Re: [Patch, Fortran] PR 80121: Memory leak with derived-type intent(out) argument

2017-04-24 Thread Bernhard Reutner-Fischer
On 24 April 2017 10:56:57 CEST, Janus Weil wrote: >Hi Christophe, > >2017-04-24 10:25 GMT+02:00 Christophe Lyon >: > the patch in the attachment fixes a memory leak by >auto-deallocating > the allocatable components of an allocatable intent(out) argument. > > Regtests cleanly on x8

Re: [PATCH, v3] Fix PR51513, switch statement with default case containing __builtin_unreachable leads to wild branch

2017-04-27 Thread Bernhard Reutner-Fischer
On Wed, Apr 26, 2017 at 10:39:12PM -0500, Peter Bergner wrote: > +/* Returns true if the basic block BB has no successors and only contains > + a call to __builtin_unreachable (). */ so return EDGE_COUNT (bb->succs) == 0 && (gsi = gsi_last_nondebug_bb (bb)) && !gsi_end_p (gsi) &&

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-16 Thread Bernhard Reutner-Fischer
On 15 September 2017 18:20:33 CEST, Pierre-Marie de Rodat wrote: >On 09/15/2017 06:10 PM, Jeff Law wrote: >> OK. >> jeff > >Committed. Thanks! + * for result-adjusting thinks, the FIXED_OFFSET adjustment is done after s/think/thunk/ TIA

Re: [PATCH] Factor out division by squares and remove division around comparisons (1/2)

2017-09-16 Thread Bernhard Reutner-Fischer
On 15 September 2017 18:50:26 CEST, Jeff Law wrote: >On 09/13/2017 03:20 PM, Wilco Dijkstra wrote: >> Jeff Law wrote: >>> On 09/06/2017 03:55 AM, Jackson Woodruff wrote: On 08/30/2017 01:46 PM, Richard Biener wrote: >> >rdivtmp = 1 / (y*C); >tem = x *rdivtmp; >tem2= z

Re: [PATCH][RFC] Radically simplify emission of balanced tree for switch statements.

2017-09-21 Thread Bernhard Reutner-Fischer
On 20 September 2017 17:00:13 CEST, Jeff Law wrote: >On 09/20/2017 01:24 AM, Martin Liška wrote: > >> >> Hello. >> >> Thank you Jeff for very verbose explanation what's happening. I'm >planning to do >> follow-up of this patch that will include clustering for bit-tests >and jump tables. >> Maybe

Re: [PATCH PR82163/V2]New interface checking LCSSA for single loop

2017-09-23 Thread Bernhard Reutner-Fischer
On Fri, Sep 22, 2017 at 11:37:53AM +, Bin Cheng wrote: > diff --git a/gcc/tree-ssa-loop-manip.c b/gcc/tree-ssa-loop-manip.c > index d6ba305..6ad0b75 100644 > --- a/gcc/tree-ssa-loop-manip.c > +++ b/gcc/tree-ssa-loop-manip.c > @@ -690,48 +690,62 @@ rewrite_virtuals_into_loop_closed_ssa (struct

Re: Remove non-GAS non-ELF support in alpha backend

2017-09-26 Thread Bernhard Reutner-Fischer
On Wed, Mar 14, 2012 at 07:02:33PM +0100, Rainer Orth wrote: > Richard Henderson writes: > > > On 03/14/12 09:09, Rainer Orth wrote: > > > > Nearly ok. > > > >> + targetm.asm_file_start_file_directive = 0; > > > > This is default and may be deleted. > > Or would be if alpha.c didn't override th

Re: [PATCH v2,rs6000] Replace swap of a loaded vector constant with load of a swapped vector constant

2017-09-26 Thread Bernhard Reutner-Fischer
On 26 September 2017 12:57:37 CEST, Segher Boessenkool wrote: >> --- gcc/testsuite/gcc.target/powerpc/swps-p8-36.c(revision 0) >> +++ gcc/testsuite/gcc.target/powerpc/swps-p8-36.c(working copy) >> @@ -0,0 +1,31 @@ >> +/* This file's name was changed from swaps-p8-36.c so that the >> +

Re: [C++ PATCH] Move mangling alias out of ::

2017-10-05 Thread Bernhard Reutner-Fischer
On Wed, Oct 04, 2017 at 12:51:18PM -0400, Nathan Sidwell wrote: > Applying to trunk. +void +record_mangling (tree decl, bool need_warning) +{ + if (!mangled_decls) +mangled_decls = hash_map::create_ggc (499); + + gcc_checking_assert (DECL_ASSEMBLER_NAME_SET_P (decl)); + tree id = DECL_ASSE

Re: [PATCH] update-copyright.py: Retain file mode

2017-01-30 Thread Bernhard Reutner-Fischer
On Tue, Jun 21, 2016 at 09:00:58AM -0600, Jeff Law wrote: > On 06/21/2016 08:14 AM, Bernhard Reutner-Fischer wrote: > > Hi! > > > > Ok for trunk? > > > > thanks, > > > > contrib/ChangeLog > > > > 2016-06-21 Bernhard Reutner-Fischer &

Re: [PATCH] Actually fix libhsail-rt build on x86_64/i?86 32-bit (take 2)

2017-01-30 Thread Bernhard Reutner-Fischer
On 30 January 2017 18:37:00 CET, Jakub Jelinek wrote: >Hi! > >On Mon, Jan 30, 2017 at 05:56:36PM +0100, Bernhard Reutner-Fischer >wrote: >> On 30 January 2017 10:56:59 CET, Jakub Jelinek >wrote: >> >> >+++ libhsail-rt/rt/sat_arithmetic.c 2017-01-30 10:27:27.8

Re: [committed] move constant to the right of relational operators (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-31 Thread Bernhard Reutner-Fischer
On 31 January 2017 00:19:46 CET, Martin Sebor wrote: >> So I see the introduction of many >> >> if (const OP object) expressions >> >> Can you please fix those as an independent patch after #4 and #5 are >> installed on the trunk? Consider that patch pre-approved, but please >> post it here for t

Re: [PATCH 2/8] [i386] Add option -moutline-msabi-xlogues

2017-02-08 Thread Bernhard Reutner-Fischer
On 7 February 2017 19:40:17 CET, Daniel Santos wrote: >+{ "-mmoutline-msabi-xlogues", MASK_OUTLINE_MSABI_XLOGUES } > }; s/mm/m/ >+thus reducing function size at the cost of and few extra instructions. s/and/a/

Re: [PATCH] Improve x % y to x VRP optimization (PR tree-optimization/79408)

2017-02-09 Thread Bernhard Reutner-Fischer
On 8 February 2017 09:41:47 CET, Richard Biener wrote: >On Tue, 7 Feb 2017, Jakub Jelinek wrote: >> +/* { dg-final { scan-tree-dump-times "link_error" 0 "optimized"} } >*/ scan-tree-dump-not would have been more expressive, FWIW.

Re: [PATCH 1/2] [ARM] Refactor costs calculation for MEM.

2017-02-22 Thread Bernhard Reutner-Fischer
On 21 February 2017 17:54:23 CET, charles.bay...@linaro.org wrote: >From: Charles Baylis > >+/* Convert fron bytes to ints. */ s/fron/from/ >+#define ARM_NUM_INTS(X) (((X) + UNITS_PER_WORD - 1) / UNITS_PER_WORD) >+ >+ > /* RTX costs. Make an estimate of the cost of executing the operation >

Re: [PATCH] For broken exception handling in GDB on AIX platform

2017-03-07 Thread Bernhard Reutner-Fischer
On 7 March 2017 13:43:00 CET, Nitish Kumar Mishra wrote: >Hi, > >I have update the patch according to some comments from GDB community. >Please find the attachments. If it is AIX specific, you probably should not remove fuchsia support. And since we most likely do not link host_tools statically

Re: [PATCH 1/7] Add missing punctuation to message (PR driver/79875)

2017-03-14 Thread Bernhard Reutner-Fischer
On 11 March 2017 11:28:46 CET, Roland Illig wrote: >Am 10.03.2017 um 05:12 schrieb Martin Sebor: >> I have just an observation/question here for future consideration. >> If this sort of diagnostic is common (I count 23 instances of it) >> or if it is expected to become common, would it make sense

Re: [patch,fortran] PR69043 Trying to include a directory causes an infinite loop

2016-03-13 Thread Bernhard Reutner-Fischer
On March 13, 2016 3:22:53 AM GMT+01:00, Jerry DeLisle wrote: >I plan to commit the attached patch and test case under simple and >obvious tomorrow. First, the patch adds superfluous vertical whitespace. Second, and I apologise for stating the obvious, I'd make that a whitelist instead, I.e onl

Re: [PATCH] Fix PR56365

2016-03-14 Thread Bernhard Reutner-Fischer
On March 14, 2016 12:58:20 PM GMT+01:00, Richard Biener wrote: > >I am testing the following patch to fix the regression in min/max >detection introduced by comparison canonicalization like a < 267 >to a <= 266. The patch allows us to identify all four min/max >cases in the testcase below. > >Bo

Re: [PATCH] Fix PR56365

2016-03-14 Thread Bernhard Reutner-Fischer
On March 14, 2016 9:21:25 PM GMT+01:00, Richard Biener wrote: >On March 14, 2016 7:25:31 PM GMT+01:00, Bernhard Reutner-Fischer > wrote: >>On March 14, 2016 12:58:20 PM GMT+01:00, Richard Biener >> wrote: >>>+ >>>+ int test_01 (int a) >>>+

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2016-03-16 Thread Bernhard Reutner-Fischer
On March 16, 2016 3:17:20 AM GMT+01:00, "H.J. Lu" wrote: >> Where is the current definition of empty types you're proposing for >use in >> GCC? Is the behavior of this case clear from that definition? > >https://gcc.gnu.org/ml/gcc/2016-03/msg00071.html > >Jason's patch follows it. Here is a tes

Re: [PATCH V3]PR other/70268: map one directory name (old) to another (new) in __FILE__

2016-03-19 Thread Bernhard Reutner-Fischer
On March 18, 2016 6:16:46 AM GMT+01:00, Hongxu Jia wrote: +/* Perform user-specified mapping of __FILE__ prefixes. Return + the new name corresponding to filename. */ + +const char * +remap_file_filename (const char *filename) +{ + file_prefix_map *map; + char *s; + const char *name; +

Re: Do not give realistic estimates for loop with array accesses

2016-03-30 Thread Bernhard Reutner-Fischer
On March 30, 2016 2:36:14 PM GMT+02:00, Richard Biener wrote: >On Wed, 30 Mar 2016, Jan Hubicka wrote: > >> > >> > You are only changing one place in this file. >> >> You are right. I am attaching the updated patch which I am re-testing >now. >> > >> > The vectorizer already checks this (albei

Re: [PATCH, fortran, v3] Use Levenshtein spelling suggestions in Fortran FE

2016-04-23 Thread Bernhard Reutner-Fischer
On March 7, 2016 3:57:16 PM GMT+01:00, David Malcolm wrote: >On Sat, 2016-03-05 at 23:46 +0100, Bernhard Reutner-Fischer wrote: >[...] > >> diff --git a/gcc/fortran/misc.c b/gcc/fortran/misc.c >> index 405bae0..72ed311 100644 >> --- a/gcc/fortran/misc.c

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-07 Thread Bernhard Reutner-Fischer
On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov wrote: >Hi all, s/contigous/contiguous/ s/ where where/ where/ +struct merged_store_group +{ + HOST_WIDE_INT start; + HOST_WIDE_INT width; + unsigned char *val; + unsigned int align; + auto_vec stores; + /* We record the first and

Re: [PATCH][v3] GIMPLE store merging pass

2016-09-08 Thread Bernhard Reutner-Fischer
On 8 September 2016 at 10:31, Kyrill Tkachov wrote: > > On 07/09/16 20:03, Bernhard Reutner-Fischer wrote: >> >> On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov >> wrote: > Thanks, fixed all the above in my tree (will be retesting). > >> What abo

Re: [PATCH] Fix PR77514

2016-09-16 Thread Bernhard Reutner-Fischer
On 15 September 2016 09:08:36 CEST, Richard Biener wrote: > >Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. > >+ /* Likewise if we simplified to sth not queued for insertion. */ >+ bool found = false; >+ gsi = gsi_start (forced_stmts); >+ for (; !gsi_end_p (gsi); gsi_

Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-22 Thread Bernhard Reutner-Fischer
On 22 September 2016 11:11:42 CEST, Andreas Schwab wrote: >On Sep 22 2016, Sebastian Huber >wrote: > >> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 >> index 6d897be..d7db435 100644 >> --- a/libstdc++-v3/acinclude.m4 >> +++ b/libstdc++-v3/acinclude.m4 >> @@ -3490,9 +3490,10

Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-26 Thread Bernhard Reutner-Fischer
On 26 September 2016 10:27:13 CEST, Andreas Schwab wrote: >On Sep 22 2016, Bernhard Reutner-Fischer wrote: > >> On 22 September 2016 11:11:42 CEST, Andreas Schwab >wrote: >>>On Sep 22 2016, Sebastian Huber >>>wrote: >>> >>>> diff --git a

Re: [PATCH, libfortran] PR 48587 Newunit allocator

2016-10-14 Thread Bernhard Reutner-Fischer
On 13 October 2016 22:08:21 CEST, Jerry DeLisle wrote: >On 10/13/2016 08:16 AM, Janne Blomqvist wrote: >> >> Regtested on x86_64-pc-linux-gnu. Ok for trunk? >> > >Yes, OK, clever! Thanks! Is 32 something a typical program uses? I'd have started at 8 and had not doubled but += 16 fwiw. Cheers

Re: [PATCH, libfortran] PR 48587 Newunit allocator

2016-10-14 Thread Bernhard Reutner-Fischer
On 14 October 2016 22:41:25 CEST, Janne Blomqvist wrote: >On Fri, Oct 14, 2016 at 8:01 PM, Bernhard Reutner-Fischer > wrote: >> On 13 October 2016 22:08:21 CEST, Jerry DeLisle > wrote: >>>On 10/13/2016 08:16 AM, Janne Blomqvist wrote: >> >>>> >>&

Ping: [Re: [PATCH, fortran, v4] Use Levenshtein spelling suggestions in Fortran FE]

2016-07-03 Thread Bernhard Reutner-Fischer
Ping On June 18, 2016 9:58:47 PM GMT+02:00, Bernhard Reutner-Fischer wrote: >Hi, > >Ok for trunk? > >Changes for v4 -> v3: > >- rebased >- Use 4 argument levenshtein_distance() to save multiple strlen(typo) > calls as suggested by dmalcolm > >Changes for v

Re: [PATCH 3/4] Run profile feedback tests with autofdo

2016-04-30 Thread Bernhard Reutner-Fischer
On April 27, 2016 5:27:32 PM GMT+02:00, Bernd Schmidt wrote: >On 03/28/2016 06:44 AM, Andi Kleen wrote: >> From: Andi Kleen > >> @@ -313,6 +320,7 @@ proc profopt-execute { src } { >> # valid, by running it after dg-additional-files-options. >> foreach ext $prof_ext { >> profo

Re: [PATCH,rs6000] Add built-in support for new Power9 darn (deliver a random number) instruction

2016-05-05 Thread Bernhard Reutner-Fischer
On May 5, 2016 6:26:01 PM GMT+02:00, Kelvin Nilsen wrote: >+ /* Handle simple no-argument operations. */ >+ d = bdesc_0arg; >+ for (i = 0; i < ARRAY_SIZE (bdesc_0arg); i++, d++) >+if (d->code == fcode) >+ return rs6000_expand_zeroop_builtin (d->icode, target); >+ >+ gcc_assert (fals

Re: [PATCH] Fix PR70497, missed "subreg" CSE on GIMPLE

2016-05-10 Thread Bernhard Reutner-Fischer
On May 9, 2016 3:42:21 PM GMT+02:00, Richard Biener wrote: >On Mon, 9 May 2016, Marc Glisse wrote: > >> On Mon, 9 May 2016, Richard Biener wrote: s/ROCDE/RCODE/ Thanks,

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-10 Thread Bernhard Reutner-Fischer
On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: >Hi, this patch resolves an ICE for Fortran when using the OpenACC >host_data directive. Actually, rather than say resolve, it's more like >adjusting the front-end to same middle-end restrictions as C/C++, >namely that we only support po

Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments

2016-05-10 Thread Bernhard Reutner-Fischer
On Mon, May 09, 2016 at 08:14:47PM -0400, David Malcolm wrote: > - inform (loc, "valid arguments to %qs are: %s", option->opt_text, s); > + const char *hint = find_closest_string (arg, &candidates); > + if (hint) > + inform (loc, "valid arguments to %qs are: %s; did you mean %qs

Re: [PATCH] Fix PR71039

2016-05-11 Thread Bernhard Reutner-Fischer
On May 10, 2016 3:07:12 PM GMT+02:00, Richard Biener wrote: > >The following fixes PR71039 - we were failing to verify we can >insert the lhs on the predecessor edges. > >Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. >+ /* Verify if *idx is available at *DATA. */ >+ >+ static bo

Re: [PATCH] Fix PR71039

2016-05-11 Thread Bernhard Reutner-Fischer
On May 11, 2016 11:36:11 AM GMT+02:00, Richard Biener wrote: >On Wed, 11 May 2016, Bernhard Reutner-Fischer wrote: > >> On May 10, 2016 3:07:12 PM GMT+02:00, Richard Biener > wrote: >> > >> >The following fixes PR71039 - we were failing to verify we can >> &

Re: [PATCH, PR71084] Further improve of CFG change tracking in CSE

2016-05-13 Thread Bernhard Reutner-Fischer
On May 13, 2016 11:50:33 AM GMT+02:00, Richard Biener wrote: >On Fri, May 13, 2016 at 11:03 AM, Ilya Enkovich > wrote: >> Hi, >> >> This patch improves cse_cfg_altered computation by taking into >account >> cleanup_cfg returned values. This resolves another case of >invalidated >> dominance info

Re: [PATCH][MIPS] Add -mgrow-frame-downwards option

2016-05-20 Thread Bernhard Reutner-Fischer
On May 20, 2016 4:58:47 PM GMT+02:00, Robert Suchanek wrote: s/splots/slots/ thanks,

Re: [PATCH 1/5] Add gcc-auto-profile script

2016-05-21 Thread Bernhard Reutner-Fischer
On May 21, 2016 6:36:22 PM GMT+02:00, Andi Kleen wrote: >From: Andi Kleen >+if [ "$1" = "--kernel" ] ; then >+ FLAGS=k >+ shift >+fi >+if [ "$1" == "--all" ] ; then == is legacy, s/==/=/ >+ FLAGS=uk >+ shift >+fi >+ >+if ! grep -q Intel /proc/cpuinfo ] ; then >+ echo >&2 "Only Intel CPUs

Re: [PATCH 2/5] Don't cause ICEs when auto profile file is not found with checking

2016-05-21 Thread Bernhard Reutner-Fischer
On May 21, 2016 6:36:23 PM GMT+02:00, Andi Kleen wrote: >From: Andi Kleen > >Currently, on a checking enabled compiler when -fauto-profile does >not find the profile feedback file it errors out with assertation >failures. Add proper errors for this case. Please s/mathch/match/ while at it. than

Re: [PATCH 3/5] Run profile feedback tests with autofdo

2016-05-21 Thread Bernhard Reutner-Fischer
On May 21, 2016 6:36:24 PM GMT+02:00, Andi Kleen wrote: >From: Andi Kleen >diff --git a/gcc/testsuite/lib/profopt.exp >b/gcc/testsuite/lib/profopt.exp >index 0aea6c4..4ddb10a 100644 >--- a/gcc/testsuite/lib/profopt.exp >+++ b/gcc/testsuite/lib/profopt.exp >@@ -36,7 +36,7 @@ load_lib gcc-dg.exp >

Re: [PATCH, rs6000] Extend LE swap optimization to handle vector permutes with constant masks

2015-09-10 Thread Bernhard Reutner-Fischer
On September 10, 2015 7:48:10 PM GMT+02:00, David Edelsohn wrote: >On Thu, Sep 10, 2015 at 1:41 PM, Bill Schmidt > wrote: >> Currently the little-endian swap optimization is disabled for >> computations that include vector permute instructions. We generate a >> vperm in a variety of ways, and fo

Re: [PATCH] Teach genmatch.c to generate single-use restrictions from flags

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 11:23:28 AM GMT+02:00, Richard Biener wrote: >On Fri, 11 Sep 2015, Bernd Schmidt wrote: > >> On 07/08/2015 04:39 PM, Richard Biener wrote: >> > >> > This introduces a :s flag to match expressions which enforces >> > the expression to have a single-use if(!) the simplified >

Re: [PATCH 1/4] [ARM] Add attribute/pragma target fpu=

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 11:36:13 AM GMT+02:00, Christian Bruel wrote: >Hi, > >This patch moves the FPU flags settings and checks to the attribute >hooks. .e.g neon must be checked in arm_option_check_internal. FPU name > >is emitted before each function and arm_fpu_index is Saved to be >handled >

Re: [PATCH 3/4] [ARM] Add attribute/pragma target fpu=

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 1:39:28 PM GMT+02:00, Christian Bruel wrote: >This patch splits the neon_builtins initialization into 2 internals >functions. One for NEON and one for CRYPTO, each one guarded by its own > >predicate. arm_init_neon_builtins is now global to be called from >arm_valid_target

Re: [PATCH 4/4] [ARM] Add attribute/pragma target fpu=

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 4:30:23 PM GMT+02:00, Christian Bruel wrote: >Finally, the final part of the patch set does the attribute target >parsing and checking, redefines the preprocessor macros and implements >the inlining rules. > >testcases and documentation included. @@ -29501,6 +29532,8 @@

Re: [PATCH 2/4] [ARM] Add attribute/pragma target fpu=

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 12:47:23 PM GMT+02:00, Christian Bruel wrote: >This patch defines and uses accessors for the current fpu type fields, >based on switchable arm_fpu_index rather than defuncted arm_fpu_desc. * config/arm/arm.c (arm_fpu_desc): Remove. (all_fpus): Make global.

Re: [PATCH 02/22] Testsuite: add dg-{begin|end}-multiline-output commands

2015-09-14 Thread Bernhard Reutner-Fischer
On September 14, 2015 9:32:54 PM GMT+02:00, Jeff Law wrote: >On 09/10/2015 02:28 PM, David Malcolm wrote: >> >> multiline.exp is used by prune.exp; hence we need to load it before >> prune.exp via *load_gcc_lib* for the testsuites of the various >> non-"gcc" support libraries (e.g. boehm-gc). >?!

Re: [PATCH] v2 Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE

2015-12-12 Thread Bernhard Reutner-Fischer
On December 9, 2015 2:07:05 AM GMT+01:00, David Malcolm wrote: >I can't comment on Mikael's observations, but here's an updated version >of Bernhard's patch which moves the duplicated code into a new >"find_closest_string" function in gcc/spellcheck.c. >With that, the lookup_*_fuzzy functions

Re: [PTX] simplify calling struct

2015-12-17 Thread Bernhard Reutner-Fischer
On December 16, 2015 2:53:51 PM GMT+01:00, Nathan Sidwell wrote: >PTX's machine_function structure squirrels away the function type to >calculate >the presence of varadic args later, rather than calculate it >immediately. It >also uses an rtx field as a boolean. This patch reorganizes it wi

[PATCH, RFC, v2] Use Levenshtein spelling suggestions in Fortran FE

2015-12-27 Thread Bernhard Reutner-Fischer
gcc/fortran/ChangeLog 2015-12-27 Bernhard Reutner-Fischer * gfortran.h (gfc_lookup_function_fuzzy): New declaration. (gfc_closest_fuzzy_match): New declaration. (vec_push): New definition. * misc.c (gfc_closest_fuzzy_match): New definition. * resolve.c

[PATCH] validate_failures.py: also ignore .git

2012-12-04 Thread Bernhard Reutner-Fischer
contrib/ChangeLog: 2012-12-01 Bernhard Reutner-Fischer * testsuite-management/validate_failures.py (IsInterestingResult): Only strip line a second time if we did split. Rephrase return statement while at it. (CollectSumFiles): Also ignore .git directory

Re: [PATCH] validate_failures.py: also ignore .git

2012-12-04 Thread Bernhard Reutner-Fischer
On Tue, Dec 04, 2012 at 08:53:50AM -0500, Diego Novillo wrote: >On Tue, Dec 4, 2012 at 4:24 AM, Bernhard Reutner-Fischer > wrote: >> contrib/ChangeLog: >> >> 2012-12-01 Bernhard Reutner-Fischer >> >> * testsuite-management/validate_failures.py &g

[PATCH] validate_failures.py: Fix performance regression

2012-12-06 Thread Bernhard Reutner-Fischer
2012-12-06 Bernhard Reutner-Fischer * testsuite-management/validate_failures.py (IsInterestingResult): Fix performance regression --- Rephrasing the return statement was not a good idea, it regressed tremendously ;) ==> LOG-before <== real0m22.696s user0m19.95

RE: [patch] cilkplus: Array notation for C patch

2013-04-30 Thread Bernhard Reutner-Fischer
On 30 April 2013 00:55:16 "Joseph S. Myers" wrote: > + if (flag_enable_cilkplus && contains_array_notation_expr (cond)) > +{ > + error_at (start_locus, "array notation expression cannot be used in a " > + "loop%'s condition"); > + return; > +} > + if (flag_enable_

Re: section anchors and weak hidden symbols

2013-05-08 Thread Bernhard Reutner-Fischer
On 8 May 2013 15:11:18 Jan Hubicka wrote: > 2013-05-08 Nathan Sidwell >gcc/ >* varasm.c (default_use_anchors_for_symbol_p): Reject WEAK. >gcc/testsuite/ >* gcc.dg/visibility-21.c: New. > Index: gcc/varasm.c > ===

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-09 Thread Bernhard Reutner-Fischer
On Thu, May 09, 2013 at 05:52:26PM +0800, Chung-Lin Tang wrote: >2013-05-09 Chung-Lin Tang > > PR target/32219 > * rtlanal.c (nonzero_address_p): Robustify checking by look >recursively into PIC constant offsets and (CONST (UNSPEC ...)) > expressions. >Index: rtlanal.

Re: [patch] Small emit-rtl.c / reorg.c cleanup

2013-05-12 Thread Bernhard Reutner-Fischer
On 11 May 2013 21:29:53 Steven Bosscher wrote: Hello, This just removes one unused function, and moves two functions from emit-rtl.c to reorg.c which is the only place where they're used. Will commit in a few days, barring objections. Ciao! Steven * rtl.h (next_label, skip_consecuti

Re: [rs6000] Add register save/restore routines for cross

2013-05-22 Thread Bernhard Reutner-Fischer
On 22 May 2013 16:36:52 David Edelsohn wrote: On Wed, May 22, 2013 at 10:35 AM, Alan Modra wrote: > On Wed, May 22, 2013 at 10:05:47AM -0400, David Edelsohn wrote: >> Why does cross need the functions in libgcc and not provided by the linker? > > Only the ppc64 linker provides save/restore func

Re: [Patch, Fortran] Better error messages for type/rank checks

2013-05-31 Thread Bernhard Reutner-Fischer
On 31 May 2013 15:57:25 Manfred Schwarb wrote: Am 31.05.2013 14:28, schrieb Janus Weil: >> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports >> that we're outputting to a terminal? > > Good point. Updated patch attached, which imposes no limit if we're > not outputting to a t

Re: [PATCH] gfortran testsuite: implicitly cleanup-modules

2013-06-07 Thread Bernhard Reutner-Fischer
On 29 June 2012 04:59, Mike Stump wrote: > On Jun 28, 2012, at 5:15 PM, Bernhard Reutner-Fischer wrote: >> On Thu, Jun 28, 2012 at 04:43:05PM -0700, Mike Stump wrote: >>> On Jun 28, 2012, at 3:27 PM, Bernhard Reutner-Fischer wrote: >>>> Perhaps you want to pursue t

<    1   2   3   4   5   6   7   8   9   10   >