On March 13, 2016 3:22:53 AM GMT+01:00, Jerry DeLisle <jvdeli...@charter.net> 
wrote:
>I plan to commit the attached patch and test case under simple and
>obvious tomorrow.

First, the patch adds superfluous vertical whitespace.

Second, and I apologise for stating the obvious, I'd make that a whitelist 
instead, I.e only allow regular files or symlinks pointing to regular files as 
I think there are no sensible use cases for including e.g. block- or char 
devices et al. Including a pipe would maybe be possible to support but I doubt 
this is a usual usage pattern.

Thanks,

Reply via email to