Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-06 Thread Tobias Burnus
On Sunday, July 6, 2025, Yuao Ma wrote: >>> Since I don't have root/sudo permissions on my devbox, I manually downloaded >>> and compiled the autoconf 2.69 tarball. This means there might be some minor >>> discrepancies compared to the version shipped with OS distributions. In principle, having a

Re: [PATCH v2] doc: Correct the return type of float comparison

2025-07-06 Thread Trevor Gross
On Tue May 27, 2025 at 9:35 PM CDT, Trevor Gross wrote: > Documentation for `__cmpsf2` and similar functions currently indicate a > return type of `int`. This is not correct however; the `libgcc` > functions return `CMPtype`, the size of which is determined by the > `libgcc_cmp_return` mode. > > Up

[patch,avr,applied] Add AVRxxDAyyS devices

2025-07-06 Thread Georg-Johann Lay
Applied as obvious. Johann -- AVR: Add support for AVR32DAxxS, AVR64DAxxS, AVR128DAxxS devices. gcc/ * config/avr/avr-mcus.def (avr32da28S, avr32da32S, avr32da48S) (avr64da28S, avr64da32S, avr64da48S avr64da64S) (avr128da28S, avr128da32S, avr128da48S, avr128da64S): Add

Add cutoff information to profile_info and use it when forcing non-zero value

2025-07-06 Thread Jan Hubicka
Hi, main difference between normal profile feedback and auto-fdo is that with profile feedback every basic block with non-zero profile has an incomming edge with non-zero profile. With auto-profile it is possible that none of predecessors was sampled and also the tool has cutoff parameter which

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-06 Thread Yuao Ma
Hi Tobias, On 7/6/2025 6:34 PM, Tobias Burnus wrote: As that commit is from 2020 and 2.69 in from 2012, it seems as if your autoconf is too new. Can you re-check that the right version is at the beginning of the PATH? Note that there is a CI job that checks whether the generated files are in

gcc-patches@gcc.gnu.org

2025-07-06 Thread Jan Hubicka
Hi, this fixes stupid mistake of mine in the overflow check for sreal multiplication. This was introduced this stage1 so unless we want to backport the ipa-cp heuristics bugfixes, this does not need to go to release branches. Regtested and bootstrapped x86_64-linux. Honza gcc/ChangeLog:

[PATCH v2] ipa, cgraph: Enable constant propagation to OpenMP kernels

2025-07-06 Thread Josef Melcr
> This patch enables constant propagation to outlined OpenMP kernels and > improves support for optimizing callback functions in general. It > implements the attribute 'callback' as found in clang, though argument > numbering is a bit different, as described below. The title says OpenMP, > but it

Re: [PATCH v3] RISC-V: Mips P8700 Conditional Move Support.

2025-07-06 Thread Umesh Kalappa
Hi @Jeff Law and @ma...@orcam.me.uk , Please have a look at the updated patch for conditional move support and any comments or suggestions please let us know ? Thank you ~U On Wed, Jul 2, 2025 at 12:46 PM Umesh Kalappa wrote: > Indentation are updated accordingly and no regress found. > >

[PATCH] crc: Error out on non-constant poly arguments for the crc builtins [PR120709]

2025-07-06 Thread Andrew Pinski
These builtins requires a constant integer for the third argument but currently there is assert rather than error. This fixes that and updates the documentation too. Uses the same terms as was being used for the __builtin_prefetch arguments. Bootstrapped and tested on x86_64-linux-gnu. P

Re: Fwd: [PATCH v3] simplify-rtx.cc:Simplify XOR(AND(ROTATE(~1) A) ASHIFT(1 A)) to IOR.

2025-07-06 Thread chenxiaolong
Hi, At present, the corresponding optimization function has not been verified through test cases redundant-bitmap-2.C  on RV. Part of the reason is that SHIFT_COUNT_TRUNCATED is defined as 0, which does not meet the condition. Could you provide some relevant test cases to verify the optimiza

RE: [PATCH v3 3/4] RISC-V: Implement unsigned scalar SAT_MUL from uint128_t

2025-07-06 Thread Li, Pan2
I see, thanks a lot. Pan -Original Message- From: Jeff Law Sent: Monday, July 7, 2025 10:38 AM To: Li, Pan2 ; Robin Dapp ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; Chen, Ken ; Liu, Hongtao Subject: Re: [PATCH v3 3/4] RISC-V: Implement unsigned scalar SA

RE: [PATCH] RISC-V: Add testcases for unsigned vector SAT_SUB form 11 and form 12

2025-07-06 Thread Li, Pan2
Thanks ciyuan. +#include "vec_sat_arith.h" + +#define T uint16_t +#define N 16 +#define RUN_VEC_SAT_BINARY RUN_VEC_SAT_U_SUB_FMT_11 + +DEF_VEC_SAT_U_SUB_FMT_11(T) + +T test_data[][3][N] = { + { +{ + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, +

Re: [PATCH v2] libstdc++: Use hidden friends for __normal_iterator operators

2025-07-06 Thread Jonathan Wakely
On Sun, 6 Jul 2025 at 19:53, Stephan Bergmann wrote: > > On 6/12/25 10:46, Jonathan Wakely wrote: > > It now says: > > > > I also had to reorder the __attribute__((always_inline)) and > > [[nodiscard]] attributes on the pre-c++20 operators, because Clang won't > > allow [[foo]] after _

Re: [PATCH v3 3/4] RISC-V: Implement unsigned scalar SAT_MUL from uint128_t

2025-07-06 Thread Jeff Law
On 7/4/25 10:54 PM, Li, Pan2 wrote: What you do want to watch out for is constants Here I want the max value of unsigned scalar based on mode, it could be UINT8_MAX, UINT16_MAX, UINT32_MAX and UINT64_MAX. Understood, but within the compiler HOST_WIDE_INT is how we tend to want to work on

[PATCH] RISC-V: Add testcases for unsigned vector SAT_SUB form 11 and form 12

2025-07-06 Thread Ciyan Pan
From: panciyan This patch adds testcase for form11 and form12, as shown below: void __attribute__((noinline)) \ vec_sat_u_sub_##T##_fmt_11 (T *out, T *op_1, T *op_2, unsigned limit) \ {\ u

Re: [SNAPv3] libstdc++: Add NTTP bind_front, _back (P2714) [PR119744]

2025-07-06 Thread Tomasz Kaminski
On Fri, Jul 4, 2025 at 6:39 AM Nathan Myers wrote: > This is a snapshot of work on P2714 "Bind front and back to NTTP > callables", posted for reference. > > Questions: > 1. Jonathan asks if __type_forward_like_t does the same job as __like_t > in bits/move.h. > 2. Could the "if constexpr" statem

Re: [PATCH v2 4/5] libstdc++: Implement mdspan and tests.

2025-07-06 Thread Tomasz Kaminski
On Thu, Jul 3, 2025 at 4:14 PM Luc Grosheintz wrote: > Thank you for the nice review! I've locally implemented everything and > I'll send a v3 later today or tomorrow; after squashing the commits > correctly; and retesting everything. > > Meanwhile a couple of comments below. > > On 7/1/25 16:42,

Re: [PATCH v2] libstdc++: Use hidden friends for __normal_iterator operators

2025-07-06 Thread Stephan Bergmann
On 6/12/25 10:46, Jonathan Wakely wrote: It now says: I also had to reorder the __attribute__((always_inline)) and [[nodiscard]] attributes on the pre-c++20 operators, because Clang won't allow [[foo]] after __attribute__((bar)) on a friend function: :4:36: error: an attribute l

Re: [PATCH] c++, v2: Pedwarn on invalid decl specifiers for for-range-declaration [PR84009]

2025-07-06 Thread Jason Merrill
On 7/5/25 1:05 PM, Jakub Jelinek wrote: On Sat, Jul 05, 2025 at 08:46:31AM -0400, Jason Merrill wrote: I think we want these diagnostics enabled by default; I don't feel strongly about unconditional pedwarn vs. permerror. So like this then? OK. 2025-07-05 Jakub Jelinek PR c++/8

Re: [PATCH 1/2] Allow the target to request a masked vector epilogue

2025-07-06 Thread Richard Biener
On Fri, 4 Jul 2025, Richard Sandiford wrote: > Richard Biener writes: > > @@ -1738,8 +1738,13 @@ protected: > >unsigned int m_suggested_unroll_factor; > > > >/* The suggested mode to be used for a vectorized epilogue or VOIDmode, > > - determined at finish_cost. */ > > + determ

Re: Add template keyword to for Clang

2025-07-06 Thread Tomasz Kaminski
Thanks. I am not sure if template is necessary here, as I believe this is type-only context, but I never understood the rules around this. On Sat, Jul 5, 2025 at 1:15 AM Jonathan Wakely wrote: > Clang wants this change: > > --- a/libstdc++-v3/include/std/mdspan > +++ b/libstdc++-v3/include/std/m

[r16-1971 Regression] FAIL: gcc.target/i386/pr120936-8.c check-function-bodies foo on Linux/x86_64

2025-07-06 Thread haochen.jiang
On Linux/x86_64, 349da53f13de274864d01b6ccc466961c472dbe1 is the first bad commit commit 349da53f13de274864d01b6ccc466961c472dbe1 Author: H.J. Lu Date: Thu Jul 3 10:13:48 2025 +0800 x86: Emit label only for __mcount_loc section caused FAIL: gcc.target/i386/pr120936-10.c check-function-bo

Re: [PATCH] crc: Error out on non-constant poly arguments for the crc builtins [PR120709]

2025-07-06 Thread Richard Biener
> Am 06.07.2025 um 23:23 schrieb Andrew Pinski : > > These builtins requires a constant integer for the third argument but > currently > there is assert rather than error. This fixes that and updates the > documentation too. > Uses the same terms as was being used for the __builtin_prefetch