I see, thanks a lot. Pan
-----Original Message----- From: Jeff Law <jeffreya...@gmail.com> Sent: Monday, July 7, 2025 10:38 AM To: Li, Pan2 <pan2...@intel.com>; Robin Dapp <rdapp....@gmail.com>; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; Chen, Ken <ken.c...@intel.com>; Liu, Hongtao <hongtao....@intel.com> Subject: Re: [PATCH v3 3/4] RISC-V: Implement unsigned scalar SAT_MUL from uint128_t On 7/4/25 10:54 PM, Li, Pan2 wrote: > >> What you do want to watch out for is constants > > Here I want the max value of unsigned scalar based on mode, it could be > UINT8_MAX, > UINT16_MAX, UINT32_MAX and UINT64_MAX. Understood, but within the compiler HOST_WIDE_INT is how we tend to want to work on objects. And to get constants handled correctly we use the macros I mentioned in the prior message. We don't tend to use things like int32_t, int64_t in the compiler itself. jeff