Re: [PATCH] libstdc++: Fix gnu.ver CXXABI_1.3.16 for Solaris [PR118701]

2025-02-04 Thread Jonathan Wakely
On Tue, 4 Feb 2025 at 14:19, Andreas Schwab wrote: > > On Feb 04 2025, Jonathan Wakely wrote: > > > I think this will cause check-abi failures on risc-v because the new > > symbols are added to CXXABI_1.3.16 but the "latest_p" map says that > > new symbols (i.e. ones not present in the baseline_sy

Re: [PATCH v1 06/16] Change function versions to be implicitly ordered.

2025-02-04 Thread Richard Sandiford
Richard Sandiford writes: > Alfie Richards writes: >> --- >> gcc/cgraph.cc| 39 +++--- >> gcc/config/aarch64/aarch64.cc| 37 +++- >> gcc/config/i386/i386-features.cc | 33 - >> gcc/config/riscv/riscv.

Re: [patch, fortran] Add modular exponentiation for unsigned

2025-02-04 Thread Thomas Koenig
Hi Jerry, committed as r15-7345 . Thanks for the review! Best regards Thomas

Re: The COBOL front end, in 8 notes + toplevel patch

2025-02-04 Thread James K. Lowden
[Well, that was interesting. Some combination of fat fingers crashed my mail client and sent the incomplete message. Continued below] From: "James K. Lowden" To: Matthias Klose Cc: gcc-patches@gcc.gnu.org Date: Tue, 4 Feb 2025 04:25:23 -0500 Subject: Re: The COBOL front end, in 8 notes + tople

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Simon Martin
Hi Jason, On 4 Feb 2025, at 16:39, Jason Merrill wrote: > On 1/15/25 9:56 AM, Jason Merrill wrote: >> On 1/15/25 7:24 AM, Simon Martin wrote: >>> Hi, >>> >>> On 14 Jan 2025, at 23:31, Jason Merrill wrote: >>> On 1/14/25 2:13 PM, Simon Martin wrote: > On 10 Jan 2025, at 19:10, Andrew Pins

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Marek Polacek
On Tue, Feb 04, 2025 at 10:39:44AM -0500, Jason Merrill wrote: > Does this also fix 118304? If so, let's go ahead and apply it to GCC 15. It does not, with this patch we emit an error, but still crash on struct A { *A() = default; }; Marek

Re: [PATCH] COBOL 8/8 bld: "meta" files, such a gcc/cobol/Make-lang.in

2025-02-04 Thread James K. Lowden
On Wed, 18 Dec 2024 20:37:13 + (UTC) Joseph Myers wrote: > So make sure your patches include the changes required to > update_web_docs_git to install HTML and PDF versions of those man > pages, and point to somewhere we can see the formatted versions. > That will then provide a way to compar

Re: [PATCH] c++: quadratic constexpr folding of arith expr [PR118340]

2025-02-04 Thread Jason Merrill
On 2/4/25 5:20 PM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for stage 1? Yes, OK for stage 1. -- >8 -- Here the PR's testcase demonstrates that the cp_fully_fold calls in cp_build_binary_op (for diagnosing arithmetic overflow) lead to quadrati

[PATCH] testsuite: Fix up toplevel-asm-1.c for LoongArch

2025-02-04 Thread Xi Ruoyao
Like RISC-V, on LoongArch we don't really support %cN for SYMBOL_REFs even with -fno-pic. gcc/testsuite/ChangeLog: * c-c++-common/toplevel-asm-1.c: Use %cc3 %cc4 instead of %c3 %c4 on LoongArch. --- Ok for trunk? gcc/testsuite/c-c++-common/toplevel-asm-1.c | 2 +- 1 file change

[PATCH] vect: Fix wrong code with pr108692.c on targets with only non-widening ABD [PR118727]

2025-02-04 Thread Xi Ruoyao
With things like // signed char a_14, a_16; a.0_4 = (unsigned char) a_14; _5 = (int) a.0_4; b.1_6 = (unsigned char) b_16; _7 = (int) b.1_6; c_17 = _5 - _7; _8 = ABS_EXPR ; r_18 = _8 + r_23; An ABD pattern will be recognized for _8: patt_31 = .ABD (a.0_4, b.1_6); It's still cor

Re: [PING, PATCH] fortran: fix -MT/-MQ adding additional target [PR47485]

2025-02-04 Thread Jerry D
Committed as: commit e41a5a2a0832509fa1c0b7cab0c8001fadbd23d4 (HEAD -> master, origin/master, origin/HEAD) Author: Jerry DeLisle Date: Tue Feb 4 17:21:42 2025 -0800 Fortran: Fix PR 47485. The -MT and -MQ options should replace the default target in the generated dependency file

[PATCH] c++: quadratic constexpr folding of arith expr [PR118340]

2025-02-04 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for stage 1? -- >8 -- Here the PR's testcase demonstrates that the cp_fully_fold calls in cp_build_binary_op (for diagnosing arithmetic overflow) lead to quadratic behavior when building up a large arithmetic constant expression

[wwwdocs] Document some further C++ FE changes

2025-02-04 Thread Marek Polacek
W3 validated. Pushed. commit 3c9e703a45f36113ace827463e6f0240fea334a2 Author: Marek Polacek Date: Tue Feb 4 17:20:18 2025 -0500 Document some further C++ FE changes. diff --git a/htdocs/gcc-15/changes.html b/htdocs/gcc-15/changes.html index 14dea6f4..18484915 100644 --- a/htdocs/gcc-15/c

Re: [PATCH] libstdc++: Implement LWG 4027 change to possibly-const-range [PR118083]

2025-02-04 Thread Patrick Palka
On Tue, 4 Feb 2025, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk and perhaps > 14 (after a long while)? > > -- >8 -- > > LWG 4027 effectively makes the const range access CPOs ranges::cfoo behave > more consistently across C++23 and C++20 (pre-P2278R4) and mo

Re: [PATCH v2] RISC-V: Fix wrong LMUL when only implict zve32f.

2025-02-04 Thread Monk Chiang
Hi Robin, Sorry, I should have simplified the problem by presenting it in terms of Zve32x, because Zve32f implies Zve32x. As the specification states, the requirement is to support LMUL ≥ SEW/ELEN. Regarding the implementation, I followed this rule to fix the problem. In this link: https://godbolt

[committed] fortran/trans-openmp.cc: Use the correct member in gfc_omp_namelist [PR118745]

2025-02-04 Thread Tobias Burnus
Found using UBSAN - and thanks to Martin for running it with UBSAN and reporting it! append_args and adjust_args can be easily confused being spelled rather similarly and being used in the same code. Still, it makes sense to use the right list... (It seems as if the pointer dereferencing actuall

Re: [PATCH] cselib: For CALL_INSNs to const/pure fns invalidate memory below sp [PR117239]

2025-02-04 Thread Richard Biener
On Tue, 4 Feb 2025, Jakub Jelinek wrote: > Hi! > > The following testcase is miscompiled on x86_64 during postreload. > After reload (with IPA-RA figuring out the calls don't modify any > registers but %rax for return value) postreload sees > (insn 14 12 15 2 (set (mem:DI (plus:DI (reg/f:DI 7 sp)

Re: [PATCH] libstdc++: Fix gnu.ver CXXABI_1.3.16 for Solaris [PR118701]

2025-02-04 Thread Andreas Schwab
On Feb 04 2025, Jonathan Wakely wrote: > I think this will cause check-abi failures on risc-v because the new > symbols are added to CXXABI_1.3.16 but the "latest_p" map says that > new symbols (i.e. ones not present in the baseline_symbols.txt file) > should be in CXXABI_1.3.15 There is effectiv

Re: [PATCH v1 06/16] Change function versions to be implicitly ordered.

2025-02-04 Thread Alfie Richards
On 04/02/2025 15:11, Richard Sandiford wrote: Richard Sandiford writes: Alfie Richards writes: --- gcc/cgraph.cc| 39 +++--- gcc/config/aarch64/aarch64.cc| 37 +++- gcc/config/i386/i386-features.cc | 33 --

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Jason Merrill
On 1/15/25 9:56 AM, Jason Merrill wrote: On 1/15/25 7:24 AM, Simon Martin wrote: Hi, On 14 Jan 2025, at 23:31, Jason Merrill wrote: On 1/14/25 2:13 PM, Simon Martin wrote: On 10 Jan 2025, at 19:10, Andrew Pinski wrote: On Fri, Jan 10, 2025 at 3:18 AM Simon Martin wrote: We currently acce

Re: [PATCH] arm: testsuite: Adapt mve-vabs.c to improved codegen

2025-02-04 Thread Thiago Jung Bauermann
Christophe Lyon writes: > On Sun, 2 Feb 2025 at 21:18, Thiago Jung Bauermann > wrote: >> >> Since commit r15-491-gc290e6a0b7a9de this failure happens on on >> armv8l-linux-gnueabihf and arm-eabi: >> >> Running gcc:gcc.target/arm/simd/simd.exp ... >> gcc.target/arm/simd/mve-vabs.c: memmove foun

Re: [PATCH 1/4] vect: Set counts of early break exit blocks correctly [PR117790]

2025-02-04 Thread Jan Hubicka
> This adds missing code to correctly set the counts of the exit blocks we > create when building the CFG for a vectorized early break loop. > > Tested as a series on aarch64-linux-gnu, arm-linux-gnueabihf, and > x86_64-linux-gnu. OK for trunk? > > Thanks, > Alex > > gcc/ChangeLog: > > P

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Jason Merrill
On 2/4/25 10:56 AM, Simon Martin wrote: Hi Jason, On 4 Feb 2025, at 16:39, Jason Merrill wrote: On 1/15/25 9:56 AM, Jason Merrill wrote: On 1/15/25 7:24 AM, Simon Martin wrote: Hi, On 14 Jan 2025, at 23:31, Jason Merrill wrote: On 1/14/25 2:13 PM, Simon Martin wrote: On 10 Jan 2025, at 1

[PATCH v3] c++: Reject default arguments for template class friend functions [PR118319]

2025-02-04 Thread Simon Martin
Hi Jason, On 4 Feb 2025, at 1:11, Jason Merrill wrote: > On 1/31/25 11:12 AM, Simon Martin wrote: >> Hi Jason, >> >> On 31 Jan 2025, at 16:29, Jason Merrill wrote: >> >>> On 1/31/25 9:52 AM, Simon Martin wrote: Hi Jason, On 9 Jan 2025, at 22:55, Jason Merrill wrote: > On 1

[COMITTED] Fix file cache tunables documentation

2025-02-04 Thread Andi Kleen
From: Andi Kleen Document new params in invoke.texi. The auto tuning description was on the wrong tunable, move to lines. Comitted as obvious. gcc/ChangeLog: * doc/invoke.texi: Document file cache tunables. * params.opt: Move auto tuning description to lines. --- gcc/doc/invo

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Simon Martin
On 4 Feb 2025, at 17:17, Jason Merrill wrote: > On 2/4/25 10:56 AM, Simon Martin wrote: >> Hi Jason, >> >> On 4 Feb 2025, at 16:39, Jason Merrill wrote: >> >>> On 1/15/25 9:56 AM, Jason Merrill wrote: On 1/15/25 7:24 AM, Simon Martin wrote: > Hi, > > On 14 Jan 2025, at 23:31, Jaso

Re: [PATCH] optabs: Fix widening optabs for vec-mode -> scalar-mode [PR116926]

2025-02-04 Thread Richard Biener
On Tue, Feb 4, 2025 at 8:42 AM Andrew Pinski wrote: > > r15-4317-ga6f4404689f12 tried to add support for widending optabs > for vec-mode -> scalar-mode but it misunderstood how FOR_EACH_MODE worked, > the limit in this case is not inclusive. Which means setting limit to from, > would cause the loo

Re: [PATCH] libstdc++: Fix gnu.ver CXXABI_1.3.16 for Solaris [PR118701]

2025-02-04 Thread Jonathan Wakely
On Tue, 4 Feb 2025 at 12:48, Rainer Orth wrote: > > This patch > > commit c6977f765838a5ca8d321d916221a7368622bdd9 > Author: Andreas Schwab > Date: Tue Jan 21 23:50:15 2025 +0100 > > libstdc++: correct symbol version of typeinfo for bfloat16_t on RISC-V > > broke the libstdc++-abi/abi_check

Re: [PATCH v2 1/7] Add tunables for input buffer

2025-02-04 Thread Martin Jambor
Hello Andi, On Sat, Jan 25 2025, Andi Kleen wrote: > From: Andi Kleen > > The input machinery to read the source code independent of the lexer > has a range of hard coded maximum array sizes that can impact performance. > Make them tunable. > > input.cc is part of libcommon so it cannot direct ac

Re: [PATCH] testsuite: Exclude test in pr109393.c from ilp32 targets [PR116845]

2025-02-04 Thread Philipp Tomsich
Applied to master with the requested change (to XFAIL for ilp32). Thanks, Philipp. On Tue, 4 Feb 2025 at 12:45, Richard Biener wrote: > On Tue, Feb 4, 2025 at 12:36 PM Konstantinos Eleftheriou > wrote: > > > > From: kelefth > > > > The match.pd canonicalization that this testcase checks for,

Re: [PATCH] testsuite: Exclude test in pr109393.c from ilp32 targets [PR116845]

2025-02-04 Thread Richard Biener
On Tue, Feb 4, 2025 at 12:36 PM Konstantinos Eleftheriou wrote: > > From: kelefth > > The match.pd canonicalization that this testcase checks for, > is not applied on ilp32 targets. > > This prevents the test from running on ilp32 targets. > > PR116845 > > gcc/testsuite/ChangeLog: > >

Re: [PATCH v1 15/16] Support mixing of target_clones and target_version for aarch64.

2025-02-04 Thread Richard Sandiford
Alfie Richards writes: > This patch adds support for the combination of target_clones and > target_version in the definition of a versioned function. > > This patch changes is_function_default_version to consider a function > declaration annotated with target_clones containing default to be a > de

Re: [PATCH] cselib: For CALL_INSNs to const/pure fns invalidate memory below sp [PR117239]

2025-02-04 Thread Jakub Jelinek
On Tue, Feb 04, 2025 at 11:53:21AM +0100, Richard Biener wrote: > > + if (sp_derived_base) > > + if (cselib_val *v3 > > + = cselib_lookup_1 (stack_pointer_rtx, Pmode, 0, VOIDmode)) > > + { > > + bool ok = false; > > + HOST_WIDE

Re: [PATCH v2] RISC-V: Fix wrong LMUL when only implict zve32f.

2025-02-04 Thread Robin Dapp
Hi Monk, could you detail the issue/patch a bit? Are we generally violating LMUL >= SEW/ELEN with zve32f (zve32x as well then)? And what's "implicit zve32f"? In the test case it's specified explicitly. > According to Section 3.4.2, Vector Register Grouping, in the RISC-V > Vector Specification

[PATCH] c/118742 - gimple FE parsing of unary operators of C promoted args

2025-02-04 Thread Richard Biener
The GIMPLE FE currently invokes parser_build_unary_op to build unary GENERIC which has the operand subject to C promotion rules which does not match GIMPLE. The following adds a wrapper around the build_unary_op worker which conveniently has an argument to indicate whether to skip such promotion.

Re: [PATCH v1 09/16] Add assembler_name to cgraph_function_version_info.

2025-02-04 Thread Richard Sandiford
Alfie Richards writes: > This adds the assembler_name member to cgraph_function_version_info > to store the base assembler name for the function to be mangled. This is > used in later patches for refactoring FMV mangling. > > gcc/c/ChangeLog: > > * c-decl.cc (start_decl): Record assembler_na

Re: The COBOL front end, in 8 notes + toplevel patch

2025-02-04 Thread James K. Lowden
On Mon, 16 Dec 2024 10:24:23 +0100 Matthias Klose wrote: > On 14.12.24 15:38, Matthias Klose wrote: > > I tried to use the patches to build binary packages for Debian. > > Found some issues: > > tried to build libgcobol on more architectures, please find the > attached patch to disable building

Re: [PATCH] cselib: For CALL_INSNs to const/pure fns invalidate memory below sp [PR117239]

2025-02-04 Thread Richard Biener
On Tue, 4 Feb 2025, Jakub Jelinek wrote: > On Tue, Feb 04, 2025 at 11:53:21AM +0100, Richard Biener wrote: > > > + if (sp_derived_base) > > > + if (cselib_val *v3 > > > + = cselib_lookup_1 (stack_pointer_rtx, Pmode, 0, VOIDmode)) > > > + { > > > + bo

Re: [PATCH v2] ira: Add a target hook for callee-saved register cost scale

2025-02-04 Thread Jan Hubicka
> Hello, > > On Mon, 3 Feb 2025, H.J. Lu wrote: > > > Author: Surya Kumari Jangala > > Date: Tue Jun 25 08:37:49 2024 -0500 > > > > ira: Scale save/restore costs of callee save registers with block > > frequency > > > > scales the cost of saving/restoring a callee-save hard register in

[PATCH] tree-optimization/117113 - ICE with unroll-and-jam

2025-02-04 Thread Richard Biener
When there's an inner loop without virtual header PHI but the outer loop has one the fusion process cannot handle the need to create an inner loop virtual header PHI. Punt in this case. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/117113 * gim

Re: [PATCH v1 03/16] Add string_slice class.

2025-02-04 Thread Richard Sandiford
Alfie Richards writes: > The string_slice inherits from array_slice and is used to refer to a > substring of an array that is memory managed elsewhere without modifying > the underlying array. > > For example, this is useful in cases such as when needing to refer to a > substring of an attribute i

[PATCH] cselib: For CALL_INSNs to const/pure fns invalidate memory below sp [PR117239]

2025-02-04 Thread Jakub Jelinek
Hi! The following testcase is miscompiled on x86_64 during postreload. After reload (with IPA-RA figuring out the calls don't modify any registers but %rax for return value) postreload sees (insn 14 12 15 2 (set (mem:DI (plus:DI (reg/f:DI 7 sp) (const_int 16 [0x10])) [0 S8 A64])

RE: [PATCH]middle-end: delay checking for alignment to load [PR118464]

2025-02-04 Thread Richard Biener
On Tue, 4 Feb 2025, Tamar Christina wrote: > Looks like a last minute change I made accidentally blocked SVE. Fixed and > re-sending: > > Hi All, > > This fixes two PRs on Early break vectorization by delaying the safety checks > to > vectorizable_load when the VF, VMAT and vectype are all kno

Re: [PATCH] RTEMS: Add Cortex-M33 multilib

2025-02-04 Thread Richard Earnshaw (lists)
On 04/02/2025 03:20, Sebastian Huber wrote: > - Am 4. Feb 2025 um 4:15 schrieb Sebastian Huber > sebastian.hu...@embedded-brains.de: > >> Enable use of Armv8-M instruction set. >> >> Account for CVE-2021-35465 mitigation [PR102035]. The >> -mfix-cmse-cve-2021-35465 enabled by default, if -mc

[PATCH] libstdc++: Fix gnu.ver CXXABI_1.3.16 for Solaris [PR118701]

2025-02-04 Thread Rainer Orth
This patch commit c6977f765838a5ca8d321d916221a7368622bdd9 Author: Andreas Schwab Date: Tue Jan 21 23:50:15 2025 +0100 libstdc++: correct symbol version of typeinfo for bfloat16_t on RISC-V broke the libstdc++-abi/abi_check test on Solaris: the log shows 1 incompatible symbols 0 Argument

[Ada] Fix PR ada/118731

2025-02-04 Thread Eric Botcazou
It's just a missing test for the presence of a nonempty parameter. Tested on x86-64/Linux, applied on the mainline. 2025-02-04 Eric Botcazou PR ada/118731 * sem_aggr.adb (Resolve_Iterated_Association): Add missing guard. -- Eric Botcazoudiff --git a/gcc/ada/sem_aggr.adb b/g

Re: [PING, PATCH] fortran: fix -MT/-MQ adding additional target [PR47485]

2025-02-04 Thread Jerry D
On 2/4/25 9:29 AM, Jerry D wrote: On 2/3/25 4:46 PM, Vincent Vanlaer wrote: On 4/02/2025 01:42, Jerry D wrote: On 2/3/25 2:14 PM, Vincent Vanlaer wrote: Hi all, Gentle ping for the patch below: https://gcc.gnu.org/pipermail/ fortran/2024-December/061467.html Best wishes, Vincent On 30/

Re: [PATCH] COBOL 8/8 bld: "meta" files, such a gcc/cobol/Make-lang.in

2025-02-04 Thread Joseph Myers
On Tue, 4 Feb 2025, James K. Lowden wrote: > It's not clear to me there should be an install target for PDF because > there's no pdfdir variable defined (akin to htmldir). pdfdir is passed down from the top-level Makefile. > I guess when this script runs, nothing has been configured and no > M

Re: [EXTERNAL][PATCH 0/61] Improve Mips target

2025-02-04 Thread Chao-ying Fu
> This patch series improves the support for the mips64r6 target in GCC, > includes the enhancements to the general bug fixes and contains other > MIPS ISA and processor enablement. > > These patches are cherry-picked from the mips_rel/11_2_0/master > and mips_rel/9_3_0/master branches from the MI

[PATCH] libstdc++: Implement LWG 4027 change to possibly-const-range [PR118083]

2025-02-04 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk and perhaps 14 (after a long while)? -- >8 -- LWG 4027 effectively makes the const range access CPOs ranges::cfoo behave more consistently across C++23 and C++20 (pre-P2278R4) and more consistently with the std::cfoo range accessors, as t

[pushed] c++: add fixed test [PR94100]

2025-02-04 Thread Marek Polacek
Tested x86_64-pc-linux-gnu, applying to trunk. -- >8 -- The recent r15-7339-g26d3424ca5d9f4 fixed this test too. PR c++/94100 gcc/testsuite/ChangeLog: * g++.dg/cpp0x/variadic188.C: New test. --- gcc/testsuite/g++.dg/cpp0x/variadic188.C | 23 +++ 1 file chang

[committed] testsuite: RISC-V: Ignore pr118170.c for E ABI

2025-02-04 Thread Dimitar Dimitrov
The -mcpu=tt-ascalon-d8 option for the test implies D extension, which is not compatible with the ILP32E and ILP64E ABIs. Pushed to trunk as obvious. gcc/testsuite/ChangeLog: * gcc.target/riscv/pr118170.c: Ignore for E ABI. Signed-off-by: Dimitar Dimitrov --- gcc/testsuite/gcc.target/

Re: [PING, PATCH] fortran: fix -MT/-MQ adding additional target [PR47485]

2025-02-04 Thread Jerry D
On 2/3/25 4:46 PM, Vincent Vanlaer wrote: On 4/02/2025 01:42, Jerry D wrote: On 2/3/25 2:14 PM, Vincent Vanlaer wrote: Hi all, Gentle ping for the patch below: https://gcc.gnu.org/pipermail/ fortran/2024-December/061467.html Best wishes, Vincent On 30/12/2024 00:19, Vincent Vanlaer wrot

[RFC][libgcc][PATCH] Fix two issues in libgcc/unwind-dw2-fde.c.

2025-02-04 Thread Qing Zhao
Hi, One of our big application segv in libgcc code while unwinding the stack. This is a random crash while the application throws a c++ exception and unwinds the stack. Incidents are random and never can be reproduced by any test case. The libgcc that is used is based on GCC 8. Fortunately, we

Re: [PATCH v3] c++: Reject default arguments for template class friend functions [PR118319]

2025-02-04 Thread Jason Merrill
On 2/4/25 11:25 AM, Simon Martin wrote: Hi Jason, On 4 Feb 2025, at 1:11, Jason Merrill wrote: On 1/31/25 11:12 AM, Simon Martin wrote: Hi Jason, On 31 Jan 2025, at 16:29, Jason Merrill wrote: On 1/31/25 9:52 AM, Simon Martin wrote: Hi Jason, On 9 Jan 2025, at 22:55, Jason Merrill wrote:

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Jason Merrill
On 2/4/25 11:45 AM, Simon Martin wrote: On 4 Feb 2025, at 17:17, Jason Merrill wrote: On 2/4/25 10:56 AM, Simon Martin wrote: Hi Jason, On 4 Feb 2025, at 16:39, Jason Merrill wrote: On 1/15/25 9:56 AM, Jason Merrill wrote: On 1/15/25 7:24 AM, Simon Martin wrote: Hi, On 14 Jan 2025, at 23

Re: [PATCH] c++: Fix ICE with #embed/RAW_DATA_CST after list conversion [PR118671]

2025-02-04 Thread Jason Merrill
On 1/27/25 6:49 PM, Jakub Jelinek wrote: Hi! The following testcases ICE with RAW_DATA_CSTs (so the first one since introduction of #embed C++ optimizations and the latter since optimization of large sequences of comma separated literals). I've missed the fact that implicit_conversion can embed

Re: [PATCH v2] c++: Reject cdtors and conversion operators with a single * as return type [PR118306]

2025-02-04 Thread Jason Merrill
On 2/4/25 3:03 PM, Jason Merrill wrote: On 2/4/25 11:45 AM, Simon Martin wrote: On 4 Feb 2025, at 17:17, Jason Merrill wrote: On 2/4/25 10:56 AM, Simon Martin wrote: Hi Jason, On 4 Feb 2025, at 16:39, Jason Merrill wrote: On 1/15/25 9:56 AM, Jason Merrill wrote: On 1/15/25 7:24 AM, Simon

Re: [PATCH] OpenMP: Improve Fortran metadirective diagnostics [PR107067]

2025-02-04 Thread Tobias Burnus
Hi Sandra, hello world, Sandra Loosemore wrote: gcc/fortran/ChangeLog PR middle-end/107067 * parse.cc (parse_omp_do): Diagnose missing "OMP END METADIRECTIVE" after loop. (parse_omp_structured_block): Likewise for strictly structured block. (parse_omp_meta

[PATCH] testsuite: Exclude test in pr109393.c from ilp32 targets [PR116845]

2025-02-04 Thread Konstantinos Eleftheriou
From: kelefth The match.pd canonicalization that this testcase checks for, is not applied on ilp32 targets. This prevents the test from running on ilp32 targets. PR116845 gcc/testsuite/ChangeLog: * gcc.dg/pr109393.c: Exclude ilp32 targets. --- gcc/testsuite/gcc.dg/pr109393.c

Re: [PATCH v1 14/16] Change target_version semantics to follow ACLE specification.

2025-02-04 Thread Richard Sandiford
Alfie Richards writes: > This changes behavior of target_clones and target_version attributes > to be inline with what is specified in the Arm C Language Extension. > > Notably this changes the scope and signature of multiversioned functions > to that of the default version, and changes the resol

Patch ping: [PATCH] c++: Fix ICE with #embed/RAW_DATA_CST after list conversion [PR118671]

2025-02-04 Thread Jakub Jelinek
Hi! On Tue, Jan 28, 2025 at 12:49:54AM +0100, Jakub Jelinek wrote: > The following testcases ICE with RAW_DATA_CSTs (so the first one since > introduction of #embed C++ optimizations and the latter since optimization > of large sequences of comma separated literals). > I've missed the fact that im

Re: [PATCH v1 12/16] Refactor FMV name mangling.

2025-02-04 Thread Richard Sandiford
Alfie Richards writes: > This patch is an overhaul of how FMV name mangling works. Previously > mangling logic was duplicated in several places across both target > specific and independent code. This patch changes this such that all > mangling is done in targetm.mangle_decl_assembler_name (includ

Re: [PATCH v11] c++: Fix overeager Woverloaded-virtual with conversion operators [PR109918]

2025-02-04 Thread Simon Martin
Hi Jason, On 4 Feb 2025, at 1:10, Jason Merrill wrote: > On 1/31/25 12:11 PM, Simon Martin wrote: >> Hi Jason, >> >> On 27 Jan 2025, at 16:49, Jason Merrill wrote: >> >>> On 1/27/25 10:41 AM, Simon Martin wrote: Hi Jason, On 17 Jan 2025, at 23:33, Jason Merrill wrote: > On