Re: [PATCH] Fix PR 67102: Add libstdc++ dependancy to libffi

2021-09-17 Thread Thomas Schwinge
Hi Andrew! First, I appreciate you working through all these old PRs! On 2021-09-15T13:56:37-0700, apinski--- via Gcc-patches wrote: > The error message is obvious -funconfigured-libstdc++-v3 is used > on the g++ command line. So we just add the dependancy. > --- a/Makefile.def > +++ b/Makef

Re: [PATCH] Enable auto-vectorization at O2 with very-cheap cost model.

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, 17 Sep 2021, Hongtao Liu wrote: > On Thu, Sep 16, 2021 at 8:31 PM Richard Biener wrote: > > > > On Thu, 16 Sep 2021, Hongtao Liu wrote: > > > > > On Thu, Sep 16, 2021 at 4:23 PM Richard Biener via Gcc-patches > > > wrote: > > > > > > > > On Thu, 16 Sep 2021, liuhongt wrote: > > > > > > >

[PATCH v2] C++: add type checking for static local vector variable in template

2021-09-17 Thread wangpc via Gcc-patches
This patch moves verify_type_context from start_decl_1 to cp_finish_decl and adds type checking for static local vector variable in C++ template. 2021-08-06 wangpc gcc/cp/ChangeLog * decl.c (start_decl_1): Remove verify_type_context. (cp_finish_decl): Add more type che

Re: [PATCH] Enable auto-vectorization at O2 with very-cheap cost model.

2021-09-17 Thread Hongtao Liu via Gcc-patches
On Fri, Sep 17, 2021 at 3:47 PM Richard Biener wrote: > > On Fri, 17 Sep 2021, Hongtao Liu wrote: > > > On Thu, Sep 16, 2021 at 8:31 PM Richard Biener wrote: > > > > > > On Thu, 16 Sep 2021, Hongtao Liu wrote: > > > > > > > On Thu, Sep 16, 2021 at 4:23 PM Richard Biener via Gcc-patches > > > > w

Re: [PATCH 30/62] AVX512FP16: Add vcvtsh2si/vcvtsh2usi/vcvtsi2sh/vcvtusi2sh.

2021-09-17 Thread Hongtao Liu via Gcc-patches
I'm going to check in 10 patches. [PATCH 30/62] AVX512FP16: Add vcvtsh2si/vcvtsh2usi/vcvtsi2sh/vcvtusi2sh. [PATCH 31/62] AVX512FP16: Add testcase for vcvtsh2si/vcvtsh2usi/vcvtsi2sh/vcvtusi2sh. [PATCH 32/62] AVX512FP16: Add vcvttph2w/vcvttph2uw/vcvttph2dq/vcvttph2qq/vcvttph2udq/vcvttph2uqq [PATCH 3

Re: [PATCH] Fix PR 67102: Add libstdc++ dependancy to libffi

2021-09-17 Thread Andrew Pinski via Gcc-patches
On Fri, Sep 17, 2021 at 12:46 AM Thomas Schwinge wrote: > > Hi Andrew! > > First, I appreciate you working through all these old PRs! > > > On 2021-09-15T13:56:37-0700, apinski--- via Gcc-patches > wrote: > > The error message is obvious -funconfigured-libstdc++-v3 is used > > on the g++ command

[PATCH] C++: add type checking for static local vector variable in template

2021-09-17 Thread wangpc via Gcc-patches
Thanks for your advice, I have misunderstood what you meant. I have sent a second version patch, please review whether it is OK. On 2021/9/16 23:19, Jason Merrill wrote: On 9/16/21 05:11, wangpc via Gcc-patches wrote: This patch adds type checking for static local vector variable in C++ templa

Re: [RFC] ldist: Recognize rawmemchr loop patterns

2021-09-17 Thread Richard Biener via Gcc-patches
On Mon, Sep 13, 2021 at 4:53 PM Stefan Schulze Frielinghaus wrote: > > On Mon, Sep 06, 2021 at 11:56:21AM +0200, Richard Biener wrote: > > On Fri, Sep 3, 2021 at 10:01 AM Stefan Schulze Frielinghaus > > wrote: > > > > > > On Fri, Aug 20, 2021 at 12:35:58PM +0200, Richard Biener wrote: > > > [...]

Re: [PATCH #2] PR c/102245: Disable sign-changing optimization for shifts by zero.

2021-09-17 Thread Richard Biener via Gcc-patches
On Tue, Sep 14, 2021 at 9:44 AM Roger Sayle wrote: > > > Respecting Jakub's suggestion that it may be better to warn-on-valid for > "if (x << 0)" as the author might have intended "if (x < 0)" [which will > also warn when x is _Bool], the simplest way to resolve this regression > is to disable the

Re: [PATCH V2] Set bound/cmp/control for until wrap loop.

2021-09-17 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Jiufu Guo wrote: > > Changes on V1: > * Add more test case > * Add comment for exit-condition transform > * Removing duplicate setting on niter->control > > This patch reset niter->control, niter->bound and niter->cmp in > number_of_iterations_until_wrap. > > Bootstrap and t

Re: [PATCH 1/N] Rename asm_out_file function arguments.

2021-09-17 Thread Richard Biener via Gcc-patches
On Thu, Sep 16, 2021 at 3:52 PM Iain Sandoe wrote: > > > Hi Martin, > > > On 16 Sep 2021, at 11:00, Martin Liška wrote: > > > > As preparation for a new global object that will encapsulate > > asm_out_file, we would need to live with a macro that will > > define asm_out_file as casm->out_file and

Re: [PATCH] nvptx: Add (experimental) support for HFmode with -misa=sm_53

2021-09-17 Thread Tobias Burnus
Hi Roger, some more generic remarks not specific to using new ISA features. On 17.09.21 00:53, Roger Sayle wrote: Whilst there I also added -misa=sm_75 and -misa=sm_80 which are points where other useful instructions were added to the ISA. First, my impression was that already sm_70 added lo

Re: [PATCH, Fortran] Use _Float128 rather than __float128 for c_float128 kind

2021-09-17 Thread Tobias Burnus
On 17.09.21 06:02, Sandra Loosemore wrote: On 9/5/21 11:20 PM, Sandra Loosemore wrote: Unless the aarch64 maintainers think it is a bug that __float128 is not supported, I think the right solution here is [...] to tie the C_FLOAT128 kind to _Float128 rather than __float128, [...] Here's a new

[committed] openmp: Add support for OpenMP 5.1 atomics for C++

2021-09-17 Thread Jakub Jelinek via Gcc-patches
Hi! Besides the C++ FE changes, I've noticed that the C FE didn't reject #pragma omp atomic capture compare { v = x; x = y; } and other forms of atomic swap, this patch fixes that too. And the c-family/ routine needed quite a few changes so that the new code in it works fine with both FEs. B

Re: [PATCH] tree-optimization/65206 - dependence analysis on mixed pointer/array

2021-09-17 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > This adds the capability to analyze the dependence of mixed > pointer/array accesses. The example is from where using a masked > load/store creates the pointer-based access when an otherwise > unconditional access is array based. Other examples would include > accesses t

Re: [PATCH 1/N] Rename asm_out_file function arguments.

2021-09-17 Thread Iain Sandoe
Hi Folks, > On 17 Sep 2021, at 09:23, Richard Biener wrote: > > On Thu, Sep 16, 2021 at 3:52 PM Iain Sandoe wrote: >> >> >>> On 16 Sep 2021, at 11:00, Martin Liška wrote: >>> >>> As preparation for a new global object that will encapsulate >>> asm_out_file, we would need to live with a macr

[PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Kewen.Lin via Gcc-patches
Hi! Power ISA 2.07 (Power8) introduces transactional memory feature but ISA3.1 (Power10) removes it. It exposes one troublesome issue as PR102059 shows. Users define some function with target pragma cpu=power10 then it calls one function with attribute always_inline which inherits command line o

[PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Kewen.Lin via Gcc-patches
Hi, When changing target_info with bitfield, I happened to find this inconsistent streaming in and out. We have the streaming in: bp_pack_value (&bp, info->inlinable, 1); bp_pack_value (&bp, false, 1); bp_pack_value (&bp, info->fp_expressions, 1); while the streami

Re: [PATCH v2] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Kewen.Lin via Gcc-patches
Hi Martin, on 2021/9/16 下午9:19, Martin Jambor wrote: > Hi, > > On Thu, Sep 16 2021, Kewen.Lin wrote: >> Hi Martin, >> >> Thanks for the review comments! >> >> on 2021/9/15 下午8:51, Martin Jambor wrote: >>> Hi, >>> >>> since this is inlining-related, I would somewhat prefer Honza to have a >>> look

Re: [PATCH 1/N] Rename asm_out_file function arguments.

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 11:42 AM Iain Sandoe wrote: > > Hi Folks, > > > On 17 Sep 2021, at 09:23, Richard Biener wrote: > > > > On Thu, Sep 16, 2021 at 3:52 PM Iain Sandoe wrote: > >> > >> > >>> On 16 Sep 2021, at 11:00, Martin Liška wrote: > >>> > >>> As preparation for a new global object tha

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > > Hi, > > When changing target_info with bitfield, I happened to find this > inconsistent streaming in and out. We have the streaming in: > > bp_pack_value (&bp, info->inlinable, 1); > bp_pack_value (&bp, false, 1); >

Re: [PATCH] ipa-fnsummary: Remove inconsistent bp_pack_value

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 12:03 PM Richard Biener wrote: > > On Fri, Sep 17, 2021 at 11:43 AM Kewen.Lin wrote: > > > > Hi, > > > > When changing target_info with bitfield, I happened to find this > > inconsistent streaming in and out. We have the streaming in: > > > > bp_pack_value (&bp,

[committed] libgomp: Spelling error fix in OpenMP 5.1 conformance section

2021-09-17 Thread Jakub Jelinek via Gcc-patches
Hi! Fix spelling of OpenMP directive declare variant. 2021-09-17 Jakub Jelinek * libgomp.texi (OpenMP 5.1): Spelling fix, declare variante -> declare variant. --- libgomp/libgomp.texi.jj 2021-09-08 09:55:29.014718647 +0200 +++ libgomp/libgomp.texi2021-09-17 12:30:

[PING^2] Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-10T09:48:56+0200, I wrote: > Ping. My patches again attached, for easy reference. Ping once again. Grüße Thomas > On 2021-09-03T18:33:37+0200, I wrote: >> Hi! >> >> On 2021-09-02T21:09:54+0200, I wrote: >>> On 2021-09-02T15:59:14+0200, I wrote: On 2016-08-05T14:16:58-040

[PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-10T10:00:25+0200, I wrote: > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > wrote: >> On 8/30/21 4:46 AM, Thomas Schwinge wrote: >>> Ping -- we still need to plug the memory leak; see patch attached, and/or >>> long discussion here: >> >> Thanks for answering my quest

Re: [committed] libstdc++: Add missing 'constexpr' to std::tuple [PR102270]

2021-09-17 Thread Jonathan Wakely via Gcc-patches
On 16/09/21 23:07 +0100, Jonathan Wakely wrote: Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/102270 * include/std/tuple (_Head_base, _Tuple_impl): Add _GLIBCXX20_CONSTEXPR to allocator-extended constructors. (tuple<>::swap(tuple&)): Add _G

Re: [PATCH v2] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Martin Jambor
Hi, On Fri, Sep 17 2021, Kewen.Lin wrote: > on 2021/9/16 下午9:19, Martin Jambor wrote: >> On Thu, Sep 16 2021, Kewen.Lin wrote: >>> on 2021/9/15 下午8:51, Martin Jambor wrote: On Wed, Sep 08 2021, Kewen.Lin wrote: > [...] > diff --git a/gcc/ipa-fnsummary.h b/gcc/ipa-fnsumm

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Martin Jambor
Hi, On Fri, Sep 17 2021, Kewen.Lin wrote: > [...] > > Against v2 [2], this v3 addressed Martin's review comments: > - Replace HWI auto_vec with unsigned int for target_info > to avoid overkill (also Segher's comments), adjust some > places need to be updated for this change. > - Annota

[PATCH] configure: Update --help output for --with-multilib-list

2021-09-17 Thread Jonathan Wakely via Gcc-patches
The list of architectures that support the option is incomplete. gcc/ChangeLog: * configure.ac: Fix --with-multilib-list description. * configure: Regenerate. OK for trunk? commit 630dc3085cbd87a224129177870103e2c4fbf22a Author: Jonathan Wakely Date: Fri Sep 17 12:34:22 2021

[committed] libstdc++: Rename tests with incorrect extension

2021-09-17 Thread Jonathan Wakely via Gcc-patches
The libstdc++ testsuite only runs .cc files, so these two old tests have never been run. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * testsuite/26_numerics/valarray/dr630-3.C: Moved to... * testsuite/26_numerics/valarray/dr630-3.cc: ...here. * testsuite/27_io

[PATCH] Revert no longer needed fix for PR95539

2021-09-17 Thread Richard Biener via Gcc-patches
The workaround is no longer necessary since we maintain alignment info on the DR group leader only. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-09-17 Richard Biener * tree-vect-stmts.c (vectorizable_load): Do not frob stmt_info for SLP. --- gcc/tree-vect

[PATCH, OpenMP, Fortran] Support in_reduction for Fortran

2021-09-17 Thread Chung-Lin Tang
Hi Jakub, and Fortran folks, this patch does the required adjustments to let 'in_reduction' work for Fortran. Not just for the target directive actually, task directive is also working after this patch. There is a little bit of adjustment in omp-low.c:scan_sharing_clauses: RTL expand of the copy

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge wrote: > > Hi! > > On 2021-09-10T10:00:25+0200, I wrote: > > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > > wrote: > >> On 8/30/21 4:46 AM, Thomas Schwinge wrote: > >>> Ping -- we still need to plug the memory leak; see patch attache

Re: [PATCH 05/18] rs6000: Support for vectorizing built-in functions

2021-09-17 Thread Segher Boessenkool
On Wed, Sep 01, 2021 at 11:13:41AM -0500, Bill Schmidt wrote: > This patch just duplicates a couple of functions and adjusts them to use the > new builtin names. There's no logical change otherwise. > +/* Returns a function decl for a vectorized version of the builtin function > + with builtin

Re: [PATCH] tree-optimization/65206 - dependence analysis on mixed pointer/array

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, 17 Sep 2021, Richard Sandiford wrote: > Richard Biener writes: > > This adds the capability to analyze the dependence of mixed > > pointer/array accesses. The example is from where using a masked > > load/store creates the pointer-based access when an otherwise > > unconditional access i

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Jonathan Wakely via Gcc-patches
On Fri, 17 Sept 2021 at 13:08, Richard Biener wrote: > > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge > wrote: > > > > Hi! > > > > On 2021-09-10T10:00:25+0200, I wrote: > > > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > > > wrote: > > >> On 8/30/21 4:46 AM, Thomas Schwinge wr

[Patch] Fortran: Fix -Wno-missing-include-dirs handling [PR55534]

2021-09-17 Thread Tobias Burnus
Short version: * -Wno-missing-include-dirs had no effect as the warning was always on * For CPP-only options like -idirafter, no warning was shown. This patch tries to address both, i.e. cpp's include-dir diagnostics are shown as well – and silencing the diagnostic works as well. OK for mainlin

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely wrote: > > On Fri, 17 Sept 2021 at 13:08, Richard Biener > wrote: > > > > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge > > wrote: > > > > > > Hi! > > > > > > On 2021-09-10T10:00:25+0200, I wrote: > > > > On 2021-09-01T19:31:19-0600, Martin Sebo

Re: [PATCH v2] C++: add type checking for static local vector variable in template

2021-09-17 Thread Jason Merrill via Gcc-patches
On 9/17/21 03:58, wangpc wrote: This patch moves verify_type_context from start_decl_1 to cp_finish_decl and adds type checking for static local vector variable in C++ template. How have you tested this patch? https://gcc.gnu.org/contribute.html#testing 2021-08-06 wangpc gcc/cp/ChangeLog

Re: [PATCH] tree-optimization/65206 - dependence analysis on mixed pointer/array

2021-09-17 Thread Richard Biener via Gcc-patches
On Fri, 17 Sep 2021, Richard Biener wrote: > On Fri, 17 Sep 2021, Richard Sandiford wrote: > > > Richard Biener writes: > > > This adds the capability to analyze the dependence of mixed > > > pointer/array accesses. The example is from where using a masked > > > load/store creates the pointer-b

[committed] Fortran: Prefer GCC internal macros to float.h in ISO_Fortran_binding.h (was: [PATCH, Fortran] Revert to non-multilib-specific ISO_Fortran_binding.h)

2021-09-17 Thread Tobias Burnus
On 17.09.21 08:03, Gerald Pfeifer wrote: On Tue, 14 Sep 2021, Gerald Pfeifer wrote: And, related, does the following make sense and fixes the issue? --- a/libgfortran/ISO_Fortran_binding.h +++ b/libgfortran/ISO_Fortran_binding.h @@ -228,5 +228,5 @@ extern int CFI_setpointer (CFI_cdesc_t *, CFI

Re: [PATCH v3] ipa-inline: Add target info into fn summary [PR102059]

2021-09-17 Thread Segher Boessenkool
On Fri, Sep 17, 2021 at 05:42:38PM +0800, Kewen.Lin wrote: > Against v2 [2], this v3 addressed Martin's review comments: > - Replace HWI auto_vec with unsigned int for target_info > to avoid overkill (also Segher's comments), adjust some > places need to be updated for this change. I'd h

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi Julian! Three quick questions here: On 2020-06-29T13:16:52-0700, Julian Brown wrote: > This patch implements an algorithm to lay out local data-share (LDS) space. > It currently works for AMD GCN. [...] Thanks! > @@ -1449,8 +1634,120 @@ oacc_do_neutering (void) > + addr_range ar >

Re: [PATCH v2] C++: add type checking for static local vector variable in template

2021-09-17 Thread wangpc via Gcc-patches
I have tested this patch on AArch64 and RISCV by running testsuites, the diagnostic message seems to be right. While one thing that should be noted is that error message will be reported twice as below: static-template.cpp: In instantiation of 'void f1() [with int a = 2]': static-template.cpp

Re: [PATCH 04/18] rs6000: Handle some recent MMA builtin changes

2021-09-17 Thread Bill Schmidt via Gcc-patches
Thanks!  I'll remove the elses in the committed patch, along with a TODO comment for the additional factoring opportunity for when I get to that stage. Thanks for all the reviews! Bill On 9/16/21 6:38 PM, Segher Boessenkool wrote: Hi! On Wed, Sep 01, 2021 at 11:13:40AM -0500, Bill Schmidt wr

[PATCH] darwin: support aarch64-darwin host

2021-09-17 Thread Yuta Saito via Gcc-patches
Hi, Currently, building gcc for aarch64-darwin host fails due to missing host_hooks definition. This patch adds host_hooks definition for aarch64-darwin. aarch64-darwin is not supported as a target yet, but this allows using gcc cross-compiler on aarch64-darwin. I confirmed linking gcc-cross suc

[PATCH 0/3][vect] Enable vector unrolling of main loop

2021-09-17 Thread Andre Vieira (lists) via Gcc-patches
Hi all, This patch series enables unrolling of an unpredicated main vectorized loop based on a target hook. The epilogue loop will have (at least) half the VF of the main loop and can be predicated. Andre Vieira (3): [vect] Add main vectorized loop unrolling [vect] Consider outside costs earl

[PATCH 1/3][vect] Add main vectorized loop unrolling

2021-09-17 Thread Andre Vieira (lists) via Gcc-patches
Hi all, This patch adds the ability to define a target hook to unroll the main vectorized loop. It also introduces --param's vect-unroll and vect-unroll-reductions to control this through a command-line. I found this useful to experiment and believe can help when tuning, so I decided to leave

[PATCH 2/3][vect] Consider outside costs earlier for epilogue loops

2021-09-17 Thread Andre Vieira (lists) via Gcc-patches
Hi, This patch changes the order in which we check outside and inside costs for epilogue loops, this is to ensure that a predicated epilogue is more likely to be picked over an unpredicated one, since it saves having to enter a scalar epilogue loop. gcc/ChangeLog:     * tree-vect-loop.c

[PATCH] nvptx: Adds uses of -misa=sm_75 and -misa=sm_80

2021-09-17 Thread Roger Sayle
This patch adds upon my previous patch to prototype HFmode support on nvptx, which includes adding new target macros TARGET_SM75 and TARGET_SM80. Tobias Burnus has questioned "whether it makes sense to add those flags if no use is made of those flags". I had hoped that it might be possible to spl

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-17T15:03:18+0200, Richard Biener wrote: > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely wrote: >> On Fri, 17 Sept 2021 at 13:08, Richard Biener >> wrote: >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge >> > wrote: >> > > On 2021-09-10T10:00:25+0200, I wrote: >> > > > On

Re: [PATCH] warn for more impossible null pointer tests [PR102103]

2021-09-17 Thread Martin Sebor via Gcc-patches
On 9/8/21 2:06 PM, Jason Merrill wrote: On 9/2/21 7:53 PM, Martin Sebor wrote: @@ -4622,28 +4622,94 @@ warn_for_null_address (location_t location, tree op, tsubst_flags_t complain)     if (!warn_address     || (complain & tf_warning) == 0     || c_inhibit_evaluation_warnings != 0 - 

Re: [PATCH, OpenMP, Fortran] Support in_reduction for Fortran

2021-09-17 Thread Jakub Jelinek via Gcc-patches
On Fri, Sep 17, 2021 at 07:57:38PM +0800, Chung-Lin Tang wrote: > 2021-09-17 Chung-Lin Tang > > gcc/fortran/ChangeLog: > > * openmp.c (gfc_match_omp_clause_reduction): Add 'openmp_target' default > false parameter. Add 'always,tofrom' map for OMP_LIST_IN_REDUCTION case. > (gf

[RFC] c++: Allow parm use outside function body for constexpr members

2021-09-17 Thread Barrett Adair via Gcc-patches
The WIP attached patch attempts to enable usage of parameters' constexpr members before the function body begins (see new tests dependent-expr11.C and dependent-expr12.C). Unfortunately, I hit a "vexing" snag: gcc/testsuite/g++.dg/parse/ambig7.C breaks with this patch. After several hours of debug

Re: [PATCH v2] C++: add type checking for static local vector variable in template

2021-09-17 Thread wangpc via Gcc-patches
OK I know, it's because the redundant code will check a declaration twice. On 2021/9/17 22:30, wangpc wrote: I have tested this patch on AArch64 and RISCV by running testsuites, the diagnostic message seems to be right. While one thing that should be noted is that error message will be repo

Re: [PATCH] rs6000: Parameterize some const values for density test

2021-09-17 Thread Bill Schmidt via Gcc-patches
Hi Kewen, On 9/15/21 3:52 AM, Kewen.Lin wrote: Hi, This patch follows the discussion here[1], where Segher suggested parameterizing those exact magic constants for density heuristics, to make it easier to tweak if need. Since these heuristics are quite internal, I make these parameters as undo

Re: [PATCH] rs6000: Modify the way for extra penalized cost

2021-09-17 Thread Bill Schmidt via Gcc-patches
Hi Kewen, On 9/15/21 8:14 PM, Kewen.Lin wrote: Hi, This patch follows the discussion here[1], where Segher pointed out the existing way to guard the extra penalized cost for strided/elementwise loads with a magic bound doesn't scale. The way with nunits * stmt_cost can get one much exaggerated

Re: [PATCH] tree-optimization/65206 - dependence analysis on mixed pointer/array

2021-09-17 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > On Fri, 17 Sep 2021, Richard Biener wrote: > >> On Fri, 17 Sep 2021, Richard Sandiford wrote: >> >> > Richard Biener writes: >> > > This adds the capability to analyze the dependence of mixed >> > > pointer/array accesses. The example is from where using

[PATCH v4] c++: Fix cp_tree_equal for template value args using dependent sizeof/alignof/noexcept expressions

2021-09-17 Thread Barrett Adair via Gcc-patches
I think the patch is in good shape now, thanks for the help. canon-type*.C fail with trunk and pass with patch, dependent-name*.C are regression tests that pass with both. I removed the dg-ice from constexpr-52830.C. I didn't dig much into the churn history there, but the test code looks valid to

Re: [PATCH] tree-optimization/65206 - dependence analysis on mixed pointer/array

2021-09-17 Thread Richard Biener via Gcc-patches
On September 17, 2021 6:36:10 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener via Gcc-patches writes: >> On Fri, 17 Sep 2021, Richard Biener wrote: >> >>> On Fri, 17 Sep 2021, Richard Sandiford wrote: >>> >>> > Richard Biener writes: >>> > > This adds the capability to analyze the depen

[PATCH] testsuite: Fix gcc.target/i386/auto-init-* tests.

2021-09-17 Thread Qing Zhao via Gcc-patches
Hi, This is the patch to fix gcc.target/i386/auto-init-* tests. I have tested the change at X86_64-linux with make check-gcc RUNTESTFLAGS='--target_board=unix\{-m64,-m64/-march=skylake-avx512,-m64/-fstack-protector-all,-m64/-fstack-clash-protection,-m32/-mno-sse,-m32/-mtune=bonnell,-m32/-march=

Re: [PATCH] testsuite: Fix gcc.target/i386/auto-init-* tests.

2021-09-17 Thread Jakub Jelinek via Gcc-patches
On Fri, Sep 17, 2021 at 04:55:22PM +, Qing Zhao wrote: > This is the patch to fix gcc.target/i386/auto-init-* tests. > > I have tested the change at X86_64-linux with > > make check-gcc > RUNTESTFLAGS='--target_board=unix\{-m64,-m64/-march=skylake-avx512,-m64/-fstack-protector-all,-m64/-fsta

Re: [PATCH] c++: fix wrong fixit hints for misspelled typedef [PR77565]

2021-09-17 Thread Michel Morin via Gcc-patches
On Fri, Sep 17, 2021 at 3:23 AM Jason Merrill wrote: > > On 9/16/21 11:50, Michel Morin wrote: > > On Thu, Sep 16, 2021 at 5:44 AM Jason Merrill wrote: > >> > >> On 9/14/21 04:29, Michel Morin via Gcc-patches wrote: > >>> On Tue, Sep 14, 2021 at 7:14 AM David Malcolm wrote: > > On Tue,

Re: [PATCH] testsuite: Fix gcc.target/i386/auto-init-* tests.

2021-09-17 Thread Qing Zhao via Gcc-patches
> On Sep 17, 2021, at 11:59 AM, Jakub Jelinek wrote: > > On Fri, Sep 17, 2021 at 04:55:22PM +, Qing Zhao wrote: >> This is the patch to fix gcc.target/i386/auto-init-* tests. >> >> I have tested the change at X86_64-linux with >> >> make check-gcc >> RUNTESTFLAGS='--target_board=unix\{-m

Re: Merge from trunk to gccgo branch

2021-09-17 Thread Ian Lance Taylor via Gcc-patches
I merged trunk revision 89be17a1b231ade643f28fbe616d53377e069da8 to the gccgo branch. Ian

[PATCH] libstdc++: Implement C++20 atomic and atomic

2021-09-17 Thread Thomas Rodgers
From: Thomas Rodgers Signed-off-by: Thomas Rodgers libstdc++-v3/ChangeLog: * config/abi/pre/gnu.ver (GLIBCXX_3.4.21): Do not match new _Sp_locker constructor. (GLIBCXX_3.4.30): Export _Sp_locker::_M_wait/_M_notify and new constructor. * include/bits/share

[COMMITTED] Virtualize relation oracle and various cleanups.

2021-09-17 Thread Andrew MacLeod via Gcc-patches
This patch cleans up a number of things in the relation oracle. First it virtualizes a base relation_oracle class, and then standardizes the equivalency oracle to utilize that API, and then restructures the old relation oracle into a dominance based oracle which inherits from the equivalency o

[COMMITTED] Provide a relation oracle for paths.

2021-09-17 Thread Andrew MacLeod via Gcc-patches
This patch provides a path-oracle which complies with the relation_oracle base class and is used to track any relations that are found along a specific path. There are upcoming threader changes which utilize this oracle. As paths are walked, gimple_range_fold can be used to automatically regi

Re: [Patch] Fortran: Fix -Wno-missing-include-dirs handling [PR55534]

2021-09-17 Thread Tobias Burnus
I seemingly messed up a bit in previous patch – corrected version attached. OK? Tobias PS: Due to now enabling the missing-include-dir warning also for cpp,the following warning show up during build. This seems to be specific to libgfortran building, libgomp works and real-world code also does

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Jonathan Wakely via Gcc-patches
On Fri, 17 Sep 2021, 16:52 Thomas Schwinge, wrote: > Hi! > > On 2021-09-17T15:03:18+0200, Richard Biener > wrote: > > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely > wrote: > >> On Fri, 17 Sept 2021 at 13:08, Richard Biener > >> wrote: > >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge <

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:16:52-0700, Julian Brown wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/broadcast-many.c That one already/currently works without any code changes. > @@ -0,0 +1,79 @@ > +/* { dg-additional-options "-foffload=-mgang-local-size=64" } */ ... just w

Re: [PATCH] [og10] OpenACC: Turn off worker partitioning if num_workers==1

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:16:51-0700, Julian Brown wrote: > This patch turns off the middle-end worker-partitioning support if the > number of workers for an outlined offload function is one. In that case, > we do not need to perform the broadcasting/neutering code transformation. ACK, thanks. > --

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:16:52-0700, Julian Brown wrote: > This patch implements an algorithm to lay out local data-share (LDS) space. > It currently works for AMD GCN. [...] Thanks. (... but I have not verified the algorithmic/behavioral changes in detail.) I've merged in PR96334 "openacc: Uns

Re: [PATCH] [og10] OpenACC: Remove unnecessary barriers (gimple worker partitioning/broadcast)

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:17:30-0700, Julian Brown wrote: > This is an optimisation for middle-end worker-partitioning support (used > to support multiple workers on AMD GCN). At present, [...] Thanks. (... but I have not verified the algorithmic/behavioral changes.) I've removed (trivial) now-unt

[committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]

2021-09-17 Thread Jonathan Wakely via Gcc-patches
Also rename the test so it actually runs. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/102270 * include/std/tuple (_Tuple_impl): Add constexpr to constructor missed in previous patch. * testsuite/20_util/tuple/cons/102270.C: Moved to...

[committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]

2021-09-17 Thread Jonathan Wakely via Gcc-patches
On 17/09/21 12:25 +0100, Jonathan Wakely wrote: On 16/09/21 23:07 +0100, Jonathan Wakely wrote: Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/102270 * include/std/tuple (_Head_base, _Tuple_impl): Add _GLIBCXX20_CONSTEXPR to allocator-extended cons

[committed] libstdc++: Add 'noexcept' to path::iterator members

2021-09-17 Thread Jonathan Wakely via Gcc-patches
All path::iterator operations are non-throwing. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * include/bits/fs_path.h (path::iterator): Add noexcept to all member functions and friend functions. (distance): Add noexcept. (advance): Add noexcept and inli

[HELP Needed!][PATCH] testsuite: Fix gcc.target/aarch64/auto-init-* tests.

2021-09-17 Thread Qing Zhao via Gcc-patches
Hi, There are much less issues with aarch64/auto-init-* test cases. Different -march values (from ‘armv8-a’, ‘armv8.1-a’, till ‘armv8.6-a’, ‘armv8-r’) do not change the pattern match. Only 1. -mabi=ilp32/lp64 impact two of the testing cases “auto-init-2.c” and “auto-init-padding-5.c”. 2. -fst

Re: [committed] libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]

2021-09-17 Thread Jonathan Wakely via Gcc-patches
On 17/09/21 20:47 +0100, Jonathan Wakely wrote: On 17/09/21 12:25 +0100, Jonathan Wakely wrote: On 16/09/21 23:07 +0100, Jonathan Wakely wrote: Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/102270 * include/std/tuple (_Head_base, _Tuple_impl): Add

[PATCH, committed] PR fortran/102366] [10/11/12 Regression] large arrays no longer become static

2021-09-17 Thread Harald Anlauf via Gcc-patches
The attempt to fix a misleading warning lead to a regression that prevented putting large variables in the main into static storage. So instead of preventing the move, we now disable the useless warning for variables in the main. Regtested on x86_64-pc-linux-gnu. The patch was ok'ed in the PR by

[r12-3630 Regression] FAIL: gcc.target/i386/auto-init-3.c scan-assembler-times fldz 3 on Linux/x86_64

2021-09-17 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 896fec24c8ef59b3520f5ded69dcd5bcf643c1f9 is the first bad commit commit 896fec24c8ef59b3520f5ded69dcd5bcf643c1f9 Author: qing zhao Date: Fri Sep 17 10:33:47 2021 -0700 testsuite: Fix gcc.target/i386/auto-init-* tests. caused FAIL: gcc.target/i386/auto-init-3.c scan-assem

[Patch] Fortran/OpenMP: unconstrained/reproducible ordered modifier

2021-09-17 Thread Tobias Burnus
This patch adds Fortran support for the new OpenMP 5.1 unconstrained and reproducible modifiers to ordered(concurrent). This patch requires Jakub's patch to handle the middle-end (and C/C++) part, which still has to be committed. The testcases are based on the C/C++ ones. OK? Tobias -

Re: [PATCH] rs6000: Modify the way for extra penalized cost

2021-09-17 Thread Segher Boessenkool
Hi! On Thu, Sep 16, 2021 at 09:14:15AM +0800, Kewen.Lin wrote: > The way with nunits * stmt_cost can get one much exaggerated > penalized cost, such as: for V16QI on P8, it's 16 * 20 = 320, > that's why we need one bound. To make it scale, this patch > doesn't use nunits * stmt_cost any more, but

Re: [PATCH] introduce predicate analysis class

2021-09-17 Thread Martin Sebor via Gcc-patches
On 9/2/21 10:28 AM, Jeff Law via Gcc-patches wrote: On 8/30/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: The predicate analysis subset of the tree-ssa-uninit pass isn't necessarily specific to the detection of uninitialized reads. Suitably parameterized, the same core logic could be used

Re: [PATCH] rs6000: Parameterize some const values for density test

2021-09-17 Thread Segher Boessenkool
Hi! On Fri, Sep 17, 2021 at 11:27:09AM -0500, Bill Schmidt wrote: > On 9/15/21 3:52 AM, Kewen.Lin wrote: > >+-param=rs6000-density-pct-threshold= > >+Target Undocumented Joined UInteger Var(rs6000_density_pct_threshold) > >Init(85) IntegerRange(0, 99) Param > >+When costing for loop vectorization

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-09-17 Thread Anthony Sharp via Gcc-patches
Re-adding gcc-patches@gcc.gnu.org. -- Forwarded message - From: Anthony Sharp Date: Fri, 17 Sept 2021 at 23:11 Subject: Re: [PATCH] c++: error message for dependent template members [PR70417] To: Jason Merrill Hi Jason! Apologies for the delay. > This is basically core issue 1

Re: [PATCH] c++: error message for dependent template members [PR70417]

2021-09-17 Thread Anthony Sharp via Gcc-patches
And also re-attaching the patch! On Fri, 17 Sept 2021 at 23:17, Anthony Sharp wrote: > > Re-adding gcc-patches@gcc.gnu.org. > > -- Forwarded message - > From: Anthony Sharp > Date: Fri, 17 Sept 2021 at 23:11 > Subject: Re: [PATCH] c++: error message for dependent template members

Re: [PATCH] rs6000: Parameterize some const values for density test

2021-09-17 Thread Segher Boessenkool
Hi! On Wed, Sep 15, 2021 at 04:52:49PM +0800, Kewen.Lin wrote: > This patch follows the discussion here[1], where Segher suggested > parameterizing those exact magic constants for density heuristics, > to make it easier to tweak if need. > > Since these heuristics are quite internal, I make these

Re: [PATCH 3/4] [PATCH 3/4] x86: Properly handle USE_VECTOR_FP_CONVERTS/USE_VECTOR_CONVERTS

2021-09-17 Thread Jakub Jelinek via Gcc-patches
On Fri, Sep 17, 2021 at 08:35:57AM +0200, Uros Bizjak via Gcc-patches wrote: > > > On Wed, Sep 15, 2021 at 10:10 AM wrote: > > > > > > > > From: "H.J. Lu" > > > > > > > > Check TARGET_USE_VECTOR_FP_CONVERTS or > > > TARGET_USE_VECTOR_CONVERTS when > > > > handling avx_partial_xmm_update attribute

[PATCH 1/2] Fix PR bootstrap/102389: --with-build-config=bootstrap-lto is broken

2021-09-17 Thread apinski--- via Gcc-patches
From: Andrew Pinski So the problem here is that now the lto-plugin requires NM that works with LTO to work so we need to pass down NM just like we do for ranlib and ar. OK? Bootstrapped and tested with --with-build-config=bootstrap-lto on aarch64-linux-gnu. Note you need to use binutils 2.35 or

[PATCH 2/2] Update the section on binutils version

2021-09-17 Thread apinski--- via Gcc-patches
From: Andrew Pinski LTO usage requires binutils 2.35 or newer due to https://sourceware.org/PR25355. This adds a note in the prerequisites page about it. Ok? gcc/ChangeLog: * doc/install.texi: Add note about binutils 2.35 is required for LTO usage. --- gcc/doc/install.texi | 3

Re: [PATCH 3/4] [PATCH 3/4] x86: Properly handle USE_VECTOR_FP_CONVERTS/USE_VECTOR_CONVERTS

2021-09-17 Thread Hongtao Liu via Gcc-patches
On Sat, Sep 18, 2021 at 7:50 AM Jakub Jelinek via Gcc-patches wrote: > > On Fri, Sep 17, 2021 at 08:35:57AM +0200, Uros Bizjak via Gcc-patches wrote: > > > > On Wed, Sep 15, 2021 at 10:10 AM wrote: > > > > > > > > > > From: "H.J. Lu" > > > > > > > > > > Check TARGET_USE_VECTOR_FP_CONVERTS or > >

[pushed] c++: improve lookup of member-qualified names

2021-09-17 Thread Jason Merrill via Gcc-patches
I've been working on the resolution of CWG1835 by P1787, which among many other things clarified that a name after -> or . is looked up first in the class of the object expression even if it's dependent. This patch does not make that change; this is a smaller change extracted from that work in pro

[PATCH] [i386] Fix ICE in pass_rpad.

2021-09-17 Thread liuhongt via Gcc-patches
Besides conversion instructions, pass_rpad also handles scalar sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to handle conversion instructions, so fix it. Bootstrapped and regtest on x86_64-linux-gnu{-m32,} w/ configure --enable-checking=yes,rtl,extra, failed tests are fixed

Re: [PATCH] introduce predicate analysis class

2021-09-17 Thread Jeff Law via Gcc-patches
On 9/17/2021 4:05 PM, Martin Sebor wrote: On 9/2/21 10:28 AM, Jeff Law via Gcc-patches wrote: On 8/30/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: The predicate analysis subset of the tree-ssa-uninit pass isn't necessarily specific to the detection of uninitialized reads. Suitably para

[PATCH] libstdc++: Implement C++20 atomic and atomic

2021-09-17 Thread Thomas Rodgers
From: Thomas Rodgers Let's try this one instead. Signed-off-by: Thomas Rodgers libstdc++-v3/ChangeLog: * acinclude.m4: Update ABI version. * config/abi/pre/gnu.ver (GLIBCXX_3.4.21): Do not match new _Sp_locker constructor. (GLIBCXX_3.4.30): Export _Sp_locker::_M

Re: [committed] Fortran: Prefer GCC internal macros to float.h in ISO_Fortran_binding.h (was: [PATCH, Fortran] Revert to non-multilib-specific ISO_Fortran_binding.h)

2021-09-17 Thread Gerald Pfeifer
On Fri, 17 Sep 2021, Tobias Burnus wrote: > I have now committed the attached patch as r12-3621. It includes the > patch by Sandra > https://gcc.gnu.org/pipermail/gcc-patches/2021-September/579372.html > (approved 3 days ago) plus adding the "== 53" similar to above. Thank you, Tobias; thank you,

Re: [PATCH/RFC 1/2] WPD: Enable whole program devirtualization

2021-09-17 Thread Jason Merrill via Gcc-patches
On 9/16/21 22:29, Feng Xue OS wrote: On 9/16/21 05:25, Feng Xue OS via Gcc-patches wrote: This and following patches are composed to enable full devirtualization under whole program assumption (so also called whole-program devirtualization, WPD for short), which is an enhancement to current spec

[PATCH v2] C++: add type checking for static local vector variable in template

2021-09-17 Thread wangpc via Gcc-patches
This patch moves verify_type_context from start_decl_1 to cp_finish_decl to do more type checking such as static local vector variable in C++ template. 2021-08-06 wangpc gcc/cp/ChangeLog * decl.c (start_decl_1): Move verify_type_context to ... (cp_finish_decl): ... to

Re: [PATCH 40/62] AVX512FP16: Add vfmaddsub[132, 213, 231]ph/vfmsubadd[132, 213, 231]ph.

2021-09-17 Thread Hongtao Liu via Gcc-patches
Hi: I'm going to check the 9 patches below. Bootstrapped and regtest on x86_64-pc-linux-gnu{-m32,}. Newly added testcase passed on sde{-m32,}. [PATCH 40/62] AVX512FP16: Add vfmaddsub[132, 213, 231]ph/vfmsubadd[132, 213, 231]ph. [PATCH 41/62] AVX512FP16: Add testcase for vfmaddsub[132, 213, 2

  1   2   >