Re: [PATCH] PR tree-optimization/101403: Incorrect folding of ((T)bswap(x))>>C

2021-07-12 Thread Jakub Jelinek via Gcc-patches
On Sun, Jul 11, 2021 at 10:48:17AM +0100, Roger Sayle wrote: > /* { dg-do run } */ > /* { dg-options "-O2" } */ > unsigned int foo (unsigned int a) > { > unsigned int u; Can you please change the above line to unsigned int u = 0; or add some other initializer, or make it static unsigned int

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Richard Sandiford via Gcc-patches
Martin Jambor writes: > On Thu, Jul 08 2021, Qing Zhao wrote: >> (Resend this email since the previous one didn’t quote, I changed one >> setting in my mail client, hopefully that can fix this issue). >> >> Hi, Martin, >> >> Thank you for the review and comment. >> >>> On Jul 8, 2021, at 8:29 AM,

Re: [PATCH] New hook adjust_iv_update_pos

2021-07-12 Thread Xionghu Luo via Gcc-patches
On 2021/7/7 21:20, Richard Biener wrote: > On Tue, Jun 29, 2021 at 11:19 AM Xionghu Luo wrote: >> >> >> >> On 2021/6/28 16:25, Richard Biener wrote: >>> On Mon, Jun 28, 2021 at 10:07 AM Xionghu Luo wrote: On 2021/6/25 18:02, Richard Biener wrote: > On Fri, Jun 25, 2021

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 14:20, Richard Biener wrote: On Fri, 9 Jul 2021, Segher Boessenkool wrote: On Fri, Jul 09, 2021 at 08:43:59AM +0200, Richard Biener wrote: > I wonder if there's a way to query the target what modes the doloop > pattern can handle (not being too familiar with the doloop code). You

[PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
is included indirectly in the #pragma GCC visibility hidden block. With glibc 2.34, needs a declaration of the sysconf function, and including it under hidden visibility turns other calls to sysconf into hidden references, leading to a linker failure. libgomp/ChangeLog: * libgomp.h: In

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread Richard Biener
On Mon, 12 Jul 2021, guojiufu wrote: > On 2021-07-12 14:20, Richard Biener wrote: > > On Fri, 9 Jul 2021, Segher Boessenkool wrote: > > > >> On Fri, Jul 09, 2021 at 08:43:59AM +0200, Richard Biener wrote: > >> > I wonder if there's a way to query the target what modes the doloop > >> > pattern ca

Re: [PATCH] New hook adjust_iv_update_pos

2021-07-12 Thread Hongtao Liu via Gcc-patches
On Mon, Jul 12, 2021 at 4:14 PM Xionghu Luo via Gcc-patches wrote: > > > > On 2021/7/7 21:20, Richard Biener wrote: > > On Tue, Jun 29, 2021 at 11:19 AM Xionghu Luo wrote: > >> > >> > >> > >> On 2021/6/28 16:25, Richard Biener wrote: > >>> On Mon, Jun 28, 2021 at 10:07 AM Xionghu Luo wrote: > >>

[PATCH] offloading: fix -foffload hinting

2021-07-12 Thread Martin Liška
We should not call candidates_list_and_hint if there are no candidates. Ready after testing finishes? Thanks, Martin sanitizer/101425 gcc/ChangeLog: * gcc.c (check_offload_target_name): Call candidates_list_and_hint only if we have a candidate. --- gcc/gcc.c | 15 +++

Re: [PATCH] offloading: fix -foffload hinting

2021-07-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 12, 2021 at 11:01:39AM +0200, Martin Liška wrote: > We should not call candidates_list_and_hint if there are no candidates. > > Ready after testing finishes? > Thanks, > Martin > > sanitizer/101425 > > gcc/ChangeLog: > > * gcc.c (check_offload_target_name): Call >

RE: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Tamar Christina via Gcc-patches
Hi, > Richard Sandiford writes: > >> @@ -992,21 +1029,27 @@ vect_recog_dot_prod_pattern (vec_info > *vinfo, > >>/* FORNOW. Can continue analyzing the def-use chain when this stmt in > a phi > >> inside the loop (in case we are analyzing an outer-loop). */ > >>vect_unpromoted_value

Re: [PATCH] offloading: fix -foffload hinting

2021-07-12 Thread Martin Liška
On 7/12/21 11:17 AM, Jakub Jelinek wrote: Please move char *s; declaration into the new scope. Sure. Ok with that change. I've just pushed to master. Martin

Re: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi, > >> Richard Sandiford writes: >> >> @@ -992,21 +1029,27 @@ vect_recog_dot_prod_pattern (vec_info >> *vinfo, >> >>/* FORNOW. Can continue analyzing the def-use chain when this stmt in >> a phi >> >> inside the loop (in case we are analyzing an outer-loop).

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 16:57, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 14:20, Richard Biener wrote: > On Fri, 9 Jul 2021, Segher Boessenkool wrote: > >> On Fri, Jul 09, 2021 at 08:43:59AM +0200, Richard Biener wrote: >> > I wonder if there's a way to query the target what

Re: [PATCH] New hook adjust_iv_update_pos

2021-07-12 Thread Richard Biener via Gcc-patches
On Mon, Jul 12, 2021 at 11:00 AM Hongtao Liu wrote: > > On Mon, Jul 12, 2021 at 4:14 PM Xionghu Luo via Gcc-patches > wrote: > > > > > > > > On 2021/7/7 21:20, Richard Biener wrote: > > > On Tue, Jun 29, 2021 at 11:19 AM Xionghu Luo wrote: > > >> > > >> > > >> > > >> On 2021/6/28 16:25, Richard

Re: [ARM] PR66791: Replace builtins for signed vmul_n intrinsics

2021-07-12 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 5 Jul 2021 at 14:47, Prathamesh Kulkarni wrote: > > Hi, > This patch replaces builtins with __a * __b for signed variants of > vmul_n intrinsics. > As discussed earlier, the patch has issue if __a * __b overflows, and > whether we wish to leave > that as UB. ping https://gcc.gnu.org/git/g

Re: [ARM] PR66791: Replace builtins for signed vmul_n intrinsics

2021-07-12 Thread Prathamesh Kulkarni via Gcc-patches
On Mon, 12 Jul 2021 at 15:23, Prathamesh Kulkarni wrote: > > On Mon, 5 Jul 2021 at 14:47, Prathamesh Kulkarni > wrote: > > > > Hi, > > This patch replaces builtins with __a * __b for signed variants of > > vmul_n intrinsics. > > As discussed earlier, the patch has issue if __a * __b overflows, an

RE: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Sandiford > Sent: Monday, July 12, 2021 10:39 AM > To: Tamar Christina > Cc: Richard Biener ; nd ; gcc- > patc...@gcc.gnu.org > Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product > where the sign for the multiplicant changes. > >

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread Richard Biener
On Mon, 12 Jul 2021, guojiufu wrote: > On 2021-07-12 16:57, Richard Biener wrote: > > On Mon, 12 Jul 2021, guojiufu wrote: > > > >> On 2021-07-12 14:20, Richard Biener wrote: > >> > On Fri, 9 Jul 2021, Segher Boessenkool wrote: > >> > > >> >> On Fri, Jul 09, 2021 at 08:43:59AM +0200, Richard Bien

[PATCH] mklog: support '-b c/101343' format.

2021-07-12 Thread Martin Liška
Hello. I don't use --fill-up-bug-titles, but I would like using ./contrib/mklog.py -b c/101343 producing: PR c/101343 ... I'm going to install the patch if there are not comments. Martin contrib/ChangeLog: * mklog.py: Support additional PRs without PR prefix. --- contrib/

[PATCH] middle-end/101423 - internal calls do not trap

2021-07-12 Thread Richard Biener
This adjusts gimple_could_trap_p to not consider internal function calls to trap compared to indirect calls or calls to weak functions. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-07-12 Richard Biener PR middle-end/101423 * gimple.c (gimple_could_trap_p_1

[PATCH] tree-optimization/101394 - fix PRE full redundancy wrt abnormals

2021-07-12 Thread Richard Biener
This avoids adding a copy from an abnormal picked up from PHI translation much like we'd avoid inserting the translated expression on pred edges. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2021-07-12 Richard Biener PR tree-optimization/101394 * tree-ssa-pre.c

[PATCH] tree-optimization/101373 - avoid PRE across externally throwing call

2021-07-12 Thread Richard Biener
PRE already tries to avoid hoisting possibly trapping expressions across calls that might not return normally but fails to consider const calls that throw externally. The following fixes that and also plugs the hole of trapping references not pruned in case they are not catched by the actuall call

[PATCH] Display the number of components BB vectorized

2021-07-12 Thread Richard Biener
This amends the optimization message printed when a basic-block part is vectorized to mention the number of SLP graph entries. This helps when debugging vectorization differences and we end up merging SLP instances for costing purposes. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

Re: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Monday, July 12, 2021 10:39 AM >> To: Tamar Christina >> Cc: Richard Biener ; nd ; gcc- >> patc...@gcc.gnu.org >> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product >> where the sign for t

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-12 Thread Richard Biener via Gcc-patches
On Wed, Jul 7, 2021 at 4:37 PM Martin Sebor wrote: > > On 7/7/21 1:28 AM, Richard Biener wrote: > > On Tue, Jul 6, 2021 at 5:06 PM Martin Sebor wrote: > >> > >> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html > >> > >> Any questions/suggestions on the final patch or is it ok

Re: [RFC, PATCH] Allow means for targets to out out of CTF/BTF support

2021-07-12 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 12:23 AM Indu Bhagat via Gcc-patches wrote: > > Hello, > > It was brought up when discussing PR debug/101283 (Several tests fail on > Darwin with -gctf/gbtf) that it will be good to provide means for targets to > opt out of CTF/BTF support. > > By and large, it seems to me t

Re: [PATCH] [PHIOPT/MATCH] Remove the statement to move if not used

2021-07-12 Thread Richard Biener via Gcc-patches
On Fri, Jul 9, 2021 at 10:05 PM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > Instead of waiting for DCE to remove the unused statement, > and maybe optimize another conditional, it is better if > we don't move the statement and have the statement > removed. > > OK? Bootstrapped a

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Richard Biener via Gcc-patches
On Sat, Jul 10, 2021 at 9:26 AM Roger Sayle wrote: > > > Hi Richard and Eric, > Of course, you're both completely right. Rather than argue that > -fnon-call-exceptions without -fexceptions (and without > -fdelete-dead-exceptions) has some implicit undocumented semantics, > trapping instructions s

Re: [PATCH] move the (a-b) CMP 0 ? (a-b) : (b-a) optimization from fold_cond_expr_with_comparison to match

2021-07-12 Thread Richard Biener via Gcc-patches
On Sun, Jul 11, 2021 at 4:12 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > This patch moves the (a-b) CMP 0 ? (a-b) : (b-a) optimization > from fold_cond_expr_with_comparison to match. So I searched and I guess these transforms are produced from /* If we have A op 0 ? A : -

Re: [PATCH v3 1/2] Add -f[no-]direct-extern-access

2021-07-12 Thread H.J. Lu via Gcc-patches
On Sun, Jul 11, 2021 at 11:13 PM Richard Biener wrote: > > On Fri, Jul 9, 2021 at 4:50 PM H.J. Lu wrote: > > > > -fdirect-extern-access is the default. With -fno-direct-extern-access: > > > > 1. Always use GOT to access undefined data and function symbols, > >including in PIE and non-PIE. T

PING^1 [PATCH v5 00/11] Allow TImode/OImode/XImode in op_by_pieces operations

2021-07-12 Thread H.J. Lu via Gcc-patches
On Thu, Jul 1, 2021 at 8:22 AM H.J. Lu wrote: > > Changes in the v5 patches: > > 1. Add TARGET_GEN_MEMSET_SCRATCH_RTX to allow the backend to use a hard > scratch register to avoid stack realignment when expanding memset. > 2. Use vec_duplicate, instead of adding TARGET_READ_MEMSET_VALUE and > TAR

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Eric Botcazou
> There's still the open question what -fnon-call-exceptions on its > own should do - IMHO it doesn't make sense to allow unwiding > from a trapping memory reference but not from the call it resides > in which means -fnon-call-exceptions should better enable > -fexceptions? Or issue a warning that

RE: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Sandiford > Sent: Monday, July 12, 2021 11:26 AM > To: Tamar Christina > Cc: Richard Biener ; nd ; gcc- > patc...@gcc.gnu.org > Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product > where the sign for the multiplicant changes. > > T

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Richard Biener via Gcc-patches
On Mon, Jul 12, 2021 at 2:22 PM Eric Botcazou wrote: > > > There's still the open question what -fnon-call-exceptions on its > > own should do - IMHO it doesn't make sense to allow unwiding > > from a trapping memory reference but not from the call it resides > > in which means -fnon-call-exceptio

[Ada] Duplicate Size/Value_Size clause

2021-07-12 Thread Pierre-Marie de Rodat
Give a warning if both Size and Value_Size attributes are specified for the same type. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_ch13.adb (Duplicate_Clause): Add a helper routine Check_One_Attr, with a parameter for the attribute_designator we are l

[Ada] Add DWARF 5 support to System.Dwarf_Line

2021-07-12 Thread Pierre-Marie de Rodat
The encoding of the debugging line information has substantially changed in DWARF 5, so this adds the support for it alongside the existing code. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * libgnat/s-dwalin.ads: Adjust a few comments left and right. (Line_Info_Re

[Ada] Clean up Uint fields

2021-07-12 Thread Pierre-Marie de Rodat
We add new field types Valid_Uint, Unat, Upos, Nonzero_Uint, which have predicates that assert the value is a proper Uint value (i.e. not No_Uint), and that the value is appropriate. It is not clear that Nonzero_Uint is needed, but it is useful in testing; we can always remove it later. We use the

[Ada] Implement support for unconstrained array types with FLB

2021-07-12 Thread Pierre-Marie de Rodat
The fixed lower bound also makes it possible to simplify the formula of the upper bound used for unconstrained array types. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * gcc-interface/decl.c (gnat_to_gnu_entity) : Use a fixed lower bound if the index subtype is mar

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > is included indirectly in the #pragma GCC visibility hidden > block. With glibc 2.34, needs a declaration of the sysconf > function, and including it under hidden visibility turns other calls > to sysconf into hidden references, leading to a linker failure. > > libgomp/Chang

Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
Hello. Let's make it a separate sub-thread where we can discuss motivation why do I want moving to Sphinx format. Benefits: 1) modern looking HTML output (before: [1], after: [2]): a) syntax highlighting for examples (code, shell commands, etc.) b) precise anchors, the current Texinfo anch

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 12, 2021 at 10:26:47AM +0200, Florian Weimer via Gcc-patches wrote: > is included indirectly in the #pragma GCC visibility hidden > block. With glibc 2.34, needs a declaration of the sysconf > function, and including it under hidden visibility turns other calls > to sysconf into hidd

[PATCH] produce simple DOT graphs from SLP trees

2021-07-12 Thread Richard Biener
This adds a dot_slp_tree debug function producing a simple DOT graph from a starting node down the graph. There's no fancy direct invocation of dot but the output is directed to a specified file. It re-uses vect_print_slp_tree, naming nodes as their address. Bootstrap / regtest running on x86_64

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 15:25:47 +0200 > > Let's make it a separate sub-thread where we can discuss motivation why > do I want moving to Sphinx format. Thanks for starting this discussion. > Benefits:

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Jakub Jelinek: > On Mon, Jul 12, 2021 at 10:26:47AM +0200, Florian Weimer via Gcc-patches > wrote: >> is included indirectly in the #pragma GCC visibility hidden >> block. With glibc 2.34, needs a declaration of the sysconf >> function, and including it under hidden visibility turns other ca

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 14:41, Eli Zaretskii via Gcc wrote: > > > Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > > From: Martin Liška > > Date: Mon, 12 Jul 2021 15:25:47 +0200 > > > > Let's make it a separate sub-thread where we can discuss motivation why > > do I want mo

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 14:53, Jonathan Wakely wrote: > For me, these items are enough justification to switch away from > texinfo, which produces crap HTML pages with crap anchors. You can't > find out the anchors without inspecting (and searching) the HTML > source. That's utterly stupid. And even

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 18:02, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 16:57, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 14:20, Richard Biener wrote: >> > On Fri, 9 Jul 2021, Segher Boessenkool wrote: >> > >> >> On Fri, Jul 09, 2021 at

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 14:53:44 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > For me, these items are enough justification to switch away from > texinfo, which produces crap HTML pages with crap anchors. If we

Re: [PATCH] [wwwdocs] Update description of GM2 and document branch

2021-07-12 Thread Gaius Mulley via Gcc-patches
Gerald Pfeifer writes: > I realize this predates your patch (which merely changes version numbers), > but a reference to back ends could be misunderstood. I assume GNU Modula-2 > doesn't just use the back ends (x86, aarch64,...), but also the middle-end > and tree optimizers etc.? > > What do you

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 15:05:11 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > To be clear, I give links to users frequently (several times a week, > every week, for decades) and prefer to give them a link to spe

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 4:12 PM, Eli Zaretskii wrote: From: Jonathan Wakely Date: Mon, 12 Jul 2021 14:53:44 +0100 Cc: Martin Liška , "g...@gcc.gnu.org" , gcc-patches , "Joseph S. Myers" For me, these items are enough justification to switch away from texinfo, which produces crap HTML pages

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 4:16 PM, Eli Zaretskii wrote: From: Jonathan Wakely Date: Mon, 12 Jul 2021 15:05:11 +0100 Cc: Martin Liška , "g...@gcc.gnu.org" , gcc-patches , "Joseph S. Myers" To be clear, I give links to users frequently (several times a week, every week, for decades) and prefer

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > I tested this on csky-linux-gnuabiv2 with the glibc version that failed > before, and it works. So I guess your version is fine, too. Build on powerpc64-linux-gnu and other targets now fails with: /home/bmg/src/gcc/libgomp/config/linux/affinity.c: In function ‘gomp_init_affi

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Martin Liška
On 7/12/21 3:39 PM, Eli Zaretskii wrote: Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com From: Martin Liška Date: Mon, 12 Jul 2021 15:25:47 +0200 Let's make it a separate sub-thread where we can discuss motivation why do I want moving to Sphinx format. Thanks for starti

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread Richard Biener
On Mon, 12 Jul 2021, guojiufu wrote: > On 2021-07-12 18:02, Richard Biener wrote: > > On Mon, 12 Jul 2021, guojiufu wrote: > > > >> On 2021-07-12 16:57, Richard Biener wrote: > >> > On Mon, 12 Jul 2021, guojiufu wrote: > >> > > >> >> On 2021-07-12 14:20, Richard Biener wrote: > >> >> > On Fri, 9

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > > From: Jonathan Wakely > > Date: Mon, 12 Jul 2021 14:53:44 +0100 > > Cc: Martin Liška , > > "g...@gcc.gnu.org" , gcc-patches > > , > > "Joseph S. Myers" > > > > For me, these items are enough justification to switch away from >

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:52, Jonathan Wakely wrote: > > On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > > > > From: Jonathan Wakely > > > This is a problem with texinfo too. > > > > Not for someone who already knows Texinfo. We are talking about > > switching away of it, so I'm thinking

Re: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-07-12 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Monday, July 12, 2021 11:26 AM >> To: Tamar Christina >> Cc: Richard Biener ; nd ; gcc- >> patc...@gcc.gnu.org >> Subject: Re: [PATCH 1/4]middle-end Vect: Add support for dot-product >> where the sign for t

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 15:52, Jonathan Wakely wrote: > > On Mon, 12 Jul 2021 at 15:13, Eli Zaretskii wrote: > > I get it that you dislike the HTML produced by Texinfo, but without > > some examples of such bad HTML it is impossible to know what exactly > > do you dislike and why. > > > > > You ca

Re: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34

2021-07-12 Thread Florian Weimer via Gcc-patches
* Florian Weimer: > * Florian Weimer: > >> I tested this on csky-linux-gnuabiv2 with the glibc version that failed >> before, and it works. So I guess your version is fine, too. > > Build on powerpc64-linux-gnu and other targets now fails with: > > /home/bmg/src/gcc/libgomp/config/linux/affinity.

Re: [PATCH V2] gcc: Add vec_select -> subreg RTL simplification

2021-07-12 Thread Richard Sandiford via Gcc-patches
Jonathan Wright writes: > Hi, > > Version 2 of this patch adds more code generation tests to show the > benefit of this RTL simplification as well as adding a new helper function > 'rtx_vec_series_p' to reduce code duplication. > > Patch tested as version 1 - ok for master? Sorry for the slow rep

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
> On Jul 12, 2021, at 2:51 AM, Richard Sandiford > wrote: > > Martin Jambor writes: >> On Thu, Jul 08 2021, Qing Zhao wrote: >>> (Resend this email since the previous one didn’t quote, I changed one >>> setting in my mail client, hopefully that can fix this issue). >>> >>> Hi, Martin, >>> >

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 3:03 PM, Michael Meissner wrote: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166 This patch updates the various tests in the testsuite to treat plxv and pstxv as being vector loads/stores. This shows up if you run the testsuite with a compiler configure

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 3:00 PM, Michael Meissner wrote: [PATCH] Fix vec-splati-runnable.c test. I noticed that the vec-splati-runnable.c did not have an abort after one of the tests. If the test was run with optimization, the optimizer could delete some of the tests and throw off the count. Howev

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021, guojiufu wrote: >> > >> >> On 2021-07-12 14:20, Richard Bie

[RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread Richard Sandiford via Gcc-patches
David Edelsohn writes: > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford > wrote: >> >> David Edelsohn writes: >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc >> > wrote: >> >> >> >> Hi, >> >> >> >> It was pointed out to me off-list that config/aarch64/value-unwind.h >> >> is mi

Re: [PATCH] Check type size for doloop iv on BITS_PER_WORD [PR61837]

2021-07-12 Thread guojiufu via Gcc-patches
On 2021-07-12 23:53, guojiufu via Gcc-patches wrote: On 2021-07-12 22:46, Richard Biener wrote: On Mon, 12 Jul 2021, guojiufu wrote: On 2021-07-12 18:02, Richard Biener wrote: > On Mon, 12 Jul 2021, guojiufu wrote: > >> On 2021-07-12 16:57, Richard Biener wrote: >> > On Mon, 12 Jul 2021, guoji

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Gavin Smith via Gcc-patches
On Mon, Jul 12, 2021 at 4:04 PM Jonathan Wakely via Gcc wrote: > GNU Hello has the same problem with its docs: > https://www.gnu.org/software/hello/manual/hello.html#index-_002dg > That URL is garbage because of the URL-encoded %2d character, and the > fact it links to the wrong place (the descri

Re: Repost: [PATCH] Change rs6000_const_f32_to_i32 return type.

2021-07-12 Thread Bill Schmidt via Gcc-patches
Hi Mike, On 7/7/21 2:59 PM, Michael Meissner wrote: [PATCH] Change rs6000_const_f32_to_i32 return type. The function rs6000_const_f32_to_i32 called REAL_VALUE_TO_TARGET_SINGLE with a long long type and returns it. This patch changes the type to long which is the proper type for REAL_VALUE_TO_T

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 17:01, Gavin Smith wrote: > > On Mon, Jul 12, 2021 at 4:04 PM Jonathan Wakely via Gcc > wrote: > > GNU Hello has the same problem with its docs: > > https://www.gnu.org/software/hello/manual/hello.html#index-_002dg > > That URL is garbage because of the URL-encoded %2d char

Re: [RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 11:58 AM Richard Sandiford wrote: > > David Edelsohn writes: > > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford > > wrote: > >> > >> David Edelsohn writes: > >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc > >> > wrote: > >> >> > >> >> Hi, > >> >> > >>

Re: disable -Warray-bounds in libgo (PR 101374)

2021-07-12 Thread Martin Sebor via Gcc-patches
On 7/9/21 7:26 AM, Rainer Orth wrote: Hi Martin, Yesterday's enhancement to -Warray-bounds has exposed a couple of issues in libgo where the code writes into an invalid constant address that the warning is designed to flag. On the assumption that those invalid addresses are deliberate, the att

Re: [RFA] Some libgcc headers are missing the runtime exception

2021-07-12 Thread Richard Sandiford via Gcc-patches
David Edelsohn writes: > On Mon, Jul 12, 2021 at 11:58 AM Richard Sandiford > wrote: >> >> David Edelsohn writes: >> > On Fri, Jul 9, 2021 at 1:31 PM Richard Sandiford >> > wrote: >> >> >> >> David Edelsohn writes: >> >> > On Fri, Jul 9, 2021 at 12:53 PM Richard Sandiford via Gcc >> >> > wrot

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread David Malcolm via Gcc-patches
On Mon, 2021-07-12 at 15:25 +0200, Martin Liška wrote: > Hello. > > Let's make it a separate sub-thread where we can discuss motivation > why > do I want moving to Sphinx format. > > Benefits: > 1) modern looking HTML output (before: [1], after: [2]): "modern looking" is rather subjective; I'd r

Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.

2021-07-12 Thread Segher Boessenkool
On Mon, Jul 12, 2021 at 06:19:28AM +0200, Martin Liška wrote: > PING^1 I did not notice you attached a new patch. It works a lot better if every patch series is a new thread. Segher

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Martin Jambor
Hi, On Mon, Jul 12 2021, Qing Zhao wrote: >> On Jul 12, 2021, at 2:51 AM, Richard Sandiford >> wrote: >> >> Martin Jambor writes: >>> On Thu, Jul 08 2021, Qing Zhao wrote: (Resend this email since the previous one didn’t quote, I changed one setting in my mail client, hopefully that c

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 16:34:11 +0200 > > > "Texinfo must go" is one possible conclusion from your description. > > But it isn't the only one. An alternative is "the Texinfo source of > > the GCC manu

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Michael Meissner via Gcc-patches
On Mon, Jul 12, 2021 at 10:49:26AM -0500, Bill Schmidt wrote: > Hi Mike, > > On 7/7/21 3:00 PM, Michael Meissner wrote: > >[PATCH] Fix vec-splati-runnable.c test. > > > >I noticed that the vec-splati-runnable.c did not have an abort after one > >of the tests. If the test was run with optimization

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> Cc: h...@bitrange.com, g...@gcc.gnu.org, gcc-patches@gcc.gnu.org, > jos...@codesourcery.com > From: Martin Liška > Date: Mon, 12 Jul 2021 16:37:00 +0200 > > > 4) The need to learn yet another markup language. > > While this is not a problem for simple text, it does require a > > se

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Eli Zaretskii via Gcc-patches
> From: Jonathan Wakely > Date: Mon, 12 Jul 2021 15:54:49 +0100 > Cc: Martin Liška , > "g...@gcc.gnu.org" , gcc-patches > , > "Joseph S. Myers" > > You like texinfo. We get it. Would you please drop the attitude?

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Michael Meissner via Gcc-patches
On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: > Hi Mike, > > On 7/7/21 3:04 PM, Michael Meissner wrote: > >[PATCH] PR 100167: Fix vector long long multiply/divide tests on power10. > > > >This patch updates the vector long long multiply and divide tests to > >supply the correct cod

Re: [PATCH] Port GCC documentation to Sphinx

2021-07-12 Thread Martin Sebor via Gcc-patches
On 6/29/21 4:09 AM, Martin Liška wrote: On 6/28/21 5:33 PM, Joseph Myers wrote: Are formatted manuals (HTML, PDF, man, info) corresponding to this patch version also available for review? I've just uploaded them here: https://splichal.eu/gccsphinx-final/ Martin I think listing the -Wfoo an

Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size.

2021-07-12 Thread Segher Boessenkool
On Mon, Jun 28, 2021 at 02:19:03PM +0200, Martin Liška wrote: > On 6/24/21 12:46 AM, Segher Boessenkool wrote: > >>As mentioned in the "Fallout: save/restore target options in > >>handle_optimize_attribute" > >>thread, we need to support target option restore of > >>rs6000_long_double_type_size ==

Re: Repost: [PATCH] Fix vec-splati-runnable.c test.

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:11 PM, Michael Meissner wrote: On Mon, Jul 12, 2021 at 10:49:26AM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:00 PM, Michael Meissner wrote: [PATCH] Fix vec-splati-runnable.c test. I noticed that the vec-splati-runnable.c did not have an abort after one of the tests. If the

[committed] libstdc++: Constrain std::as_writable_bytes [PR101411]

2021-07-12 Thread Jonathan Wakely via Gcc-patches
The std::as_writable_bytes function should be constrained to only accept writable spans. Currently it can be called but then gives an error in the function body. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR libstdc++/101411 * include/std/span (as_writable_bytes): Ad

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:16 PM, Michael Meissner wrote: On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:04 PM, Michael Meissner wrote: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10. This patch updates the vector long long multiply and divid

[r12-2245 Regression] FAIL: g++.dg/vect/slp-pr87105.cc -std=c++2a scan-tree-dump-times slp2 "optimized: basic block part" 1 on Linux/x86_64

2021-07-12 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, c03cae4e066066278c8435c409829a9bf851e49f is the first bad commit commit c03cae4e066066278c8435c409829a9bf851e49f Author: Richard Biener Date: Wed Jul 7 11:45:43 2021 +0200 Display the number of components BB vectorized caused FAIL: g++.dg/vect/slp-pr87105.cc -std=c++14

Re: [PATCH 10/10] vect: Reuse reduction accumulators between loops

2021-07-12 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > On Fri, Jul 9, 2021 at 3:12 PM Richard Sandiford > wrote: >> >> Thanks for the review. >> >> Richard Biener writes: >> >> @@ -588,6 +600,23 @@ public: >> >>/* Unrolling factor */ >> >>poly_uint64 vectorization_factor; >> >> >> >> + /* If this lo

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Kees Cook via Gcc-patches
On Wed, Jul 07, 2021 at 05:38:02PM +, Qing Zhao wrote: > Hi, > > This is the 4th version of the patch for the new security feature for GCC. > > I have tested it with bootstrap on both x86 and aarch64, regression testing > on both x86 and aarch64. > Also compile and run CPU2017, without any

PING [PATCH] handle sanitizer built-ins in -Wuninitialized (PR 101300)

2021-07-12 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574385.html On 7/2/21 1:21 PM, Martin Sebor wrote: To avoid a class of false negatives for sanitized code -Wuninitialized recognizes the ASAN_MARK internal function doesn't modify its argument.  But the warning code doesn't do the same fo

Re: Repost: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10

2021-07-12 Thread Bill Schmidt via Gcc-patches
On 7/12/21 12:47 PM, Bill Schmidt via Gcc-patches wrote: On 7/12/21 12:16 PM, Michael Meissner wrote: On Sun, Jul 11, 2021 at 02:55:04PM -0500, Bill Schmidt wrote: Hi Mike, On 7/7/21 3:04 PM, Michael Meissner wrote: [PATCH] PR 100167: Fix vector long long multiply/divide tests on power10.

Re: [patch][version 4]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-07-12 Thread Qing Zhao via Gcc-patches
Hi, Martin, Thanks a lot for your experiments and examples, they are really helpful. So, based on your study, I will delete the code that handle grp_to_be_debug_replaced accesses in generate_subtree_deferred_init. Let me know if you have further comments on this. Qing > On Jul 12, 2021, at 1

Re: Benefits of using Sphinx documentation format

2021-07-12 Thread Koning, Paul via Gcc-patches
> On Jul 12, 2021, at 12:36 PM, David Malcolm via Gcc-patches > wrote: > > On Mon, 2021-07-12 at 15:25 +0200, Martin Liška wrote: >> ... > > I think the output formats we need to support are: > - HTML > - PDF > - man page (hardly "modern", but still used) Also info format (for the Emacs info

Re: [PATCH] [wwwdocs] Update description of GM2 and document branch

2021-07-12 Thread Gerald Pfeifer
On Mon, 12 Jul 2021, Gaius Mulley wrote: >> Usually I'd just say "subject", which is a header in our mail systems; >> the term "subject line" isn't widely used. > feel free to overrule and use "subject". I copied the text from other > branch descriptions :-) (there are 38 uses). I guess there sho

[COMMITTED] tree-optimization/101335 - Do not register a cast as an equivalence.

2021-07-12 Thread Andrew MacLeod via Gcc-patches
Registering an equivalence between objects of the same size in a cast can cause other registered relations to be incorrect. Detailed in the PR.  This was an older attempt to solve a problem which has since been resolved by recomputation in the GORI engine. Bootstrapped on  x86_64-pc-linux-gnu

[PATCH] i386: Fix vec_set expanders [PR101424]

2021-07-12 Thread Uros Bizjak via Gcc-patches
AVX does not support 32-byte integer compares, required by ix86_expand_vector_set_var. The following patch fixes vec_set expanders by introducing new vec_setm_avx2_operand predicate for AVX vector modes. gcc/ 2021-07-12 Uroš Bizjak PR target/101424 * config/i386/predicates.md (vec_se

[PATCH v3] IBM Z: Use @PLT symbols for local functions in 64-bit mode

2021-07-12 Thread Ilya Leoshkevich via Gcc-patches
Bootstrapped and regtested on s390x-redhat-linux. Ok for master? v1: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573614.html v1 -> v2: Do not use UNSPEC_PLT in 64-bit code and rename it to UNSPEC_PLT31 (Ulrich, Andreas). Do not append @PLT only to weak symbols in non-

*Ping* [PATCH] PR fortran/101084 - [10/11/12 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1124

2021-07-12 Thread Harald Anlauf via Gcc-patches
*Ping* > Gesendet: Dienstag, 15. Juni 2021 um 21:31 Uhr > Von: "Harald Anlauf" > An: "fortran" , "gcc-patches" > Betreff: [PATCH] PR fortran/101084 - [10/11/12 Regression] ICE in > gfc_typenode_for_spec, at fortran/trans-types.c:1124 > > A recent change to the checking of legacy FORMAT tags did

Re: Repost: [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-07-12 Thread David Edelsohn via Gcc-patches
On Wed, Jul 7, 2021 at 4:03 PM Michael Meissner wrote: > > [PATCH] Deal with prefixed loads/stores in tests, PR testsuite/100166 > > This patch updates the various tests in the testsuite to treat plxv > and pstxv as being vector loads/stores. This shows up if you run the > testsuite with a compil

Re: Repost: [PATCH] Change rs6000_const_f32_to_i32 return type.

2021-07-12 Thread David Edelsohn via Gcc-patches
On Mon, Jul 12, 2021 at 12:07 PM Bill Schmidt wrote: > > Hi Mike, > > On 7/7/21 2:59 PM, Michael Meissner wrote: > > [PATCH] Change rs6000_const_f32_to_i32 return type. > > > > The function rs6000_const_f32_to_i32 called REAL_VALUE_TO_TARGET_SINGLE > > with a long long type and returns it. This p

  1   2   >