Re: [RS6000] Unsupported test options for -m32

2020-10-27 Thread Peter Bergner via Gcc-patches
On 10/26/20 7:48 PM, David Edelsohn via Gcc-patches wrote: >> -/* { dg-do compile } */ >> +/* { dg-do compile { target { *-*-aix* || { *-*-linux* && lp64 } } } } */ >> /* { dg-require-effective-target powerpc_p8vector_ok } */ >> /* { dg-options "-O2 -mdejagnu-cpu=power8 -maltivec -mcmodel=large"

[committed] libstdc++: Fix -Wsign-compare warnings in headers

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/bits/locale_conv.h (__str_codecvt_out_all): Add cast to compare operands of the same signedness. * include/bits/locale_facets_nonio.tcc (time_get::_M_extract_wday_or_month): Likewise. * include/bits/sstream.tcc (basic_string

Re: [PATCH V2] aarch64: Add vcopy(q)__lane(q)_bf16 intrinsics

2020-10-27 Thread Andrea Corallo via Gcc-patches
Richard Sandiford writes: > Andrea Corallo via Gcc-patches writes: >> diff --git >> a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_bf16_indices_1.c >> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vcopy_lane_bf16_indices_1.c >> new file mode 100644 >> index 000.

Re: [PATCH] tree-optimization/97428 - split SLP groups for loop vectorization

2020-10-27 Thread Richard Biener
On Tue, 27 Oct 2020, Richard Sandiford wrote: > Sorry for the very late comment (was out last week)? > > Richard Biener writes: > > This enables SLP store group splitting also for loop vectorization. > > For the existing testcase gcc.dg/vect/vect-complex-5.c this then > > generates much better c

[committed] libstdc++: Fix ODR violations caused by

2020-10-27 Thread Jonathan Wakely via Gcc-patches
The placeholders for std::tr1::bind are defined in an anonymous namespace, which means they have internal linkage. This will cause ODR violations when used in function templates (such as std::tr1::bind) from multiple translation units. Although probably harmless (every definition will generate iden

Re: [RS6000] Unsupported test options for -m32

2020-10-27 Thread Segher Boessenkool
On Tue, Oct 27, 2020 at 10:05:45AM +1030, Alan Modra wrote: > aix64.opt is used for all rs6000-aix targets, linux64.opt for 64-bit > and biarch powerpc linux targets. powerpc linux errors for -mcmodel > when -m32 (yes, even when biarch Segher). >From sysv4.h: #ifndef RS6000_BI_ARCH # define SUBSU

Re: [RS6000] Unsupported test options for -m32

2020-10-27 Thread Segher Boessenkool
On Mon, Oct 26, 2020 at 08:48:37PM -0400, David Edelsohn wrote: > Or we enable -mcmodel= for all powerpc targets and make it a nop for > Darwin and PPC32 Linux. That is starting to sound more and more attractive (it is also how we handle pretty much all other machine flags: just igmore it if it do

Re: [PATCH] c++: Check constraints only on candidate conversion functions

2020-10-27 Thread Jason Merrill via Gcc-patches
On 10/26/20 5:37 PM, Patrick Palka wrote: In the testcase below, we're overeagerly checking the constraints on the conversion function B::operator bool() as part of finding an implicit conversion sequence from B to const A&. This behavior seems to be nonconforming because according to [over.matc

c++: Kill nested_udts

2020-10-27 Thread Nathan Sidwell
During the implementation of modules I added myself a note to implement nested_udt handling. It wasn't obvious to me what they were for and nothing seemed to be broken in ignoring them. I figured something would eventually pop up and I'd add support. Nothing popped up. Investigating on trunk

[patch, shared coarrays, committed] Make header use more consistent

2020-10-27 Thread Thomas Koenig via Gcc-patches
I just committed https://gcc.gnu.org/g:0c261d5b5c931d9e9214d06531bdc7e9e16aeaab to hopefully fix the header issue on the native_coarray branch. If anybody wants to give this a spin, please go right ahead. I've also discussed with Nicolas on how best to proceed. The best way forward is probabl

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Uros Bizjak via Gcc-patches
On Tue, Oct 27, 2020 at 5:10 PM Qing Zhao wrote: > > Uros, > > The following is the change compared to version 4 after fix all the issues > you raised in the previous email. > > Let me know if there is any other issue. LGTM for x86 part, with a couple of small review comments inline. Thanks, Ur

Re: [PATCH] c++: Prevent warnings for value-dependent exprs [PR96742]

2020-10-27 Thread Jason Merrill via Gcc-patches
On 10/24/20 6:52 PM, Marek Polacek wrote: Here, in r11-155, I changed the call to uses_template_parms to type_dependent_expression_p_push to avoid a crash in C++98 in value_dependent_expression_p on a non-constant expression. But that prompted a host of complaints that we now warn for value-depe

Re: [PATCH] c++: Implement DR2303 [PR97453]

2020-10-27 Thread Jason Merrill via Gcc-patches
On 10/22/20 1:31 PM, kamlesh kumar wrote: Attaching the patch file. >>Instead of building a hash table, would it work to handle ambiguity by >>checking whether one of the classes is a base of the other? Fixing for cases like: struct B: A,A may not be cleaner this way. Why not? Your patch

Go patch committed: Remove unused Type::in_heap_ member variable

2020-10-27 Thread Ian Lance Taylor via Gcc-patches
This patch to the Go frontend removes the unused Type::in_heap_ member variable. This member variable was added in https://golang.org/cl/46490, but it was never used. The code uses Named_type::in_heap_ instead. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian

Go patch committed: Export notinheap annotation

2020-10-27 Thread Ian Lance Taylor via Gcc-patches
This Go frontend patch adds the notinheap annotation to the export data. This is the Go frontend version of https://golang.org/cl/259297. This is required now because that change is in the 1.15.3 release. This requires changing the go/internal/gccgoimporter package, to skip the new annotation. T

Re: *PING^4* [PATCH] doc: gcc.c: Update documentation for spec files

2020-10-27 Thread Joseph Myers
First, as a general principle I don't think it's really a good idea to have the documentation for specs duplicated in two places. It would be better to have it in exactly one place, and so avoid having two copies getting out of sync in future. I'd say that specs are an internal implementation

Re: [PATCH v2] RISC-V: Add configure option: --with-multilib-config to flexible config multi-lib settings.

2020-10-27 Thread Jim Wilson
On Mon, Oct 19, 2020 at 2:35 AM Kito Cheng wrote: > - I was consider to implmenet this into `--with-multilib-list` option, >but I am not sure who will using that with riscv*-*-elf*, so I decide to >using another option name for that. > I believe that --with-multllib-list is only useful

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Qing Zhao via Gcc-patches
> On Oct 27, 2020, at 12:34 PM, Uros Bizjak wrote: > > On Tue, Oct 27, 2020 at 5:10 PM Qing Zhao > wrote: >> >> Uros, >> >> The following is the change compared to version 4 after fix all the issues >> you raised in the previous email. >> >> Let me know if the

Re: [PATCH v2] builtins: rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-10-27 Thread Segher Boessenkool
Hi! On Sun, Oct 04, 2020 at 09:56:01PM -0400, Hans-Peter Nilsson wrote: > Please excuse a comment from the gallery: :-) Thanks! > > > + rtx tmp = gen_rtx_CONST_INT (SImode, __builtin_clz (INTVAL > > > (operands[1]))); > > This doesn't appear to be very portable, to any-cxx11-compiler > that

[Committed] Fix PR97497

2020-10-27 Thread Andreas Krebbel via Gcc-patches
This works around a limitation of gcse with handling of partially clobbered registers. With this patch our GOT pointer register r12 is not marked as partially clobbered anymore for the -m31 -mzarch -fpic combination. This is correct since all the bits in r12 we actually care about are in fact pres

Re: [PATCH] c++: Check constraints only on candidate conversion functions

2020-10-27 Thread Patrick Palka via Gcc-patches
On Tue, 27 Oct 2020, Jason Merrill wrote: > On 10/26/20 5:37 PM, Patrick Palka wrote: > > In the testcase below, we're overeagerly checking the constraints on > > the conversion function B::operator bool() as part of finding an > > implicit conversion sequence from B to const A&. > > > > This beh

libgo patch committed: Update to Go 1.15.3 release

2020-10-27 Thread Ian Lance Taylor via Gcc-patches
This patch updates libgo to the Go 1.15.3 release. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian c1ddc4818479413a967694cf6b5e322c0549890f diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 7d065954502..1f65809fc81 100644 --- a/gcc/go/gofro

[PATCH] PR libgfortran/97581 - clean up size calculation of random generator state

2020-10-27 Thread Harald Anlauf
As mentioned in the PR, gcc has a new warning about size calculations of arrays ([-Wsizeof-array-div]), which fired in libgfortran/intrinsics/random.c, and complained about the macro SZ that determines the size of the internal state of the random number generator for different integer kinds. A fix

[PATCH][driver] Don't add suffix for non-files

2020-10-27 Thread Tamar Christina via Gcc-patches
Hi All, This patch fixes an issue where on systems that are HAVE_TARGET_EXECUTABLE_SUFFIX the driver calls convert_filename in order to add the suffix to the filename. However while it excludes `-` it doesn't exclude the null device. This patches changes the check to exclude anything that is not

Re: [patch, shared coarrays, committed] Make header use more consistent

2020-10-27 Thread David Edelsohn via Gcc-patches
The current COARRAYS branch correctly bootstraps on AIX. Thanks for correcting the contents and ordering of the header files. Thanks, David On Tue, Oct 27, 2020 at 1:31 PM Thomas Koenig wrote: > > I just committed > > https://gcc.gnu.org/g:0c261d5b5c931d9e9214d06531bdc7e9e16aeaab > > to hopeful

[r11-4404 Regression] FAIL: g++.dg/pr97560.C -std=gnu++98 (test for excess errors) on Linux/x86_64

2020-10-27 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 18cb6195fda69ea8ab8b8a5290dd8c9f8d52b0e6 is the first bad commit commit 18cb6195fda69ea8ab8b8a5290dd8c9f8d52b0e6 Author: Aldy Hernandez Date: Tue Oct 27 07:29:42 2020 +0100 Add test for pr97560. caused FAIL: g++.dg/pr97560.C -std=gnu++98 (test for excess errors) with G

[r11-4427 Regression] FAIL: gfortran.dg/vect/pr83232.f90 -O scan-tree-dump-times slp1 "vectorizing stmts using SLP" 3 on Linux/x86_64

2020-10-27 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 5af1e827bbb624eb28f80d2c5e0da46185af3708 is the first bad commit commit 5af1e827bbb624eb28f80d2c5e0da46185af3708 Author: Richard Biener Date: Tue Oct 27 11:03:27 2020 +0100 Avoid uniform lane BB vectorization caused FAIL: gfortran.dg/vect/pr83232.f90 -O scan-tree-dum

c: Allow duplicate C2x standard attributes

2020-10-27 Thread Joseph Myers
N2557, accepted into C2x at the October WG14 meeting, removes the requirement that duplicates of standard attributes cannot appear within an attribute list (so allowing e.g. [[deprecated, deprecated]], where previously that was disallowed but [[deprecated]] [[deprecated]] was OK). Remove the code

Re: [PATCH 2/2] combine: Don't turn (mult (extend x) 2^n) into extract

2020-10-27 Thread Segher Boessenkool
On Tue, Oct 27, 2020 at 10:35:59AM +, Alex Coplan wrote: > On 26/10/2020 12:43, Segher Boessenkool wrote: > > I do not like handling both mult and ashift in one case like this, it > > complicates things for no good reason. Write it as two cases, and it > > should be good. > > OK, the attached

Re: [RS6000] dg-do !compile and scan-assembler

2020-10-27 Thread Segher Boessenkool
Hi! On Tue, Oct 27, 2020 at 09:26:10PM +1030, Alan Modra wrote: > These tests never checked assembly, because .s files were not > produced. One test was looking for the wrong instructions. -/* { dg-final { scan-assembler-times {\msldbi\M} 6 } } */ > -/* { dg-final { scan-assembler-times {\msrdb

Re: [RS6000] power10 scan-assembler tests

2020-10-27 Thread Segher Boessenkool
On Tue, Oct 27, 2020 at 09:48:48PM +1030, Alan Modra wrote: > On power10 these are "dg-do run" tests, so need -save-temps for the > assembler scanning. > > Regression tested powerpc64le-linux power8 and power10. OK? Yes please. Thanks! Segher > * gcc.target/powerpc/vsx-load-element-ex

Handle builtins on local modref, v2

2020-10-27 Thread Jan Hubicka
Hi, this is updated patch to handle fnspec in local modref. There are the following fortran failues: gfortran.dg/assumed_type_9.f90 -O2 execution test gfortran.dg/assumed_type_9.f90 -Os execution test gfortran.dg/class_alias.f90 -O1 execution test gfortran.dg/finalize_25.f90 -O2 e

Avoid typeless storage in trailing wide ints

2020-10-27 Thread Jan Hubicka
Hi, this patch avoid typeless storage in trailing_wide_ints. This improves TBAA disambiguation rate on cc1plus by 7%. Bootstrapped/regtested x86_64-linux, OK? * wide-int.h (trailing_wide_ints ): Turn len to array of structures so it does not imply typeless storage. (traili

Re: [RS6000] dg-do !compile and scan-assembler

2020-10-27 Thread Alan Modra via Gcc-patches
On Tue, Oct 27, 2020 at 05:34:45PM -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Oct 27, 2020 at 09:26:10PM +1030, Alan Modra wrote: > > These tests never checked assembly, because .s files were not > > produced. One test was looking for the wrong instructions. > > -/* { dg-final { scan-as

Re: PowerPC: Update __float128 and __ibm128 error messages.

2020-10-27 Thread Segher Boessenkool
Hi! On Thu, Oct 22, 2020 at 06:11:35PM -0400, Michael Meissner wrote: > This patch attempts to make the error messages for intermixing IEEE 128-bit > floating point with IBM 128-bit extended double types to be clearer if the > long > double type uses the IEEE 128-bit format. > We have gotten som

[PATCH] Tweaks to ranger API routines.

2020-10-27 Thread Andrew MacLeod via Gcc-patches
There are a couple of little things I've been meaning to get to. 1)  The API routines return TRUE when a range has been computed, and false when one cannot be. The range itself was uninitialized when false was returned, and this was a bit awkward by times. Now, when false is returned, the ra

Re: [PATCH][PR target/97540] Don't extract memory from operand for normal memory constraint.

2020-10-27 Thread Hongtao Liu via Gcc-patches
On Tue, Oct 27, 2020 at 7:13 PM Richard Sandiford wrote: > > Hongtao Liu via Gcc-patches writes: > > Hi: > > For inline asm, there could be an operand like (not (mem:)), it's > > not a valid operand for normal memory constraint. > > Bootstrap is ok, regression test is ok for make check > > RU

Re: move sincos after pre

2020-10-27 Thread Alexandre Oliva
On Oct 27, 2020, Richard Biener wrote: > For trapping math SRC may be a constant? Better be safe > and guard against TREE_CODE (src) != SSA_NAME. *nod* > You also want to guard against SSA_NAME_OCCURS_IN_ABNORMAL_PHI (src) > since you cannot generally propagate or move uses of those. What if

Re: [PATCH v2] c++: Implement -Wvexing-parse [PR25814]

2020-10-27 Thread Jason Merrill via Gcc-patches
On 10/24/20 7:40 PM, Marek Polacek wrote: On Fri, Oct 23, 2020 at 09:33:38PM -0400, Jason Merrill via Gcc-patches wrote: On 10/23/20 3:01 PM, Marek Polacek wrote: This patch implements the -Wvexing-parse warning to warn about the sneaky most vexing parse rule in C++: the cases when a declaratio

<    1   2