Hi!
On Thu, Oct 22, 2020 at 06:11:35PM -0400, Michael Meissner wrote:
> This patch attempts to make the error messages for intermixing IEEE 128-bit
> floating point with IBM 128-bit extended double types to be clearer if the
> long
> double type uses the IEEE 128-bit format.
> We have gotten some requests to back port these changes to GCC 10.x. At the
> moment, I am not planning to do the back port, but I may need to in the
> future.
Ping the patches if/when that happens?
> +/* { dg-do compile { target { powerpc*-*-linux* } } } */
Use *-*-linux* instead? (In all relevant tests.)
Is there any reason these tests should only run on Linux? If not, it
should not restrict itself like this; and if so, you may want another
selsector (something ieee128 perhaps), or at the very least add a
comment why you do this.
> /* { dg-do compile { target { powerpc*-*-linux* } } } */
> -/* { dg-require-effective-target powerpc_vsx_ok } */
> -/* { dg-options "-O2 -mvsx" } */
> +/* { dg-require-effective-target ppc_float128_sw } */
Removing powerpc_vsx_ok is wrong, you still use -mvsx. That the only
current soft float QP stuff requires VSX is irrelevant.
Please fix those everywhere. Okay for trunk with that. Thanks!
Segher
