Re: [PATCH] lto: no sub-make when --jobserver-auth= is missing

2020-10-27 Thread Richard Biener via Gcc-patches
On Mon, Oct 26, 2020 at 7:21 PM Martin Liška wrote: > > We newly correctly detect that a job server is not active for > a LTO linking: > > lto-wrapper: warning: jobserver is not available: '--jobserver-auth=' is not > present in 'MAKEFLAGS' > > In that situation we should not call make -f abc.mk

Re: Add string builtins to builtin_fnspec

2020-10-27 Thread Richard Biener
On Mon, 26 Oct 2020, Jan Hubicka wrote: > Hi, > this patch adds missing string builtins to builtin_fnspec. > Bootstrapped/regtested x86_64-linux, OK? OK. Thanks, Richard. > gcc/ChangeLog: > > 2020-10-26 Jan Hubicka > > * builtins.c (builtin_fnspec): Add bzero, memcmp, memcmp_eq, bcmp

Re: Fix builtin decls generated in tree.c

2020-10-27 Thread Richard Biener
On Mon, 26 Oct 2020, Jan Hubicka wrote: > Hi, > tree.c still produces "fn spec" attribute for memcpy, memmove and > memset. This is not desirable since "1" is less informative than > fnspec builtin_fnspec returns. > > Also the buitin would fire checker, since it misses the second caracter, > so

Re: Use EAF_RETURN_ARG in tree-ssa-ccp.c

2020-10-27 Thread Richard Biener
On Mon, 26 Oct 2020, Jan Hubicka wrote: > Hi, > while looking for special cases of buitins I noticed that tree-ssa-ccp > can use EAF_RETURNS_ARG. I wonder if same should be done by value > numbering and other propagators The issue is that changing q = memcpy (p, r); .. use q ... to

Re: [PATCH] [PR target/97194] [AVX2] Support variable index vec_set.

2020-10-27 Thread Hongtao Liu via Gcc-patches
ping^1 On Tue, Oct 20, 2020 at 3:36 PM Richard Biener wrote: > > On Tue, Oct 20, 2020 at 4:35 AM Hongtao Liu wrote: > > > > On Mon, Oct 19, 2020 at 5:55 PM Richard Biener > > wrote: > > > > > > On Mon, Oct 19, 2020 at 11:37 AM Hongtao Liu wrote: > > > > > > > > On Mon, Oct 19, 2020 at 5:07 PM

Re: Use EAF_RETURN_ARG in tree-ssa-ccp.c

2020-10-27 Thread Jan Hubicka
> On Mon, 26 Oct 2020, Jan Hubicka wrote: > > > Hi, > > while looking for special cases of buitins I noticed that tree-ssa-ccp > > can use EAF_RETURNS_ARG. I wonder if same should be done by value > > numbering and other propagators > > The issue is that changing > > q = memcpy (p, r); >

Re: Fix fnspecs for math builtins

2020-10-27 Thread Jan Hubicka
> On Mon, 26 Oct 2020, Jan Hubicka wrote: > > > Hi, > > this patch makes us to use ".C" and ".P" fnspecs where > > applicable. I also noticed that gamma and variants are > > declared as storing to memory while they are not (gamma_r does) > > I think the point is that they store to the global sig

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Uros Bizjak via Gcc-patches
On Tue, Oct 27, 2020 at 12:08 AM Qing Zhao wrote: > > Hi, Uros, > > Could you please check the change compared to the previous version for i386.c > as following: > Let me know any issue there. It looks that the combination when the function only touches MMX registers (so, no x87 register is touc

[committed] RISC-V: Refine riscv_parse_arch_string

2020-10-27 Thread Kito Cheng
- Generalize logic for translating arch to internal flags, this patch is infrastructure for supporing sub-extension parsing. gcc/ChangeLog * common/config/riscv/riscv-common.c (opt_var_ref_t): New. (riscv_ext_flag_table_t): New. (riscv_ext_flag_table): New. (ri

Re: Fix fnspecs for math builtins

2020-10-27 Thread Richard Biener via Gcc-patches
On Tue, Oct 27, 2020 at 9:06 AM Jan Hubicka wrote: > > > On Mon, 26 Oct 2020, Jan Hubicka wrote: > > > > > Hi, > > > this patch makes us to use ".C" and ".P" fnspecs where > > > applicable. I also noticed that gamma and variants are > > > declared as storing to memory while they are not (gamma_r

Re: move sincos after pre

2020-10-27 Thread Richard Biener via Gcc-patches
On Tue, Oct 27, 2020 at 6:32 AM Alexandre Oliva wrote: > > On Oct 23, 2020, Richard Biener wrote: > > > Can you move it one pass further after sink please? > > I did, but it didn't solve the recip regressions that my first attempt > brought about. > > > Also I don't > > remember exactly but does

Re: Use EAF_RETURN_ARG in tree-ssa-ccp.c

2020-10-27 Thread Richard Biener
On Tue, 27 Oct 2020, Jan Hubicka wrote: > > On Mon, 26 Oct 2020, Jan Hubicka wrote: > > > > > Hi, > > > while looking for special cases of buitins I noticed that tree-ssa-ccp > > > can use EAF_RETURNS_ARG. I wonder if same should be done by value > > > numbering and other propagators > > >

[committed] wwwdocs: Adjust note on OpenMP 4.5.

2020-10-27 Thread Gerald Pfeifer
I was going to fix "limitted" to "limited" and added this simplification. Turns out "limitted" had already been addressed, still worth improving messaging, so I pushed the below. Gerald --- htdocs/gcc-11/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc

[Ada] Remove Digits_From_Size and Width_From_Size

2020-10-27 Thread Pierre-Marie de Rodat
The Digits_From_Size and Width_From_Size functions of Get_Targ, as well as the *_Width and *_Digits constants of Ttypes, have been unused for a while in the compiler. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * ada_get_targ.adb (Digits_From_Size): Delete. (Width_

[Ada] Warnings on g-spogwa.adb

2020-10-27 Thread Pierre-Marie de Rodat
This unit added recently generate legitimate warnings which were not caught because this file had not been added to Makefile.rtl. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * Makefile.rtl (GNATRTL_NONTASKING_OBJS): Add g-spogwa object. * libgnat/g-spogwa.adb: Fix

[Ada] Multidimensional arrays with Iterated_Component_Associations

2020-10-27 Thread Pierre-Marie de Rodat
This patch allows the compiler to handle array aggregates with more than two dimensions, when the aggregate includes nested Iterated_Component_Associations for sub-aggregates. These constructs are expanded into a loop that contains a copy of the expression. Previously their semantic analysis was do

[Ada] New flag Transform_Function_Array

2020-10-27 Thread Pierre-Marie de Rodat
This new flag is introduced to enable the transformation of function returning constrained arrays into a procedure separately from Modify_Tree_For_C for easier reuse. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_ch6.adb, freeze.adb, gnat1drv.adb, opt.ads, sem_ch6.adb

[Ada] Fix GNATprove support for iterated_component_associations

2020-10-27 Thread Pierre-Marie de Rodat
GNAT only partially analyzes iterated_component_associations within array aggregates, as they are fully analyzed when expanded into loops. GNATprove must therefore analyze iterated_component_associations as part of its custom expansion. This only worked for one-dimensional array aggregates; now it

Re: [PATCH] [tree-optimization] Fix for PR97223

2020-10-27 Thread Richard Biener via Gcc-patches
On Sat, Oct 24, 2020 at 2:20 AM Eugene Rozenfeld via Gcc-patches wrote: > > This patch adds a pattern for folding > x < (short) ((unsigned short)x + const) > to > x <= SHORT_MAX - const > (and similarly for other integral types) if const is not 0. > as described in PR97223

Re: [PATCH] Refactor array descriptor field access

2020-10-27 Thread Richard Biener via Gcc-patches
On Fri, Oct 16, 2020 at 10:47 AM Richard Biener wrote: > > This refactors the array descriptor component access tree building > to commonize code into new helpers to provide a single place to > fix correctness issues with respect to TBAA. > > The only interesting part is the gfc_conv_descriptor_da

Add fnspec to C++ new and delete

2020-10-27 Thread Jan Hubicka
Hi, this patch makes C++ new and delete operators to be handled as malloc/free for fnspec. I still do not understand why free is ".co " and not ".cO ". I do not think we need to invalidate memory referenced to by blockbeing freed. Bootstrapped/regtested x86_64-linux, OK? Honza gcc/ChangeLog: 2

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-10-27 Thread Jonathan Wakely via Gcc-patches
On 26/10/20 14:48 -0700, Thomas Rodgers wrote: +#include + +#if __has_include() +#define _GLIBCXX_HAVE_POSIX_SEMAPHORE 1 +#include It occurs to me now that this check probably isn't robust enough. For any POSIX system it's probably safe to assume that means the POSIX header and so sem_t is a

Re: [PATCH] gcov-profile: use static pool for TOPN first

2020-10-27 Thread Martin Liška
@Honza: PING Thanks On 10/20/20 11:10 AM, Martin Liška wrote: Hello. As noticed in the PR, it's quite tricky to not run malloc (or calloc) in context of libgcov. I'm suggesting a new approach where we'll first use the pre-allocated static buffer in hope that malloc function is initialized and

Re: [PATCH] LTO: get_section: add new argument

2020-10-27 Thread Martin Liška
On 10/22/20 2:14 PM, Martin Liška wrote: On 10/22/20 1:42 PM, Martin Jambor wrote: ...is that I think this should be internal_error.  I am not sure what difference it makes in practice, if any, though. You are right, using internal_error is a better approach. Martin Is also the rest of the

Re: [PATCH] gcov-profile: use static pool for TOPN first

2020-10-27 Thread Jan Hubicka
> > Hello. > > > > As noticed in the PR, it's quite tricky to not run malloc (or calloc) > > in context of libgcov. I'm suggesting a new approach where we'll first > > use the pre-allocated static buffer in hope that malloc function is > > initialized > > and so every call to calloc can happen. T

Re: [PATCH V2] aarch64: Add bfloat16 vldN_lane_bf16 + vldNq_lane_bf16 intrisics

2020-10-27 Thread Richard Sandiford via Gcc-patches
Andrea Corallo writes: > Richard Sandiford writes: > >> Andrea Corallo via Gcc-patches writes: >>> Hi all, >>> >>> Second version of the patch here implementing the bfloat16_t neon >>> related load intrinsics: vld2_lane_bf16, vld2q_lane_bf16, >>> vld3_lane_bf16, vld3q_lane_bf16 vld4_lane_bf16, v

*PING^4* [PATCH] doc: gcc.c: Update documentation for spec files

2020-10-27 Thread Armin Brauns via Gcc-patches
On 15/10/2020 10.11, Armin Brauns wrote: > On 02/10/2020 19.20, Armin Brauns wrote: >> On 06/09/2020 17.23, Armin Brauns wrote: >>> There were some differences between the actual code in do_spec_1, its >>> source comment, and the documentation in doc/invoke.texi. These should >>> now be resolved. >

Re: [PATCH 2/2] combine: Don't turn (mult (extend x) 2^n) into extract

2020-10-27 Thread Alex Coplan via Gcc-patches
On 26/10/2020 12:43, Segher Boessenkool wrote: > On Mon, Oct 26, 2020 at 01:28:42PM +, Alex Coplan wrote: > > On 26/10/2020 07:12, Segher Boessenkool wrote: > > > On Thu, Oct 15, 2020 at 09:59:24AM +0100, Alex Coplan wrote: > > > Can you instead replace the mult by a shift somewhere earlier in

Re: [PATCH] gcov-profile: use static pool for TOPN first

2020-10-27 Thread Martin Liška
On 10/27/20 11:29 AM, Jan Hubicka wrote: Looks reasonable, but I do not like very much the non-configurable preallocation since libgcov was meant to be useful for embedded targets and not consume too much. Sure, we can handle that later when it's really an issue. I guess we could handle that

[committed] d: Merge upstream dmd 0fcdaab32

2020-10-27 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the D front-end implementation with upstream dmd 0fcdaab32, fixing a bug where there was undefined template references when compiling upstream dmd mainline. In `TemplateInstance::semantic`, there exists special handling of matching template instances for the same template de

[committed] d: Remove the d_critsec_size target hook.

2020-10-27 Thread Iain Buclaw via Gcc-patches
Hi, This patch removes the d_critsec_size target hook from the D front-end and all related target support code. Its replacement is implemented in the merge of upstream dmd bec5973b0 and druntime 58560d51. The allocation of mutex objects for synchronized statements has been moved to the library a

[RS6000] dg-do !compile and scan-assembler

2020-10-27 Thread Alan Modra via Gcc-patches
>From 6c1817cece47ce2cb36df1f57b533b9d2385f0a5 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 27 Oct 2020 17:32:13 +1030 Subject: These tests never checked assembly, because .s files were not produced. One test was looking for the wrong instructions. A typical error log PASS: gcc.target/

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-10-27 Thread Martin Liška
PING^6 The patch is in review process for more than 6 months, can please any global reviewer take a look at it? Thanks, Martin On 9/25/20 4:55 PM, Martin Liška wrote: PING^5

Re: [PATCH] gcov-profile: use static pool for TOPN first

2020-10-27 Thread Jan Hubicka
> On 10/27/20 11:29 AM, Jan Hubicka wrote: > > Looks reasonable, but I do not like very much the non-configurable > > preallocation since libgcov was meant to be useful for embedded targets > > and not consume too much. > > Sure, we can handle that later when it's really an issue. > > > I guess w

Re: [PATCH][PR target/97540] Don't extract memory from operand for normal memory constraint.

2020-10-27 Thread Richard Sandiford via Gcc-patches
Hongtao Liu via Gcc-patches writes: > Hi: > For inline asm, there could be an operand like (not (mem:)), it's > not a valid operand for normal memory constraint. > Bootstrap is ok, regression test is ok for make check > RUNTESTFLAGS="--target_board='unix{-m32,}'" > > gcc/ChangeLog > PR

[PATCH V3] aarch64: Add bfloat16 vldN_lane_bf16 + vldNq_lane_bf16 intrisics

2020-10-27 Thread Andrea Corallo via Gcc-patches
Richard Sandiford writes: > Andrea Corallo writes: >> Richard Sandiford writes: >> >>> Andrea Corallo via Gcc-patches writes: Hi all, Second version of the patch here implementing the bfloat16_t neon related load intrinsics: vld2_lane_bf16, vld2q_lane_bf16, vld3_lane_b

[RS6000] power10 scan-assembler tests

2020-10-27 Thread Alan Modra via Gcc-patches
On power10 these are "dg-do run" tests, so need -save-temps for the assembler scanning. Regression tested powerpc64le-linux power8 and power10. OK? * gcc.target/powerpc/vsx-load-element-extend-char.c: Add -save-temps. * gcc.target/powerpc/vsx-load-element-extend-int.c: Likewise.

Re: [PATCH] Combine logical OR ranges properly. pr97567

2020-10-27 Thread Christophe Lyon via Gcc-patches
Hi, On Mon, 26 Oct 2020 at 22:51, Andrew MacLeod via Gcc-patches wrote: > > In the core of gori_compute::logical_combine we are suppose to combine > the calculated true and false ranges on each side of the operation. > > when encountering > > [0,0] = c_3 | c_4 > > we know we only need to cons

Re: [PATCH V3] aarch64: Add bfloat16 vldN_lane_bf16 + vldNq_lane_bf16 intrisics

2020-10-27 Thread Richard Sandiford via Gcc-patches
Andrea Corallo writes: > Richard Sandiford writes: > >> Andrea Corallo writes: >>> Richard Sandiford writes: >>> Andrea Corallo via Gcc-patches writes: > Hi all, > > Second version of the patch here implementing the bfloat16_t neon > related load intrinsics: vld2_lane_bf16

Re: [PATCH] Combine logical OR ranges properly. pr97567

2020-10-27 Thread H.J. Lu via Gcc-patches
On Tue, Oct 27, 2020 at 4:24 AM Christophe Lyon via Gcc-patches wrote: > > Hi, > > On Mon, 26 Oct 2020 at 22:51, Andrew MacLeod via Gcc-patches > wrote: > > > > In the core of gori_compute::logical_combine we are suppose to combine > > the calculated true and false ranges on each side of the ope

[PATCH 0/2] arm: "noinit" and "persistent" attributes

2020-10-27 Thread Jozef Lawrynowicz
This patch series fixes behavior related to the "noinit" attribute, and makes the MSP430 "persistent" attribute generic, so it can be used for ARM. These attributes are related because they are both used to mark variables that should not be initialized by the target's runtime startup code. The "no

[PATCH 1/2] Fix "noinit" attribute being ignored for -O0 and -fdata-sections

2020-10-27 Thread Jozef Lawrynowicz
Variables with the "noinit" attribute are ignored at -O0 because they are treated like a regular .bss variable and placed in the .bss section. With -fdata-sections they are ignored because they are not handled in resolve_unique_section. Successfully bootstrapped/regtested x86_64-pc-linux-gnu and

[PATCH 2/2] Implement the "persistent" attribute

2020-10-27 Thread Jozef Lawrynowicz
The "persistent" attribute is used for variables that are initialized by the program loader, but are not initialized by the runtime startup code. "persistent" variables are placed in a non-volatile area of memory, which allows their value to "persist" between processor resets. Successfully bootstr

Re: [PATCH 2/2] combine: Don't turn (mult (extend x) 2^n) into extract

2020-10-27 Thread Alex Coplan via Gcc-patches
On 27/10/2020 10:35, Alex Coplan via Gcc-patches wrote: > On 26/10/2020 12:43, Segher Boessenkool wrote: > > I do not like handling both mult and ashift in one case like this, it > > complicates things for no good reason. Write it as two cases, and it > > should be good. > > OK, the attached patc

Re: [PATCH] PR fortran/97491 - Wrong restriction for VALUE arguments of pure procedures

2020-10-27 Thread Paul Richard Thomas via Gcc-patches
Hi Harald, OK for master and 10-branch if you want. Thanks Paul On Mon, 26 Oct 2020 at 21:00, Harald Anlauf wrote: > As found/reported by Thomas, the redefinition of dummy arguments with the > VALUE attribute was erroneously rejected for pure procedures. A related > purity check did not tak

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Richard Sandiford via Gcc-patches
To review my review… Richard Sandiford via Gcc-patches writes: >> +In addition to the above three basic choices, the register set can be >> further >> +limited by adding "-gpr" (i.e., general purpose register), "-arg" (i.e., >> +argument register), or both as following: > > How about: > > --

[PATCH] Avoid uniform lane BB vectorization

2020-10-27 Thread Richard Biener
This makes sure to use splats early when facing uniform internal operands in BB SLP discovery rather than relying on the late heuristincs re-building nodes from scratch. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2020-10-27 Richard Biener * tree-vect-slp.c (vect_buil

[PATCH] SLP vectorize across PHI nodes

2020-10-27 Thread Richard Biener
This makes SLP discovery detect backedges by seeding the bst_map with the node to be analyzed so it can be picked up from recursive calls. This removes the need to discover backedges in a separate walk. This enables SLP build to handle PHI nodes in full, continuing the SLP build to non-backedges.

[PATCH 2/2] Enable OpenMP efficient performance profiling via ITT tracing

2020-10-27 Thread Vitaly Slobodskoy
This patch adds the remaining part of ITT API (src folder), enables its compilation and includes modifications within autogenerated files (as result of autoreconf within libgomp folder). >From fee569f2fc016a864aca7941d5396fa4497507a0 Mon Sep 17 00:00:00 2001 From: Vitaly Slobodskoy Date: Tue, 2

Re: [PATCH] nvptx: Cache stacks block for OpenMP kernel launch

2020-10-27 Thread Julian Brown
(Apologies if threading is broken, for some reason I didn't receive this reply directly!) On Mon Oct 26 14:26:34 GMT 2020, Jakub Jelinek wrote: > On Mon, Oct 26, 2020 at 07:14:48AM -0700, Julian Brown wrote: > > This patch adds caching for the stack block allocated for offloaded > > OpenMP kernel

Re: [PATCH] Refactor array descriptor field access

2020-10-27 Thread Paul Richard Thomas via Gcc-patches
Hi Richard, This looks good to me. OK for master. Do you have any plans to backport to 10-branch, say? Thanks Paul On Tue, 27 Oct 2020 at 09:28, Richard Biener via Fortran < fort...@gcc.gnu.org> wrote: > On Fri, Oct 16, 2020 at 10:47 AM Richard Biener wrote: > > > > This refactors the array

Re: [PATCH] Refactor array descriptor field access

2020-10-27 Thread Richard Biener
On Tue, 27 Oct 2020, Paul Richard Thomas wrote: > Hi Richard, > > This looks good to me. OK for master. Thanks, pushed. > Do you have any plans to backport to > 10-branch, say? No, it's just refactoring to remove the GENERIC building duplication. Richard. > Thanks > > Paul > > > On Tue,

[committed] libstdc++: Include in tests that use std::uintptr_t

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * testsuite/experimental/memory_resource/new_delete_resource.cc: Add missing header. * testsuite/experimental/memory_resource/resource_adaptor.cc: Likewise. Tested x86_64-linux. Committed to trunk. commit 01079b6a9236bd467b445fafaff2659840

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Qing Zhao via Gcc-patches
> On Oct 27, 2020, at 3:09 AM, Uros Bizjak wrote: > > On Tue, Oct 27, 2020 at 12:08 AM Qing Zhao > wrote: >> >> Hi, Uros, >> >> Could you please check the change compared to the previous version for >> i386.c as following: >> Let me know any issue there. > > I

[committed] analyzer: implement region_model::get_representative_path_var for labels

2020-10-27 Thread David Malcolm via Gcc-patches
This fixes an ICE seen e.g. with gcc.dg/analyzer/data-model-16.c when enabling -fdump-analyzer. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 9e78634c74c540cad6a2ca447af0d5df1ac4c60b. gcc/analyzer/ChangeLog: * region-model.cc (region_model::get_represe

[committed] analyzer: fix param "analyzer-max-enodes-per-program-point"

2020-10-27 Thread David Malcolm via Gcc-patches
This was effectively checking for one beyond the limit, rather than the limit itself. Seen when fixing PR analyzer/97514. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as ea0ae4e77a89d4a0492dcbbc13e9cbc19bcc2361. gcc/analyzer/ChangeLog: * engine.cc (expl

[committed 2/2] analyzer: eliminate non-deterministic behavior

2020-10-27 Thread David Malcolm via Gcc-patches
This patch is a followup to the previous one, eliminating non-determinism in the behavior of the analyzer (rather than just in the logs), by sorting whenever the result previously depended on pointer values. Tested as per the previous patch. Successfully bootstrapped & regrtested on x86_64-pc-lin

[committed 1/2] analyzer: eliminate non-determinism in logs

2020-10-27 Thread David Malcolm via Gcc-patches
This patch and the followup eliminate various forms of non-determinism in the analyzer due to changing pointer values. This patch fixes churn seen when diffing analyzer logs. The patch avoids embedding pointers in various places, and adds sorting when dumping hash_set and hash_map for various ana

[PATCH] Adjust BB vectorization function splitting

2020-10-27 Thread Richard Biener
This adjusts the condition when to split at control altering stmts, only when there's a definition. It also removes the only use of --param slp-max-insns-in-bb which a previous change left doing nothing (but repeatedly print a message for each successive instruction...). Bootstrapped on x86_64-un

Re: [PATCH] [PR96608] analyzer: Change cast from long to intptr_t

2020-10-27 Thread David Malcolm via Gcc-patches
On Wed, 2020-09-30 at 09:43 +0200, Markus Böck wrote: > Casting to intptr_t states the intent of an integer to pointer cast > more clearly and ensures that the cast causes no loss of precision on > any platforms. LLP64 platforms eg. have a long value of 4 bytes and > pointer values of 8 bytes which

Re: [PATCH] c++: Check constraints before instantiation from mark_used [PR95132]

2020-10-27 Thread Jason Merrill via Gcc-patches
On 10/26/20 5:37 PM, Patrick Palka wrote: This makes mark_used check constraints of a function _before_ calling maybe_instantiate_decl, so that we don't try instantiating a function (as part of return type deduction) with unsatisfied constraints. Bootstrapped and regtested on x86_64-pc-linux-gnu

Re: [PATCH 1/2] Enable OpenMP efficient performance profiling via ITT tracing

2020-10-27 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 27, 2020 at 12:55:36PM +, Vitaly Slobodskoy wrote: > I'd like to propose instrumentation of GCC OpenMP runtime with ITT API > (https://github.com/intel/ittapi) like it was already done for LLVM > (https://github.com/llvm/llvm-project/tree/master/openmp/runtime/src/thirdparty/ittno

[committed] testsuite: restrict test to c++11 and later [PR97590]

2020-10-27 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 27, 2020 at 07:38:53AM +0100, Aldy Hernandez via Gcc-patches wrote: > This was already fixed by the patch for PR97520, but it can't hurt to > keep this test around as well :). Small tweaks for that. Note, it would be better to put such tests into g++.dg/opt/, g++.dg/ itself shouldn't

[PING 2][PATCH] issue -Wstring-compare in more case (PR 95673)

2020-10-27 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555225.html On 10/8/20 8:43 AM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555225.html On 9/30/20 6:14 PM, Martin Sebor wrote: -Wstring-compare triggers under the same strict conditions as the st

[committed] analyzer: don't assume extern const vars are zero-initialized [PR97568]

2020-10-27 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-4437-g16ad9ae85bb5b9acf80f9d1cf2be5a989ef7ba49. gcc/analyzer/ChangeLog: PR analyzer/97568. * region-model.cc (region_model::get_initial_value_for_global): Move check that !DECL_EXTERNAL f

Re: [PATCH v7] genemit.c (main): split insn-emit.c for compiling parallelly

2020-10-27 Thread Richard Sandiford via Gcc-patches
Jojo R writes: > gcc/ChangeLog: > > * genemit.c (main): Print 'split line'. > * Makefile.in (insn-emit.c): Define split count and file > > --- > gcc/Makefile.in | 19 + > gcc/genemit.c | 104 +--- > 2 files changed, 83 insertions(

Re: [PATCH] Combine logical OR ranges properly. pr97567

2020-10-27 Thread Andrew MacLeod via Gcc-patches
On 10/27/20 7:23 AM, Christophe Lyon wrote: Hi, On Mon, 26 Oct 2020 at 22:51, Andrew MacLeod via Gcc-patches wrote: In the core of gori_compute::logical_combine we are suppose to combine the calculated true and false ranges on each side of the operation. when encountering [0,0] = c_3 | c

Re: PowerPC: Update __float128 and __ibm128 error messages.

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:11 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Update __float128 and __ibm128 error messages. > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > This patch attempts to make the error messages for intermixin

Re: [committed] testsuite: restrict test to c++11 and later [PR97590]

2020-10-27 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 27, 2020 at 3:10 PM Jakub Jelinek wrote: > > On Tue, Oct 27, 2020 at 07:38:53AM +0100, Aldy Hernandez via Gcc-patches > wrote: > > This was already fixed by the patch for PR97520, but it can't hurt to > > keep this test around as well :). > > Small tweaks for that. Note, it would be

Re: [committed] testsuite: restrict test to c++11 and later [PR97590]

2020-10-27 Thread Jakub Jelinek via Gcc-patches
On Tue, Oct 27, 2020 at 03:20:55PM +0100, Aldy Hernandez wrote: > > g++.dg/opt/, g++.dg/ itself shouldn't really have any tests directly. > > Wait, what? I've always put them into g++.dg. And it looks like that Many people violate that. > directory is chock-full of PR.C files. When did we

Re: PowerPC: Use __builtin_pack_ieee128 if long double is IEEE 128-bit.

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:10 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Use __builtin_pack_ieee128 if long double is IEEE 128-bit. > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > This patch changes the __ibm128 emulator to use _

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Qing Zhao via Gcc-patches
> On Oct 26, 2020, at 1:47 PM, Richard Sandiford > wrote: > > Qing Zhao writes: >> diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi >> index c9f7299..3a884e1 100644 >> --- a/gcc/doc/extend.texi >> +++ b/gcc/doc/extend.texi >> @@ -3992,6 +3992,49 @@ performing a link with relocatable ou

Re: [PING #2][PATCH] use get_size_range to get allocated size (PR 92942)

2020-10-27 Thread Martin Sebor via Gcc-patches
This patch was never reviewed and I forgot all about it but I wound up reimplementing the same solution in r11-3827, so I just committed the tests from this one in r11-4441. On 9/30/20 4:25 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-August/552903.html (I lost t

Re: libstdc++: Attempt to resolve PR83562

2020-10-27 Thread Liu Hao via Gcc-patches
在 2020/10/8 22:56, Jason Merrill 写道: > > Hmm, why isn't the mingw implementation used for all programs?  That would > avoid the bug. > There was a little further discussion about this [1]. TL;DR: The mingw-w64 function is linked statically and subject to issues about order of destruction. Re

Re: PowerPC: Update IEEE 128-bit built-ins for long double is IEEE 128-bit.

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:09 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Update IEEE 128-bit built-ins for long double is IEEE 128-bit. "for when .." > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > This patch adds long double v

[patch] vxworks: Fix glitch on VX_CPU selection for E6500

2020-10-27 Thread Olivier Hainque
Hello, The proper VxWorks CPU macro name for -mcpu=e6500 is PPCE6500, not E6500. Committing after checking that it lets a powerpc64-wrs-vxworks7r2 build proceed to termination in a freshly setup environment. Olivier 2020-10-27 Olivier Hainque gcc/ * config/rs6000/vxworks.h (CPP_

Re: [PATCH] Combine logical OR ranges properly. pr97567

2020-10-27 Thread H.J. Lu via Gcc-patches
On Tue, Oct 27, 2020 at 7:18 AM Andrew MacLeod via Gcc-patches wrote: > > On 10/27/20 7:23 AM, Christophe Lyon wrote: > > Hi, > > > > On Mon, 26 Oct 2020 at 22:51, Andrew MacLeod via Gcc-patches > > wrote: > >> In the core of gori_compute::logical_combine we are suppose to combine > >> the calcul

[patch] vxworks: Extract VX_CPU_PREFIX up into config/vxworks.h

2020-10-27 Thread Olivier Hainque
Hello, This change moves the VX_CPU_PREFIX definition in rs6000/vxworks.h to a place where it can be reused by other target ports. Committing after a successful build of both the ppc and x86 ports (patch to come for the latter). 2020-10-21 Olivier Hainque gcc/ * config/vxworks.h

Re: [PATCH] Combine logical OR ranges properly. pr97567

2020-10-27 Thread Andrew MacLeod via Gcc-patches
On 10/27/20 10:44 AM, H.J. Lu wrote: On Tue, Oct 27, 2020 at 7:18 AM Andrew MacLeod via Gcc-patches wrote: On 10/27/20 7:23 AM, Christophe Lyon wrote: Hi, On Mon, 26 Oct 2020 at 22:51, Andrew MacLeod via Gcc-patches wrote: In the core of gori_compute::logical_combine we are suppose to combi

Re: PowerPC: Add __float128 conversions to/from Decimal

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:06 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Add __float128 conversions to/from Decimal. > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > This patch adds the various decimal to/from IEEE 128-bit convers

[committed] libstdc++: Add noexcept to declaration of path::_List members

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/bits/fs_path.h (path::_List::begin, path::_List::end): Add noexcept to match definitions in src/c++17/fs_path.cc. Tested x86_64-linux. Committed to trunk. commit fe9d058ca28e0e3a50c44096ce112763057e686e Author: Jonathan Wakely Date: Tue Oct 27

[committed] libstdc++: Fix directory_iterator exception specification

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * src/c++17/fs_dir.cc (fs::directory_iterator::operator*): Add noexcept. Do not throw on precondition violation. Tested x86_64-linux. Committed to trunk. commit 044b04348cfdc12848f1c6d5a8f45087c3075390 Author: Jonathan Wakely Date: Tue Oct 27 14:49:37 2

[committed] libstdc++: Add missing noexcept to std::from_chars declarations

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/std/charconv (from_chars): Add noexcept to match definitions in src/c++17/floating_from_chars.cc Tested x86_64-linux. Committed to trunk. commit e579f66c3c6566e94be842bea7f2a93370489626 Author: Jonathan Wakely Date: Tue Oct 27 14:49:47 2020

[PATCH] Fix BB store group splitting group size compute

2020-10-27 Thread Richard Biener
This fixes a mistake in the previous change in this area to what was desired - figure the largest power-of-two group size fitting in the matching area. Bootstrap and regtest running on x86_64-unknown-linux-gnu. 2020-10-27 Richard Biener * tree-vect-slp.c (vect_build_slp_instance): Use

Re: [committed] testsuite: restrict test to c++11 and later [PR97590]

2020-10-27 Thread Aldy Hernandez via Gcc-patches
On Tue, Oct 27, 2020 at 3:29 PM Jakub Jelinek wrote: > > On Tue, Oct 27, 2020 at 03:20:55PM +0100, Aldy Hernandez wrote: > > > g++.dg/opt/, g++.dg/ itself shouldn't really have any tests directly. > > > > Wait, what? I've always put them into g++.dg. And it looks like that > > Many people violat

Re: PowerPC: Update long double IEEE 128-bit tests.

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:07 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Update long double IEEE 128-bit tests. > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > This patch fixes 3 tests in the testsuite that fail if long double is

Re: PowerPC: Map q built-ins to *l instead of *f128 if IEEE 128-bit long double.

2020-10-27 Thread will schmidt via Gcc-patches
On Thu, 2020-10-22 at 18:08 -0400, Michael Meissner via Gcc-patches wrote: > PowerPC: Map q built-ins to *l instead of *f128 if IEEE 128-bit long double. > > I have split all of these patches into separate patches to hopefully get them > into the tree. > > If we map nanq to nanf128 when long doub

Fix signature updates in ipa-modref

2020-10-27 Thread Jan Hubicka
Hi, ipa-modref updates summaries for changed function signatures in transform hook. This has a problem with program partitioning because transform happens only in one partition. So I moved the logic to the ipa pass itself and added a check that we produce no more clones (if we will ever do, we wil

[PATCH] Selectively trap if ranger and vr-values disagree on range builtins.

2020-10-27 Thread Aldy Hernandez via Gcc-patches
The UBSAN builtins degrade into PLUS/MINUS/MULT and call extract_range_from_binary_expr, which as the PR shows, can special case some symbolics which the ranger doesn't currently handle. Looking at vr_values::extract_range_builtin(), I see that every single place where we ask for a range, we bail

Re: [PATCH v2] pass: Run cleanup passes before SLP [PR96789]

2020-10-27 Thread Richard Sandiford via Gcc-patches
Kewen asked me to have a look at this since Richard was reluctant to approve it (given that it was his idea). TBH I don't know much about the pass machinery, so I'm not sure I'm really best placed. There again, perhaps I know just enough to realise that this is indeed the hack that it's billed as

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Richard Sandiford via Gcc-patches
Qing Zhao writes: >>> diff --git a/gcc/flag-types.h b/gcc/flag-types.h >>> index 852ea76..0f7e503 100644 >>> --- a/gcc/flag-types.h >>> +++ b/gcc/flag-types.h >>> @@ -285,6 +285,15 @@ enum sanitize_code { >>> | SANITIZE_BOUNDS_STRICT >>> }; >>> >>> +enum zero_call_u

Re: [PATCH] arm: Fix multiple inheritance thunks for thumb-1 with -mpure-code

2020-10-27 Thread Richard Earnshaw via Gcc-patches
On 26/10/2020 10:52, Christophe Lyon via Gcc-patches wrote: > On Thu, 22 Oct 2020 at 17:22, Richard Earnshaw > wrote: >> >> On 22/10/2020 09:45, Christophe Lyon via Gcc-patches wrote: >>> On Wed, 21 Oct 2020 at 19:36, Richard Earnshaw >>> wrote: On 21/10/2020 17:11, Christophe Lyon via

[PATCH] c++: Don't purge the satisfaction caches

2020-10-27 Thread Patrick Palka via Gcc-patches
The adoption of P2104 means we can memoize the result of satisfaction indefinitely and no longer have to clear the satisfaction caches on various events that would affect satisfaction. To that end, this patch removes clear_satisfaction_cache and adjusts its callers appropriately. This provides a

c++: Small cleanup for do_type_instantiation

2020-10-27 Thread Nathan Sidwell
In working on a bigger cleanup I noticed some opportunities to make do_type_instantiation's control flow simpler. gcc/cp/ * parser.c (cp_parser_explicit_instantiation): Refactor some RAII. * pt.c (bt_instantiate_type_proc): DATA is the tree, pass type to do_type_in

Re: [PATCH] tree-optimization/97428 - split SLP groups for loop vectorization

2020-10-27 Thread Richard Sandiford via Gcc-patches
Sorry for the very late comment (was out last week)… Richard Biener writes: > This enables SLP store group splitting also for loop vectorization. > For the existing testcase gcc.dg/vect/vect-complex-5.c this then > generates much better code, likewise for the PR97428 testcase. > > Both of those h

Re: [PATCH] Selectively trap if ranger and vr-values disagree on range builtins.

2020-10-27 Thread Aldy Hernandez via Gcc-patches
For the record, this is what I envision the follow-up patch to be (untested). Aldy diff --git a/gcc/vr-values.c b/gcc/vr-values.c index 9f5943a1ab6..3db72a360a6 100644 --- a/gcc/vr-values.c +++ b/gcc/vr-values.c @@ -1159,188 +1159,16 @@ check_for_binary_op_overflow (range_query *query, succes

Re: [PATCH 1/2] arm: Avoid indirection with -mpure-code on v6m (PR96967)

2020-10-27 Thread Richard Earnshaw via Gcc-patches
On 28/09/2020 10:09, Christophe Lyon via Gcc-patches wrote: > With -mpure-code on v6m (thumb-1), to avoid a useless indirection when > building the address of a symbol, we want to consider SYMBOL_REF as a > legitimate constant. This way, we build the address using a series of > upper/lower relocati

Re: [PATCH][middle-end][i386][Version 4] Add -fzero-call-used-regs=[skip|used-gpr-arg|used-arg|all-arg|used-gpr|all-gpr|used|all]

2020-10-27 Thread Qing Zhao via Gcc-patches
Uros, The following is the change compared to version 4 after fix all the issues you raised in the previous email. Let me know if there is any other issue. Thanks. Qing --- gcc/config/i386/i386.c | 162 + .../gcc.target/i386/zero-scratch-regs-2

Re: [PATCH 2/2] arm: Improve handling of relocations with small offsets with -mpure-code on v6m (PR96770)

2020-10-27 Thread Richard Earnshaw via Gcc-patches
On 28/09/2020 10:09, Christophe Lyon via Gcc-patches wrote: > With -mpure-code on v6m (thumb-1), we can use small offsets with > upper/lower relocations to avoid the extra addition of the > offset. > > This patch accepts expressions symbol+offset as legitimate constants > when the literal pool is

[committed] libstdc++: Remove unused variables in special functions

2020-10-27 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/tr1/ell_integral.tcc (__ellint_rf, __ellint_rd) (__ellint_rc, __ellint_rj): Remove unused variables. * include/tr1/modified_bessel_func.tcc (__airy): Likewise. Tested x86_64-linux. Committed to trunk. commit 86558afc09e65b172377d4e759b000

  1   2   >