> On 10/27/20 11:29 AM, Jan Hubicka wrote: > > Looks reasonable, but I do not like very much the non-configurable > > preallocation since libgcov was meant to be useful for embedded targets > > and not consume too much. > > Sure, we can handle that later when it's really an issue. > > > I guess we could handle that incrementally, > > how the llvm's option for preallocated pool size is implemented? > > It basically pre-allocates N counters for TOPN counter per call site. > I'm going to install the patch and we'll see.
I see, not very pretty either. I think it would make more sense to gave global preallocated array but of configurable size which can probably be arranged by putting it to comdat, but it is bit tricky. Honza > > Thanks, > Martin >
