Re: [PATCH] Treat { 0 } specially for structs with the designated_init attribute.

2020-06-03 Thread Asher Gordon via Gcc-patches
Hello, I accidentally wrote 'free(loc)' instead of 'free (loc)'. Please see the fixed patch attached below (contrib/check_GNU_style.sh says it's OK now): From 0445fba96ee9030feb00ebec893f8dfed153b12d Mon Sep 17 00:00:00 2001 From: Asher Gordon Date: Wed, 3 Jun 2020 17:20:08 -0400 Subject: [PATCH]

Re: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-03 Thread Hao Liu OS via Gcc-patches
Hi All, The patch is refactored a little according to the last comment. Do you have more comments? If no, I will commit it later. Tested on X86_64 and AArch64. gcc/: PR tree-optimization/89430 * tree-ssa-phiopt.c (cond_store_replacement): Extend non-trap checking to sup

Re: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-03 Thread Jakub Jelinek via Gcc-patches
On Thu, Jun 04, 2020 at 04:47:43AM +, Hao Liu OS wrote: > The patch is refactored a little according to the last comment. Do you have > more comments? If no, I will commit it later. > > Tested on X86_64 and AArch64. > > gcc/: > > PR tree-optimization/89430 > * tree-ssa-phiop

[PATCH] Fix typo in expander trunc2 [AVX512]

2020-06-03 Thread Hongtao Liu via Gcc-patches
This patch to is fix uppercase of mode in trunc2, it should be lowercase for standard pattern name. Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog: * config/i386/sse.md (pmov_dst_3_lower): New mode attribute. (trunc2): Refine from trunc2. g

Re: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-03 Thread Hao Liu OS via Gcc-patches
Hi Jakub, I've updated the incorrect ChangLog. gcc/: PR tree-optimization/89430 * tree-ssa-phiopt.c (struct name_to_bb): Rename to ref_to_bb; add a new field exp; remove ssa_name_ver, store, offset fields. (struct ssa_names_hasher): Rename to refs_hasher;

Re: [PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-03 Thread Richard Biener
On Thu, 4 Jun 2020, Hongtao Liu wrote: > Hi Richard: > Could you help review this patch. > uros said he wouldn't review patches related to x86 vector ISA anymore. I can't spot anything wrong but I know nothing about what a define_subst is. You say "Bootstrap is ok, regression test on i386/x8

Re: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-03 Thread Jakub Jelinek via Gcc-patches
Hi! The usual way to write it would be: On Thu, Jun 04, 2020 at 06:17:13AM +, Hao Liu OS wrote: > gcc/: > > PR tree-optimization/89430 > * tree-ssa-phiopt.c > (struct name_to_bb): Rename to ref_to_bb; add a new field exp; > remove ssa_name_ver, store, offset fi

Re: [PATCH] extend cselim to check non-trapping for more references (PR tree-optimizaton/89430)

2020-06-03 Thread Richard Biener
On Thu, 4 Jun 2020, Hao Liu OS wrote: > Hi Jakub, > > I've updated the incorrect ChangLog. > > gcc/: > > PR tree-optimization/89430 > * tree-ssa-phiopt.c > (struct name_to_bb): Rename to ref_to_bb; add a new field exp; > remove ssa_name_ver, store, offset fields

Re: [PATCH V2 1/2] Introduce flag_cunroll_grow_size for cunroll

2020-06-03 Thread Richard Biener via Gcc-patches
On Thu, Jun 4, 2020 at 5:34 AM Jiufu Guo wrote: > > Jiufu Guo writes: > > Hi, > > Patch is updated a little according to comments. > Please see if this is ok to commit. OK with a proper ChangeLog after bootstrap / testing. It's also OK to backport this to the GCC 10 branch if powerpc folks want

Re: [PATCH] Fix typo in expander trunc2 [AVX512]

2020-06-03 Thread Richard Biener via Gcc-patches
On Thu, Jun 4, 2020 at 8:09 AM Hongtao Liu via Gcc-patches wrote: > > This patch to is fix uppercase of mode in trunc2, it > should be lowercase for standard pattern name. > > Bootstrap is ok, regression test on i386/x86-64 backend is ok. OK. Richard. > gcc/ChangeLog: > * config/i386/

Re: [PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-03 Thread Hongtao Liu via Gcc-patches
On Thu, Jun 4, 2020 at 2:43 PM Richard Biener wrote: > > On Thu, 4 Jun 2020, Hongtao Liu wrote: > > > Hi Richard: > > Could you help review this patch. > > uros said he wouldn't review patches related to x86 vector ISA anymore. > > I can't spot anything wrong but I know nothing about what a >

<    1   2